87265 Commits

Author SHA1 Message Date
engine-flutter-autoroll
3dafc64ba7
Roll Skia from deb0153719dd to d570e2317110 (2 revisions) (#179734)
https://skia.googlesource.com/skia.git/+log/deb0153719dd..d570e2317110

2025-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 50c5f8b4dd57 to f23836d62fa0 (5 revisions)
2025-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from c2a048f9a1db to 92d454d83328 (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-11 13:21:46 +00:00
engine-flutter-autoroll
c6f7f2c969
Roll Dart SDK from dbcb567e2432 to 3d4b989bdc41 (1 revision) (#179733)
https://dart.googlesource.com/sdk.git/+log/dbcb567e2432..3d4b989bdc41

2025-12-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-233.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-11 13:09:44 +00:00
engine-flutter-autoroll
7f0e5b5031
Roll Fuchsia Linux SDK from u5vxWTRT0HlxOP5_r... to QssSL8DkxIbMvf89C... (#179729)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-11 09:53:30 +00:00
engine-flutter-autoroll
d94c0e94da
Roll Skia from 59c6cad539f7 to deb0153719dd (2 revisions) (#179721)
https://skia.googlesource.com/skia.git/+log/59c6cad539f7..deb0153719dd

2025-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 9e1721615b33 to f39150de4906 (8 revisions)
2025-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 492dfbfe3bb2 to 6cd15cab2194 (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-11 07:04:27 +00:00
engine-flutter-autoroll
0c6af9d662
Roll Dart SDK from 077062c5e515 to dbcb567e2432 (2 revisions) (#179715)
https://dart.googlesource.com/sdk.git/+log/077062c5e515..dbcb567e2432

2025-12-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-232.0.dev
2025-12-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-231.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-11 03:28:26 +00:00
b-luk
811a4d22e6
Use kPreventOverdraw for arcs with overlapping stroke caps (#179312)
Fixes #178746

Before:
<img width="341" height="527" alt="image"
src="https://github.com/user-attachments/assets/b2458490-109f-4e6f-b35d-3bc0e5648de6"
/>

After:
<img width="295" height="566" alt="image"
src="https://github.com/user-attachments/assets/f5958934-dae2-4181-b142-9c68f8cdc2e8"
/>


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-12-11 01:14:23 +00:00
engine-flutter-autoroll
ab089c0e2c
Roll Skia from e61cc6d073fd to 59c6cad539f7 (22 revisions) (#179714)
https://skia.googlesource.com/skia.git/+log/e61cc6d073fd..59c6cad539f7

2025-12-10 bungeman@google.com Modernize
SkFontMgr_Mac::onMatchFamilyStyleCharacter
2025-12-10 kylechar@google.com Upgrade gradle to version 9.1.0
2025-12-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 9f7342ee3761 to 50c5f8b4dd57 (8 revisions)
2025-12-10 bungeman@google.com Revert "Pass first family name to
paragraph fallback"
2025-12-10 kjlubick@google.com Revert "[rust bmp] Add initial Rust BMP
decoder implementation"
2025-12-10 bungeman@google.com Roll HarfBuzz from 08b52ae2 to 31695252
(971 commits)
2025-12-10
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-12-10 sergiog@microsoft.com [rust bmp] Add initial Rust BMP decoder
implementation
2025-12-10 bungeman@google.com Pass first family name to paragraph
fallback
2025-12-10 kjlubick@google.com Update CanvasKit to use const version of
SerialProcs
2025-12-10 kjlubick@google.com Remove legacy SkParagraphBuilder API
2025-12-10 michaelludwig@google.com [wgsl] Stop forcing all function
calls into scratch lets
2025-12-10 michaelludwig@google.com [ganesh] Guard division by zero in
AAConvexPathRenderer
2025-12-10 nicolettep@google.com [graphite] Use depth/stencil image
aspects for default d/s attachments
2025-12-10 nscobie@google.com Make SkDebugf calls log at Android's WARN
level in RenderEngine
2025-12-10 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from 57fca18a1603 to 9e1721615b33 (7 revisions)
2025-12-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 3486579f434a to 9f7342ee3761 (5 revisions)
2025-12-10
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-12-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 78bb5a33a9e9 to c2a048f9a1db (7 revisions)
2025-12-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from ca3eb8741f18 to 492dfbfe3bb2 (10 revisions)
2025-12-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 8de9b80c5bd9 to 57fca18a1603 (17 revisions)
2025-12-10
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-11 00:51:37 +00:00
zhongliugo
2a950efec4
Reland: Add framework-side hitTestBehavior support to Semantics (#178817) (#179352)
This is a reland of #178817, which was reverted in #179100 due to test
failures.

The original PR introduced `hitTestBehavior` to the semantics framework
but incorrectly applied `opaque` behavior to `ModalRoute`, which blocked
platform views from receiving pointer events.

Instead of making the entire modal opaque, we:
1. Keep `ModalRoute` without explicit `hitTestBehavior` (defaults to
`defer`)
2. Make only the dialog/sheet content opaque (blocks clicks to barrier)
3. Platform views remain clickable because they're outside the opaque
content boundary

Fixes #149001
Original PR: #177570
Revert: #178744
2025-12-10 22:31:02 +00:00
Jason Simmons
e25d71b086
Ensure that the engine converts std::filesystem::path objects to UTF-8 strings on Windows (#179528)
Fixes https://github.com/flutter/flutter/issues/178896

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2025-12-10 21:39:24 +00:00
yim
8fe76181e3
Fix the issue with pinned headers in nested SliverMainAxisGroup. (#179132)
Fixes: #178973

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-12-10 21:11:40 +00:00
akashefrath
aaafeaf18d
added onUserInteractionIfError for form (#175515)
This PR adds a new `AutovalidateMode` value:  
`onUserInteractionIfError`.

This mode allows `Form` and `FormField` widgets to auto-validate **only
when a field already has an error and the user interacts with it
again**.

### Why
- Current modes (`disabled`, `always`, `onUserInteraction`, `onUnfocus`)
do not cover the case where developers want validation **only when
correcting an error**.
- This improves UX by reducing unnecessary validation calls while still
ensuring errors disappear as soon as the user fixes them.

### How
- Added `onUserInteractionIfError` to `AutovalidateMode`.  
- Updated Dartdoc with detailed description and example snippet.  
- Added new unit tests to validate behavior.  
- Verified no regressions in other modes (`always`, `onUnfocus`,
`onUserInteraction`).

### Example

```dart
TextFormField(
  autovalidateMode: AutovalidateMode.onUserInteractionIfError,
  validator: (value) => value!.isEmpty ? 'Required field' : null,
)
````

---

## Related Issues

Fixes #\<INSERT\_RELATED\_ISSUE\_NUMBER\_IF\_ANY>

---

## Tests

* Added widget tests to confirm that:

  * No validation occurs until a field has an error.
* Once an error exists, validation runs automatically on user
interaction.
  * Resetting the form clears errors correctly.
* Regression tests ensure that `always`, `onUserInteraction`, and
`onUnfocus` modes still behave correctly.

---

## Pre-launch / Reviewer Checklist

* [x] I have read the [[Contributor
Guide](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md)](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md)
* [x] I have read the \[Tree Hygiene] wiki page and followed its
guidance
* [x] I have read and followed the \[Flutter Style Guide]
* [x] I signed the \[CLA]
* [x] I added a new enum value with clear Dartdoc
(`onUserInteractionIfError`)
* [x] I added example code in the Dartdoc
* [x] I added new widget/unit tests for the new mode
* [x] All existing and new tests pass
* [x] I ran `flutter analyze` and fixed all issues
* [x] No breaking changes introduced (or marked accordingly)

---

## Breaking Change

* [x] Yes
* [x] No

---

## Screenshots / Demo (if applicable)

*(N/A — logic-only change)*

---

## Reviewer Notes

* The new mode reduces unnecessary validation until the user corrects an
error.
* All tests confirm correct behavior and no regressions in existing
modes.

---------

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
2025-12-10 20:57:38 +00:00
Pacific
2c4e7ebfd9
Fixed RenderFlex overflow in RouteObserver Example (#170980)
Fixed RenderOverflow in RouteObserver Example:
https://api.flutter.dev/flutter/widgets/RouteObserver-class.html

<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

This PR is about solving render overflow issue in Route Observer Example
in Live Website. I've wrapped the body with a Scrollable View to solve
this issue

| | |
| --- | --- |
| B |
![image](https://github.com/user-attachments/assets/c8fa78e7-62ca-4bd1-9798-588c636cd61a)
|
| A |
![image](https://github.com/user-attachments/assets/3a2b4697-121a-43e3-9c85-b1379a575af1)
|

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.


<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-12-10 20:53:33 +00:00
engine-flutter-autoroll
f8b88be694
Roll Dart SDK from 17749965ec57 to 077062c5e515 (3 revisions) (#179691)
https://dart.googlesource.com/sdk.git/+log/17749965ec57..077062c5e515

2025-12-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-230.0.dev
2025-12-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-229.0.dev
2025-12-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-228.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-10 18:29:02 +00:00
Roman Laptev
9cc43f13a5
Manually roll characters (#179447)
Flutter pub roller does not update characters to 1.4.1.
#179495 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-12-10 18:15:09 +00:00
engine-flutter-autoroll
545b8c33ed
Roll Packages from 338ecd3864b8 to 74a5a5314f5c (4 revisions) (#179693)
338ecd3864...74a5a5314f

2025-12-10 47866232+chunhtai@users.noreply.github.com [ci] Rewrites
branch exists without external dependencies (flutter/packages#10594)
2025-12-10 61003485+BottlePumpkin@users.noreply.github.com [rfw] Add
Flexible widget support to core widgets (flutter/packages#9750)
2025-12-09 matt.boetger@gmail.com Redistribute package ownership among
Android team (flutter/packages#10569)
2025-12-09 10687576+bparrishMines@users.noreply.github.com
[camera_android_camerax] Updates pigeon generation to prevent crash when
objects call to Dart after a hot restart (flutter/packages#10571)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-10 18:03:56 +00:00
Flutter GitHub Bot
8147c3ab3c
Marks Mac_ios draw_arcs_all_stroke_styles_perf_ios__timeline_summary to be unflaky (#179669)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_ios draw_arcs_all_stroke_styles_perf_ios__timeline_summary"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20draw_arcs_all_stroke_styles_perf_ios__timeline_summary%22).
This test can be marked as unflaky.
2025-12-10 17:14:10 +00:00
Jason Simmons
5b74a3b8e8
Check for a null cached image in SingleFrameCodec::getNextFrame (#179483)
This could happen if the image decoder invoked its callback with a null
image to signal an error. The SingleFrameCodec's status will be
kComplete but its cached image will not be set.

Fixes https://github.com/flutter/flutter/issues/161031
2025-12-10 16:07:39 +00:00
engine-flutter-autoroll
6519f99911
Roll Fuchsia Linux SDK from _pSztGZvEA3-Ry-GW... to u5vxWTRT0HlxOP5_r... (#179652)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-10 05:18:27 +00:00
Robert Ancell
08e88c0973
Implement flutter/accessibility channel (#179484)
Fixes https://github.com/flutter/flutter/issues/172023
2025-12-10 03:44:19 +00:00
engine-flutter-autoroll
79e2ca2b04
Roll Skia from 82fff05cc621 to e61cc6d073fd (4 revisions) (#179646)
https://skia.googlesource.com/skia.git/+log/82fff05cc621..e61cc6d073fd

2025-12-09
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-12-09
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-12-09 vigneshv@google.com SkCrabbyAvifCodec: Disable sample
transforms
2025-12-09 bungeman@google.com Roll FreeType from 1518bc83 to 30e45abe
(119 commits)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-10 01:21:32 +00:00
Ahmed Mohamed Sameh
b0801721b3
Make sure that a CupertinoDialogAction doesn't crash in 0x0 environment (#178956)
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
CupertinoDialogAction widget.

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-12-10 00:41:29 +00:00
Matt Boetger
90ebc1d261
Make SettingsChannel configuration queue not static (#179636)
SettingsChannel has a static data structure that stores system
configurations. This is fine if there is one engine. If there are two
FlutterViews and two engines - this static configuration is shared
between the two different engines. Because of the way the queue deletes
old entries this will result in one engine missing it's configuration.

Fixes: #179559

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
2025-12-10 00:28:40 +00:00
Ahmed Mohamed Sameh
5266539cfb
Make sure that a CupertinoListSection doesn't crash in 0x0 environment (#179068)
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
CupertinoListSection widget.

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-12-10 00:26:59 +00:00
Ahmed Mohamed Sameh
4e113f9420
Make sure that a CupertinoFormSection doesn't crash in 0x0 environment (#179001)
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
CupertinoFormSection widget.

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-12-10 00:25:49 +00:00
Ahmed Mohamed Sameh
410a0dda2b
Make sure that a CupertinoMagnifier doesn't crash in 0x0 environment (#179206)
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
CupertinoMagnifier widget.

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-12-10 00:24:35 +00:00
Ahmed Mohamed Sameh
50ffc5044e
Make sure that a Tooltip doesn't crash in 0x0 environment (#178461)
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the Tooltip widget.

---------

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-12-10 00:23:57 +00:00
Ahmed Mohamed Sameh
41ff0598fe
Make sure that a CupertinoSegmentedControl doesn't crash in 0x0 envir… (#179544)
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
CupertinoSegmentedControl widget.
2025-12-10 00:22:36 +00:00
Ahmed Mohamed Sameh
4c24578e2b
Make sure that a CupertinoSlider doesn't crash in 0x0 environment (#179566)
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the CupertinoSlider
widget.
2025-12-10 00:22:36 +00:00
Ahmed Mohamed Sameh
6e611e04b7
Make sure that a CupertinoPageScaffold doesn't crash in 0x0 environment (#179245)
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
CupertinoPageScaffold widget.

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-12-10 00:22:36 +00:00
engine-flutter-autoroll
458dcfd70c
Roll Skia from f9e32c28c5c5 to 82fff05cc621 (2 revisions) (#179641)
https://skia.googlesource.com/skia.git/+log/f9e32c28c5c5..82fff05cc621

2025-12-09
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-12-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 4edb81c5d7c8 to 3486579f434a (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-09 23:16:29 +00:00
engine-flutter-autoroll
69f4b00217
Roll Dart SDK from 019cb923bf62 to 17749965ec57 (5 revisions) (#179640)
https://dart.googlesource.com/sdk.git/+log/019cb923bf62..17749965ec57

2025-12-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-227.0.dev
2025-12-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-226.0.dev
2025-12-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-225.0.dev
2025-12-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-224.0.dev
2025-12-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-223.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-09 22:34:13 +00:00
Mohellebi abdessalem
15f944a9d6
Enhance documentation for LocalHistoryEntry class (#179223)
Fixes : #11660

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-12-09 22:14:21 +00:00
Rusino
84b5f5372d
WebParagrah: ellipsis (#178748)
Part of https://github.com/flutter/flutter/issues/172561

---------

Co-authored-by: Mouad Debbar <mdebbar@google.com>
2025-12-09 22:09:10 +00:00
Lau Ching Jun
87f0f377b4
Update the doc on Google Testing to reflect the current state (#177187)
Also reformat the markdown file.
2025-12-09 21:46:57 +00:00
Jackson Gardner
e0f544bf62
[wimp] Initial Impeller on Web implementation. (#175442)
This PR adds an initial implementation of a impeller-based version of
skwasm. As of right now, the main things that are missing are:
* Image support https://github.com/flutter/flutter/issues/175371
* Custom shader support https://github.com/flutter/flutter/issues/175431
* Turn on MSAA https://github.com/flutter/flutter/issues/175441
* Multithreading is turned off
https://github.com/flutter/flutter/issues/178749

I plan on implementing these in smaller followup PRs.

Towards https://github.com/flutter/flutter/issues/174980
2025-12-09 20:50:23 +00:00
chunhtai
2e2d655be8
Relax assertion for adding semantics locale (#178140)
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

instead forcing a contain: true, uses isCompatibleWith to prevent
implicit merge

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-12-09 20:46:18 +00:00
Ramon Farizel
8cdb466a8a
Fix Scrollbar drag behavior (#179199)
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->


Updates `_canHandleScrollGestures()` to check if there's an actual
scrollable range (`maxScrollExtent > minScrollExtent`) instead of only
checking if `maxScrollExtent > 0.0`.


Fixes https://github.com/flutter/flutter/issues/178863

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
2025-12-09 20:24:24 +00:00
engine-flutter-autoroll
e1af0fecc5
Roll Skia from 502ee6f2a0d7 to f9e32c28c5c5 (6 revisions) (#179632)
https://skia.googlesource.com/skia.git/+log/502ee6f2a0d7..f9e32c28c5c5

2025-12-09
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-12-09 kjlubick@google.com Update pinned libpng version to 1.6.53
2025-12-09 kjlubick@google.com Replace _unlikely_ with SK_UNLIKELY etc
2025-12-09 michaelludwig@google.com [graphite] Move more strategy
IsSupported logic to RendererProvider
2025-12-09
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-12-09
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-09 20:20:09 +00:00
John Lilly
6a1f5b7f85
Fix - Semantics focus does not move outside viewport when moving up or down (#179480)
Fixes regression caused by PR
[#174374](https://github.com/flutter/flutter/pull/174374). SliverLists
are not scrolling with TalkBack. Update fixes the issue by adding the
ScrollView or HorizontalScrollView if the scroll actions are present.

Test code used: 

``` dart
import 'package:flutter/material.dart';

void main() => runApp(const MaterialApp(home: MyApp()));

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: CustomScrollView(
        slivers: <Widget>[
          const SliverAppBar(
            pinned: true,
            expandedHeight: 100.0,
            title: Text('Pinned Semantic Focus'),
            backgroundColor: Colors.blue,
          ),
          // The List
          SliverList(
            delegate: SliverChildBuilderDelegate((BuildContext context, int index) {
              return ListTile(title: Text('Item $index'), subtitle: const Text('Scroll down then navigate back up'));
            }, childCount: 50),
          ),
        ],
      ),
    );
  }
}

```


https://github.com/user-attachments/assets/a3780f6d-8e22-40b7-83eb-38bc406b8821

- Fixing #179450

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-12-09 18:56:10 +00:00
Ahmed Mohamed Sameh
981a39f551
Make sure that a CupertinoActionSheetAction doesn't crash in 0x0 envi… (#178955)
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
CupertinoActionSheetAction widget.

---------

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-12-09 17:32:06 +00:00
Ahmed Mohamed Sameh
af7b52181e
Make sure that a CupertinoPickerDefaultSelectionOverlay doesn't crash… (#179351)
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
CupertinoPickerDefaultSelectionOverlay widget.

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-12-09 17:30:04 +00:00
Ahmed Mohamed Sameh
6c7de50493
Make sure that a CupertinoExpansionTile doesn't crash in 0x0 environment (#178978)
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
CupertinoExpansionTile widget.

---------

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-12-09 17:28:05 +00:00
engine-flutter-autoroll
17797780cd
Roll Packages from 33a9a810b5a2 to 338ecd3864b8 (5 revisions) (#179625)
33a9a810b5...338ecd3864

2025-12-09 adsonpleal@gmail.com [shared_preferences_tool] Update
dependencies and fix deprecation (flutter/packages#10560)
2025-12-08 47866232+chunhtai@users.noreply.github.com [ci] Use manual
trigger for go_router_batch workflow for testing purp…
(flutter/packages#10475)
2025-12-08 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump camerax_version from 1.5.1 to 1.5.2 in
/packages/camera/camera_android_camerax/android (flutter/packages#10582)
2025-12-08 engine-flutter-autoroll@skia.org Roll Flutter from
5b8720312a94 to b2de367c41e0 (38 revisions) (flutter/packages#10587)
2025-12-08 10687576+bparrishMines@users.noreply.github.com
[camera_android_camerax] Removes internal native library Dart proxy
(flutter/packages#10536)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-09 16:17:22 +00:00
Kaylee Lubick
a4959f7544
[skia] Update SkSerialProcs to use new type (#179347)
This lets us eventually use the const SkData version added in
https://skia-review.googlesource.com/c/skia/+/1109339

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-12-09 14:15:15 +00:00
engine-flutter-autoroll
45896dd21b
Roll Skia from 895fa7417947 to 502ee6f2a0d7 (4 revisions) (#179617)
https://skia.googlesource.com/skia.git/+log/895fa7417947..502ee6f2a0d7

2025-12-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 4ccd968c8edc to 78bb5a33a9e9 (15 revisions)
2025-12-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from f875023015f9 to ca3eb8741f18 (10 revisions)
2025-12-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 23f08c798e68 to 8de9b80c5bd9 (13 revisions)
2025-12-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 8b33d336e1ab to 4edb81c5d7c8 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-09 11:40:27 +00:00
engine-flutter-autoroll
ccd3be9a2e
Roll Skia from 9f276dfa0bdc to 895fa7417947 (1 revision) (#179608)
https://skia.googlesource.com/skia.git/+log/9f276dfa0bdc..895fa7417947

2025-12-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 518a9f63228d to ff4435d3f92d (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-09 06:17:38 +00:00
Harry Terkelsen
8b7834766f
Remove unused optional argument in _followDiagnosticableChain (#179525)
Fixes a small warning that just started showing up in Dart analysis.

Here's an example failure:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze/115908/overview

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-12-09 00:59:30 +00:00
engine-flutter-autoroll
96c65251a6
Roll Dart SDK from 3c07646cdcb9 to 019cb923bf62 (1 revision) (#179595)
https://dart.googlesource.com/sdk.git/+log/3c07646cdcb9..019cb923bf62

2025-12-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-222.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-08 23:52:11 +00:00
Flutter GitHub Bot
55c56b9cd1
Marks Linux_mokey flutter_engine_group_performance to be flaky (#179115)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_mokey flutter_engine_group_performance"
}
-->
Issue link: https://github.com/flutter/flutter/issues/179114
2025-12-08 23:41:08 +00:00
engine-flutter-autoroll
25168af6e6
Roll Skia from 00e6fc407968 to 9f276dfa0bdc (3 revisions) (#179594)
https://skia.googlesource.com/skia.git/+log/00e6fc407968..9f276dfa0bdc

2025-12-08
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-12-08 michaelludwig@google.com [graphite] Use largest supported
sample count < max internal sample count
2025-12-08 kjlubick@google.com [bazel] Update Mac toolchain to Clang 22

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com,kjlubick@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-08 23:29:08 +00:00