Ben Konyi
3ce05fc3dd
Roll src/third_party/dart 94dd49cdb6..f546362691 (1 commits)
...
dart-lang/sdk@f546362691 [SDK] Adds dart2exe to create standalone executables.
2019-09-23 10:20:05 -07:00
skia-flutter-autoroll
6c36b9541a
Roll src/third_party/skia ab52a7a53db6..57ef68077574 (3 commits) ( flutter/engine#12396 )
...
https://skia.googlesource.com/skia.git/+log/ab52a7a53db6..57ef68077574
git log ab52a7a53db6..57ef68077574 --date=short --no-merges --format='%ad %ae %s'
2019-09-23 robertphillips@google.com Create a GrGpu::createBackendTexture choke point
2019-09-23 bsalomon@google.com Remove a few GrSurfaceProxy::config() usages
2019-09-23 brianosman@google.com Roll third_party/externals/angle2 6c4ff5ddab07..8be7a4c7f738 (12 commits)
Created with:
gclient setdep -r src/third_party/skia@57ef68077574
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=bungeman@google.com
2019-09-23 12:52:10 -04:00
Jaime Blasco
06914655b3
[Web] Implement dark mode support for web ( flutter/engine#12335 )
2019-09-23 09:42:20 -07:00
Ben Konyi
c5f31e9394
Roll src/third_party/dart 07f0bc0144..94dd49cdb6 (3 commits)
...
dart-lang/sdk@94dd49cdb6 [cfe] Add NullCheck expression node
dart-lang/sdk@96f1abdaca [pkg/testing] Replace top-level logging functions with an interface.
dart-lang/sdk@209180d280 Treat the case that the reported error location has length 0
2019-09-23 07:12:34 -07:00
skia-flutter-autoroll
f602b7bbc0
Roll src/third_party/skia 776d81525e7c..ab52a7a53db6 (1 commits) ( flutter/engine#12393 )
...
https://skia.googlesource.com/skia.git/+log/776d81525e7c..ab52a7a53db6
git log 776d81525e7c..ab52a7a53db6 --date=short --no-merges --format='%ad %ae %s'
2019-09-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
Created with:
gclient setdep -r src/third_party/skia@ab52a7a53db6
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=bungeman@google.com
2019-09-23 09:04:02 -04:00
skia-flutter-autoroll
9e8512ef11
Roll src/third_party/skia 5b4c0ee19b74..776d81525e7c (1 commits) ( flutter/engine#12392 )
...
https://skia.googlesource.com/skia.git/+log/5b4c0ee19b74..776d81525e7c
git log 5b4c0ee19b74..776d81525e7c --date=short --no-merges --format='%ad %ae %s'
2019-09-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 3243c3b11405..82de2e611e32 (463 commits)
Created with:
gclient setdep -r src/third_party/skia@776d81525e7c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=bungeman@google.com
2019-09-23 05:11:06 -04:00
Ben Konyi
3747e82d0d
Roll src/third_party/dart 60c2bb9f5b..07f0bc0144 (7 commits)
...
dart-lang/sdk@07f0bc0144 [vm/bytecode] More fixes for AOT compilation from bytecode
dart-lang/sdk@a683a5822f Consider '[]' and '[]=' as having the same base name '[]' for extensions.
dart-lang/sdk@73eb0ee4ae Mark pkg/modular_test/test/memory_pipeline_test slow (to compile) on dart2js
dart-lang/sdk@4c74b486af Re-adding dart sdk version comment
dart-lang/sdk@6066271811 Don't use Element.type in analyzer_plugin.
dart-lang/sdk@ad52d12953 [dart2js] New RTI: Don't try to instantiate a null function.
dart-lang/sdk@e2adba804b [vm, compiler] Further reduce alignment of Instructions.
2019-09-23 01:15:34 -07:00
skia-flutter-autoroll
ad64c063ac
Roll src/third_party/skia b4d60b5eda31..5b4c0ee19b74 (1 commits) ( flutter/engine#12390 )
...
https://skia.googlesource.com/skia.git/+log/b4d60b5eda31..5b4c0ee19b74
git log b4d60b5eda31..5b4c0ee19b74 --date=short --no-merges --format='%ad %ae %s'
2019-09-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader b6fa949c4539..1f89f58faeb8 (5 commits)
Created with:
gclient setdep -r src/third_party/skia@5b4c0ee19b74
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=bungeman@google.com
2019-09-23 01:23:00 -04:00
skia-flutter-autoroll
0e451754f5
Roll src/third_party/skia bd67d0035a80..b4d60b5eda31 (7 commits) ( flutter/engine#12389 )
...
https://skia.googlesource.com/skia.git/+log/bd67d0035a80..b4d60b5eda31
git log bd67d0035a80..b4d60b5eda31 --date=short --no-merges --format='%ad %ae %s'
2019-09-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version
2019-09-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps
2019-09-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-21 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps
2019-09-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
Created with:
gclient setdep -r src/third_party/skia@b4d60b5eda31
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=bungeman@google.com
2019-09-22 21:08:08 -04:00
skia-flutter-autoroll
166afd3755
Roll src/third_party/skia 942d69fa9d5f..bd67d0035a80 (1 commits) ( flutter/engine#12382 )
...
https://skia.googlesource.com/skia.git/+log/942d69fa9d5f..bd67d0035a80
git log 942d69fa9d5f..bd67d0035a80 --date=short --no-merges --format='%ad %ae %s'
2019-09-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
Created with:
gclient setdep -r src/third_party/skia@bd67d0035a80
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=brianosman@google.com
2019-09-22 15:40:45 -04:00
Yegor
064ca6bfb5
Add macOS testing support ( flutter/engine#12383 )
...
- Add support for macOS in `felt test`
- Set viewport so it does not depend on real device pixel density
2019-09-22 11:49:44 -07:00
Ben Konyi
5927a289b1
Roll src/third_party/dart ff0e8f8035..60c2bb9f5b (5 commits)
...
dart-lang/sdk@60c2bb9f5b [vm/fuzzer] Disable controlflow collections
dart-lang/sdk@7e68a0c95e Copy changes from f057e25 to sdk_nnbd.
dart-lang/sdk@a42a2412b4 [dart2js] Add JS-interop classes as supertypes of JavaScriptObject.
dart-lang/sdk@dd948188f7 [dart2js] Implement type relations for AnyType.
dart-lang/sdk@43cacafb51 Revert "[dartdevc] fix for const / overridden fields"
2019-09-20 19:11:09 -07:00
Ben Konyi
367b0cb912
Roll src/third_party/dart 70a1e8e090..ff0e8f8035 (18 commits)
...
dart-lang/sdk@ff0e8f8035 Make extension methods more readable on dart2js stacktraces
dart-lang/sdk@3f8c7e5fa2 [cfe] Refactor local and read-only compound assignments
dart-lang/sdk@771e0f7d32 [cfe] Refactor local and read-only if null assignments
dart-lang/sdk@5997ea4d73 [cfe] Make buildSimpleRead and buildAssignment abstract
dart-lang/sdk@68b1a2e7bd [cfe] Refactor super index access
dart-lang/sdk@1e24146dab [cfe] Refactor this indexed access
dart-lang/sdk@729099cc5b [ VM ] Update embedding API to perform Platform initialization
dart-lang/sdk@2cebdaae2c Update MockSdk to support unsafe_html lint.
dart-lang/sdk@125ed45eff [vm] Fix ResolveDynamicAnyArgs to avoid returning incorrect method extractor
dart-lang/sdk@db035f39cf Remove some uses of 'type' and substitute2() it types.
dart-lang/sdk@56913c2555 Changing val to accommodate double values
dart-lang/sdk@2b4a84efd0 Revert "[vm/compiler] Drop redundant initializing stores of null"
dart-lang/sdk@ff778d1cb4 [bazel] Sort certain things when compiling in incremental mode (take 2)
dart-lang/sdk@96b8401cfc [vm/compiler] Drop redundant initializing stores of null
dart-lang/sdk@8b4d89e03c [gardening] Mark FFI tests on Android as slow
dart-lang/sdk@2b16ae1b54 [gardening] Fix unguarded uses of CompileType::ToSExpression.
dart-lang/sdk@469863ded7 Fix bug in static extension member test.
dart-lang/sdk@99713209c4 [CFE] Fix issue with cached calculations and recording dependencies
2019-09-20 16:09:05 -07:00
skia-flutter-autoroll
d66d7632dd
Roll src/third_party/skia 2e29ab5b03aa..942d69fa9d5f (6 commits) ( flutter/engine#12378 )
...
https://skia.googlesource.com/skia.git/+log/2e29ab5b03aa..942d69fa9d5f
git log 2e29ab5b03aa..942d69fa9d5f --date=short --no-merges --format='%ad %ae %s'
2019-09-20 ethannicholas@google.com Revert "Fixed GLSL ES compilation error in GLTestAtlasTextRenderer"
2019-09-20 ethannicholas@google.com Fixed GLSL ES compilation error in GLTestAtlasTextRenderer
2019-09-20 bsalomon@google.com Check for scratch textures in GrResourceProvider.
2019-09-20 kjlubick@google.com [canvaskit] add support for SkAnimatedImage
2019-09-20 brianosman@google.com Use makeRenderTargetContextWithFallback when creating devices for layers
2019-09-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
Created with:
gclient setdep -r src/third_party/skia@942d69fa9d5f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=brianosman@google.com
2019-09-20 15:33:45 -07:00
Yegor
e08ce018a4
Store screenshot test output as Cirrus artifacts; do fuzzy comparison of non-matching screenshot pixels ( flutter/engine#12274 )
...
- Store screenshot test output as Cirrus artifacts
- Do fuzzy comparison of non-matching screenshot pixels
- Make screenshot tests fail on Cirrus
2019-09-20 14:46:00 -07:00
gaaclarke
1cad708800
Added unit tests for method channels. ( flutter/engine#12373 )
...
Added unit tests for method channels.
2019-09-20 14:25:56 -07:00
Jason Simmons
4be4458ed0
Roll Wuffs to 0.2.0-alpha.47 ( flutter/engine#12376 )
2019-09-20 13:03:31 -07:00
Dan Field
128398be60
Sync dart_runner ( flutter/engine#12375 )
2019-09-20 12:58:08 -07:00
skia-flutter-autoroll
bef7c8f84d
Roll src/third_party/skia ffdc3e668061..2e29ab5b03aa (12 commits) ( flutter/engine#12374 )
...
https://skia.googlesource.com/skia.git/+log/ffdc3e668061..2e29ab5b03aa
git log ffdc3e668061..2e29ab5b03aa --date=short --no-merges --format='%ad %ae %s'
2019-09-20 brianosman@google.com added support for user-defined functions to GrSKSLFP
2019-09-20 robertphillips@google.com Remove a usage of GrPixelConfig in SkGpuBlurUtils::GaussianBlur (take 2)
2019-09-20 ethannicholas@google.com Revert "added support for SkSL unpremul function"
2019-09-20 vasilyt@chromium.org Added missed ETC2 case to GrVkFormatColorTypePairIsValid
2019-09-20 reed@google.com call Graphics Init() to get faster asm
2019-09-20 brianosman@google.com Reland "Use saveLayer-determined CT in SkGpuDevice::onCreateDevice"
2019-09-20 ethannicholas@google.com regenerated fragment processors to make bot happy
2019-09-20 brianosman@google.com Revert "Use saveLayer-determined CT in SkGpuDevice::onCreateDevice"
2019-09-20 nifong@google.com Added functions supporting a resource view for images in the debugger.
2019-09-20 brianosman@google.com Use saveLayer-determined CT in SkGpuDevice::onCreateDevice
2019-09-20 brianosman@google.com Run gn format
2019-09-20 brianosman@google.com Use 64 bit shift to make MSVC happy
Created with:
gclient setdep -r src/third_party/skia@2e29ab5b03aa
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=brianosman@google.com
2019-09-20 14:10:16 -04:00
Ben Konyi
8b3d27e8ff
Roll src/third_party/dart 7c1821c4aa..70a1e8e090 (52 commits)
...
dart-lang/sdk@70a1e8e090 [cfe] Fix handling of access on type variables with dynamic bound
dart-lang/sdk@5645cc64f5 [vm/compiler] Fix mismatches in early round trip.
dart-lang/sdk@36c3eccc11 [CFE] Fix issue with exports and recording dependencies
dart-lang/sdk@fae7d07fbc [ VM / Profiler ] Add --sample-buffer-duration flag to specify sample buffer size
dart-lang/sdk@7367b6f192 fix for MISSING_CONST_FINAL_VAR_OR_TYPE
dart-lang/sdk@0051da7f55 [nnbd] change modular nnbd test to enable non-nullable for sdk
dart-lang/sdk@65078b5ee8 Stop using DynamicElementImpl/NeverElementImpl.type getter/setter.
dart-lang/sdk@07922810b2 Remove writes to TypeParameterElement.type.
dart-lang/sdk@8d2045f336 Remove ResolutionEraser.
dart-lang/sdk@4c666569b5 Reland "[fuchsia] migrate from ioctls to FIDL"
dart-lang/sdk@97346ff476 Initial migration i13n HTML output
dart-lang/sdk@fd7e337dd6 [vm] Update wasmer and resolve a TODO.
dart-lang/sdk@5aafee5196 [vm/fuzzer] Fix Analyser
dart-lang/sdk@9cea50c0ca Use Substitution for type arguments validation.
dart-lang/sdk@b26636925d [vm, compiler] Reduce alignment of Instructions and remove some debugging trap instructions.
dart-lang/sdk@dcd5cd13fb Prepare to publish analyzer version 0.38.3.
dart-lang/sdk@ccd19cd94d [vm/fuzzer] Decrease collection size
dart-lang/sdk@e88057fe04 Add non-NNBD language version marker on all sdk_nnbd files.
dart-lang/sdk@34253ce388 [dart2js] New RTI: Treat JavaScriptFunction as subtype of all function types.
dart-lang/sdk@544915e0c1 [vm/bytecode] Initial support for AOT compilation from bytecode
dart-lang/sdk@b2a9dc16ec [vm/fuzzer] Allow no recursion within collections
dart-lang/sdk@f8f54c883b check for existing asserts before suggesting to add one
dart-lang/sdk@892386ad22 Don't use ClassElement.type many places in analyzer.
dart-lang/sdk@9ed45651a9 [cfe] Refactor super expressions
dart-lang/sdk@5081eb15ee [cfe] Refactor handling of static if-null assignment
dart-lang/sdk@f018ce0355 [cfe] Refactor handling of static get/set/compound
dart-lang/sdk@dc211c3f9d [cfe] Refactoring handling of compound index set
dart-lang/sdk@604f443285 [cfe] Refactor handling of if-null index assignment
dart-lang/sdk@54c2dd737f [cfe] Refactor handling of index and index-set
dart-lang/sdk@c7a083ee5a [cfe] Refactor handling of ++/--
dart-lang/sdk@c2f35df918 [cfe] Refactor handling of compound local/property assignment
dart-lang/sdk@40d75d733b [cfe] Refactor if-null and null-aware property access
dart-lang/sdk@342b48bd27 Remove unused import
dart-lang/sdk@396fec7cfb Use DriverResolutionTest directly, without ResolutionTest mixins.
dart-lang/sdk@000de948fa add test for 38091
dart-lang/sdk@596bd5b61c [dartdevc] Add modular NNBD test
dart-lang/sdk@f6883ff726 Don't use ClassElement.type in summary2.
dart-lang/sdk@9da8472e2d Don't use ClassElement.type in nnbd_migration.
dart-lang/sdk@f7472249a2 Remove EnumMemberBuilder.
dart-lang/sdk@605384dbe7 Migration: Add `nullability_migration_impl_test.dart` to test_all
dart-lang/sdk@6e4794a584 [kernel] Clone all co-defined type parameters before visiting them.
dart-lang/sdk@31996aa24f [vm/bytecode] Enable bytecode compiler by default in Dart SDK
dart-lang/sdk@23def0da02 Migration: add support for assert initializers.
dart-lang/sdk@8ffe04bcf7 Migration: integrate flow analysis for "is" checks.
dart-lang/sdk@a85b7cef95 Migration: Add support for for-each loop variables.
dart-lang/sdk@3fa2bbf202 [cfe] Fix incorrect const contexts.
dart-lang/sdk@515a597710 [cfe] Remove Class.rawType
dart-lang/sdk@b0f7cba35e [VM] Kernel service dill should not include full paths
dart-lang/sdk@cdcec63569 [bazel] Sort certain things when compiling in incremental mode
dart-lang/sdk@37111633be [DDK] SDK should not contain full paths
dart-lang/sdk@740c72e251 [kernel] Mark class as non-dirty after computeCanonicalNames is run
dart-lang/sdk@2a94546f94 Fix flutter-frontend bot and future problems in flutter HHH bot
2019-09-20 09:45:57 -07:00
David Iglesias
0c2c7cfd15
Add web engine screenshot (scuba) tests ( flutter/engine#12353 )
...
* Import all golden files and tests from internal repo.
* Adapt test files to new screenshot API, and tweak some settings.
(Check PR to see individual changes to each file)
Fixes https://github.com/flutter/flutter/issues/40975
2019-09-20 09:00:55 -07:00
skia-flutter-autoroll
f6081ed304
Roll src/third_party/skia 9a9841178078..ffdc3e668061 (1 commits) ( flutter/engine#12369 )
...
https://skia.googlesource.com/skia.git/+log/9a9841178078..ffdc3e668061
git log 9a9841178078..ffdc3e668061 --date=short --no-merges --format='%ad %ae %s'
2019-09-20 ethannicholas@google.com added support for SkSL unpremul function
Created with:
gclient setdep -r src/third_party/skia@ffdc3e668061
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=brianosman@google.com
2019-09-20 10:23:54 -04:00
skia-flutter-autoroll
406558f67b
Roll src/third_party/skia be0d7dfa6194..9a9841178078 (2 commits) ( flutter/engine#12368 )
...
https://skia.googlesource.com/skia.git/+log/be0d7dfa6194..9a9841178078
git log be0d7dfa6194..9a9841178078 --date=short --no-merges --format='%ad %ae %s'
2019-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 bf4268a3963b..6c4ff5ddab07 (8 commits)
2019-09-20 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps
Created with:
gclient setdep -r src/third_party/skia@9a9841178078
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=brianosman@google.com
2019-09-20 05:24:42 -04:00
skia-flutter-autoroll
07acdaab94
Roll src/third_party/skia e5b65d212bca..be0d7dfa6194 (3 commits) ( flutter/engine#12367 )
...
https://skia.googlesource.com/skia.git/+log/e5b65d212bca..be0d7dfa6194
git log e5b65d212bca..be0d7dfa6194 --date=short --no-merges --format='%ad %ae %s'
2019-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src b8149cbe28ad..3243c3b11405 (453 commits)
2019-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e9b6f28fdd71..b6fa949c4539 (2 commits)
2019-09-20 mtklein@google.com raster 8888 pow2 samples hack
Created with:
gclient setdep -r src/third_party/skia@be0d7dfa6194
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=brianosman@google.com
2019-09-20 01:35:57 -04:00
liyuqian
56bb40c017
Revert "Reland "Smooth out iOS irregular input events delivery ( #11817 )" ( #12280 )" ( flutter/engine#12364 )
...
This reverts commit dedf24e797d6257f9bb776cdf0d7525a16610321.
Reason: flutter/flutter#40863
TBR: chinmaygarde, iskakaushik
2019-09-19 19:39:36 -07:00
skia-flutter-autoroll
4054ea63df
Roll src/third_party/skia f47717ad8cc7..e5b65d212bca (4 commits) ( flutter/engine#12366 )
...
https://skia.googlesource.com/skia.git/+log/f47717ad8cc7..e5b65d212bca
git log f47717ad8cc7..e5b65d212bca --date=short --no-merges --format='%ad %ae %s'
2019-09-19 halcanary@google.com pdf-comparison and image_diff_metric tools
2019-09-19 robertphillips@google.com New proposed syntax for SkColorTypes
2019-09-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
Created with:
gclient setdep -r src/third_party/skia@e5b65d212bca
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=brianosman@google.com
2019-09-19 21:49:03 -04:00
Matt Carroll
fce67bf3a8
Fixes race condition that was reported internally. ( flutter/engine#12362 )
2019-09-19 16:36:17 -07:00
Siva
c5ac59ebee
 Roll src/third_party/dart 7c1821c4aa...ea969c358e ( flutter/engine#12339 )
...
* Roll src/third_party/dart 7c1821c4aa...ea969c358e (6 commits)
dart-lang/sdk@7c1821c4aa [NNBD/VM] Restructure VM patch files for the NNBD dart sdk split
dart-lang/sdk@0c23664c8f [vm/fuzzer] Reduce number of methods per class
dart-lang/sdk@3135eb569d [vm/bytecode] Fix initial scope in field initializers
dart-lang/sdk@1345fb80ac Use TypeParameterElement instead of TypeParameterType in inference.
dart-lang/sdk@430ff6d649 Migration: fix "matching" functionality of edge testing infrastructure.
dart-lang/sdk@f1bff1b512 Add option to run ddb with observatory
2019-09-19 16:07:34 -07:00
skia-flutter-autoroll
bed1fcbc51
Roll src/third_party/skia 9a8b846baf43..f47717ad8cc7 (7 commits) ( flutter/engine#12361 )
...
https://skia.googlesource.com/skia.git/+log/9a8b846baf43..f47717ad8cc7
git log 9a8b846baf43..f47717ad8cc7 --date=short --no-merges --format='%ad %ae %s'
2019-09-19 robertphillips@google.com Alter wacky_yuv_formats GM to skip rows if the required backing GPU format(s) aren't supported
2019-09-19 robertphillips@google.com Remove "experimental" comments regarding RG_F16 and RGBA_16161616
2019-09-19 mtklein@google.com stifle warning in tValue2Scalar()
2019-09-19 jvanverth@google.com Set up prototype interface for MakeFromCAMetalLayer
2019-09-19 robertphillips@google.com Revert "Remove a usage of GrPixelConfig in SkGpuBlurUtils::GaussianBlur"
2019-09-19 csmartdalton@google.com Use GrResourceProvider::MakeApprox for mask filter proxy sizes
2019-09-19 robertphillips@google.com Remove a usage of GrPixelConfig in SkGpuBlurUtils::GaussianBlur
Created with:
gclient setdep -r src/third_party/skia@f47717ad8cc7
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=brianosman@google.com
2019-09-19 15:03:42 -07:00
skia-flutter-autoroll
aee3d67a28
Roll src/third_party/skia 18531cde2ab7..9a8b846baf43 (1 commits) ( flutter/engine#12360 )
...
https://skia.googlesource.com/skia.git/+log/18531cde2ab7..9a8b846baf43
git log 18531cde2ab7..9a8b846baf43 --date=short --no-merges --format='%ad %ae %s'
2019-09-19 brianosman@google.com Particles: Sub-effect spawning and some slight refactoring
Created with:
gclient setdep -r src/third_party/skia@9a8b846baf43
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=brianosman@google.com
2019-09-19 12:02:03 -04:00
skia-flutter-autoroll
ddd6c46f76
Roll src/third_party/skia 6344cbd1df76..18531cde2ab7 (2 commits) ( flutter/engine#12358 )
...
https://skia.googlesource.com/skia.git/+log/6344cbd1df76..18531cde2ab7
git log 6344cbd1df76..18531cde2ab7 --date=short --no-merges --format='%ad %ae %s'
2019-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a7003d5fc306..bf4268a3963b (7 commits)
2019-09-19 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps
Created with:
gclient setdep -r src/third_party/skia@18531cde2ab7
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=brianosman@google.com
2019-09-19 05:27:48 -04:00
skia-flutter-autoroll
5a9ac4bfc7
Roll src/third_party/skia e2a903e18b59..6344cbd1df76 (3 commits) ( flutter/engine#12357 )
...
https://skia.googlesource.com/skia.git/+log/e2a903e18b59..6344cbd1df76
git log e2a903e18b59..6344cbd1df76 --date=short --no-merges --format='%ad %ae %s'
2019-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src b1c1d2844bd1..b8149cbe28ad (423 commits)
2019-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 61a2765940a7..e9b6f28fdd71 (3 commits)
2019-09-19 mtklein@google.com fold srcover coverage with SkVMBlitter
Created with:
gclient setdep -r src/third_party/skia@6344cbd1df76
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=brianosman@google.com
2019-09-19 01:39:03 -04:00
Ben Konyi
61453ac1f2
Roll src/third_party/dart cb80ea7ba9..ea969c358e (52 commits)
...
dart-lang/sdk@ea969c358e [vm/assembler] Split popcnt and lzcnt tests over feature set
dart-lang/sdk@c9d187ec9c [vm/bytecode] Finalize type parameters while reading bytecode
dart-lang/sdk@397c7e4d9a Revert "[vm/bytecode] Enable bytecode compiler by default in Dart SDK"
dart-lang/sdk@108fe9cbcf Revert "[fuchsia] migrate from ioctls to FIDL"
dart-lang/sdk@ad7374fcdb assist to insert null checks
dart-lang/sdk@51d6145e77 [vm/assembler] Skip tests on hosts without POPCNT/LZCNT
dart-lang/sdk@27c127db86 Use Process.start in ddb
dart-lang/sdk@7305ae6c35 Revert "Update BoringSSL to 4dfd5af70191b068aebe567b8e29ce108cee85ce."
dart-lang/sdk@93793a4ee8 Migration: add tests to document missing `required` keyword functionality.
dart-lang/sdk@8acd1fe517 Update build rules to point to Fuchsia SDK rather than Flutter's buildroot
dart-lang/sdk@39ff937afa [vm] Rename _LocalXMirror to _XMirror.
dart-lang/sdk@bcca3c483b [vm/bytecode] Enable bytecode compiler by default in Dart SDK
dart-lang/sdk@b988928c33 Declare type system fields as Dart2TypeSystem where we cast them.
dart-lang/sdk@2e34231c8e [vm] Do not mirror default values of parameters of abstract methods
dart-lang/sdk@771ee9f9ba Pass the output directory to dartfix and install a listener when output should be generated
dart-lang/sdk@93f1324449 Update BoringSSL to 4dfd5af70191b068aebe567b8e29ce108cee85ce.
dart-lang/sdk@0ad30fafc1 [vm/assembler] Added cpufeatures, added LZCNT (IA32/X64)
dart-lang/sdk@4d9792668c Flow anaylsis: fix definite assignment tracking for for-each loop vars
dart-lang/sdk@b43bb452f0 [vm/concurrency] Fix asan memory leak caused by longjmp over std::function<> objects
dart-lang/sdk@f057e2506e [dart2js] Extended structured clone algorithm to JSObject.
dart-lang/sdk@b699852e6d Add 'out'/'inout' keywords for variance.
dart-lang/sdk@a1fdfb8fc8 Move ClassElement.thisType to API.
dart-lang/sdk@4102e63f37 Deprecate TypeProvider.listType/mapType
dart-lang/sdk@f1afb34924 Move strict-raw-type tests; add tests for extensions
dart-lang/sdk@4fcef04d61 Deprecate TypeProvider.iterableType/streamType
dart-lang/sdk@74af5f3496 Add a representation of the information captured from an nnbd migration
dart-lang/sdk@bd28bad820 [dartdevc] add modular tests for old ddc
dart-lang/sdk@9f4f0acb9e [vm/bytecode] Generate dependencies in front-end server in bytecode mode
dart-lang/sdk@678f561ea6 Syntax tests for disabled variance flag.
dart-lang/sdk@b510b91424 [vm] Bump abi version.
dart-lang/sdk@998a421128 Migration: expose fix reasons through the instrumentation interface.
dart-lang/sdk@a5683dfb62 Migration: add a repro for an issue with field formal parameters.
dart-lang/sdk@dce98a23d1 Fix a typo in a diagnostic message (issue 38449)
dart-lang/sdk@d4f1b8f8db Deprecate TypeProvider.futureType/futureOrType
dart-lang/sdk@546440074a Stop reporting diagnostics on synthetic identifiers (issue 38448)
dart-lang/sdk@f3b54fae0a Information for the migration result pages
dart-lang/sdk@205b90f0de Take 3 for '[vm/ffi] Implement FFI callbacks on AOT for ELF and Asm snapshots (excl. blobs).'
dart-lang/sdk@3731cfdef9 [vm] source report marks all const field as executed
dart-lang/sdk@a56b4ee790 [cfe] Thread nullability from source for function types
dart-lang/sdk@0c948521ca Update expectations in static_extesion_operators_test
dart-lang/sdk@ce6f40bccc [dartdevc] fix for const / overridden fields
dart-lang/sdk@38c6152884 [vm/concurrency] Add IsolateGroup::RunWithStoppedMutators and use it in various places
dart-lang/sdk@97b561a8de [cfe] Update CoreTypes to handle raw types with it
dart-lang/sdk@0281f9c425 [cfe] Add members to construct nullability in Library and LibraryBuilder
dart-lang/sdk@6a27310b87 Reland "[build] Speed up debug and simulator builds by running steps on the prebuilt VM."
dart-lang/sdk@4f1b0fdd0f [dart2js] (New RTI) Check all subtypes for trivial substitutions only when necessary.
dart-lang/sdk@12c1b43365 Substitute bounds of fresh type parameters using all fresh type parameters.
dart-lang/sdk@1a812bb6bb Deprecate TypeProvider.setType
dart-lang/sdk@4b6ab33cfa [SDK] Reland: Remove dart:profiler library which has been deprecated since Dart 1.2 and remove all references to it in tests and the SDK build scripts.
dart-lang/sdk@30d24335a8 [vm] Fix all wasm exception memory leaks
dart-lang/sdk@bab399b5ae [vm, arm64] Add missing store barrier to PushArrayOfArguments.
dart-lang/sdk@085f81224a [fuchsia] migrate from ioctls to FIDL
2019-09-18 22:07:11 -07:00
Dan Field
e4a8130bc6
skip flaky test ( flutter/engine#12355 )
2019-09-18 21:43:11 -07:00
Dan Field
0b33917787
java lints ( flutter/engine#12354 )
2019-09-18 21:20:04 -07:00
Kaushik Iska
4d6b95ebdc
[flutter_runner] Port vulkan surface changes ( flutter/engine#12350 )
...
[flutter_runner] use dedicated allocation info
This informs the vulkan driver that we're allocating memory
dedicated to a single image. This is required for aemu and
might also allow future drivers to make optimizations currently
not possible.
No change in behavior. Existing tests (modular_tests,
scenic_tests, etc.) are sufficient and regressions will be
prevented by running these tests on aemu.
DX-939 #comment
Test: fx shell run fuchsia-pkg://fuchsia.com/basemgr#meta/basemgr.cmx --base_shell=fuchsia-pkg://fuchsia.com/spinning_cube#meta/spinning_cube.cmx
Change-Id: If4ecd9aaa09f12f94654a68e8e9fe979748f44af
[flutter_runner] use external image create info
DX-939 #progress
MA-394 #progress
This informs the vulkan driver that we're creating an image
that will be backed by external memory. The driver driver can
decide to use different memory requirements based on the if
memory for the image can be exported or not.
No change in behavior. Existing tests (modular_tests,
scenic_tests, etc.) are sufficient and regressions will be
prevented by running these tests on aemu.
Test: fx shell run fuchsia-pkg://fuchsia.com/basemgr#meta/basemgr.cmx --base_shell=fuchsia-pkg://fuchsia.com/spinning_cube#meta/spinning_cube.cmx
Change-Id: I489318c2e31f752f76c80a81245e203861d44d94
2019-09-18 19:06:12 -07:00
skia-flutter-autoroll
51c7eb7711
Roll src/third_party/skia f19f9caab2b4..e2a903e18b59 (1 commits) ( flutter/engine#12351 )
...
https://skia.googlesource.com/skia.git/+log/f19f9caab2b4..e2a903e18b59
git log f19f9caab2b4..e2a903e18b59 --date=short --no-merges --format='%ad %ae %s'
2019-09-18 csmartdalton@google.com Reland "Reorder msaa and mipmap resolves to happen all at once"
Created with:
gclient setdep -r src/third_party/skia@e2a903e18b59
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=brianosman@google.com
2019-09-18 21:53:53 -04:00
Kaushik Iska
5bdd5ec96c
[flutter_runner] Explicitly set |trace_skia| to false ( flutter/engine#12349 )
...
Explicitly set |Application|'s |flutter::Settings| |trace_skia| field to
false (it currently defaults to false), in order to slightly simplify
the enabling skia trace events workflow.
PT-145 #comment-patch
Change-Id: Ib40f9ed3dc6f824056465db2cd45309c78b7e3b4
2019-09-18 18:02:43 -07:00
Kaushik Iska
51fc8e108d
[flutter_runner] Port the new compilation trace from topaz ( flutter/engine#12348 )
2019-09-18 18:02:34 -07:00
Kaushik Iska
b198248b55
[flutter_runner][async] Migrate dart/flutter to new async-loop APIs ( flutter/engine#12347 )
...
Change-Id: I11ca124878d2652798ed49958c42aa10ae019ef9
2019-09-18 17:45:53 -07:00
Kaushik Iska
555f0b2506
[flutter_runner] Move from runner context to component context ( flutter/engine#12346 )
...
* [flutter_runner] Move from runner context to component context
* remove the file references
2019-09-18 17:45:46 -07:00
Kaushik Iska
4063939bd8
[flutter_runner] Port over the tuning advice ( flutter/engine#12345 )
2019-09-18 17:32:08 -07:00
Kaushik Iska
9e522b13b1
[flutter_runner] Remove usages of shared snapshots from CC sources ( flutter/engine#12343 )
...
Build rules still reference creating share snapshot data and instructions. This makes the engine to always pass them as empty to the dart vm. To be followed up with a change to alter the build rules to stop referencing the shared snapshots.
This is not being used currently and the fact that the runner will be built outside of the flutter tree means that the apps will not have much to gain via shared snapshots. The rationale behind this change is to partially make migrating the runner out of topaz tree easier.
Change-Id: Ibc4dd6a298d65082416af753522f5a17c88a750a
2019-09-18 17:31:54 -07:00
Kaushik Iska
2c1b30a4f2
[flutter_runner] Do not use prebuilts just yet ( flutter/engine#12340 )
2019-09-18 15:31:57 -07:00
Dan Field
a8cfcfc78d
Add missing CL, fix targets for Fuchsia ( flutter/engine#12338 )
2019-09-18 15:06:50 -07:00
David Iglesias
25d2d2a47a
More controls for Screenshot tests (for web) ( flutter/engine#12284 )
...
New features for golden tests (for web):
* Height/width of headless browser instance extracted to constants
* Remove border from the host iframe
* Added 'region' to matchGoldenFile, so screenshots can capture only
a subset of the viewport
* Added image-format-awareness (png) to screenshot comparison, so it
doesn't only look at raw bytes
* When a test fails, output a diff image alongside the unexpected
output.
2019-09-18 14:58:30 -07:00
skia-flutter-autoroll
2772d80a9f
Roll src/third_party/skia 8391bac5c6f0..f19f9caab2b4 (8 commits) ( flutter/engine#12341 )
...
https://skia.googlesource.com/skia.git/+log/8391bac5c6f0..f19f9caab2b4
git log 8391bac5c6f0..f19f9caab2b4 --date=short --no-merges --format='%ad %ae %s'
2019-09-18 bsalomon@google.com Handle F16Norm clamping in SkPaint->GrPaint conversion.
2019-09-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-18 mtklein@google.com move skvm debug tools back to core
2019-09-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-18 herb@google.com Reland "SkZip - synchronized indexing of several pointers"
2019-09-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-18 robertphillips@google.com Last tranche of new SkColorTypes
2019-09-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
Created with:
gclient setdep -r src/third_party/skia@f19f9caab2b4
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=brianosman@google.com
2019-09-18 17:38:06 -04:00
Tamir Duberstein
8156de6820
[fuchsia] add fuchsia.netstack.Netstack ( flutter/engine#12325 )
...
Needed in preparation for
https://dart-review.googlesource.com/c/sdk/+/117620 .
Test:
git grep -l -E '(socket\.Provider|NameLookup)' | \
xargs grep -L fuchsia.netstack.Netstack
2019-09-18 12:01:49 -07:00
skia-flutter-autoroll
ddcb802813
Roll src/third_party/skia dd0dff1c35d2..8391bac5c6f0 (8 commits) ( flutter/engine#12337 )
...
https://skia.googlesource.com/skia.git/+log/dd0dff1c35d2..8391bac5c6f0
git log dd0dff1c35d2..8391bac5c6f0 --date=short --no-merges --format='%ad %ae %s'
2019-09-18 bsalomon@google.com Add F16Norm mode to viewer
2019-09-18 bsalomon@google.com blurrect_compare GM: draw "masks" in white for RGBA fallback.
2019-09-18 csmartdalton@google.com Weed out duplicates from the proxy version of addDependency
2019-09-18 mtklein@google.com faster PNG encoding in skottie_tool
2019-09-18 csmartdalton@google.com Revert "Use a "decal" domain for filterMaskGPU"
2019-09-18 csmartdalton@google.com Revert "Abolish absClear"
2019-09-18 bsalomon@google.com Use mipmapping/protected to lookup scratch textures.
2019-09-18 jvanverth@google.com Reland "Add ETC2 support to Metal backend."
Created with:
gclient setdep -r src/third_party/skia@8391bac5c6f0
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
TBR=brianosman@google.com
2019-09-18 13:53:16 -04:00
David Iglesias
c9f422f6eb
Ensure DRRects without corners also draw. ( flutter/engine#12330 )
...
Uncovered this bug running some additional engine tests. Backported the
test here, and fixed the recording_canvas code.
2019-09-18 10:45:43 -07:00