skia-flutter-autoroll
3c19ca33b4
Roll Skia from af7fb958e7f7 to adaad6716b2c (1 revision) ( flutter/engine#45312 )
...
https://skia.googlesource.com/skia.git/+log/af7fb958e7f7..adaad6716b2c
2023-08-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 3bbc85ea8f37 to 4d381b7718fd (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-31 05:56:23 +00:00
skia-flutter-autoroll
e40a0a18e1
Roll Skia from 5f3ef5363dbd to af7fb958e7f7 (1 revision) ( flutter/engine#45311 )
...
https://skia.googlesource.com/skia.git/+log/5f3ef5363dbd..af7fb958e7f7
2023-08-31 armansito@google.com [graphite][dawn] Introduce error scope utility
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-31 03:16:37 +00:00
Jonah Williams
42f0f83acb
[Impeller] CoverGeometry transforms its bounds. ( flutter/engine#45308 )
...
Thanks to @bdero ð
Fixes https://github.com/flutter/flutter/issues/132802
Fixes https://github.com/flutter/flutter/issues/123142
### Skia
### Impeller
2023-08-31 02:54:06 +00:00
Dan Field
ffa16ec08f
[Impeller] Reland DlAiksCanvas ( flutter/engine#45232 )
...
Relands https://github.com/flutter/engine/pull/45131
Fixes https://github.com/flutter/flutter/issues/132416
Differences from last time:
- Some minor merge conflict fixes
- Use the RTree to get the bounds instead of recalculating the bounds
- Make the iOS platform view controller implementation use the impeller-aware slices instead of the display list ones. This has been fixed for Android and the desktop embedding, but I missed iOS. The unit tests weren't actually running before I branched for my PR, @zanderso fixed them up separately and this resulted in catching the failures on post submit last time.
2023-08-31 00:29:23 +00:00
Matan Lurey
293bca4e65
Add a build_bucket_golden_scraper tool. ( flutter/engine#45243 )
...
As discussed offline, this is best deleted when Skia-gold is used for
all of our engine tests.
However, this will be useful for unblocking some PRs until then :)
See README.md for details!
2023-08-30 17:26:01 -07:00
Matan Lurey
8a55ee5d07
Add a DlStopwatchVisualizer and conditionally use it for Impeller ( flutter/engine#45259 )
...
Closes https://github.com/flutter/flutter/issues/126009 .
One major change, as-per @jonahwilliams's feedback, is that I created a helper class called `DlVertexPainter`, which provides a `DrawRect`-like API, but just builds a buffer of vertices, resulting into just a single:
```cc
// Actually draw.
canvas->DrawVertices(painter.IntoVertices(), DlBlendMode::kSrc, paint);
```
Also, added test for it, since there is no way to screenshot test to Impeller overlay yet.
# Impeller
2023-08-30 23:15:16 +00:00
skia-flutter-autoroll
1410d8beaa
Roll Skia from 185fbe1a264d to 5f3ef5363dbd (9 revisions) ( flutter/engine#45305 )
...
https://skia.googlesource.com/skia.git/+log/185fbe1a264d..5f3ef5363dbd
2023-08-30 michaelludwig@google.com Experiment with over-looping blur kernels
2023-08-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 99e7ba4c04b8 to 0d228411886e (11 revisions)
2023-08-30 robertphillips@google.com Add SkImages::MakeWithFilter factories
2023-08-30 robertphillips@google.com Move MakeWithFilter_Shared to SkImageFilter_Base::makeImageWithFilter
2023-08-30 jvanverth@google.com [graphite] Reduce generated SkImage usage in testing code.
2023-08-30 johnstiles@google.com Remove SPIRVDawnCompatFlag from SkSL.
2023-08-30 johnstiles@google.com Enable WGSL when `--config grdawn` is used.
2023-08-30 penghuang@chromium.org Set dawn_opengl_registry_dir dawn build override
2023-08-30 johnstiles@google.com Rename layout(backend) qualifiers to APIs, not languages.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 22:21:28 +00:00
Jackson Gardner
e9d2afd7d5
[web] Roll to most recent fallback font data ( flutter/engine#45301 )
2023-08-30 22:03:46 +00:00
Matan Lurey
b68134a74a
Increase maximum length of function names from 30 to 60. ( flutter/engine#45296 )
...
Unblocks https://github.com/flutter/engine/pull/45243 , which adds the function:
```py
def `gather_build_bucket_golden_scraper_tests`():
```
2023-08-30 20:24:03 +00:00
Jackson Gardner
c46824a2fa
Add an API in ui_web to create a ui.Image from an ImageBitmap ( flutter/engine#45256 )
...
This API will help with situations in which the user has a browser
resource that they want to transform into a `ui.Image` and render
directly into the layer tree. Most browser resources can be converted to
an `ImageBitmap` via the `createImageBitmap` API.
2023-08-30 13:01:22 -07:00
Jason Simmons
204b2e9e9b
[Impeller] Reorganize the glyph atlas to improve efficiency when looking up runs of glyphs in the same font ( flutter/engine#45191 )
...
The atlas will now store a separate map of glyph positions for each font/scale pair. This avoids the cost of repeated hashing and copying of font objects for each glyph in a text run.
See https://github.com/flutter/flutter/issues/133201
2023-08-30 19:49:04 +00:00
skia-flutter-autoroll
deb3e06124
Roll Fuchsia Mac SDK from Y2xfuZM0ec5GQfHV8... to gWpPuUyuR_hmz9Xmg... ( flutter/engine#45287 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 18:08:14 +00:00
skia-flutter-autoroll
667cd94c00
Roll Skia from 7a246c9eb086 to 185fbe1a264d (3 revisions) ( flutter/engine#45289 )
...
https://skia.googlesource.com/skia.git/+log/7a246c9eb086..185fbe1a264d
2023-08-30 kjlubick@google.com Remove unused SkFuzzLogging and SkAutoTime
2023-08-30 lovisolo@google.com //go.mod: Update to go 1.18 (same as the Go version in //WORKSPACE.bazel).
2023-08-30 michaelludwig@google.com Revert "Exact loops for all 1D blur kernels"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 17:56:04 +00:00
gaaclarke
abd01ab3c2
Revert "Roll Dart SDK from 0cea73a8d3c3 to 96d3a79547fc" ( flutter/engine#45285 )
...
reverts: https://github.com/flutter/engine/pull/45262
issue: https://github.com/flutter/flutter/issues/133677
2023-08-30 10:21:23 -07:00
skia-flutter-autoroll
a31b07c61e
Roll Skia from 3489b6d1d613 to 7a246c9eb086 (4 revisions) ( flutter/engine#45286 )
...
https://skia.googlesource.com/skia.git/+log/3489b6d1d613..7a246c9eb086
2023-08-30 michaelludwig@google.com [skif] Fix small-sigma threshold on GPU blurs
2023-08-30 sosotsertsvadze2@gmail.com fix: When installing skia on Windows, using emsdk.py, the option --permanent is required for setting environment variables.
2023-08-30 johnstiles@google.com Remove obsolete setting 'fAllowTraceVarInDebugTrace'.
2023-08-30 robertphillips@google.com Call makeImageFunctor explicitly in MakeWithFilter_Shared
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 16:56:50 +00:00
skia-flutter-autoroll
a5444bc48b
Roll Skia from a58ccf8ae398 to 3489b6d1d613 (2 revisions) ( flutter/engine#45283 )
...
https://skia.googlesource.com/skia.git/+log/a58ccf8ae398..3489b6d1d613
2023-08-30 cmumford@google.com [skottie]: put CanvasKit in expected directory
2023-08-30 michaelludwig@google.com Exact loops for all 1D blur kernels
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 16:07:56 +00:00
skia-flutter-autoroll
5093f62ab8
Roll Skia from 6f4fd97d2f7e to a58ccf8ae398 (1 revision) ( flutter/engine#45280 )
...
https://skia.googlesource.com/skia.git/+log/6f4fd97d2f7e..a58ccf8ae398
2023-08-30 robertphillips@google.com Replace onCreateFilterContext virtual with explicit Functor creation
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 14:02:06 +00:00
skia-flutter-autoroll
4eddcaee70
Roll Skia from a2728a7ad2a3 to 6f4fd97d2f7e (2 revisions) ( flutter/engine#45278 )
...
https://skia.googlesource.com/skia.git/+log/a2728a7ad2a3..6f4fd97d2f7e
2023-08-30 kjlubick@google.com Add external_client workspace for testing consuming Skia rules
2023-08-30 lovisolo@google.com [bazel] //gm/BazelGMRunner.cpp: Improve structure of output JSON files.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 13:17:58 +00:00
skia-flutter-autoroll
f49a64b330
Roll Skia from 7492e29ad235 to a2728a7ad2a3 (1 revision) ( flutter/engine#45273 )
...
https://skia.googlesource.com/skia.git/+log/7492e29ad235..a2728a7ad2a3
2023-08-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 356ddfc69865 to 99e7ba4c04b8 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 08:12:50 +00:00
skia-flutter-autoroll
e5cda8a24e
Roll Skia from 80f4d2f303d0 to 7492e29ad235 (1 revision) ( flutter/engine#45272 )
...
https://skia.googlesource.com/skia.git/+log/80f4d2f303d0..7492e29ad235
2023-08-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from d6fd7eafb2f7 to 8b0af482db74 (13 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 07:37:18 +00:00
skia-flutter-autoroll
eea341de87
Roll Skia from 03289b20b5d3 to 80f4d2f303d0 (1 revision) ( flutter/engine#45270 )
...
https://skia.googlesource.com/skia.git/+log/03289b20b5d3..80f4d2f303d0
2023-08-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 3bbc85ea8f37 to 02497261fadb
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 06:09:21 +00:00
skia-flutter-autoroll
a40e7ae926
Roll Dart SDK from 96d3a79547fc to 4352efd8497d (1 revision) ( flutter/engine#45267 )
...
https://dart.googlesource.com/sdk.git/+log/96d3a79547fc..4352efd8497d
2023-08-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-124.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 05:33:52 +00:00
skia-flutter-autoroll
6dae4050bc
Roll Skia from fde9fe141863 to 03289b20b5d3 (1 revision) ( flutter/engine#45268 )
...
https://skia.googlesource.com/skia.git/+log/fde9fe141863..03289b20b5d3
2023-08-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from d779093a7a96 to 3bbc85ea8f37 (8 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 05:32:14 +00:00
skia-flutter-autoroll
758eaf05e7
Roll Fuchsia Mac SDK from QKekosWnIY_ObKstn... to Y2xfuZM0ec5GQfHV8... ( flutter/engine#45265 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 04:44:05 +00:00
skia-flutter-autoroll
32f0709223
Roll Dart SDK from 0cea73a8d3c3 to 96d3a79547fc (1 revision) ( flutter/engine#45262 )
...
https://dart.googlesource.com/sdk.git/+log/0cea73a8d3c3..96d3a79547fc
2023-08-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-123.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 01:50:04 +00:00
Jonah Williams
732d38e0ae
[Impeller] transform text path offsets so color sources match expected offsets for gradients. ( flutter/engine#45255 )
...
Gradient offsets are computed based on path offsets + gradient positions, so we need to shift the points instead of just adding a concat to the canvas. Fixes https://github.com/flutter/flutter/issues/132972
### Skia
### Impeller (No Patch)
### Impeller (W/ Patch)
2023-08-30 01:30:59 +00:00
skia-flutter-autoroll
7a42143e0e
Roll Skia from e6eb56d9b074 to fde9fe141863 (1 revision) ( flutter/engine#45260 )
...
https://skia.googlesource.com/skia.git/+log/e6eb56d9b074..fde9fe141863
2023-08-30 michaelludwig@google.com Combine texture effect creation for 1d and 2d blur cases
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-30 01:25:50 +00:00
Brandon DeRosier
4e8b7c4afa
[Impeller] Document the capabilities. ( flutter/engine#45253 )
...
Add docstrings for the capabilities. Include examples/extra detail for the more confusing concepts.
Also renames a couple of capabilities for consistency with format terminology:
* SupportsDecalTileMode -> SupportsDecalSamplerAddressMode
* SupportsMemorylessTextures -> SupportsDeviceTransientTextures
PR is built on https://github.com/flutter/engine/pull/45240 (waiting for tree to reopen).
2023-08-29 23:42:56 +00:00
Xilai Zhang
d4b4f3e830
[flutter roll] Revert "ios: remove shared_application and support app extension build" ( flutter/engine#45250 )
...
Reverts flutter/engine#44732
context: b/297654739
Synced with Chris and the error message is related to the PR
2023-08-29 23:15:04 +00:00
skia-flutter-autoroll
0293da1f4c
Roll Skia from 8a2754a1ae60 to e6eb56d9b074 (3 revisions) ( flutter/engine#45248 )
...
https://skia.googlesource.com/skia.git/+log/8a2754a1ae60..e6eb56d9b074
2023-08-29 johnstiles@google.com Add paint-params key info to Shaders pane in Viewer.
2023-08-29 lovisolo@google.com [bazel] bazel_test_gm.go task driver: Upload PNGs to Gold.
2023-08-29 robertphillips@google.com Split the skif::Context's Functors out into their own object
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 23:09:44 +00:00
Matan Lurey
b3bb59e4b5
Refactor Stopwatch into StopwatchVisualizer and SkStopwatchVisualizer ( flutter/engine#45200 )
...
Partial work towards https://github.com/flutter/flutter/issues/126009 .
Still working as before:
<img width="1210" alt="Screenshot 2023-08-28 at 6 32 45 PM"
src="https://github.com/flutter/engine/assets/168174/38728015-d0d4-4933-bd31-d2326c76aeee ">
(There are some `PerformanceOverlayLayerDefault.*` tests that don't run
locally, so I guess I'll let CI run those)
2023-08-29 16:04:22 -07:00
Zachary Anderson
9ea8a110c7
Roll buildroot ( flutter/engine#45249 )
...
To pick up https://github.com/flutter/buildroot/pull/757 , which makes some sysroot paths relative.
2023-08-29 23:03:49 +00:00
Brandon DeRosier
2ec44fd6ce
[Impeller] Add GetDefaultDepthStencil to capabilities. ( flutter/engine#45240 )
...
Resolves https://github.com/flutter/flutter/issues/133194 .
And use it for building the Impeller Scene pipelines.
2023-08-29 23:03:46 +00:00
skia-flutter-autoroll
012104fa6a
Roll Dart SDK from a4e0e792ef9a to 0cea73a8d3c3 (1 revision) ( flutter/engine#45245 )
...
https://dart.googlesource.com/sdk.git/+log/a4e0e792ef9a..0cea73a8d3c3
2023-08-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-122.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 21:48:53 +00:00
Brandon DeRosier
c4be226879
[Impeller] Remove unused HasThreadingRestrictions capability. ( flutter/engine#45242 )
...
Noticed this while working through documenting all of the capabilities.
I guess we don't need this one anymore?
2023-08-29 14:29:59 -07:00
skia-flutter-autoroll
c2c776faa7
Roll Skia from fb09020ce62d to 8a2754a1ae60 (6 revisions) ( flutter/engine#45241 )
...
https://skia.googlesource.com/skia.git/+log/fb09020ce62d..8a2754a1ae60
2023-08-29 bungeman@google.com Fix Paragraph6 Sample
2023-08-29 michaelludwig@google.com Bucket 2D blur effects based on radius
2023-08-29 brianosman@google.com Migrate deprecated Vk GrBackendSurface related functions in AHB helpers
2023-08-29 jvanverth@google.com Disable yet more AsyncReadPixels tests
2023-08-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5857bae969d5 to 356ddfc69865 (8 revisions)
2023-08-29 fmalita@chromium.org [skottie] Move text editor sources to utils
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 21:27:54 +00:00
chunhtai
c667836eeb
[Impeller] Update xcode_frame_capture.md ( flutter/engine#45230 )
...
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-08-29 21:16:34 +00:00
yaakovschectman
292ac863fe
Update documentation for updater callback. ( flutter/engine#45239 )
...
Fix a mistake in the documentation regarding the thread on which the
channel update callback is called.
https://github.com/flutter/flutter/issues/131616
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-08-29 17:04:19 -04:00
yaakovschectman
e2908808b6
Add callback to Embedder API to respond to new channel listeners, and use for Windows lifecycle ( flutter/engine#44827 )
...
Supplant the temporary solution
https://github.com/flutter/engine/pull/44238 with a more elegant
solution with am embedder API callback. The windows engine provides a
callback that enables graceful exit and app lifecycle when the platform
and lifecycle channels are listened to, respectively.
https://github.com/flutter/flutter/issues/131616
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
---------
Co-authored-by: Chris Bracken <chris@bracken.jp>
2023-08-29 16:12:35 -04:00
skia-flutter-autoroll
2e8e99e339
Roll Skia from 15de7f9c3b3b to fb09020ce62d (3 revisions) ( flutter/engine#45233 )
...
https://skia.googlesource.com/skia.git/+log/15de7f9c3b3b..fb09020ce62d
2023-08-29 lovisolo@google.com [bazel] Add Bazel-only GM for testing purposes.
2023-08-29 bungeman@google.com Remove SK_IGNORE_COLRV1_GRADIENT_COLORSPACE_FIX
2023-08-29 drott@chromium.org [Fontations] Move wrappers to sk_fontations namespace
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 18:44:22 +00:00
Matan Lurey
69fd1ebf92
Use runIfNot: ... to avoid running Fuchsia try-jobs for some changes. ( flutter/engine#45134 )
...
Closes https://github.com/flutter/flutter/issues/93261 .
I probably could have been more clever with a regular-expression but
this seems easier to read.
---------
Co-authored-by: godofredoc <godofredoc@google.com>
2023-08-29 11:34:14 -07:00
Zachary Anderson
f127ba2c14
Clean up engine repo Dart code ( flutter/engine#45203 )
...
Also adds a test to ensure that all packages are accounted for.
2023-08-29 11:19:42 -07:00
skia-flutter-autoroll
58cf45060f
Roll Skia from b7e826d5324f to 15de7f9c3b3b (3 revisions) ( flutter/engine#45231 )
...
https://skia.googlesource.com/skia.git/+log/b7e826d5324f..15de7f9c3b3b
2023-08-29 bungeman@google.com Roll HarfBuzz from f94508ed to f380a328 (164 commits)
2023-08-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from d5998642c25b to 3e2b0ed75e49
2023-08-29 michaelludwig@google.com Reland "[skif] Add FilterResult::Builder::blur() to wrap per-backend blur impls"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 17:52:22 +00:00
Jonah Williams
283b68440b
[Impeller] its not safe to presentWithTransaction from a background thread. ( flutter/engine#45182 )
...
Sad Trombone. Because Flutter runs from a background thread, if we touch a CATransaction while there is a main thread transaction occuring then we'll trigger a framework error.
Fixes https://github.com/flutter/flutter/issues/133147
2023-08-29 17:34:14 +00:00
skia-flutter-autoroll
f618d4b1cf
Roll Skia from b0c1b2868129 to b7e826d5324f (4 revisions) ( flutter/engine#45229 )
...
https://skia.googlesource.com/skia.git/+log/b0c1b2868129..b7e826d5324f
2023-08-29 michaelludwig@google.com [skif] Update testing-only matrix validation image filter to new API
2023-08-29 bungeman@google.com Roll FreeType from 5769f13a to 2d9fce53 (22 commits)
2023-08-29 drott@chromium.org [Fontations] Simplify glyph path based on overlap flag, sanitize paths
2023-08-29 kjlubick@google.com Enforce IWYU on SkResourceCache etc
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 16:55:59 +00:00
skia-flutter-autoroll
5021a9123b
Roll Skia from 4048262b9b21 to b0c1b2868129 (2 revisions) ( flutter/engine#45227 )
...
https://skia.googlesource.com/skia.git/+log/4048262b9b21..b0c1b2868129
2023-08-29 kjlubick@google.com One more SkSwizzlePriv change
2023-08-29 jamesgk@google.com [graphite] Account for coverage when deciding to do in-shader blending
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 16:11:20 +00:00
Mouad Debbar
e2e1b979c4
[web] Make devicePixelRatio ready for multi-view ( flutter/engine#44783 )
...
This PR moves the source of truth for`devicePixelRatio` to the `EngineFlutterDisplay` singleton.
Main things that this PR is trying to do:
- `EngineFlutterDisplay` is a singleton that represents information about the display.
- The `devicePixelRatio` can be overriden in tests.
- The `browserDevicePixelRatio` gets the value directly from the browser and can't be overriden.
- Remove `EngineSingletonFlutterWindow` and incorporate it into `EngineFlutterWindow`.
2023-08-29 15:51:05 +00:00
skia-flutter-autoroll
bf6f6b6b80
Roll Skia from 7675f886f884 to 4048262b9b21 (2 revisions) ( flutter/engine#45225 )
...
https://skia.googlesource.com/skia.git/+log/7675f886f884..4048262b9b21
2023-08-29 jvanverth@google.com [graphite] Move contents of ImageUtils to TextureUtils.
2023-08-29 kjlubick@google.com Move SkOpts things around for easier modularization
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 15:23:53 +00:00
skia-flutter-autoroll
e13add979c
Roll Skia from 85377eca700d to 7675f886f884 (7 revisions) ( flutter/engine#45224 )
...
https://skia.googlesource.com/skia.git/+log/85377eca700d..7675f886f884
2023-08-29 michaelludwig@google.com Revert "[skif] Add FilterResult::Builder::blur() to wrap per-backend blur impls"
2023-08-29 jvanverth@google.com Some minor readPixels cleanups.
2023-08-29 jvanverth@google.com Re-enable *AsyncReadPixels on Adreno GL.
2023-08-29 johnstiles@google.com Reland "Pass colorspace-transform coefficients in a 4x4 matrix."
2023-08-29 robertphillips@google.com Consolidate onCreateFilterContext implementations
2023-08-29 michaelludwig@google.com [skif] Update testing-only PDF image filter to new API
2023-08-29 michaelludwig@google.com [skif] Add FilterResult::Builder::blur() to wrap per-backend blur impls
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 14:37:22 +00:00
skia-flutter-autoroll
dd9f324581
Roll Dart SDK from 70066300aa83 to a4e0e792ef9a (1 revision) ( flutter/engine#45221 )
...
https://dart.googlesource.com/sdk.git/+log/70066300aa83..a4e0e792ef9a
2023-08-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-121.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-08-29 13:56:59 +00:00
