Naively embedded platform views on Android were never able to receive
keyboard input, because they were never focusable. So far we've worked
around the limiation by hooking into InputMethodManager and proxying the
InputConnection from a focused window over to the embeded view.
Android Q changed InputMethodManager to be instanced per display instead
of a singleton. Because of this our proxy hook was never being called,
since it was being set up on a different instance of IMM than was being
used in the virtual display.
Update `SingleViewPresentation` to store the IMM from the focused window
and return it whenever there are any calls to `INPUT_METHOD_SERVICE`.
This hooks our proxy back into place for the embedded view in the
virtual display. This restores the functionality of our workaround from
previous versions.
Unfortunately there's still a lot of noisy error logs from IMM here. It
can tell that the IMM has a different displayId than what it's expecting
from the window.
This also updates the unit tests to support SDK=27. SDK 16 doesn't have
DisplayManager, so there were NPEs attempting to instantiate the class
under test.
* Roll dart to e6887536aadc7fbd1990448989601cee0224958d.
Changes since last roll:
```
e6887536aa [ VM ] Ignore contexts which have been optimized out during stack overflow checks
dabfda5770 Revert "[vm/compiler] Check def/use relation for PushArguments in environment."
596a4ab14d [vm/bytecode] No need to set breakpoints in bytecode if interpreter is not used.
531cb02331 Fix language_2/mixin_constructor_forwarding/* tests.
24f45d64c7 Delete language_2/generic_no_such_method_dispatcher_simple_test.
0c481a196c Revert Reland '[vm/ffi] Implement FFI callbacks on AOT for ELF and Asm snapshots (excl. blobs).' as it breaks flutter profile execution on ios 32-bit platform.
1d01d91c33 fix for sort_child_properties_last
586869c3f6 [vm/bytecode] Fix iteration of bytecode local variables
eac977bef0 Issue 38273. Fix for inlining methods ending with a return statement without an expression.
0d1636e0b2 Simplify how the list of TestCases for each TestConfiguration is made.
c8e389ff62 [vm/fuzzer] List versions for each git commit
c6b0ae1fda Fix for indexing FieldFormalParameterMember with unresolved field.
d18bfb409f Fix language_2/super_call4_test.
c464a12eb0 Minimize diffs between copies of js_dart2js.dart
c99cd5b82e Add more dart:html, enough for angular_analyzer_plugin.
3e63f06afd Remove CancelableFuture.
315e9c13f5 [gardening] Avoid --deterministic in regress_merge_blocks_with_phis_test
25edeb7ae1 Support completing the extension name locally
e8836f5086 Fix sample for UNDEFINED_SETTER.
971b519b07 Apply missed changes to NNBD sdk
d39b67dbfe Remove more unused classes from engine.dart
e35408df41 update REMOVE_TYPE_ANNOTATION assist error associations
d36f5ed181 Fix diagnostic documentation tests and add support for documenting parser codes
3d1712c822 Remove tests for unqualified identifiers from static_extension_getter_setter_conflicts_test
4f8f592b51 Remove adding prefixes for auto imports.
be93b04a7c Introduce a better diagnostic message for unqualified references to static members within extensions
de7ad46797 Enable visibleForTesting on unnamed constructors
80040e5cfe Remove errors for raw types in `is` or `as` expressions.
2cc0c4fcc0 Update doc comments for `dart:js`
dd3d6547de Rewrite property resolution, fix reporting errors when compound assignment without a getter.
76e6325ae0 Remove unused methods of AnalysisContext.
fb2e6c6d0d [test] Remove non-kernel versions of service tests.
27918cdb29 fix for prefer_inlined_adds
a7e71c3351 [test] Fixes run_appended_aot_snapshot_test in precompiled mode.
16c7ac92bf move const method error reporting into parser
9113fb3ce0 Move the remaining StaticWarningCode tests to their own files
1b67cc79da Suggest completions for extensions in parts
88e94994b1 [vm/compiler] Check def/use relation for PushArguments in environment.
488a8ae69b [vm/compiler] Don't propagate non-constants as constants.
46b58397f8 [Runtime] Adds appended blob runtime mode.
11c5c34d95 [infra] Check whether sdk and sdk_nnbd are in sync on presubmit.
4d5e15abde Fix broken static_extension_getter_setter_test.
cbdbb464ca [vm] Repair fingerprinting of recognized methods.
1e9a065dad [vm/fuzzer] Restrict depth of ... operator
a0fd607d10 [vm/fuzzer] add missing space
f3b2d770ad Migration: rework assignment handling.
1bbee6119d Migration: handle binary expressions whose LHS has type `dynamic`.
75fd88cf8c Migration: handle dynamic function expression invocations.
eeb1716660 Migration: don't forget to visit arguments to dynamic invocations.
3cccd7f117 Migration: handle `??=` assignments.
13ba681398 [vm/compiler] DIV/MOD magic for ARM64
03b195164b Revert "[vm, snapshot] Use data image pages for kFull snapshots."
5303538a09 [vm/fuzzer] re-enable control flow collections
9a9c0f3374 [test] Update status for some mirrors tests under reload stress testing.
6e01ad4d22 Fix for codeOffset/codeLength for enum constants.
3f7805a90e Make the NNBD command-line options less, uh, half-baked.
2305d9f3a6 [vm/compiler] Better be ready for OSR in field init
79137ed65f Migration: create flow anaylsis before visiting parameters.
1100aab88d Migration: handle `this` or `super` in generic classes.
d93d70a89a [dart2js] Add test for issue #38005.
64360e9f1a [vm/bytecode] Do not expect _ClosureCall in interpreted async stack traces.
f3911dffb5 Update included element kinds to include extensions
81dc269a71 Status file cleanup.
e82d1115ac Remove _CheckBuildStatus on commit
90866d3ecc Remove unused import
30ea777c65 fix parsing of "?.." cascade operator
13fc090e85 Fix language_2/map_literal3_test/03.
7ffb9de00f Update the version in the extension methods version hint
557f9121a5 Add canned_checks.CheckPatchFormatted to presubmit
004d49bd6b Make a fork of sdk/lib for use by NNBD.
ca7baa4013 [vm/fuzzer] Add virtual methods
2b966a9743 [vm/fuzzer] Fix reproduction output
c11ca7d439 Check for CompileTimeErrorCode.CONST_WITH_TYPE_PARAMETERS in LinterContext.canBeConst().
7bbfd532de [vm, reload] Remove _getUnusedChangesInLastReload.
abb606e613 [release] Update checked in SDKs to 2.5.0
24857b773a fix for prefer_spread_collections
fa099eb717 Look for both getter and setter in the hierarchy before looking for extension.
331271d405 Set id(s) for GenericFunctionType(s) in constructor initializers and default values.
300c3333d1 [gardening] Always tag class_id register on arm64 in subtype test cache stub
6717bfe423 [vm/concurrency] Lock weak table to prepare for concurrent access.
8329968192 fix for prefer_single_quotes
9357b48a8d [gardening] Use target::kWordSizeLog2 instead of kWordSizeLog2 on arm (fixes broken build)
ef9d699f07 [vm/concurrency] Move all information except for the class pointers out of [ClassTable] into [SharedClassTable]
9a2e2801d9 fix for avoid_relative_lib_imports
62f78a7abb [nit] Fixes two typos: build flag and error string.
35a7f4b552 [release] Update CHANGELOG.md for 2.5.0
f16d6d5910 [infra] Ignore newly detected flakes in try runs
ccb6ba948b [cfe] Gather constraints from both possibilities for FutureOr
f1f709ec11 Migration: add support for metadata on library/import/export/part/part-of directives.
1daf84f0dc [nnbd_migration] support spread elements
7413879026 [analyzer] Add getter isNullAware to SpreadElement
78bf8f08b9 Fix language_2/deferred_load_library_wrong_args_test.
9fccb5120b [vm/bytecode] Fix clobbering of exception handler types in bytecode reader.
b4724c1d78 Fix language_2/regress_23408_test.
424ef3646e [vm/fuzzer] Print steps to reproduce on divergence
76bc894576 [vm/bytecode] Generate explicit DebugCheck for assignment to static field
95db62d6a2 [vm/io] Return data right away if it's ready.
601d8934f4 Fix issue31596 tests
32848c3a25 Migration: Rework handling of assignments to FutureOr.
36648acfcc [nnbd_migration] Pass as casts to _handleAssignment
98837e6e43 [vm/bytecode] Workaround for incorrect type parameters in function types
4e7b77e428 Fix language_2/super_bound_closure_test
a2c8b69af0 Status file cleanup
879cdeffb3 update scanner test
909e2515af Fix regress_29025_test
ecb9a113d1 Fix language_2/regress_22976_test
ef2a21ffd9 [vm/bytecode] Use local variable information when compiling from bytecode
27f803db76 fix for convert_to_null_aware_operators
0851b9ae4c Consider both getter and setter when deciding whether an extension reference is ambiguous.
4310d157a1 Fix language_2/type_promotion_more_specific_test/04
438c595950 Fix language_2/regress_30339_test
9497b7b0a4 Delete language_2/regress_29405_test
6f38a73618 Remove most of the task model.
fbd21a0d1f Guard against null in exportedDeclarations.
b4614904de Migration: add support for indexing on a dynamic type.
9fd672b1b7 fix for prefer_expression_bodies
c2e55a26bc [vm/bytecode] Cleanup support for old bytecode format versions before v10
2e8d912848 [developer] Allow async end events to have independent arguments.
09ce6d30e7 [vm, service] Remove _collectAllGarbage.
bc24702149 Add missing parens to static_extension_getter_setter_conflicts_test.dart
e9dcb9f45d fix typo in factory; add mixin text for protected
ab5e36bcfb fix for prefer_int_literals
41c5b81818 [cfe] Special error message for illegal override of a setter by a field
e9c3eebef1 [infra] Add handling of signed SDK directories to promote.py
ff0fda7732 [cfe] Handle UnknownType using defaultDartType
129d4a6144 simplify dartfix output
41bf7443d4 update parser to report static constructor
cb1efb8d27 update parser to allow "late var" in NNBD
99007f3a3e remove duplicate error generation in ClassBuilder
fb73cb19e6 update parser to report MixinDeclaresConstructor error
355df2a354 split AstBuilder endClassConstructor out of endClassMethod event
b6f6240013 fix extension factory declaration in AST
618b56d24d fix conditional expression parsing with NNBD enabled
fb446e5768 [dartdevc] Properly emitting JS interop anonymous classes
4a4f7cbde3 Migration: Handle uses of typedef types as expressions.
0b0c113b52 Migration: rework edge builder prefix handling.
028d97bb1d Migration: handle references to already-migrated fields.
cbe135255d Migration: add support for most compound assignments.
daaa6657b1 Migration: fix a corner case of post-dominator analysis.
23d28932f0 Remove asserts in TypeProviderImpl.
3d3bbc2dbf Remove 'strongMode' flag in StaticTypeAnalyzerTest.
7f8398e484 Changes to MockSdk to make it usable in linter.
116cfbaa2d Issue 38198. Fix for isMoreSpecific() extension.
9391e15cfd [ package:vm_service ] Added support for service protocol version 3.27.
13a69b5631 [vm/bytecode] Replace ICData constant pool entries with DynamicCall
cff9c587f4 Tighten call conventions in allowInterop
c0f49b05dd [vm/debugger] Pick the correct context async variable in bytecode frames.
68dede011e [ VM / Service ] Add getCpuProfileSamples RPC which returns a minimally processed sample buffer.
84db16381d [vm] Remove dead --load_deferred_eagerly and dependent code tracking for library prefixes.
1d6ab52f38 [vm] Fix CoreSnapshotSize and StandaloneSnapshotSize to account for the image page size.
fd7676e0bc Fix language_2/config_import_corelib_test
5247036142 fix for convert_to_if_element
e1dc432102 [vm/fuzzer] Update rerun output and parser script
2c219ddb07 Replace AnalysisContextFactory with TestAnalysisContext.
67cdae394f Add import fix in missed case
cf94c3a2fa Additional tests verifying interaction between mixins, static extensions, and visiblity annotations (protected, visibleForTemplate, visibleForTesting).
ffd50c0dc5 Report EXTENSION_AS_EXPRESSION, set type fo dynamic.
254d0776d4 [vm/fuzzer] Fix bug where FFI caused dart crash
f5c0e2e362 [vm/concurrency] Ensure instance size in class table is either 0 or the correct size
eb60f0531e Support a fix to add a setter, both in extensions and elsewhere
e227ffa955 Migration: improve handling of catch clauses.
40454f0918 Fix language_2/f_bounded_quantification2_test
836f6de0f4 Fix language_2/f_bounded_quantification4_test
8ad0832bcb [vm/bytecode] Use static types of parameters when compiling from bytecode
1354ec93db fix for prefer_for_elements_to_map_fromIterable
152aa5a6ed fix calls following null-assertion operator
4e4047a52f fix extension abstract method error
a689f8df06 corelib_2/unsigned_shift_test fixes
6f4ceb887e [vm] Provide a couple more gdb helpers to print stack traces.
d7c96f323d Migration: handle prefixed class references.
0d63ce1d0c Clean up MockSdkElements.
8022f885af Stop using TestTypeProvider in analyzer_plugin.
e55a1e0f3a [vm/fuzzer] Add filter keywords to collect_data
c6a6add465 [vm/fuzzer] Count re-runs
d964c50cff clear contents on TemplateElement#setInnerHtml before appending
c8f3f132ad [vm, snapshot] Use data image pages for kFull snapshots.
add83ad185 Fix language_2/generic_no_such_method_dispatcher_test
f5b53276ce Fix language_2/compile_time_constant_static5_test
e34d71feee [nnbd_migration] Implement if/for in map/set
da235a57f8 [nnbd_migration] Fix for elements for list literals
6ae9709bcb Create TestTypeProvider as TypeProviderImpl on MockSdkElements.
46d7064108 Stop using resolutionMap in DDC.
fb14babf59 [vm/fuzzer] disable control flow collections again
5d4940f968 Migration: remove a bogus comment
6043b53af6 Migration: add the ability to dump the graph after propagation.
cdd2f855e1 Migration: handle upcasts from function type to Function or Object.
7e04e051cf Migration: add an option to print just exception nodes rather than full stack traces.
28d16e1172 Migration: implement substitution logic for generic function types.
f48a5a9f64 Support create method fix for extensions
17c06c342e Unify to single TypeProviderImpl.
8c13ecf443 [cfe] Handle nested on-types
0a49ddef73 Remove previewDart2 related code in some tests.
836039e9b6 Add MockSdkElements for creating dart:core and dart:async mocks.
d8f16611ed Support replacing similar names in extensions
4d0fa1e402 fix for slash_for_doc_comments
dc204ec879 [CFE] Preserve file URIs of expressions in unevaluated constants.
0242f0c724 [kernel] FileUriExpression node
70a7cbf49d [vm] Support extensions in ffi transformation and tfa tree shaker
7152fd06a5 [cfe] Handle [] and []= on extensions
deb2fcf818 [cfe] Handle extension operators
7ca157dfd6 [cfe] Thread nullability modifiers for some InterfaceTypes in outline
ec7ec4ecf7 [gardening] Fix import to fix Flutter build
f989605cc9 Fix dartdoc typo in ffi
2246f0a8a3 Compute constant dependencies for constructor elements in canBeConst().
981be87206 Add configuration options and flags for controlling NNBD mode.
9ff104efd6 Move StaticError and StaticErrorParser to a separate file.
bad1816c21 Migration: add edge builder support for generic method invocations.
35f45f0ee4 Do null-aware shorting for IndexExpression.
90aca0b8d5 Add test for incomparable on type resolution and fix expectations.
f4229da6ab [vm, bytecode] Produce compile-time errors instead of crashing when failing to resolve libraries etc.
a64b06ec83 [gardening] Migrate most files to be implicit-bool-conversion free
698d120328 base processor migration; fix to add type annotations
d9a9346c3f [vm/compiler] Fix truncating logic
d2dc053752 Corrections to "[vm] Fix ASAN build."
592914fb8b Don't report HintCode.CAN_BE_NULL_AFTER_NULL_AWARE when NNBD.
c219a76652 Reland "[vm/ffi] Implement FFI callbacks on AOT for ELF and Asm snapshots (excl. blobs)."
6a8c988fc4 Simplify the computeCompilerArguments().
9a847a98e8 [ VM / Service ] Fix docs for @Instance not including optional closureFunction and closureContext fields
ff8b43750a Move reporting INVALID_ASSIGNMENT for compound assignments into StaticTypeAnalyzer.
cf5e9ca423 Additional tests and fixes for creating getters
6e3498cd08 bump server SDK constraint lower bound
89dde0501d Migration: fix handling of assignments involving FutureOr.
ec48af600f Support fix to import a library defining an extention
4fbd758f9e [vm/bytecode] Optimize comparisons with null
16a4c0d13c Bump up oldest_supported_abi_version for abi bot
c7bb9cf5c4 refactor to share common fix/assist processor code
5a45050d1e [observatory] Flatten the heap snapshot before loading.
75374b89f6 [vm] Fix ASAN build.
8ee3f314cb [vm/gardening] clang tidy fixes
89ad636b58 Remove the old "preview Dart 2" flags from the test runner.
aa34de3fe5 Flow analysis: adjust _variableInfosEqual to do a shallow comparison.
ea35690b96 Flow analysis: add unit tests of try/finally handling.
b179ef33ec Flow analysis: add unit tests of try/catch handling.
e2a00dc465 Flow analysis: add unit tests of while statements
edceedff90 [vm, reload] Allow any change to a class that hasn't yet been declaration loaded.
68ba13e4e8 With NNBD null-shorting is performed.
a7723d5c40 [vm] Out-line handle allocation.
16be3a095d [vm/benchmark] Add *Bytes suffix to Isolate SendReceive benchmark
```
* Update dart license
Manage resource and onscreen contexts using separate IOSGLContext objects. FlutterView owns the onscreen context, and PlatformViewIOS owns the resource context.
- Add a custom `PlatformPlugin` that spins up a server waiting for test to request a screenshot.
- When a screenshot is requested the plugin talks to Chrome via the debug port, captures a screenshot, and compares it with a golden file
- This PR also adds proper CLI for `dev/test.dart` with an `ArgParser` for future extension into a proper developer tool for the team.
- As a first couple of features, it adds `--debug` option to launch Chrome in debug mode, a `--target` option to choose a single test to run rather than all tests, and `--shard` option to choose a subset of tests to run.
Limitations:
- While screenshot test will run on Cirrus, they are configured to not fail on Cirrus. Need to solve Chrome version skew.
- Stack maps do not work yet (you get stacks, but they are nonsensical)
- When requesting a single test, build_runner builds all tests anyway
- Nothing but desktop Chrome is supported
- Nothing but Linux is supported
- There's no Chrome version pinning; currently assumed stable Chrome channel
