16672 Commits

Author SHA1 Message Date
James George
384a44d6bd update docs (#32545) 2019-11-20 16:15:58 -08:00
Sangmin Lee
60c7cc25e9 Fix typo in README.md (#43173) 2019-11-20 16:14:10 -08:00
Jonah Williams
106b8eb9c0
Revert "Reduce some direct package:archive usage (#44608)" (#45291)
This reverts commit 6b5634fed35cb0d818e99de9f8c66586ed1b27a7.
2019-11-20 14:45:32 -08:00
Jonah Williams
6b5634fed3
Reduce some direct package:archive usage (#44608) 2019-11-20 13:32:14 -08:00
chunhtai
314eb3bae3
Moving pointer event sanitizing to engine. (#44217) 2019-11-20 13:04:29 -08:00
Michael Goderbauer
f8cafd9dbc
Remove URLs in deprecation annotation (#45215) 2019-11-20 12:45:04 -08:00
Jonah Williams
0e36a91d18
Add macOS hot reload test (#45264) 2019-11-20 12:35:53 -08:00
Todd Volkert
2c7af1e24e
Revert "[Gallery] Add Material Study app Rally as an example app (#44907)" (#45279)
This reverts commit 399aebc4b745d3572407b3b38ceea4ada29d2593.

It contained Apache 2.0 licensed files, which aren't allowed in flutter/flutter
v1.12.5
2019-11-20 12:18:44 -08:00
Todd Volkert
ce8e2bb7cf
Revert "[Material] Update the Slider and RangeSlider to the latest Material spec (#44351)" (#45268)
This reverts commit 421bf64703b5c0fae7196923da0561f6a4c6ec79.

Was causing severe breakages in Google.
2019-11-20 10:42:23 -08:00
Danny Tuppeny
927fbe5500
Re-enable asserts on Windows integration tests (#42637)
* Enable asserts

See https://github.com/flutter/flutter/issues/36476

* Remove comment
2019-11-20 17:50:37 +00:00
Jonah Williams
70dcbf4e55
Add minimum macOS application to Flutter Gallery (#45259) 2019-11-20 09:44:17 -08:00
Jonah Williams
f20471d081 Revert "reland add lifecycle enum and fix the scheduleforcedframe (#45133)" (#45260)
This reverts commit 99324105da695ed55d322a039cf5349a7b2ab45b.

It was implicated in https://github.com/flutter/flutter/issues/45258
2019-11-20 09:43:15 -08:00
Anthony
421bf64703
[Material] Update the Slider and RangeSlider to the latest Material spec (#44351)
Update the Slider and RangeSlider to the latest Material spec. This introduces an updated track, updated thumbs, updated tick marks, and a new value indicator shape. The old paddle value indicator shape is also updated so that text scaling works consistently.
2019-11-20 18:18:40 +01:00
Danny Tuppeny
73c32545b7
Fix device daemon test when desktop or web are enabled (#45172) 2019-11-20 11:02:35 +00:00
Emmanuel Garcia
fb5e49082b
Revert "Attach looks at future observatory URIs (#45228)" (#45237)
This reverts commit 2135e9fb1e7829fb6d627e4cd1ddbeafd4f272b3.
2019-11-19 23:14:25 -08:00
Emmanuel Garcia
2135e9fb1e
Reland: Attach looks at future observatory URIs (#45228) 2019-11-19 21:43:52 -08:00
engine-flutter-autoroll
51b027c2f6 Roll engine 2d35b4ec1f04..176f56329631 (3 commits) (#45226)
* f240462bb Implement basic text rendering support in CanvasKit backend (flutter/engine#13903)

* ffcd8564a Imagefilter wrapper object (flutter/engine#13711)

* 176f56329 Roll src/third_party/dart eeca3fb1cb..1f933abcee (7 commits) (flutter/engine#13931)
2019-11-19 21:39:24 -08:00
Jonah Williams
c724504142
Update Android CPU device detection (#45139) 2019-11-19 19:04:17 -08:00
Todd Volkert
868578b150
Roll engine c812a62b8810..2d35b4ec1f04 (4 commits) (#45217)
c812a62b88...2d35b4ec1f

Expose the platform view mutator stack to custom compositors. (flutter/engine#13731)
Roll fuchsia/sdk/core/linux-amd64 from T9BAw... to 7mmHP... (flutter/engine#13924)
Changing test runner and platform to be browser independent (flutter/engine#13869)
Roll Skia to e678b79c489d (2 commits) (flutter/engine#13923)
2019-11-19 18:39:53 -08:00
Ian Hickson
b75abd9f7e
Try a mildly prettier FlutterError and make it less drastic in release mode. (#44967) 2019-11-19 17:35:47 -08:00
Todd Volkert
664350d2a8
Roll engine f4fba66c2fad..c812a62b8810 (4 commits) (#45203)
git@github.com:flutter/engine.git/compare/f4fba66c2fad...c812a62b8810

git log f4fba66c2fad..c812a62b8810 --no-merges --oneline
2019-11-19 jonahwilliams@google.com allow ignoring toString, hashCode, and == in api_conform_test (flutter/engine#13907)
2019-11-19 bkonyi@google.com Roll src/third_party/dart d9d5fbc109..eeca3fb1cb (5 commits)
2019-11-19 chinmaygarde@google.com Add virtual destructor to GPUSurfaceSoftwareDelegate. (flutter/engine#13918)
2019-11-19 47866232+chunhtai@users.noreply.github.com Moves pointer event sanitizing to engine. (flutter/engine#13697)
2019-11-19 17:35:19 -08:00
Greg Spencer
0d27fdced9
Scroll scrollable to keep focused control visible. (#44965)
Before this change, it was possible to move the focus onto a control that was no longer in the view using focus traversal. This changes that, so that when a control is focused, it makes sure that if it is the child of a scrollable, that the scrollable attempts to keep it in view. If it is already in view, then nothing scrolls.

When asked to move in a direction, the focus traversal code tries to find a control to move to inside the scrollable first, and then looks for things outside of the scrollable only once the scrollable has reached its limit in that direction.
2019-11-19 17:10:34 -08:00
Emmanuel Garcia
7a0911b47a
Revert "Attach looks at future observatory URIs (#44637)" (#45211)
This reverts commit 6d77996d6a760f53649603f45b2f94ccba7ef936.
2019-11-19 16:47:39 -08:00
liyuqian
a32fc986f3
Add a perf test for picture raster cache (#45050)
This will catch issues like
https://github.com/flutter/flutter/issues/44252, and this test is
inspired by the `list_demo` sample app in
https://github.com/flutter/flutter/issues/43083#issue-509586473

This is tested locally on a Moto G4 before and after the fix
https://github.com/flutter/engine/pull/13710

The `average_frame_rasterizer_time_millis` of this test drops from
~5.4ms to ~4.9ms after that fix.
2019-11-19 15:48:41 -08:00
chunhtai
99324105da
reland add lifecycle enum and fix the scheduleforcedframe (#45133)
* reland add lifecycle enum and fix the scheduleforcedframe
2019-11-19 15:45:37 -08:00
Todd Volkert
f8424b3e6a
Roll engine to f4fba66c2fad1c1d5705ea0734ee4250211f6757 (#45192)
f4fba66 Adding opacity -> alpha method to Color class (flutter/engine#13902)
86e82fc Roll src/third_party/skia d3ddcb403993..c5e528e15b1f (1 commits) (flutter/engine#13916)
84ed7be [web] Implement PathMetrics.length (flutter/engine#13909)
2b007ed Roll fuchsia/sdk/core/mac-amd64 from 8X5fE... to bC9Qy... (flutter/engine#13919)
ad0cbdc Roll src/third_party/dart 5b72c1c669..d9d5fbc109 (5 commits) (flutter/engine#13917)
c4c1e57 Roll src/third_party/skia d4fb7c7b140d..d3ddcb403993 (21 commits) (flutter/engine#13915)
38147fa Roll fuchsia/sdk/core/linux-amd64 from kSMF7... to T9BAw... (flutter/engine#13914)
7c5ed6c Roll src/third_party/dart 62c67e40dc..5b72c1c669 (17 commits)
72b6a7e Roll buildroot to a985f7f63ac. (flutter/engine#13910)
e16a4b7 Roll fuchsia/sdk/core/mac-amd64 from Oo6E_... to 8X5fE... (flutter/engine#13912)
47e1026 Roll src/third_party/skia c9d263c1213e..d4fb7c7b140d (7 commits) (flutter/engine#13897)
2019-11-19 15:21:03 -08:00
Greg Spencer
a3186fbaa1
Analyze dartpad (#45124)
This fixes the sample code analysis to treat dartpad snippets in the same way as snippet snippets, which it wasn't until now (the snippet generator was treating them as "samples"), and some errors crept in. This PR also fixes those errors.

Also, added a --verbose option to the sample analyzer.
2019-11-19 15:16:12 -08:00
Jenn Magder
1f296ad78c
Remove chmod to make Flutter framework headers unwritable (#45189) 2019-11-19 15:13:33 -08:00
Emmanuel Garcia
6d77996d6a
Attach looks at future observatory URIs (#44637) 2019-11-19 15:11:41 -08:00
Danny Tuppeny
37eec86294
Allow web server device to use extension if started with --start-paused (#44263)
* Allow web server device to use extension if started with --start-paused

* Fix comment

* Remove browser-launch option that allowed using Chrome without launching Chrome

The web-server device should now be used if you don't want to launch a browser.

* Add tests for WebServerDevice with --start-paused

* Fixes from rebase

* More fixes from rebase

* Fix from rebase

* Fix condition for page refresh in non-debug builds

* Make dwds conditions match with a new getter

* Add missing .device
2019-11-19 20:11:53 +00:00
Danny Tuppeny
92e9f5f167
Increase memory from 8->10GB for tool_tests-commands-linux (#45178)
I've had many OOMKilled failures on Cirrus on this shard today on trivial PRs.
2019-11-19 19:52:02 +00:00
Greg Spencer
29ab6b549a
Update manual_tests to be able to run on macOS/web (#44830)
I updated the build files for manual_tests, as well as adding in a macos and web directory to allow the manual tests to be run on the web or on desktop.

The main change here are the parts that I added to the files in manual_tests/lib/... (the addition of kIsWeb to "if (!kIsWeb && Platform.isMacOS) {") The rest is just an update of the auto-generated code from flutter create.
2019-11-19 11:29:35 -08:00
Jason Simmons
68d1fe58da
Add the rally_assets package to Gallery's BUILD.gn (#45180) 2019-11-19 11:27:43 -08:00
Jonah Williams
df3505c1f3
Improve performance of build APK (~50%) by running gen_snapshot concurrently (#44534) 2019-11-19 11:26:07 -08:00
Jenn Magder
6e5769d425
Remove FLUTTER_DEVICELAB_XCODE_PROVISIONING_CONFIG code paths (#45136) 2019-11-19 11:19:44 -08:00
Per Classon
b5a85fcf48
Allow plural localized strings to not specify every case (#45168)
* Allow plural localized strings to not specify every case
2019-11-19 18:58:28 +01:00
Jonah Williams
e236196037
cache sdkNameAndVersion logic for web devices (#45145) 2019-11-19 09:36:24 -08:00
Per Classon
399aebc4b7
[Gallery] Add Material Study app Rally as an example app (#44907)
Add Material Study app Rally as an example app
2019-11-19 12:12:56 +01:00
Alexandre Ardhuin
0df8812681
fix type errors (#45151) 2019-11-19 09:28:24 +01:00
Alexandre Ardhuin
4bf03c6cf8
implicit-casts:false in flutter_test (#44996) 2019-11-19 08:10:24 +01:00
Alexandre Ardhuin
adc7351046
implicit-casts:false on flutter_tools/lib (#44447)
* implicit-casts:false on flutter_tools/lib

* address review comments

* use castStringKeyedMap

* introduce {bool,string,strings}Arg

* fix ci
2019-11-19 07:57:42 +01:00
engine-flutter-autoroll
152e6ec006
ecb32952f Roll src/third_party/dart 830f291773..62c67e40dc (15 commits) (#45147)
git@github.com:flutter/engine.git/compare/762294cf2d29...ecb32952ffcb

git log 762294cf2d29..ecb32952ffcb --no-merges --oneline
2019-11-19 bkonyi@google.com Roll src/third_party/dart 830f291773..62c67e40dc (15 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-19 01:03:50 -05:00
engine-flutter-autoroll
1b1365376b
Roll engine 9832bc8f2eb2..762294cf2d29 (8 commits) (#45144)
git@github.com:flutter/engine.git/compare/9832bc8f2eb2...762294cf2d29

git log 9832bc8f2eb2..762294cf2d29 --no-merges --oneline
2019-11-19 tvolkert@users.noreply.github.com Revert "RendererContextSwitch guard flutter's gl context rework. (#13812)" (flutter/engine#13906)
2019-11-19 bkonyi@google.com Roll src/third_party/dart 06e6554d2e..830f291773 (22 commits) (flutter/engine#13905)
2019-11-19 ferhat@gmail.com Fix withIn matcher distance function lookup (flutter/engine#13904)
2019-11-18 bkonyi@google.com Roll src/third_party/dart aceeba7567..06e6554d2e (2 commits) (flutter/engine#13900)
2019-11-18 ferhat@gmail.com Fix single line bitmap canvas text shadow (flutter/engine#13901)
2019-11-18 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from dhwMR... to kSMF7... (flutter/engine#13899)
2019-11-18 bkonyi@google.com Roll src/third_party/dart 7b67303318..aceeba7567 (8 commits)
2019-11-18 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from 6ZRA_... to Oo6E_... (flutter/engine#13894)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-19 00:05:51 -05:00
Kaushik Iska
f45bd48cca
Revert "[flutter_runner] Use sky_engine from the topaz tree (#44935)" (#45141)
This reverts commit f48f4573500e44a6a225dc994344a616a62cac5d.
2019-11-18 19:36:50 -08:00
Greg Spencer
6e10719dc5
FocusableActionDetector widget (#44867)
This adds a FocusableActionDetector, a widget which combines the functionality of Actions, Shortcuts, MouseRegion and a Focus widget to create a detector that defines actions and key bindings, and will notify that the focus or hover highlights should be shown or not. This widget can be used to give a control the required detection modes for focus and hover handling on desktop and web platforms.

I replaced a bunch of similar code in many of our widgets with this widget, and found that pretty much any control that wants to be focusable wants all of these features as well: focus highlights, hover highlights, and actions to activate it.

Also eliminated an extra _hasFocus variable in FocusState that wasn't being used.
2019-11-18 17:23:30 -08:00
Shi-Hao Hong
cce445e278
ignore vscode auto-generated files (#45080) 2019-11-18 16:25:32 -08:00
Amir Hardon
3c65463f89
Enable iOS platform views for Flutter Gallery (#45126)
While building the iOS platform views support we only enabled it when the app developer explicitly specified it with a flag, the main reasons were using an untested thread configuration, and taking a performance hit (even when no platform view is used due to disabled raster cache).

Now that we are using the same dynamic thread configuration whether platform views is used or not, and that raster cache works with platform views in the tree as well, we are almost ready to enabled the platform views support by default.

As a first step, I'm enabling it for the Flutter Gallery app on which we run benchmarks. After monitoring the benchmarks and making sure the gallery takes no hit we should be more confident to enabled platform views by default.

This change is expected to have no performance effect on the Gallery app at all.
2019-11-18 16:13:52 -08:00
Jonah Williams
58438fca3f Provide specific field to accept depfiles in target class (#44481)
* add depfile slot to Target class

* Update source.dart

* Update source.dart
2019-11-18 14:09:40 -08:00
Greg Spencer
d026f2d948
Properly interpret modifiers on GLFW key events (#44844)
GLFW key events set modifier flags based on what the modifier state was before the event, unlike every other platform. This modifies the GLFW key support to take that into account.

As a small cleanup, I fixed a documentation macro reference for the modifier flags that was duplicate
2019-11-18 14:07:08 -08:00
Greg Spencer
21158d8337
Add command key bindings to macOS text editing and fix selection. (#44130)
This adds support for the command key for text selection/editing on macOS. I had ported the text editing code (in #42879), but forgot to add support for the command key itself. This also adds a test that tests the text editing on multiple platforms instead of just testing Android.

There appears to still be a bug (filed #44135) where we're losing key events sometimes on macOS, leaving some keys "stuck" on, but this PR at least allows the right key combinations to be used.
2019-11-18 14:06:37 -08:00