DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
35,438 Commits 882 Branches 1,069 Tags
Commit Graph

35438 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jenn Magder
374dc4a4e3 Migrate PlatformMessageHandlerIos to ARC (flutter/engine#52226) 
Smart pointers support ARC as of https://github.com/flutter/engine/pull/47612, and the unit tests were migrated in https://github.com/flutter/engine/pull/48162.

Migrate `PlatformMessageHandlerIos` from MRC to ARC.  Clean up the `#include`s.

Part of https://github.com/flutter/flutter/issues/137801.
 2024-05-01 21:07:07 +00:00
chunhtai
c4415fb8e0 macOS fluttertextinputplugin drops selector called if no client (flutter/engine#52495) 
The observed behavior is that if a keypress both reach framework and flutter textinputplugin selector and the keypress handler in framework causes the the textinputplugin to resign first responder, the selector will still go through even if the textinputplugin has already resigned.

The pr makes it so textinputplugin will ignore these selector call

fixes https://github.com/flutter/flutter/issues/143270

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-05-01 20:57:39 +00:00
skia-flutter-autoroll
28c23852af Roll Skia from 0b31f64bd8d8 to 553b6e2eddc5 (5 revisions) (flutter/engine#52500) 
https://skia.googlesource.com/skia.git/+log/0b31f64bd8d8..553b6e2eddc5

2024-05-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 4a3a57f4bb79 to 6d0d7269a8c9
2024-05-01 johnstiles@google.com Fix uses of arithmetic conversion on enums.
2024-05-01 brianosman@google.com Add SkPath::addOpenOval
2024-05-01 robertphillips@google.com [graphite] Reduce the SkMatrixConvolutionImageFilter's program combinations
2024-05-01 borenet@google.com [infra] Roll infra, remove python2 hacks

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-01 20:51:54 +00:00
Chinmay Garde
6115e5ac3a [Impeller] Wire up hardware buffer backed swapchains on Android. (flutter/engine#52087) 
This wires up Android Hardware Buffer backed swapchains on platform that support
it (Android >= 29) with a KHR swapchain fallback (which can be removed later to
save on some binary size if needed).

Some salient features of these swapchains and their differences with the KHR
variant:

* All swapchain images are guaranteed to R8G8B8A8. This could potentially allow
  for earlier creation of the context and the PSO libraries.
* All swapchain allocations are lazy. This should greatly reduce the time it
  takes to create and resize a swapchain. However, swapchain image acquisition
  may take longer for the first few frame where there is no pre-pooled image
  available. Resizes should be similarly faster since the swapchain images for
  the intermediate sizes are never created.
* Swapchain transients allocations (the attachments for the root render target)
  are also lazily allocated.
* Swapchain images are pool and reused. The size of the pool is user specified
  (currently 2). If an image in the pool ages past a user supplied value
  (currently 1 second), it is collected as well. Applications that don't render
  frames for a long period of time should see less memory use because of
  swapchain image allocations.
* The present mode of AHB swapchains behave similar to KHR swapchains but with
  VK_PRESENT_MODE_MAILBOX_KHR. In cases where there is no application managed
  frame pipelining, this might cause images to never be presented if a newer
  image is available. This wasted work can only be avoided by application
  provided pipelining.
* There are no client side waits during image presentation. Instead, a new type
  of fence is wired up that exports its state as a sync file descriptor. The
  fence signal operation is enqueued on the client side and the buffer is set on
  the surface control. The presentation engine then performs the wait.
* On Qualcomm devices, Chromium seems to be setting vendor specified flags for
  opting the hardware buffers into using UBWC. AFAICT, this is similar to AFBC
  (and NOT AFRC) on ARM Mali. This has not been wired up since I don't have a
  Qualcomm device at the moment and cant verify bandwidth use using GPU
  counters. I would also like to verify that UBWC is safe to use to images that
  can be used as input attachments.
 2024-05-01 19:54:13 +00:00
skia-flutter-autoroll
343400ed74 Roll Skia from bfbd738fb97b to 0b31f64bd8d8 (3 revisions) (flutter/engine#52492) 
https://skia.googlesource.com/skia.git/+log/bfbd738fb97b..0b31f64bd8d8

2024-05-01 borenet@google.com [infra] Use vpython3 package instead of old vpython
2024-05-01 johnstiles@google.com Reject path triangulation after 500,000 self-intersections.
2024-05-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9384550810a5 to ae1ce5ca5a1e (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-01 17:19:22 +00:00
skia-flutter-autoroll
679f0f50fd Roll Dart SDK from d946408c559a to f5a429107c87 (2 revisions) (flutter/engine#52487) 
https://dart.googlesource.com/sdk.git/+log/d946408c559a..f5a429107c87

2024-05-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-119.0.dev
2024-05-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-118.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-01 16:11:03 +00:00
gaaclarke
4429b2f2fe [Impeller] Implements retry for Picture.toImage (flutter/engine#52470) 
fixes https://github.com/flutter/flutter/issues/146990

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-05-01 08:53:54 -07:00
John McCutchan
1c441f353d Fix et run (flutter/engine#52477) 
et run was broken in https://github.com/flutter/engine/pull/51803

this PR adds the missing calls to mangledConfigName before invoking flutter run
 2024-05-01 14:20:04 +00:00
skia-flutter-autoroll
324861ab69 Roll Skia from 5f4ebd628994 to bfbd738fb97b (2 revisions) (flutter/engine#52479) 
https://skia.googlesource.com/skia.git/+log/5f4ebd628994..bfbd738fb97b

2024-05-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 56ddf34cf380 to 8cb1d9ce0d7a
2024-05-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from c3eaa8e0f793 to 56ddf34cf380 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-01 07:23:11 +00:00
skia-flutter-autoroll
80effe9c51 Roll Fuchsia Linux SDK from HP2saK9sVOtKvpquC... to PIHl-e41i3mzbriG1... (flutter/engine#52480) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-01 07:05:46 +00:00
skia-flutter-autoroll
a9c7ae71c5 Roll Skia from a6bc04f984d2 to 5f4ebd628994 (1 revision) (flutter/engine#52478) 
https://skia.googlesource.com/skia.git/+log/a6bc04f984d2..5f4ebd628994

2024-05-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 690f568c5a84 to 816f6abb4c9a (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-01 05:41:12 +00:00
skia-flutter-autoroll
7bb3b4af6c Roll Dart SDK from c88854d4282c to d946408c559a (1 revision) (flutter/engine#52476) 
https://dart.googlesource.com/sdk.git/+log/c88854d4282c..d946408c559a

2024-05-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-117.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-01 04:09:16 +00:00
Chinmay Garde
967157ba26 [Impeller] Document the EGL toolkit. (flutter/engine#52469) 
No change in functionality. Just adds docs.
 2024-05-01 02:34:31 +00:00
Jackson Gardner
0d496c4a9e [skwasm] Change default FilterQuality to None for image shaders. (flutter/engine#52468) 
This brings the behavior in line with the CanvasKit renderer, which also uses `None` for the default image shader quality.

I added a few unit tests to cover different filter qualities. It turns out, there is a skia issue that manifests both in CanvasKit and Skwasm when a lazy image is rendered with medium quality. See https://g-issues.skia.org/issues/338095525
 2024-05-01 00:07:22 +00:00
skia-flutter-autoroll
b5f464502f Roll Dart SDK from 3f649c97a08c to c88854d4282c (1 revision) (flutter/engine#52475) 
https://dart.googlesource.com/sdk.git/+log/3f649c97a08c..c88854d4282c

2024-04-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-116.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-01 00:07:20 +00:00
skia-flutter-autoroll
df518eb9dd Roll Skia from 30aaaef0390d to a6bc04f984d2 (1 revision) (flutter/engine#52471) 
https://skia.googlesource.com/skia.git/+log/30aaaef0390d..a6bc04f984d2

2024-04-30 kjlubick@google.com Escape unicode sequence

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-30 22:17:52 +00:00
skia-flutter-autoroll
9d9c7cd66c Roll Skia from 85ec65ecd5ec to 30aaaef0390d (4 revisions) (flutter/engine#52466) 
https://skia.googlesource.com/skia.git/+log/85ec65ecd5ec..30aaaef0390d

2024-04-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from f83e07df2219 to 4a3a57f4bb79
2024-04-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 09d0317bc33e to 9384550810a5 (10 revisions)
2024-04-30 kjlubick@google.com Tweak harfbuzz dep for legacy Bazel build
2024-04-30 bwils@google.com Run prettier on all sample skotties

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-30 20:56:54 +00:00
skia-flutter-autoroll
b6fab0f7b1 Roll Dart SDK from 7a517de88964 to 3f649c97a08c (1 revision) (flutter/engine#52465) 
https://dart.googlesource.com/sdk.git/+log/7a517de88964..3f649c97a08c

2024-04-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-115.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-30 20:16:07 +00:00
skia-flutter-autoroll
531357bdff Roll Skia from 77350e051f71 to 85ec65ecd5ec (2 revisions) (flutter/engine#52464) 
https://skia.googlesource.com/skia.git/+log/77350e051f71..85ec65ecd5ec

2024-04-30 johnstiles@google.com Simplify binary search in tessellate_stroked_curve.
2024-04-30 johnstiles@google.com Use dot product when computing distance field gradients.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-30 19:52:39 +00:00
skia-flutter-autoroll
814ba016c7 Roll Skia from 8f2d039e1190 to 77350e051f71 (1 revision) (flutter/engine#52460) 
https://skia.googlesource.com/skia.git/+log/8f2d039e1190..77350e051f71

2024-04-30 jvanverth@google.com Fix offscreen size in Viewer for some GMs.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-30 17:42:05 +00:00
skia-flutter-autoroll
425c5977e9 Roll Skia from 459555f490bf to 8f2d039e1190 (1 revision) (flutter/engine#52458) 
https://skia.googlesource.com/skia.git/+log/459555f490bf..8f2d039e1190

2024-04-30 kjlubick@google.com [bazel] Make it possible to replace @skshaper with select

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-30 15:23:05 +00:00
skia-flutter-autoroll
c10b365dd2 Roll Dart SDK from 4144af4e4704 to 7a517de88964 (1 revision) (flutter/engine#52456) 
https://dart.googlesource.com/sdk.git/+log/4144af4e4704..7a517de88964

2024-04-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-114.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-30 13:48:22 +00:00
skia-flutter-autoroll
06d97be35a Roll Skia from b20651c1aad4 to 459555f490bf (1 revision) (flutter/engine#52455) 
https://skia.googlesource.com/skia.git/+log/b20651c1aad4..459555f490bf

2024-04-30 robertphillips@google.com Revert "[graphite] Revert KeyContext copy ctor behavior to earlier state"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-30 12:06:34 +00:00
skia-flutter-autoroll
c081b19991 Roll Skia from 0b22a72dffeb to b20651c1aad4 (3 revisions) (flutter/engine#52454) 
https://skia.googlesource.com/skia.git/+log/0b22a72dffeb..b20651c1aad4

2024-04-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from c3eaa8e0f793 to 0589073495d2
2024-04-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5eaadb2feb71 to 09d0317bc33e (8 revisions)
2024-04-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 94a452f2f2ae to c3eaa8e0f793 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-30 07:02:19 +00:00
dependabot[bot]
53d8330ec3 Bump actions/checkout from 4.1.3 to 4.1.4 (flutter/engine#52453) 
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.3 to 4.1.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v4.1.4</h2>
<h2>What's Changed</h2>
<ul>
<li>Disable <code>extensions.worktreeConfig</code> when disabling <code>sparse-checkout</code> by <a href="https://github.com/jww3"><code>@​jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1692">actions/checkout#1692</a></li>
<li>Add dependabot config by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1688">actions/checkout#1688</a></li>
<li>Bump word-wrap from 1.2.3 to 1.2.5 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1643">actions/checkout#1643</a></li>
<li>Bump the minor-actions-dependencies group with 2 updates by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1693">actions/checkout#1693</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4.1.3...v4.1.4">https://github.com/actions/checkout/compare/v4.1.3...v4.1.4</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md">actions/checkout's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h2>v4.1.4</h2>
<ul>
<li>Disable <code>extensions.worktreeConfig</code> when disabling <code>sparse-checkout</code> by <a href="https://github.com/jww3"><code>@​jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1692">actions/checkout#1692</a></li>
<li>Add dependabot config by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1688">actions/checkout#1688</a></li>
<li>Bump the minor-actions-dependencies group with 2 updates by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1693">actions/checkout#1693</a></li>
<li>Bump word-wrap from 1.2.3 to 1.2.5 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1643">actions/checkout#1643</a></li>
</ul>
<h2>v4.1.3</h2>
<ul>
<li>Check git version before attempting to disable <code>sparse-checkout</code> by <a href="https://github.com/jww3"><code>@​jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1656">actions/checkout#1656</a></li>
<li>Add SSH user parameter by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1685">actions/checkout#1685</a></li>
<li>Update <code>actions/checkout</code> version in <code>update-main-version.yml</code> by <a href="https://github.com/jww3"><code>@​jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1650">actions/checkout#1650</a></li>
</ul>
<h2>v4.1.2</h2>
<ul>
<li>Fix: Disable sparse checkout whenever <code>sparse-checkout</code> option is not present <a href="https://github.com/dscho"><code>@​dscho</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1598">actions/checkout#1598</a></li>
</ul>
<h2>v4.1.1</h2>
<ul>
<li>Correct link to GitHub Docs by <a href="https://github.com/peterbe"><code>@​peterbe</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1511">actions/checkout#1511</a></li>
<li>Link to release page from what's new section by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1514">actions/checkout#1514</a></li>
</ul>
<h2>v4.1.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1396">Add support for partial checkout filters</a></li>
</ul>
<h2>v4.0.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1067">Support fetching without the --progress option</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1436">Update to node20</a></li>
</ul>
<h2>v3.6.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1377">Fix: Mark test scripts with Bash'isms to be run via Bash</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/579">Add option to fetch tags even if fetch-depth &gt; 0</a></li>
</ul>
<h2>v3.5.3</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1196">Fix: Checkout fail in self-hosted runners when faulty submodule are checked-in</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1287">Fix typos found by codespell</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1369">Add support for sparse checkouts</a></li>
</ul>
<h2>v3.5.2</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1289">Fix api endpoint for GHES</a></li>
</ul>
<h2>v3.5.1</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1246">Fix slow checkout on Windows</a></li>
</ul>
<h2>v3.5.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1237">Add new public key for known_hosts</a></li>
</ul>
<h2>v3.4.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1209">Upgrade codeql actions to v2</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1210">Upgrade dependencies</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1225">Upgrade <code>@​actions/io</code></a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="0ad4b8fada"><code>0ad4b8f</code></a> Prep Release v4.1.4 (<a href="https://redirect.github.com/actions/checkout/issues/1704">#1704</a>)</li>
<li><a href="43045ae669"><code>43045ae</code></a> Disable <code>extensions.worktreeConfig</code> when disabling <code>sparse-checkout</code> (<a href="https://redirect.github.com/actions/checkout/issues/1692">#1692</a>)</li>
<li><a href="37b082107b"><code>37b0821</code></a> Bump the minor-actions-dependencies group with 2 updates (<a href="https://redirect.github.com/actions/checkout/issues/1693">#1693</a>)</li>
<li><a href="9839dc14a0"><code>9839dc1</code></a> Add dependabot config (<a href="https://redirect.github.com/actions/checkout/issues/1688">#1688</a>)</li>
<li><a href="9b4c13b0bf"><code>9b4c13b</code></a> Bump word-wrap from 1.2.3 to 1.2.5 (<a href="https://redirect.github.com/actions/checkout/issues/1643">#1643</a>)</li>
<li>See full diff in <a href="1d96c772d1...0ad4b8fada">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=4.1.3&new-version=4.1.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
 2024-04-30 06:23:22 +00:00
skia-flutter-autoroll
4cab914abf Roll Skia from e9d3faf63fce to 0b22a72dffeb (1 revision) (flutter/engine#52451) 
https://skia.googlesource.com/skia.git/+log/e9d3faf63fce..0b22a72dffeb

2024-04-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 9e232c0d6fc8 to 690f568c5a84 (217 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-30 06:02:08 +00:00
skia-flutter-autoroll
548e4ad90d Roll Dart SDK from 9eb838fa00af to 4144af4e4704 (4 revisions) (flutter/engine#52450) 
https://dart.googlesource.com/sdk.git/+log/9eb838fa00af..4144af4e4704

2024-04-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-113.0.dev
2024-04-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-112.0.dev
2024-04-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-111.0.dev
2024-04-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-110.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-30 05:46:11 +00:00
skia-flutter-autoroll
ec205bfa46 Roll Fuchsia Linux SDK from TFm2_qWC2xpkzk8QS... to HP2saK9sVOtKvpquC... (flutter/engine#52449) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-30 05:42:06 +00:00
John McCutchan
845c75ce6c Workaround HardwareRenderer breakage in Android 14 (flutter/engine#52370) 
- Destroy ImageReaders on memory trim.
- Unset the VirtualDisplay's surface on memory trim.
- On resume, recreate ImageReaders.
- On resume, do a dumb little dance and then set the VirtualDisplay's surface

Fixes: https://github.com/flutter/flutter/issues/146499
Fixes: https://github.com/flutter/flutter/issues/144219

Internal bug: b/335646931
Android Fix: https://googleplex-android-review.git.corp.google.com/c/platform/frameworks/base/+/27015418

Android 15 will include the fix. Unclear if Android 14 will be patched.
 2024-04-30 05:09:05 +00:00
skia-flutter-autoroll
89240e7624 Roll Skia from 29a483abf358 to e9d3faf63fce (1 revision) (flutter/engine#52444) 
https://skia.googlesource.com/skia.git/+log/29a483abf358..e9d3faf63fce

2024-04-29 kjlubick@google.com Remove duplicated .cpp files in Bazel rules

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-30 00:04:07 +00:00
Zachary Anderson
7de6e0dcc1 Add commands to rbe.md (flutter/engine#52442) 2024-04-29 23:00:25 +00:00
Chinmay Garde
a5ed4ed7d5 Add a host_debug_unopt_arm64 macOS configuration. (flutter/engine#52443) 
This is the default development configuration for local engine host builds on the corp M1 macOS boxes.
 2024-04-29 22:55:05 +00:00
skia-flutter-autoroll
b91460396a Roll Skia from 9ffb18cccf2a to 29a483abf358 (2 revisions) (flutter/engine#52441) 
https://skia.googlesource.com/skia.git/+log/9ffb18cccf2a..29a483abf358

2024-04-29 johnstiles@google.com Factor out fold_two_constants into a helper function.
2024-04-29 johnstiles@google.com Remove unnecessary virtual from method.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-29 22:30:05 +00:00
skia-flutter-autoroll
8741c56c71 Roll Skia from 953589c71b4a to 9ffb18cccf2a (4 revisions) (flutter/engine#52438) 
https://skia.googlesource.com/skia.git/+log/953589c71b4a..9ffb18cccf2a

2024-04-29 jamesgk@google.com [graphite] Analytic blur for rrects
2024-04-29 bungeman@google.com Roll depot_tools and recipes-py
2024-04-29 brianosman@google.com Simplify/optimize SkPath::hasOnlyMoveTos
2024-04-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a2456e74640e to 5eaadb2feb71 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-29 20:21:15 +00:00
skia-flutter-autoroll
19355a7425 Roll Skia from f7bfa8eef5b5 to 953589c71b4a (6 revisions) (flutter/engine#52437) 
https://skia.googlesource.com/skia.git/+log/f7bfa8eef5b5..953589c71b4a

2024-04-29 brianosman@google.com Add SkArc (in)equality operators
2024-04-29 johnstiles@google.com Add a FixedArray class to shrink SkSL::ComponentArray.
2024-04-29 johnstiles@google.com Clean up TArray tests and add a comparison test.
2024-04-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from b0e42fbd5e63 to f83e07df2219
2024-04-29 kjlubick@google.com Remove reference to deleted file
2024-04-29 johnstiles@google.com Remove unused version of Swizzle::Convert.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-29 18:12:23 +00:00
Zachary Anderson
448613ae74 Remove references to goma (flutter/engine#52411) 
This removes goma most places except for the arguments to the `gn`
script, which are referenced by recipes. This does not remove goma
capabilities from the GN build entirely. That requires changes in the
buildroot which have to be staged after this change.
 2024-04-29 09:40:16 -07:00
Kaylee Lubick
b763678f03 Make SkUnicode explicitly instead of relying on SkParagraph to make it for us (flutter/engine#52086) 
In https://skia-review.googlesource.com/c/skia/+/838417 Skia staged the
removal of automatically creating an SkUnicode as part of the effort to
make Skia more modular. Clients will now have to construct and SkUnicode
and pass it to SkParagraph to provide the appropriate data. Flutter
sometimes uses ICU and sometimes uses a "client" SkUnicode which makes
use of the browser APIs to get the data.

We should come back to the skwasm code especially, because right now
skwasm gets the data necessary to make an SkUnicode::Client, but stores
it in the ParagraphBuilder, just to take it out again later to make the
SkUnicode::Client and pass that back into the ParagraphBuilder. skwasm
should just create the SkUnicode::Client directly and pass it to the
ParagraphBuilder::make().

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-04-29 11:59:33 -04:00
skia-flutter-autoroll
a93cd5f570 Roll Skia from 27e872349963 to f7bfa8eef5b5 (1 revision) (flutter/engine#52436) 
https://skia.googlesource.com/skia.git/+log/27e872349963..f7bfa8eef5b5

2024-04-29 johnstiles@google.com Report an error if `sk_Caps` is used as an SkSL expression.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-29 14:48:33 +00:00
Jonah Williams
8f21d27541 [Impeller] fix GLES image upload. (flutter/engine#52430) 
TLDR: this was a load bearing closure.

See https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20complex_layout_scroll_perf_impeller_gles__timeline_summary/1492/overview
 2024-04-29 14:24:21 +00:00
skia-flutter-autoroll
6a25ce6b0f Roll Skia from aeab79038011 to 27e872349963 (1 revision) (flutter/engine#52435) 
https://skia.googlesource.com/skia.git/+log/aeab79038011..27e872349963

2024-04-29 robertphillips@google.com [graphite] Revert KeyContext copy ctor behavior to earlier state

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-29 13:36:10 +00:00
skia-flutter-autoroll
df5eafad93 Roll Skia from c720e2446926 to aeab79038011 (1 revision) (flutter/engine#52434) 
https://skia.googlesource.com/skia.git/+log/c720e2446926..aeab79038011

2024-04-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 94a452f2f2ae to bca2b386b5e5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-29 07:17:01 +00:00
skia-flutter-autoroll
10be137655 Roll Skia from 1a5436d50954 to c720e2446926 (1 revision) (flutter/engine#52433) 
https://skia.googlesource.com/skia.git/+log/1a5436d50954..c720e2446926

2024-04-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 07bdf2c05272 to 94a452f2f2ae (20 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-29 05:59:30 +00:00
skia-flutter-autoroll
9e43a8b820 Roll Fuchsia Linux SDK from bIUvi3y4gRFxMSKV3... to TFm2_qWC2xpkzk8QS... (flutter/engine#52432) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-29 04:35:34 +00:00
skia-flutter-autoroll
a1fc2188c2 Roll Skia from e3dfcd1b25af to 1a5436d50954 (1 revision) (flutter/engine#52431) 
https://skia.googlesource.com/skia.git/+log/e3dfcd1b25af..1a5436d50954

2024-04-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5c853cf916a0 to a2456e74640e (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-29 04:19:18 +00:00
Robert Ancell
2ab69c9f42 Use a AT-SPI socket/plug to export the Flutter accessibility state. (flutter/engine#52355) 
This will be useful when using GTK4, which doesn't support custom a11y
code in GTK and will require the Flutter code to be exported in a plug.
 2024-04-29 09:34:20 +12:00
Jonah Williams
584a0394aa [Impeller] remove image upload from IO thread, limit concurrent worker threads. (flutter/engine#52423) 
Fixes https://github.com/flutter/flutter/issues/123058
Fixes https://github.com/flutter/flutter/issues/135443

We're currently using the IO thread to bottleneck image uploads. Instead, just use fewer concurrent worker threads - and cap the limit at something small. For a Pixel device, this should use about 2 threads maximum, instead of  5 (4 worker and 1 IO).
 2024-04-28 17:22:15 +00:00
Jonah Williams
185f7cc518 [Impeller] when creating new pipeline variant block on current thread, re-persist dirty pipeline cache. (flutter/engine#52375) 
Current diagram of how PSO variants are created (after first bootstrap)

```
Raster thread.                             Worker Thread
1.  Check Pipeline Cache
2. Pipeline Cache Empty
3. Create Promise
4. Spawn Worker                     ->      Compile Pipeline
5. Block On Future.                       ..                                                    
6.
7. Resolve                          <-      Complete Future
```

This is a serialized workload due to blocking on future completion. But performing it on two threads means that we're also adding in the somewhat random cost of thread scheduling and or getting deprioritized.

Instead when creating variants, block on the current thread. Now if we knew all the variants we need to create for a frame ahead of time, we could spawn one or more works to creat them more quickly. This would require more work though.

While I'm at it. Update the pipeline cache to persist every 50 frames, if it has added a new shader.

part of https://github.com/flutter/flutter/issues/129660
 2024-04-28 17:22:13 +00:00
skia-flutter-autoroll
229c530d87 Roll Skia from 362737e0d9ad to e3dfcd1b25af (2 revisions) (flutter/engine#52429) 
https://skia.googlesource.com/skia.git/+log/362737e0d9ad..e3dfcd1b25af

2024-04-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from a42fa34aea30 to 94a452f2f2ae
2024-04-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9dbe6ddebdf8 to 5c853cf916a0 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jimgraham@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-28 07:26:22 +00:00
skia-flutter-autoroll
064bd92699 Roll Dart SDK from 7173b4dd0163 to 9eb838fa00af (3 revisions) (flutter/engine#52428) 
https://dart.googlesource.com/sdk.git/+log/7173b4dd0163..9eb838fa00af

2024-04-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-109.0.dev
2024-04-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-108.0.dev
2024-04-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-107.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-28 05:00:23 +00:00
skia-flutter-autoroll
538b6634b8 Roll Fuchsia Linux SDK from SVcynyah0BO4d5mRM... to bIUvi3y4gRFxMSKV3... (flutter/engine#52427) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-04-28 03:02:22 +00:00