10387 Commits

Author SHA1 Message Date
xster
33fea5c19a
Remove the 'demo' wording from gallery (#15640) 2018-03-19 17:03:56 -07:00
xster
d8f360717f
Add a way to generically go back on both Material and Cupertino scaffold pages (#15602)
* Add a way to generically go back on both Material and Cupertino scaffold pages

* review

* lint

* review

* Fix text assert text
2018-03-19 16:57:05 -07:00
Ian Hickson
4a2217b3d2
Improve documentation regarding padding for dialogs. (#15399) 2018-03-19 16:42:50 -07:00
Ian Hickson
28352c3f5f
Document the sample API doc analyzer (#14740) 2018-03-19 16:42:30 -07:00
Ian Hickson
b24a3a118c
Update some READMEs under dev/. (#15712) 2018-03-19 16:41:36 -07:00
Ian Hickson
da27d674a4
Move dialogs when keyboard pops up (#15426)
Fixes #7032
2018-03-19 15:52:25 -07:00
Hans Muller
076594b3fd
Added Indonesian (id) and Norwegian (no) locales (#15708) 2018-03-19 15:07:13 -07:00
Victor Choueiri
7edd5c8d6c Allow null flutter schema in pubspec (#15690) 2018-03-19 14:55:54 -07:00
Greg Spencer
10fe2056f3
Add a slider demo, and a text theme for SliderThemeData (#15620)
This adds a slider demo with a custom theme to the gallery.

In the process of adding this, I decided to add a text theme to the SliderThemeData, since it's a pain to change the text style on the value indicator otherwise.
2018-03-19 14:50:29 -07:00
xster
7a2853012f
Revert "Add a simple convenience test task runner for VSCode (#15417)" (#15705)
This reverts commit c8fd99fb3313c73eb03210a3af037cd2d150ef51.
2018-03-19 13:43:34 -07:00
Alexander Aprelev
21ad09fe57
With dart2 being default, move preview_dart_2 tests to dart1. (#15667)
* With dart being default, move preview_dart_2 tests to dart1.

* Swap out defaults for preview-dart-2 option in tests. Make dart1 explicit

* Move suffix around

* Rename files
2018-03-19 12:11:18 -07:00
Matan Lurey
81070893be
Fix Dart2 compatibility with flutter_tools' tests. (#15699) 2018-03-19 11:45:44 -07:00
Jason Simmons
1c04f951c8
Warn about missing host build binaries when compiling with a local engine (#15626)
Fixes https://github.com/flutter/flutter/issues/15361
2018-03-19 11:29:20 -07:00
Alexander Aprelev
6acf76f7be
Use uris for hot reload invalidation. (#15698)
* Use uris for hot reload invalidation.

* Clean up unneccessary conversions

* add final.

* Revert sample change
2018-03-19 11:17:16 -07:00
Jonah Williams
91dcfc5dd2
stderr can be null or empty string (#15701) 2018-03-19 10:53:04 -07:00
Alexander Aprelev
d6bac5fd4a
Add const to list literal. (#15693)
This is follow-up to https://github.com/flutter/flutter/pull/15537 to make dart1 coverage test happy.
2018-03-19 08:29:56 -07:00
Yegor
9c49255f3e
a11y: remove SemanticsSortOrder; sort locally only; semanticsOwner post-test check (#15537)
* a11y: remove SemanticsSortOrder; sort locally only; semanticsOwner post-test check

* update accessibility test framework

- default nextNodeId/previousNodeId to -1
- stop treating null as opt-out from value testing
- add `id`, `TestSemantics.root`, and `tags` to the suggested code in the TestSemantics failure message
- fix a small bug with raw string escaping
- update all tests accordingly

* fix sortKey doc

* prefer const over final
2018-03-18 22:18:52 -07:00
Ian Hickson
b494e71e36
Improve async builder docs (#15373) 2018-03-18 22:00:47 -07:00
Ian Hickson
42e4e16b47
Fix clipping in FittedBox (#15418)
Fixes https://github.com/flutter/flutter/issues/15410
2018-03-18 22:00:14 -07:00
Ian Hickson
6758b55c8d
Fix weird bug when switching text from errorText to helperText (#15390) 2018-03-18 21:54:03 -07:00
xster
0e8b187728
Turn on Material page transition fade effect for Gallery (#15583) 2018-03-17 16:52:13 -07:00
Alexander Aprelev
43284d70d9
Reland filesystem options support with fix for Windows test. (#15655)
* Revert "Revert "Reland pass filesystem options (#15622)" (#15651)"

This reverts commit 0f3eada0664e208bb8c65a5aa02daec38997e8b9.

* Fix for windows failing test

* !isEmpty -> isNotEmpty
2018-03-17 12:47:40 -07:00
Jonah Williams
298f4efc54
Fail ios workflow when simctl does not work (#15628)
* fail ios workflow when simctl does not work

* missed rename commit

* address comments
2018-03-17 10:57:51 -07:00
Chris Bracken
60c99ef67d
Roll engine to 1348ab5b63adc18148f161876a4b1cacd5ec0779 (#15645)
Includes:
* Roll Dart to f1ebe2bd5cfcb6b522e5b4fd406cdabb1a2d2091. (#4805)
2018-03-17 10:08:43 -07:00
Alexander Aprelev
0f3eada066
Revert "Reland pass filesystem options (#15622)" (#15651)
This reverts commit bbcf55a5b086559dc992c0657bcde0d95c1bc26e as it breaks hot reload on Windows.
2018-03-17 08:11:52 -07:00
Alexander Aprelev
bbcf55a5b0
Reland pass filesystem options (#15622)
* Revert "Revert "Pass filesystem-root, filesystem-scheme options through `flutter run, build` and gradle. (#15592)" (#15621)"

This reverts commit c663e3367da7c6b8b6571e7fcbf3b1050c805c78.

* Check whether filesystem-root is emtpy.

* Restore broken merge

* Fix windows test

* Adjust regex in test. Invalidate files by file path.
2018-03-17 06:49:15 -07:00
Chris Bracken
992875c21e
Roll engine to 464af48eb202ac7c6c43e2af64aadec9a72d9bb6 (#15637)
Includes:
* [fuchsia] Updated scenic fidl prefix (flutter/engine#4798)
* Cache render buffer extents when no depth/stencil buffer (flutter/engine#4801)
* Eliminate iOS depth/stencil buffer code (flutter/engine#4802)
* [fuchsia] Adapt to FIDL1 VectorPtr API (flutter/engine#4804)
2018-03-17 00:33:18 -07:00
Chris Bracken
059aea95e4
Roll engine to 3e9912698955ed5a2ebc5c9433197c42c8c068f3 (#15633)
Includes:
* Provide lookup key to access Flutter assets in the APK (flutter/engine#4785)
* Roll skia and update licenses (flutter/engine#4797)
* libtxt: retain hard line breaks when calculating maxIntrinsicWidth (flutter/engine#4796)
2018-03-16 22:30:28 -07:00
Alexander Aprelev
cbbf4d4b1b
Run test coverage in dart1 mode. (#15635)
Running test coverage in dart2 mode runs over allocated timeslot on bots.
2018-03-16 17:44:47 -07:00
Jason Simmons
2cbe01df4b
Fix a Dart 2 type error in the Stocks example (#15634) 2018-03-16 17:39:50 -07:00
Siva
8379927985
Fix strong mode error in platform_channel/main.dart (#15624)
* Fix strong mode error in platform_channel/main.dart

* Addres code review comments.
2018-03-16 16:21:33 -07:00
Jason Simmons
6d5810eced
Fix an analyzer warning (#15627) 2018-03-16 15:54:44 -07:00
Vyacheslav Egorov
71b2cfb2a0
Turn Dart 2 mode by default. (#15565) 2018-03-16 20:29:38 +01:00
Alexander Aprelev
c663e3367d
Revert "Pass filesystem-root, filesystem-scheme options through flutter run, build and gradle. (#15592)" (#15621)
This reverts commit 0f659fb10b84fc0192c06ce351b00f6900b3408a as it
breaks bin/tasks/gradle_plugin_test.dart.
2018-03-16 12:28:30 -07:00
Alexander Aprelev
0f659fb10b
Pass filesystem-root, filesystem-scheme options through flutter run, build and gradle. (#15592)
* Pass filesystem-root, filesystem-scheme options through flutter run/build/gradle.
2018-03-16 11:16:54 -07:00
Jason Simmons
95fbd819fa
Place the transform and its children within the RenderFlow's opacity layer (#15543)
Fixes https://github.com/flutter/flutter/issues/15037
2018-03-16 10:37:01 -07:00
Mikkel Nygaard Ravn
340c68038a
Make standard codecs extensible (#15414) 2018-03-16 16:17:56 +00:00
Mikkel Nygaard Ravn
2d5ebd2a18
Roll engine to 9671f634591295aca35943df1cc589e9fbf59d14 (#15607) 2018-03-16 15:09:01 +00:00
Mikkel Nygaard Ravn
04de8c0a43
Adjust flaky flags to reality (#15608)
Get to green build.
2018-03-16 11:17:23 +00:00
Nicholas Rebhun
ab56c63971 Update README; beta release (#15098) 2018-03-16 00:29:49 -07:00
Hans Muller
c599662903
Added a Backdrop demo to the Gallery (#15579) 2018-03-15 17:52:09 -07:00
David Shuckerow
dd0acea1ec
Add support for placing the FAB in different positions (#14368)
* Add support to move the fab between positions.

* Motion demo for the FAB works between center and end floating.

* Add a Material curve to the offset animation.

* Move the fab position into an object

* Updates to docs

* Updates to docs

* Fix a lint on the bottom sheet type

* Add a ScaffoldGeometry class

* Improve the documentation

* Improve the documentation

* Add a fab motion animator

* Add position and scale animations

* FAB entrance and motion animations work

* Get started on FAB motion

* Make fab animation work properly.

* Change the fab animator to be stored in the state of the scaffold.

* Add a layout test

* Fix spacing being off

* Fix the entrance/exit animation test.

* Add a textDirection to the layout delegate.

* Fix const constructor lint checks

* Add toStrings for the fab positioner/animator

* Add a toString for CurveTween

* Change the fab motion demo icon to a simple add icon.

* Add tests and a custom fab positioner to the demo.

* Do not start the fab's motion animation when the fab is null.

* Adjust the code to pass the new tests.

* Rename for in response to Hans' comment.

* Revert the tabs fab demo

* Use timeDilation, and clean up the animation code a little.

* Clean up the prelayout geometry docs and ctr order

* Cleanup fab transition widget code

* Clean up comments on Scaffold, add cross-references between the two geometries

* Explain the fab motion animation scheduling better

* Add a const to the fab motion demo

* Make the fab animation never jank by keeping track of where to move the fab to in the future.

* Add a default fab positioner constant

* Add space after comma in the demo

* Add boilerplate dartdoc to all const constructors

* Comment improvement

* Rename 'fabSize' to 'floatingActionButtonSize'

* Rename 'fabSize' to 'floatingActionButtonSize'

* Rename 'fabSize' to 'floatingActionButtonSize'

* Clean up the prelayout geometry object's dartdoc

* Clean up the prelayout geometry object's dartdoc

* Remove extraneous comment

* Change possessive uses of Scaffold's to use dartdoc-compatible [Scaffold]'s

* Rename the horizontalFabPadding to an expansion

* Clean up controller cleanup and setState usage

* Animate instead of lerp

* Make the fab position animation use offsets instead of animations

* Streamline the fab motion demo

* Set up the animator to start from a reasonable place when interrupting animations.

* Doc cleanup on the new animation interruption

* Expand some uses of fab and clean up constants

* Expand remaining public uses of fab to floating action button

* Expand remaining public uses of fab to floating action button

* Expand on the documentation for the fab positioner and animator

* Refactor animations to broadcast the position properly.

* Add the ability to turn on and off the fab to the motion demo.

* Remove unused code

* Change the fab animator to animate even when the fab is exitting.

* Remove extra positioner.

* Apps -> Applications in docs

* Explain the scale animation.

* Name the child parameter in the animated builder

* RTL before LTR

* Wrap the AppBar in the example code

* const the fab motion demo name

* Start a test against animation jumps

* Test for jumps in the fab motion animation

* Dont initialize values to null

* Use constants, fix spacing from some of Hans' comments

* Clarify the relationship between fab positioners and prelayout geometries

* Explain the fab animmator a bit better

* Explain the animation progress in the fab animation

* Explain the animation restart better

* Explain the animation restart better

* Explain the prelayout geometry better

* Explain that height is a vertical distance.

* Explain the horizontal fab padding

* Update the scaffold size description to explain what happens when a wild keyboard appears

* Remove print statements

* Update the scaffold geometry with information about it being available at paint time.

* In one step of a transition

* Explain how the top-start fab positioner works

* Explain how the top-start fab positioner works

* Refactor the scaffold layout to just pass a padding instead of a bottom, top, start and end.

* Refactor the scaffold layout to just pass a padding instead of a bottom, top, start and end.

* Action buttons with with custom positioners.

* Add a rotation animation example.

* Use a swap animation to show swapping between two different animations.

* Use a swap animation to show swapping between two different animations.

* Add an example for the size animations.

* 2018 copyright

* Extra empty line

* Return new Scaffold

* Extra blank line fix

* All its contents have been laid out

* Position the fab

* Explain what the scaffold geometry is for.

* Move asserts to different lines

* The scaffoldsize will not

* Initial rename of FabPositioners to FloatingActionButtonLocation

* Rename comments in example to refer to location instead of positioner.

* Rename fabpositioner to location in tests and in the scaffold field

* Finish removing references to positioner in scaffold code.

* Split the fab location and animation out into a separate file.

* Make things more private

* Import foundation instead of meta

* Const curve instead of final.
2018-03-15 17:04:24 -07:00
Hans Muller
600739d195
Fix "my be entered" should be "may be entered" typo (#15540) 2018-03-15 12:06:37 -07:00
Keerti Parthasarathy
50190d2810
Do not encode the server port in the test file (#15535)
* Do not encode the server port in the test file

* revert formatting

* add back ignore

* add a default value to serverPort

* address comments
2018-03-15 10:56:10 -07:00
Siva
c640b19167
Roll engine to version 520529dbba9b3048f5cc0e0268a274911f3887e6 (#15560)
- picks up dart change to introduce multi root file system for use in
google3 builds
2018-03-15 07:30:32 -07:00
Vyacheslav Egorov
d693d427d8
Upgrade packages to pull in newest petitparser with Dart 2 fixes. (#15558)
* Upgrade packages to pull in newest petitparser with Dart 2 fixes.

* Don't allow Dart 2 failures.

* Address new lints discovered by updated analyzer.
2018-03-15 11:11:13 +01:00
Siva
8c75dcf1bd
Engineroll (#15547)
* iupdate engine version to 141176b9004d7b01325629fd45b2ef61b0d00251

* update engine version to f192c59d76c0afe63f2290c3ed76061f00c77cc7
This rolls dart to version 0175f24b2549732d0010708988fd328440c3f956

* Move dart 2 tests back to optional section to allow debugging of a new
regression in the petitParser package.

* Update
2018-03-15 00:18:34 -07:00
xster
85d42fb396
Wrap route transitions above the transition as well to prevent repaints (#15534) 2018-03-14 18:37:53 -07:00
Marcin Urbański
2609876c8f Fix misspelling in tab description (#15449)
Actual text: "Tab 2 of $3"
Expected text: "Tab 2 of 3"
2018-03-14 16:04:06 -07:00
Conor Dockry
b0f7da9249 Choose default icon color based on theme brightness (#15450)
* Use theme for default icon color

Replaces hard-coded black.

* Better icon defaults for dark/light modes

* Add default case to silence warning
2018-03-14 16:01:38 -07:00