34443 Commits

Author SHA1 Message Date
Justin McCandless
3128df832a
Disableable ContextMenuButtonItems (#124253)
Fixes https://github.com/flutter/flutter/issues/124247

| Native | Flutter before | Flutter after |
| --- | --- | --- |
| <img width="248" alt="Screenshot 2023-04-05 at 9 26 16 AM" src="https://user-images.githubusercontent.com/389558/230177116-154999e8-eef3-441d-9fe9-7063839a6b99.png"> | <img width="240" alt="Screenshot 2023-04-05 at 11 18 01 AM" src="https://user-images.githubusercontent.com/389558/230177125-1680e851-223e-4956-b5b6-1a24e11dc22a.png"> | <img width="226" alt="Screenshot 2023-04-05 at 11 17 36 AM" src="https://user-images.githubusercontent.com/389558/230177123-bde82134-67e1-4ce2-8eec-719eeb779bf4.png"> |

Also, it's now possible for anyone to create disabled buttons like this by setting ContextMenuButtonItem.onPressed to `null`.
2023-04-19 00:09:34 +00:00
Mitchell Goodwin
bd2617ecb9
Adaptive alert dialog (#124336)
Fixes #102811. Adds an adaptive constructor to AlertDialog, along with the adaptive function showAdaptiveDialog.

<img width="357" alt="Screenshot 2023-04-06 at 10 40 18 AM" src="https://user-images.githubusercontent.com/58190796/230455412-31100922-cfc5-4252-b8c6-6f076353f29e.png">
<img width="350" alt="Screenshot 2023-04-06 at 10 42 50 AM" src="https://user-images.githubusercontent.com/58190796/230455454-363dd37e-c44e-4aca-b6a0-cfa1d959f606.png">
2023-04-18 23:00:03 +00:00
engine-flutter-autoroll
c05bc400f9
Roll Flutter Engine from 6d263ea56a62 to 5fcc7b719029 (4 revisions) (#125069)
6d263ea56a...5fcc7b7190

2023-04-18 dnfield@google.com [Impeller] Gpu model information to Skia gold (flutter/engine#41216)
2023-04-18 30870216+gaaclarke@users.noreply.github.com [Impeller] faster glyph atlas generation by removing data copies (flutter/engine#41290)
2023-04-18 godofredoc@google.com Migrate android AOT to engine_v2. (flutter/engine#41229)
2023-04-18 skia-flutter-autoroll@skia.org Roll Skia from 5bd4bdc0d8e2 to f80ee1088861 (8 revisions) (flutter/engine#41302)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-18 22:25:15 +00:00
Srujan Gaddam
6edbc19597
Remove package:js/dart:js_interop conflicts (#124879)
dart:js_interop and package:js will start conflicting, since they both have an `@JS` annotation. Until we're ready to only use dart:js_interop (which will require updating the SDK constraints of every package), we should hide the `@JS` annotation from dart:js_interop. Due to shadowing, this is the behavior today, so there should be no functional change.

Unblocks https://dart-review.googlesource.com/c/sdk/+/294130/8 and prevents confusing shadowing of dart:js_interop annotations like we do today.

- [Mentioned CL that is unblocked] I listed at least one issue that this PR fixes in the description above.
- [Need test-exemption] I added new tests to check the change I am making, or this PR is [test-exempt].
- [Need to run] All existing and new tests are passing.
2023-04-18 22:15:53 +00:00
Samuel Abada
81c3bc5687
Remove double.fromEnvironment from dart-define doc (#124102)
Remove double.fromEnvironment from dart-define doc.

Fixes #124665 

The current dart-define docs reads:

```
Additional key-value pairs that will be available as constants from the String.fromEnvironment, bool.fromEnvironment, int.fromEnvironment, and
double.fromEnvironment constructors.
```
while dart-define-from-file reads:

```
The path of a json format file where flutter define a global constant pool. 
Json entry will be available as constants from the String.fromEnvironment, bool.fromEnvironment, int.fromEnvironment, 
and double.fromEnvironment constructors; the key and field are json values
```

<img width="1440" alt="Screenshot 2023-04-03 at 19 31 34" src="https://user-images.githubusercontent.com/31275429/229720102-2020e1a9-c1fb-470b-89e6-ffb84096a51b.png">

However, there is no fromEnvironment constructor for double. The aim of this PR is to address this by removing double.fromEnvironment from help docs as stated in
3.10.0-7.0.pre
2023-04-18 21:52:52 +00:00
Kim Jiun
e2a2046014
Update to add Kim Jiun to AUTHORS (#125026)
Adding my name (Kim Jiun) to Authors.

REF : https://github.com/flutter/flutter/pull/91496
Thanks!
2023-04-18 21:52:49 +00:00
Greg Spencer
4b39f071f3
Add controller argument to SubmenuButton (#125000)
## Description

This adds an optional argument to the `SubmenuButton` that allows the creator to supply a `MenuController` for controlling the menu.

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/124988

## Tests
 - Added tests for new argument.
2023-04-18 21:09:53 +00:00
engine-flutter-autoroll
98dfdf1b6c
Roll Flutter Engine from 879308a52228 to 6d263ea56a62 (1 revision) (#125060)
879308a522...6d263ea56a

2023-04-18 gspencergoog@users.noreply.github.com Some minor doc typo and diagnostic fixes. (flutter/engine#40982)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-18 20:35:34 +00:00
Justin McCandless
f04a5afb58
Limit the number of Material spell check suggestions to 3 (#124899)
Fixes a bug where the spell check menu could overflow.
2023-04-18 12:50:12 -07:00
Jenn Magder
0ea2f3b530
Remove impeller testowners (#125056)
Remove TESTOWNERS matching the removed impeller tests in https://github.com/flutter/flutter/pull/125044.

Filed https://github.com/flutter/flutter/issues/125055 since I believe the mismatch should have been caught in that PR.
2023-04-18 19:35:05 +00:00
htoor3
cb90ae4d97
[web] - Clean up skipped tests (#124981)
Fixes https://github.com/flutter/flutter/issues/124174
Fixes https://github.com/flutter/flutter/issues/124980
2023-04-18 19:31:18 +00:00
engine-flutter-autoroll
ad784bf843
Roll Flutter Engine from 72b68622fffa to 879308a52228 (1 revision) (#125057)
72b68622ff...879308a522

2023-04-18 30870216+gaaclarke@users.noreply.github.com [Impeller] Turned on wide gamut support by default. (flutter/engine#39801)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-18 19:14:05 +00:00
Michael Goderbauer
df811c6d79
Remove unused getRootRenderObject and getSelectedRenderObject service extensions (#124805)
These are currently unused and will not work in a multi-view environment where we will have multiple render trees.

Work towards https://github.com/flutter/flutter/issues/121573.
2023-04-18 18:54:27 +00:00
Tae Hyung Kim
b6c7df447d
l10n.yaml's nullable-getter option should default to true (#124353)
Currently, nullable-getter defaults to false when l10n.yaml is not present, which is not the same behavior as when an l10n.yaml file is present and nullable-getter is not set.

Fixes #120457.
2023-04-18 18:42:07 +00:00
engine-flutter-autoroll
9b530298fa
Roll Flutter Engine from 55bb065c607b to 72b68622fffa (1 revision) (#125053)
55bb065c60...72b68622ff

2023-04-18 skia-flutter-autoroll@skia.org Manual roll Skia from d9e216e62223 to 5bd4bdc0d8e2 (12 revisions) (flutter/engine#41286)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-18 18:19:07 +00:00
chunhtai
55502fc36a
Add vmservice for android build options (#123034)
https://github.com/flutter/flutter/issues/120408
2023-04-18 18:16:09 +00:00
Kate Lovett
42fb0b2313
Fix text theme dart fix cases (#125052)
Fixes https://github.com/flutter/flutter/issues/125049

This is blocking the dart roll, dart fix will now fix some invalid code that was in these test cases. These test case files are un-analyzed intentionally because they are by nature samples of broken code.
2023-04-18 18:06:06 +00:00
Greg Spencer
d4e1209cc0
Update the copy icon in snippets and samples to use the standard one (#123651)
## Description

This updates the copy icon for copying sample code to use `content_copy` instead of `assignment`.
Before:
<img width="369" alt="223876418-2470c4c5-abfc-4511-9762-1fd0b6e05903" src="https://user-images.githubusercontent.com/8867023/228396142-450125ee-d8cf-4ede-8545-5920eb0da99d.png">

After:
<img width="408" alt="image" src="https://user-images.githubusercontent.com/8867023/228395959-8531704a-77aa-43af-9dcf-7456bb2ed090.png">

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/122246

## Tests
 - No tests needed.
2023-04-18 17:38:13 +00:00
Justin McCandless
9d6883135a
Remove unused context parameter (#124254)
Tidying up the spell check API.
2023-04-18 10:31:05 -07:00
Justin McCandless
39becb7770
iOS spell check cursor placement (#124875)
Fixes the cursor location after selecting a spell check result on iOS.
2023-04-18 10:18:41 -07:00
engine-flutter-autoroll
f7245b647e
Roll Flutter Engine from d2973619074e to 55bb065c607b (1 revision) (#125047)
d297361907...55bb065c60

2023-04-18 10456171+caroqliu@users.noreply.github.com [fuchsia] migrate touch-input integration tests to gfx scene manager test ui stack (flutter/engine#41118)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-18 17:06:39 +00:00
Zachary Anderson
c31467f18c
Stop running "_impeller_" benchmark variants (#125044)
Impeller is now the default on iOS, so these are redundant.

In a subsequent change, I'll clean up the source files for these.
2023-04-18 09:54:02 -07:00
engine-flutter-autoroll
a9ffc1666c
Roll Packages from 0277f2ad9d92 to faf53fb3998c (7 revisions) (#125040)
0277f2ad9d...faf53fb399

2023-04-18 engine-flutter-autoroll@skia.org Manual roll Flutter from 50171bbae357 to 15cb1f84d726 (9 revisions) (flutter/packages#3749)
2023-04-17 reidbaker@google.com [palette_generator] run agp update for example (flutter/packages#3747)
2023-04-17 47866232+chunhtai@users.noreply.github.com [go_router] Fixes a bug that go_router would crash if pageBuilder depends on InheritedWidgets.s. (flutter/packages#3714)
2023-04-17 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump com.android.tools.build:gradle from 7.3.1 to 8.0.0 in /packages/pigeon/platform_tests/alternate_language_test_plugin/android (flutter/packages#3727)
2023-04-17 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump com.android.tools.build:gradle from 7.3.1 to 8.0.0 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#3726)
2023-04-17 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump io.mockk:mockk from 1.13.4 to 1.13.5 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#3725)
2023-04-17 stuartmorgan@google.com [tool] Add initial gradle validation command (flutter/packages#3715)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-18 16:06:15 +00:00
engine-flutter-autoroll
ec02eb35ad
Roll Flutter Engine from c4396f9f602f to d2973619074e (6 revisions) (#125039)
c4396f9f60...d297361907

2023-04-18 leroux_bruno@yahoo.fr [macOS] Fix Ctrl+Tab is broken
(flutter/engine#40706)
2023-04-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
K1LGtKXyxRlW3Q9O1... to qZHSvkpAU1-YYGvYc... (flutter/engine#41293)
2023-04-18 aam@google.com Roll buildroot to
059d155b4d452efd9c4427c45cddfd9445144869 (flutter/engine#41288)
2023-04-18 bdero@google.com [Impeller] Remove glyph pixel rounding
during text frame conversion (flutter/engine#41285)
2023-04-18 godofredoc@google.com Revert "Reland "Migrate mac_host_engine
to engine v2 builds."" (flutter/engine#41284)
2023-04-17 flar@google.com focus SkiaGPUObject wrappers on only those
objects that need the protection (flutter/engine#41237)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from K1LGtKXyxRlW to qZHSvkpAU1-Y

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-18 08:58:21 -07:00
Flutter GitHub Bot
b0346b2953
Roll pub packages (#125005)
This PR was generated by `flutter update-packages --force-upgrade`.
2023-04-18 13:35:36 +00:00
Tirth
5de716f7f8
[InputDatePickerFormField] adds acceptEmptyDate to InputDatePickerFormField Widget (#124143)
Adds `acceptEmptyDate` property to `InputDatePickerFormField`.

Fixes: #117511

| `acceptEmptyDate` is **false** | `acceptEmptyDate` is **true** |
| --- | ---|
| ![acceptemptydate_false](https://user-images.githubusercontent.com/13456345/229893658-280ecdee-d509-4579-b53c-9d8d485c61b4.gif) | ![acceptemptydate__true](https://user-images.githubusercontent.com/13456345/229895144-115e71bd-e5bb-4653-8db2-9f57dd8262aa.gif) |
2023-04-18 09:33:30 +00:00
Viren Khatri
3ba249a6b3
relayout active ListWheelScrollView children every performLayout (#124476)
during performLayout, active children's constraints were updated, but they weren't laid out again w.r.t their parent (ListWheelScrollView).

Fixes #123497
2023-04-18 05:16:33 +00:00
engine-flutter-autoroll
4075503489
Roll Flutter Engine from 4a603aaff32e to c4396f9f602f (2 revisions) (#125007)
4a603aaff3...c4396f9f60

2023-04-17 zanderso@users.noreply.github.com Roll impeller-cmake-example to 58042bb24833a3cbd615ad082b1d17daef42d097 (flutter/engine#41280)
2023-04-17 jacksongardner@google.com Reland ui_web files in sky_engine (flutter/engine#41169)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-18 01:17:14 +00:00
engine-flutter-autoroll
9cc5f5558a
Roll Flutter Engine from 20034a8d62c4 to 4a603aaff32e (2 revisions) (#125004)
20034a8d62...4a603aaff3

2023-04-17 magder@google.com Remove 'Mac mac_unopt' in favor of Linux (flutter/engine#41226)
2023-04-17 chinmaygarde@google.com [Impeller] Add debug ToString methods to render targets. (flutter/engine#41221)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-18 00:15:14 +00:00
Kate Lovett
e867d1c686
Add optional axis specifier to static scrollable methods (#124894)
This is motivated by part of the 2D scrolling proposal: [flutter.dev/go/2D-Foundation](https://flutter.dev/go/2D-Foundation)

This is one of the last little PRs to prep for the 2D scrolling foundation. 
This adds an optional `axis` parameter to the static Scrollable methods `[of, maybeOf, recommendDeferredLoadingForContext]`. This allows developers that are nesting scrollables (or one day using 2D scrolling) to look them up instead by a particular axis.

In general, even outside the context of 2D, I think this is helpful. I am often asked how to get the outer scrollable when nesting. Now it can be done.

There is also a small semantic refactor here in ScrollableState.build, this just creates a private method (_buildChrome) that will be overridden in 2D later. It is easier to add now than in the really big PR that will be.
2023-04-18 00:08:07 +00:00
Bartek Pacia
e99eb40222
Update usage of standalonepub executable in flutter_tools testing docs (#124898)
Just found this while trying to run the integration test shard of `flutter_tools` locally :)
2023-04-17 23:34:23 +00:00
Harish Anbalagan
0ac1813b16
Add Harish Anbalagan to AUTHORS (#124684)
Adding my name (Harish Anbalagan) to Authors.
2023-04-17 23:29:03 +00:00
engine-flutter-autoroll
67a84e6c87
Roll Flutter Engine from b2d07388ceb6 to 20034a8d62c4 (7 revisions) (#125001)
b2d07388ce...20034a8d62

2023-04-17 godofredoc@google.com Reland  "Migrate mac_host_engine to engine v2 builds." (flutter/engine#41279)
2023-04-17 41930132+hellohuanlin@users.noreply.github.com [rotation_distortion] Use "delayed swap" solution to reduce rotation distortion (flutter/engine#40730)
2023-04-17 akash.mercer@gmail.com null check added to avoid NPE while calling FlutterView.detachFromFlutterEngine() (flutter/engine#41082)
2023-04-17 5236035+fzyzcjy@users.noreply.github.com [Impeller] Make `DoMakeRasterSnapshot` output timeline event. (flutter/engine#41197)
2023-04-17 bdero@google.com [Impeller] Remove ContentContextOptions declarations from AnonymousContents (flutter/engine#41256)
2023-04-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 786a70d8ef6b to a335e6724332 (1 revision) (flutter/engine#41278)
2023-04-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from atix5Ek_OOxH-uoPA... to Cy5LG4U2InaFLkJGz... (flutter/engine#41275)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from atix5Ek_OOxH to Cy5LG4U2InaF

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-17 23:24:00 +00:00
Qun Cheng
6e85113418
Add an example for SearchBar (#124992)
This PR is to: 
* Update API doc for `SearchBar`.
* Add an example to show how to use a `SearchBar` as the builder of the `SearchAnchor`.
2023-04-17 23:23:57 +00:00
chunhtai
cc9ffd3f3b
SelectionContainer's listeners can remove itself during listener call… (#124624)
When swapping out delegate of  selectioncontainer, if the newly passed in delegate doesn't have any selectable content(which is usually the case), the selectioncontainerstate will notify all of the listeners. One of the listener would be SelectionRegistrant._updateSelectionRegistrarSubscription, and since it doesn't have content, it would remove itself from the listener which causes concurrent modification
2023-04-17 23:19:11 +00:00
Taha Tesser
15cb1f84d7
Fix Chip highlight color isn't drawn on top of the background color (#124673) 2023-04-17 13:41:55 -07:00
chunhtai
7424f3448d
Deprecates string for reorderable list in material_localizations (#124711)
deprecates the these strings since they are now moved into widgetslocalizations

migration guide https://github.com/flutter/website/pull/8543/files
2023-04-17 20:03:06 +00:00
hangyu
2f45458e2c
Fix a null crash in SelectableRegion Widget (#124736)
issue #123378
2023-04-17 19:59:06 +00:00
Mubarak Bakarman
df8d819410
Customize color and thickness of connected lines in Stepper.dart (#122485) 2023-04-17 12:52:48 -07:00
engine-flutter-autoroll
53f31c7c06
Roll Flutter Engine from 30e1c4308213 to b2d07388ceb6 (7 revisions) (#124987)
30e1c43082...b2d07388ce

2023-04-17 30870216+gaaclarke@users.noreply.github.com Adds AndroidSurfaceGLImpeller unit tests (flutter/engine#40979)
2023-04-17 yjbanov@google.com [web:canvaskit] migrate Paint API to UniqueRef (flutter/engine#41230)
2023-04-17 kjlubick@users.noreply.github.com Migrate uses of deprecated SkImage->encodeToData (flutter/engine#41204)
2023-04-17 skia-flutter-autoroll@skia.org Roll Skia from 962800967591 to d9e216e62223 (1 revision) (flutter/engine#41270)
2023-04-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from xPacy_rLieLS05d_g... to K1LGtKXyxRlW3Q9O1... (flutter/engine#41271)
2023-04-17 skia-flutter-autoroll@skia.org Roll Skia from 82665485077b to 962800967591 (1 revision) (flutter/engine#41267)
2023-04-17 skia-flutter-autoroll@skia.org Roll Skia from 5c4d2a518736 to 82665485077b (2 revisions) (flutter/engine#41266)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from xPacy_rLieLS to K1LGtKXyxRlW

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-17 19:36:29 +00:00
godofredoc
8bbe71787a
Remove token permissions for coverage. (#124909)
The coverage build does not require write access to checks.
2023-04-17 17:31:30 +00:00
engine-flutter-autoroll
c368d64d88
Roll Packages from e4ec15590935 to 0277f2ad9d92 (9 revisions) (#124972)
e4ec155909...0277f2ad9d

2023-04-16 engine-flutter-autoroll@skia.org Roll Flutter from 00171b07130e to 50171bbae357 (7 revisions) (flutter/packages#3723)
2023-04-15 engine-flutter-autoroll@skia.org Roll Flutter from f74054467bed to 00171b07130e (17 revisions) (flutter/packages#3717)
2023-04-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.2.9 to 2.2.12 (flutter/packages#3711)
2023-04-15 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.0 to 3.5.2 (flutter/packages#3710)
2023-04-14 stuartmorgan@google.com [path_provider] Fix Android lint warnings (flutter/packages#3706)
2023-04-14 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] [camera_android_camerax] Updates internal Java InstanceManager to only stop finalization callbacks when stopped (flutter/packages#3571)
2023-04-14 stuartmorgan@google.com [shared_preferences] Fix Android Java version issue (flutter/packages#3712)
2023-04-14 48185017+andreisas06@users.noreply.github.com [image_picker][android] Non-bitmap images now return path instead of null (flutter/packages#3590)
2023-04-14 engine-flutter-autoroll@skia.org Roll Flutter from be45eb2420b2 to f74054467bed (24 revisions) (flutter/packages#3713)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-17 15:51:25 +00:00
engine-flutter-autoroll
bfd92a8619
Roll Flutter Engine from 360ca05311c8 to 30e1c4308213 (3 revisions) (#124963)
360ca05311...30e1c43082

2023-04-17 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.0 to 3.5.2 (flutter/engine#41264)
2023-04-17 skia-flutter-autoroll@skia.org Roll Skia from a64c248e62e0 to 5c4d2a518736 (1 revision) (flutter/engine#41262)
2023-04-17 skia-flutter-autoroll@skia.org Roll Skia from 03c8e529196d to a64c248e62e0 (1 revision) (flutter/engine#41261)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-17 11:10:32 +00:00
engine-flutter-autoroll
858d4ff634
Roll Flutter Engine from 4a998b73a2df to 360ca05311c8 (2 revisions) (#124952)
4a998b73a2...360ca05311

2023-04-17 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from AAx6fLy6ykWVhXvNh... to xPacy_rLieLS05d_g... (flutter/engine#41260)
2023-04-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 46T4ZTAt48yPRDEn5... to atix5Ek_OOxH-uoPA... (flutter/engine#41258)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 46T4ZTAt48yP to atix5Ek_OOxH
  fuchsia/sdk/core/mac-amd64 from AAx6fLy6ykWV to xPacy_rLieLS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3.10.0-6.0.pre
2023-04-17 03:21:38 +00:00
engine-flutter-autoroll
50171bbae3
Roll Flutter Engine from da0805a9cf03 to 4a998b73a2df (5 revisions) (#124944)
da0805a9cf...4a998b73a2

2023-04-16 skia-flutter-autoroll@skia.org Roll Skia from cc3404330d3b to 03c8e529196d (1 revision) (flutter/engine#41255)
2023-04-16 skia-flutter-autoroll@skia.org Roll Skia from 2d0b05335104 to cc3404330d3b (1 revision) (flutter/engine#41254)
2023-04-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from hacWN-gQSoWudziIS... to 46T4ZTAt48yPRDEn5... (flutter/engine#41253)
2023-04-16 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from gI2knJ4Rh0yoK4Syd... to AAx6fLy6ykWVhXvNh... (flutter/engine#41252)
2023-04-16 bdero@google.com [Impeller] Add offscreen texture checkerboarding (flutter/engine#41199)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from hacWN-gQSoWu to 46T4ZTAt48yP
  fuchsia/sdk/core/mac-amd64 from gI2knJ4Rh0yo to AAx6fLy6ykWV

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-16 17:37:40 +00:00
engine-flutter-autoroll
2d57261069
Roll Flutter Engine from feb476b7b991 to da0805a9cf03 (4 revisions) (#124933)
feb476b7b9...da0805a9cf

2023-04-15 skia-flutter-autoroll@skia.org Roll Skia from 2a4d95762651 to 2d0b05335104 (1 revision) (flutter/engine#41250)
2023-04-15 jonahwilliams@google.com [Impeller] add a generic porter duff blend foreground shader. (flutter/engine#41098)
2023-04-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Y_tD90hDX_jiubGbC... to hacWN-gQSoWudziIS... (flutter/engine#41248)
2023-04-15 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from RFyPoDrXzIiy-E3wn... to gI2knJ4Rh0yoK4Syd... (flutter/engine#41249)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Y_tD90hDX_ji to hacWN-gQSoWu
  fuchsia/sdk/core/mac-amd64 from RFyPoDrXzIiy to gI2knJ4Rh0yo

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-16 00:34:24 +00:00
engine-flutter-autoroll
d8a916f232
Roll Flutter Engine from ee66f0d6f2c9 to feb476b7b991 (2 revisions) (#124929)
ee66f0d6f2...feb476b7b9

2023-04-15 skia-flutter-autoroll@skia.org Roll Skia from cf580fd68a21 to 2a4d95762651 (2 revisions) (flutter/engine#41247)
2023-04-15 skia-flutter-autoroll@skia.org Roll Dart SDK from eb26d88d7f58 to 786a70d8ef6b (1 revision) (flutter/engine#41245)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-15 22:32:13 +00:00
Jonah Williams
00495da0b5
Revert "[framework] use shader tiling instead of repeated calls to drawImage" (#124640)
Reverts flutter/flutter#119495

We'll managed to optimize almost all of the cases that made this slow. Actually, it will soon be harder to optimize shader tiling...
2023-04-15 22:04:20 +00:00
Jonah Williams
d1d426e5a8
[cupertino] improve cupertino picker performance by using at most one opacity layer (#124719)
Fixes https://github.com/flutter/flutter/issues/124703

Rather than applying an opacity layer per picker item, apply them to all partially opaque picker items at once. This dramatically improves performance for impeller, by reducing the number of required subpasses and texture allocations signficantly.

Before:
Doesn't finish, 100s of passes

After:

![image](https://user-images.githubusercontent.com/8975114/231569280-91f55c9a-53a5-4b75-8728-59a4dceebe81.png)

![image](https://user-images.githubusercontent.com/8975114/231569309-7c82e5ff-46c7-4f00-80f0-9b4096aa4b14.png)

See also:

https://github.com/flutter/flutter/issues/124658
2023-04-15 22:00:48 +00:00
Andrew Kolos
68ec71f46c
[flutter_tools] Remove Version.unknown (#124771)
Fixes #124756 by removing the concept of `Version.unknown`.

`Version` fields that needed the ability to represent an unknown version have been made nullable. Assigning `null` to them represents an unknown version.
2023-04-15 19:56:41 +00:00