DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
35,726 Commits 882 Branches 1,069 Tags
Commit Graph

27193 Commits

Author SHA1 Message Date
Brandon DeRosier
2ffd763cfb [Impeller] Reland: Remove Entity capture/AiksInspector. (flutter/engine#52932) 
Resolves https://github.com/flutter/flutter/issues/134748.

This was a really fun experiment. I learned a lot from it, and it
genuinely helped me solve some coverage-related problems, but the
reality is it was too little too late -- by the time we had this
capture system, we had already solved most of the problems that would
have benefitted from this.

It's been a few months since I've used or extended the capabilities of
this capture system for something, and I don't have the spare
time/energy to give it the love it needs to realize the vision I had
for it. I still almost exclusively use a combination of native frame
captures and print debugging to solve problems.

RIP in peace.

This reverts commit 104eb98e62. (https://github.com/flutter/engine/pull/52680)
 2024-05-21 00:59:14 +00:00
Harry Terkelsen
a554688620 [canvaskit] Refactor HtmlImageCodec to generalize to different renderers (flutter/engine#52905) 
Refactor `HtmlImageCodec` to decouple it from the html renderer so other
renderers can create a `ui.Image` via `Image.decode()`.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-05-20 16:59:06 -07:00
skia-flutter-autoroll
dd229beeff Roll Skia from 977a43773f7c to 62f369c75994 (1 revision) (flutter/engine#52941) 
https://skia.googlesource.com/skia.git/+log/977a43773f7c..62f369c75994

2024-05-20 ccameron@google.com Revert "Decode and encode ISO 21496-1 JPEG images"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-20 23:28:22 +00:00
skia-flutter-autoroll
1363abdeb3 Roll Skia from 0b8d8ce44d1f to 977a43773f7c (1 revision) (flutter/engine#52938) 
https://skia.googlesource.com/skia.git/+log/0b8d8ce44d1f..977a43773f7c

2024-05-20 ccameron@chromium.org Decode and encode ISO 21496-1 JPEG images

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-20 22:30:09 +00:00
Jonah Williams
c9f79d8b9e [Impeller] write glyphs to malloc buffer. (flutter/engine#52937) 
Writing to a malloc buffer and then copying is faster on a variety of Pixel devices. Since this change was supposed to be a performance optimization, just back it out.
 2024-05-20 22:15:05 +00:00
skia-flutter-autoroll
2872bbe05c Roll Dart SDK from 08f4324c988b to 01a77883e9e9 (1 revision) (flutter/engine#52936) 
https://dart.googlesource.com/sdk.git/+log/08f4324c988b..01a77883e9e9

2024-05-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-173.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-20 21:59:33 +00:00
Brandon DeRosier
1bf574e4a6 [Impeller] Fix use-after-move in SwapchainVK. (flutter/engine#52933) 
Fix lint encountered in https://github.com/flutter/engine/pull/52932.
 2024-05-20 14:57:22 -07:00
Jenn Magder
dff60d8f55 Update file permissions for FlutterMacOS.framework (flutter/engine#52930) 
During FlutterMacOS.framework engine universal fat framework creation, make sure the framework is `u=rwx,go=rx` when it's created.

There's a framework-side workaround in-flight https://github.com/flutter/flutter/pull/148580. 

However, this is still a good thing to do engine-side, particularly for add-to-app when they don't go through the `flutter assemble` tooling.

I'll also add a test around here, once this rolls 02a6c91e4d/packages/flutter_tools/test/host_cross_arch.shard/macos_content_validation_test.dart (L30)

Fixes https://github.com/flutter/flutter/issues/148354

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-05-20 21:46:37 +00:00
Jonah Williams
1579900629 [Impeller] leave glyph atlas in transfer dst to improve vulkan throughput. (flutter/engine#52908) 
On the vulkan backend everytime we blit a glyph we go shader read -> transfer dst -> shader read. This is pretty inefficient if we're appending many glyphs. 

Poke a hole in the blitpass API so we can leave the glyph atlas in transfer_dst to reduce the number of layout transitions.
 2024-05-20 18:39:14 +00:00
skia-flutter-autoroll
2731f6e460 Roll Dart SDK from 54c384453207 to 08f4324c988b (1 revision) (flutter/engine#52931) 
https://dart.googlesource.com/sdk.git/+log/54c384453207..08f4324c988b

2024-05-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-172.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-20 17:59:29 +00:00
skia-flutter-autoroll
c1c7f00ede Roll Skia from e26d9e5d356f to 0b8d8ce44d1f (4 revisions) (flutter/engine#52929) 
https://skia.googlesource.com/skia.git/+log/e26d9e5d356f..0b8d8ce44d1f

2024-05-20 fmalita@google.com [skottie] Add support for radial gradient highlight
2024-05-20 robertphillips@google.com [graphite] Add BlurMaskFilter to Precompilation system
2024-05-20 johnstiles@google.com Roll libjpeg-turbo to latest Chromium version.
2024-05-20 johnstiles@google.com [graphite] Apply a few simplifications in Graphite shaders.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-20 17:47:07 +00:00
skia-flutter-autoroll
62af577373 Roll Skia from 3f4c5038da37 to e26d9e5d356f (18 revisions) (flutter/engine#52928) 
https://skia.googlesource.com/skia.git/+log/3f4c5038da37..e26d9e5d356f

2024-05-20 egdaniel@google.com [Graphite] Add support for labels on user created SkSurfaces.
2024-05-20 michaelludwig@google.com Revert "Reland "GraphiteDawn: use dawn's LoadResolveTexture extension.""
2024-05-20 nathanasanchez@google.com Add check when x is 0 in sweep gradient to avoid UB.
2024-05-20 kjlubick@google.com Make skparagraph Bazel target naming consistent
2024-05-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from fd6f3c04f129 to de5559d9b295 (1 revision)
2024-05-20 bungeman@google.com [paragraph] Make tests less likely to crash
2024-05-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 1e93252a646d to 6f8e6e4009f3
2024-05-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 6da3279dd380 to 1e93252a646d (3 revisions)
2024-05-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 8122e7e3d144 to e3a4352eecab (22 revisions)
2024-05-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 8a4a82565901 to fd6f3c04f129 (1 revision)
2024-05-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 31d02bca8cff to 1e93252a646d
2024-05-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 734bd27673a1 to 8a4a82565901 (1 revision)
2024-05-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b2bda3989476 to 734bd27673a1 (1 revision)
2024-05-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 30a48b37b02b to b2bda3989476 (1 revision)
2024-05-17 kjlubick@google.com Add PDF module
2024-05-17 kjlubick@google.com Revert "[Fontations-backend] Hook up Skrifa hinting support"
2024-05-17 robertphillips@google.com [graphite] Modify MatrixConvolutionImageFilter's SkSL generation
2024-05-17 nathanasanchez@google.com Add onAsLuminance to SkLocalMatrixShader.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,jlavrova@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-20 16:35:22 +00:00
skia-flutter-autoroll
a7491fc474 Manual roll Dart SDK from 3c8718d827b5 to 54c384453207 (2 revisions) (flutter/engine#52927) 
Manual roll requested by aam@google.com

https://dart.googlesource.com/sdk.git/+log/3c8718d827b5..54c384453207

2024-05-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-171.0.dev
2024-05-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-170.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-20 16:22:05 +00:00
skia-flutter-autoroll
322de484c4 Roll Fuchsia Linux SDK from oW-pi0q4ZpKGU6Q9P... to jXE7fqJI6VWFMaIdV... (flutter/engine#52925) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-20 00:01:07 +00:00
skia-flutter-autoroll
42e4e63939 Manual roll Dart SDK from 0b87dfedea5f to 3c8718d827b5 (1 revision) (flutter/engine#52924) 
Manual roll requested by aam@google.com

https://dart.googlesource.com/sdk.git/+log/0b87dfedea5f..3c8718d827b5

2024-05-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-169.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-19 20:41:34 +00:00
skia-flutter-autoroll
8839579ef7 Roll Fuchsia Linux SDK from jKdOTTgE2Uq5OmJzT... to oW-pi0q4ZpKGU6Q9P... (flutter/engine#52923) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-18 21:28:23 +00:00
Jason Simmons
6a30864930 Manual roll of Dart SDK from 28e8e94f9e10 to 0b87dfedea5f (flutter/engine#52914) 
The invocation of dart2wasm had to be updated because the dart-sdk flag was removed.

(see https://dart.googlesource.com/sdk/+/328ae02be189311aa26e500b8f4839e90362c20b)
 2024-05-18 14:36:26 +00:00
auto-submit[bot]
bf47498373 Reverts "Fixes MatrixFilterContents rendering/coverage (#52880)" (flutter/engine#52918) 
Reverts: flutter/engine#52880
Initiated by: jonahwilliams
Reason for reverting: unexpected framework golden change
Original PR Author: gaaclarke

Reviewed By: {bdero}

This change reverts the following previous change:
fixes: https://github.com/flutter/flutter/issues/147807
relands https://github.com/flutter/engine/pull/43943 (with fixes that hopefully avoid it being reverted again)

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-05-18 03:01:46 +00:00
gaaclarke
4cb23c3af7 Fixes MatrixFilterContents rendering/coverage (flutter/engine#52880) 
fixes: https://github.com/flutter/flutter/issues/147807
relands https://github.com/flutter/engine/pull/43943 (with fixes that hopefully avoid it being reverted again)

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-05-18 00:43:35 +00:00
auto-submit[bot]
b16181fe6a Reverts "[macOS] Generate universal gen_snapshots (#52885)" (flutter/engine#52913) 
Reverts: flutter/engine#52885
Initiated by: cbracken
Reason for reverting: while this patch worked fine, it pushed the mac build bot over its time limit. Previous builds were just squeaking under the wire but seeing timeouts on the mac_host_engine host_release shard after this commit. e.g. https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20mac_host_engine/10667/overview

Looking at ci.yaml I see the timeout is set to 240, but the timeout on the failing shard is c
Original PR Author: cbracken

Reviewed By: {jmagman}

This change reverts the following previous change:
Previously, the `gen_snapshot_arm64` and `gen_snapshot_x64` binaries used by the tool were all built for x64 architecture. As such, developers building apps with Flutter rely on Rosetta translation with every build.

This refactors the gen_snapshot build rules on macOS hosts to consistently produce `gen_snapshot_arm64` and `gen_snapshot_x64` binaries with the target architecture of the build but with as universal binaries with both host architectures.

### arm64 host build

Prior to this patch we emitted:
* gen_snapshot_arm64 (arch: x64, target_arch: simarm64)

After this patch, we emit:
* artifacts_x64/gen_snapshot_arm64 (arch: x64, target_arch: simarm64)
* artifacts_arm64/gen_snapshot_arm64 (arch: arm64, target_arch: arm64)
* gen_snapshot_arm64 (universal binary composed of both of the above)

### x64 host build

Prior to this patch we emitted:
* gen_snapshot_x64 (arch: x64, target_arch: x64)

After this patch, we emit:
* artifacts_x64/gen_snapshot_x64 (arch: x64, target_arch: x64)
* artifacts_arm64/gen_snapshot_x64 (arch: arm64, target_arch: simx64)
* gen_snapshot_x64 (universal binary composed of both of the above)

Note that host builds on macOS currently default to a host architecture of x64 (can be overridden via `--force-mac-arm64`) regardless of host architecture and thus, the build itself relies on Rosetta translation when invoked on Apple Silicon arm64 hardware. This is to ensure a consistent build in CI regardless of bot architecture. See: 0d2b0cd0ed/tools/gn (L502-L505)

Issue: https://github.com/flutter/flutter/issues/101138
Issue: https://github.com/flutter/flutter/issues/69157

Related issue: https://github.com/flutter/flutter/issues/103386

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-05-17 23:35:47 +00:00
Chris Bracken
f73900ba16 [macOS] Generate universal gen_snapshots (flutter/engine#52885) 
Previously, the `gen_snapshot_arm64` and `gen_snapshot_x64` binaries used by the tool were all built for x64 architecture. As such, developers building apps with Flutter rely on Rosetta translation with every build.

This refactors the gen_snapshot build rules on macOS hosts to consistently produce `gen_snapshot_arm64` and `gen_snapshot_x64` binaries with the target architecture of the build but with as universal binaries with both host architectures.

### arm64 host build

Prior to this patch we emitted:
* gen_snapshot_arm64 (arch: x64, target_arch: simarm64)

After this patch, we emit:
* artifacts_x64/gen_snapshot_arm64 (arch: x64, target_arch: simarm64)
* artifacts_arm64/gen_snapshot_arm64 (arch: arm64, target_arch: arm64)
* gen_snapshot_arm64 (universal binary composed of both of the above)

### x64 host build

Prior to this patch we emitted:
* gen_snapshot_x64 (arch: x64, target_arch: x64)

After this patch, we emit:
* artifacts_x64/gen_snapshot_x64 (arch: x64, target_arch: x64)
* artifacts_arm64/gen_snapshot_x64 (arch: arm64, target_arch: simx64)
* gen_snapshot_x64 (universal binary composed of both of the above)

Note that host builds on macOS currently default to a host architecture of x64 (can be overridden via `--force-mac-arm64`) regardless of host architecture and thus, the build itself relies on Rosetta translation when invoked on Apple Silicon arm64 hardware. This is to ensure a consistent build in CI regardless of bot architecture. See: 0d2b0cd0ed/tools/gn (L502-L505)

Issue: https://github.com/flutter/flutter/issues/101138
Issue: https://github.com/flutter/flutter/issues/69157

Related issue: https://github.com/flutter/flutter/issues/103386

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-05-17 21:24:52 +00:00
skia-flutter-autoroll
d581c140dd Roll Fuchsia Linux SDK from ywxGmpIdjxBl2i7s2... to jKdOTTgE2Uq5OmJzT... (flutter/engine#52909) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-17 20:12:17 +00:00
Jonah Williams
6bfd7c1895 [Impeller] fix colr/bitmap font color drawing. (flutter/engine#52871) 
Fixes https://github.com/flutter/flutter/issues/126546

Track the paint color used by Bitmap/Emoji/COLR fonts and use it as a cache key. This allows non-COLR glyphs in a COLR font to get the correct text color. For other kinds of fonts, we always record the color as black so there are no cache efficiency hits in general.
 2024-05-17 19:29:06 +00:00
skia-flutter-autoroll
cec4c7d8f2 Roll Skia from 6f7cb3d360b7 to 3f4c5038da37 (1 revision) (flutter/engine#52907) 
https://skia.googlesource.com/skia.git/+log/6f7cb3d360b7..3f4c5038da37

2024-05-17 jvanverth@google.com [graphite] Remove deprecated GetGPUFamilyFromFeatureSet.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-17 19:21:29 +00:00
skia-flutter-autoroll
1c82d35f63 Roll Skia from 6165e26f33ac to 6f7cb3d360b7 (1 revision) (flutter/engine#52903) 
https://skia.googlesource.com/skia.git/+log/6165e26f33ac..6f7cb3d360b7

2024-05-17 jvanverth@google.com Use specialized multitexture lookup for LCD SDF text.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-17 18:09:23 +00:00
skia-flutter-autoroll
7d440e4139 Roll Skia from bcb24206f9c4 to 6165e26f33ac (1 revision) (flutter/engine#52902) 
https://skia.googlesource.com/skia.git/+log/bcb24206f9c4..6165e26f33ac

2024-05-17 lehoangquyen@chromium.org Reland "GraphiteDawn: use dawn's LoadResolveTexture extension."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-17 17:02:10 +00:00
Matan Lurey
1bfe32e757 Issue anERROR instead of an INFO for a non-working API. (flutter/engine#52892) 
Work towards https://github.com/flutter/flutter/issues/139702.

I think we should also `@Deprecate`/cleanup the API surface in
`FlutterView`, but that needs a bit more a discussion.

/cc @johnmccutchan
 2024-05-17 08:40:45 -07:00
skia-flutter-autoroll
4ab054b05c Roll Dart SDK from 601c7a96ef5d to 28e8e94f9e10 (1 revision) (flutter/engine#52900) 
https://dart.googlesource.com/sdk.git/+log/601c7a96ef5d..28e8e94f9e10

2024-05-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-167.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-17 14:53:37 +00:00
skia-flutter-autoroll
af32a56ff8 Roll Dart SDK from c0709fb4a1a3 to 601c7a96ef5d (1 revision) (flutter/engine#52898) 
https://dart.googlesource.com/sdk.git/+log/c0709fb4a1a3..601c7a96ef5d

2024-05-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-166.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-17 10:41:29 +00:00
skia-flutter-autoroll
d0bf851079 Roll Skia from 071cbd93d0a4 to a251e7836a5c (1 revision) (flutter/engine#52897) 
https://skia.googlesource.com/skia.git/+log/071cbd93d0a4..a251e7836a5c

2024-05-17 drott@chromium.org [Fontations-backend] Hook up Skrifa hinting support

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-17 09:50:24 +00:00
skia-flutter-autoroll
b7e2db667b Roll Skia from 4af5313185d7 to 071cbd93d0a4 (2 revisions) (flutter/engine#52896) 
https://skia.googlesource.com/skia.git/+log/4af5313185d7..071cbd93d0a4

2024-05-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 6da3279dd380 to 3d1e84a14ec4
2024-05-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from e9be917b1b0d to 6da3279dd380 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-17 06:44:34 +00:00
skia-flutter-autoroll
36a4f64ec7 Roll Dart SDK from ecc0d32e29cd to c0709fb4a1a3 (1 revision) (flutter/engine#52895) 
https://dart.googlesource.com/sdk.git/+log/ecc0d32e29cd..c0709fb4a1a3

2024-05-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-165.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-17 06:36:26 +00:00
skia-flutter-autoroll
04dc622fbd Roll Dart SDK from a68a3967e3d9 to ecc0d32e29cd (1 revision) (flutter/engine#52893) 
https://dart.googlesource.com/sdk.git/+log/a68a3967e3d9..ecc0d32e29cd

2024-05-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-164.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-17 02:36:29 +00:00
Jonah Williams
709848e589 [Impeller] grow glyph atlas instead of resizing when rect packer is full. (flutter/engine#52849) 
Fixes https://github.com/flutter/flutter/issues/138798

As far as I can tell, this gets us about as good as Skia, modulo the actual cost of rasterizing one of these glyphs is much more expensive for us.

The basic strategy is:

1. If the existing atlas texture has room (defined by the rect packer addRect call succeeding) append as many glyphs as we can to the old texture.
2. Check if there were any remaining glyphs. If not return.
3. Otherwise, double the size of the texture and create a new rect packer that represents only the increased area. So for example if you doubled a 100x100 texture to 100x200, then you'd create another 100x100 rect packer, assuming the old one is full.
4. Grow this size until all remaining glyphs fit. Store the new rect packer and the "height adjustment", which basically tells you where along the y-axis the rect packer offset starts.
5. Allocate this new texture, clear it, and then blit the contents of the old texture into the top left corner. Append all additional glyphs. The allows us to recycle all previously rendered glyphs and keep them in the texture, reducing the amount of software rasterization per frame.
6. Note; if the max atlas size would be exceeded, throw it away and start again.
 2024-05-17 02:20:21 +00:00
Jonah Williams
20ea92ce6f [Impeller] use smaller SkFont size for determining glyph bounds. (flutter/engine#52868) 
Applies the fix that @jason-simmons  previously suggested in https://github.com/flutter/flutter/issues/128624#issuecomment-1846473830 

I'm not sure if these results are better or not ... but I think we try and make this change to see if things are improved anyway? Leaving up golden diffs for others to look at.
 2024-05-16 22:55:19 +00:00
skia-flutter-autoroll
e1b5e2c1d2 Roll Skia from 7536d3b590b8 to 5f094e6de863 (2 revisions) (flutter/engine#52891) 
https://skia.googlesource.com/skia.git/+log/7536d3b590b8..5f094e6de863

2024-05-16 bungeman@google.com Reland "Add PostScript name to generated fonts"
2024-05-16 jvanverth@google.com Move kDistanceAdjustLumShift into DistanceFieldAdjustTable.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-16 22:47:24 +00:00
skia-flutter-autoroll
d94c1b59a9 Roll Dart SDK from d174ead78d98 to a68a3967e3d9 (1 revision) (flutter/engine#52889) 
https://dart.googlesource.com/sdk.git/+log/d174ead78d98..a68a3967e3d9

2024-05-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-163.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-16 22:22:17 +00:00
auto-submit[bot]
ea811b97ba Reverts "Manual roll of Clang from 725656bdd885 to 145176dc0c93 (#52823)" (flutter/engine#52890) 
Reverts: flutter/engine#52823
Initiated by: zanderso
Reason for reverting: Engine crashes on framework CI following this roll https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20flutter_gallery__transition_perf_with_semantics/12126/overview
Original PR Author: jason-simmons

Reviewed By: {zanderso}

This change reverts the following previous change:
See https://github.com/flutter/flutter/issues/143178
 2024-05-16 22:01:38 +00:00
skia-flutter-autoroll
74d5011ee9 Roll Skia from 530fa373b797 to bb1572a681eb (2 revisions) (flutter/engine#52886) 
https://skia.googlesource.com/skia.git/+log/530fa373b797..bb1572a681eb

2024-05-16 bungeman@google.com Add PostScript name to generated fonts
2024-05-16 armansito@google.com Reland "[graphite] Tweaks to atlas path renderer selection"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-16 20:31:17 +00:00
skia-flutter-autoroll
114afcf5d5 Roll Fuchsia Linux SDK from Ftw7GopnudHydGS1y... to ywxGmpIdjxBl2i7s2... (flutter/engine#52882) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-16 19:08:10 +00:00
skia-flutter-autoroll
080abd7f9f Roll Dart SDK from b64b487c9967 to d174ead78d98 (1 revision) (flutter/engine#52878) 
https://dart.googlesource.com/sdk.git/+log/b64b487c9967..d174ead78d98

2024-05-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-162.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-16 18:15:11 +00:00
skia-flutter-autoroll
3fd64fd9d3 Roll Skia from 320b00b025b8 to ac4aa1dbd268 (2 revisions) (flutter/engine#52877) 
https://skia.googlesource.com/skia.git/+log/320b00b025b8..ac4aa1dbd268

2024-05-16 lehoangquyen@chromium.org GraphiteDawn: use future version of CreateRenderPipelineAsync
2024-05-16 kjlubick@google.com Use image deserial proc in debugger

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-16 18:09:02 +00:00
Jason Simmons
31d7cb2870 Manual roll of Clang from 725656bdd885 to 145176dc0c93 (flutter/engine#52823) 
See https://github.com/flutter/flutter/issues/143178
 2024-05-16 17:16:21 +00:00
skia-flutter-autoroll
0d2b0cd0ed Roll Skia from dafbdcc7f1fd to 320b00b025b8 (2 revisions) (flutter/engine#52876) 
https://skia.googlesource.com/skia.git/+log/dafbdcc7f1fd..320b00b025b8

2024-05-16 jvanverth@google.com [graphite] Hook up gamma adjustment for SDF text.
2024-05-16 ccameron@chromium.org SkJpegEncoder: Specify metadata segments explicitly

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-16 16:40:04 +00:00
skia-flutter-autoroll
3a468e8e7c Roll Dart SDK from 1600c3bae731 to b64b487c9967 (1 revision) (flutter/engine#52874) 
https://dart.googlesource.com/sdk.git/+log/1600c3bae731..b64b487c9967

2024-05-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-161.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-16 14:03:26 +00:00
skia-flutter-autoroll
b6cebe9c92 Roll Skia from a01d9bb9d4b3 to 9c3b296f7b58 (1 revision) (flutter/engine#52872) 
https://skia.googlesource.com/skia.git/+log/a01d9bb9d4b3..9c3b296f7b58

2024-05-16 bungeman@google.com Test effect of sbix originOffset fields

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-16 08:28:07 +00:00
skia-flutter-autoroll
f73d4a934f Roll Skia from 91527e447923 to 5a9402854577 (1 revision) (flutter/engine#52869) 
https://skia.googlesource.com/skia.git/+log/91527e447923..5a9402854577

2024-05-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from c8e24928e2f9 to e9be917b1b0d (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC armansito@google.com,bdero@google.com,brianosman@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-16 06:01:28 +00:00
Matan Lurey
b0e791fce3 et generates {out}/{buildName} if missing on et {build|test|query} (flutter/engine#52866) 
Closes https://github.com/flutter/flutter/issues/148442.

This restores functionality that existed prior in https://github.com/flutter/engine/pull/52832:

- Splits `runGn` to `ensureBuildDir`, which is in practice what it does.
 2024-05-16 04:03:21 +00:00
auto-submit[bot]
d810c59879 Reverts "Revamp the engine style guide, remove always_specify_types. (#52859)" (flutter/engine#52867) 
Reverts: flutter/engine#52859
Initiated by: zanderso
Reason for reverting: This sort of change *is* in scope for a discussion at the Dash forum.
Original PR Author: matanlurey

Reviewed By: {cbracken, gaaclarke, johnmccutchan}

This change reverts the following previous change:
Based on the (internal) discussion around converging on using the official Dart style guide, with the exception of the code that gets published under `dart:ui`, as that is user-facing, and we'd like to evolve the code style in conjunction with the framework.

I also took the opportunity to specify more about our style guide use in general, mostly to make it easier to understand our conventions, and also call out known problem areas (notably, our over-use of `shared_ptr` and `auto` in some cases). I am happy to split those up, but it was easier to make the markdown changes at once.

I also took @cbracken and folks advice and clarified directly that explicit types in Dart are _not_ bad (with examples).
 2024-05-16 02:51:50 +00:00
Matan Lurey
eafc52c37d Include stdout on a failed gn desc call, and test for it. (flutter/engine#52863) 
Fixes https://github.com/flutter/flutter/issues/148431, in that full error output is now shown.

I also filed an additional issue for how we could do better: https://github.com/flutter/flutter/issues/148442.
 2024-05-16 01:09:13 +00:00