Issue anERROR instead of an INFO for a non-working API. (flutter/engine#52892)

Work towards https://github.com/flutter/flutter/issues/139702.

I think we should also `@Deprecate`/cleanup the API surface in
`FlutterView`, but that needs a bit more a discussion.

/cc @johnmccutchan
This commit is contained in:
Matan Lurey 2024-05-17 08:40:45 -07:00 committed by GitHub
parent 4ab054b05c
commit 1bfe32e757

View File

@ -287,11 +287,14 @@ void PlatformViewAndroid::RegisterExternalTexture(
texture_id, surface_texture, jni_facade_));
break;
case AndroidRenderingAPI::kSoftware:
case AndroidRenderingAPI::kImpellerVulkan:
FML_LOG(INFO)
<< "Attempted to use a SurfaceTextureExternalTexture with an "
"unsupported rendering API.";
FML_LOG(INFO) << "Software rendering does not support external textures.";
break;
case AndroidRenderingAPI::kImpellerVulkan:
FML_LOG(ERROR) << "Impeller requires migrating plugins that create and "
"register surface textures to the new surface producer "
"API. See "
"https://docs.flutter.dev/release/breaking-changes/"
"android-surface-plugins";
}
}
@ -319,9 +322,7 @@ void PlatformViewAndroid::RegisterImageTexture(
texture_id, image_texture_entry, jni_facade_));
break;
case AndroidRenderingAPI::kSoftware:
FML_LOG(INFO)
<< "Attempted to use a SurfaceTextureExternalTexture with an "
"unsupported rendering API.";
FML_LOG(INFO) << "Software rendering does not support external textures.";
break;
}
}