LongCatIsLooong
2fcda04790
Add error handling for Element lifecycle user callbacks ( #173148 )
...
This is for #172289 , but since this fix is speculative so I'll wait for
the confirmation from the original reporters before closing the issue.
As a bonus this fixes #65655
The framework Element rebuild logic relies heavily on
`Element._lifecycleState` being correct. When a user-supplied lifecycle
callback (e.g., `State.deactivate`) fails the framework currently only
ensures that every `Element` in the tree has the right lifecycle state,
so an out-of-tree `Element` that is supposed to be disposed may still
have an `active` state and continue being rebuilt by the BuildScope
(because it's in the dirty list). See the comments in #172289
Also related:
#100777
Internal:
b/425298525 b/431537277
b/300829376 b/415724119 b/283614822
# TODO (in a different PR)
The original issue could also be caused by incorrect
`Element.updateChild` calls. If an `Element` subclass calls
`Element.updateChild` to add child but forgets to update its child list
accordingly (such that `visitChildren` misses that child), you'll get a
child Element that thinks it's a child of the parent but the parent
doesn't recognize the child so won't take that child into account during
reparenting or unmounting. This is a programmer error that we should try
to catch in the framework.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-08-14 19:53:20 +00:00
engine-flutter-autoroll
ad7ee1cf04
Roll Fuchsia Linux SDK from I1TfNmsqTp7t3rO8e... to zWRpLglb48zC1vZLv... ( #173784 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-14 18:40:26 +00:00
Hannah Jin
450401dfec
[Range slider] Tap on active range, the thumb closest to the mouse cursor should move to the cursor position. ( #173725 )
...
Fix: https://github.com/flutter/flutter/issues/172923
Internal issue: b/434778923
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-08-14 18:27:51 +00:00
engine-flutter-autoroll
38eae2bf09
Roll Packages from 6cb9113d5fa4 to 09533b7d5d66 (4 revisions) ( #173789 )
...
6cb9113d5f...09533b7d5dengine-flutter-autoroll@skia.org Roll Flutter from
34c2a3b158b2 to f4334d27934b (18 revisions) (flutter/packages#9807 )
2025-08-14 stuartmorgan@google.com Add review agent style guidelines to
.gemini/styleguide.md (flutter/packages#9805 )
2025-08-13 koji.wakamiya@gmail.com [go_router_builder] Support extension
types (flutter/packages#9458 )
2025-08-13 engine-flutter-autoroll@skia.org Roll Flutter from
e2a347b14a18 to 34c2a3b158b2 (41 revisions) (flutter/packages#9803 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-14 18:26:33 +00:00
Dev TtangKong
03736a282e
Implements the Android native stretch effect as a fragment shader (Impeller-only). ( #169293 )
...
> Sorry, Closing PR #169196 and reopening this in a new PR for clarity
and a cleaner commit history.
Fixes #82906
In the existing Flutter implementation, the Android stretch overscroll
effect is achieved using Transform. However, this approach does not
evenly stretch the screen as it does in the native Android environment.
Therefore, in the Impeller environment, add or modify files to implement
the effect using a fragment shader identical to the one used in native
Android.
> [!NOTE]
> - The addition of a separate test file for StretchOverscrollEffect was
not included because it would likely duplicate coverage already provided
by the changes made in overscroll_stretch_indicator_test.dart within
this PR.
>> However, since determining whether stretching occurred by referencing
global coordinates is currently considered impossible with the new
Fragment Shader approach, the code was modified to partially exclude the
relevant test logic in the Impeller.
>>
>> For reference, in the page_view_test.dart test, there was an issue
with referencing the child Transform widget, but because the
StretchOverscrollEffect widget is defined instead of the Transform
widget in the Impeller environment, the code logic was adjusted
accordingly.
>
> - Golden image tests were updated as the visual effect changes.
## Reference Source
-
https://cs.android.com/android/platform/superproject/main/+/main:frameworks/base/libs/hwui/effects/StretchEffect.cpp
## `Old` Skia (Using Transform)
https://github.com/user-attachments/assets/22d8ff96-d875-4722-bf6f-f0ad15b9077d
## `New` Impeller (Using fragment shader)
https://github.com/user-attachments/assets/73b6ef18-06b2-42ea-9793-c391ec2ce282
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Kate Lovett <katelovett@google.com>
2025-08-14 18:13:54 +00:00
Matan Lurey
20563f943f
Sync CHANGELOG.md (3.35 -> master) ( #173790 )
...
No changes, just syncing from the 3.35 branch.
2025-08-14 18:08:59 +00:00
Victor Sanni
e68da97bd5
[VPAT][A11y] Announce Autocomplete search results status ( #173480 )
...
Status announcements 'Search results found' and 'no results found' were
observed on a search view on the iOS sheets app.
Fixes [[VPAT][A11y] autocomplete must announce status when search result
is available](https://github.com/flutter/flutter/issues/173064 )
Fixes b/429094918
2025-08-14 18:06:57 +00:00
Bruno Leroux
ee3551fbe4
Fix InputDecorator label padding ( #173344 )
...
## Description
This PR fixes the label padding for an InputDecorator with prefixIcon
and/or suffixIcon.
# Before
The label was shorter than the available space because
`InputDecoration.contentPadding.horizontal` was applied even when
`prefixIcon` and `suffixIcon` were defined. The icons width replaces the
corresponding `contentPadding`, so both should not be used at the same
time to compute the available space.
<img width="269" height="61" alt="image"
src="https://github.com/user-attachments/assets/e1433ffb-8f17-46fe-9a65-6b9a504ef043 "
/>
# After
The label takes all the available space.
<img width="269" height="61" alt="image"
src="https://github.com/user-attachments/assets/12e8d087-c75b-48c9-8df4-1b11207c0e73 "
/>
## Related Issue
Fixes [Label padding is wrong for InputDecorator with prefixIcon and/or
suffixIcon ](https://github.com/flutter/flutter/issues/173341 )
## Tests
Adds 1 test.
2025-08-14 17:38:02 +00:00
EdwynZN
e2c7311956
Fix default minimumSize in dropdownMenu when maximumSize is null ( #169438 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
Previous change in `DropDownMenu`
https://github.com/flutter/flutter/pull/162380 forced the menu width to
be constrained between the width or anchorWidth and the maximumSize
width menuStyle, but giving a minimum of zero when maximumSize was not
enforced or null. This prevents width or anchorWidth to be used at all
as the minimum will be zero always if maximumSize is null
Now this sets the default value back to width or anchorWidth if
maximumSize is null, keeping consistency of the previous configuration
while using the fix of maximumSize when provided.
Fixes https://github.com/flutter/flutter/issues/170970
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
2025-08-14 17:36:09 +00:00
Matan Lurey
d0851959fe
Thread sub-builders for every engine-uploading builder ( #173742 )
...
Closes https://github.com/flutter/flutter/issues/173655 .
We should consider making these flags either the default (opt-out to
`false`) or evergreen (no opt-out).
2025-08-14 16:05:26 +00:00
engine-flutter-autoroll
f4334d2793
Roll Dart SDK from 9b4691f35139 to 214a7f829913 (2 revisions) ( #173769 )
...
https://dart.googlesource.com/sdk.git/+log/9b4691f35139..214a7f829913
2025-08-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-98.0.dev
2025-08-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-97.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert
to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-14 14:54:39 +00:00
engine-flutter-autoroll
c932faf754
Roll Skia from b3e86773dae1 to dca5f05fee87 (4 revisions) ( #173763 )
...
https://skia.googlesource.com/skia.git/+log/b3e86773dae1..dca5f05fee87
2025-08-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from cfeea900811c to 899f3505748e (2 revisions)
2025-08-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 98d09f8e88db to fed7f25ca957 (1 revision)
2025-08-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 180eb3f989b3 to e07d4f333e72 (20 revisions)
2025-08-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from c3c9f7778507 to 1d9ad72b24bd (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-14 09:43:29 +00:00
engine-flutter-autoroll
9b219ec445
Roll Dart SDK from 73153bdc1459 to 9b4691f35139 (3 revisions) ( #173755 )
...
https://dart.googlesource.com/sdk.git/+log/73153bdc1459..9b4691f35139
2025-08-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-96.0.dev
2025-08-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-95.0.dev
2025-08-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-94.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert
to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-14 06:35:10 +00:00
engine-flutter-autoroll
d9c31fbb1d
Roll Skia from 5852eddfd404 to b3e86773dae1 (1 revision) ( #173750 )
...
https://skia.googlesource.com/skia.git/+log/5852eddfd404..b3e86773dae1
2025-08-13
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-14 03:54:31 +00:00
Azat Chorekliyev
e1eb1a67dd
Allow empty initial time when using text input mode in showTimePicker dialog ( #172847 )
...
Added ability to allow empty initial time when using text input mode in
showTimePicker dialog https://github.com/flutter/flutter/issues/169131
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
---------
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-08-14 00:10:11 +00:00
engine-flutter-autoroll
bfee6183ca
Roll Skia from 525e2bf80559 to 5852eddfd404 (2 revisions) ( #173740 )
...
https://skia.googlesource.com/skia.git/+log/525e2bf80559..5852eddfd404
2025-08-13 bungeman@google.com Fix Android NDK FontMgr alias scanning
2025-08-13
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-13 23:58:04 +00:00
Mouad Debbar
f83d8cfd3a
[web] Popping a nameless route should preserve the correct route name ( #173652 )
...
Fixes https://github.com/flutter/flutter/issues/173356
2025-08-13 23:53:05 +00:00
Ahmed Mohamed Sameh
72e1bf1a15
Make sure that a ChoiceChip doesn't crash in 0x0 environment ( #173322 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the ChoiceChip UI
control.
2025-08-13 23:53:03 +00:00
Ben Konyi
1c0ee96c8f
[ Tool ] Fix missing import for widget_preview.dart ( #173731 )
...
The import was removed in a PR that landed after all presubmits passed.
2025-08-13 21:03:14 +00:00
engine-flutter-autoroll
d9daafded5
Roll Skia from f7fdda3cd0e6 to 525e2bf80559 (7 revisions) ( #173727 )
...
https://skia.googlesource.com/skia.git/+log/f7fdda3cd0e6..525e2bf80559
2025-08-13 nicolettep@google.com [graphite] Add SPIR-V validation to
SPIR-V transformer
2025-08-13 kjlubick@google.com Update fuzzer documentation to include
new bucket
2025-08-13 robertphillips@google.com Rehabilitate some Mac15 jobs
2025-08-13 mike@reedtribe.org use pathbuilder for dash culling
2025-08-13 kjlubick@google.com Add notes about oss-fuzz and status
2025-08-13 kjlubick@google.com Reland "Fix bazel release build to not
compile debug code"
2025-08-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 1ecf22990490 to c3c9f7778507 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-13 20:37:43 +00:00
Matan Lurey
446adb1acc
Do not include :unittests unless enable_unittests ( #173729 )
...
Closes https://github.com/flutter/flutter/issues/173728 .
This will need to be cherrypicked into both 3.35 and 3.36.
2025-08-13 20:19:16 +00:00
engine-flutter-autoroll
db1ede369f
Roll Packages from 08a9b2cc46dd to 6cb9113d5fa4 (1 revision) ( #173726 )
...
08a9b2cc46...6cb9113d5fkoji.wakamiya@gmail.com [go_router_builder] Migrate to
Element2 API and update dependencies (flutter/packages#9649 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-13 19:31:35 +00:00
Albin PK
90a892293c
fix: selected date decorator renders outside PageView in DatePickerDialog dialog ( #171718 )
...
Wraps `PageView` with a transparent `Material` to ensure the selected
date decorator is painted in the correct context, avoiding visual
glitches during transitions.
Fixes #171717
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
---------
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Huy <huy@nevercode.io>
2025-08-13 19:12:53 +00:00
Ben Konyi
f8e8a8dce9
[ Widget Preview ] Add --machine mode ( #173654 )
...
Currently only outputs a single event with information about where the
widget preview environment is served from:
`[{"event":"widget_preview.started","params":{"url":"http://localhost:61383 "}}]`
Fixes https://github.com/flutter/flutter/issues/173545
2025-08-13 19:08:53 +00:00
Ahmed Mohamed Sameh
9e99953a4e
Make sure that a Chip doesn't crash in 0x0 environment ( #173245 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the Chip UI control.
2025-08-13 19:08:49 +00:00
masato
4051fab349
feat: Cupertino sheet implement upward stretch on full sheet ( #168547 )
...
implimented(https://github.com/flutter/flutter/issues/161686 )
This PR implements a subtle stretch effect when the user drags the sheet
upward.
It achieves this by dynamically adjusting the top padding while the
sheet is fully expanded.
https://github.com/user-attachments/assets/ee98ab82-bc84-40b5-839f-82ae6de59e36
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-08-13 19:07:29 +00:00
TheLastFlame
61a4d24da5
Fix visual overlap of transparent routes barrier when using FadeForwardsPageTransitionsBuilder ( #167032 )
...
Reopens https://github.com/flutter/flutter/pull/165726 with the removed
test that has become irrelevant.
Depends on: https://github.com/flutter/flutter/pull/167324
Actual master:
https://github.com/user-attachments/assets/28619355-9c1e-4f06-9ede-38c4dddd13df
After fix:
https://github.com/user-attachments/assets/a5f2ecf2-5d8e-445a-b5a9-a7d6c0e3ec5d
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
---------
Co-authored-by: Justin McCandless <jmccandless@google.com>
Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
2025-08-13 19:07:29 +00:00
Valentin Vignal
dd7b2130a1
Fix ChipThemeData lerp for BorderSide ( #173160 )
...
In https://github.com/flutter/flutter/pull/171945#discussion_r2245715705
we realised that some `lerp` method for `BorderSide` had a bug.
This PR
- Fixes a wrong interpolation of `ChipThemeData.lerp` for `side` in the
case of `b` being `null`
- Do some cleaning of other `lerp` of `BorderSide?`
Fixes https://github.com/flutter/flutter/issues/173161
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-08-13 19:06:00 +00:00
Ben Konyi
34c2a3b158
[ Tool ] Mark Linux_pixel_7pro linux_chrome_dev_mode as bringup ( #173646 )
...
There seems to be issues with Chrome flakily either having too many open
tabs or none at all. This needs to be investigated further and shouldn't
block the tree.
Related issue: https://github.com/flutter/flutter/issues/173696
2025-08-13 18:04:33 +00:00
Ben Konyi
1eb2f68da5
[ Widget Preview ] Move --dtd-url from a global flag to a widget-preview start option ( #173712 )
...
`--dtd-url` is only used by widget previews and has no current usage, so
this is a safe change.
2025-08-13 16:14:22 +00:00
Jamil Saadeh
f26eddba00
Null aware elements clean-ups ( #173074 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
Converted more null checks to null aware elements.
The analyzer had many false negatives and the regex became pretty wild
to find many of them 😂
I've found more in the engine folder but I'll apply the changes in a
separate PR
Part of #172188
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-08-13 15:36:14 +00:00
engine-flutter-autoroll
ef76a61283
Roll Skia from 29e3e1ab7f62 to f7fdda3cd0e6 (3 revisions) ( #173709 )
...
https://skia.googlesource.com/skia.git/+log/29e3e1ab7f62..f7fdda3cd0e6
2025-08-13 mike@reedtribe.org Conditionally switch technique for
rect::bounds
2025-08-13 robertphillips@google.com Revert "Fix bazel release build to
not compile debug code"
2025-08-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 3643c21d9d0c to cfeea900811c (12 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-13 15:34:12 +00:00
Matthew Kosarek
738ec1a4b9
Regular windows win32 engine ( #173424 )
...
## What's new?
This pull request implements the remaining bits necessary for landing
regular windows on win32 for the engine only.
- Updated `InternalFlutterWindows_WindowManager_CreateRegularWindow`
- Separated constraints and size to two different fields
- Added title
- Updated `InternalFlutterWindows_WindowManager_SetWindowSize`
- Added `InternalFlutterWindows_WindowManager_SetWindowConstraints`
- Added `InternalFlutterWindows_WindowManager_SetFullscreen`
- Added `InternalFlutterWindows_WindowManager_GetFullscreen`
- Added integration tests, but let me know if you think more tests would
help! I felt that the integration tests showed off the functionality
very well.
https://github.com/canonical/flutter/pull/64 will follow with the
framework side of things 🚀
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
2025-08-13 15:00:48 +00:00
engine-flutter-autoroll
9cbd55ceb8
Roll Dart SDK from a098cb676fd6 to 73153bdc1459 (1 revision) ( #173708 )
...
https://dart.googlesource.com/sdk.git/+log/a098cb676fd6..73153bdc1459
2025-08-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-93.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert
to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-13 14:31:46 +00:00
engine-flutter-autoroll
6a89f1e753
Roll Fuchsia Linux SDK from vgv-rTf7i9PfcDq2Y... to I1TfNmsqTp7t3rO8e... ( #173690 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC chinmaygarde@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-13 10:03:44 +00:00
engine-flutter-autoroll
faec667402
Roll Skia from 1170405c30cf to 29e3e1ab7f62 (2 revisions) ( #173689 )
...
https://skia.googlesource.com/skia.git/+log/1170405c30cf..29e3e1ab7f62
2025-08-13
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 6831e9de3fb3 to 180eb3f989b3 (13 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-13 09:17:38 +00:00
engine-flutter-autoroll
554714c663
Roll Dart SDK from e2b7aec7333e to a098cb676fd6 (4 revisions) ( #173683 )
...
https://dart.googlesource.com/sdk.git/+log/e2b7aec7333e..a098cb676fd6
2025-08-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-92.0.dev
2025-08-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-91.0.dev
2025-08-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-90.0.dev
2025-08-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-89.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert
to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-13 07:17:28 +00:00
engine-flutter-autoroll
bc7517537d
Roll Skia from d06fdf03c6a1 to 1170405c30cf (4 revisions) ( #173681 )
...
https://skia.googlesource.com/skia.git/+log/d06fdf03c6a1..1170405c30cf
2025-08-13
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-13
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 197d56d8aef9 to 1ecf22990490 (5 revisions)
2025-08-12
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-13 06:47:40 +00:00
engine-flutter-autoroll
f93f3053c8
Roll Skia from 9ed4b4e53db2 to d06fdf03c6a1 (11 revisions) ( #173661 )
...
https://skia.googlesource.com/skia.git/+log/9ed4b4e53db2..d06fdf03c6a1
2025-08-12
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-12
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-12 jlavrova@google.com Revert "Change internal cache to be
per-name/face"
2025-08-12 syoussefi@google.com Disable
VK_EXT_rasterization_order_attachment_access on ARM
2025-08-12 nicolettep@google.com Fix bazel release build to not compile
debug code
2025-08-12 mike@reedtribe.org Change internal cache to be per-name/face
2025-08-12 mike@reedtribe.org use new path::iter
2025-08-12 kjlubick@google.com Make skslc use Tint built from CMake
instead of GN rules
2025-08-12 nicolettep@google.com Remove
GrAHardwareBufferUtils::GetSkColorTypeFromBufferFormat
2025-08-12 drott@chromium.org Remove Fontations suffixing in Fontations
Typeface impl
2025-08-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 974e23c791f2 to 197d56d8aef9 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-13 02:04:23 +00:00
Robert Ancell
53676f000b
Fix GTK redraw call being called from non-GTK thread. ( #173602 )
...
gtk_widget_queue_draw is not thread-safe, call it from an idle callback.
Fixes https://github.com/flutter/flutter/issues/173447
2025-08-12 22:56:19 +00:00
Jason Simmons
a07fc6b910
[Impeller] Apply Y coordinate scaling when sampling from the destination texture in framebuffer advanced blends ( #173639 )
...
Fixes https://github.com/flutter/flutter/issues/173162
2025-08-12 22:13:23 +00:00
romain.gyh
b46a6aa9a6
Fix directional focus in nested scrollables with different axis ( #172875 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
Related issue : #172854
Fixes #160431
This PR fixes the focus when navigating with keyboard arrows or TV
remote d-pad in a nested lists with different axis and a fixed focusable
at the top.
It's a common setup for apps that deal with images or videos.
The problem is that when the vertical scrollbar has scrolled and you
want to scroll back to the top without the mouse, only using keyboard up
arrow to jump from widgets to widgets in the list until reaching the
top, the fixed top focusable widget wrongly takes the focus instead of
letting the vertical scrollable scroll.
I think the video bellow explain the problem better.
| Before this PR | After this PR |
|--------|--------|
|
https://github.com/user-attachments/assets/54160e0c-abe5-4181-9aea-8351ce5f35b5
|
https://github.com/user-attachments/assets/eee32175-37eb-44a6-a7c2-a751fc82d592
|
Note that I had to edit two existing tests because they were failing
with my edits. However, I think these tests were testing a bad behavior.
For example here is the visualization of the `Focus traversal inside a
vertical scrollable scrolls to stay visible` test case before this PR :
https://github.com/user-attachments/assets/be843ae8-a0df-411e-971c-3bf763c457e0
Test was green bug the focus behavior is weird. When pressing arrow down
from item 3 we would expect a scroll and item 4 to be focused, here it's
footer that is focused and when we press arrow down again item 5 is
focused and item 4 is skipped.
Here is the behavior after this PR and the test edited :
https://github.com/user-attachments/assets/b90757a8-042d-4d53-b7e6-19b9141cc83f
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-08-12 22:07:18 +00:00
hellohuanlin
b581cda7b9
[ios][tools]do not log "bonjour not found" at all (unless verbose) ( #173569 )
...
The previous PR https://github.com/flutter/flutter/pull/172913 avoids
compilation error by not having the "error: " prefix. However, it's
still very confusing to have "key not found" printed out in the terminal
(either stderr or stdout), despite that it doesn't cause compilation
error anymore.
This PR introduces a new flag "skipErrorLog" which skips logging the
`stderr` if set to true. We set it for plist extraction, because "not
having bonjour key" should be one of the expected "normal" states
<s> We don't want to pipe it to `stdout` either, because it would be
confusing too. I figured people would still file issue if they see it in
terminal, even if it's a completely normal state. But not a strong
opinion, so let me know if you disagree. </s>
However, under verbose mode, we would pipe it to `stdout`. This will be
consistent with our previous behavior before macOS 26.
*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*
Fixes https://github.com/flutter/flutter/issues/172627
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-08-12 22:00:09 +00:00
Reid Baker
f6bbf76524
Remove jetifier usages ( #173548 )
...
- **Remove jetifiier usages across repo**
Similar to https://github.com/flutter/flutter/pull/173459
Related to #173430
Used `grep --exclude-dir=third_party --include=gradle\.properties -rw .
-e "android.enableJetifier=true"` to find usages.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-08-12 21:03:55 +00:00
Ben Konyi
8c358779aa
[ Tool ] Fix run_linux_chrome_dev_mode ( #173647 )
...
It's possible for Chrome to open with two tabs pointing to localhost,
which was causing this test to fail. This change updates the Chrome
connection logic to look for the specific URL Chrome was told to
navigate to at launch, if one was provided.
2025-08-12 21:13:24 +00:00
hellohuanlin
b0c8612eda
[ios] Update iOS code signing CIPD instruction command ( #171173 )
...
Replace `version:to_2025` with `YOUR_NEW_TAG` (similar to
`AMD64_INSTANCE_ID`). This should help avoid setting the wrong tag.
Note to myself: the current instruction was pointing to the old repo
(flutter/engine). Remember to update it.
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
*Replace this paragraph with a description of what this PR is changing
or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*
https://github.com/flutter/flutter/issues/168427
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-08-12 18:44:43 +00:00
Ben Konyi
c4ce6a8ef7
Reapply "Make device debuggable if useDwdsWebSocketConnection is true … ( #173551 )" ( #173628 )
...
This reverts commit
17c92b7ba6
2025-08-12 17:23:19 +00:00
Jason Simmons
f45a8f8b71
Roll Clang to 8c7a2ce01a77c96028fe2c8566f65c45ad9408d3 ( #173429 )
...
This version is currently used by Dart.
2025-08-12 17:21:53 +00:00
Mouad Debbar
f63cb75520
[web] Fallback to CanvasKit when WebGL is not available ( #173629 )
...
Fixes https://github.com/flutter/flutter/issues/173401
2025-08-12 17:07:11 +00:00
engine-flutter-autoroll
4534042cb6
Roll Packages from a114ac22b1d0 to 08a9b2cc46dd (3 revisions) ( #173625 )
...
a114ac22b1...08a9b2cc46nikunjr@cybage.com [in_app_purchase_storekit] Add support for
quantity in consumable product purchases (#171570 )
(flutter/packages#9698 )
2025-08-11 10687576+bparrishMines@users.noreply.github.com [pigeon]
Improves documentation of `ProxyApi` and moves helper functions to a
separate file (flutter/packages#9756 )
2025-08-11 engine-flutter-autoroll@skia.org Roll Flutter from
1590543f6794 to e2a347b14a18 (1 revision) (flutter/packages#9784 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-08-12 15:53:43 +00:00
