Daco Harkes
2e229be2ff
Native assets: package in framework on iOS and MacOS ( #140907 )
...
Packages the native assets for iOS and MacOS in frameworks.
Issue:
* https://github.com/flutter/flutter/issues/140544
* https://github.com/flutter/flutter/issues/129757
## Details
* [x] This packages dylibs from the native assets feature in frameworks. It packages every dylib in a separate framework.
* [x] The dylib name is updated to use `@rpath` instead of `@executable_path`.
* [x] The dylibs for flutter-tester are no longer modified to change the install name. (Previously it was wrongly updating the install name to the location the dylib would have once deployed in an app.)
* [x] Use symlinking on MacOS.
2024-01-19 20:29:13 +00:00
Ian Hickson
77c3807c80
Revert "Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal ( #140101 )" ( #141814 )
...
Reverts https://github.com/flutter/flutter/pull/140101
That PR somehow made non-matching gold tests not fail at HEAD.
Fixes https://github.com/flutter/flutter/issues/141880
- Blocked by https://github.com/flutter/flutter/issues/140169
- https://github.com/flutter/flutter/pull/141427
2024-01-19 20:29:11 +00:00
engine-flutter-autoroll
49447fc68b
Roll Flutter Engine from 538975f2511b to c953c83112ba (3 revisions) ( #141886 )
...
538975f251...c953c83112flar@google.com [Impeller] switch Rect fields to LTRB implementation (flutter/engine#49816 )
2024-01-19 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Redo - Use chromium test-scripts to download images and execute tests (flutter/engine#49847 )
2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from fb3f61d932e6 to 2536dc6fef1d (2 revisions) (flutter/engine#49892 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-19 20:07:51 +00:00
Qun Cheng
ba4a11dafa
Add showDragHandle to showBottomSheet ( #141754 )
2024-01-19 11:17:40 -08:00
engine-flutter-autoroll
3563372f06
Roll Flutter Engine from 9a6c64de8a46 to 538975f2511b (8 revisions) ( #141881 )
...
9a6c64de8a...538975f251skia-flutter-autoroll@skia.org Roll Skia from 0a78d1f0ef48 to fb3f61d932e6 (1 revision) (flutter/engine#49891 )
2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from 961ad2c3fcf5 to 0a78d1f0ef48 (1 revision) (flutter/engine#49890 )
2024-01-19 103135467+sealesj@users.noreply.github.com Re-enable osv-scanner on pushes to main (flutter/engine#49729 )
2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from 273b0628a969 to 961ad2c3fcf5 (1 revision) (flutter/engine#49889 )
2024-01-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from dTy8CK4YxnUsW305O... to geXIwPzzJiSXrZEEb... (flutter/engine#49888 )
2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from b6fa819eb54c to 273b0628a969 (1 revision) (flutter/engine#49887 )
2024-01-19 skia-flutter-autoroll@skia.org Roll Skia from e073a4fad57a to b6fa819eb54c (1 revision) (flutter/engine#49886 )
2024-01-19 leroux_bruno@yahoo.fr [Android] Fix KeyEmbedderResponder throws a NullPointerException (flutter/engine#49860 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from dTy8CK4YxnUs to geXIwPzzJiSX
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-19 18:44:07 +00:00
Michael Goderbauer
cc544169be
Make pumpWidget's arguments named ( #141728 )
...
Much nicer calling API and simplifies evolving this API in the future.
I wish we could write a dart fix for this, but that's blocked on https://github.com/dart-lang/sdk/issues/54668 .
2024-01-19 18:29:07 +00:00
fzyzcjy
9e024fdf31
Tiny fix inaccurate documentations about bindings ( #140282 )
...
The old doc says that, AutomatedTestWidgetsFlutterBinding for `flutter test` and LiveTestWidgetsFlutterBinding for `flutter run`. However, suppose we `flutter test integration_test/simple_test.dart` with the following code:
```
void main() {
testWidgets('hi', (WidgetTester tester) async {
print('hi ${TestWidgetsFlutterBinding.instance} ${Platform.operatingSystem}');
});
}
```
We will see: `hi <IntegrationTestWidgetsFlutterBinding> ios`. Therefore, we see `IntegrationTestWidgetsFlutterBinding` is used in a `flutter test` command, which is contrary to the documentation.
2024-01-19 17:45:13 +00:00
Zachary Anderson
d4707d12d5
Roll engine to 9a6c64de8a4694cef59a338cd33ac1a9e7d23d9d ( #141870 )
...
Includes the Engine roll from
https://github.com/flutter/flutter/pull/141841
A new version of Dart is having trouble with the tool integration test
test `passing one file with errors are detected`:
https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20tool_integration_tests_2_4/31851/overview .
However the analysis server emits the expected errors when we give it
both the file without issues and the file with issues.
My guess is that the analysis server has changed it's behavior slightly
when supplied with a single malformed file.
Since the Dart roll is >20 dev versions behind, and this is the only
failing presubmit test, and it's testing something a bit weird, I
suggest we investigate the right way to test the thing that test was
attempting to cover as a follow-up.
2024-01-19 09:38:01 -08:00
engine-flutter-autoroll
0487931ac2
Roll Packages from 83c2c4da97c5 to 129e08c1dff1 (13 revisions) ( #141865 )
...
83c2c4da97...129e08c1dfmagder@google.com [pigeon] Run swift-format on ungenerated example app Swift files (flutter/packages#5934 )
2024-01-19 magder@google.com [path_provider_foundation] Run swift-format on Swift files (flutter/packages#5935 )
2024-01-19 magder@google.com [shared_preferences_foundation] Run swift-format on Swift files (flutter/packages#5933 )
2024-01-19 magder@google.com [various] Run swift-format on example app Swift files (flutter/packages#5931 )
2024-01-19 magder@google.com [camera_avfoundation] Remove development team from Xcode example app (flutter/packages#5930 )
2024-01-18 jsharp83@gmail.com [webview_flutter_wkwebview] Add javascript panel interface for wkwebview (flutter/packages#5795 )
2024-01-18 amirpanahandeh@yahoo.com [two_dimensional_scrollables] Fix must_call_super (flutter/packages#5921 )
2024-01-18 cedvandenbosch@gmail.com [pointer_interceptor] fix width and height unset warning on web platform (flutter/packages#5864 )
2024-01-18 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.23.0 to 3.23.1 (flutter/packages#5922 )
2024-01-18 stuartmorgan@google.com [google_maps_flutter] Clean up iOS example project (flutter/packages#5925 )
2024-01-18 magder@google.com [ci] Add flags to formatter command to decide which formatters to run (flutter/packages#5905 )
2024-01-18 15619084+vashworth@users.noreply.github.com Update tests to Xcode 15 and iOS 17 simulator (flutter/packages#5914 )
2024-01-18 engine-flutter-autoroll@skia.org Roll Flutter from def6af0b8e6e to f77f82435a97 (25 revisions) (flutter/packages#5924 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-19 15:52:50 +00:00
godofredoc
c95bb6fbb3
Add mac_x64_ios configuration. ( #141828 )
...
This is in preparation to allow tests to run on x64 and arm64 if they rely only on the ios phone.
2024-01-19 03:42:23 +00:00
engine-flutter-autoroll
70a4a5de7c
Roll Flutter Engine from 90be25d8aac3 to d1afda52d254 (1 revision) ( #141825 )
...
90be25d8aa...d1afda52d2skia-flutter-autoroll@skia.org Roll Skia from c71519e854d1 to dd24bd11d79e (1 revision) (flutter/engine#49878 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-19 02:32:18 +00:00
Ian Hickson
8ff0af0c70
Move the requestKeyboard up to the widgets layer ( #141655 )
...
Turns out all implementations of this method made this call, so it seems like it should belong in the superclass.
2024-01-19 02:30:03 +00:00
engine-flutter-autoroll
46bbf4029a
Roll Flutter Engine from dde3ebf6551a to 90be25d8aac3 (1 revision) ( #141817 )
...
dde3ebf655...90be25d8aaskia-flutter-autoroll@skia.org Roll Skia from da3bfb25fb84 to c71519e854d1 (1 revision) (flutter/engine#49875 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-19 01:09:13 +00:00
Yegor
5987563e4a
enable more tests in web mode ( #141791 )
...
- Unskip `text_style_test` for CanvasKit.
- Remove no longer necessary `kIsWeb` checks in a few tests.
This PR depends on https://github.com/flutter/engine/pull/49786 , which rolled into the framework. If the engine PR needs to be reverted, this PR will need to be reverted too.
2024-01-18 23:55:33 +00:00
engine-flutter-autoroll
cdf82b2883
Roll Flutter Engine from 9dded186bcff to dde3ebf6551a (2 revisions) ( #141811 )
...
9dded186bc...dde3ebf655737941+loic-sharma@users.noreply.github.com [Windows] Refactor logic when window resize completes (flutter/engine#49872 )
2024-01-18 skia-flutter-autoroll@skia.org Roll Skia from 40200ceca00e to da3bfb25fb84 (1 revision) (flutter/engine#49873 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-18 23:50:50 +00:00
David Martos
197cd4d665
Update margin between label and icon in Tab to better reflect Material specs ( #140698 )
...
This PR improves the distance between the label and the icon in the Tab widget.
I updated the margin to 2 pixels, taken from the Figma design page for Material 3. On Material 2 I left the default value of 10 pixels.
Related to #128696 (In particular, the distance between label and icon)
Here are some screenshots for comparison. I looked a bit into the other mentioned issue of the tab height not following the M3 spec. Flutter uses 72 and the spec uses 64. But because Tab is a PreferredSizeWidget, I don't think there is an easy way to provide a different size depending on `ThemeData.useMaterial3`, because there is no `BuildContext` available.
I provide a sample image for the 64 height as well for context on the linked issue, even though it's not part of the PR changes.
The screenshots are taken side by side with the image at: https://m3.material.io/components/tabs/guidelines
## Original
## New (tab height = 72, Flutter default for 8 years)
## New (tab height = 64, M3 spec)
2024-01-18 23:04:26 +00:00
engine-flutter-autoroll
c1b01ec181
Roll Flutter Engine from 3106e08e1219 to 9dded186bcff (2 revisions) ( #141807 )
...
3106e08e12...9dded186bcfmil@google.com [fuchsia] Wire through the tzdata-icu capability (flutter/engine#48907 )
2024-01-18 skia-flutter-autoroll@skia.org Roll Skia from 31fae9f0cdd1 to 40200ceca00e (1 revision) (flutter/engine#49871 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-18 23:04:24 +00:00
auto-submit[bot]
1901d6fa10
Reverts "Enable native compilation for windows-arm64 " ( #141809 )
...
Reverts flutter/flutter#137618
Initiated by: Jasguerrero
This change reverts the following previous change:
Original Description:
It's now possible to natively compile a flutter app for
windows-arm64. Cross-compilation is not yet implemented.
Uses arm64 artifacts now available for Dart/Flutter.
Platform detection is based on Abi class, provided by Dart. Depending if
Dart is an arm64 or x64 binary, the Abi is set accordingly.
Initial bootstrap of dart artifacts (update_dart_sdk.ps1) is checking
PROCESSOR_ARCHITECTURE environment variable, which is the way to detect
host architecture on Windows.
This is available only for master channel (on other channels, it
fallbacks to windows-x64).
On windows-x64, it produces an x64 app. On windows-arm64, it produces an
arm64 app.
2024-01-18 22:48:16 +00:00
godofredoc
9d9bd884ea
Run framework_tests_misc in arm64 and x64. ( #141797 )
...
This is to ensure coverage in both platforms.
2024-01-18 22:40:16 +00:00
engine-flutter-autoroll
0dc066b717
Roll Flutter Engine from f4a4f046b173 to 3106e08e1219 (1 revision) ( #141802 )
...
f4a4f046b1...3106e08e12skia-flutter-autoroll@skia.org Roll Skia from 1064eeedac09 to 31fae9f0cdd1 (1 revision) (flutter/engine#49869 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-18 22:23:16 +00:00
dependabot[bot]
fac26c575d
Bump actions/upload-artifact from 4.1.0 to 4.2.0 ( #141803 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 4.1.0 to 4.2.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases ">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v4.2.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Ability to overwrite an Artifact by <a href="https://github.com/robherley "><code>@ârobherley</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/501 ">actions/upload-artifact#501</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4...v4.2.0 ">https://github.com/actions/upload-artifact/compare/v4...v4.2.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="694cdabd8bhttps://redirect.github.com/actions/upload-artifact/issues/501 ">#501</a> from actions/robherley/overwrite-artifact</li>
<li><a href="05d4fe670240b305282149552fcb8279615904cc11ff42c7b11eb3cb2b3e...694cdabd8bhttps://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=4.1.0&new-version=4.2.0 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-01-18 22:21:03 +00:00
Michael Goderbauer
d6a7f346f5
Update labeler.yml ( #141697 )
...
* `flutter_web_plugins` didn't have a label that would make PRs show up for team triage, now they are assigned to the web team so they don't fall through the cracks
* `flutter_goldens_client` doesn't exist anymore, deleted
* `integration_test` PRs should be treated like `flutter_test` or `flutter_driver` PRs and get the `a: tests` label.
2024-01-18 21:26:06 +00:00
engine-flutter-autoroll
c92b634e26
Roll Flutter Engine from 75400c49fa0b to f4a4f046b173 (2 revisions) ( #141800 )
...
75400c49fa...f4a4f046b11961493+harryterkelsen@users.noreply.github.com [canvaskit] Fall back to multi-context rendering on Firefox and Safari (flutter/engine#49572 )
2024-01-18 godofredoc@google.com Use any mac machine available for orchestrator run. (flutter/engine#49845 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-18 21:11:10 +00:00
Polina Cherkasova
2cd448574b
Reland "Remove hack from PageView." ( #141533 )
...
Fixes https://github.com/flutter/flutter/issues/141119
Original PR: https://github.com/flutter/flutter/pull/141138
Revert: https://github.com/flutter/flutter/pull/141479
Reason for revert: https://fusion2.corp.google.com/presubmit/597877179/OCL:597877179:BASE:597883748:1705084754455:88d992fc/targets
Fix: cl/599347719
2024-01-18 20:45:08 +00:00
Callum Moffat
e05d0dd21f
ScaleGestureRecognizer pointerCount=2 for trackpad gestures ( #140745 )
...
Now trackpad gestures will count as pointerCount=2 instead of 1. It makes it easier for people who want to have different behaviour for single-finger drag vs two-finger pan/zoom. Also fixed up `scale_test.dart` to verify `pointerCount` in more places.
Related: https://github.com/flutter/flutter/issues/13102
Fixes https://github.com/flutter/flutter/issues/140730
2024-01-18 20:15:38 +00:00
engine-flutter-autoroll
b0c5fc9154
Roll Flutter Engine from de68e7612948 to 75400c49fa0b (2 revisions) ( #141796 )
...
de68e76129...75400c49fa103135467+sealesj@users.noreply.github.com Simplify osv-scanner workflow (flutter/engine#49807 )
2024-01-18 skia-flutter-autoroll@skia.org Roll Skia from b1611add5939 to 1064eeedac09 (6 revisions) (flutter/engine#49867 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-18 20:14:05 +00:00
Victoria Ashworth
c92b20ba97
Run flutter_gallery_ios__start_up test on Mac-14 in staging ( #141795 )
...
Attempting to debug https://github.com/flutter/flutter/issues/141383 .
2024-01-18 20:05:10 +00:00
engine-flutter-autoroll
41cc84c0f1
Roll Flutter Engine from d80fe1cb5854 to de68e7612948 (1 revision) ( #141789 )
...
d80fe1cb58...de68e76129dnfield@google.com [Impeller] Eliminate some shared_ptr copying from EntityPass::Render (flutter/engine#49855 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-18 19:25:06 +00:00
Pierrick Bouvier
540559204e
Enable native compilation for windows-arm64 ( #137618 )
...
It's now possible to natively compile a flutter app for
windows-arm64. Cross-compilation is not yet implemented.
Uses arm64 artifacts now available for Dart/Flutter.
Platform detection is based on Abi class, provided by Dart. Depending if
Dart is an arm64 or x64 binary, the Abi is set accordingly.
Initial bootstrap of dart artifacts (update_dart_sdk.ps1) is checking
PROCESSOR_ARCHITECTURE environment variable, which is the way to detect
host architecture on Windows.
This is available only for master channel (on other channels, it
fallbacks to windows-x64).
On windows-x64, it produces an x64 app. On windows-arm64, it produces an
arm64 app.
2024-01-18 19:15:23 +00:00
Xilai Zhang
6e39eb75a1
[github actions] Fix token issue on actions/checkout package ( #141652 )
...
revision 01/17: instead of removing actions/checkout, keep actions/checkout but remove the `token` field and add `persist-credentials` field. tested with a [mirror script](https://github.com/XilaiZhang/miscellaneous-side-project/blob/master/.github/workflows/easy-cp.yml ) and creates [expected pull request](https://github.com/flutter/flutter/pull/141730 )
Issue: when running github actions, the [tokens not found error](https://github.com/actions/checkout/issues/298 ) still happens( `Input required and not supplied: token`). We are not using fork PR or dependabot, and it's flaky when the well defined token isn't find in the inputs. We hit this error when invoking [market place actions/checkout](https://github.com/actions/checkout ): [example failed run 1](https://github.com/flutter/flutter/actions/runs/7546108771/job/20543199801 ), [example failed run 2](https://github.com/flutter/flutter/actions/runs/7546141972/job/20543265842 )
In this PR, Remove the dependency on marketplace actions to make our workflow more reliable and less flaky.
other changes to remove actions/checkout dependency:
1. embedded token url for git push
Tried a number of ways and this is the only / best workaround I found to resolve [the notorious problem of pushing without ssh key](https://stackoverflow.com/questions/22147574/github-fatal-could-not-read-username-for-https-github-com-no-such-file-o ).
2. added back `--head`
`--head` is now needed to avoid [abort](https://github.com/XilaiZhang/miscellaneous-side-project/actions/runs/7548409479/job/20550397014 )
Test: a [replicate of the actions file](https://github.com/XilaiZhang/miscellaneous-side-project/blob/master/.github/workflows/easy-cp.yml ) is [tested](https://github.com/XilaiZhang/miscellaneous-side-project/actions/runs/7548448024/job/20550521341 ) on my personal repo, and it creates the [expected PR](https://github.com/flutter/flutter/pull/141647 )
2024-01-18 18:48:00 +00:00
engine-flutter-autoroll
c12d0068c5
Roll Flutter Engine from b75d6d80d813 to d80fe1cb5854 (2 revisions) ( #141785 )
...
b75d6d80d8...d80fe1cb5815619084+vashworth@users.noreply.github.com Update tests to Xcode 15 and iOS 17 simulator (flutter/engine#49833 )
2024-01-18 skia-flutter-autoroll@skia.org Roll Skia from 7b3d788ba978 to b1611add5939 (1 revision) (flutter/engine#49863 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-18 18:23:13 +00:00
Jesús S Guerrero
1997bec685
Revert "Native assets: roll deps" ( #141748 )
...
b/320767653
Reverts flutter/flutter#141684
2024-01-18 18:13:21 +00:00
Pierre-Louis
ef5beeced3
Deprecate M2 curves ( #134417 )
...
These have 1:1 replacements with a new name, introduced in
https://github.com/flutter/flutter/pull/129942
Land after https://github.com/flutter/packages/pull/4898
Part of https://github.com/flutter/flutter/issues/116525
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-01-18 18:38:00 +01:00
Renzo Olivares
cd06ba7ab6
Fix: TextField can inherit errorStyle from InputDecorationTheme. ( #141227 )
...
Previously `TextField`s error `cursorColor` was being derived without taking into account any `InputDecorationTheme` defaults. This change respects `InputDecorationTheme` defaults when deriving the error `cursorColor`.
Fixes #140607
2024-01-18 17:37:06 +00:00
yaakovschectman
3123d98132
Add check for Bank of Brazil security module to Windows Flutter Doctor validators ( #141135 )
...
Add a warning to Flutter Doctor if Topaz OFD is found as a process on
the system.
The protection module used by the Bank of Brazil has been identified as
causing build failures when using VS with CMake for Windows (see
https://github.com/flutter/flutter/issues/121366#issuecomment-1845703728 ).
Disabling the software allows the build to succeed again.
If a running process is found by `flutter doctor` whose path contains
`Topaz OFD\Warsaw\core.exe`, a warning message is generated to convey
this.
Addresses https://github.com/flutter/flutter/issues/121366
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
---------
Co-authored-by: Elias Yishak <42216813+eliasyishak@users.noreply.github.com>
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
2024-01-18 12:32:49 -05:00
Reid Baker
c479109e75
Fix gradle lints No semantic change should be present. ( #141692 )
...
Move static methods together.
Fix property uses of duplicate strings.
Add types wherever obvious
Fix format depth
Add whitespace to top and bottom of classes
Ignore line length for file
Ignore prefer single quote for file
Ignore correction for getFoo used instead of foo
Loosely related to flutter/flutter/issues/123934
2024-01-18 16:33:10 +00:00
engine-flutter-autoroll
6065c42668
Roll Packages from 1a2b780c9108 to 83c2c4da97c5 (5 revisions) ( #141778 )
...
1a2b780c91...83c2c4da97stuartmorgan@google.com [google_maps_flutter] Restore the arm64 workaround (flutter/packages#5915 )
2024-01-17 10687576+bparrishMines@users.noreply.github.com [pigeon] Separates message call code generation into separate methods in the KotlinGenerator (flutter/packages#5891 )
2024-01-17 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkebview] Verify JavaScriptChannels have a unique name (flutter/packages#5904 )
2024-01-17 10687576+bparrishMines@users.noreply.github.com [pigeon] Separates message call code generation into separate methods in the `DartGenerator` (flutter/packages#5859 )
2024-01-17 engine-flutter-autoroll@skia.org Roll Flutter from 8e94423e6a92 to def6af0b8e6e (23 revisions) (flutter/packages#5911 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-18 15:47:06 +00:00
engine-flutter-autoroll
f77f82435a
Roll Flutter Engine from 49fa2cb9024f to b75d6d80d813 (1 revision) ( #141771 )
...
49fa2cb902...b75d6d80d8skia-flutter-autoroll@skia.org Roll Skia from 1b2909f1eac7 to 7b3d788ba978 (1 revision) (flutter/engine#49861 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-18 12:16:24 +00:00
engine-flutter-autoroll
91aceaa051
Roll Flutter Engine from 49c6ca211aa4 to 49fa2cb9024f (1 revision) ( #141762 )
...
49c6ca211a...49fa2cb902skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from GuU0e5WxJCi92Scz8... to dTy8CK4YxnUsW305O... (flutter/engine#49859 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from GuU0e5WxJCi9 to dTy8CK4YxnUs
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-18 10:18:26 +00:00
engine-flutter-autoroll
a5da3a2217
Roll Flutter Engine from 873449c27d5a to 49c6ca211aa4 (1 revision) ( #141760 )
...
873449c27d...49c6ca211askia-flutter-autoroll@skia.org Roll Skia from ea70dd235e9f to 1b2909f1eac7 (1 revision) (flutter/engine#49858 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-18 09:38:06 +00:00
engine-flutter-autoroll
0ee36adccb
Roll Flutter Engine from bfdc0c5b2826 to 873449c27d5a (1 revision) ( #141759 )
...
bfdc0c5b28...873449c27dleroux_bruno@yahoo.fr [Android] Reset IME state in TextInputPlugin.clearTextInputClient (flutter/engine#49829 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-18 08:51:03 +00:00
Andrew Kolos
0833929c99
Catch UnsupportedError thrown when user provides an asset directory path containing invalid characters ( #141214 )
...
Fixes https://github.com/flutter/flutter/issues/140092
2024-01-18 08:35:59 +00:00
engine-flutter-autoroll
e1e470d459
Roll Flutter Engine from 48f89ac064ac to bfdc0c5b2826 (1 revision) ( #141752 )
...
48f89ac064...bfdc0c5b28skia-flutter-autoroll@skia.org Roll Skia from 31f275e8fcc7 to ea70dd235e9f (2 revisions) (flutter/engine#49856 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-18 08:07:31 +00:00
engine-flutter-autoroll
ebc2016394
Roll Flutter Engine from 924c17245a78 to 48f89ac064ac (2 revisions) ( #141751 )
...
924c17245a...48f89ac064dnfield@google.com Delete trace event from DeviceBufferVK (flutter/engine#49854 )
2024-01-18 jonahwilliams@google.com [Impeller] remove shared_ptr copies during text contents rendering. (flutter/engine#49837 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-18 06:54:25 +00:00
engine-flutter-autoroll
2ff9802cb9
Roll Flutter Engine from 98c16b430e6b to 924c17245a78 (1 revision) ( #141749 )
...
98c16b430e...924c17245ayjbanov@google.com [web] fix ==/hashCode/toString for several classes across renderers (flutter/engine#49786 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-18 06:12:24 +00:00
engine-flutter-autoroll
5dc6925096
Roll Flutter Engine from 73a2de5da53f to 98c16b430e6b (16 revisions) ( #141744 )
...
73a2de5da5...98c16b430eskia-flutter-autoroll@skia.org Roll Skia from 5abf9717ea92 to 31f275e8fcc7 (8 revisions) (flutter/engine#49850 )
2024-01-18 30870216+gaaclarke@users.noreply.github.com Reland: [Impeller] Turned on new blur. (#48472 ) (flutter/engine#49642 )
2024-01-17 737941+loic-sharma@users.noreply.github.com [Windows] Reduce Visual Studio build errors caused by keyboard unit tests (flutter/engine#49814 )
2024-01-17 30870216+gaaclarke@users.noreply.github.com [Impeller] disabled misleading vulkan golden image tests (flutter/engine#49836 )
2024-01-17 737941+loic-sharma@users.noreply.github.com [Windows] Remove unnecessary statics in keyboard (flutter/engine#49834 )
2024-01-17 skia-flutter-autoroll@skia.org Roll Skia from 5c9e3474cf13 to 5abf9717ea92 (1 revision) (flutter/engine#49831 )
2024-01-17 godofredoc@google.com Move mac cache builder to bringup. (flutter/engine#49843 )
2024-01-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Switch from transient stencil-only to depth+stencil buffer." (flutter/engine#49832 )
2024-01-17 skia-flutter-autoroll@skia.org Roll Skia from d8da1ee69767 to 5c9e3474cf13 (2 revisions) (flutter/engine#49827 )
2024-01-17 skia-flutter-autoroll@skia.org Manual roll Dart SDK from d6c08fa9bb54 to 6ff69d6b7f59 (15 revisions) (flutter/engine#49825 )
2024-01-17 skia-flutter-autoroll@skia.org Roll Skia from 02e94b3b4d29 to d8da1ee69767 (1 revision) (flutter/engine#49824 )
2024-01-17 bdero@google.com Flutter GPU: Add GpuContext.createHostBuffer (flutter/engine#49822 )
2024-01-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Klxww53tA4-TG5pA9... to GuU0e5WxJCi92Scz8... (flutter/engine#49823 )
2024-01-17 bdero@google.com [Impeller] Switch from transient stencil-only to depth+stencil buffer. (flutter/engine#47987 )
2024-01-17 skia-flutter-autoroll@skia.org Roll Skia from 31309ff09537 to 02e94b3b4d29 (43 revisions) (flutter/engine#49819 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Klxww53tA4-T to GuU0e5WxJCi9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-18 04:27:17 +00:00
Zachary Anderson
a9d94be0da
Move mac pixel 7 pro test to presubmit: false ( #141747 )
...
The only bot with this configuration in the try pool just died.
2024-01-17 19:54:51 -08:00
Yegor
00032569a1
[web] prepare layers_test.dart for https://github.com/flutter/engine/pull/49786 ( #141731 )
...
This disables the expectation for `TileMode` stringification because
https://github.com/flutter/engine/pull/49786 is about to fix it (as in,
the test would fail when the engine fix lands).
2024-01-17 18:53:33 -08:00
Polina Cherkasova
b90a3e4710
Remove non-needed bot and increase time out for leak_tracking. ( #141712 )
2024-01-17 15:31:38 -08:00
Qun Cheng
ef794e2a28
Add headerHeight for SearchAnchor ( #141223 )
...
Fixes #140046
This PR is to add a `headerHeight` property to `SearchAnchor` and `SearchViewThemeData` so the header height on the search view can be customized.
2024-01-17 22:49:04 +00:00
