9304 Commits

Author SHA1 Message Date
Ian Hickson
2dfeaa668d
Run "pub get" for the frontend_server package before building. (#4562)
In https://github.com/flutter/engine/pull/4554 I removed the .packages
file in the frontend_server directory, because it was out of sync with
the pubspec.yaml. It seems like the right solution is to run `pub get`
when we get the dependencies, i.e. when we run `gclient sync`.

Being out of sync is a problem because it means that running "pub get"
in that directory changes what packages are being used, and changes
the `.packages` file, which leads to having to revert changes before
committing code, etc. Having to regularly update this file doesn't
make much sense either, since the files that were missing were files
that are obtained from the network (e.g. the `io` package as used by
the `test` package).

Previously, (see
https://github.com/flutter/engine/pull/3982#issuecomment-323213199),
we did not do this because we did not want the build to call into the
network. This still does not call into the network during the _build_
phase, only during `gclient sync` (which is when all the dependencies
are brought down).

Currently the network dependencies only matter for running tests. We
should make sure this remains the case. Ideally we wouldn't even
depend on those.
2018-01-17 15:41:46 -08:00
amirh
d5cd548b5d
Update comment on Scenic shapes following feedback from schwa423@ (#4563) 2018-01-17 14:39:40 -08:00
Greg Spencer
4822507560
Roll buildroot to c947b7aa6a57d3c427d63692e530f23b1f77d81e (#4561) 2018-01-17 12:11:36 -08:00
Ian Hickson
f3f005c457
Analysis cleanup of the Dart in the Engine repo (#4554)
* Analysis cleanup of the Dart in the Engine repo

* Update painting.dart

* Update painting.dart
2018-01-17 09:48:56 -08:00
jensjoha
6de9931c36 Train frontend_server snapshot (#4560)
Reland 86430be68a8294fa6ef3002ee5aba27a50ce3ca6 with a fix for Windows build

Cuts 30% from hot-reload benchmarks with `--preview-dart-2`
2018-01-17 10:33:10 +01:00
Michael Goderbauer
7173a158db
Announce when checked status changes on Android (#4557)
Fixes https://github.com/flutter/flutter/issues/14092
2018-01-16 23:10:17 -08:00
amirh
e1e97b9130
Fallback to compose shapes as their bounding rectangles. (#4553)
Scenic doesn't currently support arbitrary shaped frames.
2018-01-16 18:20:18 -08:00
Jason Simmons
a1328e7730
libtxt: use an ICU character iterator that can handle complex grapheme clusters (#4548) 2018-01-16 10:43:00 -08:00
Jason Simmons
a394ee04aa
libtxt: skip redundant bidi processing performed by minikin (#4539)
The libtxt Paragraph class now runs the bidi algorithm itself, and each text
run passed to doLayout will be entirely LTR or RTL
2018-01-16 10:39:31 -08:00
Ian Hickson
6fee2654f1
Make Canvas cullRect optional and make Rect.largest a static field. (#4551)
Fixes https://github.com/flutter/flutter/issues/7201.

The change from `new Rect.largest()` to `Rect.largest` saves a few
allocations since we'll be using these with every Canvas.
2018-01-16 10:08:08 -08:00
Alexander Aprelev
e3be1b3d4e
Revert "Train frontend_server snapshot (#4512)" (#4556)
This reverts commit 86430be68a8294fa6ef3002ee5aba27a50ce3ca6 as it
breaks Windows engine buildbot.
2018-01-16 10:05:00 -08:00
jensjoha
86430be68a Train frontend_server snapshot (#4512)
Cuts 30% from hot-reload benchmarks with `--preview-dart-2`
2018-01-15 15:59:57 +01:00
Sarah Zakarias
73a9ea68b9
Mark deprecated API in FlutterDartProject.h as unavailable (#4552) 2018-01-15 13:29:43 +01:00
Sarah Zakarias
1e23d648cb
Run Fuchsia apps without flx (#4550) 2018-01-15 11:09:01 +01:00
Michael Goderbauer
e7e94c6307
Properly identify CheckBox and RadioButton on Android (#4547) 2018-01-12 15:27:55 -08:00
Brian Osman
e6c117d0fb
When blurring, clamp to image's edge pixels, not to black (#4546) 2018-01-12 16:27:17 -05:00
Michael Goderbauer
5ce89a0f3d
Fixes crash on Android when activating Now on Tap (#4536) 2018-01-12 10:22:55 -08:00
Sarah Zakarias
ce8ea0f742
Revert "Run Fuchsia apps without flx" (#4545)
* Revert "include portable_unistd.h in directory_asset_bundle (#4542)"

This reverts commit 211150fe40fbca68580af2f923b87ddb5ac924c6.

* Revert "Run Fuchsia apps without flx (#4538)"

This reverts commit 8718438d83c2cf3acdd3781df8ae4d00b8de56b1.
2018-01-12 15:55:47 +01:00
Sarah Zakarias
5a67f2d8e0
Revert "include portable_unistd.h in directory_asset_bundle (#4542)" (#4544)
This reverts commit 211150fe40fbca68580af2f923b87ddb5ac924c6.
2018-01-12 15:53:02 +01:00
Sarah Zakarias
211150fe40
include portable_unistd.h in directory_asset_bundle (#4542) 2018-01-12 15:31:56 +01:00
Sarah Zakarias
8718438d83
Run Fuchsia apps without flx (#4538) 2018-01-12 13:31:54 +01:00
Ian Hickson
26c3ab08d9
Convert MaskFilter to pure-Dart. (#4534) 2018-01-11 23:25:18 -08:00
amirh
05fe72d068
Revive always using SkPath for physical models (#4537) 2018-01-11 15:11:00 -08:00
Todd Volkert
f5dc4ec739
Roll Skia to 579f094f1259931c30dfd1623e8e22d74b4a7531 (#4525)
* Roll Skia to 579f094f1259931c30dfd1623e8e22d74b4a7531

Fixes https://github.com/flutter/flutter/issues/13742
2018-01-11 13:15:05 -08:00
Alexander Aprelev
cdf869bcd7
When running on iOS deduce bundle path during engine initialization. (#4532) 2018-01-10 17:40:47 -08:00
Zachary Anderson
6dd2666f90
Roll Dart to 28757928b47b192efcec082c78258102beb03f78 (#4535) 2018-01-10 13:30:12 -08:00
Jason Simmons
e8bfd4d025
libtxt: map pixel coordinates above the text to glyph positions on the first line of text (#4533)
This matches Blink's behavior
2018-01-10 10:32:24 -08:00
Ian Hickson
9536b80781
Offset.direction (#4530)
Since we've got a vector class, and it has a getter for the magnitude,
why not also a getter for the angle.
2018-01-09 22:17:57 -08:00
Mikkel Nygaard Ravn
84fc920fde
Deprecate support for big integers in standard message codec (#4528) 2018-01-09 23:58:45 +01:00
Ben Konyi
5a72197b73
Dart sdk roll for 2018/01/09 (bd6cbd1ec7e79730ea1fd8ba01139f4e18a02290) (#4531)
* Rolled dart-sdk to bd6cbd1ec7e79730ea1fd8ba01139f4e18a02290

* Updated third_party licenses.
2018-01-09 14:28:13 -08:00
Michael Goderbauer
16e365e722
Rename SemanticsFlags to SemanticsFlag (#4526)
To align with `SemanticsAction`.
2018-01-09 09:25:52 -08:00
amirh
b7d99da3e2
Revert "Delete the SkPath/SkRRect code duplication in for physical model layers. (#4519)" (#4527)
This reverts commit d8740c70a58ada74aff5b773e2bec9d622c42a97.
2018-01-08 19:25:56 -08:00
amirh
d8740c70a5
Delete the SkPath/SkRRect code duplication in for physical model layers. (#4519) 2018-01-08 16:13:15 -08:00
Mehmet Fidanboylu
9b98d194f2
Fix build break caused by https://github.com/flutter/engine/pull/4491 (#4524) 2018-01-07 07:51:46 -08:00
Mehmet Fidanboylu
d43ae0b41b
Add unwrap to JSONUtil (#4491)
We have a use for this for the internal messaging plugin. Instead of rolling our own, it made sense to add it here especially since it has the mirror functionality (wrap).
2018-01-06 14:32:00 -08:00
Jason Simmons
e1b01d7d7b
API version check for AccessibilityNodeInfo.setEditable call (#4522)
Fixes https://github.com/flutter/flutter/issues/13896
2018-01-05 14:45:35 -08:00
Ryan Macnak
6a724f0d3e
Roll Dart to 5b56dfb77a76e9d8021086c0684b1e8bd9dbca9a. (#4521) 2018-01-05 14:15:47 -08:00
Jason Simmons
bbefdf1980
Add a Rect.largest constructor equivalent to SkRect::MakeLargest (#4520) 2018-01-05 13:37:23 -08:00
Jason Simmons
4b2c0c4a40
Fetch libjpeg-turbo from the Fuchsia repository (#4518) 2018-01-05 12:08:56 -08:00
Michael Goderbauer
12e0e38a8b
Split SemanticsFlags.isDisabled into two (#4517) 2018-01-04 15:15:54 -08:00
Siva
43327730a2
Roll Dart to version 8d7219a5b6a7c2505ff57f23e7cf80da4c724512 (#4515)
* Roll Dart to version 8d7219a5b6a7c2505ff57f23e7cf80da4c724512

* Update third_party license file.
2018-01-04 14:36:41 -08:00
Brian Osman
c4141ff8f4
Add missing include for sk_malloc_throw (#4516)
SkTypes.h no longer includes SkMalloc.h
2018-01-04 17:11:04 -05:00
Alexander Aprelev
f6ea8f32aa
Fix windows build by using lambda capture workaround (#4514)
* Fix windows build by using lambda capture workaround

* clang format, add todo

* clang-format again
2018-01-04 10:41:54 -08:00
Alexander Aprelev
6bacf4522e
This adds RPC call to set asset path. (#4323)
* This adds rpc call to simply set asset path.

This is needed when doing hot reload to pick up updated assets.

* Move asset_directory fetch for after view_id. Clean up return. Fix formatting.

* Add SetAssetBundlePath methods implementations for mac and ios

* Fix mac mm

* Fix formatting

* Merge and use nullptr
2018-01-04 09:48:01 -08:00
P.Y. Laligand
194fb81209
[fuchsia] Removed the flutter_app template. (#4511)
It is moving to the Fuchsia codebase.
2018-01-04 09:20:41 -08:00
Sigurd Meldgaard
9efcd5371a
Apply texture transform on Android (#4513)
* Apply transform to textures on android
2018-01-04 16:04:30 +01:00
Siva
0f0b144b03
Add support for --strong option in the engine, create a strong mode version of the platform file (#4504)
* Add a --strong option to the front end server so we can use strong mode with preview-dart-2.

* Plumb the --strong option through the dart controller into the VM.

* - Build a strong version of platform.dill for use with the engine.
- Fix a strong mode static error in the assert statement

* Enable asserts when running debug version even in strong mode.

* Use the correct platform dill file for linking when doing the aot builds.

* Fix formatting issue.
2018-01-03 16:52:24 -08:00
Ian Hickson
fb0cfcd33c
Further improve painting.dart documentation. (#4505) 2018-01-03 16:34:09 -08:00
Alexander Aprelev
b6c9ca5552
Revert "Apply transform to textures on android (#4486) (#4507)" (#4510)
This reverts commit 368380cfe1ddcfb8e884b411050bbe6f8d5eb8a5.

This breaks Flutter external_ui test.
2018-01-03 12:37:39 -08:00
Alexander Markov
90e5ca5041
Roll Dart SDK to e9243a4d16cef962214d6d1f433bc2cd3fe864e6 (#4509) 2018-01-03 10:46:50 -08:00