engine-flutter-autoroll
2be86dbee3
Roll Flutter Engine from 3b4779324b44 to 55eefd5bd255 (6 revisions) ( #142245 )
...
3b4779324b...55eefd5bd2skia-flutter-autoroll@skia.org Roll Skia from bcc2e8b6105a to de46a989e0ca (1 revision) (flutter/engine#50046 )
2024-01-25 30870216+gaaclarke@users.noreply.github.com [Impeller] turned on vulkan validation for all but one golden test (flutter/engine#50045 )
2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 56c06ee7a252 to bcc2e8b6105a (2 revisions) (flutter/engine#50042 )
2024-01-25 jonahwilliams@google.com [Impeller] call shutdown method in Android context. (flutter/engine#49992 )
2024-01-25 maRci002@users.noreply.github.com [web] add support for AppLifecycleState changes (flutter/engine#44720 )
2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 416d7b0e5ba1 to 56c06ee7a252 (1 revision) (flutter/engine#50040 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-25 20:06:20 +00:00
LouiseHsu
caba667ed4
Fix incorrect zh-cn translation for Look Up Label in selection controls ( #142158 )
...
Fixes https://github.com/flutter/flutter/issues/141764
Translation suggestion here:
https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=8222331119728136330&language=zh-CN
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
2024-01-25 10:24:42 -08:00
Justin McCandless
204a8848a6
PopScope example improvements ( #142163 )
...
Attempting to help users understand how to build a confirmation dialog when exiting a route.
2024-01-25 10:14:49 -08:00
engine-flutter-autoroll
e985c29f31
Roll Flutter Engine from 1d3f16b0d62e to 3b4779324b44 (1 revision) ( #142225 )
...
1d3f16b0d6...3b4779324bskia-flutter-autoroll@skia.org Roll Skia from 699ee2b7cf34 to 416d7b0e5ba1 (2 revisions) (flutter/engine#50039 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-25 15:59:06 +00:00
engine-flutter-autoroll
ff01022017
Roll Packages from 8fbdf65d0235 to 21b5abba7958 (6 revisions) ( #142224 )
...
8fbdf65d02...21b5abba79pageli328@gmail.com Add rfw widgets (flutter/packages#5661 )
2024-01-24 50643541+Mairramer@users.noreply.github.com [camera] add heif support image iOS (flutter/packages#4586 )
2024-01-24 jsharp83@gmail.com [webview_flutter_android] Add javascript panel interface for android (flutter/packages#5796 )
2024-01-24 43054281+camsim99@users.noreply.github.com [camerax] Wrap Android classes/methods required for implementing setting focus & exposure points and offset (flutter/packages#5659 )
2024-01-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.2.0 to 4.3.0 (flutter/packages#5967 )
2024-01-24 engine-flutter-autoroll@skia.org Roll Flutter from 5b673c28e4ac to 19b06f4ee9a0 (21 revisions) (flutter/packages#5968 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-25 15:45:19 +00:00
Sigurd Meldgaard
a0e43d3053
Don't show legacy welcome message when analytics are disabled ( #140956 )
...
The legacy welcome message would be printed even if `CI=true` confusing
parsers of the output.
This fixes: https://github.com/flutter/flutter/issues/139737
---------
Co-authored-by: eliasyishak <42216813+eliasyishak@users.noreply.github.com>
2024-01-25 16:29:42 +01:00
engine-flutter-autoroll
1e24c41c0f
Roll Flutter Engine from 7c4ed15cb271 to 1d3f16b0d62e (1 revision) ( #142223 )
...
7c4ed15cb2...1d3f16b0d6skia-flutter-autoroll@skia.org Roll Dart SDK from beb003009a4d to 2fb950853f06 (1 revision) (flutter/engine#50037 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-25 15:10:05 +00:00
engine-flutter-autoroll
a8efa771d6
Roll Flutter Engine from e2014f007f61 to 7c4ed15cb271 (1 revision) ( #142221 )
...
e2014f007f...7c4ed15cb268449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Redo - Use chromium test-scripts to download images and execute tests (flutter/engine#49940 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-25 13:22:25 +00:00
engine-flutter-autoroll
bd5db0daaf
Roll Flutter Engine from 5fa2e2920274 to e2014f007f61 (1 revision) ( #142213 )
...
5fa2e29202...e2014f007fskia-flutter-autoroll@skia.org Roll Skia from 21c53af2e9f5 to 699ee2b7cf34 (1 revision) (flutter/engine#50034 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-25 08:56:25 +00:00
Andrew Kolos
295a9a2031
provide command to FakeCommand::onRun ( #142206 )
...
Part of work on [#101077 ](https://github.com/flutter/flutter/pull/141194 ). This is done as a separate PR to avoid a massive diff.
## Context
1. The `FakeCommand` class accepts a list of patterns that's used to match a command given to its `FakeProcessManager`. Since `FakeCommand` can match a list of patterns, not just specifically strings, it can be used to match commands where the exact value of some arguments can't (easily) known ahead of time. For example, a part of the tool may invoke a command with an argument that is the path of a temporarily file that has a randomly-generated basename.
2. The `FakeCommand` class provides on `onRun` parameter, which is a callback that is run when the `FakeProcessManager` runs a command that matches the `FakeCommand` in question.
## Issue
In the event that a `FakeCommand` is constructed using patterns, the test code can't know the exact values used for arguments in the command. This PR proposes changing the type of `onRun` from `VoidCallback?` to `void Function(List<String>)?`. When run, the value `List<String>` parameter will be the full command that the `FakeCommand` matched.
Example:
```dart
FakeCommand(
command: <Pattern>[
artifacts.getArtifactPath(Artifact.engineDartBinary),
'run',
'vector_graphics_compiler',
RegExp(r'--input=/.*\.temp'),
RegExp(r'--output=/.*\.temp'),
],
onRun: (List<String> command) {
final outputPath = (() {
// code to parse `--output` from `command`
})();
testFileSystem.file(outputPath).createSync(recursive: true);
},
)
```
2024-01-25 07:51:25 +00:00
engine-flutter-autoroll
535ce79a99
Roll Flutter Engine from c346fd3d9ca1 to 5fa2e2920274 (1 revision) ( #142212 )
...
c346fd3d9c...5fa2e29202skia-flutter-autoroll@skia.org Roll Dart SDK from 6211fedca10c to beb003009a4d (1 revision) (flutter/engine#50032 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-25 07:41:23 +00:00
engine-flutter-autoroll
20e8f5b910
Roll Flutter Engine from d4d8f668159b to c346fd3d9ca1 (1 revision) ( #142209 )
...
d4d8f66815...c346fd3d9cskia-flutter-autoroll@skia.org Roll Skia from c0544410fc8e to 21c53af2e9f5 (1 revision) (flutter/engine#50031 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-25 06:54:38 +00:00
engine-flutter-autoroll
1c3f386568
Roll Flutter Engine from 499ed00bbda2 to d4d8f668159b (2 revisions) ( #142205 )
...
499ed00bbd...d4d8f66815skia-flutter-autoroll@skia.org Roll Skia from 571873c31056 to c0544410fc8e (1 revision) (flutter/engine#50030 )
2024-01-25 71952488+johnstiles-google@users.noreply.github.com Use top-level GN arg for Skottie instead of CanvasKit-specific arg. (flutter/engine#50019 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-25 06:10:37 +00:00
engine-flutter-autoroll
d2a2d83876
Roll Flutter Engine from 4880592ca5ba to 499ed00bbda2 (6 revisions) ( #142202 )
...
4880592ca5...499ed00bbdskia-flutter-autoroll@skia.org Roll Skia from 3b7accdf8ed8 to 571873c31056 (1 revision) (flutter/engine#50026 )
2024-01-25 jonahwilliams@google.com [Impeller] round up subpass coverage when it is close to (and smaller) than root pass size. (flutter/engine#49925 )
2024-01-25 mzhou620@gmail.com Adding DDC module system targets to web SDK artifacts. (flutter/engine#47783 )
2024-01-25 hasan@hasali.dev [Windows] Set cursor immediately when framework requests update (flutter/engine#49784 )
2024-01-25 737941+loic-sharma@users.noreply.github.com [Windows] Introduce `egl::Surface` and `egl::WindowSurface` (flutter/engine#49983 )
2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 588caf1ceddd to 3b7accdf8ed8 (1 revision) (flutter/engine#50025 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-25 04:10:26 +00:00
David Iglesias
703e12f524
[ci] Adds test for web hot restart with const App. ( #141824 )
...
This PR adds a test that reproduces the problem described in the linked issue: hot restart on the web seems to not update if the app being run is `const`.
The new test is expected to fail, until the `const` issue with hot restart in the web is resolved.
Expected failure mode is a 15s timeout in the following test:
```
02:31 +3 ~1 -1: Hot reload (index.html: Default) (with `const MyApp()`)): newly added code executes during hot restart [E]
TimeoutException after 0:00:15.000000: Future not completed
dart:async _startMicrotaskLoop
...
```
(And then a bunch of output that I'm not 100% sure is intended :))
## Issues
* #141588
2024-01-25 01:49:08 +00:00
godofredoc
3165fa30be
Migrate android_view to linux_android_emu platform. ( #142184 )
...
A new top level platform configuration was created for android emulator tests running on linux vms.
This is also a preparation step to remove adhoc recipes created to run emulator tests.
2024-01-25 01:15:12 +00:00
Matan Lurey
b3da19f879
Refactor external_ui without making any name changes (I think) ( #142192 )
...
Work towards https://github.com/flutter/flutter/issues/142178 .
---
This PR makes no _behavioral_ changes to executed code, and instead
focuses on organization and naming:
1. Extended the README to explain the intent of the test, as well as how
to run it
1. Renamed `main.dart` and `main_test.dart` to `frame_rate_main.dart`
and `frame_rate_test.dart` (we'll add more)
1. Did some refactoring of the test to make it more obvious what is
being asserted (i.e. `widgetBuilds` and friends)
2024-01-24 17:14:16 -08:00
Renzo Olivares
eba38c4b77
Fix text selection edge scrolling when inside a horizontal scrollable ( #140250 )
...
Fixes #129590
* Consider `AxisDirection` when calculating scroll offset used in determining TextSelection during a drag/long press drag. Previously it seems that we were assuming the direction was always vertical 30cc831985/packages/flutter/lib/src/widgets/text_selection.dart (L2842-L2844)
2024-01-25 00:59:06 +00:00
engine-flutter-autoroll
d83eff4459
Roll Flutter Engine from d7bf5ec1dcdd to 4880592ca5ba (2 revisions) ( #142186 )
...
d7bf5ec1dc...4880592ca5skia-flutter-autoroll@skia.org Roll Dart SDK from e0bf6a261895 to 6211fedca10c (1 revision) (flutter/engine#50021 )
2024-01-24 skia-flutter-autoroll@skia.org Roll Skia from 247a61a5496d to 588caf1ceddd (2 revisions) (flutter/engine#50020 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-25 00:42:25 +00:00
engine-flutter-autoroll
d12b36de02
Roll Flutter Engine from 6a7f963dc751 to d7bf5ec1dcdd (2 revisions) ( #142185 )
...
6a7f963dc7...d7bf5ec1dcskia-flutter-autoroll@skia.org Roll Skia from 7d69d275afd8 to 247a61a5496d (1 revision) (flutter/engine#50018 )
2024-01-24 skia-flutter-autoroll@skia.org Roll Skia from 643160445720 to 7d69d275afd8 (3 revisions) (flutter/engine#50016 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-24 23:56:25 +00:00
Polina Cherkasova
47d8252a85
Reland "Remove hack from PageView." ( #142172 )
...
Original PR: https://github.com/flutter/flutter/pull/141533
Failure: https://fusion2.corp.google.com/presubmit/601217743/OCL:601217743:BASE:601219708:1706132224874:9a4bcab3/targets
Fix: [b/321743868](https://b.corp.google.com/321743868 ), http://cl/601219001 (added as g3 fix.
2024-01-24 23:44:11 +00:00
Polina Cherkasova
a522b38e96
Upgrade leak_tracker. ( #142162 )
2024-01-24 15:33:17 -08:00
godofredoc
d51858c2e1
Migrate android views to devicelab. ( #142081 )
...
Migrate android view out of recipes.
2024-01-24 23:11:12 +00:00
engine-flutter-autoroll
30cc831985
Roll Flutter Engine from ed498f111d53 to 6a7f963dc751 (4 revisions) ( #142176 )
...
ed498f111d...6a7f963dc7skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kYC2-fFgjbb36mukB... to Igt2rE-R6rgfmTRaF... (flutter/engine#50015 )
2024-01-24 skia-flutter-autoroll@skia.org Roll Skia from 9ea7cb490804 to 643160445720 (6 revisions) (flutter/engine#50014 )
2024-01-24 robert.ancell@canonical.com Add custom FlValue types and support their en/decoding via FlStandardMessageCodec (flutter/engine#49162 )
2024-01-24 matanlurey@users.noreply.github.com Do not double-increment `nextId` when using `createSurfaceProducer` with `SurfaceTexture`s (flutter/engine#50011 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from kYC2-fFgjbb3 to Igt2rE-R6rgf
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-24 22:41:13 +00:00
Jo Jaeyong
23385468a8
Support wireless debugging for iOS 12 or earlier ( #141439 )
...
`idevicesyslog` requires the `--network` flag to obtain logs for iOS devices when wirelessly paired.
When running Flutter on devices with iOS 12 or earlier versions, [the `idevicesyslog` command is used.](5931b4f21d/packages/flutter_tools/lib/src/ios/devices.dart (L1269-L1277)#15072
Related PRs: #118104 , #118895 , #60623
2024-01-24 22:14:08 +00:00
engine-flutter-autoroll
990e2a562b
Roll Flutter Engine from 4bc368ee5f74 to ed498f111d53 (5 revisions) ( #142167 )
...
4bc368ee5f...ed498f111dflar@google.com [Impeller] allow non-square corner radii for fast blurs (flutter/engine#49994 )
2024-01-24 103135467+sealesj@users.noreply.github.com Fuchsia + ocmock mirror migration (flutter/engine#50003 )
2024-01-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 0f7c49da26da to e0bf6a261895 (1 revision) (flutter/engine#50009 )
2024-01-24 dkwingsmt@users.noreply.github.com [macOS] Fix: Memory sanitizer violated when encoding indirect strings (flutter/engine#49995 )
2024-01-24 30870216+gaaclarke@users.noreply.github.com [Impeller] Share vulkan playground across goldens (flutter/engine#49981 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-24 21:56:33 +00:00
auto-submit[bot]
54e9f2dbe6
Reverts "Refactor external_ui → external_textures" ( #142173 )
...
Reverts flutter/flutter#142062
Initiated by: eliasyishak
This change reverts the following previous change:
Original Description:
This PR makes no _behavioral_ changes to executed code, and instead focuses on organization and naming:
1. Almost[^1] anything named `external_ui` is renamed `external_textures`
1. Extended the README to explain the intent of the test, as well as how to run it
1. Renamed `main.dart` and `main_test.dart` to `frame_rate_main.dart` and `frame_rate_test.dart` (we'll add more)
1. Did some refactoring of the test to make it more obvious what is being asserted (i.e. `widgetBuilds` and friends)
Given how complex (and in-flux) this directory is, I'm also requesting either John, Jonah or I review any changes.
[^1]: Except the name of the `.ci.yaml` task, i.e. `name: Linux_pixel_7pro external_ui_integration_test` because I'm apparently not able to change that without creating a new task as `bringup: true` and playing a bit of a dance. Maybe that's worth doing though (in future PRs)?
2024-01-24 21:41:17 +00:00
Matan Lurey
2e2042ff8e
Refactor external_ui → external_textures ( #142062 )
...
This PR makes no _behavioral_ changes to executed code, and instead
focuses on organization and naming:
1. Almost[^1] anything named `external_ui` is renamed
`external_textures`
1. Extended the README to explain the intent of the test, as well as how
to run it
1. Renamed `main.dart` and `main_test.dart` to `frame_rate_main.dart`
and `frame_rate_test.dart` (we'll add more)
1. Did some refactoring of the test to make it more obvious what is
being asserted (i.e. `widgetBuilds` and friends)
Given how complex (and in-flux) this directory is, I'm also requesting
either John, Jonah or I review any changes.
[^1]: Except the name of the `.ci.yaml` task, i.e. `name:
Linux_pixel_7pro external_ui_integration_test` because I'm apparently
not able to change that without creating a new task as `bringup: true`
and playing a bit of a dance. Maybe that's worth doing though (in future
PRs)?
2024-01-24 12:44:31 -08:00
engine-flutter-autoroll
fb4eef1c9c
Roll Flutter Engine from 0b9fce355df9 to 4bc368ee5f74 (3 revisions) ( #142157 )
...
0b9fce355d...4bc368ee5fjonahwilliams@google.com [Impeller] use const std::unique_ptr ref for Sampler type. (flutter/engine#49974 )
2024-01-24 skia-flutter-autoroll@skia.org Roll Skia from c353c00a4dcb to 9ea7cb490804 (1 revision) (flutter/engine#50005 )
2024-01-24 mbrase@google.com Replace Fuchsia logging macros (FX_LOG*) with FML logging (flutter/engine#49970 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-24 19:55:07 +00:00
hangyu
6adc8246e4
Update navigationBar label's maxScaleFactor to meet GAR requirement ( #141998 )
...
fixes: https://github.com/flutter/flutter/issues/141997
2024-01-24 19:45:47 +00:00
engine-flutter-autoroll
8fb4a64853
Roll Flutter Engine from b65556fa543e to 0b9fce355df9 (1 revision) ( #142147 )
...
b65556fa54...0b9fce355dskia-flutter-autoroll@skia.org Roll Skia from 26ac196b95c4 to c353c00a4dcb (1 revision) (flutter/engine#50004 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-24 18:18:06 +00:00
Flutter GitHub Bot
a0df2c4573
Marks Mac_arm64 build_tests_2_4 to be unflaky ( #142115 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_arm64 build_tests_2_4"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64%20build_tests_2_4%22 ).
This test can be marked as unflaky.
2024-01-24 18:11:53 +00:00
Flutter GitHub Bot
07ece1aad2
Marks Mac_x64 build_tests_2_4 to be unflaky ( #142111 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_x64 build_tests_2_4"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_x64%20build_tests_2_4%22 ).
This test can be marked as unflaky.
2024-01-24 17:56:38 +00:00
Flutter GitHub Bot
fdda3b5ac0
Marks Mac_x64 build_tests_1_4 to be unflaky ( #142110 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_x64 build_tests_1_4"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_x64%20build_tests_1_4%22 ).
This test can be marked as unflaky.
2024-01-24 17:56:35 +00:00
Flutter GitHub Bot
a0e0387a80
Marks Mac_x64 build_tests_3_4 to be unflaky ( #142112 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_x64 build_tests_3_4"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_x64%20build_tests_3_4%22 ).
This test can be marked as unflaky.
2024-01-24 17:55:43 +00:00
Greg Price
e661ed3a00
Revise tooltip theme docs, including more cross-references ( #137316 )
...
Much of the new wording here is borrowed from [ChipTheme], [SliderTheme], or [RadioThemeData], which I think are pretty good. I believe a lot of other theme classes have similar wording too. I've also made some tweaks of my own, notably the references to [MaterialApp.theme].
This started from a desire to have clearer cross-references pointing at what to do with a FooThemeData to make it take effect:
https://github.com/flutter/flutter/pull/135879#discussion_r1355851481
but then as I started writing I kept finding more and more small things I wanted to adjust, including a couple of bits that were extraneous or obsolete.
2024-01-24 17:26:03 +00:00
godofredoc
5d48b5c8b5
Run some tests explicitly in both arm and x64. ( #141910 )
...
This is part of the process to start running tests on either arm64 or x64 if the host architecture is not important for the test.
2024-01-24 17:24:12 +00:00
engine-flutter-autoroll
787a51fa08
Roll Flutter Engine from ba3a70ce7722 to b65556fa543e (3 revisions) ( #142140 )
...
ba3a70ce77...b65556fa54skia-flutter-autoroll@skia.org Roll Dart SDK from 8307fb417cb9 to 0f7c49da26da (1 revision) (flutter/engine#50001 )
2024-01-24 skia-flutter-autoroll@skia.org Roll Skia from 6556502887bf to 26ac196b95c4 (1 revision) (flutter/engine#50000 )
2024-01-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 8115d045c95d to 8307fb417cb9 (1 revision) (flutter/engine#49999 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-24 16:50:52 +00:00
LongCatIsLooong
b6e758addb
Fixes #138773 , port autocomplete to OverlayPortal ( #140285 )
...
Fixes #138773 , port autocomplete to OverlayPortal
2024-01-24 16:49:18 +00:00
Jesús S Guerrero
b5262f0d80
Revert "[web] - Fix broken TextField in semantics mode when it's a sibling of Navigator" ( #142129 )
...
Reverts flutter/flutter#138446
b/322136071
2024-01-24 16:13:26 +00:00
Flutter GitHub Bot
161fd82c7f
Marks Mac_arm64 build_tests_1_4 to be unflaky ( #142114 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_arm64 build_tests_1_4"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64%20build_tests_1_4%22 ).
This test can be marked as unflaky.
2024-01-24 15:50:11 +00:00
engine-flutter-autoroll
229098c2d9
Roll Packages from 841fe901fe2b to 8fbdf65d0235 (2 revisions) ( #142139 )
...
841fe901fe...8fbdf65d02stuartmorgan@google.com [webview_flutter] Use a local web server for legacy web integration tests (flutter/packages#5956 )
2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter from 3ee8ff287a6e to 5b673c28e4ac (28 revisions) (flutter/packages#5965 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-24 15:41:19 +00:00
Flutter GitHub Bot
277366d2cc
Marks Mac_arm64 build_tests_3_4 to be unflaky ( #142116 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_arm64 build_tests_3_4"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64%20build_tests_3_4%22 ).
This test can be marked as unflaky.
2024-01-24 15:39:25 +00:00
Flutter GitHub Bot
db0ce8a498
Marks Mac_x64 build_tests_4_4 to be unflaky ( #142113 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_x64 build_tests_4_4"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_x64%20build_tests_4_4%22 ).
This test can be marked as unflaky.
2024-01-24 15:09:03 +00:00
Flutter GitHub Bot
e7ff0e0e8f
Marks Mac_arm64 build_tests_4_4 to be unflaky ( #142117 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_arm64 build_tests_4_4"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64%20build_tests_4_4%22 ).
This test can be marked as unflaky.
2024-01-24 14:59:41 +00:00
engine-flutter-autoroll
19b06f4ee9
Roll Flutter Engine from 7c592dbfa032 to ba3a70ce7722 (2 revisions) ( #142130 )
...
7c592dbfa0...ba3a70ce77skia-flutter-autoroll@skia.org Roll Dart SDK from 69af2ca8332f to 8115d045c95d (1 revision) (flutter/engine#49998 )
2024-01-24 skia-flutter-autoroll@skia.org Roll Skia from 1af4f1216478 to 6556502887bf (1 revision) (flutter/engine#49997 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-24 12:20:26 +00:00
engine-flutter-autoroll
6de70abacd
Roll Flutter Engine from 700235c85d4a to 7c592dbfa032 (2 revisions) ( #142108 )
...
700235c85d...7c592dbfa0matanlurey@users.noreply.github.com Fix a typo in `geometry.cc#ComputeUVGeometryForRect`. (flutter/engine#49986 )
2024-01-24 skia-flutter-autoroll@skia.org Roll Skia from be4b398b4f2e to 1af4f1216478 (1 revision) (flutter/engine#49993 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-24 09:30:34 +00:00
engine-flutter-autoroll
b61ef0426b
Roll Flutter Engine from da96f9de3f69 to 700235c85d4a (1 revision) ( #142100 )
...
da96f9de3f...700235c85dskia-flutter-autoroll@skia.org Roll Dart SDK from 838cd732e56a to 69af2ca8332f (1 revision) (flutter/engine#49990 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-24 05:33:55 +00:00
engine-flutter-autoroll
094306eadb
Roll Flutter Engine from 220416cfa6ca to da96f9de3f69 (5 revisions) ( #142098 )
...
220416cfa6...da96f9de3fskia-flutter-autoroll@skia.org Roll Skia from c396b2171b16 to be4b398b4f2e (2 revisions) (flutter/engine#49988 )
2024-01-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 5646ac9669f8 to 838cd732e56a (3 revisions) (flutter/engine#49982 )
2024-01-24 jonahwilliams@google.com [ui] hold a strong reference to fragment program objects. (flutter/engine#49868 )
2024-01-23 skia-flutter-autoroll@skia.org Roll Skia from 4e42423c7f6f to c396b2171b16 (1 revision) (flutter/engine#49987 )
2024-01-23 skia-flutter-autoroll@skia.org Roll Skia from e7d10257ffb5 to 4e42423c7f6f (4 revisions) (flutter/engine#49985 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-01-24 04:25:38 +00:00
yim
24e7a0be8b
Don't change the height of the Textfield's labelStyle when it focused. ( #141943 )
...
Fixes #141448
2024-01-24 04:13:50 +00:00
