9216 Commits

Author SHA1 Message Date
Jason Simmons
2b2e21ae0b
libtxt: If no glyphs were rendered, then compute baseline metrics using the paragraph style's font (#4462)
Fixes the "empty text baseline" case in text_painter_rtl_test
2017-12-15 10:07:11 -08:00
Martin Kustermann
d945976b04
Roll dart into engine (#4465) 2017-12-15 13:39:17 +01:00
Jason Simmons
503999ff4d
libtxt: Restore code that had been disabled due to older versions of ICU and HarfBuzz (#4456) 2017-12-14 09:43:59 -08:00
Jason Simmons
1e669f080b
libtxt: fix the paragraph level text direction passed to the ICU bidi API (#4455)
Also includes some cleanup of the BidiRun struct
2017-12-14 09:43:49 -08:00
Vyacheslav Egorov
e0d19e2897 Fix frontend_server error reporting. (#4461)
* Do not use CompilerOptions.onError to report errors.

CompilerMessage does not carry correct SourceSpan
which makes errors unreadable: they all point to
line 1 column XYZ.

* Run dartfmt on frontend_server/lib/server.dart.

* Fix linting issues for frontend_server
2017-12-14 16:26:53 +01:00
Jason Simmons
2383bb7c4e
Update the path to Skia test images in codec_test (#4460) 2017-12-13 18:12:42 -08:00
Jason Simmons
37c132e2ac
Provide the skia_vulkan_header variable now required by Skia's Vulkan build scripts (#4459) 2017-12-13 17:17:05 -08:00
Régis Crelier
d89b9c6dad Dart roll to cf1de7d46cd88e204380e8f96a993439be56b24c (#4457)
Dart roll to cf1de7d46cd88e204380e8f96a993439be56b24c (#4457)
2017-12-13 16:10:55 -08:00
Brian Salomon
2ae4416d36 Roll skia to 58a3fcd4b3a2f7210586f4ec74dde8ac2b231e0f (#4443)
* Roll Skia to 58a3fcd4b3a2f7210586f4ec74dde8ac2b231e0f

* license again
2017-12-13 14:48:26 -05:00
Ben Konyi
a20ad44c1d
Updated message_loop_unittests.cc to use a macro instead of #ifdef (#4441)
OS_WIN blocks when adding platform specific captures.
2017-12-13 10:13:24 -08:00
Sarah Zakarias
f04c5715ce
Add missing include (#4454) 2017-12-13 14:29:14 +01:00
Sarah Zakarias
8cfab93439
Add #define's in dart_init.cc (#4453) 2017-12-13 14:13:02 +01:00
Sarah Zakarias
4cbe26dd37
Handle Flutter assets outside FLX (#4343) 2017-12-13 10:55:24 +01:00
Jason Simmons
28bc7b1248
libtxt: improvements to GetWordBoundary (#4446)
* fix an off-by-one when the offset itself is a word boundary
* lazily create the word break iterator
2017-12-12 17:44:34 -08:00
Zachary Anderson
df18819048
Fix Platform.localeName by setting _Platform._localeClosure (#4450) 2017-12-12 15:01:13 -08:00
Michael Goderbauer
e07eafae1d
Roll forward: Parameters for SemanticActions; a11y text selection (#4452)
Reverts the revert in #4448 with fixes to pass on the bot.

This change will require framework changes in flutter/flutter#13490.
2017-12-12 14:25:45 -08:00
Siva Chandra
2bdb21985c
Roll dart to 962c18b627c76f22166cd0bb8ab9e1b21d3c7305 (#4451)
* Roll dart to 962c18b627c76f22166cd0bb8ab9e1b21d3c7305.

* Update travis/licenses_golden/licenses_third_party
2017-12-12 14:06:28 -08:00
najeira
4ea7075c1d Map iOS touches to Flutter view coordinate system (#4425)
This change ensures that touches are mapped to the Flutter view
co-ordinate system. In the case of a Flutter view that doesn't share the
same origin and orientation as the screen co-ordinate system, touches
were appled in the wrong location. This bug affected Flutter views whose
origin was not the screen origin and Flutter apps running with the
in-call status bar on iPhones other than the iPhone X.
2017-12-12 13:22:53 -08:00
Chris Bracken
6c6b709b2c
Model Android keyboard height as view inset (#4447)
Model top and side system insets as padding and bottom (keyboard) as a
view inset. This avoids applying system insets twice (once as an inset,
once as padding).
2017-12-12 11:04:42 -08:00
Michael Goderbauer
056fd4597f
Revert " Add parameters to SemanticActions; implement extend selection for a11y (#4444)" (#4448)
This reverts commit 59c3a37e6436d60381d9708113228c83ccc6b7f9.
2017-12-12 10:53:15 -08:00
Michael Goderbauer
59c3a37e64
Add parameters to SemanticActions; implement extend selection for a11y (#4444) 2017-12-12 10:06:04 -08:00
Jason Simmons
aaa758d619
Check for a detached FlutterNativeView before sending messages (#4445)
Fixes https://github.com/flutter/flutter/issues/13481
2017-12-11 17:15:21 -08:00
Jason Simmons
9f8cf7eb97
libtxt: track the font metrics of each run in order to calculate heights in GetRectsForRange (#4442)
Previously GetRectsForRange was assigning each rectangle a height matching the
height of the entire line.  If the line includes multiple text styles, callers
will expect each span's rectangle to reflect the height of that span.
(see text_painter_rtl_test.dart)
2017-12-11 14:38:17 -08:00
Vyacheslav Egorov
edaecdc8b8 Update VM entry points list to include some previous omitted entries. (#4440)
This fixes obfuscated snapshot mode.
2017-12-11 11:27:23 -08:00
Zachary Anderson
a8881dfd94
Roll Dart to d8ae797298c3a6cf8dc9f4558707bd2672224d3e (#4439) 2017-12-11 09:33:32 -08:00
Chris Bracken
edb0201fa2
Support iOS scroll-to-top tap on iPhone X (#4436)
This adds support for scrolling the primary scroll view to the top on
status bar touches, on the iPhone X.

Notes:
1. The iPhone X status bar doesn't change height when in in-call/etc.
   mode, and unlike other iPhones, does scroll to top when in in-call mode.
2. No matter which model of iOS device, the top safe area inset doesn't
   change when in in-call mode. In in-call mode, the OS reduces the app
   view height by 20px off the top, and the double-height 'in-call' status
   bar covers this new inset (outside the view) and there continues to be a
   20px safe area in the app.

On iOS 11, rather than comparing status bar height to a hardcoded 20px
'standard height' we now compare to the top safe area inset (which is
always the standard status bar height, regardless of device). On iOS
versions prior to iOS 11, we use the previous logic.

Fixes flutter/flutter#13439
2017-12-08 19:36:53 -08:00
Ben Konyi
845fe3a20d
Rolled forward buildroot to fix Windows build issues. (#4435) 2017-12-08 17:16:25 -08:00
Ben Konyi
a817ee14cb
Fixed failure on Windows in paragraph.cc which was surfaced by enabling (#4434)
Fixed failure on Windows in paragraph.cc which was surfaced by enabling flutter_tester.exe build on bots.
2017-12-08 16:27:47 -08:00
Chinmay Garde
e8526e6fd3
Add macros to mark APIs as being deprecated or unavailable. (#4401) 2017-12-08 13:30:45 -08:00
Jason Simmons
2cf9ed094e
Exclude Skia's copy of libjpeg-turbo from the license crawl (#4432) 2017-12-08 11:50:13 -08:00
Ben Konyi
c3f18b90e0
Fixed errors introduced in landing of fml changes for Windows. (#4431) 2017-12-08 11:17:48 -08:00
Ben Konyi
4d718568b2
Updated fml to build on Windows. (#4415) 2017-12-08 10:40:10 -08:00
Brian Osman
5309ac6c19
Remove SkToBool usage (#4429) 2017-12-08 13:28:06 -05:00
Chris Bracken
8e39760168
Expose keyboard height as view inset on iOS (#4428)
Keyboard height is now treated as a view inset, which could be used to
shrink the content area of the app as is done in the Material Scaffold,
rather than padding, which is used to indicate content areas where user
interaction should be avoided.
2017-12-07 18:37:46 -08:00
Jason Simmons
a2f488ac7f
Do not report a cursor location if there is no active selection (#4427)
Fixes https://github.com/flutter/flutter/issues/13398
2017-12-07 17:43:51 -08:00
Ryan Macnak
1cdaab88e3
Roll Dart to a38ac7cf127f4611c873c2f2d523c06ce06b1342. (#4422) 2017-12-06 16:48:37 -08:00
Michael Goderbauer
9d5cd4b12e
Fix typo (#4424) 2017-12-06 16:14:04 -08:00
Michael Goderbauer
fb44dce8c2
A11y cursor movements for text fields on Android (#4419)
* a11y cursor movement by character

* focus fixes

* doc fixes
2017-12-06 15:46:35 -08:00
Chris Bracken
f888186e50
Fix an extra paren in locale_test.dart (#4423) 2017-12-06 15:38:40 -08:00
Jason Simmons
e79dc185f0
libtxt: implement GetWordBoundary using the ICU word breaker (#4421) 2017-12-06 15:23:40 -08:00
Chris Bracken
a94e88200a
Set window.viewInsets.bottom to keyboard height on iOS (#4420)
This allows for us to start migrating framework classes (notably
Scaffold) to use window.viewInsets.bottom to get the keyboard height.
Once framework updates have landed, we will land an engine patch to
expose the iOS bottom safe area inset as padding.

This change is already landed for Android.

Related issue: flutter/flutter#12098
2017-12-06 15:06:12 -08:00
Jason Simmons
affa4e7c46
libtxt: handle lines containing both LTR and RTL text runs (#4416)
* Call the ICU bidi API to divide the text into LTR/RTL runs and merge
  them with the styled runs defined by the application
* Maintain a list of glyph positions sorted by the order of the corresponding
  code units in the text, as well as a list of glyphs sorted by x/y coordinates
  in the layout
2017-12-06 14:46:03 -08:00
Ian Hickson
7e4df308a7
Make Locale know about the deprecated Hebrew language code. (#4411)
...by making it know about ALL the deprecated language and region codes.
2017-12-06 12:17:30 -08:00
Chris Bracken
033daf152d
Update the iOS mark region on setTextInputState (#4418)
Previously, we failed to clear/update the mark text range on updates
from the framework. This resulted in a crash if the incoming text value
was shorter than the current mark range when iOS attempts to extract the
mark range substring from the text.

Fixes flutter/flutter#12585
2017-12-06 11:30:14 -08:00
Ben Konyi
9b366e1e1a
Dart SDK roll for 2017/12/08. (#4417) 2017-12-05 19:56:47 -05:00
Brian Osman
443c5e4c5b
Disable linear blending on iOS simulator (#4413)
Fixes flutter/flutter#13308

Overlooked this case when I previously removed linear blending. MakeS32 creates a surface with a color space attached (triggering the linear blending behavior). MakeN32 creates a legacy surface (no color space), which matches what the other backend bindings do (including the GL surface factory, and the raster cache).
2017-12-05 08:38:53 -05:00
Alexander Markov
b57fca02b5
Roll Dart SDK to d4cfecb1065d322d3670df7e9ec9a0cc2d4b90f0 (#4414) 2017-12-04 13:46:45 -08:00
Adam Barth
b5d0a4ac51
[fuchsia] Sandbox Flutter runner (#4410) 2017-12-04 12:35:38 -08:00
Alexander Markov
3e84bf01c2
Front-end server: use VM-specific package:vm/kernel_front_end (#4412)
* Use the VM-specific wrapper for the kernel front-end to support VM-specific kernel transformations.
* Also, pass a flag to distinguish AOT mode from JIT mode to enable whole-program optimizations.
2017-12-02 17:37:32 -08:00
xster
22e63c3d05
Block image decoding on iOS in the background (#4384)
* Add synchronization to ResourceContext usage

* debug

* Use unique ptr factory

* formatting

* left more notes for future readers
2017-12-01 12:09:00 -08:00