skia-flutter-autoroll
25e2478f3e
Roll Dart SDK from 7c749713c688 to 7c3588c05f87 (1 revision) ( flutter/engine#46288 )
...
https://dart.googlesource.com/sdk.git/+log/7c749713c688..7c3588c05f87
2023-09-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-199.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-26 04:49:28 +00:00
godofredoc
421f68e13a
Prepare fuchsia script to coexist with v1 and v2 of fuchsia builders. ( flutter/engine#46126 )
...
Prepares fuchsia scripts to work correctly when both v1 and v2 of the fuchsia build are running in their respective environments.
Bug: https://github.com/flutter/flutter/issues/126461
Bug: https://github.com/flutter/flutter/issues/135189
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-09-26 01:27:26 +00:00
skia-flutter-autoroll
302f0f7355
Roll Fuchsia Linux SDK from uY9WEf2tJxa1Hpp4v... to a56c8yPp4DDlj_Qbl... ( flutter/engine#46285 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-26 01:04:04 +00:00
skia-flutter-autoroll
29829be9c6
Roll Dart SDK from 216b25f9ea6f to 7c749713c688 (1 revision) ( flutter/engine#46284 )
...
https://dart.googlesource.com/sdk.git/+log/216b25f9ea6f..7c749713c688
2023-09-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-198.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-26 00:59:58 +00:00
Brandon DeRosier
0a240517a8
[Impeller] Support applying color filters on the CPU for the RRect fast path. ( flutter/engine#46281 )
...
Resolves https://github.com/flutter/flutter/issues/133354 .
Fixes and speeds up blended rrect blurs.
Before:
After:
2023-09-25 23:29:22 +00:00
skia-flutter-autoroll
2086676a11
Roll Skia from 00e4d00021a7 to b961fc353715 (6 revisions) ( flutter/engine#46280 )
...
https://skia.googlesource.com/skia.git/+log/00e4d00021a7..b961fc353715
2023-09-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 26148a023702 to 9fc3baf5a19f (7 revisions)
2023-09-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 655f1fa58633 to d2408a4517eb (4 revisions)
2023-09-25 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 8bf090f5ff0d to 555b91a7b386 (19 revisions)
2023-09-25 kjlubick@google.com Remove unwanted SkAssert from GrDirectContextPriv
2023-09-25 jvanverth@google.com [graphite] Fix SoftwarePathAtlas storage usage.
2023-09-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps and Dawn, add Vulkan-Utility-Libraries
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-25 23:23:10 +00:00
Jonah Williams
0872e4b5f1
[Impeller] Dont blow away coverage hint on advanced blends. ( flutter/engine#46219 )
...
Advnaced blends are given a fairly accurate coverage hint based on the entity size. We were blowing this value away when applying the stencil coverage, resulting in oversized offscreen textures. This should improve the android advanced blend benchmark
2023-09-25 23:08:56 +00:00
keyonghan
11ab13e1a5
Restore goma from rbe before 3.16 branching ( flutter/engine#46272 )
...
This is a revert of targets that generate artifacts for framework:
```
Linux linux_fuchsia
Linux linux_android_aot_engine
Linux linux_android_debug_engine
Linux linux_arm_host_engine
Linux linux_host_desktop_engine
Linux linux_host_engine
```
2023-09-25 22:14:48 +00:00
Ben Konyi
dc41fe832c
Add package:tar to DEPS to fix broken 3H configurations ( flutter/engine#46273 )
...
Filed https://github.com/flutter/flutter/issues/135463 to track adding support for auto-updating this dependency as part of the SDK roll.
2023-09-25 22:07:06 +00:00
skia-flutter-autoroll
8b870284d1
Roll Fuchsia Mac SDK from SNqQGAfjWL3PbUABh... to we5owZaebdO_3kyjz... ( flutter/engine#46270 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-25 20:31:03 +00:00
skia-flutter-autoroll
2a909291f5
Roll Skia from a19a325cd670 to 00e4d00021a7 (6 revisions) ( flutter/engine#46269 )
...
https://skia.googlesource.com/skia.git/+log/a19a325cd670..00e4d00021a7
2023-09-25 johnstiles@google.com Type-check the list of child effects passed to SkMesh.
2023-09-25 armansito@google.com [graphite] Remove unused parameter in AtlasProvider method
2023-09-25 kjlubick@google.com Remove #ifdef SK_GL from GrDirectContext by moving MakeGL factories
2023-09-25 fmalita@chromium.org [svg] Fix nullptr deref in SkSVGAttributeParser
2023-09-25 kjlubick@google.com Reland "Tidy up public.bzl rules for iOS"
2023-09-25 johnstiles@google.com Fix expression position of redundant casts.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-25 20:27:04 +00:00
Jonah Williams
7e31f94005
[Impeller] fallback to position data if texture coordinates are undefined. ( flutter/engine#46264 )
...
Fixes https://github.com/flutter/flutter/issues/135441
This check was lost in some refactor, I added a test for it.
2023-09-25 20:23:03 +00:00
Ian McKellar
a02355a95c
fuchsia: Update FIDL for unknown interactions ( flutter/engine#45773 )
...
This is part of a language change in FIDL. This should have no effect.
See: [https://fxbug.dev/88366 ](https://fxbug.dev/88366 )
2023-09-25 19:15:36 +00:00
Jonah Williams
f5ff960253
[Engine] use QoS classes in iOS engine. ( flutter/engine#46265 )
...
Hint to the CPU scheduler which of our threads are more important. This change should result in more stable rendering times on CI, but likely doesn't have any other observable effects.
2023-09-25 19:06:09 +00:00
Jonah Williams
867fc32087
Revert "Switch goma to reclient for Linux clang_tidy targets ( #45898 )" ( flutter/engine#46266 )
...
Clang tidy is now failing on CI:
https://flutter-dashboard.appspot.com/#/build?repo=engine&branch=master
2023-09-25 11:31:50 -07:00
auto-submit[bot]
ef6b357b23
Reverts "Switch goma to reclient for Linux clang_tidy targets" ( flutter/engine#46267 )
...
Reverts flutter/engine#45898
Initiated by: ricardoamador
This change reverts the following previous change:
Part of https://github.com/flutter/flutter/issues/132701
2023-09-25 18:27:27 +00:00
Kenzie Davisson
e70d4a1c1b
Add description to assert in history.dart ( flutter/engine#46072 )
...
I have hit this assertion error many times in tests and this message
would be helpful for debugging.
---------
Co-authored-by: Mouad Debbar <mdebbar@google.com>
2023-09-25 10:57:44 -07:00
keyonghan
a915a49646
Switch goma to reclient for Linux clang_tidy targets ( flutter/engine#45898 )
...
Part of https://github.com/flutter/flutter/issues/132701
2023-09-25 17:51:00 +00:00
skia-flutter-autoroll
28e92fdc84
Roll Skia from e16a9b5b2c48 to a19a325cd670 (6 revisions) ( flutter/engine#46261 )
...
https://skia.googlesource.com/skia.git/+log/e16a9b5b2c48..a19a325cd670
2023-09-25 jvanverth@google.com [Metal] Update some deprecated interfaces.
2023-09-25 johnstiles@google.com Add 'children' parameters to SkMesh::Make.
2023-09-25 kjlubick@google.com Reland "Make SKP deserialize null instead of PNG images by default."
2023-09-25 brianosman@google.com Update include/OWNERS
2023-09-25 johnstiles@google.com Allow child effects in SkMeshSpecification.
2023-09-25 kjlubick@google.com Fix Bazel rules
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-25 17:08:04 +00:00
skia-flutter-autoroll
dbb2019ec4
Roll Dart SDK from 692273b46610 to 216b25f9ea6f (6 revisions) ( flutter/engine#46260 )
...
https://dart.googlesource.com/sdk.git/+log/692273b46610..216b25f9ea6f
2023-09-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-197.0.dev
2023-09-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-196.0.dev
2023-09-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-195.0.dev
2023-09-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-194.0.dev
2023-09-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-193.0.dev
2023-09-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-192.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-25 16:40:30 +00:00
keyonghan
fac8af4890
Switch goma to reclient for Linux fuchsia/unopt/android_aot ( flutter/engine#45899 )
...
Part of https://github.com/flutter/flutter/issues/132701
2023-09-25 15:56:48 +00:00
keyonghan
b02469658c
Switch goma to reclient for Linux host engine targets ( flutter/engine#45884 )
...
Part of https://github.com/flutter/flutter/issues/132701
2023-09-25 15:56:46 +00:00
skia-flutter-autoroll
5383bad25d
Roll Skia from 7a49397a02b4 to e16a9b5b2c48 (1 revision) ( flutter/engine#46258 )
...
https://skia.googlesource.com/skia.git/+log/7a49397a02b4..e16a9b5b2c48
2023-09-25 johnstiles@google.com Expand the list of no-longer-existing error tests.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-25 15:32:22 +00:00
skia-flutter-autoroll
954f65d109
Roll Skia from 569a30fbdbdf to 7a49397a02b4 (2 revisions) ( flutter/engine#46257 )
...
https://skia.googlesource.com/skia.git/+log/569a30fbdbdf..7a49397a02b4
2023-09-25 jlavrova@google.com Set of utilities for Unicode comparison
2023-09-25 lehoangquyen@chromium.org GraphiteDawn: Use std::memory_or_acquire for last load in DawnAsyncWait
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-25 14:51:32 +00:00
skia-flutter-autoroll
db6fd1e4a0
Roll Skia from 31ceb1669d1c to 569a30fbdbdf (1 revision) ( flutter/engine#46256 )
...
https://skia.googlesource.com/skia.git/+log/31ceb1669d1c..569a30fbdbdf
2023-09-25 kjlubick@google.com [Fontations] Test path equivalence for a set of test fonts and strings
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-25 14:05:20 +00:00
dependabot[bot]
d3648e637a
Bump archive from 3.3.9 to 3.4.2 in /lib/web_ui ( flutter/engine#46253 )
...
Bumps [archive](https://github.com/brendan-duncan/archive ) from 3.3.9 to 3.4.2.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/brendan-duncan/archive/blob/main/CHANGELOG.md ">archive's changelog</a>.</em></p>
<blockquote>
<h2>3.4.2 - September 23, 2023</h2>
<ul>
<li>Add bzip2 decompression for zip files.</li>
</ul>
<h2>3.4.1 - September 23, 2023</h2>
<ul>
<li>Fix for decoding zip64 zip files that have multiple extra fields.</li>
</ul>
<h2>3.4.0 - September 21, 2023</h2>
<ul>
<li>Add Zip64 support to ZipEncoder to allow it to create zip files > 4GB.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="3fe2f348b07ebfdfe3452a6c51b6a53bd14c0a22e2ae50513d9171becaa66fdd35c7dfhttps://github.com/brendan-duncan/archive/compare/3.3.9...3.4.2 ">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2023-09-25 09:02:05 +00:00
skia-flutter-autoroll
34ef3fad51
Roll Fuchsia Linux SDK from VKAiabs4VzJ1Py-oA... to uY9WEf2tJxa1Hpp4v... ( flutter/engine#46252 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-25 08:58:06 +00:00
skia-flutter-autoroll
a22b49089d
Roll Skia from b8bc0c080aa8 to 31ceb1669d1c (1 revision) ( flutter/engine#46249 )
...
https://skia.googlesource.com/skia.git/+log/b8bc0c080aa8..31ceb1669d1c
2023-09-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 2888f630bd2e to 262aec389235
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-25 06:33:54 +00:00
skia-flutter-autoroll
e79de2658f
Roll Skia from 983f42f4c76b to b8bc0c080aa8 (1 revision) ( flutter/engine#46247 )
...
https://skia.googlesource.com/skia.git/+log/983f42f4c76b..b8bc0c080aa8
2023-09-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 8ddc74eefa73 to 2888f630bd2e (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,bungeman@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-25 05:34:22 +00:00
skia-flutter-autoroll
d8ffaed607
Roll Fuchsia Mac SDK from 0Jl20zAW45rRsTNEu... to SNqQGAfjWL3PbUABh... ( flutter/engine#46246 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-25 05:00:25 +00:00
Zachary Anderson
594738f2d5
In run_tests.py, separate Dart package unit tests from other tests ( flutter/engine#46232 )
...
This PR creates a new test type for `run_tests.py` called `dart-host`.
The tests remaining under the `dart` type are tests that run in
`flutter_tester`. The `dart-host` tests run in the Dart CLI. This allows
`run_tests.py` to be simplified a bit, and while doing this I spotted a
couple of mistakes that were causing some tests not to run.
This PR also makes a couple of small style fixes to the build config
json files, converting tabs to spaces, and moving some "script" fields
before the "parameters" fields.
2023-09-24 18:22:27 -07:00
skia-flutter-autoroll
6dbf929c16
Roll Fuchsia Linux SDK from SqWjDvrDsMfiisUoA... to VKAiabs4VzJ1Py-oA... ( flutter/engine#46241 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-24 19:15:39 +00:00
skia-flutter-autoroll
488a4c6f78
Roll Fuchsia Mac SDK from W1uZC0_FbXyoCmwJ1... to 0Jl20zAW45rRsTNEu... ( flutter/engine#46240 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-24 15:10:37 +00:00
skia-flutter-autoroll
09bddccdbe
Roll Fuchsia Linux SDK from M-fNM9YP2Lpc8Y_Dj... to SqWjDvrDsMfiisUoA... ( flutter/engine#46239 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-24 06:36:25 +00:00
skia-flutter-autoroll
b08855fcdd
Roll Fuchsia Mac SDK from de4D1aoqF6LBk18Rd... to W1uZC0_FbXyoCmwJ1... ( flutter/engine#46238 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-24 02:31:28 +00:00
skia-flutter-autoroll
41be46797a
Roll Fuchsia Linux SDK from PCEkaltiQ-iEKlmEj... to M-fNM9YP2Lpc8Y_Dj... ( flutter/engine#46231 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-23 17:47:24 +00:00
skia-flutter-autoroll
aed44465d5
Roll Fuchsia Mac SDK from M9rDyhmn7VY4iTxzQ... to de4D1aoqF6LBk18Rd... ( flutter/engine#46229 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-23 13:55:22 +00:00
Chris Yang
c889e14d4c
[ios] Fix default assets url ( flutter/engine#46214 )
...
When reverting the default asset url code, the old "flutter_assets" path was also copied in https://github.com/flutter/engine/pull/46073
This PR uses the correct URL. Although I'm unsure why the video player test passed before my change for the asset urls.
I'm going to take another look at it but meanwhile this PR can unblock the roll once rolled into the framework.
fixes of https://github.com/flutter/flutter/issues/135323
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-09-23 11:43:21 +00:00
skia-flutter-autoroll
7f439ef302
Roll Skia from 15ccdeaba011 to 983f42f4c76b (1 revision) ( flutter/engine#46223 )
...
https://skia.googlesource.com/skia.git/+log/15ccdeaba011..983f42f4c76b
2023-09-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 8ddc74eefa73 to 352858b2283e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-23 03:02:53 +00:00
Casey Hillers
27e8b0633d
Revert "[Impeller] fail if software backend is chosen and Impeller is enabled on iOS" ( flutter/engine#46217 )
...
Reverts flutter/engine#46124
See b/301660190. This is breaking a few Google iOS tests due to test bed configurations. We'll need more time to investigate fixing those tests before relanding.
2023-09-23 02:15:50 +00:00
skia-flutter-autoroll
ed919c7f54
Roll Fuchsia Linux SDK from QcxgV9KlY7j3o3b4j... to PCEkaltiQ-iEKlmEj... ( flutter/engine#46221 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-23 02:15:48 +00:00
Jonah Williams
f570ec1222
[Impeller] dont treat non-rects as rects. ( flutter/engine#46218 )
...
We were going down this branch for all closed paths, but we should only be taking it for closed paths that are also rectangles.
2023-09-22 23:04:08 +00:00
skia-flutter-autoroll
00d6b50d43
Roll Skia from e9358f92110c to 15ccdeaba011 (1 revision) ( flutter/engine#46216 )
...
https://skia.googlesource.com/skia.git/+log/e9358f92110c..15ccdeaba011
2023-09-22 kjlubick@google.com Reland "Revert "Make SKP deserialize null instead of PNG images by default.""
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-22 22:45:28 +00:00
skia-flutter-autoroll
56cae32b05
Roll Fuchsia Mac SDK from ZyajVWocCHVIuJkzM... to M9rDyhmn7VY4iTxzQ... ( flutter/engine#46215 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-22 22:02:17 +00:00
skia-flutter-autoroll
2c3ea5633c
Roll Dart SDK from 4ddff752a6b0 to 692273b46610 (1 revision) ( flutter/engine#46212 )
...
https://dart.googlesource.com/sdk.git/+log/4ddff752a6b0..692273b46610
2023-09-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-191.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-22 21:32:31 +00:00
skia-flutter-autoroll
aa0a1c3dd8
Roll Skia from 78fced84372d to e9358f92110c (4 revisions) ( flutter/engine#46211 )
...
https://skia.googlesource.com/skia.git/+log/78fced84372d..e9358f92110c
2023-09-22 brianosman@google.com [graphite] Fix lifetime of texture infos when updating descriptor set
2023-09-22 brianosman@google.com [graphite] Make Dawn viewer's swap chain copy/texture-able
2023-09-22 kjlubick@google.com Fix G3
2023-09-22 johnstiles@google.com Allow child effects in SkSL mesh-fragment programs during compile.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-22 21:27:41 +00:00
Brandon DeRosier
57f9d82f0d
[Impeller] Incorporate backdrop filters in subpass coverage. ( flutter/engine#46130 )
...
Resolves https://github.com/flutter/flutter/issues/134775 .
Before:
After:
2023-09-22 20:56:03 +00:00
skia-flutter-autoroll
05cab9ad58
Roll Skia from 8a1e6e5844d7 to 78fced84372d (4 revisions) ( flutter/engine#46207 )
...
https://skia.googlesource.com/skia.git/+log/8a1e6e5844d7..78fced84372d
2023-09-22 kjlubick@google.com Reland "Enforce IWYU on more src/core files"
2023-09-22 michaelludwig@google.com [skif] Add SkBlender handling to FilterResult::draw
2023-09-22 kjlubick@google.com Extract SkImageGenerator::MakeFromEncoded into own file
2023-09-22 johnstiles@google.com Create error tests to verify existing mesh-program behavior.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-22 19:36:20 +00:00
skia-flutter-autoroll
c17bc7b25d
Roll Skia from fe73688dc40f to 8a1e6e5844d7 (1 revision) ( flutter/engine#46205 )
...
https://skia.googlesource.com/skia.git/+log/fe73688dc40f..8a1e6e5844d7
2023-09-22 armansito@google.com [graphite] Support atlas textures without storage usage
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-09-22 18:17:56 +00:00
Jonah Williams
7cd7603dfa
[Impeller] Reland: construct text frames on UI thread. ( flutter/engine#46115 )
...
Due to https://github.com/flutter/flutter/issues/127500 , we can get in a state where enable-impeller is true but we're using Skia. We need to either fall back completely to Skia, make this configuration fatal, or remote the check
----------------
Conversion of SkTextBlobs to impeller::TextFrame objects is one of the most expensive operations in display list dispatching. While the rest of the engine and framework makes a reasonable attempt to cache the SkTextBlobs generated during paragraph construction, the design of the dl dispatcher means that these the Impeller backend will always reconstruct all text frames on each frame - even if the display list/picture that contained those text frames was unchanged.
Removing this overhead is one of the goals of https://github.com/flutter/engine/pull/45386 , however this patch is also fairly risky and will be difficult to land. As a more incremental solution, we can instead construct the impeller::TextFrame objects when performing paragraph painting and record them in the display list. This both moves the text frame construction to the UI thread and allows the framework/engine to cache unchanged text frames.
This also does not conflict with the dl_aiks_canvas patch directly, and is fine to land before or after it does. (though I'd argue we should land this first).
To compare the current performance levels, I ran the complex_layout_scroll perf test, since this is fairly text filled. On a Pixel 6 pro. Across several runs this is a fairly consistent ~1ms raster time improvement.
Fixes https://github.com/flutter/flutter/issues/133204
2023-09-22 17:46:32 +00:00
