42816 Commits

Author SHA1 Message Date
Bruno Leroux
2430f00a01
fix DropdownMenu keyboard navigation is broken when expandedInsets is set (#156803)
## Description

This PR fixes keyboard navigation when `DropdownMenu.expandedInsets` is used.
Before this PR the Shortcuts widget defining the navigation intents was only added when `DropdownMenu.expandedInsets` was null.
After this PR, the Shortcuts widget is always added.

## Related Issue

Fixes [DropdownMenu keyboard navigation is broken when expandedInsets is set](https://github.com/flutter/flutter/issues/156712).

## Tests

Adds 2 tests.
Replaces several unneeded 'pumpAndSettle'.
2024-10-16 07:30:34 +00:00
engine-flutter-autoroll
13718df71d
Roll Flutter Engine from 5b468b77203a to 6b93cf9fbcc9 (1 revision) (#156932)
5b468b7720...6b93cf9fbc

2024-10-16 skia-flutter-autoroll@skia.org Roll Skia from 539ab9d39812 to 8073f7b8bc89 (2 revisions) (flutter/engine#55895)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-16 05:17:25 +00:00
engine-flutter-autoroll
2a80905b36
Roll Flutter Engine from 04d9894c0a42 to 5b468b77203a (6 revisions) (#156931)
04d9894c0a...5b468b7720

2024-10-16 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 2bf0f2b8d391 to 7fce3544047c (4 revisions) (flutter/engine#55896)
2024-10-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from T2Cq00sVabK2fCW9r... to OTfEfbaoT9c0HcprI... (flutter/engine#55894)
2024-10-16 robert.ancell@canonical.com Remove obsolete fl_keyboard_view_delegate_get_messenger (flutter/engine#54857)
2024-10-16 a-siva@users.noreply.github.com Manual roll Dart SDK from d916a5f69a48 to 2bf0f2b8d391 (24 revisions) (flutter/engine#55884)
2024-10-16 chinmaygarde@google.com [Impeller] libImpeller: Initialize the base paragraph style lazily. (flutter/engine#55891)
2024-10-16 robert.ancell@canonical.com Split FlKeyboardManager out of FlKeyboardHandler (flutter/engine#55892)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from T2Cq00sVabK2 to OTfEfbaoT9c0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-16 04:21:40 +00:00
engine-flutter-autoroll
210094285b
Roll Flutter Engine from 7509de89d90c to 04d9894c0a42 (2 revisions) (#156927)
7509de89d9...04d9894c0a

2024-10-16 41930132+hellohuanlin@users.noreply.github.com Revert "[ios][platform_view] Fix Platform view gesture recognizer wit… (flutter/engine#55889)
2024-10-15 robert.ancell@canonical.com Simplify code for dispatching events (flutter/engine#55871)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-16 01:32:11 +00:00
Loïc Sharma
4d48c60b57
Pin google_mobile_ads to 5.1.0 (#156911)
`google_mobile_ads` 5.2.0 is known to break the builds of Flutter apps: https://github.com/googleads/googleads-mobile-flutter/issues/1193

This pins google_mobile_ads to 5.1.0 to unblock the pub autoroller.

See: https://github.com/flutter/flutter/issues/156606
2024-10-15 22:36:09 +00:00
Siva
4715296249
Fix JS compilation to use the command 'compile js' instead of using snapshot names to invoke dart2js (#156735)
Fix JS compilation to use the command 'compile js' instead of using
snapshot names to invoke dart2js

The Dart SDK is switching all tools to use AOT snapshots instead of JIT
snapshots and using snapshot names directly causes things to break.
2024-10-15 15:28:27 -07:00
Jason Simmons
4f2211b550
Determine the scroll gesture axis based on the effectiveScrollController (#156190)
Fixes https://github.com/flutter/flutter/issues/154520
2024-10-15 20:58:51 +00:00
Kate Lovett
7b0b03bc0d
Adjust timeout for devicelab tests (#156553)
Fixes https://github.com/flutter/flutter/issues/156456

There is a known long running test that has been bumping up against the default timeout. This adjusts the perTestTimeout for the devicelab tests to add 15 seconds to stop this from flaking.

The test is question: 82ebb74c64/dev/devicelab/test/run_test.dart (L76)

`test/run_test.dart: run.dart script prints a message after a few seconds when failing to connect (this test takes >10s)`
2024-10-15 20:47:03 +00:00
engine-flutter-autoroll
9fe609ecf4
Roll Flutter Engine from 107ea8baa4f5 to 7509de89d90c (3 revisions) (#156908)
107ea8baa4...7509de89d9

2024-10-15 chinmaygarde@google.com [Impeller] Ignore opt-outs on iOS devices. (flutter/engine#55808)
2024-10-15 skia-flutter-autoroll@skia.org Roll Skia from baf314b72924 to 539ab9d39812 (3 revisions) (flutter/engine#55879)
2024-10-15 jonahwilliams@google.com [Impeller] remove extra copy from drawPoints. (flutter/engine#55872)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-15 20:43:20 +00:00
Jonah Williams
4505e00bf2
[devicelab] try waiting for first frame. (#156907)
From testing locally, sometimes the first frame rasterization takes longer. Could be related to https://github.com/flutter/flutter/issues/156903
2024-10-15 20:37:09 +00:00
Kate Lovett
19488bd6bd
Update triage doc (#155716) 2024-10-15 15:34:10 -05:00
Rexios
e96aaab5e0
Add padding options to SearchAnchor (#152508)
Cherry-picked padding changes from https://github.com/flutter/flutter/pull/148856

Adds padding configuration options to `SearchAnchor`. This PR adds the following:
- `viewBarPadding`: The padding for items inside the `SearchBar` in the `SearchAnchor` view
- `viewPadding`: The padding to use around the entire `SearchAnchor` view

Working towards https://github.com/flutter/flutter/issues/148852
2024-10-15 20:24:48 +00:00
Andrew Kolos
2dad95b21c
Fix flavor-conditional asset bundling for path dependencies (#156687)
Fixes https://github.com/flutter/flutter/issues/155755

When building the asset bundle during, the `--flavor` option isn't considered when searching for assets from dependencies. This PR fixes that.

It's possible that when initially implementing this feature, I thought that flavor-conditional assets didn't make sense for packages. While I still think that way regarding pub packages, using this feature makes a lot more sense for monorepo projects.

<details>

<summary> Pre-launch checklist </summary> 

</details>
2024-10-15 17:39:01 +00:00
Victor Sanni
915985ad52
Implement CupertinoSearchTextField opacity fade on scroll (#155025)
## Before:

https://github.com/user-attachments/assets/38cabba1-d002-4a5d-b80b-fd0955b2aad5

## After:

https://github.com/user-attachments/assets/3e73f863-c353-43f3-90b8-fd322b42b5d3

## Native iOS:

https://github.com/user-attachments/assets/daab345e-09ae-44dc-a1a0-461757c13542

Fixes https://github.com/flutter/flutter/issues/154648

Needed for https://github.com/flutter/flutter/issues/18103
2024-10-15 17:03:25 +00:00
Ben Konyi
ad370c8fa7
[ Tool ] Support Powershell v6+ to determine Windows version in flutter doctor (#156476)
Powershell v6+ use the executable name `pwsh.exe` instead of
`powershell.exe`. This change adds support for determining the Windows
version on systems that solely use `pwsh.exe` and don't have
`powershell.exe` on the `PATH`.

Fixes #156189.

---------

Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com>
2024-10-15 11:48:35 -04:00
engine-flutter-autoroll
2b1e71b4a4
Roll Packages from 1e670f27a620 to bf751e6dff18 (1 revision) (#156824)
1e670f27a6...bf751e6dff

2024-10-14 parlough@gmail.com Disable non-functional, deprecated `package_api_docs` lint (flutter/packages#7858)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-15 15:41:28 +00:00
Valentin Vignal
6829c6a9b9
Add tests for material_state_outlined_border.0.dart (#156814)
Contributes to https://github.com/flutter/flutter/issues/130459

It adds a test for
- `examples/api/test/material/material_state/material_state_outlined_border.0_test.dart`
2024-10-15 14:36:36 +00:00
engine-flutter-autoroll
2b36701456
Roll Flutter Engine from 346565480b36 to 107ea8baa4f5 (1 revision) (#156812)
346565480b...107ea8baa4

2024-10-15 skia-flutter-autoroll@skia.org Roll Skia from 39bd1d3f242a to baf314b72924 (4 revisions) (flutter/engine#55876)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-15 12:42:42 +00:00
Taha Tesser
8ea38a7921
Fix AppBar back button doesn't navigate back when using TooltipTriggerMode.tap in the TooltipTheme (#155822)
Fixes [AppBar BackButton Tooltip interferes with clicking button when TooltipThemeData set to TooltipTriggerMode.tap](https://github.com/flutter/flutter/issues/152315)

### Description
`TooltipTheme` with `triggerMode: TooltipTriggerMode.tap` prevents user from navigating back when tapping on the back button. `triggerMode: TooltipTriggerMode.tap` shouldn't interrupted the back button navigation back callback.

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
        tooltipTheme:
            const TooltipThemeData(triggerMode: TooltipTriggerMode.tap),
      ),
      home: Scaffold(
        appBar: AppBar(
          title: const Text('Sample'),
        ),
        body: Builder(builder: (context) {
          return Center(
            child: ElevatedButton(
              onPressed: () {
                Navigator.push(
                  context,
                  MaterialPageRoute(
                    builder: (context) => const SecondScreen(),
                  ),
                );
              },
              child: const Text('Go to Second Screen'),
            ),
          );
        }),
      ),
    );
  }
}

class SecondScreen extends StatelessWidget {
  const SecondScreen({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Second Screen'),
      ),
      body: const Center(
        child: Tooltip(
          message: 'This is the second screen',
          child: Text('Tap to show tooltip'),
        ),
      ),
    );
  }
}
```

</details>

### Before

https://github.com/user-attachments/assets/ed2020f0-aef8-40f9-be05-55ff80e42e5d

### After

https://github.com/user-attachments/assets/8d65f9f8-d15d-453f-955f-e5d92f8a04e8
2024-10-15 12:30:28 +00:00
Valentin Vignal
5d06db6aad
Add test for material_state_property.0.dart (#156719)
Contributes to https://github.com/flutter/flutter/issues/130459

It adds a test for
- `examples/api/test/material/material_state/material_state_property.0_test.dart`
2024-10-15 12:10:21 +00:00
engine-flutter-autoroll
aaccfe6170
Roll Flutter Engine from 0e143d71dbfe to 346565480b36 (1 revision) (#156804)
0e143d71db...346565480b

2024-10-15 skia-flutter-autoroll@skia.org Roll Skia from 7d16e5cd642c to 39bd1d3f242a (1 revision) (flutter/engine#55870)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-15 07:36:42 +00:00
engine-flutter-autoroll
945386d7d7
Roll Flutter Engine from d4b85da14b8e to 0e143d71dbfe (1 revision) (#156794)
d4b85da14b...0e143d71db

2024-10-15 bdero@google.com [Impeller] Allow binding multiple vertex buffer views. (flutter/engine#55856)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-15 04:04:39 +00:00
engine-flutter-autoroll
986dfdff86
Roll Flutter Engine from 1d70e7d8fb84 to d4b85da14b8e (2 revisions) (#156789)
1d70e7d8fb...d4b85da14b

2024-10-15 bdero@google.com [Flutter GPU] Remove unused fixture. (flutter/engine#55869)
2024-10-14 skia-flutter-autoroll@skia.org Roll Skia from de6e47f0f17b to 7d16e5cd642c (2 revisions) (flutter/engine#55868)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-15 01:41:37 +00:00
Andrew Kolos
dacfa2d452
increase sharding of Windows build_tests (#156763)
Fixes https://github.com/flutter/flutter/issues/156762

<details>

<summary> Pre-launch checklist </summary> 

</details>
2024-10-14 22:52:24 +00:00
engine-flutter-autoroll
86ff6163d9
Roll Flutter Engine from cb51292d802e to 1d70e7d8fb84 (3 revisions) (#156759)
cb51292d80...1d70e7d8fb

2024-10-14 skia-flutter-autoroll@skia.org Roll Skia from d6d3c4f624a3 to de6e47f0f17b (9 revisions) (flutter/engine#55867)
2024-10-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 2cTD8TkGBMX2IssGl... to T2Cq00sVabK2fCW9r... (flutter/engine#55865)
2024-10-14 parlough@gmail.com Disable non-functional and deprecated `package_api_docs` lint (flutter/engine#55833)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 2cTD8TkGBMX2 to T2Cq00sVabK2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-14 22:26:31 +00:00
Hannah Jin
75d93e1c44
Update dropdown menu semantics to fix its a11y issues (#156709)
fixes https://github.com/flutter/flutter/issues/133742 

because the _initialMenu is invisible, we should not add semantics nodes
to it

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-10-14 13:36:24 -07:00
Bruno Leroux
a60933551d
Refactor some DropdownMenu tests (#156702)
## Description

This PR adds a utility method, named `isItemHighlighted`, to simplify several `DropdownMenu` tests.
It will help for some inworking changes.
2024-10-14 20:17:09 +00:00
engine-flutter-autoroll
f2ae627085
Roll Flutter Engine from 767be0a92313 to cb51292d802e (2 revisions) (#156745)
767be0a923...cb51292d80

2024-10-14 ditman@gmail.com [web] Ensure Flutter adds a generator meta-tag. (flutter/engine#55714)
2024-10-14 jonahwilliams@google.com [Impeller] remove STB backend. (flutter/engine#55842)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-14 20:11:09 +00:00
engine-flutter-autoroll
56c20f7a1c
Roll Flutter Engine from 01e247a9ab39 to 767be0a92313 (1 revision) (#156737)
01e247a9ab...767be0a923

2024-10-14 bdero@google.com [Impeller] Add miplevel to Buffer->Texture blit. (flutter/engine#55848)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-14 19:01:08 +00:00
engine-flutter-autoroll
3f73337568
Roll Packages from 67401e169e5c to 1e670f27a620 (7 revisions) (#156734)
67401e169e...1e670f27a6

2024-10-14 stuartmorgan@google.com [image_picker] Update for non-nullable generics in Pigeon (flutter/packages#7775)
2024-10-14 109111084+yaakovschectman@users.noreply.github.com [camera_android] Convert calls from native to dart side to Pigeon. (flutter/packages#7857)
2024-10-14 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Update JSON code to Pigeon for `BitmapDescriptor`, `Cap`, and `PatternItem` (flutter/packages#7840)
2024-10-13 andrechalella@gmail.com [flutter_markdown] Soft wrapping in blockquotes (flutter/packages#7848)
2024-10-12 stuartmorgan@google.com [google_maps_flutter] Update iOS Pigeon for non-nullable generics (flutter/packages#7792)
2024-10-11 10687576+bparrishMines@users.noreply.github.com [pigeon] Swift implementation for ProxyApis (flutter/packages#6602)
2024-10-11 echo.ellet@gmail.com [camera_android_camerax] Remove duplicated 'report' in README.md (flutter/packages#7708)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-14 18:57:21 +00:00
stuartmorgan
14272d54dc
Update iOS/macOS plugin test information (#156716)
Updates the paths for test files to reflect the `darwin/` structure, and updates the instructions for enabling tests to use the SPM version of OCMock if necessary (as well as flagging that new use of OCMock is discouraged).
2024-10-14 17:31:18 +00:00
engine-flutter-autoroll
64d96eaa49
Roll Flutter Engine from fdc667ebb34e to 01e247a9ab39 (4 revisions) (#156698)
fdc667ebb3...01e247a9ab

2024-10-14 robert.ancell@canonical.com Use GWeakRef API (flutter/engine#55795)
2024-10-14 robert.ancell@canonical.com Remove unnecessary use of std::vector (flutter/engine#55796)
2024-10-14 robert.ancell@canonical.com Remove fl_keyboard_view_delegate_subscribe_to_layout_change and just access the object directly via a method (flutter/engine#55817)
2024-10-13 robert.ancell@canonical.com Split out FlKeyboardLayout into its own class (flutter/engine#55816)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-14 06:56:25 +00:00
engine-flutter-autoroll
566f606824
Roll Flutter Engine from adc590994aa3 to fdc667ebb34e (1 revision) (#156678)
adc590994a...fdc667ebb3

2024-10-13 robert.ancell@canonical.com When rendering into secondary views, copy the pixel contents between contexts (flutter/engine#55639)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-14 00:51:35 +00:00
engine-flutter-autoroll
b89dd8b336
Roll Flutter Engine from 8fdc6a8254a6 to adc590994aa3 (2 revisions) (#156677)
8fdc6a8254...adc590994a

2024-10-13 robert.ancell@canonical.com Make FlRenderable interface (flutter/engine#55763)
2024-10-13 robert.ancell@canonical.com Fix dispose methods that didn't chain the parent. (flutter/engine#55794)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-13 23:07:26 +00:00
engine-flutter-autoroll
d62bd120b9
Roll Flutter Engine from c2ef73e32f27 to 8fdc6a8254a6 (1 revision) (#156673)
c2ef73e32f...8fdc6a8254

2024-10-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from tNuwSyjjbdU9HjOwQ... to 2cTD8TkGBMX2IssGl... (flutter/engine#55862)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from tNuwSyjjbdU9 to 2cTD8TkGBMX2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-13 20:56:41 +00:00
engine-flutter-autoroll
c083cbcf89
Roll Flutter Engine from 04f82d07c7fe to c2ef73e32f27 (1 revision) (#156671)
04f82d07c7...c2ef73e32f

2024-10-13 skia-flutter-autoroll@skia.org Roll Skia from 88cb2bff3842 to d6d3c4f624a3 (1 revision) (flutter/engine#55861)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-13 17:19:24 +00:00
engine-flutter-autoroll
b58fb12162
Roll Flutter Engine from ea311c957176 to 04f82d07c7fe (1 revision) (#156665)
ea311c9571...04f82d07c7

2024-10-13 skia-flutter-autoroll@skia.org Roll Skia from d2833b68c8c7 to 88cb2bff3842 (2 revisions) (flutter/engine#55853)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-13 08:01:39 +00:00
engine-flutter-autoroll
05ef4d3131
Roll Flutter Engine from b39fec6d97d1 to ea311c957176 (8 revisions) (#156658)
b39fec6d97...ea311c9571

2024-10-12 zanderso@users.noreply.github.com Roll buildroot for flutter/buildroot#912 (flutter/engine#55818)
2024-10-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll Dart SDK from d916a5f69a48 to 75bf9e183a33 (1 revision) (#55838)" (flutter/engine#55850)
2024-10-12 flar@google.com Delete last usages of MockCanvas test mechanism (flutter/engine#55840)
2024-10-12 skia-flutter-autoroll@skia.org Roll Skia from 97cebfb06139 to d2833b68c8c7 (9 revisions) (flutter/engine#55846)
2024-10-12 jonahwilliams@google.com [Impeller] delete a bunch of dead filter code. (flutter/engine#55841)
2024-10-12 55750689+AthulJoseph27@users.noreply.github.com [Impeller] Added support to set polygon mode in Flutter GPU. (flutter/engine#55804)
2024-10-11 skia-flutter-autoroll@skia.org Manual roll Dart SDK from d916a5f69a48 to 75bf9e183a33 (1 revision) (flutter/engine#55838)
2024-10-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 1OZ2rHDklRNSZRUrc... to tNuwSyjjbdU9HjOwQ... (flutter/engine#55837)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 1OZ2rHDklRNS to tNuwSyjjbdU9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-12 21:30:37 +00:00
Jatin Nagar
b3491acb0d
RadioListTile: add property to scale the radio (#156292)
Added a property in the RadioListTile to scale the underlying Radio using `Transform.scale`.

Fixes: #81334
2024-10-12 15:50:36 +00:00
Ildeberto Vasconcelos
ba778dea6d
Add test for AutofillGroup api example (#156439)
Write Tests for API Examples of `autoffil_group`  as part  of https://github.com/flutter/flutter/issues/130459

This are tests of snippets used in [AutofillGroup class](https://api.flutter.dev/flutter/widgets/AutofillGroup-class.html)
2024-10-12 13:54:31 +00:00
Viraj Kanwade
0eedec47c2
Updated iPhone enable developer mode instructions (#154511)
The instructions specify to enable Developer Mode in Privacy and Security. But Developer Mode option is not available, unless you open Xcode and reconnect the device.

___________
9/23 edit from @andrewkolos: See https://stackoverflow.com/questions/77648341/flutter-not-reading-device-developer-mode-setting
2024-10-12 06:23:13 +00:00
Jatin Nagar
63dd042e72
CheckboxListTile: use Transform.scale only when required (#156593)
Make CheckboxListTile use `Transform.scale` only when required.

Fixes: #81334
2024-10-12 05:37:38 +00:00
engine-flutter-autoroll
c667c97c3f
Roll Flutter Engine from bc3b18085b7e to b39fec6d97d1 (1 revision) (#156619)
bc3b18085b...b39fec6d97

2024-10-11 chinmaygarde@google.com [Impeller] libImpeller: Upload missing arm artifacts. (flutter/engine#55790)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-11 21:55:42 +00:00
Bruno Leroux
9e64b67111
Improve InputDecoration.errorMaxLines documentation (#156468)
## Description

This PR improves the `InputDecoration.errorMaxLines` and `InputDecoration.helperMaxLines` documentations to explain when wrapping and ellipsing are applied.

## Related Issue

Fixes [InputDecoration.errorMaxLines's documentation does not match behavior](https://github.com/flutter/flutter/issues/155626).
2024-10-11 21:35:27 +00:00
Parker Lougheed
2682633381
Remove non-functional, deprecated package_api_docs lint (#156603)
Reference: https://github.com/dart-lang/linter/issues/5107
2024-10-11 21:17:19 +00:00
engine-flutter-autoroll
1fb077118d
Roll Flutter Engine from d13cbfb6f38a to bc3b18085b7e (3 revisions) (#156609)
d13cbfb6f3...bc3b18085b

2024-10-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Fuchsia] Use more high level fuchsia-gn-sdk templates (#55445)" (flutter/engine#55834)
2024-10-11 chinmaygarde@google.com [Impeller] libImpeller: Fix missing exports on some paint methods. (flutter/engine#55814)
2024-10-11 68449066+zijiehe-google-com@users.noreply.github.com [fuchsia] Use the right versioned libs according to the target-api-level (flutter/engine#55786)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-10-11 20:53:20 +00:00
RamonFarizel
51aa2f5809
Add code sample to the CupertinoMagnifier/CupertinoTextMagnifier (#156028)
This PR adds code samples regarding the CupertinoMagnifier and CupertinoTextMagnifier

Fixes #154439
2024-10-11 20:53:18 +00:00
Taha Tesser
45033a29f9
Introduce DropdownMenu.closeBehavior to control menu closing behavior (#156405)
Fixes [Add option to control whether the root DropdownMenu can be closed or not](https://github.com/flutter/flutter/issues/139269)

This introduces  `DropdownMenu.closeBehavior` to provide control over `DropdownMenu` can be closed in nested menus.

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatefulWidget {
  const MyApp({super.key});

  @override
  State<MyApp> createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  String selectedValue = "1";

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        body: Center(
          child: Row(
            mainAxisAlignment: MainAxisAlignment.spaceEvenly,
            children: [
              Column(
                spacing: 16.0,
                mainAxisSize: MainAxisSize.min,
                children: [
                  const Text("DropdownMenuCloseBehavior.none"),
                  MenuAnchor(
                    menuChildren: <Widget>[
                      Padding(
                        padding: const EdgeInsets.all(8.0),
                        child: DropdownMenu(
                          closeBehavior: DropdownMenuCloseBehavior.none,
                          label: const Text('Menu'),
                          initialSelection: selectedValue,
                          onSelected: (String? value) {
                            if (value != null) {
                              setState(() {
                                selectedValue = value;
                              });
                            }
                          },
                          dropdownMenuEntries: ["1", "2", "3"]
                              .map(
                                (it) => DropdownMenuEntry(
                                  value: it,
                                  label: it,
                                ),
                              )
                              .toList(),
                        ),
                      )
                    ],
                    child: const Text('Open Menu'),
                    builder: (context, controller, child) {
                      return ElevatedButton(
                        onPressed: () {
                          controller.open();
                        },
                        child: child,
                      );
                    },
                  ),
                ],
              ),
              Column(
                spacing: 16.0,
                mainAxisSize: MainAxisSize.min,
                children: [
                  const Text("DropdownMenuCloseBehavior.self"),
                  MenuAnchor(
                    menuChildren: <Widget>[
                      Padding(
                        padding: const EdgeInsets.all(8.0),
                        child: DropdownMenu(
                          closeBehavior: DropdownMenuCloseBehavior.self,
                          label: const Text('Menu'),
                          initialSelection: selectedValue,
                          onSelected: (String? value) {
                            if (value != null) {
                              setState(() {
                                selectedValue = value;
                              });
                            }
                          },
                          dropdownMenuEntries: ["1", "2", "3"]
                              .map(
                                (it) => DropdownMenuEntry(
                                  value: it,
                                  label: it,
                                ),
                              )
                              .toList(),
                        ),
                      )
                    ],
                    child: const Text('Open Menu'),
                    builder: (context, controller, child) {
                      return ElevatedButton(
                        onPressed: () {
                          controller.open();
                        },
                        child: child,
                      );
                    },
                  ),
                ],
              ),
              Column(
                spacing: 16.0,
                mainAxisSize: MainAxisSize.min,
                children: [
                  const Text("DropdownMenuCloseBehavior.all"),
                  MenuAnchor(
                    menuChildren: <Widget>[
                      Padding(
                        padding: const EdgeInsets.all(8.0),
                        child: DropdownMenu(
                          closeBehavior: DropdownMenuCloseBehavior.all,
                          label: const Text('Menu'),
                          initialSelection: selectedValue,
                          onSelected: (String? value) {
                            if (value != null) {
                              setState(() {
                                selectedValue = value;
                              });
                            }
                          },
                          dropdownMenuEntries: ["1", "2", "3"]
                              .map(
                                (it) => DropdownMenuEntry(
                                  value: it,
                                  label: it,
                                ),
                              )
                              .toList(),
                        ),
                      )
                    ],
                    child: const Text('Open Menu'),
                    builder: (context, controller, child) {
                      return ElevatedButton(
                        onPressed: () {
                          controller.open();
                        },
                        child: child,
                      );
                    },
                  ),
                ],
              ),
            ],
          ),
        ),
      ),
    );
  }
}
```

</details>

### Demo

https://github.com/user-attachments/assets/1f79ea6e-c0c6-4dcf-8180-d9dcca1c22c5
2024-10-11 20:51:18 +00:00
Jonah Williams
56e2a9d380
[devicelab] remove raster cache benchmarks. (#156600)
Death to the raster cache!
2024-10-11 19:46:21 +00:00
auto-submit[bot]
c1a301e8e8
Reverts "Manual pub roll (#156549)" (#156607)
Reverts: flutter/flutter#156549
Initiated by: christopherfujino
Reason for reverting: https://github.com/flutter/flutter/issues/156606
Original PR Author: christopherfujino

Reviewed By: {matanlurey}

This change reverts the following previous change:
I manually ran:

```
flutter update-packages --force-upgrade
cd dev/tools && dart bin/generate_gradle_lockfiles.dart --no-gradle-generation --no-exclusion
```

Note this bumps the `google_mobile_ads` plugin, which caused https://github.com/flutter/flutter/issues/156474. I expect it to work this time after https://flutter-review.googlesource.com/c/recipes/+/60340
2024-10-11 18:52:18 +00:00