1299 Commits

Author SHA1 Message Date
Ian Hickson
22bbc3aa6c Merge pull request #1315 from Hixie/PointerEventListenerCollision
Fix the minedigger game.
2015-09-23 17:34:55 -07:00
James Robinson
3cb73a067a Merge pull request #1314 from jamesr/bump_sky_services
Bump sky_services pub dependency to mojo 0.1.x
2015-09-23 17:25:25 -07:00
Hixie
c8e7504c6f Fix the minedigger game.
Remove the Widgets framework's PointerEventListener definition now that
the Rendering layer has one. It was previously clashing in files that
imported both, which would result in it being hidden. Turns out
MineDigger is the only example that this affects.
2015-09-23 16:50:50 -07:00
Jeff Brown
c483b2e2e6 Only pointers which are down should be tracked.
This change ensures that we only store the results of a hit
test on the initial pointer down event.  Moreover, we perform
new hit tests each time a hovering pointer moves.  This is
important to ensure correct behavior of input devices which can
hover, such as mice.

Previously the first hover movement after releasing a mouse
button would cause a new pointer state to be recorded along with
hit test results for wherever the pointer happened to be which
caused the following pointer down event to be delivered to the
wrong place.

Fixes issue #1189.
2015-09-23 16:48:14 -07:00
James Robinson
cddb85da08 Bump sky_services pub dependency to mojo 0.1.x
This prepares for updating sky to depend on mojo 0.1.x. This corresponds
to the already published sky_services 0.0.26.
2015-09-23 16:37:44 -07:00
Hixie
8ca9be2e89 fn3: Port HomogeneousViewport 2015-09-23 16:21:13 -07:00
Adam Barth
e804a0f4e8 Merge pull request #1308 from abarth/fn3_drag_target
Port DragTarget to fn3
2015-09-23 15:44:54 -07:00
Adam Barth
04aec907c1 Port DragTarget to fn3 2015-09-23 15:44:40 -07:00
Ian Fischer
c7682b5892 Merge pull request #1306 from chinmaygarde/master
Fix sky_tool start/listen on iOS
2015-09-23 13:53:18 -07:00
Adam Barth
bbc2ad1a88 Port more widgets to fn3 2015-09-23 13:36:18 -07:00
Chinmay Garde
dac371beb0 Fix sky_tool start/listen on iOS 2015-09-23 12:54:29 -07:00
Chinmay Garde
310a4acb33 Merge pull request #1305 from chinmaygarde/master
Guard against warnings resulting from non-nullable annotations in sky_window on Mac
2015-09-23 12:54:08 -07:00
Adam Barth
ceb93a02ee Merge pull request #1304 from abarth/simple_widgets
Port some widgets to fn3
2015-09-23 12:34:55 -07:00
Chinmay Garde
fa8b0ce1a1 Guard against warnings resulting non-nullable annotations in sky_window on Mac 2015-09-23 12:16:56 -07:00
Matt Perry
3ba3f43ce4 Merge pull request #1288 from mpcomplete/dart
Replace C++ UpdateTask with an empty dart version, loaded as a snapshot
2015-09-23 14:33:12 -04:00
Adam Barth
867054ab9e Port some widgets to fn3 2015-09-23 11:26:55 -07:00
Hixie
d44555bc18 fn3: Listener
In this new world, Listener is just a wrapper around a node in the
render tree that hooks directly into the event handling logic.
2015-09-23 11:22:51 -07:00
Hixie
77510575c1 Expose _descendantRenderObject as 'renderer'
This allows people to use localToGlobal and company.
2015-09-23 11:13:45 -07:00
Matt Perry
81b2b81b1d Replace C++ UpdateTask with an empty dart version, loaded as a snapshot.
This adds a new placeholder dart package updater in sky/packages. This is built
into a snapshot and compiled into the Sky engine binary using the same
mechanism as the Dart isolate.

I also added a SkyHeadless class, similar to SkyView, used for running Dart
code without a view.
2015-09-23 14:09:38 -04:00
Adam Barth
800336cba6 Add tests for ParentData 2015-09-23 10:59:49 -07:00
Adam Barth
e9b9a3b3b6 Rev pub package 2015-09-23 10:38:25 -07:00
Adam Barth
2e8df67cf2 Rev pub packages 2015-09-23 10:36:09 -07:00
Hixie
e796e498eb fn3: Minor cleanup
- Remove the unique objects used as slots since we decided 'null' was
  fine after all
- Rename 'slot' to 'newSlot' when it's used as an argument to change the
  _slot field, to clarify which variable has the newer value
- Remove the RenderObject registry since we'll do listeners a different
  way. This also removes handleEvent for the same reason.
- Remove the TODOs for mount/unmount becoming didMount/didUnmount since
  the methods do in fact do the mounting/unmounting.
2015-09-23 09:24:13 -07:00
Hixie
e1afb3023f fn3: Binding to RenderView
In the old world, we had two ways to bind a Widget tree to a
RenderObject node, one way for RenderView and one mostly untested way
for other cases (it's only tested by the spinning_mixed.dart demo). For
fn3, I made these the same code path.

This patch also introduces GlobalKey, though the GlobalKey logic isn't
hooked in yet.

This is Hello World in the new world:

```dart
import 'package:sky/src/fn3.dart';

void main() {
  runApp(new Text('Hello World!'));
}
```
2015-09-23 09:12:01 -07:00
Adam Barth
06388ba5ff Add tests for MultiChildRenderWidget 2015-09-23 08:52:15 -07:00
Adam Barth
28c4656083 Add support for multichild widgets to fn3 2015-09-22 17:52:40 -07:00
Chinmay Garde
1ed5a16e05 Merge pull request #1293 from chinmaygarde/master
Fix leak of the picture after tracing it to a file
2015-09-22 16:15:02 -07:00
Chinmay Garde
ae90923593 Use wtf/RefPtr instead of manually un-reffing the SkPicture reference in PaintContext 2015-09-22 16:14:47 -07:00
Adam Barth
b407d116fd Merge pull request #1291 from abarth/fn2_tag_widgets
Add TagWidget to fn3
2015-09-22 16:14:36 -07:00
Chinmay Garde
fedda1d8df Fix leak of the picture after tracing it to a file 2015-09-22 16:08:39 -07:00
Adam Barth
b1736518e1 Add ParentDataWidget and InheritedWidget to fn3 2015-09-22 16:07:27 -07:00
Hans Muller
54553997ad bumped newton to version 0.1.3 2015-09-22 16:00:21 -07:00
Hans Muller
60e9aa5135 Merge pull request #1286 from HansMuller/limit_scrolling_animation
Currently, fling scrolls animate far too long after the display has effectively stopped moving. Use the ScrollSimulation's tolerance property to stop the scrolling roughly when the display stops changing.
2015-09-22 15:48:24 -07:00
Hixie
724359500a Fix warnings and build errors
Fixes errors from #1285 and #1281.
2015-09-22 15:32:41 -07:00
Ian Hickson
7b2c7b33bb Merge pull request #1285 from Hixie/fn3
fn3: Add a binding for fn3 and sky.
2015-09-22 15:27:11 -07:00
Hans Muller
00c87f0a67 Set simulation tolerance field 2015-09-22 15:08:13 -07:00
Chinmay Garde
70c98ff994 Generate unique SkPicture trace files each time a trace is requested 2015-09-22 15:00:36 -07:00
Hans Muller
90e08ea94b replace endDistance and endVelocity parameters with tolerance 2015-09-22 14:50:27 -07:00
Chinmay Garde
f222d57e4d When capturing a frame, pass the frame size to the top level picture 2015-09-22 14:33:27 -07:00
Hans Muller
1447d22756 Added velocity and distance thresholds to ScrollSimulation, ScrollBehavior 2015-09-22 13:34:57 -07:00
Hixie
a57d3ddd69 fn3: Add a binding for fn3 and sky.
- I extracted the BuildScheduler into a separate binding.dart file.
- Various changes to expose private members that are needed by
  binding.dart.
- Registering the render objects for event dispatch.
- Convert the tests to use the new binding mechanism.

This doesn't yet have a RenderView or event handling.
2015-09-22 12:30:37 -07:00
Adam Barth
5068939407 Add CustomPaint and few other basic widgets to fn3
We'll need tag nodes before finishing Flex and Stack.
2015-09-22 11:26:20 -07:00
Ian Hickson
dfb5fbdae4 Merge pull request #1280 from Hixie/block
Fix scrolling of Block.
2015-09-22 10:43:22 -07:00
Hixie
838fa55385 Fix scrolling of Block.
Since our build function depends on scrollBehavior.isScrollable, any
time we update scrollBehavior we are implicitly updating our state. As
such, we must do so during a setState() call, or else we won't rebuild
and might not bother to listen to the scroll gestures.

This probably broke when we made Block not listen to gestures if it
wasn't overflowing.
2015-09-22 10:36:34 -07:00
Adam Barth
dd78171041 Add a number of basic widgets to fn3
There are some TODOs in this file that I'll address in the next patch.
2015-09-22 10:27:28 -07:00
Adam Barth
c0a7b2a2fb Merge pull request #1279 from Hixie/fn3
More dartdocs for fn3, refactor buildDirtyElements
2015-09-22 09:41:38 -07:00
Jason Simmons
e4c329d19b Merge pull request #1245 from jason-simmons/editable_text_initial_blink
Ensure that EditableText always shows a cursor
2015-09-22 09:29:52 -07:00
Jason Simmons
148dade286 Merge pull request #1255 from jason-simmons/skyanalyzer_pub_cache
Some cleanup of the Sky analyzer script
2015-09-22 09:29:27 -07:00
Hixie
43ee253c09 More dartdocs for fn3, refactor buildDirtyElements
The buildDirtyElements() method now enforces that we only build deeper
nodes and never go back to build higher nodes during a frame.
2015-09-22 09:20:30 -07:00
Adam Barth
985e430532 Merge pull request #1273 from abarth/rm_gesture_event
Remove GestureEvent.idl
2015-09-21 21:36:45 -07:00