DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
31,762 Commits 882 Branches 1,069 Tags
Commit Graph

31762 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
1fb03eae7e Roll Fuchsia Linux SDK from cu6apvEZ2P6zhishc... to l2RxJKPfYn7QzGOoL... (flutter/engine#46382) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-28 21:23:01 +00:00
gaaclarke
ffb68709ee Remove opacity layer dcheck. (flutter/engine#46160) 
In https://github.com/flutter/flutter/issues/132849 it was found that rendering happens fine when this dcheck is removed.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-28 21:16:50 +00:00
Matan Lurey
3e3251147a Add initial support for 4x MSAA in OpenGLES backend. (flutter/engine#46381) 
Initial support _towards_ https://github.com/flutter/flutter/issues/130045.

This updates the `PROC_TABLE`, and adds (and supports) `Type::kRenderBufferMultisampled`.

The type remains unused in the actual engine, and will be in a follow-up PR once we like this one!

/cc @chinmaygarde
 2023-09-28 20:44:31 +00:00
Matej Knopp
fab42e688a Reland: [macOS] performKeyEquivalent cleanup (flutter/engine#46377) 
Fixes the issue in original PR where `FlutterViewWrapper` does not pass the key equivalent to subviews thus prevents `TextInputPlugin` from receiving it. Also adds a regression test for this scenario.

Note that key equivalent flow does not respect the regular responder chain. It is passed from root view to down to subviews and if unhandled will be forwarded to menus.

Original message: 

https://github.com/flutter/engine/pull/40706 added a duplicate `NSEvent (KeyEquivalentMarker)` category. This PR removes it. It also removes the call to `markAsKeyEquivalent` from `FlutterViewController`. That call is internal to `FlutterTextInputPlugin` and classes outside should not be calling it.

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-28 20:41:11 +00:00
Matej Knopp
839d6adae7 [macOS] TextInputPlugin should mark navigation events in IME popover as handled (flutter/engine#46141) 
Fixes https://github.com/flutter/flutter/issues/134699

Because of NSTextInputContext API limitations it is not straightforward to determine whether `TextInputPlugin` has handled a text equivalent event or whether it should pass it on. Previously we marked all event  that didn't result in a TextInputClient action as unhandled, but that's does not work for arrow key events while the IME popover is active.

This PR will mark arrow keys event as handled if there is active composition.

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-28 20:37:47 +00:00
gaaclarke
0a75ad30ae Removed unnecessary dynamic dispatch (flutter/engine#46369) 
Small performance tweak.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-28 20:17:48 +00:00
Joel Winarske
40b832a838 [Impeller] Fix OpenGLES EGL_BAD_ACCESS due to context being current on multiple threads. (flutter/engine#46287) 
On Linux setting the EGL context from one thread, then setting from another thread will trigger a EGL_BAD_ACCESS error.  The resolution is to clear the context after use on the thread that set it.

https://github.com/flutter/flutter/issues/130619
 2023-09-28 20:10:09 +00:00
AJI
86b582a6bc Fix damage calculation when not providing populate_existing_damage for gl embedder (flutter/engine#45611) 
# Description

This PR fixes the `gl_populate_existing_damage` in embedder.cc, which currently returns an empty rectangle when a full repaint is needed. This leads to the `frame_damage` being considered empty in rasterizer.cc, causing incorrect partial repaint within Flutter when `gl_populate_existing_damage` is not provided by the embedder.

# Related Issue

https://github.com/flutter/flutter/issues/119601

# Tests

Add a new test. Also fixes damage calculation related tests in EmbedderTest by

* Use a new Dart embedder fixture entry point `render_gradient_retained` which retains the old layer to make sure layer tree diff happens.
* Add `latch.Wait()` after `SetGLPresentCallback` to make sure assertions have been executed.
* Make `existing_damage_rects` static since it should be valid after `populate_existing_damage` returns.
 2023-09-28 20:06:51 +00:00
Matej Knopp
c94d335b6b [macOS] FlutterTextInputPlugin should clip to bounds (flutter/engine#46142) 
Fixes https://github.com/flutter/flutter/issues/135219
(formerly https://github.com/flutter/flutter/issues/128956)

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-28 19:05:55 +00:00
skia-flutter-autoroll
53a111dc8a Roll Skia from d8a71d549262 to 33502f9b0c7d (2 revisions) (flutter/engine#46375) 
https://skia.googlesource.com/skia.git/+log/d8a71d549262..33502f9b0c7d

2023-09-28 michaelludwig@google.com Revert "[skif] Draw FilterResults directly for layer restoration"
2023-09-28 michaelludwig@google.com [skif] Draw FilterResults directly for layer restoration

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-28 18:44:14 +00:00
Chris Bracken
87e27ff202 Revert "[macOS] performKeyEquivalent cleanup (#45946)" (flutter/engine#46374) 
This broke some keyboard shortcut handling (e.g. cmd-a to select all).

This reverts commit 0deacc6c7023789c4a75155e6798b3cccdc6384a.


## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-09-28 10:45:11 -07:00
Matej Knopp
0deacc6c70 [macOS] performKeyEquivalent cleanup (flutter/engine#45946) 
https://github.com/flutter/engine/pull/40706 added a duplicate `NSEvent (KeyEquivalentMarker)` category. This PR removes it. It also removes the call to `markAsKeyEquivalent` from `FlutterViewController`. That call is internal to `FlutterTextInputPlugin` and classes outside should not be calling it.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-28 17:28:47 +00:00
skia-flutter-autoroll
5b9610fed9 Roll Skia from bcbcb109bad6 to d8a71d549262 (1 revision) (flutter/engine#46367) 
https://skia.googlesource.com/skia.git/+log/bcbcb109bad6..d8a71d549262

2023-09-28 jmbetancourt@google.com expose getSlotInfo to JS skottie bindings

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-28 16:05:04 +00:00
skia-flutter-autoroll
da36ad6002 Manual roll Dart SDK from 7c3588c05f87 to 077d768accfa (11 revisions) (flutter/engine#46366) 
Manual roll requested by zra@google.com

https://dart.googlesource.com/sdk.git/+log/7c3588c05f87..077d768accfa

2023-09-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-210.0.dev
2023-09-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-209.0.dev
2023-09-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-208.0.dev
2023-09-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-207.0.dev
2023-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-206.0.dev
2023-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-205.0.dev
2023-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-204.0.dev
2023-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-203.0.dev
2023-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-202.0.dev
2023-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-201.0.dev
2023-09-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-200.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-28 15:38:04 +00:00
skia-flutter-autoroll
77357cd39b Roll Skia from 267bb43e822d to bcbcb109bad6 (1 revision) (flutter/engine#46365) 
https://skia.googlesource.com/skia.git/+log/267bb43e822d..bcbcb109bad6

2023-09-28 kjlubick@google.com Apply buildifier fixes

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-28 14:23:24 +00:00
Bruno Leroux
f732952384 [Android] Rename allowChannelBufferOverflow to `setWarnsOnChannelOv… (flutter/engine#46361) 
## Description

This PR is a follow-up to https://github.com/flutter/engine/pull/44434 which introduces the `allowChannelBufferOverflow` function. It renames this function to `setWarnsOnChannelOverflow`.

The previous naming was inspired by the framework side implementation.
c00c022036/lib/ui/channel_buffers.dart (L574)

During the review of the iOS/macOS implementation, https://github.com/flutter/engine/pull/44848#discussion_r1310463864, we agreed that the existing naming is confusing because it implies that overflow will be allowed, but this not the case this function is used to enable/disable error messages when a channel overflows. 

## Related Issue

Follow-up for https://github.com/flutter/flutter/issues/132386.

## Tests

Updates 1 test.
 2023-09-28 14:08:12 +00:00
skia-flutter-autoroll
35f3d4d35d Roll Skia from cfac8410d773 to 267bb43e822d (1 revision) (flutter/engine#46363) 
https://skia.googlesource.com/skia.git/+log/cfac8410d773..267bb43e822d

2023-09-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 89aea904c65f to 34349287c876 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-28 13:46:56 +00:00
skia-flutter-autoroll
2fa365eb17 Roll Skia from d410e03a6b9b to cfac8410d773 (1 revision) (flutter/engine#46362) 
https://skia.googlesource.com/skia.git/+log/d410e03a6b9b..cfac8410d773

2023-09-28 kjlubick@google.com Expand //:core and introduce //:png_decode_codec et al

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-28 13:03:33 +00:00
skia-flutter-autoroll
98aae71e5b Roll Fuchsia Mac SDK from U334SygIkffMJVmdu... to 4WW3KRrAbuY7VeGT0... (flutter/engine#46357) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-28 10:27:26 +00:00
skia-flutter-autoroll
b8a3cc3bb2 Roll Fuchsia Linux SDK from 6Y22MutFhgL7ua18F... to cu6apvEZ2P6zhishc... (flutter/engine#46355) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-28 08:39:34 +00:00
skia-flutter-autoroll
0ecfd72bc0 Roll Skia from 1f4e5c374172 to d410e03a6b9b (1 revision) (flutter/engine#46353) 
https://skia.googlesource.com/skia.git/+log/1f4e5c374172..d410e03a6b9b

2023-09-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2c0f9d20f699 to 929ace8da386 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-28 07:13:47 +00:00
skia-flutter-autoroll
4fc16d688b Roll Skia from f3e5eddda2fa to 1f4e5c374172 (2 revisions) (flutter/engine#46351) 
https://skia.googlesource.com/skia.git/+log/f3e5eddda2fa..1f4e5c374172

2023-09-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from d0c5366041fc to 8248cceea329
2023-09-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from b3365cad07b5 to d0c5366041fc (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-28 06:14:19 +00:00
skia-flutter-autoroll
1ba3aea5da Roll Skia from 704217de51e1 to f3e5eddda2fa (1 revision) (flutter/engine#46350) 
https://skia.googlesource.com/skia.git/+log/704217de51e1..f3e5eddda2fa

2023-09-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 1ec4835ca75d to 1b2986736fd2 (14 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-28 05:17:05 +00:00
skia-flutter-autoroll
788809446f Roll Skia from 4441cde55a79 to 704217de51e1 (1 revision) (flutter/engine#46346) 
https://skia.googlesource.com/skia.git/+log/4441cde55a79..704217de51e1

2023-09-28 armansito@google.com Roll vello from 4435398 to ee3a076

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-28 03:25:44 +00:00
auto-submit[bot]
9aa6a942cb Reverts "Roll Dart SDK from 7c3588c05f87 to 86c577329bf7 (8 revisions)" (flutter/engine#46345) 
Reverts flutter/engine#46342
Initiated by: zanderso
This change reverts the following previous change:

https://dart.googlesource.com/sdk.git/+log/7c3588c05f87..86c577329bf7

2023-09-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-207.0.dev
2023-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-206.0.dev
2023-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-205.0.dev
2023-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-204.0.dev
2023-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-203.0.dev
2023-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-202.0.dev
2023-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-201.0.dev
2023-09-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-200.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-28 02:52:26 +00:00
skia-flutter-autoroll
ee4b10ab70 Roll Dart SDK from 7c3588c05f87 to 86c577329bf7 (8 revisions) (flutter/engine#46342) 
https://dart.googlesource.com/sdk.git/+log/7c3588c05f87..86c577329bf7

2023-09-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-207.0.dev
2023-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-206.0.dev
2023-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-205.0.dev
2023-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-204.0.dev
2023-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-203.0.dev
2023-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-202.0.dev
2023-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-201.0.dev
2023-09-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-200.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-28 01:53:17 +00:00
skia-flutter-autoroll
a41f152a42 Roll Skia from b048b468d641 to 4441cde55a79 (1 revision) (flutter/engine#46341) 
https://skia.googlesource.com/skia.git/+log/b048b468d641..4441cde55a79

2023-09-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5ec10484307a to 89aea904c65f (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-28 01:13:04 +00:00
Jackson Gardner
fb4d10cce3 Rollback Dart SDK to 3.2.0-119. (flutter/engine#46339) 
This is a manual rollback to unblock the engine -> framework roller, until https://dart-review.googlesource.com/c/sdk/+/328180 makes its way into a rollable SDK version
 2023-09-28 00:13:36 +00:00
Harry Terkelsen
940ac25772 [canvaskit] Do not double-apply ImageFilter transform to children (flutter/engine#46336) 
Fixes an issue seen in the "widgets.image_filter_matrix" golden here:
https://flutter-gold.skia.org/search?crs=github&issue=135249&patchsets=3

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-09-27 17:12:19 -07:00
Chris Yang
e2bc37bba7 Reland "Reverts "[ios] Fix app extension not able to find assets from… (flutter/engine#46329) 
Relands https://github.com/flutter/engine/pull/46283

The original PR had a bug where the relative assets path is reset after not being found in the `bundle`. It should not be reset unless it was not found inside the info.plist in `bundle`

Fixes https://github.com/flutter/flutter/issues/124292

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-28 00:02:04 +00:00
chunhtai
e333e342c8 Revert "[Impeller] Fixes stroke path geometry that can draw outside o… (flutter/engine#46334) 
…f path if the path ends at sharp turn. (#45252)"

This reverts commit 5238bbae830c11247ae6cc5989e8ce8ced59c24d.

introduced a regression
https://github.com/flutter/flutter/issues/135225

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-27 22:59:08 +00:00
skia-flutter-autoroll
898b8843ef Roll Fuchsia Mac SDK from jQHACBU4Fi2wMElkm... to U334SygIkffMJVmdu... (flutter/engine#46333) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-27 21:52:17 +00:00
skia-flutter-autoroll
b85d017a4b Roll Skia from 952e8dd66560 to b048b468d641 (1 revision) (flutter/engine#46332) 
https://skia.googlesource.com/skia.git/+log/952e8dd66560..b048b468d641

2023-09-27 kjlubick@google.com Don't build fontations gm for WASM

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-27 20:53:28 +00:00
Jason Simmons
f0f7d3934f [Impeller] Destroy all per-thread command pools tied to a context before deleting the context (flutter/engine#46286) 
Vulkan requires that all objects created using a device be destroyed before the device is destroyed.  The CommandPoolRecyclerVK maintains a thread-local map of each context's currently active command pool. Before the context deletes the device, it must force cleanup of all such command pools associated with that context.

This PR reinstates a mechanism that was used prior to the refactoring that introduced command pool recycling.
 2023-09-27 20:09:51 +00:00
skia-flutter-autoroll
acb7b973bc Roll Skia from d78aba2524b3 to 952e8dd66560 (1 revision) (flutter/engine#46331) 
https://skia.googlesource.com/skia.git/+log/d78aba2524b3..952e8dd66560

2023-09-27 armansito@google.com [graphite] Fix VelloComputeStep declarations for WGSL

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-27 20:06:40 +00:00
Jonah Williams
68175db388 [Impeller] Match Skia gradient clamping behavior (and document). (flutter/engine#44825) 
Skia clamps any gradient stops to values of 0.0 to 1.0. Implement this behavior in Impeller and document it in dart:ui (Framework also needs to be documented). This also matches the w3c gradient behavior: https://www.w3.org/TR/2000/CR-SVG-20000802/pservers.html - almost. We might be slightly off with how we're inserting additional stops for 0.0 and 1.0, but at least its closer.

Fixes https://github.com/flutter/flutter/issues/132792
 2023-09-27 19:48:19 +00:00
skia-flutter-autoroll
4de50ce133 Roll Dart SDK from 97647bb1666b to 80a965ee48ab (1 revision) (flutter/engine#46330) 
https://dart.googlesource.com/sdk.git/+log/97647bb1666b..80a965ee48ab

2023-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-205.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-27 19:11:24 +00:00
skia-flutter-autoroll
3c2eb5187d Roll Skia from ff5474eed6b4 to d78aba2524b3 (3 revisions) (flutter/engine#46327) 
https://skia.googlesource.com/skia.git/+log/ff5474eed6b4..d78aba2524b3

2023-09-27 michaelludwig@google.com [skif] Make SkImageFilters::Crop public
2023-09-27 drott@chromium.org [Fontations] Add pixel comparisons for FreeType vs. Fontations
2023-09-27 johnstiles@google.com Split out MakeChildFP to a separate helper function.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-27 18:08:11 +00:00
auto-submit[bot]
8a97e55da3 Reverts "[ios] Fix app extension not able to find assets from unloaded bundle" (flutter/engine#46328) 
Reverts flutter/engine#46283
Initiated by: CaseyHillers
This change reverts the following previous change:
Directly use "flutter_assets" as the default path to find the asset path, this works for app extension when the bundle is unloaded.

This PR also adds integration tests for app extensions, which also tests the asset path. 

Fixes https://github.com/flutter/flutter/issues/124292

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-27 17:57:18 +00:00
Loïc Sharma
f020b2c7c9 [Windows] Improve logic to update swap intervals (flutter/engine#46172) 
This relands https://github.com/flutter/engine/pull/45310 to unblock the ANGLE roll with the fix for https://github.com/flutter/flutter/issues/134262.

## Background

### Swap interval

If the Windows system compositor is enabled, the Windows embedder disables the swap interval so that presenting to a surface does not block until the v-blank. If the Windows system compositor is disabled (which is possible on Windows 7), the Windows embedder enables swap interval to prevent screen tearing.

### GL context threading

Our current version of ANGLE allows making a GL context current on multiple threads. However, the latest version of ANGLE errors if a GL context is made current on multiple threads. This is causing the ANGLE roll to fail ([example](https://ci.chromium.org/ui/p/flutter/builders/try/Windows%20Engine%20Drone/203788/overview)).

The Windows embedder has two GL context threading issues:

1. At startup, the platform thread creates and binds the GL context. This change ensures the GL context is released from the platform thread so that the raster thread can use the GL context for rendering.
2. When the system compositor updates, the GL context is bound to the platform thread to update the swap interval. This change ensures the swap interval update happens on the raster thread.

### Window resizing

Resizing the window recreates the GL surface and resets the swap interval.

The previous fix released the current GL context after updating the swap interval (this ensured the platform thread released the GL context at startup). This broke window resizing as it caused the engine to "lose" its GL context during rendering (see https://github.com/flutter/flutter/issues/134262). This reland releases the GL context only if on the startup case.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-27 17:52:17 +00:00
Jonah Williams
41604c6b10 [Impeller] Fallback to no index buffer when tesselation count is large, split up nonZero contours. (flutter/engine#46282) 
See example app in https://github.com/flutter/flutter/issues/135458

Because tessellation is generally nlogn best case (with allocation complexity as well), we can actually make it faster by breaking it into smaller pieces. For non zero fill modes, the contours can be tessellated individually without  losing fidelity.

In cases where this isn't possible, we need to check if we exceed the max uint16 index and fall back to no index buffer.

Fixes https://github.com/flutter/flutter/issues/135458

I Benchmarked signing my name.

### Before

 worst raster time 3+ seconds. Visual glitches

![flutter_03](https://github.com/flutter/engine/assets/8975114/7be57bd2-744f-4f0a-af0a-d2bd4fc9efaf)

### After
worst raster time 30 ms, looks correct (though my signature is still wrong)

![flutter_04](https://github.com/flutter/engine/assets/8975114/1fdf504e-7b4e-447a-8c29-063dd0ff34d0)
 2023-09-27 17:11:08 +00:00
skia-flutter-autoroll
5f33b082a2 Roll Skia from 4731ccd6342c to ff5474eed6b4 (1 revision) (flutter/engine#46325) 
https://skia.googlesource.com/skia.git/+log/4731ccd6342c..ff5474eed6b4

2023-09-27 johnstiles@google.com Remove make_effect_fp from header.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-27 16:16:21 +00:00
Jason Simmons
bfc3acee24 Declare native wrapper classes in Fuchsia packages as base classes (flutter/engine#46305) 
This prohibits other implementations of the class interface that can not act as native wrappers.

See https://github.com/flutter/flutter/issues/123756
 2023-09-27 15:44:58 +00:00
godofredoc
aaea48626e Remove fuchsia from recipes cq. (flutter/engine#46324) 
It was accidentally added back when landing some changes to the v2 version of the build.

Bug: https://github.com/flutter/flutter/issues/135596

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-09-27 15:43:12 +00:00
skia-flutter-autoroll
9383e8fc67 Roll Dart SDK from c2a455113e39 to 97647bb1666b (1 revision) (flutter/engine#46323) 
https://dart.googlesource.com/sdk.git/+log/c2a455113e39..97647bb1666b

2023-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-204.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-27 15:25:48 +00:00
Matej Knopp
066459ce65 [macOS] Synchronise modifiers from mouse events for RawKeyboard (flutter/engine#46230) 
Fixes https://github.com/flutter/flutter/issues/135349

This has been done for FlutterEmbedderKeyResponder in
https://github.com/flutter/engine/pull/37870, but has not been
implemented for FlutterChannelKeyResponder, which results in RawKeyboard
being out of sync with HardwareKeyboard.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-09-27 17:09:49 +02:00
skia-flutter-autoroll
168a4156df Roll Fuchsia Linux SDK from Lg6FR6iDnZeV6y-E8... to 6Y22MutFhgL7ua18F... (flutter/engine#46322) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-27 15:02:53 +00:00
skia-flutter-autoroll
723871d91e Roll Skia from 2991bb799d3f to 4731ccd6342c (1 revision) (flutter/engine#46321) 
https://skia.googlesource.com/skia.git/+log/2991bb799d3f..4731ccd6342c

2023-09-27 nicolettep@google.com Reland "[graphite] Add Vulkan BackendTexture creation and deletion methods; unit tests"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bungeman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-27 14:47:56 +00:00
Jason Simmons
c53ee75553 Declare native wrapper classes in the GPU package as base classes (flutter/engine#46304) 
This prohibits other implementations of the class interface that can not act as native wrappers.

See https://github.com/flutter/flutter/issues/123756
 2023-09-27 14:44:54 +00:00
Jason Simmons
75dcef5f45 Do not call DrawTextBlob for performance overlay text when using Impeller (flutter/engine#46307) 2023-09-27 14:44:51 +00:00