Fixes InputDecorator to work with textScaleFactor, fixes Material Design differences.
There were a number of differences with the Material Design spec, including
several different padding values and underline thickness. This corrects
that so that the decorator is in line with the Material Design spec now.
Also, the decorator properly handles changes to the textScaleFactor, where
before it would not re-layout when needed, painting the cursor and
underline incorrectly.
The decorator also now properly animates helper, error, and hint text when
the textScaleFactor or input decoration properties change.
Helper text is now properly displayed in dense mode, as the spec shows.
Before this change, it was never displayed in dense mode.
Fixes#12485
* Make Tab take a widget as child
This way you can override the semantics information of a Tab (see test).
Fixes https://github.com/flutter/flutter/issues/12432
* more tests
* review comments
* review comment
* doc nits
* style fix
libtxt's implementation of Paragraph.getBoxesForRange returns the full line
height for all characters in a line. Blink had been returning a tighter
enclosing rectangle for each individual character.
This modifies the MaterialButton to expand vertically to fit the size of the contained child, no matter what the child widget is. It tries to be as close as possible to the minHeight constraint.
Also updated some doc comments to have headers (extra blank line after first sentence), and to wrap at 80 cols.
Addresses #12311
* Keep Icon's subtree structure the same with and without a semanticLabel.
This avoids rebuilding the subtree when a semanticLabel is set/unset.
Also updated some doc comments.
(This is a followup on post-merge comments for #12475)
* Roll engine
* Move assert requiring 'this' from initializer to constructor body
* Update test expected message
* Relax regexp to allow wider array of dart uris
Also:
* Provide a better message when you lerp from infinity to finity
constraints.
* Make the striped marker support RTL.
* By popular demand, dump a warning to the console the first time
a particular Flex overflows. (Resets on hot reload.)
This updates the bottom navigation bar to be able to handle more general widgets in the place of the label in the bottom navigation bar, so that Text with a textScaleFactor larger than 1.0 will behave nicely in a bottom navigation bar.
It also means that other widgets given instead of a Text widget for the label will work more predictably.
I also vastly simplified the layout logic, eliminating many computations that were not needed, and refactored the build function to use a separate private navigation tile widget.
Also, the color splash animations were coming from the wrong location (they were coming from far to the right of the touched widget), so that works as specified now.
* Changed PageController #nextPage & #previousPage to return a Future after completing.
* Removed false statement about returning a Future in PageController#jumpToPage
* Added tests to make sure nextPage & previousPage return Futures.
* Tested that the Futures returned by nextPage & previousPage actually resolve.
* Renaming *pageCalled to *pageCompleted, since that's what it's actually for.
* Revert "When parts of the program are changed in a hot reload, but not executed during the reassemble, warn that a restart may be needed. (#12304)"
This reverts commit 90028813a89a3de8154144e6e0f1edbe90dc2e4f.
* fix _debugCheckOwnerBuildTargetExists; sync localizations and tests
* address comments