4194 Commits

Author SHA1 Message Date
Greg Spencer
67cf7918cf Fixes InputDecorator to work with textScaleFactor, fixes Material Design differences. (#12595)
Fixes InputDecorator to work with textScaleFactor, fixes Material Design differences.

There were a number of differences with the Material Design spec, including
several different padding values and underline thickness.  This corrects
that so that the decorator is in line with the Material Design spec now.

Also, the decorator properly handles changes to the textScaleFactor, where
before it would not re-layout when needed, painting the cursor and
underline incorrectly.

The decorator also now properly animates helper, error, and hint text when
the textScaleFactor or input decoration properties change.

Helper text is now properly displayed in dense mode, as the spec shows.
Before this change, it was never displayed in dense mode.

Fixes #12485
2017-10-19 10:11:07 -07:00
Greg Spencer
7e09649c41 Override just the textScaleFactor (#12530)
Hixie pointed out that what I had before was resetting all of the MediaQuery values, not just textScaleFactor. This should fix that.
2017-10-19 09:24:05 -07:00
Sarah Zakarias
f74cd91761 Update TextStyle doc and remove package field (#12577) 2017-10-19 10:14:38 +02:00
Sarah Zakarias
e4f53c3abd Add 'package' argument to IconData (#12560) 2017-10-19 09:38:54 +02:00
Alexandre Ardhuin
700dc9f752 enable lint avoid_function_literals_in_foreach_calls (#12607) 2017-10-19 08:16:16 +02:00
Todd Volkert
79fbf8bb03 Split common matcher into its own file. (#12622)
This aids in running the tests internally in Google
since the libraries upon which tests depend and the
test files themselves are defined separately.
2017-10-18 20:55:00 -07:00
Michael Goderbauer
a5a75e3d84 Fix tabs Semantics test (#12620)
Merge confliuct between #12605 and #12613
2017-10-18 17:11:50 -07:00
Michael Goderbauer
f8a2bd20e9 Redesign Semantic Tree Compilation Algorithm (#12605)
* Oct 12 10:12am

* implicit_semantics_test.dart passes

* refactoring

* works in nice

* minor rename

* more doc comments

* to be explicit check better

* fix test

* ++

* ++

* semantics_9_test (BlockSemantics) and implicit_semantics_test are passing

* doc updates

* tiny refactor

* fix static errors in tests

* fix gesture detector

* ++

* ++

* geometry

* ++

* remove noGeometry

* revert test

* +

* all tests but scrolling/clipping pass

* clipping works

* scrolling halfway

* sliver tests pass

* ALL TESTS PASS

* SemanticsNode changed

* docs and tiny fixes

* card test

* more doc comments

* remove missed print

* more tests

* make test pass on Linux

* remove changes to intellij proj file

* review comments
2017-10-18 16:28:24 -07:00
Collin Jackson
d47d268719 0.0.17 dev version (#12593) 2017-10-18 16:25:36 -07:00
Michael Goderbauer
9baca00119 Make Tab take a widget as child (#12613)
* Make Tab take a widget as child

This way you can override the semantics information of a Tab (see test).

Fixes https://github.com/flutter/flutter/issues/12432

* more tests

* review comments

* review comment

* doc nits

* style fix
2017-10-18 16:19:54 -07:00
Jason Simmons
264cbf6145 libtxt: adapt a selection rectangle test (#12612)
libtxt's implementation of Paragraph.getBoxesForRange returns the full line
height for all characters in a line.  Blink had been returning a tighter
enclosing rectangle for each individual character.
2017-10-18 14:48:20 -07:00
Ian Hickson
0790891600 BoxDecoration.borderRadius and RoundedRectangleBorder.borderRadius RTL (#12603) 2017-10-18 11:24:54 -07:00
xster
822084b235 Add a rootNavigator option to Navigator.of (#12580) 2017-10-18 01:31:29 -07:00
xster
964a138d80 nav bar font styles are special, do not inherit (#12578) 2017-10-18 01:30:43 -07:00
Ian Hickson
d920fdd11a RoundedRectangleBorder (#12591) 2017-10-17 17:58:04 -07:00
Jason Simmons
d8380201bd libtxt: update a test for differences in rounding when calculating line heights (#12572) 2017-10-17 17:45:20 -07:00
Jason Simmons
1f531595cf Use non-whitespace contents in a button padding test (#12568)
libtxt has different policies than Blink for trimming whitespace.  This change
will make the test results consistent in both text renderers.
2017-10-17 17:45:11 -07:00
Collin Jackson
e8aa40eddd release 0.0.17 (#12590) 2017-10-17 15:42:40 -07:00
Ian Hickson
0e34c7f28c CircleBorder (#12570) 2017-10-17 13:38:06 -07:00
Ian Hickson
1f82733a3b Make BoxDecoration lerp gradients (#12451)
This still is very limited in what it can lerp, but it sets the stage for arbitrary lerps later.
2017-10-17 13:10:10 -07:00
Adam Barth
a13320253c Don't attempt to draw invisible overflow indicator (#12534)
If the flex is empty, there's no space in which to draw the overflow indicator,
so we shouldn't bother trying to draw it.

Fixes #12532
2017-10-17 11:17:08 -07:00
amirh
3d7a4eed44 Short circuit _checkUp if tap callbacks were triggered by resolve. (#12521) 2017-10-17 10:29:29 -07:00
Hans Muller
bd3e91ed98 AssetImage.obtainKey handles devicePixelRatio == null (#12564) 2017-10-17 09:27:04 -07:00
xster
9ce3ba314e Add Cupertino icon fonts helper and dependency for default template (#12559)
* add CupertinoIcons

* Use new font name convention

* review
2017-10-16 18:59:28 -07:00
P.Y. Laligand
0999fca99d Update references to the engine project. (#12515) 2017-10-13 17:16:33 -07:00
Greg Spencer
25ac924e01 Modify the MaterialButton to expand when text is scaled. (#12431)
This modifies the MaterialButton to expand vertically to fit the size of the contained child, no matter what the child widget is. It tries to be as close as possible to the minHeight constraint.

Also updated some doc comments to have headers (extra blank line after first sentence), and to wrap at 80 cols.

Addresses #12311
2017-10-13 16:07:05 -07:00
amirh
3616ebbd30 Emphasize the behavior property in GestureDetector's class doc. (#12536) 2017-10-13 13:33:39 -07:00
Michael Goderbauer
4ffa801cb1 Remove parentSemantics from semantics tree compliation (#12479) 2017-10-13 12:27:23 -07:00
amirh
32c038ee3f Add missing curly braces in icon.dart (#12529)
(post-merge followup for #12516)
2017-10-13 10:20:22 -07:00
gspencergoog
e316956888 Make tooltips scale with textScaleFactor (#12498)
Fixes #12480
2017-10-12 16:44:21 -07:00
gspencergoog
ba0618d35d Make material slider respect textScaleFactor (#12511)
Make material slider respect textScaleFactor

Fixes #5938
2017-10-12 16:43:28 -07:00
amirh
c312b3d9ae Keep Icon's subtree structure the same with and without a semanticLabel. (#12516)
* Keep Icon's subtree structure the same with and without a semanticLabel.

This avoids rebuilding the subtree when a semanticLabel is set/unset.
Also updated some doc comments.

(This is a followup on post-merge comments for #12475)
2017-10-12 13:52:55 -07:00
gspencergoog
f5cc816c54 Keep CircleAvatar from scaling the text with textScaleFactor (#12499)
Fixes #12483
2017-10-12 08:21:28 -07:00
Hans Muller
c3d56b1dad flutter_localization optional package (#12410) 2017-10-11 16:01:13 -07:00
Michael Goderbauer
f07170b45b Update Semantics for SingleChildScrollViews (#12376)
* Update Semantics for SingleChildScrollViews

* refactor

* review feedback

* added assert and comments

* doc
2017-10-11 13:07:19 -07:00
Chris Bracken
51e4e9f9a5 Rev version to 0.0.17-dev (#12489) 2017-10-10 17:41:25 -07:00
Chris Bracken
4424892c79 Version 0.0.16 (#12488) 2017-10-10 16:45:11 -07:00
Alexander Aprelev
095e6af0b8 Reroll engine to 2a84f18c795d24ba95baed360fcb58b3dc66d661 (#12487) 2017-10-10 16:27:51 -07:00
amirh
5e595d12e4 Allow specifying and a11y label for Icon widget (#12475)
* Allow specifying and a11y label for Icon widget
2017-10-10 14:04:43 -07:00
Alexander Aprelev
c38b843460 Move -referencing asserts to constructor body. (#12478) 2017-10-10 09:05:20 -07:00
Alexander Aprelev
7f5b973cb1 Revert "Roll engine after dart roll (#12473)" (#12477)
This reverts commit e7061698147e80fa53ec3ed0cf048f4d68df7d68.

This causes preview-dart-2 test failures.
2017-10-10 07:27:39 -07:00
Alexander Aprelev
e706169814 Roll engine after dart roll (#12473)
* Roll engine

* Move assert requiring 'this' from initializer to constructor body

* Update test expected message

* Relax regexp to allow wider array of dart uris
2017-10-10 06:38:51 -07:00
Alexander Aprelev
4023b7cad8 Use const for const constructor (#12464) 2017-10-09 09:29:43 -07:00
Ian Hickson
4e48a737eb Fix flex floating point error causing unnecessary striped warnings (#12424)
Also:

 * Provide a better message when you lerp from infinity to finity
   constraints.

 * Make the striped marker support RTL.

 * By popular demand, dump a warning to the console the first time
   a particular Flex overflows. (Resets on hot reload.)
2017-10-06 19:24:34 -07:00
P.Y. Laligand
21b81d902d Disable Dart analysis in Fuchsia. (#12409)
Fuchsia will soon use a newer version of the Dart analysis server which Flutter code has not been adjusted for yet.
2017-10-06 10:47:52 -07:00
gspencergoog
8d41fa7862 Adding proper accommodation for textScaleFactor in bottom navigation bar. (#12421)
This updates the bottom navigation bar to be able to handle more general widgets in the place of the label in the bottom navigation bar, so that Text with a textScaleFactor larger than 1.0 will behave nicely in a bottom navigation bar.

It also means that other widgets given instead of a Text widget for the label will work more predictably.

I also vastly simplified the layout logic, eliminating many computations that were not needed, and refactored the build function to use a separate private navigation tile widget.

Also, the color splash animations were coming from the wrong location (they were coming from far to the right of the touched widget), so that works as specified now.
2017-10-06 08:13:34 -07:00
Iiro Krankka
0a85db2958 Change PageController#nextPage & #previousPage methods to return Future when the animation completes. (#12299)
* Changed PageController #nextPage & #previousPage to return a Future after completing.

* Removed false statement about returning a Future in PageController#jumpToPage

* Added tests to make sure nextPage & previousPage return Futures.

* Tested that the Futures returned by nextPage & previousPage actually resolve.

* Renaming *pageCalled to *pageCompleted, since that's what it's actually for.
2017-10-05 21:13:27 -07:00
Alexander Aprelev
c02850b4dc Force upgrade update packages with improved update process. (#12412)
* Force upgrade update packages with improved update process.

* Update packages

* Revert "Update packages"

This reverts commit a37de26d3f4f7f5a15746ff791002625faa3d3c0.
2017-10-05 20:59:08 -07:00
Yegor
150c58303e Date picker i18n (#12324)
* formatYear

* localize date picker

* tests

* clean-ups

* address comments
2017-10-05 17:15:20 -07:00
Yegor
6ca2e5dc10 fix _debugCheckOwnerBuildTargetExists; sync localizations and tests (#12245)
* Revert "When parts of the program are changed in a hot reload, but not executed during the reassemble, warn that a restart may be needed. (#12304)"

This reverts commit 90028813a89a3de8154144e6e0f1edbe90dc2e4f.

* fix _debugCheckOwnerBuildTargetExists; sync localizations and tests

* address comments
2017-10-05 15:14:56 -07:00