DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
31,895 Commits 882 Branches 1,069 Tags
Commit Graph

31895 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
skia-flutter-autoroll
1a2c32d8fe Roll Skia from 0f2af25f15ee to d86da2a029d8 (7 revisions) (flutter/engine#46587) 
https://skia.googlesource.com/skia.git/+log/0f2af25f15ee..d86da2a029d8

2023-10-05 brianosman@google.com Fix link errors in shared-library
builds when using SkRuntimeEffect inner classes
2023-10-05 johnstiles@google.com Incorporate child effects into the mesh
key and proxy handlers.
2023-10-05 johnstiles@google.com Set up texture bindings for SkMesh
child effects.
2023-10-05 johnstiles@google.com Emit shader code and uniforms for a
mesh's child processors.
2023-10-05 rmistry@google.com Sync depot_tools to HEAD to fix
RecreateSKPs bot sync failures
2023-10-05 jvanverth@google.com [graphite] Progress towards caching
rasterPathAtlas masks.
2023-10-05 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
vulkan-deps from ff2054861dc4 to 404a76d9bf0e (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-06 15:25:01 -07:00
Alexander Aprelev
eb374b3881 [fuchsia] Remove hardcoded fuchsia-imported packages 2.12 sdk version (flutter/engine#46629) 
Use sdk version from imported package pubspec.yaml instead.

This unblocks dart->engine roll that currently is failing
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Fuchsia/83386/overview.
 2023-10-06 14:01:28 -07:00
Kevin Lubick
5d70f10ebb Add Base64::EncodedSize to tidy up allocations (flutter/engine#46624) 
As a follow-up to #46543, this adds a dedicated function to compute the
size of the buffer needed to encode data using Base64 instead of calling
the encode function with nullptr.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-06 16:50:20 -04:00
Jonah Williams
f29ce2aa7a [Impeller] Ensure known geometry has simple bounds computation. (flutter/engine#46623) 
Computing the bounds of an RRect can be really slow if you don't actually know that it is an RRect, and shows up in the traces for flutter gallery on wembly. This change should be semantically equivalent and is only an optimization to avoid recomputing the same value we already know.
 2023-10-06 20:49:08 +00:00
Jonah Williams
fe78d18716 [Impeller] Refactor CapabilitiesGLES into a Capabilties. (flutter/engine#46621) 
From https://github.com/flutter/engine/pull/46585

For Framebuffer fetch and other changes we should refactor the CapabilitiesGLES into a regular capabilities.
 2023-10-06 19:03:11 +00:00
Brandon DeRosier
096c45ad3f [Impeller] Track clip coverage per-pass when not collapsing. (flutter/engine#46597) 
Resolves https://github.com/flutter/flutter/issues/135916.

Big credits to @gaaclarke for the repros and investigation around this.

Moves back to tracking clip coverage per-pass when not collapsing. This is especially important for SaveLayers with MatrixImageFilters, which can transform the rendered layer texture and thereby move elements inside or outside of existing parent clips.

This should have little to no performance impact, since we should already be generating correct minimal subpass textures based on correct subpass coverage computation.

Before:
<img width="679" alt="Screenshot 2023-10-05 at 1 25 29 PM" src="https://github.com/flutter/engine/assets/919017/fe63808a-6353-4969-8225-120fd5ee0949">

https://github.com/flutter/engine/assets/919017/9284f055-bee1-40cd-8b7e-f478b00d01da

After:
<img width="679" alt="Screenshot 2023-10-05 at 1 24 17 PM" src="https://github.com/flutter/engine/assets/919017/066b1e25-9611-4e14-a383-cc3a866dbe36">

https://github.com/flutter/engine/assets/919017/0fbd1f96-8920-472c-bb0e-4414187fc72d
 2023-10-06 16:05:20 +00:00
skia-flutter-autoroll
8fe1f0c054 Roll Fuchsia Linux SDK from eI_FBTaRgvoBQaK5n... to K7K76tME-CSGhYlFm... (flutter/engine#46614) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-06 10:19:22 +00:00
skia-flutter-autoroll
79c9d6f29e Roll Fuchsia Mac SDK from th0Ks2IEZYh6fe8G5... to 14dOVccxXOO5RPJJB... (flutter/engine#46611) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-06 08:22:53 +00:00
skia-flutter-autoroll
3f74b956bd Roll Fuchsia Linux SDK from bnd4FFub2R9Q4mlAC... to eI_FBTaRgvoBQaK5n... (flutter/engine#46599) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-05 21:28:15 +00:00
skia-flutter-autoroll
7fb3d8e3a5 Roll Fuchsia Mac SDK from -RGP9v0n9shWn5yg1... to th0Ks2IEZYh6fe8G5... (flutter/engine#46593) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-05 19:43:04 +00:00
skia-flutter-autoroll
d5c45015f9 Roll Skia from 09c71755bc6c to 0f2af25f15ee (2 revisions) (flutter/engine#46586) 
https://skia.googlesource.com/skia.git/+log/09c71755bc6c..0f2af25f15ee

2023-10-05 robertphillips@google.com [graphite] Add BlendModeBlenderBlock::AddBlock
2023-10-05 michaelludwig@google.com Reland "Reland "[skif] Draw FilterResults directly for layer restoration""

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-05 14:57:24 +00:00
Kevin Lubick
ec62430ff1 Replace use of Skia's Base64 Encoding/Decoding logic with a copy of the equivalent code (flutter/engine#46543) 
Skia would like to remove SkBase64.h from its public API. This ports the
same functionality into Flutter's codebase with tests.

The implementation was copied from
[Skia](387853af19/src/utils/SkBase64.cpp)
then modified to match Flutter's style and have readable tests.

In a follow-up PR, I would like to add a function to pre-flight the
calculation needed to figure out how many
bytes are needed to be allocated, to avoid the clunky double API
call (see the TODOs).

I chose to put the code in `//shell/common` at the suggestion of Flutter
devs, but it needs to be in its own source_set because it is used in a
few other places (for now) and we want to avoid dependency cycles.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-05 10:21:39 -04:00
skia-flutter-autoroll
2e02f6e6ee Roll Skia from 2be211c972d5 to 09c71755bc6c (1 revision) (flutter/engine#46584) 
https://skia.googlesource.com/skia.git/+log/2be211c972d5..09c71755bc6c

2023-10-05 robertphillips@google.com [graphite] Deduplicate the paint color uniform

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-05 14:11:24 +00:00
skia-flutter-autoroll
ae2bde183b Roll Fuchsia Linux SDK from z_GRSMyHRsHjrpY48... to bnd4FFub2R9Q4mlAC... (flutter/engine#46580) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-05 08:40:23 +00:00
skia-flutter-autoroll
398348bc12 Roll Skia from f0cbcb892b2b to 2be211c972d5 (1 revision) (flutter/engine#46579) 
https://skia.googlesource.com/skia.git/+log/f0cbcb892b2b..2be211c972d5

2023-10-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from ffb323805790 to 3d75b794df0f (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-05 07:30:22 +00:00
skia-flutter-autoroll
2bb3b0ce29 Roll Fuchsia Mac SDK from Q0h8rkXPNpWBnlAnS... to -RGP9v0n9shWn5yg1... (flutter/engine#46578) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-05 07:06:00 +00:00
skia-flutter-autoroll
d6b0e0878c Roll Skia from e9b5e455ff8d to f0cbcb892b2b (1 revision) (flutter/engine#46577) 
https://skia.googlesource.com/skia.git/+log/e9b5e455ff8d..f0cbcb892b2b

2023-10-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from e12f70e0a324 to 98777c2e9e16

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-05 06:05:05 +00:00
skia-flutter-autoroll
0f46365721 Roll Skia from 7e025304e846 to e9b5e455ff8d (1 revision) (flutter/engine#46575) 
https://skia.googlesource.com/skia.git/+log/7e025304e846..e9b5e455ff8d

2023-10-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from c97b5ae9f547 to e12f70e0a324 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-05 05:28:30 +00:00
skia-flutter-autoroll
6d679cd4b5 Roll Skia from 0206ca4badc0 to 7e025304e846 (1 revision) (flutter/engine#46574) 
https://skia.googlesource.com/skia.git/+log/0206ca4badc0..7e025304e846

2023-10-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 548271dcec9f to ff2054861dc4 (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-05 03:51:00 +00:00
skia-flutter-autoroll
33a98127c8 Roll Skia from 10b86aa8d8b7 to 0206ca4badc0 (1 revision) (flutter/engine#46572) 
https://skia.googlesource.com/skia.git/+log/10b86aa8d8b7..0206ca4badc0

2023-10-05 armansito@google.com [graphite][viewer] Context options and UI for path renderer strategy

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-05 03:10:24 +00:00
skia-flutter-autoroll
63c5de19cc Roll Dart SDK from b8fceaea291c to 368fd3846df0 (1 revision) (flutter/engine#46571) 
https://dart.googlesource.com/sdk.git/+log/b8fceaea291c..368fd3846df0

2023-10-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-231.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-05 02:20:21 +00:00
skia-flutter-autoroll
79e76c5a3f Roll Skia from 073737b7f4ab to 10b86aa8d8b7 (1 revision) (flutter/engine#46570) 
https://skia.googlesource.com/skia.git/+log/073737b7f4ab..10b86aa8d8b7

2023-10-04 jvanverth@google.com Disable GrTessellationPathRenderer on webgl with intel driver

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-05 00:55:24 +00:00
Robert Ancell
53d379bfac Use GdkEvent methods to access values, direct access is removed in GTK4. (flutter/engine#46526) 
This should have no effect on the current implementation, and will be
one less thing needed when we migrate to GTK4.
 2023-10-05 13:46:51 +13:00
Chinmay Garde
f98a5c2093 Update buildroot to 5d60bd2. (flutter/engine#46564) 
Pulls in the changes to format GN files.
 2023-10-04 21:57:52 +00:00
Chris Yang
4ccef45a9a [ios] Link PlatformView back to semantics tree (flutter/engine#46471) 
The PlatformView does not have a semantics container when added to semantics tree, this PR gives it a semantics container to ensure accessibility traversal works.

This fixes https://github.com/flutter/flutter/issues/135504, which is a regression of 738b1ad94d

Before 738b1ad94d, the traversal works because the PlatformView is added to the accessibilityElements of the FlutterPlatFormViewSemanticsContainer, which implicitly made the FlutterPlatFormViewSemanticsContainer as the PlatformVIew's AccessibilityContainer. 

Now we use the PlatformVIew as the nativeAccessibility of the  FlutterPlatFormViewSemanticsContainer, we need to expilicitly set the container. 

This needs to be cherry-picked since the commit caused the regression was cherry-picked in 738b1ad94d

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-04 21:41:53 +00:00
skia-flutter-autoroll
93336de8dc Roll Skia from d061d21eed0d to 073737b7f4ab (2 revisions) (flutter/engine#46563) 
https://skia.googlesource.com/skia.git/+log/d061d21eed0d..073737b7f4ab

2023-10-04 egdaniel@google.com Make sure not to share texture allocations for offscreens going to a Vk SecondaryCB.
2023-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from d9ae2b91952e to 548271dcec9f (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-04 21:22:20 +00:00
skia-flutter-autoroll
366ad93925 Roll Skia from b3d65351b9ae to d061d21eed0d (2 revisions) (flutter/engine#46562) 
https://skia.googlesource.com/skia.git/+log/b3d65351b9ae..d061d21eed0d

2023-10-04 armansito@google.com Do not build canvas_state_lib if vello shaders are enabled
2023-10-04 lovisolo@google.com [bazel] Add //bench/BazelBenchmarkRunner.cpp and some sample targets.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-04 20:38:05 +00:00
skia-flutter-autoroll
e546f821df Roll Dart SDK from 49561debc8d4 to b8fceaea291c (1 revision) (flutter/engine#46559) 
https://dart.googlesource.com/sdk.git/+log/49561debc8d4..b8fceaea291c

2023-10-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-230.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-04 20:01:23 +00:00
skia-flutter-autoroll
e93228e61f Roll Fuchsia Linux SDK from tpiob-Qyh6oYiIznS... to z_GRSMyHRsHjrpY48... (flutter/engine#46557) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-04 19:51:14 +00:00
skia-flutter-autoroll
abd2c03ede Roll Skia from f6b7864d0325 to b3d65351b9ae (1 revision) (flutter/engine#46556) 
https://skia.googlesource.com/skia.git/+log/f6b7864d0325..b3d65351b9ae

2023-10-04 robertphillips@google.com [graphite]  Remove initial colorshader from PaintKey

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-04 19:26:00 +00:00
skia-flutter-autoroll
10705b9fba Roll Skia from 49657f39d457 to f6b7864d0325 (5 revisions) (flutter/engine#46554) 
https://skia.googlesource.com/skia.git/+log/49657f39d457..f6b7864d0325

2023-10-04 kjlubick@google.com Disable `__google_cxa_guard_acquire` on Windows as it is POSIX specific
2023-10-04 robertphillips@google.com [graphite] Allow zero Paint uniforms
2023-10-04 robertphillips@google.com [graphite] Add SolidColorShader::AddBlock
2023-10-04 drott@chromium.org Enable VSCode rust-analyzer to find Fontations project
2023-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c572662924c3 to d9ae2b91952e (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-04 18:42:00 +00:00
skia-flutter-autoroll
a8822bd949 Roll Fuchsia Mac SDK from pzOoo5Zcrqst6Cl3X... to Q0h8rkXPNpWBnlAnS... (flutter/engine#46553) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-04 18:25:33 +00:00
skia-flutter-autoroll
0e412f42d1 Roll Skia from 387853af198f to 49657f39d457 (1 revision) (flutter/engine#46544) 
https://skia.googlesource.com/skia.git/+log/387853af198f..49657f39d457

2023-10-04 robertphillips@google.com [graphite] Add ImageShaderBlock::AddBlock

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-04 14:22:24 +00:00
skia-flutter-autoroll
0ef3eadf87 Roll Dart SDK from 8c7e38cd3903 to 49561debc8d4 (1 revision) (flutter/engine#46540) 
https://dart.googlesource.com/sdk.git/+log/8c7e38cd3903..49561debc8d4

2023-10-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-229.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-04 09:21:23 +00:00
skia-flutter-autoroll
a10f7ea6c5 Roll Skia from 8d45e7f1d4a4 to 387853af198f (1 revision) (flutter/engine#46539) 
https://skia.googlesource.com/skia.git/+log/8d45e7f1d4a4..387853af198f

2023-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from f29f73d9f063 to ffb323805790 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-04 08:55:15 +00:00
Brandon DeRosier
1cbd273449 [Impeller] Clarify coverage space. (flutter/engine#46524) 
Update the coverage docstrings to clarify which space the coordinates are given in. Up until now, I've been using the phrase "screen space" to convey that coverage is counted in framebuffer pixels and is unaffected by the subpass transform basis. But a more accurate way to describe this would be "pass space", since it counts pixels relative to the top left corner of the framebuffer that the Entity is being drawn to during rendering.
 2023-10-04 06:27:23 +00:00
skia-flutter-autoroll
d051a85e47 Roll Skia from 417a6383c59a to 8d45e7f1d4a4 (2 revisions) (flutter/engine#46537) 
https://skia.googlesource.com/skia.git/+log/417a6383c59a..8d45e7f1d4a4

2023-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from c97b5ae9f547 to e12f70e0a324
2023-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 0387aac67124 to c97b5ae9f547 (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-04 06:16:05 +00:00
skia-flutter-autoroll
3c0802921c Roll Fuchsia Mac SDK from d4QNzZ6FjCCXUQtkT... to pzOoo5Zcrqst6Cl3X... (flutter/engine#46536) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-04 05:46:18 +00:00
skia-flutter-autoroll
d8f4c3734c Roll Dart SDK from c819e51c8a94 to 8c7e38cd3903 (1 revision) (flutter/engine#46534) 
https://dart.googlesource.com/sdk.git/+log/c819e51c8a94..8c7e38cd3903

2023-10-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-228.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-04 05:33:06 +00:00
skia-flutter-autoroll
8eebb6fdf7 Roll Skia from aec80c6c8983 to 417a6383c59a (1 revision) (flutter/engine#46533) 
https://skia.googlesource.com/skia.git/+log/aec80c6c8983..417a6383c59a

2023-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 5b6f768198ce to 400ac3a175a6 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-04 05:25:08 +00:00
skia-flutter-autoroll
01f56591bd Roll Fuchsia Linux SDK from SQrHxRVqMo5arcS3p... to tpiob-Qyh6oYiIznS... (flutter/engine#46532) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-04 04:34:19 +00:00
Jia Hao
c2eecba786 [Impeller] Don't define CanvasRecorder if IMPELLER_TRACE_CANVAS is not set. (flutter/engine#46476) 
Internal bug: b/303067268

https://github.com/flutter/engine/pull/46376 is causing a breakage to the internal engine build because of 543348a044/impeller/aiks/canvas_recorder.h (L58-L62). Internally, we do not set `IMPELLER_TRACE_CANVAS`.

It looks like the cause is that the internal toolchain causes the `static_assert` to be compiled even though the template is not instantiated.

@chingjun helped me to figure out the following:

https://stackoverflow.com/questions/5246049/c11-static-assert-and-template-instantiation points us to the spec. In the later version (ISO/IEC 14882:2017(E)):

> The program is ill-formed, no diagnostic required, if ... no valid specialization can be generated for a template or a substatement of a constexpr if statement (9.4.1) within a template and the template is not instantiated,

<details>

<summary>The relevant section</summary>

![The relevant section of the spec](https://github.com/flutter/engine/assets/7111741/4503efcd-9479-4c7a-b4a1-7302dea1653b)

</details>

Interpretation: the compiler can either choose to emit the error caused by the `static_assert` or not. Currently the compiler used by the build here on LUCI does not; internally it does.

For example, the following links shows that simply changing the Clang version affects whether the error appears or not for a minimal template.

- ok: https://godbolt.org/z/n9nYrcvcP
- not ok: https://godbolt.org/z/fWcvdcn35

Hence, `#ifdef` out the class instead of using a `static_assert` for more consistent behavior across these two toolchains.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-04 02:29:17 +00:00
skia-flutter-autoroll
7593a5be16 Roll Dart SDK from 817f77ceba40 to c819e51c8a94 (1 revision) (flutter/engine#46529) 
https://dart.googlesource.com/sdk.git/+log/817f77ceba40..c819e51c8a94

2023-10-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-227.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-04 01:51:18 +00:00
skia-flutter-autoroll
e21459b45f Roll Skia from ee415cab7955 to aec80c6c8983 (1 revision) (flutter/engine#46528) 
https://skia.googlesource.com/skia.git/+log/ee415cab7955..aec80c6c8983

2023-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5d68d7e207a5 to c572662924c3 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-04 01:19:49 +00:00
skia-flutter-autoroll
78f89e11cd Roll Skia from 4cc56b6b3453 to ee415cab7955 (1 revision) (flutter/engine#46527) 
https://skia.googlesource.com/skia.git/+log/4cc56b6b3453..ee415cab7955

2023-10-03 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll ANGLE from 1cab871c2207 to f29f73d9f063 (20 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-03 23:48:07 +00:00
skia-flutter-autoroll
aba0fcf6c5 Roll Skia from c66c89c56549 to 4cc56b6b3453 (1 revision) (flutter/engine#46525) 
https://skia.googlesource.com/skia.git/+log/c66c89c56549..4cc56b6b3453

2023-10-03 jvanverth@google.com Move some functionality for PathAtlas into Compute and Raster.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-03 22:51:04 +00:00
Matan Lurey
b6dfcba94b [Impeller] Implement a MockGLES, that provides trampolines for ProcGLESTable (flutter/engine#46433) 
Unblocks testing https://github.com/flutter/flutter/issues/135715. See
`README.md` for details.

I made one non-testing change to the proc_table itself, which is if a
function call will fail, we will print out what is about to fail in the
validation log. It was useful when debugging the test creation itself,
and it's only enabled when GL call checks are enabled anyway.

@gaaclarke I originally implemented it with `FML_THREAD_LOCAL`, but
figured doing a global lock essentially was the same thing, and would
prevent parallel test runs from stepping on each-other in weird ways?

/cc @chinmaygarde for visibility.
 2023-10-03 16:23:25 -06:00
Matan Lurey
217689a9c0 [Impeller] Invoke glDebugMessageControl before glPushDebugGroup (flutter/engine#46392) 
Closes https://github.com/flutter/flutter/issues/135715.

I plan to add tests before submitting once
https://github.com/flutter/engine/pull/46433 lands, probably something
around `glDebugMessageControl` being emitted once per context, since
that's what we need to keep working for Pixel phones.

## Output

<details>

<summary>Screenshot of app running locally, showing lack of off-screen
MSAA</summary>


![flutter_01](https://github.com/flutter/engine/assets/168174/23642582-ce4c-47dc-8edf-7e6cfd12a074)

</details>

```shell
$ fl run --enable-impeller --local-engine=$ENGINE/out/android_debug_unopt_arm64 --local-engine-host=$ENGINE/out/host_debug_unopt_arm64

Launching lib/main.dart on Pixel 5 in debug mode...
Running Gradle task 'assembleDebug'...                             33.7s
✓  Built build/app/outputs/flutter-apk/app-debug.apk.
Installing build/app/outputs/flutter-apk/app-debug.apk...          17.8s
E/flutter (17749): [ERROR:flutter/shell/platform/android/android_context_gl_impeller.cc(80)] Using the Impeller rendering backend (OpenGLES).
Syncing files to device Pixel 5...                                  70ms

Flutter run key commands.
r Hot reload. 🔥🔥🔥
R Hot restart.
h List all available interactive commands.
d Detach (terminate "flutter run" but leave application running).
c Clear the screen
q Quit (terminate the application on the device).

A Dart VM Service on Pixel 5 is available at: http://127.0.0.1:57181/CrsakIgCHFY=/
I/cle_opacity_foo(17749): Compiler allocated 4413KB to compile void android.view.ViewRootImpl.performTraversals()
The Flutter DevTools debugger and profiler on Pixel 5 is available at:
http://127.0.0.1:9101?uri=http://127.0.0.1:57181/CrsakIgCHFY=/
```
 2023-10-03 16:14:20 -06:00
skia-flutter-autoroll
f9e1cae064 Roll Dart SDK from 318c46832196 to 817f77ceba40 (1 revision) (flutter/engine#46520) 
https://dart.googlesource.com/sdk.git/+log/318c46832196..817f77ceba40

2023-10-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-226.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-03 22:11:32 +00:00
Matan Lurey
90595b5afa Opt out flutter/third_party/** from clang-tidy checks explicitly. (flutter/engine#46514) 
See https://github.com/flutter/flutter/issues/134969.

/cc @zanderso
 2023-10-03 22:06:09 +00:00