Reid Baker
17960e7c1e
Ignore cxx folders for all of flutter/flutter ( #160381 )
...
Related to https://github.com/flutter/flutter/issues/160372
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2024-12-16 21:38:55 +00:00
engine-flutter-autoroll
cff545c9f9
Roll Flutter Engine from d373a934d413 to 0dfbd04106ed (5 revisions) ( #160376 )
...
d373a934d4...0dfbd04106skia-flutter-autoroll@skia.org Roll Skia from 8c1e2bf9492c to
8054b098b5cd (5 revisions) (flutter/engine#57197 )
2024-12-16 goderbauer@google.com Reland 'Delete stale
package_config.json in gclient sync hook' (flutter/engine#57218 )
2024-12-16 MyriadSoft@users.noreply.github.com docs: Fix RGB565 format
documentation and bit masks (flutter/engine#57210 )
2024-12-16 jonahwilliams@google.com [Impeller] disable AHB swapchains on
all platforms. (flutter/engine#57213 )
2024-12-16 jonahwilliams@google.com [Impeller] fix Adreno precision
issue in gaussian downsample. (flutter/engine#57212 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-16 21:16:21 +00:00
Andrew Kolos
c803c1346f
Remove more references to deprecated package:usage (executable, runner) ( #160369 )
...
Helps https://github.com/flutter/flutter/issues/150575
<details>
<summary> Pre-launch checklist </summary>
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
</details>
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-12-16 20:39:43 +00:00
Flutter GitHub Bot
98e5ce7ed7
Marks Linux_android_emu android_defines_test to be unflaky ( #159538 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_android_emu android_defines_test"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android_emu%20android_defines_test%22 ).
This test can be marked as unflaky.
2024-12-16 20:12:03 +00:00
Gray Mackall
b19b68074f
Fix regression to hardcoded AGP/Kotlin values in Android module templates ( #160108 )
...
https://github.com/flutter/flutter/pull/159770 regressed the module
templates to use a hardcoded `8.7.0` and `1.8.22` as the AGP and Kotlin
versions respectively. This PR returns them to using the template
context values.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <mackall@google.com>
2024-12-16 19:59:00 +00:00
Alex Li
a0f2424e2e
🐛 [tool] Do not handle directory arguments implicitly for pub commands ( #160223 )
...
- Resolves https://github.com/flutter/flutter/issues/144898
- Resolves https://github.com/flutter/flutter/issues/160145
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-12-16 19:55:04 +00:00
Christopher Fujino
2bda0ccc75
re-enable linux packages-autoroller ( #160266 )
...
I fixed the autoroller in https://github.com/flutter/flutter/pull/160059
but forgot to mark the shard non-bring-up. Note, it's currently failing
in post-submit, but only because bringUp shards run in the staging pool,
which does not have access to the GitHub access token necessary for the
roller to operate.
2024-12-16 19:51:25 +00:00
Michael Goderbauer
55d7341a66
Formatter pre-work: Fix syntax in test_fixes ( #160371 )
...
* removes an extra `)` in `app_bar.dart`
* Moves class definitions and getter definition out of the `main` method
in `widget_state.dart` (defining classes/getters inside of methods is
not allowed in Dart)
The formatter was stumbling over these syntax errors.
2024-12-16 19:50:40 +00:00
engine-flutter-autoroll
fbb312169c
Roll Packages from 56886ffe11ad to eb7358231e43 (6 revisions) ( #160351 )
...
56886ffe11...eb7358231eflutter/packages#8306 )
2024-12-14 engine-flutter-autoroll@skia.org Manual roll Flutter from
6966a2eef1e9 to 29a6c648ca4d (16 revisions) (flutter/packages#8295 )
2024-12-13 jessiewong401@gmail.com Bump Camera Example Plugin Apps
Targetsdk Versions (flutter/packages#8193 )
2024-12-13 astivi@users.noreply.github.com [google_adsense] Adds H5
Games Ads support to package. (flutter/packages#7747 )
2024-12-13 cepadilla@google.com [camera_android_camerax] Remove nonnull
annotation from getDefaultPointSize (flutter/packages#8292 )
2024-12-13 tarrinneal@gmail.com [shared_preferences] Adds Shared
preferences as option in shared preferences async android
(flutter/packages#7994 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-16 19:49:00 +00:00
engine-flutter-autoroll
6b6227e6c3
Roll Flutter Engine from 330210f44aa6 to d373a934d413 (1 revision) ( #160356 )
...
330210f44a...d373a934d4jason-simmons@users.noreply.github.com Disable RBE in the GN
flags for wasm_release builds in the linux_web_engine builder
(flutter/engine#57204 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-16 19:49:00 +00:00
Matan Lurey
daaceacb30
Fix a bug to skip flutter_gen when synthetic packages are disabled ( #160367 )
...
Without this bug fix, when flipping the flag a lot of things blow up :)
(https://github.com/flutter/flutter/pull/160289 as an example of needing
this)
2024-12-16 19:33:34 +00:00
Matan Lurey
1c52436853
Skip integration tests that consistently OOM on a Windows platform. ( #160368 )
...
Towards https://github.com/flutter/flutter/issues/157640 .
As far as I can tell, these test cases add no value to be running
specifically on Windows (they are testing general tool functionality),
and it's on [Windows specifically that the tests have the most problems
with OOM and
timeout](https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Windows%20tool_integration_tests_2_9 ).
2024-12-16 19:14:58 +00:00
engine-flutter-autoroll
ad4a1212dc
Roll Flutter Engine from 159090f6f40f to 330210f44aa6 (1 revision) ( #160323 )
...
159090f6f4...330210f44arobert.ancell@canonical.com Migrate FlEventChannel tests to
FlMockBinaryMessenger (flutter/engine#57150 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-16 00:55:26 +00:00
engine-flutter-autoroll
68a57709d8
Roll Flutter Engine from a9f7fa8ca613 to 159090f6f40f (1 revision) ( #160321 )
...
a9f7fa8ca6...159090f6f4robert.ancell@canonical.com Migrate FlMethodChannel tests to
FlMockBinaryMessenger (flutter/engine#57146 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-15 23:18:32 +00:00
Mohammed CHAHBOUN
a4be7cd70a
Added Mohammed Chahboun to authors ( #160311 )
...
Adds [Mohammed
Chahboun](https://github.com/flutter/flutter/pulls/M97Chahboun ) to
authors
2024-12-15 17:46:19 +00:00
engine-flutter-autoroll
7877a076a6
Roll Flutter Engine from 4e4a430bcd0d to a9f7fa8ca613 (1 revision) ( #160294 )
...
4e4a430bcd...a9f7fa8ca6goderbauer@google.com Adjust some ignores for 'dart format'
(flutter/engine#57208 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-14 03:46:08 +00:00
engine-flutter-autoroll
fc9124cb4f
Roll Flutter Engine from c4e3cc27afef to 4e4a430bcd0d (2 revisions) ( #160291 )
...
c4e3cc27af...4e4a430bcdgoderbauer@google.com Fix include path in fuchsia's
analysis_options.yaml files (flutter/engine#57203 )
2024-12-13 goderbauer@google.com Delete stale package_config.json in
gclient sync hook (flutter/engine#57195 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-14 02:47:38 +00:00
engine-flutter-autoroll
e7fcd0d6e6
Roll Flutter Engine from f0ff4f25bda8 to c4e3cc27afef (5 revisions) ( #160290 )
...
f0ff4f25bd...c4e3cc27afjason-simmons@users.noreply.github.com [skwasm] Fix
implementation of SkwasmPath.relativeLineTo (flutter/engine#57201 )
2024-12-13 30870216+gaaclarke@users.noreply.github.com Made compilation
error colors come through et. (flutter/engine#57174 )
2024-12-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
iWMEbVYaNdH8RJmXZ... to iYz_WkWk1uPr8BLSZ... (flutter/engine#57198 )
2024-12-13 yjbanov@google.com [web] allow imports to line-break
(flutter/engine#57170 )
2024-12-13 41930132+hellohuanlin@users.noreply.github.com [ios]limit web
view not tappable workaround to a limited depth (flutter/engine#57193 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from iWMEbVYaNdH8 to iYz_WkWk1uPr
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-14 01:47:26 +00:00
Matan Lurey
0875988f5f
Migrate flutter_command_test.dart to explicit-package-dependencies. ( #160274 )
...
Work towards https://github.com/flutter/flutter/issues/160257 .
2024-12-14 00:08:28 +00:00
Matan Lurey
5e7c856d5b
Migrate test/general.shard/*plugin* tests to explicit-package-dependencies. ( #160279 )
...
Towards https://github.com/flutter/flutter/issues/160257 .
2024-12-13 23:18:07 +00:00
Matan Lurey
14177eaa7c
Migrate the rest of general.shard to explicit-package-dependencies. ( #160280 )
...
Towards https://github.com/flutter/flutter/issues/160257 .
2024-12-13 23:14:22 +00:00
Matan Lurey
b008e5b60c
Migrate resident_web_runner_test.dart to explicit-package-dependencies. ( #160278 )
...
Work towards https://github.com/flutter/flutter/issues/160257 .
2024-12-13 22:56:05 +00:00
Matan Lurey
15517f0569
Migrate hot_test.dart to explicit-package-dependencies. ( #160277 )
...
Work towards https://github.com/flutter/flutter/issues/160257 .
2024-12-13 22:43:21 +00:00
Matan Lurey
6bcb15db63
Migrate cocoapods_test.dart to explicit-package-dependencies. ( #160264 )
...
Work towards https://github.com/flutter/flutter/issues/160257 .
2024-12-13 22:37:08 +00:00
Matan Lurey
96aeed4591
Migrate test/general.shard/build_system to explicit-package-dependencies. ( #160275 )
...
Work towards https://github.com/flutter/flutter/issues/160257 .
2024-12-13 22:30:38 +00:00
Matan Lurey
61025ca2dd
Migrate test/general.shard/web to explicit-package-dependencies. ( #160273 )
...
Work towards https://github.com/flutter/flutter/issues/160257 .
2024-12-13 22:22:21 +00:00
Matan Lurey
5332e696a4
Migrate generate_synthetic_packages_test.dart to explicit-package-dependencies. ( #160267 )
...
Work towards https://github.com/flutter/flutter/issues/160257 .
Unlike some of the other PRs, this test explicitly _opts-out_ of the
flag, as the test itself is testing whether the now deprecated feature
works.
2024-12-13 22:22:12 +00:00
Matan Lurey
47403e351e
Migrate test_compiler_test.dart to explicit-package-dependencies. ( #160265 )
...
Work towards https://github.com/flutter/flutter/issues/160257 .
2024-12-13 22:21:58 +00:00
Matan Lurey
1e2322c080
Enable explicit-package-dependencies (resident_web_runner_cold_test.dart) ( #160258 )
...
Example of option (2) for
https://github.com/flutter/flutter/issues/160257 .
2024-12-13 21:14:20 +00:00
Gray Mackall
2948917a47
[Reland] Force automatic ndk download when building for Android ( #160260 )
...
Relands https://github.com/flutter/flutter/pull/159756 .
The original caused some stderr because
1. the configurable `ndkVersion` value that AGP provides used to be null
by default.
2. Now it is not, instead it has a default value
3. `integration_test` doesn't actually use the NDK, but default for
`integration_test` was higher that `flutter.ndkVersion`
4. We have code that checks if a plugin uses a higher ndk version and
tells you to consider upgrading
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy#L921
This reverts the revert, and then aligns `integration_test`'s NDK
version (which again, it doesn't actually use, so I'm not too concerned
about the downgrade) with `flutter.ndkVersion`.
It also starts using the `flutter.min/compile/ndkVersion` values in
`integration_test`, which was unrelated to the original pr. Can remove
if you think it should land separately.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <mackall@google.com>
2024-12-13 20:27:23 +00:00
Christopher Fujino
29a6c648ca
precompile generate_gradle_lockfile script BEFORE updating pub dependencies ( #160059 )
...
Avoid situations like https://github.com/flutter/flutter/issues/160055
2024-12-13 19:43:25 +00:00
chunhtai
82ecbb5cbd
Refactor gradle task runner to share error handler code ( #159452 )
...
fixes https://github.com/flutter/flutter/issues/153893
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
2024-12-13 18:51:20 +00:00
engine-flutter-autoroll
08b2e23e2e
Roll Flutter Engine from 3c263a38f56b to f0ff4f25bda8 (1 revision) ( #160254 )
...
3c263a38f5...f0ff4f25bdsstrickl@google.com Add entry-point annotations for test-only
code. (flutter/engine#57158 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-13 18:31:29 +00:00
Nate Wilson
7aa4d2d3ec
Fix Stepper connector not being properly displayed ( #160193 )
...
@ayyoub-coder gave a fantastic summary of the problem in #160177 : if a
`Container` doesn't have a child or unbounded constraints, it will
expand to fill its parent, whereas a `ColoredBox` defaults to zero size.
I also noticed that in the main branch, the `PositionedDirectional`
widget has an unused `width` parameter, and instead builds a `SizedBox`
child for it.
This pull request cleans up the `Stepper` subtree a bit and allows the
connector to display properly.
fixes #160156
2024-12-13 16:26:26 +00:00
engine-flutter-autoroll
335300d9da
Roll Packages from cbdb48a0bcee to 56886ffe11ad (6 revisions) ( #160245 )
...
cbdb48a0bc...56886ffe11rjs580@usask.ca [webview_flutter_android] Allow configuration
of WebView file access through `setAllowFileAccess`
(flutter/packages#8228 )
2024-12-13 32538273+ValentinVignal@users.noreply.github.com
[go_router_builder] Activate leak testing (flutter/packages#8059 )
2024-12-12 ultraon83@gmail.com [go_router] Fix a typo in a comment in
the shell_route.dart (flutter/packages#8235 )
2024-12-12 stuartmorgan@google.com [ci] Update for 3.27 stable release
(flutter/packages#8284 )
2024-12-12 engine-flutter-autoroll@skia.org Manual roll Flutter from
f559e16010a0 to 6966a2eef1e9 (5 revisions) (flutter/packages#8283 )
2024-12-12 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
dec2ee5c1f98 to 8495dee1fd4a (1318 revisions) (flutter/packages#8280 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-13 15:44:27 +00:00
Bruno Leroux
eaf74bdd11
Fix NavigationDrawerDestination backgroundColor obscures interactions ( #160239 )
...
## Description
This PR fixes `NavigationDrawerDestination.backgroundColor` obscuring
ink well splashes and overlay.
Before this PR the destination background color was renderer in a
`ColoredBox` which hides the ink well effects. This PR replaces the
`ColorsBox` with an `Ink`.
## Related Issue
Fixes [NavigationDrawerDestination backgroundColor obscures interaction
states](https://github.com/flutter/flutter/issues/160109 )
## Tests
Updates 1 test.
2024-12-13 12:06:28 +00:00
engine-flutter-autoroll
26ea690af8
Roll Flutter Engine from b9df033311cc to 3c263a38f56b (1 revision) ( #160238 )
...
b9df033311...3c263a38f5skia-flutter-autoroll@skia.org Roll Skia from 0aec6f7bfbc8 to
8c1e2bf9492c (26 revisions) (flutter/engine#57183 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-13 09:26:25 +00:00
engine-flutter-autoroll
56d26118d6
Roll Flutter Engine from 5eedfefe38c1 to b9df033311cc (1 revision) ( #160233 )
...
5eedfefe38...b9df033311flar@google.com Migrate DlRTree and DlRegion to
DisplayList/Impeller geometry classes (flutter/engine#57175 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-13 06:41:22 +00:00
engine-flutter-autoroll
6a5445833b
Roll Flutter Engine from 9b51e30a4d37 to 5eedfefe38c1 (12 revisions) ( #160220 )
...
9b51e30a4d...5eedfefe38flar@google.com Normalize round rect bounds when coming from
Flutter (flutter/engine#57171 )
2024-12-13 41930132+hellohuanlin@users.noreply.github.com [ios]enable
the webview non tappable workaround by checking subviews recursively
(flutter/engine#57168 )
2024-12-12 30870216+gaaclarke@users.noreply.github.com removed c style
casts and enabled the lint (flutter/engine#57162 )
2024-12-12 jonahwilliams@google.com [Impeller] exploit perfect hash for
SamplerDescriptor. (flutter/engine#57036 )
2024-12-12 30870216+gaaclarke@users.noreply.github.com Reenabled
labelling test with a capabilities check. (flutter/engine#57160 )
2024-12-12 jonahwilliams@google.com [Impeller] dont print format strings
for blend filter and snapshots. (flutter/engine#57105 )
2024-12-12 robert.ancell@canonical.com Make fl_engine_send_key_event
into a standard async function. (flutter/engine#57112 )
2024-12-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
HJ57Y3zxqDamI8qkY... to iWMEbVYaNdH8RJmXZ... (flutter/engine#57163 )
2024-12-12 robert.ancell@canonical.com Migrate FlPlatformChannel tests
to FlMockBinaryMessenger (flutter/engine#57140 )
2024-12-12 robert.ancell@canonical.com Migrate FlBasicMessageChannel
tests to FlMockBinaryMessenger (flutter/engine#57115 )
2024-12-12 flar@google.com Migrate layers and layer_tree to
DisplayList/Impeller geometry classes (flutter/engine#57153 )
2024-12-12 mdebbar@google.com [web] Use CanvasKit to run tests under
engine/ (flutter/engine#54786 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from HJ57Y3zxqDam to iWMEbVYaNdH8
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-13 03:53:26 +00:00
Mohammed CHAHBOUN
9742656610
Adds splashBorderRadius property to TabBarTheme ( #160046 )
...
Adds splashBorderRadius property to TabBarTheme
Fix #159845
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
---------
Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
2024-12-12 23:52:19 +00:00
auto-submit[bot]
5cd440f6ec
Reverts "Force automatic ndk download when building for Android ( #159756 )" ( #160205 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#159756
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: gmackall
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Made the tree red due to some std out.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: gmackall
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {reidbaker}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
In preparation for changing engine builds to be unstripped by default
https://github.com/flutter/engine/pull/52852 , which will allow us to
make progress towards resolving
https://github.com/flutter/flutter/issues/60240 .
Tricks AGP in to downloading the NDK when building a flutter app (that
uses the FGP, which to my knowledge is all ways of building flutter
apk/aab/aar).
I want to follow this up by modifying the tool to search for the log
line that the NDK is missing (making it throw an error in that case) as
a safeguard, because that would be the last line of defense before we
accidentally build a bloated app. The safeguard won't work for add to
app, from what I understand, because while they use the FGP (so they
should be forced to be download the NDK) they don't invoke the flutter
tool, and therefore won't invoke the custom error handling of
[`gradle_errors.dart`](https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/android/gradle_errors.dart )
Some details
1. Respects existing values for `externalNativeBuild.cmake.path` for
apps that actually use it.
2. Silences some warnings that would otherwise appear for add to app
builds or builds that manually invoke gradle:
```
C/C++: CMake Warning (dev) in CMakeLists.txt:
C/C++: No project() command is present. The top-level CMakeLists.txt file must
C/C++: contain a literal, direct call to the project() command. Add a line of
C/C++: code such as
C/C++: project(ProjectName)
C/C++: near the top of the file, but after cmake_minimum_required().
C/C++: CMake is pretending there is a "project(Project)" command on the first
C/C++: line.
C/C++: This warning is for project developers. Use -Wno-dev to suppress it.
C/C++: CMake Warning:
C/C++: Manually-specified variables were not used by the project:
C/C++: CMAKE_EXPORT_COMPILE_COMMANDS
C/C++: CMAKE_LIBRARY_OUTPUT_DIRECTORY
C/C++: CMAKE_RUNTIME_OUTPUT_DIRECTORY
```
3. Our ci installs the NDK at an abnormal place that AGP can't find
without help. I've modified all the `build.gradle`s that we have checked
in to point to the pre-installed path. **But some of our tests make a
new app from the templates, and those tests will now start downloading
the NDK** (as they won't be able to find it at it's current path from
templates). We could resolve this by actually fixing
https://github.com/flutter/flutter/issues/136666 . This would be a very
significant lift from what I understand - we rely on this hardcoding in
a lot of places in our infra.
Fixes https://github.com/flutter/flutter/issues/155576
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2024-12-12 23:44:26 +00:00
Gray Mackall
99786b413f
Force automatic ndk download when building for Android ( #159756 )
...
In preparation for changing engine builds to be unstripped by default
https://github.com/flutter/engine/pull/52852 , which will allow us to
make progress towards resolving
https://github.com/flutter/flutter/issues/60240 .
Tricks AGP in to downloading the NDK when building a flutter app (that
uses the FGP, which to my knowledge is all ways of building flutter
apk/aab/aar).
I want to follow this up by modifying the tool to search for the log
line that the NDK is missing (making it throw an error in that case) as
a safeguard, because that would be the last line of defense before we
accidentally build a bloated app. The safeguard won't work for add to
app, from what I understand, because while they use the FGP (so they
should be forced to be download the NDK) they don't invoke the flutter
tool, and therefore won't invoke the custom error handling of
[`gradle_errors.dart`](https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/android/gradle_errors.dart )
Some details
1. Respects existing values for `externalNativeBuild.cmake.path` for
apps that actually use it.
2. Silences some warnings that would otherwise appear for add to app
builds or builds that manually invoke gradle:
```
C/C++: CMake Warning (dev) in CMakeLists.txt:
C/C++: No project() command is present. The top-level CMakeLists.txt file must
C/C++: contain a literal, direct call to the project() command. Add a line of
C/C++: code such as
C/C++: project(ProjectName)
C/C++: near the top of the file, but after cmake_minimum_required().
C/C++: CMake is pretending there is a "project(Project)" command on the first
C/C++: line.
C/C++: This warning is for project developers. Use -Wno-dev to suppress it.
C/C++: CMake Warning:
C/C++: Manually-specified variables were not used by the project:
C/C++: CMAKE_EXPORT_COMPILE_COMMANDS
C/C++: CMAKE_LIBRARY_OUTPUT_DIRECTORY
C/C++: CMAKE_RUNTIME_OUTPUT_DIRECTORY
```
3. Our ci installs the NDK at an abnormal place that AGP can't find
without help. I've modified all the `build.gradle`s that we have checked
in to point to the pre-installed path. **But some of our tests make a
new app from the templates, and those tests will now start downloading
the NDK** (as they won't be able to find it at it's current path from
templates). We could resolve this by actually fixing
https://github.com/flutter/flutter/issues/136666 . This would be a very
significant lift from what I understand - we rely on this hardcoding in
a lot of places in our infra.
Fixes https://github.com/flutter/flutter/issues/155576
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <mackall@google.com>
2024-12-12 23:23:29 +00:00
Tong Mu
c16aa2d232
Make animation and router support simulation, and use Spring for Cupertino ( #155575 )
...
This PR makes `TransitionRoute` support driving the animation with
`Simulation`. This is needed for Cupertino widgets, since iOS use
"spring simulations" for a majority of their animations.
This PR also applies the standard spring animation to
`CupertinoDialogRoute` (alert dialogs) and `CupertinoModalPopupRoute`
(action sheets). (This PR does not yet support customizing the spring
parameters or conveniently using the springs for custom routes, which
are left for future PRs.)
### Comparison
I tried to create a comparison video for action sheets, however the
difference is far less noticeable than I expected. (All clips are
precisely aligned at the moment the pointer is lifted.) I guess the
original curve _is_ good enough. Nevertheless, the spring simulation is
the correct one and we should support it.
Edit: [The
comment](https://github.com/flutter/flutter/pull/155575#issuecomment-2489303282 )
below also mentioned that supporting spring animation will improve the
fidelity when the animation is caused by a user gesture. I assume this
requires initial speed, which is not supported by this PR but we can add
it in the future.
https://github.com/user-attachments/assets/06d2f684-ad1c-4a4d-8663-a561895f45e9
Also, Flutter's response seems to be always a moment slower than
SwiftUI, possibly because Flutter requiring two frames to start the
animation (one frame to add the transition widget, one frame for the
animation to actually progress.) We probably want to solve it in the
future.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-12-12 21:56:11 +00:00
Mouad Debbar
dd437c7a60
[web] Enable platform view benchmarks in Skwasm ( #160186 )
...
Skwasm has support for platform views already. Let's enable those
benchmarks.
2024-12-12 20:32:27 +00:00
engine-flutter-autoroll
688dee4c61
Roll Flutter Engine from 0bcea845cd31 to 9b51e30a4d37 (4 revisions) ( #160190 )
...
0bcea845cd...9b51e30a4dchris@bracken.jp iOS: Reduce engine/view controller coupling
(flutter/engine#57151 )
2024-12-12 skia-flutter-autoroll@skia.org Roll Dart SDK from
770ff2b085fc to 02aa27c6a075 (1 revision) (flutter/engine#57161 )
2024-12-12 goderbauer@google.com Format _empty.dart
(flutter/engine#57144 )
2024-12-12 jason-simmons@users.noreply.github.com [Impeller] Fix a race
in the ReactorGLES.PerThreadOperationQueues test (flutter/engine#57147 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-12 20:19:55 +00:00
Andrew Kolos
6b12651419
Fix analytics enabled/disabled event not being sent when the user enables/disables analytics ( #160060 )
...
Fixes https://github.com/flutter/flutter/issues/160058 .
In addition, only send an event when the enabled-state of analytics
actually gets flipped.
<details>
<summary> Pre-launch checklist </summary>
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
</details>
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-12-12 19:59:50 +00:00
engine-flutter-autoroll
6966a2eef1
Roll Packages from 16616ad588d7 to cbdb48a0bcee (4 revisions) ( #160170 )
...
16616ad588...cbdb48a0bcengine-flutter-autoroll@skia.org Manual roll Flutter from
918b2b9ddb43 to f559e16010a0 (4 revisions) (flutter/packages#8277 )
2024-12-12 tarrinneal@gmail.com disable maps test and manual roll
(flutter/packages#8275 )
2024-12-11 sinyuper@gmail.com [quick_actions] add localizedSubtitle for
iOS (flutter/packages#8038 )
2024-12-11 napoleon.na1120@gmail.com [video_player_avfoundation] Support
the audio-only HLS (.m3u8) on iOS (flutter/packages#7890 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-12 16:52:10 +00:00
engine-flutter-autoroll
d085381da9
Roll Flutter Engine from 4d8488f02cd8 to 0bcea845cd31 (1 revision) ( #160171 )
...
4d8488f02c...0bcea845cdskia-flutter-autoroll@skia.org Roll Dart SDK from
70062c353404 to 770ff2b085fc (2 revisions) (flutter/engine#57159 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-12 16:44:26 +00:00
Tess Strickland
efa109d405
Add entry-point annotations for test-only code. ( #160158 )
...
This change adds entry-point annotations to methods and classes accessed
by native code during Flutter tests. Currently, entry point annotations
are not checked by the Dart VM when running in JIT mode, only in AOT
mode. In order to also enforce entry point annotations in JIT mode,
first tests in Flutter must be appropriately annotated to avoid roll
failures.
Related issues:
* https://github.com/flutter/flutter/issues/118608
* https://github.com/dart-lang/sdk/issues/50649
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-12-12 13:46:38 +00:00
engine-flutter-autoroll
2d3ff85559
Roll Flutter Engine from 847deb2089a3 to 4d8488f02cd8 (2 revisions) ( #160165 )
...
847deb2089...4d8488f02cskia-flutter-autoroll@skia.org Roll Dart SDK from
96022397c58d to 70062c353404 (1 revision) (flutter/engine#57155 )
2024-12-12 skia-flutter-autoroll@skia.org Roll Dart SDK from
aa03dca5beb2 to 96022397c58d (2 revisions) (flutter/engine#57149 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,zra@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-12-12 13:45:10 +00:00
