Ahmed Mohamed Sameh
15d2e56b4e
Make sure that a SearchBar doesn't crash in 0x0 environment ( #177761 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the SearchBar widget.
2025-11-02 19:52:00 +00:00
Ahmed Mohamed Sameh
5e348fd892
Make sure that a Scaffold doesn't crash in 0x0 environment ( #177722 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the Scaffold widget.
2025-11-02 19:33:46 +00:00
Ahmed Mohamed Sameh
dc7da2b3fe
Make sure that a Scrollbar doesn't crash in 0x0 environment ( #177724 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the Scrollbar widget.
2025-11-02 19:33:46 +00:00
Bui Dai Duong
7efa2aed3c
Colored box optimization ( #176028 ) ( #176073 )
...
This PR fixed visual bug when placing multiple `ColoredBox`s together.
(Fixes #176028 )
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2025-11-02 18:59:19 +00:00
engine-flutter-autoroll
02d6e8fff6
Roll Fuchsia Linux SDK from qrSMgeeLme59noqy-... to Ynp3qiXocK8WLTjlb... ( #177897 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-02 14:26:29 +00:00
engine-flutter-autoroll
5ff0839f89
Roll Skia from 7a5b34ce9bbf to 25e1e4e96980 (1 revision) ( #177894 )
...
https://skia.googlesource.com/skia.git/+log/7a5b34ce9bbf..25e1e4e96980
2025-11-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SKP
CIPD package from 537 to 538
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-02 10:53:43 +00:00
engine-flutter-autoroll
677bdc8e09
Roll Skia from 5ed21229cdd9 to 7a5b34ce9bbf (1 revision) ( #177890 )
...
https://skia.googlesource.com/skia.git/+log/5ed21229cdd9..7a5b34ce9bbf
2025-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 93bfb7f59e39 to f618974690bc (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-02 01:56:40 +00:00
Zachary Anderson
590a783995
[engine,build] Fix Fuchsia RBE build ( #177865 )
...
As in the Dart build here:
fc8b3d7927/build/toolchain/fuchsia/fuchsia_toolchain.gni (L24)
2025-11-02 00:05:24 +00:00
Pierre
f234d26926
Clean up links to docs website ( #177792 )
...
- remove link without use (PowerShell version minimum not reached, this
is not mentionned anywhere in Windows installation / troubleshooting
documentation)
- clean up API docs root
- clean up app template links, add `Learn Flutter` link
- update get started links
- replace `flutter.dev/docs` with `docs.flutter.dev`
- fix embedder descriptions
- fix broken API `docs.flutter.io` links
- http → https
- remove `/install` from `/get-started` links
- fix Android Studio link
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Parker Lougheed <parlough@gmail.com>
2025-11-01 18:38:27 +00:00
engine-flutter-autoroll
c567dc33d4
Roll Dart SDK from eceb37860450 to 2d3aa1d5cb9f (1 revision) ( #177885 )
...
https://dart.googlesource.com/sdk.git/+log/eceb37860450..2d3aa1d5cb9f
2025-11-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-88.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-01 17:50:42 +00:00
engine-flutter-autoroll
df70ab759d
Roll Fuchsia Linux SDK from O-OoG6j4wHXd1ThNM... to qrSMgeeLme59noqy-... ( #177881 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-01 12:04:40 +00:00
engine-flutter-autoroll
6696f5ebef
Roll Skia from c5cd862d6fa5 to 5ed21229cdd9 (1 revision) ( #177877 )
...
https://skia.googlesource.com/skia.git/+log/c5cd862d6fa5..5ed21229cdd9
2025-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from ca45bb2eb745 to 93bfb7f59e39 (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-01 09:07:26 +00:00
Jonathan Gilbert
7b1bafec82
Add support for Visual Studio 2026 ( #177458 )
...
Adds a mapping for Visual Studio 2026 to the `cmakeGenerator` property
used to drive Windows builds, enabling Flutter to be used for
development on a system with Visual Studio 2026 installed and not Visual
Studio 2022 or Visual Studio 2019.
Closes : #176399
Related-To: #93426
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-11-01 06:01:35 +00:00
engine-flutter-autoroll
26100b7d0a
Roll Dart SDK from 1c6960e5cd79 to eceb37860450 (2 revisions) ( #177871 )
...
https://dart.googlesource.com/sdk.git/+log/1c6960e5cd79..eceb37860450
2025-11-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-87.0.dev
2025-10-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-86.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-11-01 04:30:28 +00:00
engine-flutter-autoroll
9ef662cefb
Roll Skia from 770b8a835e73 to c5cd862d6fa5 (2 revisions) ( #177864 )
...
https://skia.googlesource.com/skia.git/+log/770b8a835e73..c5cd862d6fa5
2025-10-31
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-10-31 borenet@google.com [infra] Roll infra repo
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-31 23:58:28 +00:00
engine-flutter-autoroll
26404ad8ab
Roll Dart SDK from db168d9e7471 to 1c6960e5cd79 (1 revision) ( #177862 )
...
https://dart.googlesource.com/sdk.git/+log/db168d9e7471..1c6960e5cd79
2025-10-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-85.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-31 22:53:27 +00:00
Bruno Leroux
be736e19e7
Fix default value for DateRangePickerDialog currentDate ( #177448 )
...
## Description
This PR fixes the default value for `DateRangePickerDialog.currentDate`.
Before this PR, the comment mentions that `currentDate` defaults to
`DateTime.now()` but this is not the case (the value is not
initialised).
After this PR, `currentDate` defaults to `calendarDelegate.now()`.
## Related Issue
Fixes [DateRangePickerDialog crashes when currentDate is
omitted](https://github.com/flutter/flutter/issues/177441 )
## Tests
- Adds 1 test
2025-10-31 22:16:21 +00:00
engine-flutter-autoroll
8c55555d38
Roll Skia from 2cf9a1923078 to 770b8a835e73 (3 revisions) ( #177856 )
...
https://skia.googlesource.com/skia.git/+log/2cf9a1923078..770b8a835e73
2025-10-31 nbilling@google.com trackResource->traceCommandBufferResource
for DawnCommandBuffer/MtlCommandBuffer
2025-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 7197b08a9ac7 to ca45bb2eb745 (5 revisions)
2025-10-31 sergiog@microsoft.com [rust png] Move UtilsForFFI.h to
SpanUtils.h in root rust folder
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-31 21:10:41 +00:00
Gray Mackall
48c77daf85
Re-enable android verified input devicelab test ( #177804 )
...
This was originally landed in
https://github.com/flutter/flutter/pull/140836/
but the pr did not hook it up to ci. It was then removed in
https://github.com/flutter/flutter/pull/162895/
First got the driver test running:
`flutter drive -t lib/main.dart --driver test_driver/main_test.dart`
from the directory of the test app
then got the devicelab harness working via
`../../bin/cache/dart-sdk/bin/dart bin/test_runner.dart test -t
android_verified_input_test` from the `dev/devicelab` directory
and then finally hooked up to ci with the configuration in the
`.ci.yaml`
Restoring in a passing state, in advance of landing
https://github.com/flutter/flutter/pull/177572/
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <mackall@google.com>
2025-10-31 19:40:14 +00:00
engine-flutter-autoroll
027f2e4102
Roll Dart SDK from bb45c4186fb2 to db168d9e7471 (1 revision) ( #177839 )
...
https://dart.googlesource.com/sdk.git/+log/bb45c4186fb2..db168d9e7471
2025-10-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-84.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-31 17:16:17 +00:00
Loïc Sharma
5c42d7af92
Hide "waiting for customer" issues from text input triage ( #177524 )
...
This better aligns with other team's triage queries.
2025-10-31 16:14:25 +00:00
Matthew Kosarek
de56adb817
Making the multiple_windows example app demonstrate dialogs of dialogs ( #177786 )
...
## What's new?
- Users can now create a dialog whose parent is a dialog in the example
app
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-10-31 15:54:05 +00:00
Bruno Leroux
46b6f40982
Fix ElevatedButton.icon breaks focus traversal and VoiceOver when toggling icon ( #177579 )
...
## Description
This PR changes `ElevatedButton.icon` to avoid building a different
widget. When a different widget is created the whole subtree is
recreated which leads to various issues (Focus and A11y issues for
instance).
The change is similar to https://github.com/flutter/flutter/pull/175810
which fixed the exact same problem for `OutlinedButton.icon`.
## Related Issue
[TextButton.icon breaks focus traversal and ink effect when toggling
icon](https://github.com/flutter/flutter/issues/173944 )
[Voiceover focus traversal breaks if a button's state changes to include
an icon](https://github.com/flutter/flutter/pull/175810 )
## Tests
- Adds 2 tests
2025-10-31 15:01:19 +00:00
Bruno Leroux
46733c69fb
Fix FilledButton.icon and FilledButton.tonalIcon break focus traversal and VoiceOver ( #177593 )
...
## Description
This PR changes `FilledButton.icon` and `FilledButton.tonalIcon` to
avoid building a different widget. When a different widget is created
the whole subtree is recreated which leads to various issues (Focus and
A11y issues for instance).
The change is similar to https://github.com/flutter/flutter/pull/175810
which fixed the exact same problem for `OutlinedButton.icon`.
## Related Issue
[TextButton.icon breaks focus traversal and ink effect when toggling
icon](https://github.com/flutter/flutter/issues/173944 )
[Voiceover focus traversal breaks if a button's state changes to include
an icon](https://github.com/flutter/flutter/pull/175810 )
## Tests
- Adds 4 tests
2025-10-31 13:06:24 +00:00
ColdPaleLight
290d0f87a9
Fix cubic subdivision estimation using correct Wang’s formula ( #177758 )
...
Replaced the incorrect Abs()/Max() operations with squared magnitude
checks via dot products
2025-10-31 10:52:25 +00:00
engine-flutter-autoroll
1ac7b01ae3
Roll Skia from ccbd7697791f to 2cf9a1923078 (1 revision) ( #177832 )
...
https://skia.googlesource.com/skia.git/+log/ccbd7697791f..2cf9a1923078
2025-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from d763609022a4 to 7934556e26c1 (10 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-31 10:16:25 +00:00
engine-flutter-autoroll
fdcc55acfc
Roll Fuchsia Linux SDK from ksXeDDo2yYBXJ4uEu... to O-OoG6j4wHXd1ThNM... ( #177831 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-31 09:58:15 +00:00
engine-flutter-autoroll
a30979034d
Roll Skia from 1532fabb4b7d to ccbd7697791f (4 revisions) ( #177828 )
...
https://skia.googlesource.com/skia.git/+log/1532fabb4b7d..ccbd7697791f
2025-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 0b3b8a8cbc26 to e13d18f9806c (5 revisions)
2025-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 4e1fe2e715a8 to 7197b08a9ac7 (11 revisions)
2025-10-31
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-10-30
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-31 07:56:36 +00:00
engine-flutter-autoroll
d1660b722f
Roll Dart SDK from cf24b43cb643 to bb45c4186fb2 (2 revisions) ( #177824 )
...
https://dart.googlesource.com/sdk.git/+log/cf24b43cb643..bb45c4186fb2
2025-10-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-83.0.dev
2025-10-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-82.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-31 06:26:28 +00:00
engine-flutter-autoroll
6af38a904a
Roll Skia from 825d5c854302 to 1532fabb4b7d (3 revisions) ( #177808 )
...
https://skia.googlesource.com/skia.git/+log/825d5c854302..1532fabb4b7d
2025-10-30
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-10-30
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-10-30
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-31 00:48:25 +00:00
engine-flutter-autoroll
7518b6b884
Roll Dart SDK from da663596bf6d to cf24b43cb643 (2 revisions) ( #177798 )
...
https://dart.googlesource.com/sdk.git/+log/da663596bf6d..cf24b43cb643
2025-10-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-81.0.dev
2025-10-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-80.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-30 23:00:24 +00:00
Jason Simmons
8dd2a072ca
Update the path used by the download_fuchsia_sdk.py script to //third_party/fuchsia-sdk ( #177794 )
...
See https://github.com/flutter/flutter/pull/177118
2025-10-30 22:58:33 +00:00
engine-flutter-autoroll
ba0cd2f0cc
Roll Skia from 6af53143b120 to 825d5c854302 (2 revisions) ( #177788 )
...
https://skia.googlesource.com/skia.git/+log/6af53143b120..825d5c854302
2025-10-30 kjlubick@google.com Run dawn_fetch_deps once regardless of
toolchains
2025-10-30 skydebreuil@google.com Fixed GLES 3 Crash on Android
emulators
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-30 21:42:20 +00:00
gaaclarke
c089837469
Fixes RuntimeEffect when used with ImageFilter.compose and gaussian blur ( #177687 )
...
fixes https://github.com/flutter/flutter/issues/170820
fixes https://github.com/flutter/flutter/issues/177611
This PR snapshots the input of a runtimeeffect if its transform is not
identity. This fixes the cases where we use compose with the runtime
effect and the inner effect evaluates to a snapshot that doesn't match
the size of x, such as`runtime_effect(blur(x))`. Blur will perform at
lower resolutions when the sigma is high as an optimization. Blur also
adds a halo around what it is blurring. Previously we could optimize
away this extra render pass when we assumed that the coverage of
inner(x) was the same as x (but potentially just translated), but we
can't do that in practice because of things like gaussian blur.
In order to make this PR work we had to come up with a way to disable
the extra padding that is added to every `RenderToSnapshot`. This is
because users want to to reference specific fragments. The extra border
of padding would increase the texture size of inner(x) and x which
created a jump in the locations calcuated in the fragment shaders when
the inner snapshot's transform would jump from identity to non-identity.
The only other alternative would be to pass in the offset to the
fragment shader but that would be a breaking change.
In order to get the shaders rendering in the right orientation on
opengles I had to switch the shaders to do a `uv.y = 1.0 - uv.y`. This
is in the documentation for ImageFilter.shader but it is an annoying
gotcha. Hopefully this doesn't break someone if the logic was different
previously for ImageFilter.compose but this is the correct thing to do
and since it wasn't tested, there is no breaking change.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-10-30 21:39:11 +00:00
chunhtai
c914ec90f1
Adds cache extent type to two_dimentional_viewport ( #177411 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
as title. this is needed if we want to change cache extent default to
use viewport % instead of pixels
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-10-30 21:39:07 +00:00
auto-submit[bot]
6a5a918002
Reverts "Update .ci.yaml in flutter/flutter to use 15.5 ( #177669 )" ( #177793 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#177669
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: vashworth
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Not all devicelab bots are on Mac 15.5
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: okorohelijah
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {mdebbar, vashworth}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
Update .ci.yaml in flutter/flutter to use 15.5
*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*
Fixes #177394
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-10-30 20:21:39 +00:00
Flutter GitHub Bot
95f0e06a8b
Marks Windows windowing_test to be flaky ( #177716 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows windowing_test"
}
-->
Issue link: https://github.com/flutter/flutter/issues/177715
2025-10-30 19:32:46 +00:00
Camille Simon
f5580933d8
Fixes SettingsChannelTest flake ( #177061 )
...
Fixes `SettingsChannelTest` failure that occurs when other Android
embedding tests touch the singleton queue that the `SettingsChannel`
manages.
Instead of the test making assertions based on the theoretical
generation number of `SentConfiguration`s added to the queue, the
assertions are isntead made relative to the exaction generation number
of those `SentConfiguration`s.
Fixes https://github.com/flutter/flutter/issues/176413 . I tested this
fix in https://github.com/flutter/flutter/pull/175937 ; an example
passing build:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/3641486/overview .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-10-30 19:29:10 +00:00
gaaclarke
2c9e69f0db
Implements uniform-by-name for web ( #176980 )
...
fixes https://github.com/flutter/flutter/issues/176417 (for web)
Now on the web the `FragmentShader.getUniformFloat(String name, [int?
index])` can be used.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-10-30 19:14:37 +00:00
Elijah Okoroh
fdeb7f5a6e
Update .ci.yaml in flutter/flutter to use 15.5 ( #177669 )
...
Update .ci.yaml in flutter/flutter to use 15.5
*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*
Fixes #177394
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Mouad Debbar <mdebbar@google.com>
2025-10-30 18:43:07 +00:00
Jason Simmons
8834b42dff
[Impeller] Fall back to OpenGL ES on older Adreno GPUs ( #177747 )
...
These GPUs require additional flags in WorkaroundsVK that affect key
features used by the Vulkan back end such as framebuffer fetch. The
OpenGL ES back end will likely be more reliable on these devices.
Fixes https://github.com/flutter/flutter/issues/177380
2025-10-30 18:41:11 +00:00
Hannah Jin
b5c3b9eded
[VPAT] Update a11y assessment app and guideline tests ( #177690 )
...
issue: https://github.com/flutter/flutter/issues/172993
This PR mainly update the `accessibility_guideline_test.dart` to
iterates and taps on semantic nodes to make sure each use case in the
assessment app is tested for guideline.
Also Update the navigation rail and app bar use case so they will pass
the tap target size test and the text contrast test.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2025-10-30 18:31:13 +00:00
engine-flutter-autoroll
5a72e5029e
Roll Skia from 18457971c30f to 6af53143b120 (4 revisions) ( #177778 )
...
https://skia.googlesource.com/skia.git/+log/18457971c30f..6af53143b120
2025-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 06ad50268dd3 to 4e1fe2e715a8 (1 revision)
2025-10-30 kjlubick@google.com Sync Dawn and Tint deps once, not in
parallel
2025-10-30 lukasza@chromium.org Reland "[rust png] Stop using+remove
`SkXPS...PngHelpers.h` from Skia."
2025-10-30
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-30 18:27:23 +00:00
engine-flutter-autoroll
c47233ab38
Roll Packages from 41c6b3d7666a to 1a7075b09ef1 (2 revisions) ( #177777 )
...
41c6b3d766...1a7075b09eengine-flutter-autoroll@skia.org Roll Flutter from
7cf0dc1be72e to df72035ba8c5 (23 revisions) (flutter/packages#10322 )
2025-10-29 brackenavaron@gmail.com [cross_file] always set browser blob
when constructing XFile from data (flutter/packages#8611 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-30 16:05:13 +00:00
engine-flutter-autoroll
1c485365c2
Roll Dart SDK from 4785d5971d64 to da663596bf6d (1 revision) ( #177772 )
...
https://dart.googlesource.com/sdk.git/+log/4785d5971d64..da663596bf6d
2025-10-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-79.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-30 15:49:26 +00:00
engine-flutter-autoroll
6f8abdd778
Roll Skia from 5035cdc7de31 to 18457971c30f (1 revision) ( #177767 )
...
https://skia.googlesource.com/skia.git/+log/5035cdc7de31..18457971c30f
2025-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from bf371eff8421 to d763609022a4 (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-30 11:00:41 +00:00
engine-flutter-autoroll
fe0bacbacf
Roll Skia from 018e2cdba2fe to 5035cdc7de31 (3 revisions) ( #177764 )
...
https://skia.googlesource.com/skia.git/+log/018e2cdba2fe..5035cdc7de31
2025-10-30
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from f4cbf919963d to 0b3b8a8cbc26 (4 revisions)
2025-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 6ee5b8fed805 to bfbd2e6a335b (13 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-30 08:32:27 +00:00
engine-flutter-autoroll
376a0b25d8
Roll Dart SDK from a0480f399f8f to 4785d5971d64 (21 revisions) ( #177760 )
...
https://dart.googlesource.com/sdk.git/+log/a0480f399f8f..4785d5971d64
2025-10-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-78.0.dev
2025-10-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-77.0.dev
2025-10-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-76.0.dev
2025-10-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-75.0.dev
2025-10-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-74.0.dev
2025-10-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-73.0.dev
2025-10-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-72.0.dev
2025-10-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-71.0.dev
2025-10-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-70.0.dev
2025-10-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-69.0.dev
2025-10-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-68.0.dev
2025-10-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-67.0.dev
2025-10-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-66.0.dev
2025-10-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-65.0.dev
2025-10-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-64.0.dev
2025-10-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-63.0.dev
2025-10-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-62.0.dev
2025-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-61.0.dev
2025-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-60.0.dev
2025-10-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-59.0.dev
2025-10-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-58.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-30 06:57:40 +00:00
engine-flutter-autoroll
708c0be8ce
Roll Skia from c803f12d2e26 to 018e2cdba2fe (1 revision) ( #177759 )
...
https://skia.googlesource.com/skia.git/+log/c803f12d2e26..018e2cdba2fe
2025-10-30
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-30 06:03:28 +00:00
engine-flutter-autoroll
f635fd1b9a
Roll Skia from 51267d4a2cea to c803f12d2e26 (2 revisions) ( #177756 )
...
https://skia.googlesource.com/skia.git/+log/51267d4a2cea..c803f12d2e26
2025-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from da77af8eba98 to 06ad50268dd3 (6 revisions)
2025-10-30 robertphillips@google.com [graphite] Update testing framework
for new Pipeline callback
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jlavrova@google.com ,jsimmons@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-30 03:15:32 +00:00
