Michael Thomsen
11def8eff4
Update README.md ( #140382 )
...
Update the "fast results" subsection of readme with recent developments.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
---------
Co-authored-by: Parker Lougheed <parlough@gmail.com>
2023-12-21 13:03:09 +01:00
Jim Graham
8407dd2d0e
Revert "Integrate testWidgets with leak tracking. ( #138057 )" ( #140502 )
...
The PR is breaking the `flutter_test_performance` test and making the
tree red.
2023-12-21 12:44:58 +01:00
Polina Cherkasova
d746007fcd
Integrate testWidgets with leak tracking. ( #138057 )
...
Contributes to: https://github.com/flutter/flutter/issues/135856
TODO:
2023-12-21 00:19:59 +00:00
Qun Cheng
c0acd8c45f
Fix import pattern ( #140425 )
...
This PR is just to fix the import pattern to follow the convention.
2023-12-21 00:18:09 +00:00
godofredoc
cf3760bce0
Update job permissions ( #140476 )
...
Updates to use contents: write and pull-requests: write.
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-12-20 14:59:24 -08:00
flutter-pub-roller-bot
2d75f76b44
Roll pub packages ( #140472 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-12-20 22:57:21 +00:00
Michael Goderbauer
68e346e41c
Remove outdated ignores from tool ( #140467 )
...
These were not ignoring anything (anymore).
2023-12-20 22:14:32 +00:00
Michael Goderbauer
c4fda23393
Remove outdated ignores from framework ( #140465 )
...
These were not ignoring anything (anymore).
2023-12-20 22:05:29 +00:00
LongCatIsLooong
e2e8bcb1bc
Reland find.textRange.ofSubstring changes ( #140469 )
...
Extracted from https://github.com/flutter/flutter/pull/139717 as-is. Landing this change first so we can avoid doing a g3fix.
2023-12-20 22:00:55 +00:00
Reid Baker
d6e435a7ac
Part 1/n migration steps for kotlin migration ( #140452 )
...
Following https://developer.android.com/build/migrate-to-kotlin-dsl
1/n Add parentheses to method calls
Should be a no-op change. If you see a behavioral change please flag it.
2023-12-20 20:40:17 +00:00
auto-submit[bot]
9003f13803
Reverts "Make TextSpan hit testing precise." ( #140468 )
...
Reverts flutter/flutter#139717
Initiated by: LongCatIsLooong
This change reverts the following previous change:
Original Description:
Fixes https://github.com/flutter/flutter/issues/131435 , #104594 , #43400
Needs https://github.com/flutter/engine/pull/48774 (to fix the web test failure).
Currently the method we use for text span hit testing `TextPainter.getPositionForOffset` always returns the closest `TextPosition`, even when the given offset is far away from the text.
The new TextPaintes method tells you the layout bounds (`width = letterspacing / 2 + x_advance + letterspacing / 2`, `height = font ascent + font descent`) of a character, the PR changes the hit testing implementation such that a TextSpan is only considered hit if the point-down event landed in one of it's character's layout bounds.
Potential issues:
1. In theory since the text is baseline aligned, we should use the max ascent and max descent of each character to calculate the height of the text span's hit-test region, in case some characters in the span have to fall back to a different font, but that will be slower and it typically doesn't make a huge difference.
This is a breaking change. It also introduces a new finder and a new method `WidgetTester.tapOnText`: `await tester.tapOnText('string to match')` for ease of migration.
2023-12-20 19:32:10 +00:00
Harry Terkelsen
11bfb3c46a
[web] Re-enable test now that source of flakiness is fixed ( #140462 )
...
The test was flaky before due to overflowing GPU memory during the test.
The memory leak was fixed here
https://github.com/flutter/engine/pull/49214
Fixes https://github.com/flutter/flutter/issues/137669
As a side effect of the fix, this test also runs much faster, from about
3 minutes on my Macbook down to about 25 seconds.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-12-20 11:11:56 -08:00
Chris Bracken
7b0bfa8c61
Eliminate Cirrus build status badge ( #140461 )
...
We have no tasks running on Cirrus any more. This eliminates the "Build
Status - Cirrus" badge/link as well as the "Build status" link
reference, which was unused.
@CaseyHillers has filed a bug to add a Cocoon endpoint to replace it:
https://github.com/flutter/flutter/issues/140460
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-12-20 10:58:32 -08:00
Zachary Anderson
76c8e7387b
Move tests shifted to Pixel 7 from staging to prod ( #140438 )
2023-12-20 18:57:40 +00:00
engine-flutter-autoroll
0dc3b072c1
Roll Packages from be52ac86bb4f to dc5b267f3cd1 (5 revisions) ( #140450 )
...
be52ac86bb...dc5b267f3cengine-flutter-autoroll@skia.org Roll Flutter from 0eb788134051 to da0cd69659c5 (15 revisions) (flutter/packages#5729 )
2023-12-20 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#5702 )
2023-12-19 jsharp83@gmail.com [webview_flutter] Implement platform interface for JavaScript dialog (flutter/packages#5670 )
2023-12-19 JeroenWeener@users.noreply.github.com [webview_flutter] Support for handling basic authentication requests (iOS) (flutter/packages#5455 )
2023-12-19 engine-flutter-autoroll@skia.org Roll Flutter from cdc83e5ebae4 to 0eb788134051 (17 revisions) (flutter/packages#5722 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-20 17:33:18 +00:00
Bruno Leroux
0d90014bae
_TabBarViewState should not recreate page controller ( #135500 )
...
## Description
This PR replaces the unconditional instantiation of `PageController` in `_TabBarViewState.didChangeDependencies` as suggested in https://github.com/flutter/flutter/pull/134091#discussion_r1319177744 .
## Related Issue
Fixes https://github.com/flutter/flutter/issues/134253 .
## Tests
Adds 1 test.
2023-12-20 17:04:29 +00:00
Gustl22
da0cd69659
Revert automated changes made to deprecated settings.gradle (plugins.each) ( #140037 )
...
Restore testing deprecated settings.gradle (plugins.each).
Updated presumably by accident in #83067
Split from #137115
See also https://github.com/flutter/flutter/pull/137115#issuecomment-1781909865
2023-12-20 15:45:08 +00:00
Xilai Zhang
62d699961f
[github actions] change minimal example workflow to be manually dispatched ( #140435 )
...
This would allow easier testing of the minimal example.
Might need Github Admin power to trigger the manual dispatches.
2023-12-20 04:59:27 +00:00
LongCatIsLooong
ea5b97286e
Make TextSpan hit testing precise. ( #139717 )
...
Fixes https://github.com/flutter/flutter/issues/131435 , #104594 , #43400
Needs https://github.com/flutter/engine/pull/48774 (to fix the web test failure).
Currently the method we use for text span hit testing `TextPainter.getPositionForOffset` always returns the closest `TextPosition`, even when the given offset is far away from the text.
The new TextPaintes method tells you the layout bounds (`width = letterspacing / 2 + x_advance + letterspacing / 2`, `height = font ascent + font descent`) of a character, the PR changes the hit testing implementation such that a TextSpan is only considered hit if the point-down event landed in one of it's character's layout bounds.
Potential issues:
1. In theory since the text is baseline aligned, we should use the max ascent and max descent of each character to calculate the height of the text span's hit-test region, in case some characters in the span have to fall back to a different font, but that will be slower and it typically doesn't make a huge difference.
This is a breaking change. It also introduces a new finder and a new method `WidgetTester.tapOnText`: `await tester.tapOnText('string to match')` for ease of migration.
2023-12-20 03:23:29 +00:00
Xilai Zhang
e86b825819
[github actions] add minimal workflow to test token ( #140363 )
...
Add a workflow that simply:
1. checkout repo
2. write a file
3. create a PR
This is used to verify the permissions and validity of the github token we use to create PR.
context: https://chat.google.com/room/AAAAc_4rqiI/Ck593Sg7mvs
If we think the triggering condition is complicated, I can also change this workflow to be manual dispatch, to make it truly minimal.
2023-12-20 01:18:07 +00:00
engine-flutter-autoroll
18db55b4e5
Roll Flutter Engine from 5279873a8635 to c70f0a495ace (2 revisions) ( #140431 )
...
5279873a86...c70f0a495askia-flutter-autoroll@skia.org Roll Skia from 48f959a857da to d0f09ad481f7 (3 revisions) (flutter/engine#49264 )
2023-12-19 dkwingsmt@users.noreply.github.com Revert "Reland 2: Multiview Pipeline (#47239 )" (flutter/engine#49238 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-20 00:55:24 +00:00
engine-flutter-autoroll
0ae9260111
Roll Flutter Engine from df1593e96a6b to 5279873a8635 (2 revisions) ( #140428 )
...
df1593e96a...5279873a86skia-flutter-autoroll@skia.org Roll Dart SDK from e8cdc554c598 to 4c59838945d9 (2 revisions) (flutter/engine#49261 )
2023-12-19 flar@google.com Make sure run_tests.py runs dart tests on Skia (flutter/engine#49260 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-20 00:16:15 +00:00
Christopher Fujino
ef1227f05d
[flutter_tools] handle FileSystemException trying to delete temp directory from core_devices.dart ( #140415 )
...
Fixes https://github.com/flutter/flutter/issues/140416 , the top crasher on stable/3.16.4
2023-12-20 00:08:54 +00:00
Zachary Anderson
ea6017ded8
Move hybrid_android_views_integration_test back to Moto G4 ( #140421 )
...
Related https://github.com/flutter/flutter/issues/140420
2023-12-19 23:44:10 +00:00
engine-flutter-autoroll
8316e8512f
Roll Flutter Engine from 3b156c8ce9bd to df1593e96a6b (2 revisions) ( #140422 )
...
3b156c8ce9...df1593e96azanderso@users.noreply.github.com Rolls clang to 725656bdd885483c39f482a01ea25d67acf39c46 (flutter/engine#49248 )
2023-12-19 aam@google.com Roll dart to 3.3.0-242.0.dev (flutter/engine#49239 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-19 23:36:20 +00:00
Fedor Blagodyr
2bb19a9501
Added onEnd callback into AnimatedSize ( #139859 )
...
close #106439
2023-12-19 22:59:46 +00:00
engine-flutter-autoroll
5a5683ddd7
Roll Flutter Engine from 3f45f9db4471 to 3b156c8ce9bd (1 revision) ( #140413 )
...
3f45f9db44...3b156c8ce9skia-flutter-autoroll@skia.org Roll Skia from df1a7ccbdc97 to 48f959a857da (1 revision) (flutter/engine#49255 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-19 22:37:56 +00:00
engine-flutter-autoroll
1fd5d87e54
Roll Flutter Engine from 187334c39b44 to 3f45f9db4471 (3 revisions) ( #140412 )
...
187334c39b...3f45f9db44skia-flutter-autoroll@skia.org Roll Skia from 541f16af8b3e to df1a7ccbdc97 (3 revisions) (flutter/engine#49250 )
2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 0d39fb28b32d to 541f16af8b3e (1 revision) (flutter/engine#49246 )
2023-12-19 john@johnmccutchan.com Use new SurfaceProducer external texture class for rendering platform views (flutter/engine#49201 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-19 21:54:13 +00:00
Victoria Ashworth
6981fe6fd3
Remove workarounds for plugin_lint_mac needed for older version of Cocoapods ( #140395 )
...
CI has been updated to Cocoapods 1.13, which fixes previous issues with the `plugin_lint_mac` test. Remove workarounds added previously.
Fixes https://github.com/flutter/flutter/issues/125812 .
See also https://github.com/flutter/flutter/issues/133584 .
2023-12-19 20:19:52 +00:00
engine-flutter-autoroll
b14d7452ef
Roll Flutter Engine from b87a782ce3a3 to 187334c39b44 (2 revisions) ( #140398 )
...
b87a782ce3...187334c39bskia-flutter-autoroll@skia.org Roll Skia from 22dad95c218f to 0d39fb28b32d (2 revisions) (flutter/engine#49241 )
2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 6496c9c5866a to 22dad95c218f (4 revisions) (flutter/engine#49237 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-19 19:26:05 +00:00
engine-flutter-autoroll
837ba40937
Roll Flutter Engine from 1d5a141917fa to b87a782ce3a3 (1 revision) ( #140390 )
...
1d5a141917...b87a782ce3skia-flutter-autoroll@skia.org Roll Skia from ed0148ab400d to 6496c9c5866a (6 revisions) (flutter/engine#49234 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-19 17:42:58 +00:00
Zachary Anderson
0eb7881340
Shift some Linux-hosted tests on moto g4 to pixel 7 ( #140389 )
2023-12-19 09:30:03 -08:00
Bartek Pacia
a1e1dc3f6c
Reland "Warn when Gradle plugins are applied using the legacy apply script method ( #140103 )
...
> This PR relands #139690 which was reverted in #140102
This PR adds a deprecation message when Android build is using the legacy "apply script method" way of applying Flutter's Gradle plugins (that is: [`flutter.gradle`](https://github.com/flutter/flutter/blob/3.16.0/packages/flutter_tools/gradle/flutter.gradle ) and [`app_plugin_loader.gradle`](https://github.com/flutter/flutter/blob/3.16.0/packages/flutter_tools/gradle/app_plugin_loader.gradle )).
See also:
- #121541
- in particular https://github.com/flutter/flutter/issues/121541#issuecomment-1836947311
- #135392
- and PR that add the migration guide: [#9857 ](https://github.com/flutter/website/pull/9857 )
- I think either `logger.error` or `logger.quiet` must be used, because all other error levels are not shown during `flutter build apk` (and that's what most people use).
2023-12-19 16:03:23 +00:00
engine-flutter-autoroll
df6781358e
Roll Packages from d7dee796f3c8 to be52ac86bb4f (1 revision) ( #140386 )
...
d7dee796f3...be52ac86bbengine-flutter-autoroll@skia.org Roll Flutter from 2407f699e935 to cdc83e5ebae4 (28 revisions) (flutter/packages#5715 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-19 15:44:24 +00:00
engine-flutter-autoroll
bbfe177dc9
Roll Flutter Engine from bde7c612f6ba to 1d5a141917fa (3 revisions) ( #140371 )
...
bde7c612f6...1d5a141917skia-flutter-autoroll@skia.org Roll Skia from c12c2a174327 to ed0148ab400d (1 revision) (flutter/engine#49222 )
2023-12-19 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 3.1.3 to 4.0.0 (flutter/engine#49220 )
2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 27ab8a8d2a0d to c12c2a174327 (1 revision) (flutter/engine#49218 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-19 10:48:01 +00:00
engine-flutter-autoroll
51633fe95c
Roll Flutter Engine from 42af8f106206 to bde7c612f6ba (2 revisions) ( #140367 )
...
42af8f1062...bde7c612f6academy3746@gmail.com Makes PlatformViewsController view to use tracked event's action & pointer count (flutter/engine#47424 )
2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 37a60129e019 to 27ab8a8d2a0d (1 revision) (flutter/engine#49213 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-19 07:35:27 +00:00
engine-flutter-autoroll
2ed0df8405
Roll Flutter Engine from bbfee6f59b42 to 42af8f106206 (1 revision) ( #140362 )
...
bbfee6f59b...42af8f1062skia-flutter-autoroll@skia.org Roll Skia from e5b0cdc11992 to 37a60129e019 (1 revision) (flutter/engine#49212 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-19 04:48:25 +00:00
Polina Cherkasova
6368d65622
Upgrade to version of leak tracker that does not depend on test_widgets. ( #140247 )
...
Contributes to: https://github.com/flutter/flutter/issues/135856
2023-12-19 04:28:09 +00:00
engine-flutter-autoroll
cc4b3293fb
Roll Flutter Engine from 632103f787ba to bbfee6f59b42 (4 revisions) ( #140359 )
...
632103f787...bbfee6f59bskia-flutter-autoroll@skia.org Roll Skia from fff421ff633e to e5b0cdc11992 (4 revisions) (flutter/engine#49210 )
2023-12-19 skia-flutter-autoroll@skia.org Roll Skia from 63bed826008e to fff421ff633e (1 revision) (flutter/engine#49208 )
2023-12-19 godofredoc@google.com Double timeout on mac builds. (flutter/engine#49205 )
2023-12-18 flar@google.com [Impeller] Make Rect origin and size fields private (flutter/engine#49168 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-19 03:13:09 +00:00
engine-flutter-autoroll
0d775705e6
Roll Flutter Engine from 92d88c7e4e9a to 632103f787ba (9 revisions) ( #140350 )
...
92d88c7e4e...632103f787matej.knopp@gmail.com Convert chromium wheel delta to physical pixels on macOS (flutter/engine#49028 )
2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from 3de801338767 to 63bed826008e (1 revision) (flutter/engine#49200 )
2023-12-18 skia-flutter-autoroll@skia.org Roll Dart SDK from ff7e92c7886d to b21443096387 (1 revision) (flutter/engine#49199 )
2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from 83f8fe8bbcee to 3de801338767 (2 revisions) (flutter/engine#49195 )
2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from 10e7ee119ea9 to 83f8fe8bbcee (1 revision) (flutter/engine#49193 )
2023-12-18 barpac02@gmail.com Delete `SemanticsUpdateBuilderNew` and all references and usages (flutter/engine#49139 )
2023-12-18 chinmaygarde@google.com Opt into unstable libcxx ABI and add a custom namespace. (flutter/engine#49002 )
2023-12-18 skia-flutter-autoroll@skia.org Roll Skia from 4b2639427e7e to 10e7ee119ea9 (10 revisions) (flutter/engine#49191 )
2023-12-18 skia-flutter-autoroll@skia.org Roll Dart SDK from e1a26302800d to ff7e92c7886d (1 revision) (flutter/engine#49185 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-18 23:22:26 +00:00
Bartek Pacia
a4388773bb
SemanticsProperties: default identifier and tooltip to null ( #140283 )
...
This PR applies [the suggestion made here](https://github.com/flutter/devtools/pull/6942#issuecomment-1852773200 ).
2023-12-18 19:38:05 +00:00
Simon Friis Vindum
b893884f50
Document difference between softWrap and maxLine ( #139363 )
...
This PR fixes #13631 through documentation as suggested in https://github.com/flutter/flutter/issues/13631#issuecomment-354902727 .
Since the documentation additions rely on new screenshots this PR will be accompanied by a PR in the assets repository.
2023-12-18 19:09:07 +00:00
engine-flutter-autoroll
008ecd8c9e
Roll Flutter Engine from 2dc18738167e to 92d88c7e4e9a (1 revision) ( #140332 )
...
2dc1873816...92d88c7e4eskia-flutter-autoroll@skia.org Roll Skia from 290fefdef726 to 4b2639427e7e (1 revision) (flutter/engine#49183 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-18 18:23:26 +00:00
Gray Mackall
bdfb56cee2
Only run dart files as a test in the Android preview tools test shard ( #140099 )
...
I added a README at the end of https://github.com/flutter/flutter/pull/131901 and did not realize that it was being run as a test, [leading to test failures (of course)](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8761789207346423409/+/u/run_test.dart_for_android_preview_tool_integration_tests_shard_and_subshard_None/test_stdout ). This makes it so we only run dart files as dart tests.
2023-12-18 18:17:25 +00:00
engine-flutter-autoroll
a17e2e0859
Roll Flutter Engine from e4fa972d70cb to 2dc18738167e (1 revision) ( #140328 )
...
e4fa972d70...2dc1873816skia-flutter-autoroll@skia.org Roll Skia from 276075b97567 to 290fefdef726 (1 revision) (flutter/engine#49180 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-18 17:29:21 +00:00
engine-flutter-autoroll
7b7aa6a9a3
Roll Flutter Engine from d7f0803dd6af to e4fa972d70cb (1 revision) ( #140324 )
...
d7f0803dd6...e4fa972d70mdebbar@google.com [web] Set cursor property on body (flutter/engine#49098 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-18 16:43:26 +00:00
engine-flutter-autoroll
63753d4a0e
Roll Packages from 3f2e16bf2b17 to d7dee796f3c8 (5 revisions) ( #140322 )
...
3f2e16bf2b...d7dee796f3tarrinneal@gmail.com Remove flutter api named and optional parameters (flutter/packages#5689 )
2023-12-15 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from b0366e0a3f08 to 2e9cb0aa71a3 (4 revisions) (flutter/packages#5692 )
2023-12-15 mikemcguiness@protonmail.com [extension_google_sign_in_as_googleapis_auth] Adopt code excerpts in ⦠(flutter/packages#5496 )
2023-12-15 engine-flutter-autoroll@skia.org Roll Flutter from a51e33ac76e4 to 2407f699e935 (30 revisions) (flutter/packages#5691 )
2023-12-15 davidmartos96@gmail.com [google_sign_in_ios] Move pigeon as a dev dependency (flutter/packages#5685 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-18 15:45:36 +00:00
engine-flutter-autoroll
83236fdf8f
Roll Flutter Engine from 7f1a81d5545a to d7f0803dd6af (2 revisions) ( #140320 )
...
7f1a81d554...d7f0803dd6skia-flutter-autoroll@skia.org Roll Skia from 74e6a355f208 to 276075b97567 (1 revision) (flutter/engine#49177 )
2023-12-18 skia-flutter-autoroll@skia.org Roll Dart SDK from c8106261c9cd to e1a26302800d (1 revision) (flutter/engine#49178 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-18 15:08:42 +00:00
engine-flutter-autoroll
cdc83e5eba
Roll Flutter Engine from b3de65a6d3ea to 7f1a81d5545a (1 revision) ( #140309 )
...
b3de65a6d3...7f1a81d554skia-flutter-autoroll@skia.org Roll Skia from d4b1cc5122f9 to 74e6a355f208 (1 revision) (flutter/engine#49171 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-18 09:02:05 +00:00
raphire08
4659b0c402
refactored cli tool ipa method name to support --export-options-plist ( #138555 )
...
This PR changes the way the IPA method is read in the run command for `build ipa` command. If export options plist argument is provided it takes method name from plist, otherwise it uses the method name from export method argument.
*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
fixes [#122179 ](https://github.com/flutter/flutter/issues/122179 )
2023-12-18 08:56:07 +00:00
