DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
33,065 Commits 882 Branches 1,069 Tags
Commit Graph

33065 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Dan Field
112e8a2d4b Remove some trivial forward declares from Impeller (flutter/engine#48635) 
Towards https://github.com/flutter/flutter/issues/133417#issuecomment-1839273553

I'll request a test exemption for this as it's a semantics-only refactor.

There are still a bunch of other forward declares in Impeller that make things confusing for tooling, but some of those will require less trivial changes to interfaces.
 2023-12-04 20:53:06 +00:00
Loïc Sharma
20e5300477 [Windows] Decouple the GL context from the view (flutter/engine#48636) 
In the future, the GL context will be shared between zero or more views. The engine will also need to be able to make the GL context current even if the app is currently in headless mode.

No tests are updated as this is a refactoring with no functionality changes.

Part of https://github.com/flutter/flutter/issues/137267

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-04 20:53:03 +00:00
Tong Mu
673fca77cf Multiview ExternalViewEmbedder (flutter/engine#46169) 
This PR adds multiview support for `ExternalViewEmbedder`.

## Nomenclature

The term **view** can be ambiguous in `ExternalViewEmbedder`, and therefore the following terms are used:
* A **native view** refers to the final drawing surface that to composite layers to. It is the "view" used in other places of the engine, such as `Shell::AddView`.
* A **platform view** refers a platform view, a layer that holds content to be embedded.

## Change

The lifecycle of `ExternalViewEmbedder` is changed:

<table>
    <thead>
        <tr>
            <th>Before PR</th>
            <th>After PR</th>
            <th>How it's called</th>
        </tr>
    </thead>
    <tbody>
        <tr>
            <td rowspan=2>BeginFrame</td>
            <td>BeginFrame</td>
            <td>Once per frame</td>
        </tr>
        <tr>
            <td>PrepareFlutterView</td>
            <td>Once per flutter view</td>
        </tr>
        <tr>
            <td>SubmitFrame</td>
            <td>SubmitFlutterView (renamed)</td>
            <td>Once per flutter view</td>
        </tr>
        <tr>
            <td>EndFrame</td>
            <td>EndFrame (unchanged)</td>
            <td>Once per frame</td>
        </tr>
    </tbody>
</table>

* `BeginFrame` should perform per-frame actions, such as merge-unmerging threads.
* `PrepareView` should perform per-native-view preparations, such as recording the view ID and view size.

This change is necessary because some actions in `PrepareView` needs to be refreshed at the beginning of drawing every native view.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-04 20:29:49 +00:00
skia-flutter-autoroll
2b37d51467 Roll Dart SDK from 67f7a2c2559a to a1b67665b3a3 (1 revision) (flutter/engine#48637) 
https://dart.googlesource.com/sdk.git/+log/67f7a2c2559a..a1b67665b3a3

2023-12-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-189.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-04 20:19:24 +00:00
skia-flutter-autoroll
3fa90fbbd0 Roll Skia from db4a29e0689e to 0fe76d9ce79e (5 revisions) (flutter/engine#48634) 
https://skia.googlesource.com/skia.git/+log/db4a29e0689e..0fe76d9ce79e

2023-12-04 jvanverth@google.com [graphite] Enable GMs that no longer fail readback
2023-12-04 egdaniel@google.com Add support for getting a VertexWriter from the UploadManager.
2023-12-04 kjlubick@google.com Add Vulkan subclass of GrContextThreadSafeProxy
2023-12-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3fe678c9b297 to fb6b960c0a73 (17 revisions)
2023-12-04 egdaniel@google.com [Graphite] Track CommandBuffer refs for textures instead of Usage on CommandBuffer.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-04 19:54:17 +00:00
Bartek Pacia
79126777a4 Add support for exposing accessibility identifier as resource-id on Android (flutter/engine#47961) 
Accompanying framework PR: https://github.com/flutter/flutter/pull/138331

This PR implements support for exposing `SemanticsProperties.identifier` on Android as `resource-id`. Mainly targeted at https://github.com/flutter/flutter/issues/17988. Would also fix https://github.com/flutter/flutter/issues/issues/137735 but it was marked as duplicate. Anyway, there's a lot of context in that issue.

This PR requires changing the `SemanticsUpdateBuilder` interface (defined in engine) that framework depends on, so it requires introducing a temporary API ([see question I asked on Discord](https://discord.com/channels/608014603317936148/608018585025118217/1174845658033819729) to learn more about this approach).

Steps:
**part 1: [engine] add `SemanticsUpdateBuilderNew`** <-- we are here
part 2: [flutter] use `SemanticsUpdateBuilderNew`
part 3: [engine] update `SemanticsUpdateBuilder` to be the same as `SemanticsUpdateBuilderNew`*
part 4: [flutter] use (now updated) `SemanticsUpdateBuilder` again.
part 5: [engine] remove `SemanticsBuilderNew`

I'd like to do these changes first, and only then continue with [the proper framework PR](https://github.com/flutter/flutter/pull/138331).

*More specifically: update `SemanticsUpdateBuilder.updateNode()` to be the same as `SemanticsUpdateBuilderNew.updateNode()`. Number of arguments that function takes is the only change.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-04 19:27:18 +00:00
skia-flutter-autoroll
79fd09f39f Roll Skia from 540d76ea74f8 to db4a29e0689e (2 revisions) (flutter/engine#48633) 
https://skia.googlesource.com/skia.git/+log/540d76ea74f8..db4a29e0689e

2023-12-04 briansalomon@gmail.com Fix DawnBuffer map at creation on WebGPU.
2023-12-04 michaelludwig@google.com [skif] Check AutoSurface for empty bounds

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-04 19:04:34 +00:00
Casey Hillers
b81507fefe Only run firebase tests on HEAD (flutter/engine#48548) 
https://github.com/flutter/flutter/issues/138835
 2023-12-04 18:58:29 +00:00
skia-flutter-autoroll
9d7cdbab10 Roll Skia from 0ef49914a9f0 to 540d76ea74f8 (4 revisions) (flutter/engine#48627) 
https://skia.googlesource.com/skia.git/+log/0ef49914a9f0..540d76ea74f8

2023-12-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 74939d9e0784 to 26e8d593e8b8 (3 revisions)
2023-12-04 jamesgk@google.com [graphite] Start oval paths on right side when using a path effect
2023-12-04 yikong@google.com Revert "Turn off LTO for skia_nanobench on Android"
2023-12-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from e46d9832e720 to 2a25d971b790

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-04 17:17:18 +00:00
skia-flutter-autoroll
6efee0e79b Roll Skia from 00fc70025788 to 0ef49914a9f0 (2 revisions) (flutter/engine#48626) 
https://skia.googlesource.com/skia.git/+log/00fc70025788..0ef49914a9f0

2023-12-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from af4dd0fa7da7 to 7ce5da31c2af (20 revisions)
2023-12-04 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-04 16:23:20 +00:00
skia-flutter-autoroll
d5b484579e Roll Dart SDK from 0f7c94ba9f51 to 67f7a2c2559a (1 revision) (flutter/engine#48625) 
https://dart.googlesource.com/sdk.git/+log/0f7c94ba9f51..67f7a2c2559a

2023-12-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-188.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-04 16:21:20 +00:00
skia-flutter-autoroll
8d63caa6e4 Roll Fuchsia Linux SDK from UXMnwzl-9_YZaE_aV... to CGyrUgA1M1yFx5N5C... (flutter/engine#48620) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-04 09:44:37 +00:00
skia-flutter-autoroll
b83307231e Roll Dart SDK from 58ff03f2c17f to 0f7c94ba9f51 (1 revision) (flutter/engine#48619) 
https://dart.googlesource.com/sdk.git/+log/58ff03f2c17f..0f7c94ba9f51

2023-12-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-187.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-04 09:34:36 +00:00
skia-flutter-autoroll
c86fe2d3e1 Roll Dart SDK from a5d2b197c872 to 58ff03f2c17f (1 revision) (flutter/engine#48615) 
https://dart.googlesource.com/sdk.git/+log/a5d2b197c872..58ff03f2c17f

2023-12-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-186.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-03 21:23:36 +00:00
skia-flutter-autoroll
41ffe0f9e5 Roll Fuchsia Linux SDK from 4BVJFrqacT5kBTO2S... to UXMnwzl-9_YZaE_aV... (flutter/engine#48613) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-03 08:53:32 +00:00
skia-flutter-autoroll
6fcd8e0ac8 Roll Dart SDK from c7f18da440ab to a5d2b197c872 (1 revision) (flutter/engine#48611) 
https://dart.googlesource.com/sdk.git/+log/c7f18da440ab..a5d2b197c872

2023-12-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-185.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-03 05:29:24 +00:00
skia-flutter-autoroll
0c9ef85b39 Roll Dart SDK from f5216bb23cc3 to c7f18da440ab (1 revision) (flutter/engine#48608) 
https://dart.googlesource.com/sdk.git/+log/f5216bb23cc3..c7f18da440ab

2023-12-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-184.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-03 01:40:30 +00:00
skia-flutter-autoroll
836114f32c Roll Dart SDK from 3a44776466d6 to f5216bb23cc3 (1 revision) (flutter/engine#48605) 
https://dart.googlesource.com/sdk.git/+log/3a44776466d6..f5216bb23cc3

2023-12-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-183.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-02 21:32:30 +00:00
skia-flutter-autoroll
00586075f0 Roll Dart SDK from 286ef89d1875 to 3a44776466d6 (1 revision) (flutter/engine#48603) 
https://dart.googlesource.com/sdk.git/+log/286ef89d1875..3a44776466d6

2023-12-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-182.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-02 11:50:23 +00:00
skia-flutter-autoroll
98c46e770b Roll Dart SDK from aea874a703a2 to 286ef89d1875 (1 revision) (flutter/engine#48602) 
https://dart.googlesource.com/sdk.git/+log/aea874a703a2..286ef89d1875

2023-12-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-181.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-02 08:00:22 +00:00
skia-flutter-autoroll
dc5f6a1a82 Roll Skia from e0768dea5832 to 00fc70025788 (1 revision) (flutter/engine#48599) 
https://skia.googlesource.com/skia.git/+log/e0768dea5832..00fc70025788

2023-12-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 437623f714b8 to 4dba2348bc3c (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jcgregorio@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-02 06:30:22 +00:00
skia-flutter-autoroll
75ed8da884 Roll Fuchsia Linux SDK from oPdJSBgOI25vZ9Jby... to 4BVJFrqacT5kBTO2S... (flutter/engine#48600) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-02 06:24:03 +00:00
Yegor
d1ed887379 [web] remove ulimit and add -i to felt (flutter/engine#47414) 
The ulimit logic has been failing for me for months now and felt still
ran fine. I think we don't need it any more.

Also add the `-i` option for incremental runs of `felt`. It causes felt
to start faster because it doesn't run `pub get`. In the future, we can
also run felt from the snapshot for even faster start-up.
 2023-12-01 21:06:49 -08:00
skia-flutter-autoroll
968255733a Roll Skia from 5ea9dd4abfd7 to e0768dea5832 (1 revision) (flutter/engine#48597) 
https://skia.googlesource.com/skia.git/+log/5ea9dd4abfd7..e0768dea5832

2023-12-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 8efa9e01d8b3 to e46d9832e720

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jcgregorio@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-02 04:58:08 +00:00
skia-flutter-autoroll
6d982f221b Roll Dart SDK from 8d76eae70fa9 to aea874a703a2 (1 revision) (flutter/engine#48594) 
https://dart.googlesource.com/sdk.git/+log/8d76eae70fa9..aea874a703a2

2023-12-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-180.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-02 03:58:30 +00:00
skia-flutter-autoroll
8526731bb4 Roll Skia from 9277bdf97d06 to 5ea9dd4abfd7 (1 revision) (flutter/engine#48595) 
https://skia.googlesource.com/skia.git/+log/9277bdf97d06..5ea9dd4abfd7

2023-12-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 734ba4bb7c38 to 74939d9e0784 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jcgregorio@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-02 03:42:01 +00:00
Jim Graham
d0adfc3800 [Impeller] Directly tessellate stroked circles. (flutter/engine#48586) 
Similar work as done for filled circles in https://github.com/flutter/engine/pull/48103, stroked circles can also be directly tessellated using the same internal data structures used for filled circles.
 2023-12-02 02:44:26 +00:00
skia-flutter-autoroll
b78021851b Roll Dart SDK from a419c7050dcb to 8d76eae70fa9 (1 revision) (flutter/engine#48588) 
https://dart.googlesource.com/sdk.git/+log/a419c7050dcb..8d76eae70fa9

2023-12-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-179.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-01 23:58:04 +00:00
skia-flutter-autoroll
b1163124b1 Roll Skia from d55911b49773 to 9277bdf97d06 (1 revision) (flutter/engine#48583) 
https://skia.googlesource.com/skia.git/+log/d55911b49773..9277bdf97d06

2023-12-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 617c69313195 to a85db99b109f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jcgregorio@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-01 22:03:08 +00:00
skia-flutter-autoroll
047bb1e5e9 Roll Skia from 14dceac9d276 to d55911b49773 (1 revision) (flutter/engine#48580) 
https://skia.googlesource.com/skia.git/+log/14dceac9d276..d55911b49773

2023-12-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 4cf7a7a3f3b7 to 617c69313195

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jcgregorio@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-01 21:05:49 +00:00
skia-flutter-autoroll
cb73321daf Roll Skia from 5849e2b1aa8f to 14dceac9d276 (2 revisions) (flutter/engine#48577) 
https://skia.googlesource.com/skia.git/+log/5849e2b1aa8f..14dceac9d276

2023-12-01 bungeman@google.com [skdiff] Move to component build
2023-12-01 chengyangyang-hf@loongson.cn Add progress information for dm tests.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jcgregorio@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-01 20:16:06 +00:00
skia-flutter-autoroll
d96d9f23e4 Roll Dart SDK from d306bc3634c0 to a419c7050dcb (4 revisions) (flutter/engine#48578) 
https://dart.googlesource.com/sdk.git/+log/d306bc3634c0..a419c7050dcb

2023-12-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-178.0.dev
2023-12-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-177.0.dev
2023-12-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-176.0.dev
2023-12-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-175.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-01 20:12:06 +00:00
Victoria Ashworth
92ebf6056b Renable macOS 13 tests (flutter/engine#48418) 
A workaround was added for https://github.com/flutter/flutter/issues/138238, so let's re-enable macOS 13 tests

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-01 20:09:41 +00:00
Yegor
15d0ccaa77 [web] Implement multi-view for semantics (flutter/engine#48251) 
Implement multi-view for semantics. Main changes:

- `EngineSemanticsOwner` singleton is split into two classes:
- `EngineSemantics` is a singleton that manages global properties of the
semantics tree, such as whether semantics is currently enabled, and what
gesture mode is used.
- `EngineSemanticsOwner` now supports creating multiple instances of the
class. `EngineFlutterView` now points a `EngineSemanticsOwner` that it
owns.
- Fix a number of issues with disposal logic. Now that views can come in
and out disposal has to be more robust than previously.
`EngineSemanticsOwner` acquired a `reset()` and `SemanticsObject` acquired
 a `dispose()` that clean up the tree and individual nodes respectively.
- In particular, this fixes an issue in Skwasm mode where slight
differences in asynchrony caused the semantics test to fail because old
nodes continued firing events after they were removed from the document
due to improper disposal.
 2023-12-01 11:10:05 -08:00
Jim Graham
72ea712ff9 [Impeller] Fix size of squares in DrawPoints(PointMode). (flutter/engine#48547) 
Fixes: https://github.com/flutter/flutter/issues/138877

The existing golden tests were already showing this bug, but we didn't see it. With this fix the size of the squares should be the same as the circle for the round caps in the DrawPoints playground goldens.

Test exemption request: This fix is covered by existing golden tests.
 2023-12-01 17:39:29 +00:00
skia-flutter-autoroll
e809f7dfac Roll Skia from ecf10008c8bd to 5849e2b1aa8f (2 revisions) (flutter/engine#48569) 
https://skia.googlesource.com/skia.git/+log/ecf10008c8bd..5849e2b1aa8f

2023-12-01 kjlubick@google.com Remove Vulkan-specific code from GrProxyProvider
2023-12-01 kjlubick@google.com Remove isCompatible from GrSurfaceCharacteriziation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jcgregorio@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-01 16:00:10 +00:00
skia-flutter-autoroll
265e5e1a40 Roll Skia from 0ed7f26b3adb to ecf10008c8bd (1 revision) (flutter/engine#48568) 
https://skia.googlesource.com/skia.git/+log/0ed7f26b3adb..ecf10008c8bd

2023-12-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f4204cd3fb57 to 734ba4bb7c38 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jcgregorio@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-01 15:02:28 +00:00
skia-flutter-autoroll
25ba3f6a07 Roll Skia from e69fbf086bb6 to 0ed7f26b3adb (1 revision) (flutter/engine#48565) 
https://skia.googlesource.com/skia.git/+log/e69fbf086bb6..0ed7f26b3adb

2023-12-01 lovisolo@google.com Add Mokey and MokeyGo32 Perf tasks.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jcgregorio@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-01 14:26:23 +00:00
skia-flutter-autoroll
7523d9a4eb Roll Skia from 57c6a5a97dc5 to e69fbf086bb6 (1 revision) (flutter/engine#48562) 
https://skia.googlesource.com/skia.git/+log/57c6a5a97dc5..e69fbf086bb6

2023-12-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 6f4f5e3992cb to 3fe678c9b297 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jcgregorio@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-01 07:44:22 +00:00
skia-flutter-autoroll
ee725bee4d Roll Skia from b7b02ebaf770 to 57c6a5a97dc5 (1 revision) (flutter/engine#48561) 
https://skia.googlesource.com/skia.git/+log/b7b02ebaf770..57c6a5a97dc5

2023-12-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from cbcea6b43420 to 8efa9e01d8b3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jcgregorio@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-01 06:34:23 +00:00
skia-flutter-autoroll
6c1a247664 Roll Skia from 0a90c366ff87 to b7b02ebaf770 (3 revisions) (flutter/engine#48559) 
https://skia.googlesource.com/skia.git/+log/0a90c366ff87..b7b02ebaf770

2023-12-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 7da35cc63806 to af4dd0fa7da7 (35 revisions)
2023-12-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from e0a502ae9dab to 437623f714b8 (1 revision)
2023-12-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9b8a5224f9db to f4204cd3fb57 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jcgregorio@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-01 05:46:16 +00:00
skia-flutter-autoroll
047cf29b28 Roll Fuchsia Linux SDK from Bb2k375udWIltCEAx... to oPdJSBgOI25vZ9Jby... (flutter/engine#48558) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-01 05:34:32 +00:00
Matan Lurey
6e99e081fe Roll a new version of googletest (2021->2023). (flutter/engine#48285) 2023-11-30 17:50:30 -08:00
Harry Terkelsen
0bac7851a8 [canvaskit] Add ImageFilter.compose (flutter/engine#48546) 
Adds ImageFilter.compose support in CanvasKit. Previously this would
crash.

Fixes https://github.com/flutter/flutter/issues/120123

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-11-30 16:37:07 -08:00
Dan Field
874ceb4863 Avoid reloading the kernel snapshot when spawning an isolate in the same group (flutter/engine#48478) 
Found by @mraleph while looking at flutter_tester related things with me.

I took some suggestions from him and added a test. This should eventually help speed up running large multi-file test suites.

The test is a little bit wonky because we don't have great inspection points (e.g. something to mock or examine from a test). It should break if we change the way we load kernel assets in the test harness, and is verifying that we only ask for the test asset once where we used to ask for it twice.
 2023-12-01 00:32:31 +00:00
Camille Simon
7965fd759e [Android] Check for text to paste before trying to retrieve data from URI (flutter/engine#48166) 
Adds a check to retrieve explicit text from Clipboard items via [`getText`](https://developer.android.com/reference/android/content/ClipData.Item#getText()) before attempting to retrieve data if the Clipboard item (`ClipData.Item`) has an associated URI. Also adds more error handling for edge cases concerning URIs (the URI not having the content scheme or being null).

Fixes https://github.com/flutter/flutter/issues/74320. Some content providers will not send URIs containing the `text/*` pattern or have the content scheme (`content://`), but ultimately we should expect Clipboard items to either fall **not** into one of those categories or have an explicit textual value available via `getText`. In case this is not true, though, checks for non-content URIs and null URIs are added, as well :)

Tested on a Samsung tablet with pasting from MS Word, MS Excel, and Samsung Notes.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-12-01 00:04:42 +00:00
skia-flutter-autoroll
3ffeaa87b6 Roll Skia from 88a1bcb9e43e to 0a90c366ff87 (3 revisions) (flutter/engine#48549) 
https://skia.googlesource.com/skia.git/+log/88a1bcb9e43e..0a90c366ff87

2023-11-30 fmalita@chromium.org [skottie] Plumb orignal font family name to SkShaper
2023-11-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from e6b1b3f50cf0 to 4cf7a7a3f3b7
2023-11-30 lovisolo@google.com [bazel] Gold and Perf traces: Include compilation_mode key/value pair.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jcgregorio@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-30 23:50:29 +00:00
skia-flutter-autoroll
ea91f710de Manual roll Dart SDK to 3.3.0-174.2.beta (4 revisions) (flutter/engine#48538) 
Manual roll requested by zra@google.com

https://dart.googlesource.com/sdk.git/+log/b58735e626f6..d24e4354ee54

2023-11-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.3.0-174.0.dev
2023-11-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.3.0-173.0.dev
2023-11-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.3.0-172.0.dev
2023-11-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.3.0-171.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,matanl@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

---------

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
 2023-11-30 15:35:57 -08:00
skia-flutter-autoroll
b28dfcfcb9 Roll Skia from db3399a541f3 to 88a1bcb9e43e (1 revision) (flutter/engine#48545) 
https://skia.googlesource.com/skia.git/+log/db3399a541f3..88a1bcb9e43e

2023-11-30 michaelludwig@google.com [skif] Fix ignore-ctm sigma adjustment for mask->image filters

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jcgregorio@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-11-30 22:51:56 +00:00
Loïc Sharma
f5cacea14a [Windows] Begin decoupling text input plugin from the view (flutter/engine#47833) 
Currently the text input plugin is strongly tied to a single view. This change makes the text input plugin tied to the engine in preparation for multi-view world.

Part of https://github.com/flutter/flutter/issues/115611

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-11-30 21:49:14 +00:00