9oya
0c7bc2f9c9
Implement CheckmarkableChipAttributes on ChoiceChip ( #124743 )
2023-04-20 11:43:49 -07:00
Flutter GitHub Bot
d85e2fb810
Roll pub packages ( #125225 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-04-20 18:28:10 +00:00
chunhtai
5764404f5c
fix localization typo for expansionTileExpandedHint ( #125212 )
...
as title
2023-04-20 18:23:06 +00:00
Justin McCandless
13f4fe4091
Show iOS menu on iOS for TextField by default ( #124895 )
...
Even in TextField using the Material library, iOS devices will still show the iOS-style spell check toolbar by default when using spell check.
2023-04-20 11:09:37 -07:00
Ben Konyi
0d023144d9
Fix race condition in flutter test when passing --serve-observatory ( #123556 )
...
`flutter test` wasn't awaiting the `_serveObservatory` request which was
causing a race condition in the `flutter test should respect
--serve-observatory` test in `test/integration.general/test_test.dart`.
Related to https://github.com/flutter/flutter/issues/123516
2023-04-20 13:46:33 -04:00
Flutter GitHub Bot
a573d1aeee
Roll pub packages ( #125050 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-04-20 17:36:10 +00:00
Christopher Fujino
800175af6b
[flutter_tools] make overall_experience_test resilient to extraneous pub output ( #125172 )
...
use `containsAllInOrder` so that pub output doesn't cause htis test to fail, as in https://ci.chromium.org/p/flutter/builders/try/Linux%20tool_tests_general/22929 ?
2023-04-20 17:31:58 +00:00
chunhtai
8ac94c16b2
MinimumTapTargetGuideline skips nodes at scrollable boundaries ( #124615 )
...
fixes https://github.com/flutter/flutter/issues/107615
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-04-20 09:09:55 -07:00
engine-flutter-autoroll
70ca469792
Roll Packages from 88591becfb3f to 746750ecef78 (4 revisions) ( #125208 )
...
88591becfb...746750ecefstuartmorgan@google.com [pigeon] Add an initial example app (flutter/packages#3761 )
2023-04-20 imagipioneer@gmail.com [google_maps_flutter_web] Allow marker position updates (flutter/packages#3697 )
2023-04-19 tarrinneal@gmail.com [Tool] [Code Excerpt] allow excerpts in example readme (flutter/packages#3758 )
2023-04-19 47866232+chunhtai@users.noreply.github.com [go_router] migrates test for route information.location deprecation (flutter/packages#3763 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-20 15:53:21 +00:00
Reid Baker
64591356b9
i125138 abstract method smoke agp update ( #125139 )
...
- Update gradle and AGP version for abstract_method_smoke_test
#125138 part 1/N
To update successfully:
1. Update gradle to a version supported by jdk 17
2. Uncommented the lockfile lines in android/build.gradle
3. Then ran the AGP update assistant from AndroidStudio -> tools
4. From android ran `./gradlew dependencies --write-locks`
5. From android/app ran `./gradlew dependencies --write-locks`
6. Re enabled the lockfiles section of android/build.gradle
7. Ensured `flutter build apk` passed
2023-04-20 15:16:18 +00:00
xubaolin
9f2e708831
DropdownMenu.width should support updating at runtime (#124847 )
...
Fixes https://github.com/flutter/flutter/issues/120567
2023-04-20 11:39:25 +00:00
engine-flutter-autoroll
b04efe4ecf
Roll Flutter Engine from d726345bf230 to 2db85cbe6a01 (4 revisions) ( #125183 )
...
d726345bf2...2db85cbe6askia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from suSuT9F8zuP-pBg-E... to OcPCdaE17MAihaCrD... (flutter/engine#41352 )
2023-04-19 skia-flutter-autoroll@skia.org Roll Dart SDK from fe8bb0565a30 to 88a3b66b50d6 (2 revisions) (flutter/engine#41349 )
2023-04-19 bdero@google.com Add missing header guards (flutter/engine#41322 )
2023-04-19 joshualitt@google.com [web] Fix trivial type issue. (flutter/engine#40956 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from suSuT9F8zuP- to OcPCdaE17MAi
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-20 05:31:24 +00:00
Qun Cheng
3315b25740
Make search view shape clip the view content ( #125161 )
...
Fixes #124426
This PR is to make the search view shape clip the view content.
Before: the highlight and the "i" of "item 9" are not clipped by the shape.
<img width="350" alt="Screenshot 2023-04-19 at 12 09 48 PM" src="https://user-images.githubusercontent.com/36861262/233201222-468820a9-8717-4b6c-8528-8125a40fc161.png ">
After:
<img width="350" alt="Screenshot 2023-04-19 at 2 13 52 PM" src="https://user-images.githubusercontent.com/36861262/233201609-81f5a942-2390-4081-a9c7-c9523a7f9e72.png ">
2023-04-20 04:50:52 +00:00
Renzo Olivares
8ed26d8b8e
Show magnifier on touch drag gestures ( #125151 )
...
This change shows the magnifier on touch drag gestures for Android and iOS and hides it when the drag ends.
Fixes #118268
2023-04-20 04:49:05 +00:00
Kevin Moore
f5b0f0a2b6
Report web compiler used with buildEventSettings ( #125092 )
...
Fixes https://github.com/flutter/flutter/issues/125085
2023-04-19 22:19:21 +00:00
Andrew Kolos
c74cf4ba40
[flutter_tools] bump min sdk version from 3.0.0-0 to 3.0.0 ( #125158 )
...
Allows use of APIs such as `Iterable.firstOrNull`.
2023-04-19 22:03:13 +00:00
Andrew Kolos
fa43a93bc5
[flutter_tools] add todo for userMessages ( #125156 )
...
Adds `todo` link in code for #125155 .
2023-04-19 21:29:24 +00:00
xubaolin
73f7945ba2
fix DropdownMenu crash when resize window during menu showing ( #124855 )
2023-04-19 14:21:49 -07:00
engine-flutter-autoroll
ea34f7df34
Roll Flutter Engine from 0a53cf6f7a4e to d726345bf230 (2 revisions) ( #125157 )
...
0a53cf6f7a...d726345bf2bdero@google.com [Impeller] Comprehensively label snapshots (flutter/engine#41325 )
2023-04-19 bdero@google.com [Impeller] Fix transform regressions for chained filters (flutter/engine#41332 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-19 20:41:59 +00:00
Victoria Ashworth
48bb3c0bc9
Use term wireless instead of network ( #124232 )
...
Rename variables, update comments, etc from `network` to `wireless` to keep it more uniform.
Also, move non-overriden messages related to device selection into the file they're used.
Part 7 in breakdown of https://github.com/flutter/flutter/pull/121262 .
2023-04-19 19:59:11 +00:00
chunhtai
14e191fa75
Revert selectable update back to be a postframecallback or microtask ( #125140 )
...
The regression was caused by the previous pr https://github.com/flutter/flutter/pull/124624 changes postframecallback to scheduleframecallback. The reason is that if a new postframecallback was scheduled when running a postframecallback. The newly added postframecallback will be execute on the next frame. However, adding postframecallback will not schedule a new frame. So if there isn't other widget that schedule a new frame, the newly added postframecallback will never gets run.
After changing to scheduleframecallback, it causes an issue that transient callback may be called when rendering tree contains dirty layout information that are waiting to be rebuilt.
Therefore, I use microtask to get around of the postframecallback issue instead of scheduleframecallback.
fixes https://github.com/flutter/flutter/issues/125065
2023-04-19 19:48:12 +00:00
engine-flutter-autoroll
898767f945
Roll Packages from faf53fb3998c to 88591becfb3f (6 revisions) ( #125153 )
...
faf53fb399...88591becfbengine-flutter-autoroll@skia.org Roll Flutter from 42fb0b23139c to 3476b966524f (20 revisions) (flutter/packages#3760 )
2023-04-19 49699333+dependabot[bot]@users.noreply.github.com Bump cirrusci/flutter from `794fbbc` to `d99b1ba` in /.ci (flutter/packages#3724 )
2023-04-18 10687576+bparrishMines@users.noreply.github.com [webview_flutter] Adds support to listen to url changes (flutter/packages#3313 )
2023-04-18 engine-flutter-autoroll@skia.org Roll Flutter from 15cb1f84d726 to 42fb0b23139c (19 revisions) (flutter/packages#3756 )
2023-04-18 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump com.android.tools.build:gradle from 7.2.2 to 8.0.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#3739 )
2023-04-18 stuartmorgan@google.com [local_auth] Convert Android to Pigeon (flutter/packages#3748 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-19 19:36:07 +00:00
engine-flutter-autoroll
481ac3ce44
Roll Flutter Engine from d626f16cb9a3 to 0a53cf6f7a4e (1 revision) ( #125152 )
...
d626f16cb9...0a53cf6f7achinmaygarde@google.com [Impeller] Make //impeller/display_list TU naming consistent. (flutter/engine#41174 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-19 19:25:13 +00:00
Elias Yishak
ca3a900d5d
[reland] Update helper message for --suppress-analytics ( #125145 )
...
Relanding: https://github.com/flutter/flutter/pull/124810
Fixes: https://github.com/flutter/flutter/issues/124808
2023-04-19 18:51:08 +00:00
Qun Cheng
4c6929d4c9
Dismiss the docked search view when the window size is changed ( #125071 )
2023-04-19 11:23:20 -07:00
engine-flutter-autoroll
4473899532
Roll Flutter Engine from 609f9d536494 to d626f16cb9a3 (9 revisions) ( #125150 )
...
609f9d5364...d626f16cb9mdebbar@google.com [web] Remove non-ShadowDom mode (flutter/engine#39915 )
2023-04-19 30870216+gaaclarke@users.noreply.github.com [impeller] added moltenvk notice (flutter/engine#41317 )
2023-04-19 skia-flutter-autoroll@skia.org Roll Skia from 8af1dd9659f0 to ad90b6bd4760 (3 revisions) (flutter/engine#41337 )
2023-04-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 27e71f19c144 to fe8bb0565a30 (2 revisions) (flutter/engine#41336 )
2023-04-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from yD5a3QBJHUFM4nVou... to suSuT9F8zuP-pBg-E... (flutter/engine#41334 )
2023-04-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Cy5LG4U2InaFLkJGz... to Tun7i4VLz6ncx8JJJ... (flutter/engine#41331 )
2023-04-19 skia-flutter-autoroll@skia.org Roll Skia from 85d9e67653b1 to 8af1dd9659f0 (1 revision) (flutter/engine#41333 )
2023-04-19 skia-flutter-autoroll@skia.org Roll Skia from 5a718d9e9c06 to 85d9e67653b1 (4 revisions) (flutter/engine#41330 )
2023-04-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 1f224df52bee to 27e71f19c144 (3 revisions) (flutter/engine#41329 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Cy5LG4U2InaF to Tun7i4VLz6nc
fuchsia/sdk/core/mac-amd64 from yD5a3QBJHUFM to suSuT9F8zuP-
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-19 18:20:07 +00:00
Bartek Pacia
51251f2e57
Refactor Flutter Gradle Plugin so it can be applied using the declarative plugins {} block ( #123511 )
...
This PR aims to resolve #121552 .
Resources used:
- [Developing Plugins](https://docs.gradle.org/current/userguide/custom_plugins.html )
- [Using Gradle Plugins](https://docs.gradle.org/current/userguide/plugins.html#sec:plugins_block )
- [Composite Builds Plugin Development Sample](https://docs.gradle.org/current/samples/sample_composite_builds_plugin_development.html )
This PR also paves way for #121541 , because apps will no longer have:
```groovy
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"
```
hardcoded. Instead, they'll use:
```groovy
plugins {
// ...
id "dev.flutter.flutter-gradle-plugin" // the exact name is tentative
}
```
2023-04-19 17:56:22 +00:00
chunhtai
122dacfa1a
fix SliverReorderableList test to use correct custom action id ( #125144 )
...
as title
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-04-19 10:31:36 -07:00
godofredoc
03d725620a
Revert "Update helper message for --suppress-analytics" ( #125141 )
...
Reverts flutter/flutter#124810
2023-04-19 16:43:29 +00:00
Elias Yishak
3476b96652
Update helper message for --suppress-analytics ( #124810 )
...
Fixes: https://github.com/flutter/flutter/issues/124808
2023-04-19 14:00:20 +00:00
engine-flutter-autoroll
59230759be
Roll Flutter Engine from 8b7cdb02f7f3 to 609f9d536494 (1 revision) ( #125097 )
...
8b7cdb02f7...609f9d5364bdero@google.com [Impeller] Add buffer-to-texture blit capability check; fix GL+VK playgrounds on macOS (flutter/engine#41320 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-19 06:39:50 +00:00
engine-flutter-autoroll
ade9487d68
Roll Flutter Engine from 099ed6c62d04 to 8b7cdb02f7f3 (6 revisions) ( #125094 )
...
099ed6c62d...8b7cdb02f7aam@google.com Roll dart, zlib, emscripten, tweak license script for rolled zlib (flutter/engine#41299 )
2023-04-19 skia-flutter-autoroll@skia.org Roll Skia from 84630c3c18b2 to 5a718d9e9c06 (3 revisions) (flutter/engine#41318 )
2023-04-19 bdero@google.com [Impeller] Provide an opaque interface for color sources in Aiks (flutter/engine#41315 )
2023-04-18 yjbanov@google.com [web:canvaskit] remove unnecessary instrumentation from picture (flutter/engine#41313 )
2023-04-18 skia-flutter-autoroll@skia.org Roll Skia from 476ee3fd54cc to 84630c3c18b2 (5 revisions) (flutter/engine#41316 )
2023-04-18 godofredoc@google.com Double zip FlutterMacOS.framework.zip. (flutter/engine#41306 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-19 05:43:29 +00:00
engine-flutter-autoroll
d9392f2e2a
Roll Flutter Engine from 5fcc7b719029 to 099ed6c62d04 (3 revisions) ( #125078 )
...
5fcc7b7190...099ed6c62dskia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from qZHSvkpAU1-YYGvYc... to yD5a3QBJHUFM4nVou... (flutter/engine#41314 )
2023-04-18 yjbanov@google.com [web:canvaskit] clean up the rest of skia_object_cache usages (flutter/engine#41259 )
2023-04-18 skia-flutter-autoroll@skia.org Roll Skia from f80ee1088861 to 476ee3fd54cc (2 revisions) (flutter/engine#41309 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from qZHSvkpAU1-Y to yD5a3QBJHUFM
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-19 00:31:26 +00:00
Justin McCandless
3128df832a
Disableable ContextMenuButtonItems ( #124253 )
...
Fixes https://github.com/flutter/flutter/issues/124247
| Native | Flutter before | Flutter after |
| --- | --- | --- |
| <img width="248" alt="Screenshot 2023-04-05 at 9 26 16 AM" src="https://user-images.githubusercontent.com/389558/230177116-154999e8-eef3-441d-9fe9-7063839a6b99.png "> | <img width="240" alt="Screenshot 2023-04-05 at 11 18 01 AM" src="https://user-images.githubusercontent.com/389558/230177125-1680e851-223e-4956-b5b6-1a24e11dc22a.png "> | <img width="226" alt="Screenshot 2023-04-05 at 11 17 36 AM" src="https://user-images.githubusercontent.com/389558/230177123-bde82134-67e1-4ce2-8eec-719eeb779bf4.png "> |
Also, it's now possible for anyone to create disabled buttons like this by setting ContextMenuButtonItem.onPressed to `null`.
2023-04-19 00:09:34 +00:00
Mitchell Goodwin
bd2617ecb9
Adaptive alert dialog ( #124336 )
...
Fixes #102811 . Adds an adaptive constructor to AlertDialog, along with the adaptive function showAdaptiveDialog.
<img width="357" alt="Screenshot 2023-04-06 at 10 40 18 AM" src="https://user-images.githubusercontent.com/58190796/230455412-31100922-cfc5-4252-b8c6-6f076353f29e.png ">
<img width="350" alt="Screenshot 2023-04-06 at 10 42 50 AM" src="https://user-images.githubusercontent.com/58190796/230455454-363dd37e-c44e-4aca-b6a0-cfa1d959f606.png ">
2023-04-18 23:00:03 +00:00
engine-flutter-autoroll
c05bc400f9
Roll Flutter Engine from 6d263ea56a62 to 5fcc7b719029 (4 revisions) ( #125069 )
...
6d263ea56a...5fcc7b7190dnfield@google.com [Impeller] Gpu model information to Skia gold (flutter/engine#41216 )
2023-04-18 30870216+gaaclarke@users.noreply.github.com [Impeller] faster glyph atlas generation by removing data copies (flutter/engine#41290 )
2023-04-18 godofredoc@google.com Migrate android AOT to engine_v2. (flutter/engine#41229 )
2023-04-18 skia-flutter-autoroll@skia.org Roll Skia from 5bd4bdc0d8e2 to f80ee1088861 (8 revisions) (flutter/engine#41302 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-18 22:25:15 +00:00
Srujan Gaddam
6edbc19597
Remove package:js/dart:js_interop conflicts ( #124879 )
...
dart:js_interop and package:js will start conflicting, since they both have an `@JS` annotation. Until we're ready to only use dart:js_interop (which will require updating the SDK constraints of every package), we should hide the `@JS` annotation from dart:js_interop. Due to shadowing, this is the behavior today, so there should be no functional change.
Unblocks https://dart-review.googlesource.com/c/sdk/+/294130/8 and prevents confusing shadowing of dart:js_interop annotations like we do today.
- [Mentioned CL that is unblocked] I listed at least one issue that this PR fixes in the description above.
- [Need test-exemption] I added new tests to check the change I am making, or this PR is [test-exempt].
- [Need to run] All existing and new tests are passing.
2023-04-18 22:15:53 +00:00
Samuel Abada
81c3bc5687
Remove double.fromEnvironment from dart-define doc ( #124102 )
...
Remove double.fromEnvironment from dart-define doc.
Fixes #124665
The current dart-define docs reads:
```
Additional key-value pairs that will be available as constants from the String.fromEnvironment, bool.fromEnvironment, int.fromEnvironment, and
double.fromEnvironment constructors.
```
while dart-define-from-file reads:
```
The path of a json format file where flutter define a global constant pool.
Json entry will be available as constants from the String.fromEnvironment, bool.fromEnvironment, int.fromEnvironment,
and double.fromEnvironment constructors; the key and field are json values
```
<img width="1440" alt="Screenshot 2023-04-03 at 19 31 34" src="https://user-images.githubusercontent.com/31275429/229720102-2020e1a9-c1fb-470b-89e6-ffb84096a51b.png ">
However, there is no fromEnvironment constructor for double. The aim of this PR is to address this by removing double.fromEnvironment from help docs as stated in
2023-04-18 21:52:52 +00:00
Kim Jiun
e2a2046014
Update to add Kim Jiun to AUTHORS ( #125026 )
...
Adding my name (Kim Jiun) to Authors.
REF : https://github.com/flutter/flutter/pull/91496
Thanks!
2023-04-18 21:52:49 +00:00
Greg Spencer
4b39f071f3
Add controller argument to SubmenuButton ( #125000 )
...
## Description
This adds an optional argument to the `SubmenuButton` that allows the creator to supply a `MenuController` for controlling the menu.
## Related Issues
- Fixes https://github.com/flutter/flutter/issues/124988
## Tests
- Added tests for new argument.
2023-04-18 21:09:53 +00:00
engine-flutter-autoroll
98dfdf1b6c
Roll Flutter Engine from 879308a52228 to 6d263ea56a62 (1 revision) ( #125060 )
...
879308a522...6d263ea56agspencergoog@users.noreply.github.com Some minor doc typo and diagnostic fixes. (flutter/engine#40982 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-18 20:35:34 +00:00
Justin McCandless
f04a5afb58
Limit the number of Material spell check suggestions to 3 ( #124899 )
...
Fixes a bug where the spell check menu could overflow.
2023-04-18 12:50:12 -07:00
Jenn Magder
0ea2f3b530
Remove impeller testowners ( #125056 )
...
Remove TESTOWNERS matching the removed impeller tests in https://github.com/flutter/flutter/pull/125044 .
Filed https://github.com/flutter/flutter/issues/125055 since I believe the mismatch should have been caught in that PR.
2023-04-18 19:35:05 +00:00
htoor3
cb90ae4d97
[web] - Clean up skipped tests ( #124981 )
...
Fixes https://github.com/flutter/flutter/issues/124174
Fixes https://github.com/flutter/flutter/issues/124980
2023-04-18 19:31:18 +00:00
engine-flutter-autoroll
ad784bf843
Roll Flutter Engine from 72b68622fffa to 879308a52228 (1 revision) ( #125057 )
...
72b68622ff...879308a52230870216+gaaclarke@users.noreply.github.com [Impeller] Turned on wide gamut support by default. (flutter/engine#39801 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-18 19:14:05 +00:00
Michael Goderbauer
df811c6d79
Remove unused getRootRenderObject and getSelectedRenderObject service extensions ( #124805 )
...
These are currently unused and will not work in a multi-view environment where we will have multiple render trees.
Work towards https://github.com/flutter/flutter/issues/121573 .
2023-04-18 18:54:27 +00:00
Tae Hyung Kim
b6c7df447d
l10n.yaml's nullable-getter option should default to true ( #124353 )
...
Currently, nullable-getter defaults to false when l10n.yaml is not present, which is not the same behavior as when an l10n.yaml file is present and nullable-getter is not set.
Fixes #120457 .
2023-04-18 18:42:07 +00:00
engine-flutter-autoroll
9b530298fa
Roll Flutter Engine from 55bb065c607b to 72b68622fffa (1 revision) ( #125053 )
...
55bb065c60...72b68622ffskia-flutter-autoroll@skia.org Manual roll Skia from d9e216e62223 to 5bd4bdc0d8e2 (12 revisions) (flutter/engine#41286 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-04-18 18:19:07 +00:00
chunhtai
55502fc36a
Add vmservice for android build options ( #123034 )
...
https://github.com/flutter/flutter/issues/120408
2023-04-18 18:16:09 +00:00
Kate Lovett
42fb0b2313
Fix text theme dart fix cases ( #125052 )
...
Fixes https://github.com/flutter/flutter/issues/125049
This is blocking the dart roll, dart fix will now fix some invalid code that was in these test cases. These test case files are un-analyzed intentionally because they are by nature samples of broken code.
2023-04-18 18:06:06 +00:00
