9829 Commits

Author SHA1 Message Date
Alexander Aprelev
0c5dd8d31e
Add hot_mode preview_dart_2 tests for ios. (#14022)
* Add hot_mode preview_dart_2 tests for ios.

* Explicitly request ios os in the test.

* 2018
2018-01-10 13:06:53 -08:00
Jason Simmons
77872cc560
libtxt: update paragraph_text for current libtxt behavior (#14004)
* libtxt now calculates selection rectangles reflecting the heights of
differently styled text spans within a line (matching Blink)
* libtxt does not round the coordinates of selection rectangles (unlike Blink)
2018-01-10 10:27:59 -08:00
Michael Goderbauer
46629b7187
Do not crash when toggling Semantics on, off, on (#13999)
* Do not crash when toggeling Semantics on, off, on

* review comments
2018-01-10 10:12:36 -08:00
Ian Hickson
316d8e1c2c
Make DecoratedBox repaint after being reparented (#13927)
Fixes https://github.com/flutter/flutter/issues/12553

The root cause of https://github.com/flutter/flutter/issues/12553 was that when the refresh indicator went away, which happened after the avatars had started their image loads but before the avatars had loaded, the DecoratedBoxes, along with the rest of the list, got GlobalKey-reparented, which caused the RenderDecoratedBox objects to unregister from the DecorationImagePainters, but they never re-registered since the whole subtree was in a RepaintBoundary and was therefore not explicitly repainted when the tree got reattached.

This fixes the bug by explicitly requiring any RenderDecoratedBox to repaint when it's reattached. This is probably a little more aggressive than required; we could probably expose a flag on Decoration that says whether or not the onChanged handler will ever be invoked, and only call markNeedsPaint if that's true, but we'll do that if it turns out that there's a performance issue here.

(This patch also introduces a bunch of improved debugging information that I used to track down the bug.)
2018-01-09 20:26:37 -08:00
Greg Spencer
6fda8ee821
Reverting package changes until I can figure out how to fix Windows. (#14007)
* Revert "Fixed output validation. (#14005)"

This reverts commit d84398db72807f8910833d5fe44a097be152c74a.

* Revert "Update package prep script to do async process execution and emit output as it happens. (#13918)"

This reverts commit b7169c1d951aa188c1cdc3b980e257e8a92f8abe.
2018-01-09 19:47:19 -08:00
Greg Spencer
d84398db72
Fixed output validation. (#14005) 2018-01-09 18:08:26 -08:00
Greg Spencer
b7169c1d95
Update package prep script to do async process execution and emit output as it happens. (#13918)
- Switches to async process execution, which now shows output as it happens instead of in chunks when the process completes
-  Now uses ProcessManager so that it may be mocked for the test.
- Adds in the download and install of mingit on Windows.
- Updated package dependencies because of added dependency on process package.
2018-01-09 17:42:42 -08:00
Ben Konyi
64aac3d3cb Rolled engine to 5a72197b733c01537a6583fa3715155d9fc936ef 2018-01-09 16:19:32 -08:00
Hans Muller
03e8ab1f53
Add support for a new kind of InkSplash: the "ripple" (#13986) 2018-01-09 14:43:08 -08:00
xster
c5c63dfd47
Don't flush touch events during first launch frame pre-warm (#13990)
* Lock events during runApp's warm up frame

* move to scheduler binding

* let the one scheduleWarmUpFrame api always lock

* tweak test
2018-01-09 14:05:12 -08:00
Michael Goderbauer
8a6e973739
Remove semantics boundary from gesture detector AND MORE (#13983)
`RenderSemanticsGestureHandler` is no longer a semantics boundary, which allows us to correctly mark disabled buttons as disabled without having their semantics size and semantics node id change unexpectedly.

Fixes https://github.com/flutter/flutter/issues/12589.
Fixes https://github.com/flutter/flutter/issues/11991.
See also https://github.com/flutter/flutter/issues/11993.

This change also required some refactoring to how we deal with `twoPaneSemantics` scrolling as it previously relied on `RenderSemanticsGestureHandler` being a semantics boundary. This should also make the underlying logic easier to understand.

In addition, the following minor changes are included in this PR:
* Removal of orphaned and unused `SemanticsConfiguration.isMergingDescendantsIntoOneNode`.
* Logic optimizations for `markNeedsSemanticsUpdate` .
* Fix for edge case where `MergeSemantics` failed to merge semantics.
* Use of emojis to better indicate leaf merging in the printed semantics tree.
* Better assert message for adding invisible child semantics nodes.
* Make some semantics tests robuster by not relying on creation order of SemanticsNode ids across test boundaries.

Fixes https://github.com/flutter/flutter/issues/13943.
2018-01-09 13:31:59 -08:00
jcollins-g
33d8a03545
Revert "Make artifact downloading more robust for flaky networks" (#13995)
* Revert "Change github readme links to be served by github (#13929)"

This reverts commit fd516d9538e23dcfebf48ddc0efd7041fe8068cd.

* Revert " Rename SemanticsFlags to SemanticsFlag (#13994)"

This reverts commit 24e3f7053671713e05ee6be29c5ba88ed8fce543.

* Revert "Make artifact downloading more robust for flaky networks (#13984)"

This reverts commit 4d37e03e1d93eb88ed47a43fe5b08a25dca86171.
2018-01-09 12:15:58 -08:00
Michael Thomsen
fd516d9538
Change github readme links to be served by github (#13929) 2018-01-09 19:37:59 +01:00
Michael Goderbauer
24e3f70536
Rename SemanticsFlags to SemanticsFlag (#13994)
to align with `SemanticsAction` and other enum-like types.
2018-01-09 10:31:23 -08:00
jcollins-g
4d37e03e1d
Make artifact downloading more robust for flaky networks (#13984)
* First version

* Add a clarifying comment

* Add verify to ZipDecoder.decodeBytes call

* Review comments

* Need OS Error for missing files

* FileSystemException, not OSError.
2018-01-09 10:30:42 -08:00
Ian Hickson
9b92c919a0
Imply stops on LinearGradient and RadialGradient if they're missing (#13987) 2018-01-09 08:22:17 -08:00
Ian Hickson
77711d4a3c
Try to work better on NFS (#13955)
(untested)
2018-01-08 23:19:21 -08:00
Ian Hickson
7cf58702c1
Wrap _debug flag setting in asserts. (#13974)
Fixes the last bits of #5759.
2018-01-08 21:39:50 -08:00
Ian Hickson
3905d99109
Minor doc improvements. (#13969) 2018-01-08 21:39:40 -08:00
Ian Hickson
9114e2afd1
The dependency script wasn't catching quite all our transitive dependencies (#13954) 2018-01-08 21:39:33 -08:00
Ian Hickson
b50ccc49d5
Test for Transform in Padding (#13898) 2018-01-08 21:39:25 -08:00
Ian Hickson
ce83f4fbe2
Make updateUserScrollDirection protected (#13850) 2018-01-08 21:39:16 -08:00
amirh
61a8132ea9
Revert "Push physical layers with paths instead of rects in RenderPhysicalModel. (#13942)" (#13988)
This reverts commit 57b4a52555388a613d3e4d5378b5bdf761d5f8df.
2018-01-08 19:24:19 -08:00
amirh
57b4a52555
Push physical layers with paths instead of rects in RenderPhysicalModel. (#13942) 2018-01-08 18:41:16 -08:00
xster
0f11de2e06
add email to the text fields demo (#13946) 2018-01-08 16:57:52 -08:00
Jason Simmons
4954bbfaf9
Read properties files as UTF-8 in Gradle scripts (#13981)
Fixes https://github.com/flutter/flutter/issues/13972
2018-01-08 13:48:08 -08:00
P.Y. Laligand
1954ffcaf5
[fuchsia] dart_package is now dart_library. (#13979) 2018-01-08 13:16:46 -08:00
Ryan Macnak
3782415d15 Roll engine to 6a724f0d3e22d41246baf3447d7ba2c9ff886765. 2018-01-08 11:09:09 -08:00
Ryan Macnak
a3f523742c Roll engine to bbefdf198043c900277b0024e6bd12614917d0e4. 2018-01-08 11:09:09 -08:00
Hans Muller
d188a8ff6b
Update InputDecorator et al (#13734) 2018-01-08 10:36:52 -08:00
Alexander Aprelev
c3366a65e1
Set asset directory path only on first hot reload. (#13934) 2018-01-08 10:05:44 -08:00
Mikkel Nygaard Ravn
0a96f96c4f
Update and simplify Android templates (#13970) 2018-01-08 15:01:43 +01:00
Alexander Aprelev
86c6ce99a3
Remove pinning that became obsolete once we moved up to gradle 4.1 (#13963) 2018-01-06 13:42:11 -08:00
Brian Egan
c3fab029c2 Idea: Provide initial data to the StreamBuilder (#13820) 2018-01-06 15:49:29 +01:00
Mikkel Nygaard Ravn
c669c62ecf
Update Android template instances - retake 2 (#13928) 2018-01-06 12:02:33 +01:00
Alexander Aprelev
60c5fed12d
Pin connectivity and device_info to unbreak build. (#13959) 2018-01-05 23:52:54 -08:00
Alexander Aprelev
fdbbfc3b32
Pin url_launcher package to prevent major version upgrade (#13952)
* Pin url_launcher to 1.0.3

* Commit results of 'bin/flutter update-packages --force-upgrade'

* Added TODO
2018-01-05 22:54:44 -08:00
Alexander Aprelev
50a28785bd
Update dependencies to bring updated dependency on watcher-0.9.7+6 (#13949) 2018-01-05 21:19:03 -08:00
Alexander Aprelev
27c61eeb50
Explicitly report CFE output(when using --preview-dart-2) (#13936)
* Explicitly report CFE output(when using --preview-dart-2)

* Fix test so it looks at errorText

* Fix expected text
2018-01-05 18:51:35 -08:00
Volodymyr Lykhonis
467daba419 RouteObserver supports multiple RouteAware per Route. (#13757)
Unsubscribe should remove RouteAware for all routes.
2018-01-05 12:52:43 -08:00
Yegor
107c812f64
Update to SDK bundles with accepted licenses (#13941)
* Revert "Revert "Revert "Revert "Update Android sdkmanager for all platforms (#13912)" (#13922)" (#13923)" (#13935)"

This reverts commit f6fae1ce3604fc4d73eecf03d39f1939e14229cc.

In this attempt we try to use SDK's with pre-accepted licenses.

* use SDK with pre-accepted licenses

* update readme
2018-01-05 12:40:17 -08:00
Michael Goderbauer
b741d91a20
Support disabled state for semantics (#13877)
Fixes https://github.com/flutter/flutter/issues/11993
2018-01-05 12:10:21 -08:00
xster
e6e4406de8
Fix simulator not printing to console lines with ) (#13920)
* it's fixed

* Add test for simulator log reader
2018-01-05 11:34:05 -08:00
Yegor
f6fae1ce36
Revert "Revert "Revert "Update Android sdkmanager for all platforms (#13912)" (#13922)" (#13923)" (#13935)
This reverts commit ad898ad03f72a942ed36d9f22af7259d5b11f5b5.

Back to the whiteboard w.r.t. Android SDK licenses.
2018-01-05 10:34:02 -08:00
jcollins-g
e25d881046
Reduce the chances of bots reporting analytics (#13915)
* First version

* Prevent modification of .flutter during analytics test

* Pass in directory and override analyzer warning due to conditional import

* Review comments
2018-01-05 09:38:13 -08:00
Yegor
ad898ad03f
Revert "Revert "Update Android sdkmanager for all platforms (#13912)" (#13922)" (#13923)
This reverts commit 45289c08b90095fbee7d8feefe169baa6ceac62b.
2018-01-05 09:34:13 -08:00
Braulio Cassule
a414fb458d added image links on README file (#13824)
* image links

* image links with markdown formatting

changes of pull request [#13824](https://github.com/flutter/flutter/pull/13824)

* Remove empty lines
2018-01-05 10:15:45 +01:00
Yegor
45289c08b9
Revert "Update Android sdkmanager for all platforms (#13912)" (#13922)
This reverts commit 65dcb3ab039dbf543aa30429d2a37129a0a0a69a.

The Mac infra bot fails unable to run `android update sdk`
2018-01-04 20:57:54 -08:00
Yegor
65dcb3ab03
Update Android sdkmanager for all platforms (#13912)
* Update Android sdkmanager for all platforms

* update readme
2018-01-04 18:14:37 -08:00
Siva Annamalai
1a63500338 Update engine version to include 43327730a27344f1d45a1f9e4d53b14260778ce5
which rolls Dart to the latest version.

- includes Roll Dart to version 8d7219a5b6a7c2505ff57f23e7cf80da4c724512 (43327730a2)
2018-01-04 16:35:57 -08:00