4839 Commits

Author SHA1 Message Date
Adam Barth
06eaaf7909 Fix build
Mistakenly broke sky_viewer.mojo.
2015-10-09 09:19:21 -07:00
Adam Barth
ce2719ce05 Merge pull request #1553 from abarth/io_thread
Introduce IO thread for background tasks
2015-10-09 09:13:51 -07:00
Adam Barth
1888eacb75 Drain data pipe for images no a background thread
Instead of joining the UI thread to copy data from the network into a buffer,
we now drain the data pipe for image decoding on a background thread.
2015-10-09 07:25:54 -07:00
Adam Barth
1946924b16 Introduce IO thread for background tasks
Currently we run some tasks on the UI thread that shouldn't block the frame,
such as decoding images. This patch introduces a background thread on which we
can run these tasks.
2015-10-09 06:37:57 -07:00
Ian Hickson
65160d587f Merge pull request #1552 from Hixie/button-styles
Have Flat buttons set their default text styles.
2015-10-08 23:08:40 -07:00
Hixie
939cbe5451 Have Flat buttons set their default text styles.
Also, have dialog buttons use the accent colour.
Also, generally rationalise some of this stuff to match Material better.
2015-10-08 16:49:57 -07:00
Viktor Lidholt
98eb54a53c Merge pull request #1541 from vlidholt/master
Adds support for keeping track of contact points in physics
2015-10-08 16:20:40 -07:00
Viktor Lidholt
ed999dca02 Updates sprite physics test 2015-10-08 16:13:56 -07:00
Viktor Lidholt
4f5a0320a6 Adds basic support for joints in sprite physics 2015-10-08 16:12:31 -07:00
Ian Hickson
1b566f74a5 Merge pull request #1551 from Hixie/proxy-notifications
Changing themes caused crash
2015-10-08 15:43:31 -07:00
Hixie
fe5fde162e Changing themes caused crash
The root cause was that we crawled the tree to mark anyone who depended
on the updated theme dirty _after_ we crawled it to rebuild it. Thus, if
anyone was already marked dirty when the process started, then got
marked clean by the first (rebuild) walk, then got marked dirty again by
the notification, they'd be clean when they got the notification,
despite already being in the dirty list, which would cause an assertion.

Also IconTheme didn't have an operator==, so it was independently too
aggressive about updates.
2015-10-08 15:21:18 -07:00
Adam Barth
0744374444 Merge pull request #1550 from abarth/rect_is_empty
Add an isEmpty property to Rect
2015-10-08 15:03:14 -07:00
Adam Barth
597b19fe05 Add an isEmpty property to Rect
Also trace image decoding.
2015-10-08 14:58:17 -07:00
Hans Muller
dd40abc88c Merge pull request #1549 from HansMuller/dismissable_dispose
Defunct DismissableState should not have live animations
2015-10-08 13:56:33 -07:00
Ian Hickson
bbc584b08e Merge pull request #1546 from Hixie/drawer
Drawer test.
2015-10-08 12:32:30 -07:00
Hans Muller
77c135f4f9 Defunct DismissableState should not have live animations 2015-10-08 12:19:06 -07:00
Hixie
caea42b426 Drawer test. 2015-10-08 12:17:53 -07:00
Chinmay Garde
4393975247 Merge pull request #1545 from chinmaygarde/master
Format trace file names so they are easier to organize
2015-10-08 12:06:32 -07:00
Chinmay Garde
887e06f555 Format trace file names so they are easier to organize 2015-10-08 11:50:51 -07:00
Hans Muller
50ecad44e6 Merge pull request #1543 from HansMuller/centered_empty_stack
Allow Stacks with no children or only poisitioned children
2015-10-08 11:12:50 -07:00
Hans Muller
101d4f9e7e Allow Stacks with no children or only poisitioned children 2015-10-08 11:09:41 -07:00
Adam Barth
593098b882 Merge pull request #1540 from abarth/rm_button_state
Remove ButtonState
2015-10-08 10:29:32 -07:00
Adam Barth
2510e31602 Merge pull request #1538 from abarth/fix_snackbar
SnackBar throws exception on creation
2015-10-08 10:27:58 -07:00
Adam Barth
4e8ee23a1a Remove ButtonState
Clients should just use a GestureDetector (or an InkWell) instead.
2015-10-08 10:26:34 -07:00
Hans Muller
f885246922 Merge pull request #1520 from HansMuller/indexed_stack
Indexed stack

Added horizontal and vertical alignment properties to Stack so that the origin of non-positioned children can be specified. Currently all of the non-positioned children just end up with their top-left at 0,0. Now, for example, you can center the children by specifying verticalAlignment: 0.5, horizontalAlignment: 0.5.

Added IndexedStack which only paints the stack child specified by the index property. Since it's a Stack, it's as big as the biggest non-positioned child. This component will be essential for building mobile drop down menus.

Added a (likely temporary) example that demonstrates IndexedStack.
2015-10-08 10:21:49 -07:00
Hans Muller
2271340920 IndexedStack
Added horizontal and vertical alignment properties to Stack so that the origin of non-positioned children can be specified. Currently all of the non-positioned children just end up with their top-left at 0,0. Now, for example, you can center the children by specifying verticalAlignment: 0.5, horizontalAlignment: 0.5.

Added IndexedStack which only paints the stack child specified by the index property. Since it's a Stack, it's as big as the biggest non-positioned child. This component will be essential for building mobile drop down menus.

Added a (likely temporary) example that demonstrates IndexedStack.
2015-10-08 10:21:24 -07:00
Adam Barth
8547676089 SnackBar throws exception on creation
It was trying to grab the route's performance before it was created. Now we
create the performance eagerly again.
2015-10-08 10:17:19 -07:00
Adam Barth
4198ec0ff4 Merge pull request #1500 from abarth/drawer_animate_back
The Drawer should animate out when popped off the navigator
2015-10-08 10:16:34 -07:00
Viktor Lidholt
0f19513503 Adds support for keeping track of contact points in physics 2015-10-08 10:15:32 -07:00
Adam Barth
78dfdde46c Merge pull request #1535 from abarth/button_highlight
FlatButton highlights but doesn't tap around edge
2015-10-08 10:14:40 -07:00
Viktor Lidholt
d7ae3eaae0 Merge pull request #1526 from vlidholt/master
Adds support for applying forces and impulses to sprite physics
2015-10-08 10:13:58 -07:00
Hans Muller
8d47d72979 Merge pull request #1536 from HansMuller/fix_boxconstraints_tostring
BoxConstraints.toString() should show closed intervals
2015-10-08 10:00:47 -07:00
Adam Barth
1151cfb75c Merge pull request #1512 from abarth/no_stacks
Don't dump stacks when app fails to start
2015-10-08 10:00:35 -07:00
Hans Muller
2fcd86038f BoxConstraints.toString() should show closed intervals 2015-10-08 09:55:51 -07:00
Adam Barth
0777d98f1c FlatButton highlights but doesn't tap around edge
Now we trigger the highlight from the InkWell so that it matches the tap.

Fixes #1525
2015-10-08 09:45:29 -07:00
Chinmay Garde
bbf5f047bc Merge pull request #1533 from chinmaygarde/master
Snap to the next frame interval when visualizing stopwatch samples
2015-10-07 20:40:49 -07:00
Adam Barth
f26fc5e36e Merge pull request #1534 from abarth/enable_tests
Re-enable passing tests
2015-10-07 20:16:47 -07:00
Adam Barth
8bf3b35c2f Re-enable passing tests 2015-10-07 20:12:39 -07:00
Adam Barth
cbcb1db93a The Drawer should animate out when popped off the navigator
Now with more clear ownership over the Performance.
2015-10-07 20:09:45 -07:00
Ian Hickson
10525372e0 Merge pull request #1532 from Hixie/render-element-dependencies
HomogeneousViewport support for Theme.of()
2015-10-07 15:54:33 -07:00
Hixie
5f833fccce HomogeneousViewport support for Theme.of()
Previously, RenderObjectElements didn't support being marked dirty. This
is fine, except for MixedViewport and HomogeneousViewport, which have
builder functions to which they hand themselves as a BuildContext. If
those builder functions call, e.g., Theme.of(), then when the theme
changes, the Inherited logic tries to tell the RenderObjectElement
object that its dependencies changed and that doesn't go down well.

This patch fixes this by making RenderObjectElement a BuildableElement,
and making MixedViewport and HomogeneousViewport hook into that to
rebuild themselves appropriately.

Also, this was only found at all because ThemeData didn't implement
operator==, so we were aggressively marking the entire tree dirty all
the time. That's fixed here too.

Also, I changed card_collection.dart to have more features to make this
easier to test. This found bugs #1524, #1522, #1528, #1529, #1530, #1531.
2015-10-07 15:53:50 -07:00
Chinmay Garde
fc46e9666a Snap to the next frame interval when visualizing stopwatch samples 2015-10-07 15:08:29 -07:00
Chinmay Garde
e24d9c1f08 Merge pull request #1521 from chinmaygarde/master
Set SkPicture tracing root directory on Android
2015-10-07 14:20:27 -07:00
Chinmay Garde
1e89a38bd6 Use the app directory as the tracing path on Android 2015-10-07 14:10:58 -07:00
Viktor Lidholt
a283793ea0 Fixes typo in sprite physics 2015-10-07 14:05:11 -07:00
John McCutchan
5953357540 Merge pull request #1527 from johnmccutchan/roll_dart
Roll Dart runtime forward to c9334ed61f11df2d9aecc6311a5981eba0e55c01
2015-10-07 14:04:33 -07:00
John McCutchan
abf922cb44 Roll Dart runtime forward to c9334ed61f11df2d9aecc6311a5981eba0e55c01 2015-10-07 13:52:51 -07:00
Viktor Lidholt
1c57e92899 Adds support for applying forces and impulses to sprite physics 2015-10-07 13:26:36 -07:00
Adam Barth
58cf3ba7b7 Merge pull request #1518 from abarth/performance_route
Separate Route and PerformanceRoute
2015-10-07 13:08:33 -07:00
Chinmay Garde
ec31bc9bfd Set SkPicture tracing root directory on Android 2015-10-07 12:34:03 -07:00