10144 Commits

Author SHA1 Message Date
Ferhat
054875d7ab [web] Implement TextStyle.shadows (flutter/engine#13769)
* Add shadows to Engine classes
* add text shadow test
* update golden locks file, update ui.ParagraphStyle, fix issues
* Change maxDiffRate for mac clients
2019-11-12 00:05:00 -08:00
Matt Carroll
6bf82e4675 Expose asset lookup from plugin binding. (#42019) (flutter/engine#13743) 2019-11-12 07:14:27 +00:00
skia-flutter-autoroll
0025068f23 Roll src/third_party/skia 3de645cbca78..ad21d47cfa8d (15 commits) (flutter/engine#13790)
https://skia.googlesource.com/skia.git/+log/3de645cbca78..ad21d47cfa8d

git log 3de645cbca78..ad21d47cfa8d --date=short --no-merges --format='%ad %ae %s'
2019-11-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-11 bsalomon@google.com Clamp RGB outputs of GrYUVtoRGBEffect.
2019-11-11 herb@google.com Remove belongsToCache from SkStrike
2019-11-11 jlavrova@google.com Correct cluster index
2019-11-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms e51ca8b81987..0e5f77218153 (1 commits)
2019-11-11 sgilhuly@chromium.org Roll Dawn, fix build issues in Skia Dawn
2019-11-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms b118cb0ef477..e51ca8b81987 (1 commits)
2019-11-11 robertphillips@google.com Remove GrProgramDesc's need for the GrGpu
2019-11-11 mtklein@google.com add int3, vptest, jc
2019-11-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 652dbfc63e70..012d15196023 (9 commits)
2019-11-11 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version
2019-11-11 mtklein@google.com add assert_true()
2019-11-11 bsalomon@google.com C++17
2019-11-11 mtklein@google.com don't allocate an interpreter register for stores
2019-11-11 rosasco@google.com Staging for Chromium to accept Skia-GL changes to come.

Created with:
  gclient setdep -r src/third_party/skia@ad21d47cfa8d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC halcanary@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=halcanary@google.com
2019-11-12 01:24:36 -05:00
Ferhat
e26e220a6f Move Path and PathMetrics from canvas.dart into their own files. No delta (flutter/engine#13772)
* Move Path and PathMetrics into their own files. No delta
* update file list in licenses_flutter
2019-11-11 21:27:15 -08:00
Harry Terkelsen
fc817859be Take devicePixelRatio into account when drawing shadows (flutter/engine#13786)
* Take devicePixelRatio into account when drawing shadows

This fixes a bug where shadows were offset in CanvasKit

* Respond to review comments
2019-11-11 18:20:08 -08:00
Harry Terkelsen
9899996132 Add ImageFilter and BackdropFilter to CanvasKit backend (flutter/engine#13768)
* Implement ImageFilter.blur and BackdropFilter

* update licenses file

* Respond to review comments
2019-11-11 17:20:45 -08:00
Chris Yang
590dc94eb8 Revert "Reland "Guarding EAGLContext used by Flutter #13314" (#13759)" (flutter/engine#13788)
This reverts commit 6390e62036d69c4923cc6cf2379b9eb9f25870ba.
2019-11-11 17:17:18 -08:00
Harry Terkelsen
e64b455a3f Add Helvetica and sans-serif as fallback font families (flutter/engine#13784)
* Add Helvetica and sans-serif as fallback font families

This prevents us from using an ugly serif default font when the
requested font isn't available.

* Use Arial when not on iOS
2019-11-11 16:54:28 -08:00
skia-flutter-autoroll
28335b9648 Roll src/third_party/skia 0fd4f01b9b83..3de645cbca78 (1 commits) (flutter/engine#13776)
https://skia.googlesource.com/skia.git/+log/0fd4f01b9b83..3de645cbca78

git log 0fd4f01b9b83..3de645cbca78 --date=short --no-merges --format='%ad %ae %s'
2019-11-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader d9ed1c2732ba..31edef751a8d (3 commits)

Created with:
  gclient setdep -r src/third_party/skia@3de645cbca78

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC halcanary@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=halcanary@google.com
2019-11-11 19:45:43 -05:00
Greg Spencer
a853b5a14b Add line boundary information to LineMetrics. (flutter/engine#13727)
This exposes the line boundary information a line by adding getLineBoundary to return the indices corresponding to a line around a TextPosition. The information is already calculated when calculating line metrics, so that we can enable moving the selection/cursor to the beginning/end of a line in a text field.
2019-11-11 16:42:40 -08:00
Jason Simmons
1ae8f8880f Fix RendererContextSwitch result check in Rasterizer::MakeRasterSnapshot (flutter/engine#13785)
Fixes https://github.com/flutter/flutter/issues/31355
2019-11-11 15:46:26 -08:00
Ferhat
19cec525aa [web] Fix path to svg for drrect (flutter/engine#13779) 2019-11-11 15:38:30 -08:00
Ben Konyi
d438263c6b Roll src/third_party/dart d45c3d15cb..7408ed4730 (20 commits) (flutter/engine#13778)
dart-lang/sdk@7408ed4730 Added null-check selector to syntax of cascades, and test.
dart-lang/sdk@6f70d7f5a3 Revert "[vm] Remove obsolete kernel constant expression evaluator."
dart-lang/sdk@96822518f9 [frontend_server] Add reproduction test of incremental serializer bug
dart-lang/sdk@64b0bfac68 [infra] Update CHANGELOG.md for 2.6.1
dart-lang/sdk@4a661e19e2 [cfe] Remove type_promotion_look_ahead_listener.dart
dart-lang/sdk@12c92332f8 [CFE] Parser test can run scanner in non-nnbd-mode
dart-lang/sdk@684c456ffc [cfe] Remove reify runtime
dart-lang/sdk@e8de03915b [vm] Remove obsolete kernel constant expression evaluator.
dart-lang/sdk@0e9eadcb71 Upgrade pub revision
dart-lang/sdk@48f0b83ff2 [CFE] Allow ! in cascade
dart-lang/sdk@cf2a474438 [CFE] Fix incremental serialization bug caused by missing parameter passing
dart-lang/sdk@a7a54afbaa [cfe] Support failure log printing in unit_test_suites
dart-lang/sdk@bbdb7860f6 [build]: Build on Arch Linux with python 2.7-3.8
dart-lang/sdk@64e65a7dab [dart2js] new-rti: Use local in setting up type$
dart-lang/sdk@8f1be54906 [dart2js] New RTI: Improve normalization of is-tests.
dart-lang/sdk@1b344fc77e [dartfuzz] Add fuzzer support for extension methods for classes
dart-lang/sdk@ed956daa3f Update the DDC dart:async patch file version to match the migrated lib.
dart-lang/sdk@be2866b9b1 [analyzer] update lib/crash_reporting.dart
dart-lang/sdk@8ca18f1a14 Extension method prefixed import tests.
dart-lang/sdk@750a83b896 [dartdevc] Fix crash when source files contain non-UTF8 characters
2019-11-11 13:46:33 -08:00
skia-flutter-autoroll
723996ea39 Roll fuchsia/sdk/core/mac-amd64 from RrTFI... to TnTbF... (flutter/engine#13775)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-11 11:22:01 -08:00
skia-flutter-autoroll
ba56ffe890 Roll fuchsia/sdk/core/mac-amd64 from 4JJNo... to RrTFI... (flutter/engine#13774)
Roll fuchsia/sdk/core/mac-amd64 from 4JJNo... to RrTFI...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-10 09:09:11 -05:00
skia-flutter-autoroll
9a80ce0068 Roll fuchsia/sdk/core/mac-amd64 from xC_an... to 4JJNo... (flutter/engine#13773)
Roll fuchsia/sdk/core/mac-amd64 from xC_an... to 4JJNo...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-09 20:33:14 -05:00
skia-flutter-autoroll
d838379212 Roll fuchsia/sdk/core/mac-amd64 from eq_Rz... to xC_an... (flutter/engine#13771)
Roll fuchsia/sdk/core/mac-amd64 from eq_Rz... to xC_an...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-09 07:52:55 -05:00
skia-flutter-autoroll
5c9b0db7ba Roll src/third_party/skia 4135cf0b57c2..0fd4f01b9b83 (1 commits) (flutter/engine#13770)
https://skia.googlesource.com/skia.git/+log/4135cf0b57c2..0fd4f01b9b83

git log 4135cf0b57c2..0fd4f01b9b83 --date=short --no-merges --format='%ad %ae %s'
2019-11-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@0fd4f01b9b83

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-08 23:54:39 -05:00
Chris Yang
6390e62036 Reland "Guarding EAGLContext used by Flutter #13314" (flutter/engine#13759) 2019-11-08 20:09:18 -08:00
Matt Carroll
98d25e5bf3 Point old plugin registry accessors to new embedding plugin accessors. (#44225) (flutter/engine#13739) 2019-11-09 01:55:59 +00:00
Filip Filmar
2572d5b375 Revert "[fuchsia] Temporarily disable intl provider (#13696)" (flutter/engine#13721)
This reverts commit 8cb106f91850a9e9984d4bb39fc524710e51755c.

The reverted code was not the root cause of the issues with rolling
flutter into fuchsia, so adding it back.

In addition, lowering the severity of the connection error at the outset
to WARNING; since it is not a hard failure.
2019-11-08 17:34:04 -08:00
Michael Klimushyn
24ba26f80c Turn on RasterCache based on view hierarchy (flutter/engine#13762)
This is a duplicate of flutter/engine#13360 with the test switched to use the software backend instead of the GL backend.

After some debugging and testing on another GL embedder I think the issue with the test is some bug having to do with the GL implementation in the test harness specifically. 

Fixes flutter/flutter#38903
2019-11-08 17:14:50 -08:00
gabeschine
616a2ce26c Remove usage of fuchsia.modular.Clipboard. (flutter/engine#13763)
It is deprecated and will go away.
2019-11-08 17:13:17 -08:00
Greg Spencer
4b6b7f6e96 Change wordBoundary to take dynamic temporarily (flutter/engine#13765)
Converting the argument to Paragraph.wordBoundary to dynamic temporarily until the framework code is converted to send a TextPosition instead of an int.

I'll submit this, then update the framework side to send a TextPosition, and expect a TextRange
or a List<int>, and then submit that, then I'll change this code to send a TextRange and take a TextPostion only, removing the dynamic here. Once that's done, I'll remove the code in the framework that expects a TextRange or a List<int>, and have it just expect a TextRange.

This is so that we can change the API without breaking the builds.

Landing on red to kick the engine builds.
2019-11-08 16:27:00 -08:00
skia-flutter-autoroll
f3690a0bd8 Roll fuchsia/sdk/core/mac-amd64 from KRali... to eq_Rz... (flutter/engine#13766)
Roll fuchsia/sdk/core/mac-amd64 from KRali... to eq_Rz...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-08 19:18:41 -05:00
skia-flutter-autoroll
67dbea1c87 Roll src/third_party/skia c88d1774ed50..4135cf0b57c2 (13 commits) (flutter/engine#13764)
https://skia.googlesource.com/skia.git/+log/c88d1774ed50..4135cf0b57c2

git log c88d1774ed50..4135cf0b57c2 --date=short --no-merges --format='%ad %ae %s'
2019-11-08 mtklein@google.com use round() instead of trunc() to f32->unorm
2019-11-08 jlavrova@google.com Yet another build fix
2019-11-08 mtklein@google.com rename to_i32 -> trunc, and add round
2019-11-08 mtklein@google.com avoid redundant clamps
2019-11-08 mtklein@google.com don't clamp alpha, it's already [0,1]
2019-11-08 mtklein@google.com native f32 min/max
2019-11-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-08 mtklein@google.com convert SkVMBlitter over to floats
2019-11-08 csmartdalton@google.com Always attach stencil buffers with exact sample count matches
2019-11-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-08 jlavrova@google.com Fixing no icu situation
2019-11-08 reed@google.com add flatten test to SkFont
2019-11-08 csmartdalton@google.com Defer stencil attachment until opsTask execution

Created with:
  gclient setdep -r src/third_party/skia@4135cf0b57c2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-08 19:11:35 -05:00
Siva
e07065df7e Manual Dart roll fa4379946109467c8a48f20f19d83d7c72968a3e...d45c3d15cb3cea0104a87697c085259666eec528 (flutter/engine#13761)
dart-lang/sdk@d45c3d15cb [VM/nnbd] Make Nullability and NNBDMode class enums to avoid name conflicts.
dart-lang/sdk@cfec969eff Update dartdoc version to 0.29.1.
dart-lang/sdk@e3e0ef8548 Make explanations for unchanged types optional and disabled by default
dart-lang/sdk@e39b0f8d99 Disallow a deferred import of a library with extensions if any extensions are visible
dart-lang/sdk@9c983d2ee3 [cfe] Support extensions via prefix
dart-lang/sdk@5f5ce5d119 Include type parameter bounds into string expections for subtyping.
dart-lang/sdk@dc69edcdb3 NullabilityEliminator for removing nullabilities in legacy libraries.
dart-lang/sdk@7ad7e6202d Allow extensions imported with a prefix to be accessible
dart-lang/sdk@ea57b1e62c [VM/nnbd] Pass nullability when creating Class::DeclarationType.
2019-11-09 01:55:03 +02:00
Harry Terkelsen
3efc91706b Implement Path.computeMetrics in the CanvasKit backend (flutter/engine#13760)
* Implement Path.computeMetrics in the CanvasKit backend

* Add license for path_metrics.dart
2019-11-08 15:53:42 -08:00
Jason Simmons
b374cbe299 libtxt: pass an RTL bool flag instead of a bidiFlags enum to measureText (flutter/engine#13736)
Fixes https://github.com/flutter/flutter/issues/41086
2019-11-08 15:18:06 -08:00
Siva
da4ce37c91 Manual roll of Dart e68ca9b652acdb642668a6acb5f630d5be6c03da...fa4379946109467c8a48f20f19d83d7c72968a3e (flutter/engine#13756)
dart-lang/sdk@fa43799461 [vm/bytecode] Check number of type arguments in non-generic closures
dart-lang/sdk@a01c3b464e Use TypeParameterElement(s) as free variables in FunctionType.toString().
dart-lang/sdk@9c4c49d9ee [vm/benchmarks] Reduce number of isolate spawn runs from 5 to 3.
dart-lang/sdk@e3aac9e25d Check more in LegacyTypeAsserter.
dart-lang/sdk@0957c13054 Check for null before dereferencing constraint text.
dart-lang/sdk@fd9f79c25d [cfe] Handle deferred explicit extension access
dart-lang/sdk@7c78ab75a5 Migration: allow already-migrated libraries to be opted in.
dart-lang/sdk@6317779f9b Simplify TestTypeProvider constructor.
dart-lang/sdk@7e8e66016a Migration: do not use `always` or `never` in already-migrated types.
dart-lang/sdk@e4a60912a7 [cfe] Use library's NNBD opt-in status while serializing supertypes
dart-lang/sdk@ee2efe8e58 [CFE] Add more incremental compiler tests, prepare for better invalidation strategy
dart-lang/sdk@5eaccc20ba [CFE] Incremental test suite now has expect files
dart-lang/sdk@ec0d042955 [infra] Support multiple named configurations in test infrastructure
dart-lang/sdk@b334ea8320 [dart2js] new-rti: experiment - fault in '$is' test
dart-lang/sdk@7a45228584 Use ElementsTypesMixin in TypeSystem tests.
dart-lang/sdk@ec519c3d16 [vm/aot] Disable bytecode in AOT compilation pipeline
dart-lang/sdk@f4780a6450 [vm] Late modifier for non-static final fields.
dart-lang/sdk@23770fcc6c [vm, gc] Increase HeapPage size to 512k; increase max heap size to 32GB.
2019-11-09 00:33:47 +02:00
Chris Yang
68754a85f0 Revert "Reland "Guarding EAGLContext used by Flutter #13314" (#13755)" (flutter/engine#13757)
This reverts commit a4a346f317c867663a6d8a5d9c7909101d9b5cbd.
2019-11-08 13:44:29 -08:00
Ferhat
1f2d6ce8f8 [web] Support gif/webp animations, Speed up image drawing in BitmapCanvas. (flutter/engine#13748)
* Add draw image test
* Optimize drawImageScaled
* optimize cloning in HtmlImage, implement drawImageRect using image tag
2019-11-08 12:52:01 -08:00
Chris Yang
a4a346f317 Reland "Guarding EAGLContext used by Flutter #13314" (flutter/engine#13755) 2019-11-08 12:26:48 -08:00
Greg Spencer
d7e49ecd5b Move TextRange from the framework to dart:ui. (flutter/engine#13747)
This removes TextRange from the framework and moves it to the engine, in preparation for using it to return text ranges from the text extent APIs, like Paragraph.getWordBoundary instead of a List<int>.

Also added new tests for TextRange.
2019-11-08 12:21:46 -08:00
skia-flutter-autoroll
591957f3ca Roll src/third_party/skia 8c1e265f6f81..c88d1774ed50 (7 commits) (flutter/engine#13754)
https://skia.googlesource.com/skia.git/+log/8c1e265f6f81..c88d1774ed50

git log 8c1e265f6f81..c88d1774ed50 --date=short --no-merges --format='%ad %ae %s'
2019-11-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-08 mtklein@google.com add SkColorTypeIsNormalized()
2019-11-08 jlavrova@google.com Font resolution: all unit tests working
2019-11-08 kjlubick@google.com [canvaskit] Expand SkAnimatedImage
2019-11-08 kjlubick@google.com [canvaskit] Fix null dereference when GrContext cannot be made
2019-11-08 egdaniel@google.com Handle failure to create VkRenderPasses in vulkan backend.
2019-11-08 mtklein@google.com Pre-flight SkTLS_pthread changes for C++17

Created with:
  gclient setdep -r src/third_party/skia@c88d1774ed50

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-08 15:16:52 -05:00
Chris Yang
af43ff4a31 Revert "Always use IOSGLContextSwitch to access EAGLContexts to prevent plugins from polluting Flutter's EAGLContext (#13314)" (flutter/engine#13753) 2019-11-08 10:59:45 -08:00
Chris Yang
4953fbdd3f Always use IOSGLContextSwitch to access EAGLContexts to prevent plugins from polluting Flutter's EAGLContext (flutter/engine#13314) 2019-11-08 10:02:23 -08:00
skia-flutter-autoroll
118a07c1de Roll src/third_party/skia 99b558b594a1..8c1e265f6f81 (1 commits) (flutter/engine#13751)
https://skia.googlesource.com/skia.git/+log/99b558b594a1..8c1e265f6f81

git log 99b558b594a1..8c1e265f6f81 --date=short --no-merges --format='%ad %ae %s'
2019-11-08 mtklein@google.com remove redundant comparison ops

Created with:
  gclient setdep -r src/third_party/skia@8c1e265f6f81

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-08 10:04:30 -05:00
skia-flutter-autoroll
9237de00e0 Roll fuchsia/sdk/core/mac-amd64 from H_5HL... to KRali... (flutter/engine#13750)
Roll fuchsia/sdk/core/mac-amd64 from H_5HL... to KRali...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-08 06:04:17 -05:00
skia-flutter-autoroll
aaeab00d4f Roll src/third_party/skia 3fd426d19df3..99b558b594a1 (1 commits) (flutter/engine#13749)
https://skia.googlesource.com/skia.git/+log/3fd426d19df3..99b558b594a1

git log 3fd426d19df3..99b558b594a1 --date=short --no-merges --format='%ad %ae %s'
2019-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 cc0919dcb64b..652dbfc63e70 (7 commits)

Created with:
  gclient setdep -r src/third_party/skia@99b558b594a1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-08 04:51:31 -05:00
skia-flutter-autoroll
acc53bacbe Roll src/third_party/skia 76eaab6b8cef..3fd426d19df3 (1 commits) (flutter/engine#13746)
https://skia.googlesource.com/skia.git/+log/76eaab6b8cef..3fd426d19df3

git log 76eaab6b8cef..3fd426d19df3 --date=short --no-merges --format='%ad %ae %s'
2019-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 27a3d31d7a9d..d9ed1c2732ba (1 commits)

Created with:
  gclient setdep -r src/third_party/skia@3fd426d19df3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-08 00:59:22 -05:00
Chinmay Garde
a8b3ff268a Create a new picture recorder even when the embedder supplied render target is recycled. (flutter/engine#13744)
The earlier assumption was that the render target would be re-materialized per frame. The render target needs its own picture recorder to be create per frame as well. When render targets are cached in the registry, an existing target will be reused. But submitting the previous frame would have discarded the recorder already. The layer tree paint would then attempt to dererence a null canvas causing a crash at runtime.

Added tests to ensure that this does not happen both with and without a custom compositor specified by the embedder. I am going to rework this code so that the external view embedders thinks of render target access on a per frame basis but that is a larger change. This smaller patchset should unblock broken builds.

Fixes b/144093523
2019-11-07 19:53:51 -08:00
skia-flutter-autoroll
0709512556 Roll src/third_party/skia 345a2735e2c8..76eaab6b8cef (18 commits) (flutter/engine#13745)
https://skia.googlesource.com/skia.git/+log/345a2735e2c8..76eaab6b8cef

git log 345a2735e2c8..76eaab6b8cef --date=short --no-merges --format='%ad %ae %s'
2019-11-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-08 csmartdalton@google.com Implement multisample "disable" in Vulkan
2019-11-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-07 mtklein@google.com Reland "hook up float comparisons to x86 JIT"
2019-11-07 herb@google.com Remove unused methods from SkStrike
2019-11-07 mtklein@google.com avoid the JIT on MSAN builds
2019-11-07 halcanary@google.com SkPDF/docs: note that Sfntly subsetter is deprecated
2019-11-07 herb@google.com One glyph() to rule them all!!!
2019-11-07 reed@google.com flesh out blendmodes through Screen
2019-11-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-11-07 robertphillips@google.com Use GrProgramInfo's primitiveType field
2019-11-07 mtklein@google.com Revert "hook up float comparisons to x86 JIT"
2019-11-07 egdaniel@google.com Add handling of failed framebuffer creation in vulkan.
2019-11-07 mtklein@google.com hook up float comparisons to x86 JIT
2019-11-07 mtklein@google.com gn format BUILD.gn
2019-11-07 robertphillips@google.com Add GrPrimitiveType to GrProgramInfo
2019-11-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 1d09b983031b..cc0919dcb64b (8 commits)

Created with:
  gclient setdep -r src/third_party/skia@76eaab6b8cef

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-07 21:06:31 -05:00
George Wright
606f78fdf6 Only specify --no-link-platform when not specifying --aot, roll dart-lang sdk (flutter/engine#13742)
* Only specify --no-link-platform when --aot isn't specified

* [dart_roll] Update to e68ca9b652acdb642668a6acb5f630d5be6c03da
2019-11-07 17:48:14 -08:00
Ferhat
c759a9b47b Don't run engine tests under vm (causing warnings) (flutter/engine#13737) 2019-11-07 16:28:17 -08:00
Christopher Fujino
c54d4e4eff Switch to Cirrus Dockerfile as CI (flutter/engine#13440) 2019-11-07 15:37:07 -08:00
Matt Carroll
d024332cdf Removed scary experimental warnings for new embedding. (#44314) (flutter/engine#13738) 2019-11-07 22:54:10 +00:00
skia-flutter-autoroll
d652a0a566 Roll src/third_party/skia f66ec5d69d04..345a2735e2c8 (1 commits) (flutter/engine#13732)
https://skia.googlesource.com/skia.git/+log/f66ec5d69d04..345a2735e2c8

git log f66ec5d69d04..345a2735e2c8 --date=short --no-merges --format='%ad %ae %s'
2019-11-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 215bc7949b35..27a3d31d7a9d (2 commits)

Created with:
  gclient setdep -r src/third_party/skia@345a2735e2c8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC ethannicholas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ethannicholas@google.com
2019-11-07 17:11:16 -05:00
skia-flutter-autoroll
d7761aa8db Roll fuchsia/sdk/core/mac-amd64 from r1tS4... to H_5HL... (flutter/engine#13734)
Roll fuchsia/sdk/core/mac-amd64 from r1tS4... to H_5HL...

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-11-07 17:07:49 -05:00
liyuqian
9f3eacc712 Prefer SchedulerBinding.addTimingsCallback (flutter/engine#13728)
This doc update solves our TODO in https://github.com/flutter/flutter/pull/43676/files#diff-6a35a9a692c9af7473ba1a0a74c979c8R223
2019-11-07 14:05:43 -08:00