DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
86,257 Commits 882 Branches 1,069 Tags
Commit Graph

86257 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ben Konyi
04f323450d
[ Widget Preview ] Fix WidgetInspectorService override (#176550) 
When registering the `WidgetPreviewScaffoldInspectorService`, we were
originally setting it after the bindings were initialized. This meant
that the widget inspector service extensions were registered with the
original `WidgetInspectorService` and were not taking the custom
codepaths in the override.

This change moves the `WidgetPreviewScaffoldInspectorService`
initialization to before the bindings are initialized.
 2025-10-06 16:48:09 +00:00
Bruno Leroux
b5aef9c366
Fix NavigatorBar lacks visual feedback (#175182) 
## Description

This PR fixes NavigationBar lacking visual feedback on the active
destination indicator.

This is a reland of https://github.com/flutter/flutter/pull/164484 which
was reverted in https://github.com/flutter/flutter/pull/169497.
After investigation, I narrowed down the regression introduced in
https://github.com/flutter/flutter/pull/164484 to the usage of a
RepaintBoundary.
I added one test to verify that the regression which led to the revert
of https://github.com/flutter/flutter/pull/164484 is no more
reproducible.

### Before:

The navigation indicator does not change color when hovered or focused:


https://github.com/user-attachments/assets/a1e67dee-4a38-4711-ba90-bdcd9bed3226


### After:

The navigation indicator color changes (slightly darker):


https://github.com/user-attachments/assets/1b1cc335-2cf4-4c41-9c53-696537707c72


## Related Issue

Fixes [NavigationBar lacks visual feedback when focused or
hovered](https://github.com/flutter/flutter/issues/163871)

## Tests

- Updates several helper functions which are used by several tests.
- Updates several test: adding an Ink widget changes the coordinates
used in several tests because these coordinates are now relative to the
Ink offset.
- Add one test to check that active destination moves to the correct
destination (that was not the case after
https://github.com/flutter/flutter/pull/164484). This new test is a
golden test.
 2025-10-06 16:39:19 +00:00
engine-flutter-autoroll
d903fa2d9d
Roll Packages from e401aeb3aae4 to d3ef88b5feb8 (4 revisions) (#176582) 
e401aeb3aa...d3ef88b5fe

2025-10-06 engine-flutter-autoroll@skia.org Roll Flutter from
5c0c9e9e9ad2 to 908012d58baa (18 revisions) (flutter/packages#10175)
2025-10-03 engine-flutter-autoroll@skia.org Manual roll Flutter from
65aca3661b8f to 5c0c9e9e9ad2 (16 revisions) (flutter/packages#10170)
2025-10-03 stuartmorgan@google.com Instruct agents to create a repo root
alias (flutter/packages#10165)
2025-10-03 jessiewong401@gmail.com [Gradle 9] Fixed Gradle 9
Deprecations in Packages (flutter/packages#10016)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-06 15:52:28 +00:00
engine-flutter-autoroll
c2e9e02b89
Roll Dart SDK from 898380a41c90 to 6b0193498f09 (2 revisions) (#176576) 
https://dart.googlesource.com/sdk.git/+log/898380a41c90..6b0193498f09

2025-10-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-287.0.dev
2025-10-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-286.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-06 15:27:56 +00:00
engine-flutter-autoroll
4fc08edcbb
Roll Skia from bc7cf194f4ee to d09786dfb854 (1 revision) (#176577) 
https://skia.googlesource.com/skia.git/+log/bc7cf194f4ee..d09786dfb854

2025-10-06 fmalita@google.com Conics support for
SkPathBuilder::incReserve

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC egdaniel@google.com,jimgraham@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-06 15:13:42 +00:00
Jason Simmons
003eb6523c
Roll vulkan-deps to a9e2ca3b (#176322) 
The build script for this version of the Vulkan headers defines
VK_USE_PLATFORM_XLIB_KHR. This brings in some X11 headers that define
macros with commonly used names.

Files that include Vulkan headers may need to undefine some of these
macros to prevent conflicts with other code that uses the same names.
 2025-10-06 14:28:11 +00:00
Victoria Ashworth
01474413c5
Add an AppDelegate callback for implicit FlutterEngines (#176240) 
This PR introduces a new protocol `FlutterImplicitEngineDelegate`, which
adds a callback called `didInitializeImplicitFlutterEngine`, which
returns a new interface called `FlutterImplicitEngineBridge`.

This was added to expose parts of an implicit `FlutterEngine`, such as
when created from a `FlutterViewController` in a storyboard.

``` swift diff
@objc class AppDelegate: FlutterAppDelegate, FlutterImplicitEngineDelegate {
  override func application(
    _ application: UIApplication,
    didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?
  ) -> Bool {
    return super.application(application, didFinishLaunchingWithOptions: launchOptions)
  }
}

func didInitializeImplicitFlutterEngine(_ engineBridge: FlutterImplicitEngineBridge) {
    // Register plugins with `engineBridge.pluginRegistry`
    GeneratedPluginRegistrant.register(with: engineBridge.pluginRegistry)

    // Create method channels with `engineBridge.applicationRegistrar.messenger()`
    let batteryChannel = FlutterMethodChannel(
      name: "samples.flutter.dev/battery",
      binaryMessenger: engineBridge.applicationRegistrar.messenger()
    )
    ...

    // Create platform views with `engineBridge.applicationRegistrar.messenger()`
    let factory = FLNativeViewFactory(messenger: engineBridge.applicationRegistrar.messenger())
    ...
}
```

This PR also refactors `FlutterPluginRegistrar` into 3 separate
protocols:
* `FlutterBaseRegistrar`
* `FlutterApplicationRegistrar`
* `FlutterPluginRegistrar`

Most methods are moved from `FlutterPluginRegistrar` to
`FlutterBaseRegistrar` and then `FlutterPluginRegistrar` and
`FlutterApplicationRegistrar` inherit from `FlutterBaseRegistrar`.
`FlutterPluginRegistrar` also has additional methods specific to it -
there are no meaningful/breaking changes to `FlutterPluginRegistrar`.

Fixes https://github.com/flutter/flutter/issues/173357.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-10-06 14:22:27 +00:00
engine-flutter-autoroll
8579f67adf
Roll Skia from 45191c22b15c to bc7cf194f4ee (2 revisions) (#176572) 
https://skia.googlesource.com/skia.git/+log/45191c22b15c..bc7cf194f4ee

2025-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 7b14f3ac9637 to ea4cd2b85ec4 (2 revisions)
2025-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 62b00f866364 to fc98b3f62a98 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC egdaniel@google.com,jimgraham@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-06 12:41:29 +00:00
Ben Konyi
0400e2cf77
[ Widget Preview ] Fix type error when retrieving flags from persistent preferences (#176546) 
Also moves `dtd_services_test.dart` to actually use the
`WidgetPreviewScaffoldDtdServices` implementation, which would have
caught the typecast issue in the implementation.
 2025-10-06 12:19:29 +00:00
engine-flutter-autoroll
b95ab963a4
Roll Skia from 1fd0ca1f2120 to 45191c22b15c (3 revisions) (#176556) 
https://skia.googlesource.com/skia.git/+log/1fd0ca1f2120..45191c22b15c

2025-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 01940842b667 to d8f0feef7c17 (14 revisions)
2025-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 228c951bd699 to b57557664701 (8 revisions)
2025-10-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 207fff6486db to 7b14f3ac9637 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC egdaniel@google.com,jimgraham@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-06 07:11:29 +00:00
engine-flutter-autoroll
5fcb8025b0
Roll Dart SDK from 016a8c0045fd to 898380a41c90 (1 revision) (#176549) 
https://dart.googlesource.com/sdk.git/+log/016a8c0045fd..898380a41c90

2025-10-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-285.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-05 22:31:27 +00:00
engine-flutter-autoroll
908012d58b
Roll Skia from 5479115ef5bf to 1fd0ca1f2120 (1 revision) (#176541) 
https://skia.googlesource.com/skia.git/+log/5479115ef5bf..1fd0ca1f2120

2025-10-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SKP
CIPD package from 533 to 534

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC egdaniel@google.com,jimgraham@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-05 16:23:42 +00:00
engine-flutter-autoroll
3325024e6a
Roll Fuchsia Linux SDK from oWcBvgdpdlGvaqiDg... to Zm6K_3gP3VCaMy9rH... (#176538) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-05 12:49:36 +00:00
engine-flutter-autoroll
6814c32a86
Roll Dart SDK from 53aeaeb2454c to 016a8c0045fd (1 revision) (#176531) 
https://dart.googlesource.com/sdk.git/+log/53aeaeb2454c..016a8c0045fd

2025-10-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-284.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-05 02:19:37 +00:00
engine-flutter-autoroll
f80d8169ac
Roll Skia from f316de3d47b4 to 5479115ef5bf (4 revisions) (#176529) 
https://skia.googlesource.com/skia.git/+log/f316de3d47b4..5479115ef5bf

2025-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from a45aa5b3843e to 207fff6486db (1 revision)
2025-10-04 michaelludwig@google.com [graphite] Add
findOrCreateScratchBuffer to ResourceProvider
2025-10-04 thomsmit@google.com [graphite] add missing include in
VelloComputeSteps.h
2025-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from edacf5135c8d to a45aa5b3843e (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-04 20:41:26 +00:00
engine-flutter-autoroll
d15d198799
Roll Dart SDK from 9bc52df78b67 to 53aeaeb2454c (1 revision) (#176525) 
https://dart.googlesource.com/sdk.git/+log/9bc52df78b67..53aeaeb2454c

2025-10-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-283.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-04 18:30:27 +00:00
engine-flutter-autoroll
49cca6ab8e
Roll Fuchsia Linux SDK from HUhTcRn-LUXa2Salu... to oWcBvgdpdlGvaqiDg... (#176515) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-04 10:44:35 +00:00
Bruno Leroux
067d793084
Fix TextFormField does not inherit local InputDecorationTheme (#176397) 
## Description

This PR replaces global `ThemeData.inputDecorationTheme` usage in
`TextFormField` with `InputDecorationTheme.of ` which returns the
ambient `InputDecorationTheme`.
It is a follow up to https://github.com/flutter/flutter/pull/168981
which introduces `InputDecorationTheme.of `.

## Related Issue

Fixes [TextFormField does not inherit local
InputDecorationTheme](https://github.com/flutter/flutter/issues/176391)

## Tests

- Adds 1 test
 2025-10-04 06:55:27 +00:00
engine-flutter-autoroll
a2110f4035
Roll Dart SDK from 0009748aed50 to 9bc52df78b67 (4 revisions) (#176506) 
https://dart.googlesource.com/sdk.git/+log/0009748aed50..9bc52df78b67

2025-10-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-282.0.dev
2025-10-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-281.0.dev
2025-10-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-280.0.dev
2025-10-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-279.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-04 06:47:17 +00:00
engine-flutter-autoroll
71164f3d8d
Roll Skia from 9cda1a2050c4 to f316de3d47b4 (2 revisions) (#176504) 
https://skia.googlesource.com/skia.git/+log/9cda1a2050c4..f316de3d47b4

2025-10-04
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-10-03 mike@reedtribe.org Return optional raw for path/builder

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-04 03:35:34 +00:00
John "codefu" McDole
a9ea4b4126
fix: support older git (ubuntu 22.04) in content hash (#176321) 
content aware hash was using --format which isn't present in older, but
still supported operating systems. this pr removes the format string
which basically reduces the output before hasing to:

```shell
100644 blob 198d80926b6e873c327f71350a0cdefee6a8402f	DEPS
040000 tree 139c1f10f92e4b9d4ac3ec7d4d27b2aa9775c5cd	engine
```

this format is still stable across all platforms and passed into `git
hash-object` - which produces the actual hash fingerprint of the engine.

safety: this is the only scripts that produce this hash, so all
downstream consumers keep consuming a sha1 output. Since this changes
the sha, an engine version shouldn't exist for it and cocoon will build
the artifacts for it.

fixes: #175265
 2025-10-04 02:43:22 +00:00
engine-flutter-autoroll
31c7177fab
Roll Skia from a454242c3934 to 9cda1a2050c4 (2 revisions) (#176499) 
https://skia.googlesource.com/skia.git/+log/a454242c3934..9cda1a2050c4

2025-10-03 michaelludwig@google.com [graphite] Remove assert in
VellComputeStep
2025-10-03 michaelludwig@google.com [graphite] Move functionality into
base BufferWriter

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-04 01:06:33 +00:00
davidhicks980
a23805768d
[material/menu_anchor.dart] Check for reserved padding updates on layout delegate. (#176457) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

This PR diffs reservedPadding when checking whether a menu anchor's
SingleChildLayoutDelegate should relayout.

Resolves https://github.com/flutter/flutter/issues/176456

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-10-03 23:32:30 +00:00
engine-flutter-autoroll
9537c54ae7
Roll Skia from b842026480e0 to a454242c3934 (3 revisions) (#176484) 
https://skia.googlesource.com/skia.git/+log/b842026480e0..a454242c3934

2025-10-03 thomsmit@google.com Reland "Reland "[graphite] Extracts early
in drawGeometry""
2025-10-03 thomsmit@google.com [graphite] Add all blends to
NotifyInUseTests
2025-10-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 7bc87a4a45cf to edacf5135c8d (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-03 21:15:07 +00:00
gaaclarke
4ff3ce67ab
Starts updating the DEPS in preupload. (#176485) 
fixes https://github.com/flutter/flutter/issues/176472

testing: there is no automated testing for the preupload script.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-10-03 21:11:00 +00:00
Alexander Aprelev
4fbe0fb450
Align flutter dependencies with ones coming from dart. (#176475) 
Manual workaround for https://github.com/flutter/flutter/issues/176472
 2025-10-03 20:51:08 +00:00
John "codefu" McDole
bd81ae6f02
fix: delay exiting microbenchmark (#176477) 
Give the collecting process a chance to catch Done
 2025-10-03 19:20:09 +00:00
Victoria Ashworth
b3ecbb9034
Add state restoration for UIScene migration (#176305) 
When an iOS app migrates to UIScene, the application events for handling
state restoration are no longer called by UIKit. Instead, scene events
in the SceneDelegate must be used. This PR adds support for handling
state restoration in UIScene while still maintaining support for
unmigrated apps, as well.

Fixes https://github.com/flutter/flutter/issues/174402.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-10-03 19:08:08 +00:00
LouiseHsu
22a2203888
Fix Voiceover traversal for OutlinedButton.icon (#175810) 
Fixes #172489 

When an OutlinedButton.icon is initially built with a null icon and
later updated to display an icon, the underlying widget implementation
changes. The button switches from a standard OutlinedButton to a private
_OutlinedButtonWithIcon widget.

This switch causes the button's entire semantic node to be destroyed and
a new one created in its place. For screen readers like VoiceOver, this
behavior is disruptive. If an accessibility service is focused on the
button when its icon appears, that focus is lost because the original
semantic node is discarded, leading to strange behaviour as it makes an
best effort to focus on an existing node.

This PR resolves the issue by ensuring the same widget is used
regardless of whether the icon is present. The logic for
_OutlinedButtonWithIcon has been merged into the base class
OutlinedButton, ensuring that no matter if you call OutlinedButton.icon
or OutlinedButton you recieve a widget of type OutlinedButton.

Demo:


https://github.com/user-attachments/assets/e012bac9-823e-46f1-8eba-ec70e6b260a1
 2025-10-03 18:02:35 +00:00
engine-flutter-autoroll
5c0c9e9e9a
Roll Packages from 5fd5f74dce46 to e401aeb3aae4 (4 revisions) (#176466) 
5fd5f74dce...e401aeb3aa

2025-10-02 engine-flutter-autoroll@skia.org Roll Flutter from
7811e8982355 to 65aca3661b8f (12 revisions) (flutter/packages#10161)
2025-10-02 34327253+lenzpaul@users.noreply.github.com [Camera] Add lens
type information (iOS) (flutter/packages#7653)
2025-10-02 mohellebiabdessalem@gmail.com [webview_flutter] updates build
files to use JVM 17 (flutter/packages#10129)
2025-10-02 mohellebiabdessalem@gmail.com [shared_preferences] updates
build files to use JVM 17 (flutter/packages#10131)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-03 15:49:25 +00:00
engine-flutter-autoroll
dca709fbbf
Roll Dart SDK from fdd90f38d6a0 to 0009748aed50 (3 revisions) (#176461) 
https://dart.googlesource.com/sdk.git/+log/fdd90f38d6a0..0009748aed50

2025-10-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-278.0.dev
2025-10-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-277.0.dev
2025-10-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-276.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-03 15:23:22 +00:00
engine-flutter-autoroll
5bc7a9c130
Roll Skia from f86ae4113254 to b842026480e0 (3 revisions) (#176458) 
https://skia.googlesource.com/skia.git/+log/f86ae4113254..b842026480e0

2025-10-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 7994bf76d7a9 to 62b00f866364 (11 revisions)
2025-10-03
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-10-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 8d4953412be2 to 228c951bd699 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-03 13:15:43 +00:00
engine-flutter-autoroll
018897e3f1
Roll Skia from 1720a85a507e to f86ae4113254 (1 revision) (#176443) 
https://skia.googlesource.com/skia.git/+log/1720a85a507e..f86ae4113254

2025-10-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 603a5155599a to 01940842b667 (22 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-03 07:22:28 +00:00
engine-flutter-autoroll
a319676090
Roll Fuchsia Linux SDK from Vnoygds8HtDUvGLCK... to HUhTcRn-LUXa2Salu... (#176442) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-03 06:46:34 +00:00
engine-flutter-autoroll
ddbc920ace
Roll Skia from cf339ab390c2 to 1720a85a507e (4 revisions) (#176439) 
https://skia.googlesource.com/skia.git/+log/cf339ab390c2..1720a85a507e

2025-10-03
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-10-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 3964dd7c126b to 7bc87a4a45cf (7 revisions)
2025-10-02
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-10-02 kjlubick@google.com Add tests for SkSGMerge

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-03 02:15:32 +00:00
engine-flutter-autoroll
02c902e929
Roll Dart SDK from 4f90a06328cb to fdd90f38d6a0 (7 revisions) (#176431) 
https://dart.googlesource.com/sdk.git/+log/4f90a06328cb..fdd90f38d6a0

2025-10-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-275.0.dev
2025-10-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-274.0.dev
2025-10-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-273.0.dev
2025-10-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-272.0.dev
2025-10-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-271.0.dev
2025-10-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-270.0.dev
2025-10-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-269.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-03 01:09:12 +00:00
engine-flutter-autoroll
db0e809831
Roll Skia from 05c1f5803415 to cf339ab390c2 (11 revisions) (#176426) 
https://skia.googlesource.com/skia.git/+log/05c1f5803415..cf339ab390c2

2025-10-02 michaelludwig@google.com Make SkAlignTo templated; optimize
SkAlignNonPow2
2025-10-02
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-10-02 thomsmit@google.com [graphite] Add drawContext pointer to
task dumping
2025-10-02 mike@reedtribe.org use pathbuilder or factories, rather than
mutate SkPath
2025-10-02 kjlubick@google.com Update pixmap asserts to identify
negative values explicitly
2025-10-02
louhi-prod-1-6316342352543744@louhi-prod-1.iam.gserviceaccount.com
Update fiddler-base for 020ae52af0e7
2025-10-02 fmalita@google.com Reset convexity in SkPathBuilder::addPath
2025-10-02 bungeman@google.com Use Skia's ninja when building viewer
with gradle
2025-10-02 borenet@google.com Add Louhi service account to AUTHORS
2025-10-02 mike@reedtribe.org Remove friend pathref hacking
2025-10-02 lukasza@chromium.org [rust png] Copy `EncodePngAsSkData` from
Chromium into Skia.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-02 21:48:43 +00:00
Victoria Ashworth
76776081c6
Add deeplinking for UIScene migration (#176303) 
When an iOS app migrates to UIScene, the application events for handling
deeplinks are no longer called by UIKit. Instead, scene events in the
SceneDelegate must be used. This PR adds support for handling deeplinks
in UIScene while still maintaining support for unmigrated apps, as well.

Fixes https://github.com/flutter/flutter/issues/174403.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-10-02 20:22:25 +00:00
Slava Egorov
c9f10779f4
Upgrade packages (#176411) 
Changes to the Dart IO require picking up newer version of
`package:watcher`.
 2025-10-02 18:01:21 +00:00
Qun Cheng
17e2120be8
Update localization from translation console (#176324) 
Regular import of latest translations.

Some .arb files(cupertino_ko.arb, and material_it.arb) are overwritten
again and will cause translation issues. See comment
https://github.com/flutter/flutter/pull/166496#issuecomment-2773987516.
I manually reverted them back.

This PR doesn't run the date_localization script.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
 2025-10-02 17:38:15 +00:00
jesswrd
f58eada931
Update Framework CI to Use NDK r28c (#176214) 
Updating Framework CI to use new SDK revision containing NDK r28c. Have
to update the flutter.ndkVersion constant in this PR as well otherwise
there will be a mismatch in versions.

Partially Addresses https://github.com/flutter/flutter/issues/175022

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-10-02 17:02:09 +00:00
Mayank Patke
d938e306f5
Remove references to dart:js_util (#176323) 
Flutter has been migrated from dart:js_util (which is unsupported by
dart2wasm) to dart:js_interop, so we can remove/migrate all the
remaining references to js_util.
 2025-10-02 16:09:00 +00:00
engine-flutter-autoroll
d674abf522
Roll Packages from 321a5846838d to 5fd5f74dce46 (6 revisions) (#176409) 
321a584683...5fd5f74dce

2025-10-02 mohellebiabdessalem@gmail.com [url_launcher] updates build
files to use JVM 17 (flutter/packages#10130)
2025-10-02 mohellebiabdessalem@gmail.com [quick_actions] updates build
files to use JVM 17 (flutter/packages#10132)
2025-10-01 engine-flutter-autoroll@skia.org Manual roll Flutter from
c9608e28d01a to 7811e8982355 (22 revisions) (flutter/packages#10160)
2025-10-01 fishythefish@users.noreply.github.com [google_sign_in] Remove
references to dart:js_util (flutter/packages#10148)
2025-10-01 stuartmorgan@google.com [ci] Re-enable all Android legacy
emulator tests (flutter/packages#10141)
2025-10-01 engine-flutter-autoroll@skia.org Manual roll Flutter from
96fe3b3df509 to c9608e28d01a (26 revisions) (flutter/packages#10145)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-02 16:03:41 +00:00
Matthew Kosarek
de64eed980
Windowing integration tests now await change futures if a changes is expected + commenting our erroneous icon in Runner.rc for win32 (#176312) 
## What's new?
- Update `Runner.rc` to not include the icon file, as this is what the
other integration tests do
- Await change notifications on the controller when necessary

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
 2025-10-02 15:37:33 +00:00
Kate Lovett
1c15d39b18
Fix platform specific semantics for time picker buttons (#176373) 
Updated from https://github.com/flutter/flutter/pull/173418
Fixes https://github.com/flutter/flutter/issues/173302
Applied review feedback and modified for time licker refactor that
landed somewhere in between.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-10-02 15:32:09 +00:00
engine-flutter-autoroll
65aca3661b
Roll Skia from 257c1f94afaa to 05c1f5803415 (4 revisions) (#176402) 
https://skia.googlesource.com/skia.git/+log/257c1f94afaa..05c1f5803415

2025-10-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 29b917fb5921 to 3964dd7c126b (4 revisions)
2025-10-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from ae02c3292a95 to 7994bf76d7a9 (8 revisions)
2025-10-02
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-10-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from a3b8ecf9f94a to 8d4953412be2 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-02 13:44:27 +00:00
Ben Konyi
f35a2875ae
[ Widget Preview ] Fix resolution for workspace "hosted" dependencies (#176358) 
Projects within the same workspace can depend on each other without
explicitly specifying path dependencies or dependency overrides using
the following syntax:

```
dependencies:
  my_workspace_project: # No constraint or path
```

This is treated as a "hosted" dependency, which conflicts with the path
dependencies used by the widget_preview_scaffold.

This change introduces dependency_overrides for each package in the
workspace watched by the widget previewer to allow for dependencies to
be resolved correctly.

Fixes https://github.com/flutter/flutter/issues/176018
 2025-10-02 11:13:41 +00:00
engine-flutter-autoroll
9b91dabb99
Roll Skia from b5d8ae8d3410 to 257c1f94afaa (6 revisions) (#176389) 
https://skia.googlesource.com/skia.git/+log/b5d8ae8d3410..257c1f94afaa

2025-10-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from cd3a5de0811f to 603a5155599a (14 revisions)
2025-10-01 kjlubick@google.com Make SkPathPriv::Raw handle SkPaths with
infinite bounds correctly
2025-10-01 kjlubick@google.com Reapply "Reapply "Use pathbuilder or
factories to keep path immutable""
2025-10-01 robertphillips@google.com [graphite] Make use of
PipelineCreateCacheControl in Vulkan
2025-10-01 mike@reedtribe.org Update tests to use pathbuilder
2025-10-01 jmbetancourt@google.com [skcapture] add capture callbacks for
SkSurface

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-02 07:35:21 +00:00
Jim Graham
b77acbf30b
Delete Skia-specific performance overlay implementation (#176364) 
(Essentially a re-issue of
https://github.com/flutter/flutter/pull/174682 which ended up with
broken Google Testing links)

We had 2 different implementations of the rendering code for the
performance overlay layer. The skia version used some skia-specific code
to render the overlay incrementally into an offscreen surface and so we
created a different implementation for Impeller that only uses standard
rendering calls (and no surface cache). It turns out that the Impeller
version was faster anyway even on Skia so it is a simple change to
delete the old code and always use the new visualizer.

The new visualizer reduces the time to render the graph from just under
1ms to about .1ms on Skia.
The new visualizer takes .1ms longer to compute on the UI thread, but
overall we save time between the 2 threads.
The new visualizer is much faster on Impeller.

Some work could be done to save some of that time on the UI thread by
only incrementally updating the graph data, but for now we can take the
~.8-.9ms savings with just some deleted code.
 2025-10-02 07:11:39 +00:00
engine-flutter-autoroll
2bf5da46a5
Roll Fuchsia Linux SDK from 1Ai6VL4vb_GdGnWhg... to Vnoygds8HtDUvGLCK... (#176381) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-10-02 04:24:31 +00:00