DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
29,334 Commits 882 Branches 1,069 Tags
Commit Graph

29334 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jonah Williams
02591dca4d [Impeller] fix missing assignment of embedder render target. (flutter/engine#42630) 
Otherwise we can't render 😄
 2023-06-07 19:57:57 +00:00
Jonah Williams
50626db959 [Impeller] Add buffer to texture blit for Vulkan. (flutter/engine#41706) 
Work towards https://github.com/flutter/flutter/issues/123468

In order to support the usage of BufferView, I generalized the tracked buffer type from DeviceBuffer to Buffer. Should be mostly safe!

I confirmed that this runs correctly under moltenvk but I'm uncertain if there are additional ways to validate.
 2023-06-07 19:32:48 +00:00
Chris Bracken
e7a44a64a7 [macOS] Add platformview creation parameter support (flutter/engine#42607) 
Previously, when creating native platform views on macOS, we ignored any parameters passed via the framework side "params" argument in the "create" method call, and instead always passed a nil value to the FlutterPlatformViewFactory. This made it impossible for users of macOS platform views to pass constructor arguments to the NSView subclass implementing the platform view.

We now decode the arguments data using the codec specified by the `FlutterPlatformViewFactory` and pass them through to the `[FlutterPlatformViewFactory createWithIdentifier:arguments:]` method where the platform view author can make use of them.

Fixes: https://github.com/flutter/flutter/issues/124723

This is a part of the broader macOS platform view support effort: https://github.com/flutter/flutter/issues/41722

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-07 19:16:56 +00:00
gaaclarke
01f6db8882 [Impeller] Added a switch to turn on vulkan (flutter/engine#42585) 
fixes https://github.com/flutter/flutter/issues/128286

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-07 19:08:04 +00:00
skia-flutter-autoroll
ece46cca0a Roll ANGLE from f8220fa3a729 to 15a29438b099 (1 revision) (flutter/engine#42627) 
f8220fa3a7..15a29438b0

2023-06-07 prashanthsw@google.com Migrate Android NDK to CIPD [1/2]

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-07 18:35:13 +00:00
Jackson Gardner
6fdcec7af7 Bump Chrome version to 114 for testing (flutter/engine#42623) 2023-06-07 17:55:20 +00:00
skia-flutter-autoroll
aaad533dda Roll Skia from d607cbb0db78 to 773765ca1dd2 (7 revisions) (flutter/engine#42624) 
https://skia.googlesource.com/skia.git/+log/d607cbb0db78..773765ca1dd2

2023-06-07 drott@chromium.org [Fontations] Support makeClone() for variations
2023-06-07 johnstiles@google.com Demonstrate function-parameter assignment issue in unit test.
2023-06-07 johnstiles@google.com Add unit tests to WGSL that rely on dead-return synthesis.
2023-06-07 johnstiles@google.com Add trailing `return` to functions that lack an unconditional return.
2023-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c520912239f0 to 5c35de42bbc6 (2 revisions)
2023-06-07 johnstiles@google.com Fix test disable for OutParamsDoubleSwizzle.
2023-06-07 kjlubick@google.com Remove some spaces from the gainmap sksl

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-07 17:43:26 +00:00
J-P Nurmi
42b7de838e [Linux][a11y] implement AtkText::get_text/string_at_offset() (flutter/engine#38144) 
This PR implements `AtkText::get_string_at_offset()` (and the deprecated `AtkText::get_text_at_offset()` still used by e.g. Orca) for `FlAccessibleTextField` to allow Orca to read out loud the current character while moving the text cursor around.

### Before (unmute to hear the screen reader)

[textfield-a11y-before.webm](https://user-images.githubusercontent.com/140617/206556644-fb4f4df8-acca-4d97-86d5-7120f0a4871d.webm)

### After (unmute to hear the screen reader)

[textfield-a11y-after.webm](https://user-images.githubusercontent.com/140617/206556678-4fbf9112-291e-4518-a258-e9ca33469430.webm)

Fixes: flutter/flutter#113049

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-07 17:18:04 +00:00
skia-flutter-autoroll
ab31deab67 Roll ANGLE from 176989ad00cc to f8220fa3a729 (1 revision) (flutter/engine#42621) 
176989ad00..f8220fa3a7

2023-06-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 0c2e936905ea to f7613775cdc7 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-07 15:46:19 +00:00
skia-flutter-autoroll
c69ef0e6e7 Roll Skia from ee90e9ae2e62 to d607cbb0db78 (1 revision) (flutter/engine#42618) 
https://skia.googlesource.com/skia.git/+log/ee90e9ae2e62..d607cbb0db78

2023-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from b8f3bbf465f8 to b54c2bdc9713 (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-07 14:53:23 +00:00
skia-flutter-autoroll
7949774945 Roll ANGLE from 1ad4ae4d63bf to 176989ad00cc (1 revision) (flutter/engine#42617) 
1ad4ae4d63..176989ad00

2023-06-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 9e0b5e8b8a85 to fe5f79e217c4 (537 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-07 14:45:57 +00:00
Tong Mu
fdadd4c99e Revert "[Android] Return keyboard pressed state" (flutter/engine#42616) 
Reverts flutter/engine#41695 due to internal bug report b/284945818.

cc @bleroux let's investigate some day.
 2023-06-07 01:38:45 -07:00
skia-flutter-autoroll
0a726f3493 Roll Skia from bde894438f29 to ee90e9ae2e62 (1 revision) (flutter/engine#42614) 
https://skia.googlesource.com/skia.git/+log/bde894438f29..ee90e9ae2e62

2023-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from b54c2bdc9713 to bb33478c7dad

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-07 07:43:06 +00:00
skia-flutter-autoroll
a7ba47faac Roll Fuchsia Linux SDK from lpbkSRJBMkPs0FM7_... to sEHtHM1iFt79roP-x... (flutter/engine#42613) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-07 07:20:25 +00:00
skia-flutter-autoroll
eafdc20bfa Roll Skia from cd3e1665dcd1 to bde894438f29 (1 revision) (flutter/engine#42612) 
https://skia.googlesource.com/skia.git/+log/cd3e1665dcd1..bde894438f29

2023-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 721c15efaa70 to 1ad4ae4d63bf (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-07 06:44:12 +00:00
skia-flutter-autoroll
60a48fff60 Roll ANGLE from 16841d6256da to 1ad4ae4d63bf (1 revision) (flutter/engine#42611) 
16841d6256..1ad4ae4d63

2023-06-06 yuxinhu@google.com Clean up EGLPreRotation Test

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-07 06:08:12 +00:00
Brandon DeRosier
72a1fea6e2 [Impeller] Reland 2: Add Impeller Metal support in the embedder API (#42411) (flutter/engine#42597) 
This reverts commit
8d6f091751
+ fixes bugs.

Reworked the surface wrapping to use a valid descriptor when wrapping
the drawable.
 2023-06-06 23:02:02 -07:00
skia-flutter-autoroll
d5adc1154e Roll Skia from a01f49f539ab to cd3e1665dcd1 (1 revision) (flutter/engine#42610) 
https://skia.googlesource.com/skia.git/+log/a01f49f539ab..cd3e1665dcd1

2023-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 3e5c6411ba05 to fd2d24b01b67 (21 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-07 05:55:04 +00:00
skia-flutter-autoroll
6a13668263 Roll Fuchsia Mac SDK from atrYtfHWi2cmV9B_C... to ojwVlxZWrbsG4WGSE... (flutter/engine#42609) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-07 05:17:38 +00:00
skia-flutter-autoroll
0974bef6df Roll Skia from 521b8c4bb011 to a01f49f539ab (4 revisions) (flutter/engine#42608) 
https://skia.googlesource.com/skia.git/+log/521b8c4bb011..a01f49f539ab

2023-06-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 521ddd00b973 to c520912239f0 (4 revisions)
2023-06-06 johnstiles@google.com Allow WGSL code with warnings to compile successfully.
2023-06-06 johnstiles@google.com Change WGSL indentation level to 2 spaces.
2023-06-06 johnstiles@google.com Add WGSL support for do-while loops.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-07 05:05:05 +00:00
skia-flutter-autoroll
306354e4a2 Roll Skia from cef18d10b363 to 521b8c4bb011 (1 revision) (flutter/engine#42605) 
https://skia.googlesource.com/skia.git/+log/cef18d10b363..521b8c4bb011

2023-06-06 robertphillips@google.com Revert "Add unit test for large images"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-07 03:08:49 +00:00
Alexander Aprelev
a4fc8c761e Roll dart to 3.1.0-169.0.dev (flutter/engine#42602) 
Dart changes since last roll
```
d00a370c1fd (HEAD, tag: 3.1.0-169.0.dev) Version 3.1.0-169.0.dev
00d63e7bf96 [ddc] Fix covariant bound checks with new types
ff3117ac474 (tag: 3.1.0-168.0.dev) Version 3.1.0-168.0.dev
4f2f3405fb5 [analyzer] Refactor visitInterpolationExpression in constant evaluator.
41c17e0b015 [vm, gc] Remembered cards tweaks.
d4adfcccaf1 [dart:js_interop/ddc] Lower static interop using call-site and omit tear-offs
c98ec26c910 [dart:js_interop] Disallow external extension members with 'static'
46d9f76f7e6 Add postEvent to dds client.
25c0ae1c423 Link to dart.dev for linter rules
605e89d3bd1 [analyzer_utilities] Find pkg folder from working directory
32977d8f436 [infra] Setup Windows ARM64.
808b4d5bf6a [vm/aot/tfa] Cleanup _FallthroughDetector
e0ced74e154 [gardening] Marking evaluate_activation_test as slow.
3a15031b183 (tag: 3.1.0-167.0.dev) Version 3.1.0-167.0.dev
d198f84f5e4 (tag: 3.1.0-166.0.dev) Version 3.1.0-166.0.dev
486b3b380e0 [vm/aot/tfa] Fix building of data flow summary in case of break from try/finally
8091581e720 [cfe] Use unchecked AsExpression instead of promoted VariableGet
17781dbc364 [frontend/dds] Enable frontend server and dds to pass through types, method and class information for expression evaluation.
877fe38f0ce [dart2wasm] Fix runtime type tests
8dfd80486e6 [infra] Rename dart2wasm configurations and builders
33fd4933304 [cfe] Constant evaluate string interpolation
9d8df2a5210 (tag: 3.1.0-165.0.dev) Version 3.1.0-165.0.dev
b7ea982bea6 Flow analysis: Simplify ExpressionInfo class hierarchy.
b1134039940 use switch cases where it makes sense in the macro code
b43d95a942d [test] Re-establish at least some Fuchsia testing.
79e67836378 Typing tweaks for ExecuteCommandHandler.
2c9bc7b9586 (tag: 3.1.0-164.0.dev) Version 3.1.0-164.0.dev
7b3305ebee9 [deps] rev args, bazel_worker, dartdoc, http, leak_tracker, mockito, native, protobuf, pub_semver, shelf, stack_trace, tools, vector_math, webdev
247ca91bb89 [analysis_server] Tweak "ignore diagnostic" text for file
475240d2346 Reland "[VM/Timeline] Make timestamp1_or_id variables more understandable"
310baf27375 mark all public interfaces as abstract interface classes
63d856d4878 [test] Avoid quadratic complexity in vm/dart/unobfuscated_static_symbols_test
e316fb84a11 [js] Add inlining hints to js patch files.
0d1a9df087f [analyzer] Refactor visitAdjacentStrings and visitStringInterpolation for the constant evaluator.
709c0e4ccd3 Flow analysis: combine ExpressionInfo, ReferenceWithType, and EqualityInfo.
990fdea1d50 [cfe] Fix for transforming record literals to const records with unevaluated const elements.
52791b4e0d3 [build] Decide in one place between using app-jit and kernel for the SDK snapshots.
 2023-06-06 19:59:34 -07:00
Jason Simmons
92064621b7 Convert pixel formats for animated PNG frames using the source blend mode (flutter/engine#42581) 
The destination buffer format may not exactly match the source format. In particular, the alpha type of the source may need to be converted to the alpha type of the destination.

Fixes https://github.com/flutter/flutter/issues/128102
 2023-06-07 00:02:03 +00:00
skia-flutter-autoroll
5834a9e8c4 Roll ANGLE from e21ecd1b59f7 to 16841d6256da (24 revisions) (flutter/engine#42601) 
e21ecd1b59..16841d6256

2023-06-06 kkinnunen@apple.com Reland "Remove SPIRV_METAL references from .gn and tests"
2023-06-06 romanl@google.com Resolve circular dependency android_helper <-> angle_test_util
2023-06-06 lexa.knyazev@gmail.com Disallow 'depth_unchanged' qualifier for WebGL contexts
2023-06-06 ynovikov@chromium.org Revert "Remove SPIRV_METAL references from .gn and tests"
2023-06-06 sokcevic@chromium.org Add kwargs to specialized error message
2023-06-06 rafael.cintron@microsoft.com Refactor D3D device creation to make adapter selection explicit
2023-06-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from d6f22a2a164b to 9e0b5e8b8a85 (1063 revisions)
2023-06-06 kkinnunen@apple.com Remove SPIRV_METAL references from .gn and tests
2023-06-06 senorblanco@chromium.org D3D11: fix for atomic assigned to an SSBO.
2023-06-06 kbr@chromium.org Metal: Remove OS info from renderer string for WebGL contexts.
2023-06-05 geofflang@chromium.org Do not call postResolveLink in Program::deserialize.
2023-06-05 romanl@google.com Make run_code_generation faster using python3 for auto_script
2023-06-04 syoussefi@chromium.org Vulkan: Declare common SPIR-V ids in the compiler
2023-06-04 syoussefi@chromium.org Vulkan: Pass non-semantic info from translator to transformer
2023-06-03 yuxinhu@google.com Revert "Enable usePrimitiveRestartEnableDynamicState on ARM driver 43"
2023-06-02 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll Chromium from aac4d6a34cf9 to d6f22a2a164b (285 revisions)
2023-06-02 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll VK-GL-CTS from 356e6d2f8796 to 0c2e936905ea (9 revisions)
2023-06-02 romanl@google.com Add all of tools/android to DEPS
2023-06-02 bsheedy@chromium.org Update vpython3 requests
2023-06-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from f549d5e6c663 to ae667fe96db9 (2 revisions)
2023-06-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 069f9924f967 to aac4d6a34cf9 (715 revisions)
2023-06-01 yuxinhu@google.com Enable usePrimitiveRestartEnableDynamicState on ARM driver 43
2023-06-01 abdolrashidi@google.com Vulkan: Add version to pipeline cache header
2023-06-01 cclao@google.com Vulkan: Move some bufferRead logic into CommandBufferHelperCommon

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-06 22:16:02 +00:00
skia-flutter-autoroll
a30e718193 Roll Skia from 4065e92bf577 to cef18d10b363 (18 revisions) (flutter/engine#42600) 
https://skia.googlesource.com/skia.git/+log/4065e92bf577..cef18d10b363

2023-06-06 robertphillips@google.com Add unit test for large images
2023-06-06 johnstiles@google.com Rename OutParamsTricky to OutParamsDoubleSwizzle.
2023-06-06 herb@google.com Do not return infinities as roots
2023-06-06 cmumford@google.com Revert "[infra] temporarily remove RadeonHD8870M-x86_64-Debug-All-Graphite_Metal from CQ"
2023-06-06 johnstiles@google.com Remove out-param helper functions from WGSL.
2023-06-06 rmistry@google.com Revert "Whitespace change to test GitWatcher"
2023-06-06 cmumford@google.com Revert "[infra] temp remove Release-All-Graphite_Metal from CQ"
2023-06-06 johnstiles@google.com Fix ternary paren-handling code.
2023-06-06 michaelludwig@google.com Revert "Rename ColorTable in public.bzl"
2023-06-06 kjlubick@google.com Remove old GrRectanizer file
2023-06-06 kjlubick@google.com Rename ColorTable in public.bzl
2023-06-06 johnstiles@google.com Remove special case for inverse-hyperbolic intrinsic tests.
2023-06-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3c250b5ab450 to 521ddd00b973 (1 revision)
2023-06-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from b8f3bbf465f8 to 0daeddfa6f24
2023-06-06 drott@chromium.org [Fontations] Variations support for fontations backend
2023-06-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 4ff41604e769 to 721c15efaa70 (3 revisions)
2023-06-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from ac4876bcdcc3 to b8f3bbf465f8 (9 revisions)
2023-06-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from f44e26b8163c to 3e5c6411ba05 (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-06 22:02:19 +00:00
Mouad Debbar
1574da58fb [web] Remove /#/ from home page URL (flutter/engine#42598) 
To make the `HashUrlStrategy` a bit cleaner (at least for the home page), let's get rid of the notorious `/#/` when the app is in the home page.

Non-home pages continue to have a hash in them. After this PR, here are some example URL changes:

- `http://domain.com/#/` => `http://domain.com/`
- `http://domain.com/#/page1` => (remains the same)

This change is backwards compatible, i.e. if you write `http://domain.com/#/` in the address bar, the app will load and open the home page correctly; and flutter will automatically change the URL to `http://domain.com/`.

Fixes https://github.com/flutter/flutter/issues/127608
 2023-06-06 21:33:34 +00:00
Casey Hillers
1baefb4e90 [labeler] Add engine workflow (flutter/engine#42566) 
https://github.com/flutter/flutter/issues/126002
 2023-06-06 19:39:40 +00:00
Jackson Gardner
1f3fc87375 Use proper sampling options in Skwasm's drawAtlas. (flutter/engine#42595) 
Make Skwasm consistent with the CanvasKit backend's sampling options in `drawAtlas`. Also, fix the atlas rendering tests so the sprites don't bleed into each other.
 2023-06-06 18:23:54 +00:00
Zachary Anderson
8d6f091751 Revert "[Impeller] Reland: Add Impeller Metal support in the embedder API (#42411)" (flutter/engine#42593) 
Reverts flutter/engine#42545

Not sure if this is needed, but getting a revert started for the
regression noted here:
https://github.com/flutter/engine/pull/42545#issuecomment-1579034704.
 2023-06-06 10:57:57 -07:00
Zachary Anderson
a4677d34f6 Fix raster cache optional value check logic (flutter/engine#42592) 
Possible fix for https://github.com/flutter/flutter/issues/128308
 2023-06-06 09:35:50 -07:00
ColdPaleLight
ef42a7d173 [Impeller] Fix the rendering issue when the tile mode of gradient is set to 'decal' (flutter/engine#42591) 
fix issue https://github.com/flutter/flutter/issues/128327
without patch 
![oOFhefzmN6](https://github.com/flutter/engine/assets/31977171/9d219ba8-b808-4de6-87ae-cc21e3b1411f)

with patch
![a5A81re5tD](https://github.com/flutter/engine/assets/31977171/7010b7b6-0d3b-481f-ac3b-36aeb1da1785)
 2023-06-06 16:31:17 +00:00
skia-flutter-autoroll
a208719197 Roll Skia from e8a71c76b88f to 4065e92bf577 (1 revision) (flutter/engine#42587) 
https://skia.googlesource.com/skia.git/+log/e8a71c76b88f..4065e92bf577

2023-06-06 michaelludwig@google.com Add SkColorTable to share memory for SkColorFilters::Table

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-06 16:28:30 +00:00
skia-flutter-autoroll
3235ab593e Roll Fuchsia Linux SDK from vAwdggqMrL1yoH_Zn... to lpbkSRJBMkPs0FM7_... (flutter/engine#42590) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-06 16:27:52 +00:00
skia-flutter-autoroll
b01a102dd8 Roll Fuchsia Mac SDK from tCxDcZ3yi0rnKGVHt... to atrYtfHWi2cmV9B_C... (flutter/engine#42589) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-06 16:26:00 +00:00
ColdPaleLight
56a384d9da [Impeller] Make conical gradient work as expected (flutter/engine#42567) 
fix https://github.com/flutter/flutter/issues/128012

In many instances (https://github.com/flutter/flutter/issues/128012#issuecomment-1577029031), the current implementation of conical gradient in impeller produces incorrect results. This pull request proposes to migrate the conical gradient algorithm from skia to impeller.

Please see ddf987d2ab/src/sksl/sksl_graphite_frag.sksl (L541-L666)

Test result
![FGcZZRCQZJ](https://github.com/flutter/engine/assets/31977171/4127e73d-81a9-4d3e-8430-cf511367362c)
 2023-06-06 03:55:39 +00:00
Matej Knopp
5ef190cc5c [macOS] Force clipping to path when platform view clip rect is rotated (flutter/engine#42539) 
Normally when platform view is clipped to a simple rect we rely on
clipping to container layer bounds. However when the clip rect is
rotated the container layer is expanded accordingly and clipping to path
must be used instead.

Fixes https://github.com/flutter/flutter/issues/128175
 2023-06-05 18:14:16 -07:00
skia-flutter-autoroll
c4ebcfb931 Roll Skia from 7db361be474b to e8a71c76b88f (4 revisions) (flutter/engine#42582) 
https://skia.googlesource.com/skia.git/+log/7db361be474b..e8a71c76b88f

2023-06-05 johnstiles@google.com Remove compound-constructor helper functions from WGSL.
2023-06-05 johnstiles@google.com Remove mat2-to-vec4-cast helper function from WGSL.
2023-06-05 johnstiles@google.com Remove matrix-resize helper functions from WGSL.
2023-06-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 0dbc9230a24f to 3c250b5ab450 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-06 00:06:22 +00:00
Michael Goderbauer
bb8e656444 Remove onSemanticsAction (flutter/engine#42579) 
Follow-up to https://github.com/flutter/engine/pull/42493.

The framework has been migrated to the new onSemanticsActionEvent callback.
 2023-06-05 23:12:53 +00:00
godofredoc
e421d5485a Use the arm64 dsymutil on Mac M1 machines (flutter/engine#42533) 
Use the right binary architectures on scripts running dsymutil.

This is to fix the problem of bad architecture binary for builds running on dart internal: https://github.com/flutter/flutter/issues/128098

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-06-05 22:12:13 +00:00
skia-flutter-autoroll
5af0dd3985 Roll Skia from a226cfbd6cc7 to 7db361be474b (14 revisions) (flutter/engine#42578) 
https://skia.googlesource.com/skia.git/+log/a226cfbd6cc7..7db361be474b

2023-06-05 herb@google.com Use the new quadratic root code in RootsReal
2023-06-05 armansito@google.com [graphite][compute] Crude size reduction for vello bump buffers
2023-06-05 armansito@google.com [graphite][compute] Minor VelloScene changes for atlasing
2023-06-05 ccameron@chromium.org SkGainmapInfo: Include Adobe Gain Map license notice
2023-06-05 cmumford@google.com [infra] bump Radeon Vega drivers to 1002:1636-31.0.14057.5006
2023-06-05 johnstiles@google.com Remove matrix-equality helper functions from WGSL.
2023-06-05 johnstiles@google.com Remove diagonal-matrix helper functions from WGSL.
2023-06-05 michaelludwig@google.com Rename src/codec/SkColorTable to src/codec/SkColorPalette
2023-06-05 johnstiles@google.com Add WGSL support for break, continue, and nop statements.
2023-06-05 kjlubick@google.com Make SkShaders a namespace and move SkPerlinNoiseShader functions into it
2023-06-05 michaelludwig@google.com [skif] Apply decal at layer resolution
2023-06-05 kjlubick@google.com Enforce IWYU on GrBackendSurface and reduce inclusions of it in headers
2023-06-05 rmistry@google.com Whitespace change to test GitWatcher
2023-06-05 johnstiles@google.com Implement WGSL support for swizzled lvalues.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC borenet@google.com,brianosman@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-05 22:04:49 +00:00
Brandon DeRosier
fba5e2b514 [Impeller] Reland: Add Impeller Metal support in the embedder API (#42411) (flutter/engine#42545) 
This reverts commit
45dd178414.

Original PR: https://github.com/flutter/engine/pull/42411

Part of https://github.com/flutter/flutter/issues/112230.
 2023-06-05 14:51:43 -07:00
Zachary Anderson
cd6f44c544 Ensure Dart roll script picks up udpates to dart-sdk/tools (flutter/engine#42576) 
The build of the Dart SDK depends on this package, so it needs to be
kept up to date by
https://github.com/flutter/buildroot/blob/master/tools/dart/create_updated_flutter_deps.py,
which is run by the autoroller.
 2023-06-05 13:48:53 -07:00
Casey Hillers
e730874b21 Run dependabot in off peak hours (flutter/engine#42572) 
https://github.com/flutter/flutter/issues/126002
 2023-06-05 20:48:22 +00:00
Jim Graham
5cdf77f921 fix bounds of inverted rendered rectangles (flutter/engine#42556) 
Fixes: https://github.com/flutter/flutter/issues/128159

In diagnosing test failures for https://github.com/flutter/engine/pull/42330 we discovered that the DisplayList code was not always backwards compatible with computing the bounds of inverted rectangles (where left > right or top > bottom). Historically such rectangles were always rendered as if they were sorted (i.e. `SkRect::makeSorted()`), but we computed bounds as if the bounds only mattered if the supplied rectangle was ordered. So, we would sometimes render a rectangle for which we mis-computed the bounds.

This would rarely surface in the current code as most rendered rectangles would pass through `SkMatrix::mapRect()` which implicitly orders the rectangle as it transforms it, but any attributes applied to the bounds before that method may have been applied "in the wrong direction" - such as:

- stroke width padding
- mask blur padding
- image filter padding
 2023-06-05 18:53:04 +00:00
skia-flutter-autoroll
c5959fb30a Roll Fuchsia Mac SDK from fgfgAhpxFpse7Xi4i... to tCxDcZ3yi0rnKGVHt... (flutter/engine#42574) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-05 18:45:21 +00:00
Kevin Lubick
0f09000dea Add missing #include of SkCFObject.h (flutter/engine#42573) 
Another follow-on to http://review.skia.org/704942 which removed some
#includes that Flutter had been transitively depending on.

Note that SkCFObject is mac-only, so I included it the appropriate
#ifdef in embedder.cc, but the other two files are already mac-only so
they do not need that guard.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-06-05 14:44:46 -04:00
Matej Knopp
eb1f10ea00 Improve getting non-overlapping rectangles from RTree (flutter/engine#42399) 
Fixes https://github.com/flutter/flutter/issues/116070
Fixes https://github.com/flutter/flutter/issues/126202

Introduces `DlRegion` class which implements subset of `SkRegion`
required to get non-overlapping rectangles from region.

The implementation is different and faster than `SkRegion` for this
particular use-case (`display_list_region_benchmarks`):

Edit: Updated benchmark to latest revision and natively (initial run
went through rosetta)
```
----------------------------------------------------------------------------
Benchmark                                  Time             CPU   Iterations
----------------------------------------------------------------------------
BM_RegionBenchmarkDlRegion/Tiny          616 us          616 us          908
BM_RegionBenchmarkSkRegion/Tiny        70559 us        70557 us           10
BM_RegionBenchmarkDlRegion/Small        1315 us         1314 us          537
BM_RegionBenchmarkSkRegion/Small      121736 us       121717 us            6
BM_RegionBenchmarkDlRegion/Medium       1079 us         1079 us          650
BM_RegionBenchmarkSkRegion/Medium      22039 us        22035 us           32
BM_RegionBenchmarkDlRegion/Large         399 us          399 us         1763
BM_RegionBenchmarkSkRegion/Large        1510 us         1510 us          466
```

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-06-05 20:41:21 +02:00
Matej Knopp
72876573ef Fix clang tidy error and crash (flutter/engine#42564) 
Clang tidy checks for https://github.com/flutter/engine/pull/42399 are
failing for `formats_mtl.mm` and `context_mtl.mm`. Weirdly this happens
even though none of these files where modified in the branch.

For `context_mtl.mm` the fix is straightforward, just a missing
`std::move`.
For `formats_mtl.mm` clang-tidy actually crashes on the assignments to
`des.depthCompareFunction` and `des.depth_write_enabled`. The crash
doesn't happen if the assignment is done through a temporary variable.

I'm not sure if we should have a workaround for the crash or disable
clang-tidy on the file completely (FLUTTER_NOLINT).

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-06-05 19:37:12 +02:00
skia-flutter-autoroll
b9dbdc4c9d Roll Fuchsia Linux SDK from gp1k1agqxQIz0oTXV... to vAwdggqMrL1yoH_Zn... (flutter/engine#42570) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-06-05 16:54:50 +00:00
Zachary Anderson
7230cf065f Revert Dart SDK to 3.1.0-163.0.dev for branch alignment (flutter/engine#42569) 
3.1.0-163.0.dev is the most recent version in g3 that has successfully
rolled to the framework. This PR rolls the engine back to this last
known good version of Dart.
 2023-06-05 09:34:28 -07:00