DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
34,538 Commits 882 Branches 1,069 Tags
Commit Graph

34538 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Chris Bracken
01c2ffa574 Roll buildroot to ef514ca5144ba0a4ce5e7075c325d24cd6da73a4 (flutter/engine#51265) 
In flutter/engine#51258, all existing build_overrides from the buildroot
were copied into the engine.

In flutter/buildroot#832, all buildroot build_overrides were converted
into simple forwarding files that point to the ones in the engine such
that we have a seamless path to eliminating the buildroot, while
allowing third-party dependencies to continue to hardcode
`//build_overrides/foo.gni`.

This rolls the buildroot to the engine and switches everthing over to
the new engine-based build_overrides.

Fixes: flutter/flutter#144790
Part of: flutter/flutter#67373

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I'm pretty sure that despite no real changes that should affect
the licence script, that it'll probably fail for some reason anyway and
I'll spend 2 hours fixing it.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-03-07 14:44:49 -08:00
skia-flutter-autoroll
ae6ab70478 Roll Dart SDK from 4bc97350dc47 to 4c64fcc134bf (1 revision) (flutter/engine#51266) 
https://dart.googlesource.com/sdk.git/+log/4bc97350dc47..4c64fcc134bf

2024-03-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-212.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-07 22:44:15 +00:00
Brandon DeRosier
9944f5554c [Impeller] Record restore clips in the replay mechanism when StC is enabled. (flutter/engine#51259) 2024-03-07 22:21:52 +00:00
skia-flutter-autoroll
ca81103956 Roll Skia from 6bfd57b8790f to 4a65dfcc70a5 (2 revisions) (flutter/engine#51263) 
https://skia.googlesource.com/skia.git/+log/6bfd57b8790f..4a65dfcc70a5

2024-03-07 herb@google.com Cleanup SkSwizzler_opt.inc
2024-03-07 kjlubick@google.com Fix debugger bazel build

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-07 22:21:50 +00:00
Zachary Anderson
0fb043e6f6 [gn] Disable running some python scripts from GN (flutter/engine#51248) 
For https://github.com/flutter/flutter/issues/144430
 2024-03-07 22:18:12 +00:00
Chris Bracken
b9d7f23abd Migrate build_overrides from buildroot to engine (flutter/engine#51258) 
Files under the build_overrides directory in the buildroot are typically hardcoded imports in third-party dependencies used for project-specific configuration. For example, ANGLE hardcodes an import of `//build_overrides/angle.gni` so that consumers of ANGLE can configure the build to their needs.

This adds a copy all existing src/build_overrides files at the equivalent `src/flutter/build_overrides` path in the engine. A followup patch will replace each existing file under `src/build_overrides` in the buildroot with a shim that just imports the files landed in this patch. This allows third-party dependencies to continue hardcoding the `//build_overrides/foo.gni` path, but provides a seamless path forward when we drop the buildroot.

Issue: https://github.com/flutter/flutter/issues/144790
Part of: https://github.com/flutter/flutter/issues/67373

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-07 21:42:06 +00:00
skia-flutter-autoroll
6f59be7215 Roll Fuchsia Linux SDK from y67DIBX84h7pAekIp... to 5Ra_AjCji-uR1GaX7... (flutter/engine#51261) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-07 20:58:17 +00:00
skia-flutter-autoroll
1894cb830d Roll Skia from cf7fefd0bbfb to 6bfd57b8790f (24 revisions) (flutter/engine#51260) 
https://skia.googlesource.com/skia.git/+log/cf7fefd0bbfb..6bfd57b8790f

2024-03-07 robertphillips@google.com Reduce matrix convolution image filter's maximum kernel size
2024-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 99a18601ac24 to e649d06fbad1
2024-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 82a4580a3c5a to f2cacee81b83 (6 revisions)
2024-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from b04a5aef564b to cbf986e97789
2024-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 0ccdb32ff1ca to 453d00b44c6b
2024-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from be5714074b1a to 24edbde4082b
2024-03-07 michaelludwig@google.com [skif] Add direct-drawing analog to getAnalyzedShaderView
2024-03-07 johnstiles@google.com Remove flag for SK_RASTER_PIPELINE_FASTER_POW_LOG.
2024-03-07 jlavrova@google.com Moving to the newer ICU4x version (1.4.1)
2024-03-07 jvanverth@google.com [graphite] Move small path management into RasterPathAtlas.
2024-03-07 robertphillips@google.com Manual Roll Dawn from 91a0358034d1 to 58cd45951deb (15 revisions)
2024-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9cd617cb0454 to 82a4580a3c5a (3 revisions)
2024-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 756dffd9e74f to 0dc646b71e8d (6 revisions)
2024-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 20d29a6cac1b to 0dc646b71e8d
2024-03-06 michaelludwig@google.com [skif] Add animating blur GM testing each tile mode
2024-03-06 jvanverth@google.com [graphite] Switch RasterPathAtlas to use DrawAtlasMgr.
2024-03-06 kjlubick@google.com Fix IWYU and clang-tidy suggestions on ganesh/geometry
2024-03-06 lovisolo@google.com [bazel] Fix broken CI task: BazelTest-benchmark-cpu_8888_benchmark_test-linux_rbe-linux_x64-NUC9i7QN_Debian11.
2024-03-06 penghuang@chromium.org Fix a crash in debug build
2024-03-06 kjlubick@google.com Try limiting all link jobs to 2 at a time
2024-03-06 nscobie@google.com Build Graphite in Android.bp's libskia_renderengine
2024-03-06 brianosman@google.com Add Cargo.lock and target/ to .gitignore
2024-03-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 49ae911d780a to 9cd617cb0454 (34 revisions)
2024-03-06 michaelludwig@google.com [skif] Separate X and Y transform analysis

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-07 20:56:31 +00:00
skia-flutter-autoroll
e365aa3c39 Roll Skia from f17ec7494469 to cf7fefd0bbfb (1 revision) (flutter/engine#51227) 
https://skia.googlesource.com/skia.git/+log/f17ec7494469..cf7fefd0bbfb

2024-03-06 drott@chromium.org [Fontations-backend] Color bitmap support.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-07 19:51:12 +00:00
skia-flutter-autoroll
579e866b42 Roll Dart SDK from bbf21a08a92d to 4bc97350dc47 (1 revision) (flutter/engine#51256) 
https://dart.googlesource.com/sdk.git/+log/bbf21a08a92d..4bc97350dc47

2024-03-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-211.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-07 18:37:14 +00:00
Juanjo Tugores
1e38a17a22 Prepend the accessibility placeholder (flutter/engine#51050) 
Prepends the accesibility placeholder. Previously it was being appended (last child) to the body. 

Relevant Issues are:

* Design doc: https://flutter.dev/go/focus-management 
* Focus in web multiview: https://github.com/flutter/flutter/issues/137443
* Platform dispatcher changes: https://github.com/flutter/engine/pull/49841

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-07 18:16:21 +00:00
Jesús S Guerrero
464ecf3948 Skip impeller goldens on release (flutter/engine#51240) 2024-03-07 17:24:33 +00:00
skia-flutter-autoroll
bed7b78e1f Roll Dart SDK from bf028d05b7fd to bbf21a08a92d (1 revision) (flutter/engine#51254) 
https://dart.googlesource.com/sdk.git/+log/bf028d05b7fd..bbf21a08a92d

2024-03-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-210.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-07 14:40:20 +00:00
skia-flutter-autoroll
aea8d14dc6 Roll Dart SDK from 3538739eeea9 to bf028d05b7fd (1 revision) (flutter/engine#51252) 
https://dart.googlesource.com/sdk.git/+log/3538739eeea9..bf028d05b7fd

2024-03-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-209.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-07 10:46:21 +00:00
Martin Kustermann
572d662658 Make @keepToString annotation work for web and non-web (flutter/engine#51251) 
* Update documentation for the annotation
* Add `@keepToString` annotation to web's `Locale` class (similar to
non-webs `Locale` class)

Issue https://github.com/flutter/flutter/issues/52759
 2024-03-07 10:33:13 +01:00
skia-flutter-autoroll
83afc6b52b Roll Dart SDK from 2cdf8f23c55f to 3538739eeea9 (1 revision) (flutter/engine#51249) 
https://dart.googlesource.com/sdk.git/+log/2cdf8f23c55f..3538739eeea9

2024-03-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-208.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-07 06:38:53 +00:00
skia-flutter-autoroll
66c3d1743d Roll Dart SDK from 3ad64881a209 to 2cdf8f23c55f (2 revisions) (flutter/engine#51247) 
https://dart.googlesource.com/sdk.git/+log/3ad64881a209..2cdf8f23c55f

2024-03-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-207.0.dev
2024-03-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-206.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-07 02:12:21 +00:00
Tong Mu
67603e5e32 Reland 5: Multiview pipeline (flutter/engine#51186) 
This relands https://github.com/flutter/engine/pull/50931.

The crash that caused the 4th revert has been fixed by https://github.com/flutter/flutter/pull/144212.

[There has been discussion](https://github.com/flutter/engine/pull/51019) on why the benchmark in previous attempts show significant drop in build time. This PR addresses it using option a as described in [this comment](https://github.com/flutter/engine/pull/51186#issuecomment-1977820525).

This PR also addresses https://github.com/flutter/flutter/issues/144584 with option 1. A test is added.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-07 01:54:14 +00:00
Jonah Williams
1322186f32 [Impeller] add a per-frame trace event for heap usage on Vulkan. (flutter/engine#51246) 
Part of https://github.com/flutter/flutter/issues/144617

Adds MemoryBudgetUsageMB which includes the MB of VMA allocated GPU and host memory, approximately per frame. This will be recorded in the devicelab and used to track how much memory pressure we're creating.

Split out from https://github.com/flutter/engine/pull/51187 since that was reverted (and doing big changes is a bad idea anyway).
 2024-03-07 01:40:04 +00:00
Chris Bracken
0e6d56bc1c Move Abseil from src to flutter third_party dir (flutter/engine#51245) 
In combination with:
* https://flutter-review.googlesource.com/c/third_party/abseil-cpp/+/55848
* https://github.com/flutter/buildroot/pull/831

this updates Flutter's references to Abseil from
//third_party/abseil-cpp to //flutter/third_party/abseil-cpp.

Issue: https://github.com/flutter/flutter/issues/144201
Part of: https://github.com/flutter/flutter/issues/67373

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-07 01:19:17 +00:00
skia-flutter-autoroll
049983fc56 Manual roll Dart SDK from 9ea8813ab4d4 to 3ad64881a209 (5 revisions) (flutter/engine#51242) 
Manual roll requested by zra@google.com

https://dart.googlesource.com/sdk.git/+log/9ea8813ab4d4..3ad64881a209

2024-03-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-205.0.dev
2024-03-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-204.0.dev
2024-03-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-203.0.dev
2024-03-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-202.0.dev
2024-03-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-201.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-07 00:13:11 +00:00
auto-submit[bot]
afd7f9739b Reverts "[Impeller] disable blending in gaussian intermediate steps. (#51118)" (flutter/engine#51244) 
Reverts: flutter/engine#51118
Initiated by: jonahwilliams
Reason for reverting: unexpected performance change

https://flutter-flutter-perf.skia.org/e/?queries=sub_result%3D90th_percentile_frame_rasterizer_time_millis%26sub_result%3D99th_percentile_frame_rasterizer_time_millis%26sub_result%3Daverage_frame_rasterizer_time_millis%26sub_result%3Dworst_frame_rasterizer_time_millis%26test%3Dbackdrop_filter_perf_ios__timeline_summary&selected=commit%3D39677%26name%3D%252Carch%253
Original PR Author: jonahwilliams

Reviewed By: {gaaclarke}

This change reverts the following previous change:
Noticed this while working on the StC debugging. We can disable blending on all intermediate gaussian steps. I don't know how much of an impact this has in practice.
 2024-03-06 23:55:17 +00:00
auto-submit[bot]
e3e37f2bee Reverts "[Impeller] fold memory check into allocator_vk (#51187)" (flutter/engine#51243) 
Reverts: flutter/engine#51187
Initiated by: jonahwilliams
Reason for reverting: unexpected benchmark regression

https://flutter-flutter-perf.skia.org/e/?queries=device_type%3DPixel_7_Pro%26sub_result%3D90th_percentile_frame_rasterizer_time_millis%26sub_result%3D99th_percentile_frame_rasterizer_time_millis%26sub_result%3Daverage_frame_rasterizer_time_millis%26sub_result%3Dworst_frame_rasterizer_time_millis%26test%3Dnew_gallery_impeller__transition_perf&selected=commit%3D396
Original PR Author: jonahwilliams

Reviewed By: {matanlurey}

This change reverts the following previous change:
Various cleanups to Vulkan allocator implementation:

1. Fixes https://github.com/flutter/flutter/issues/137454
2. Fold device transient cap check into allocator.
3. adds debug tracking for total memory usage in MB (a followup change needs to be made to driver to plumb it through)
4. Small cleanups to mock vulkan so an allocator can be created from it.
5. depth/stencil shouldn't be input attachments.

Part of https://github.com/flutter/flutter/issues/144617
 2024-03-06 23:52:25 +00:00
skia-flutter-autoroll
149c31822f Manual roll Dart SDK from 50464546d92d to 9ea8813ab4d4 (5 revisions) (flutter/engine#51239) 
Manual roll requested by zra@google.com

https://dart.googlesource.com/sdk.git/+log/50464546d92d..9ea8813ab4d4

2024-03-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-200.0.dev
2024-03-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-199.0.dev
2024-03-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-198.0.dev
2024-03-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-197.0.dev
2024-03-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.4.0-196.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-06 22:55:58 +00:00
Jesús S Guerrero
06c1e204da Skip impeller goldens on release branches (flutter/engine#51237) 
https://github.com/flutter/flutter/issues/144700
 2024-03-06 22:00:46 +00:00
Loïc Sharma
ece178965b [Windows] Allow plugins to get views (flutter/engine#51096) 
Allow Flutter Windows plugins to get views by their ID.

Design doc: https://flutter.dev/go/desktop-multi-view-runner-apis

Part of https://github.com/flutter/flutter/issues/143767
Part of https://github.com/flutter/flutter/issues/142845

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-03-06 21:19:19 +00:00
Jim Graham
5193a7bc02 add new builder benchmark with a global saveLayer (flutter/engine#51236) 
The existing DisplayListBuilder benchmarks that have a SaveLayer call do so around each rendering call which stresses measuring the cost of the SaveLayer/Restore calls. This new benchmark does a single SaveLayer/Restore around the entire array of rendering ops to measure the performance of adding new calls inside an existing layer.

No tests because this is just a new benchmark.
 2024-03-06 20:50:14 +00:00
Brandon DeRosier
80c055bfc9 [Flutter GPU] Move method tests to flutter_tester. (flutter/engine#51223) 
Part of https://github.com/flutter/flutter/issues/144640.

I'll be moving the rest of the pipeline-dependent tests and packaging a shader bundle for flutter_tester once Flutter GPU works against Vulkan/swiftshader.
 2024-03-06 20:33:01 +00:00
Zachary Anderson
2fdc3293eb Disable flaky linux desktop test (flutter/engine#51231) 
For https://github.com/flutter/flutter/issues/138197
 2024-03-06 20:27:00 +00:00
Jonah Williams
749903e027 [Impeller] fold memory check into allocator_vk (flutter/engine#51187) 
Various cleanups to Vulkan allocator implementation:

1. Fixes https://github.com/flutter/flutter/issues/137454
2. Fold device transient cap check into allocator.
3. adds debug tracking for total memory usage in MB (a followup change needs to be made to driver to plumb it through)
4. Small cleanups to mock vulkan so an allocator can be created from it.
5. depth/stencil shouldn't be input attachments.

Part of https://github.com/flutter/flutter/issues/144617
 2024-03-06 20:10:55 +00:00
skia-flutter-autoroll
8ea6cd44a4 Roll Fuchsia Linux SDK from ujOkbeYbrC8loPbfR... to y67DIBX84h7pAekIp... (flutter/engine#51233) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-06 19:58:17 +00:00
Brandon DeRosier
841c2b4b1d [Impeller] Append fewer redundant points when bridging triangle strips between contours. (flutter/engine#51232) 
Optimizes out 1-2 points per contour. Improvement to the TessellateConvex changes I made to get StC over the line.
 2024-03-06 19:17:57 +00:00
Jason Simmons
a72fddf954 [Impeller] Apply padding for alignment when doing HostBuffer::Emplace with a callback (flutter/engine#51221) 2024-03-06 18:58:46 +00:00
Jason Simmons
1b1eaf37d5 [Impeller] Create a new render target with the specified attachment configs when reusing cached render target textures (flutter/engine#51208) 
If the RenderTargetCache::Create methods reuse a cached RenderTarget as is, then the returned RenderTarget may contain AttachmentConfig parameters that do not match the ones passed to the create method.

This PR instead creates a new RenderTarget based on the existing textures from the cached RenderTarget.
 2024-03-06 18:57:20 +00:00
Matan Lurey
feef93058c Re-stamp skia_gold_client e2e tests. (flutter/engine#51220) 
Testing if `skia_gold_client` and pre-submit/post-submit is playing nice by triggering an update.

Generated via:

```sh
dart ./testing/skia_gold_client/tool/generate.dart
```

Related: https://github.com/flutter/flutter/issues/144352.
 2024-03-06 18:33:05 +00:00
Loïc Sharma
8f1baa30bb [et] Allow users to update dependencies (flutter/engine#51177) 
Allow users to update dependencies. Examples:

* `et fetch` Fetch dependencies

In the future, `et build` will update dependencies if it detects that they have changed.

Also:
* Updates the status in the README
* Adds instructions on how to run tests
* Fixes `et run`'s description
* Makes the `--verbose` flag global
 2024-03-06 17:00:23 +00:00
skia-flutter-autoroll
faac7b1f6e Manual roll Dart SDK from 728fcf0bcbca to 50464546d92d (5 revisions) (flutter/engine#51228) 
Manual roll requested by zra@google.com

https://dart.googlesource.com/sdk.git/+log/728fcf0bcbca..50464546d92d

2024-03-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.4.0-195.0.dev
2024-03-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.4.0-194.0.dev
2024-03-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.4.0-193.0.dev
2024-03-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.4.0-192.0.dev
2024-02-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.4.0-191.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter Engine:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-06 08:46:53 -08:00
skia-flutter-autoroll
63bb168431 Roll Skia from db3a36120ae2 to f17ec7494469 (3 revisions) (flutter/engine#51226) 
https://skia.googlesource.com/skia.git/+log/db3a36120ae2..f17ec7494469

2024-03-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 756dffd9e74f to 20d29a6cac1b
2024-03-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 65414438feb7 to 756dffd9e74f (6 revisions)
2024-03-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from f7e1ef5d45e2 to 91a0358034d1 (16 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-06 06:51:32 +00:00
skia-flutter-autoroll
7160bada6e Roll Skia from 1d1fd7fe1a89 to db3a36120ae2 (1 revision) (flutter/engine#51222) 
https://skia.googlesource.com/skia.git/+log/1d1fd7fe1a89..db3a36120ae2

2024-03-05 penghuang@chromium.org dawn: fix DawnCaps.cpp compile errors with webgpu

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-06 02:59:11 +00:00
Matan Lurey
31e26a1d52 Revamp the scenario_app/../README.md to encourage self-sustenance (flutter/engine#51196) 
Feedback welcome, though if it is non-blocking and ambiguous consider a follow-up PR instead 😸
 2024-03-06 01:26:13 +00:00
Jonah Williams
540cb080cc [Impeller] disable blending in gaussian intermediate steps. (flutter/engine#51118) 
Noticed this while working on the StC debugging. We can disable blending on all intermediate gaussian steps. I don't know how much of an impact this has in practice.
 2024-03-06 01:20:05 +00:00
Brandon DeRosier
98e6e399f1 [Impeller] Enable depth buffer clipping & Stencil-then-Cover path rendering. (flutter/engine#51219) 
Turn the page, wash your hands.

Addresses the following issues:
* https://github.com/flutter/flutter/issues/143077
* https://github.com/flutter/flutter/issues/137714
* https://github.com/flutter/flutter/issues/138460
* https://github.com/flutter/flutter/issues/123671
* https://github.com/flutter/flutter/issues/141961
* https://github.com/flutter/flutter/issues/134432

Previous attempts:
1. https://github.com/flutter/engine/pull/50856
    - reverted with https://github.com/flutter/engine/pull/51191
    - fixed with https://github.com/flutter/engine/pull/51198
2. https://github.com/flutter/engine/pull/51209
    - reverted with https://github.com/flutter/engine/pull/51217
    - fixed with https://github.com/flutter/engine/pull/51218
 2024-03-06 01:18:07 +00:00
skia-flutter-autoroll
85a60e33ae Roll Skia from 37947aec8c5c to 1d1fd7fe1a89 (1 revision) (flutter/engine#51216) 
https://skia.googlesource.com/skia.git/+log/37947aec8c5c..1d1fd7fe1a89

2024-03-05 jvanverth@google.com [graphite] Use internal class to manage DrawAtlas in SmallPathAtlas.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-06 01:18:05 +00:00
Brandon DeRosier
843eedbe39 [Impeller] Fix path winding when bridging from contours with an odd number of points. (flutter/engine#51218) 
If the previous contour has an odd number of points, insert a duplicate point to keep the winding order consistent across contours.

Before:

![Screenshot 2024-03-05 at 4 16 46 PM](https://github.com/flutter/engine/assets/919017/05306c92-78e9-4d16-88c1-6191d8ee1160)

After:

![Screenshot 2024-03-05 at 4 14 54 PM](https://github.com/flutter/engine/assets/919017/3743527f-d686-4c98-87f3-cb4db3c1a1ef)
 2024-03-06 01:13:04 +00:00
auto-submit[bot]
b17b3772b8 Reverts "[Impeller] Enable depth buffer clipping & Stencil-then-Cover path rendering. (#51209)" (flutter/engine#51217) 
Reverts flutter/engine#51209
Initiated by: bdero
Reason for reverting: Golden breakages on [engine roll](https://github.com/flutter/flutter/pull/144647) https://flutter-gold.skia.org/search?issue=144647&crs=github&patchsets=5&corpus=flutter
Original PR Author: bdero

Reviewed By: {jonahwilliams, chinmaygarde}

This change reverts the following previous change:
Original Description:
Turn the page, wash your hands.

Addresses the following issues:
* https://github.com/flutter/flutter/issues/143077
* https://github.com/flutter/flutter/issues/137714
* https://github.com/flutter/flutter/issues/138460
* https://github.com/flutter/flutter/issues/123671
* https://github.com/flutter/flutter/issues/141961
* https://github.com/flutter/flutter/issues/134432

Previous attempt:
- https://github.com/flutter/engine/pull/50856
    - reverted with https://github.com/flutter/engine/pull/51191
    - fixed with https://github.com/flutter/engine/pull/51198
 2024-03-05 23:47:35 +00:00
gaaclarke
425aeca227 [Impeller] implement blur style solid (flutter/engine#50892) 
fixes https://github.com/flutter/flutter/issues/134178

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-03-05 15:41:17 -08:00
Xilai Zhang
5b91595d3a [g3 roll] Revert "Remove unused drone_dimension field" (flutter/engine#51214) 
Reverts flutter/engine#50893

issue: https://github.com/flutter/flutter/issues/144644
 2024-03-05 23:07:04 +00:00
skia-flutter-autoroll
c715937d13 Roll Skia from 17677914dabf to 37947aec8c5c (5 revisions) (flutter/engine#51211) 
https://skia.googlesource.com/skia.git/+log/17677914dabf..37947aec8c5c

2024-03-05 drott@chromium.org Iterate emoji color font tests over more color font formats
2024-03-05 penghuang@chromium.org Add Caps::getDepthAttachmentDimensions()
2024-03-05 brianosman@google.com Remove SK_LEGACY_SNAP_DRAW_IMAGE_TRANSLATION
2024-03-05 drott@chromium.org [Fontations-backend] Add an empty FontMgr for Fontations
2024-03-05 jvanverth@google.com [graphite] Atlas management fixes for SmallPathAtlas.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,herb@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-03-05 22:57:48 +00:00
Loïc Sharma
d6bd7667e9 Fix git hooks on Windows (flutter/engine#51203) 
Windows does not pre-install python3. Previously Windows users would just use Python from depot tools, but this was broken by https://github.com/flutter/engine/pull/51156.
 2024-03-05 22:54:42 +00:00
Brandon DeRosier
29740b2b62 [Impeller] Enable depth buffer clipping & Stencil-then-Cover path rendering. (flutter/engine#51209) 
Turn the page, wash your hands.

Addresses the following issues:
* https://github.com/flutter/flutter/issues/143077
* https://github.com/flutter/flutter/issues/137714
* https://github.com/flutter/flutter/issues/138460
* https://github.com/flutter/flutter/issues/123671
* https://github.com/flutter/flutter/issues/141961
* https://github.com/flutter/flutter/issues/134432

Previous attempt:
- https://github.com/flutter/engine/pull/50856
    - reverted with https://github.com/flutter/engine/pull/51191
    - fixed with https://github.com/flutter/engine/pull/51198
 2024-03-05 21:23:00 +00:00