DoLT
017974987f
fix: check both pointer count and action before reusing MotionEvent ( #178528 )
...
Fix issue https://github.com/flutter/flutter/issues/169486
## Problem
After [PR #178015 ](https://github.com/flutter/flutter/pull/178015 ) was
merged, Android platform views experience gesture blocking after
multi-touch operations (e.g., pinch-to-zoom). The issue occurs because:
1. PR #178015 changed framework behavior to encode original pointer
count in events
2. Framework now sends events with **different actions** than the
original MotionEvent
- Example: Framework sends `ACTION_MOVE (2)` while original event is
`ACTION_POINTER_UP (6)`
3. The existing engine code only checked **pointer count**, not action
4. This caused the engine to use original event with wrong action →
gesture blocked
### Logs Showing the Issue
trackedEvent.pointerCount=2, touch.pointerCount=2, trackedEvent.action=6
(ACTION_POINTER_UP), touch.action=2 (ACTION_MOVE) → Pointer counts
MATCH, using original event → WebView receives ACTION_POINTER_UP but
expects ACTION_MOVE → Gesture blocked! ❌
2025-12-05 07:25:16 +00:00
engine-flutter-autoroll
d50dfb9bf7
Roll Fuchsia Linux SDK from VtDPX2k1kosHxjKUE... to vDeTl_KBeLJY8nCAx... ( #179478 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-05 01:08:52 +00:00
Ben Konyi
c1f134a009
[ Widget Preview ] Add embedded Widget Inspector support ( #178116 )
...
This change allows for users to open an instance of the DevTools Widget
Inspector within a web view embedded in the widget previewer. This will
allow for developers to inspect their previews without requiring IDEs to
create a special debug session for the widget previewer application.
DWDS is also rolled as part of this change to add DDS and DevTools
support for the `web-server` device.
Fixes https://github.com/flutter/flutter/issues/166423
**Demo:**
https://github.com/user-attachments/assets/3e3a1098-0526-4c7f-8087-38fb84f28335
2025-12-05 01:03:54 +00:00
gaaclarke
c33aa0af93
bubble up fragment shader errors ( #179363 )
...
fixes https://github.com/flutter/flutter/issues/176593
That issue was really fixed in
https://github.com/flutter/flutter/pull/175470 but this is extra cleanup
for error handling with shaders, including better error messages when
loading them in tests.
changes:
- Removes RuntimeStage::IsValid to statically assert that we only ever
have valid runtime stages
- Finally introduces ASSERT_OK which should have been added long ago
This doesn't propagate up shaderlibrary errors since that's flutter_gpu.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-12-05 01:03:53 +00:00
engine-flutter-autoroll
8421dec142
Roll Dart SDK from eda82318e193 to 42fe3327abca (1 revision) ( #179472 )
...
https://dart.googlesource.com/sdk.git/+log/eda82318e193..42fe3327abca
2025-12-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-208.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-05 01:00:51 +00:00
jesswrd
e5ffd42bcc
[Android 16] Use AVD With New Android Renderer ( #179306 )
...
We have confirmed that the [screenshot
tests](https://github.com/flutter/flutter/issues/170024#issuecomment-3582717105 )
failing on the 36 emulator successfully passes when using the latest
emulator from Android Studio (36.1). However, the tests in CI are not
passing when we test against an internal chromium provided emulator (and
not the emulator provided by Android Studio). We hypothesize the
previous failure could be because Flutter is depending on a next-gen
renderer but the avd version we were testing against did not depend on
the next-gen renderer.
We found an internal avd build version
[here](https://issuetracker.google.com/issues/425720132?pli=1#:~:text=are%20created%20in-,https%3A//ci.chromium.org/b/8702355247321119617,-Also%20switch%20GPU )
where the next-gen Android renderer IS being used.
Using the AVD
https://chrome-infra-packages.appspot.com/p/chromium/tools/android/avd/linux-amd64/+/okfRuASrBt9uNu5KYv7JXmEYJ76SXbWE5SMwMzvA2dMC
from the comment
[here](https://github.com/flutter/flutter/issues/170024#issuecomment-3608329781 ).
Partially Addresses https://github.com/flutter/flutter/issues/163071
Partially Addresses https://github.com/flutter/flutter/issues/170024
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-12-05 01:00:50 +00:00
Ben Konyi
49b416cf72
Unpin package:dwds dependency ( #179462 )
...
Refactoring of code in `package:dwds` `26.2.1` changed execution
ordering enough for a race condition in the web benchmark harness to be
hit. This change updates the web benchmark harness to not rely on
waiting for console output from the spawned browser which can be missed.
Fixes https://github.com/flutter/flutter/issues/178326
---------
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2025-12-05 00:59:02 +00:00
Jim Graham
4d76229470
[Impeller] include uniform info in impellerc json reflections ( #179317 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
Impellerc json reflection files include most of the data about the
shader, but they did not include the information about non-sampler
uniforms until now. This new information will be useful for tools that
extract information on uniform locations from shaders.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-12-05 00:57:51 +00:00
engine-flutter-autoroll
87dfc8ee3f
Roll Skia from 1591b066f49b to aea282ea0bcd (1 revision) ( #179468 )
...
https://skia.googlesource.com/skia.git/+log/1591b066f49b..aea282ea0bcd
2025-12-04
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (nontrivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-05 00:57:51 +00:00
engine-flutter-autoroll
f63cf73d31
Roll Skia from e1923478562b to 1591b066f49b (3 revisions) ( #179460 )
...
https://skia.googlesource.com/skia.git/+log/e1923478562b..1591b066f49b
2025-12-04 michaelludwig@google.com Fix missed typo corrections
2025-12-04 sergiog@microsoft.com [rust bmp] Define single action in
BUILD.gn for rust targets
2025-12-04 michaelludwig@google.com [sksl] Enforce f16 value limits for
literals
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-04 18:30:52 +00:00
Jackson Gardner
942783ca84
Cherry-pick flutter 3.38.4 changelog back to master. ( #179463 )
2025-12-04 18:16:05 +00:00
Harry Terkelsen
42d6f773a5
[web] Add clone method to LayerPicture and dispose pictures in PictureLayer ( #179162 )
...
Fixes https://github.com/flutter/flutter/issues/82878
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-12-04 17:49:23 +00:00
gaaclarke
5db062db06
Fixes merge conflict from high bitrate texture tests ( #179416 )
...
d57f6f81c6https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-12-04 16:41:53 +00:00
Mohellebi abdessalem
ea7fa2a4eb
Fix typos in VirtualDisplayController.java ( #179411 )
...
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-12-04 16:27:10 +00:00
engine-flutter-autoroll
3c0e42657b
Roll Dart SDK from 2de44cc08970 to eda82318e193 (1 revision) ( #179453 )
...
https://dart.googlesource.com/sdk.git/+log/2de44cc08970..eda82318e193
2025-12-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-207.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-04 16:27:10 +00:00
engine-flutter-autoroll
4788c7388d
Roll Skia from 55d94a54f453 to e1923478562b (1 revision) ( #179449 )
...
https://skia.googlesource.com/skia.git/+log/55d94a54f453..e1923478562b
2025-12-04 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from 134adc4c4785 to 77f89f1efc1a (11 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-04 16:21:38 +00:00
engine-flutter-autoroll
fb7f5854ac
Roll Packages from 8cb49035b169 to d39e481da550 (8 revisions) ( #179451 )
...
8cb49035b1...d39e481da510687576+bparrishMines@users.noreply.github.com [pigeon]
Fixes crash that occurs when an object that is removed from the instance
manager calls to Dart (flutter/packages#10552 )
2025-12-04 10687576+bparrishMines@users.noreply.github.com [pigeon]
Fixes error from constructor parameter sharing name with attached field
for a ProxyApi (flutter/packages#10541 )
2025-12-04 okorohelijah@google.com fix[image_picker_ios]: Prevent
transcoding on video selection (flutter/packages#10559 )
2025-12-04 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_wkwebview] Fixes crash when running
`WKNavigationResponse` tests on Xcode 26 (flutter/packages#10316 )
2025-12-03 15619084+vashworth@users.noreply.github.com Redistribute iOS
CODEOWNERS (flutter/packages#10520 )
2025-12-03 stuartmorgan@google.com [url_launcher] Update for UIScene
compatibility (flutter/packages#10549 )
2025-12-03 engine-flutter-autoroll@skia.org Roll Flutter from
e27457436b04 to 69d8710fadcd (5 revisions) (flutter/packages#10558 )
2025-12-03 engine-flutter-autoroll@skia.org Roll Flutter from
5545bb397e7b to e27457436b04 (17 revisions) (flutter/packages#10554 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-04 16:09:30 +00:00
Bruno Leroux
aa4f528492
Add DropdownMenu.selectOnly ( #179189 )
...
## Description
This PR adds `DropdownMenu.selectOnly`. This property allows users to
get the DropdownMenu behave as a 'select' component.
It is meant as a future replacement for
`DropdownMenu.requestFocusOnTap`.
## Motivation
On mobile, a dropdown menu widget is usually used as a ‘select’ widget
because opening the keyboard for searching/filtering is not convenient.
In Flutter, this is currently implemented through
`DropdownMenu.requestFocusOnTap` which defaults to false on mobile and
true on desktop.
The `DropdownMenu.requestFocusOnTap` property is currently used to set
`FocusNode.canRequestFocus`. This leads do difficulties mainly related
to focus traversal:
- Keyboard traversal requires workarounds (for instance relying on the
trailing icon to be focusable).
- Keyboard shortcuts require also a workaround (currently relying on a
Focus widget in a Stack).
- The `DropdownMenu` decoration does not reflect the focus state.
This PR proposes a new property named `DropdownMenu.selectOnly` which
does not require `DropdownMenu.requestFocusOnTap` to be false to make
the `DropdownMenu` behave like a select widget.
With this property the `DropdownMenu`:
- Supports keyboard navigation on mobile and desktop.
- Has a correct decoration when focused.
- Does not rely on the trailing icon to be focusable (see
https://github.com/flutter/flutter/issues/174096 ).
In the future this property could be used as a replacement for
`DropdownMenu.requestFocusOnTap`. For the moment, for compatibility, it
does not replace `DropdownMenu.requestFocusOnTap`.
## Related Issue
Fixes [Allow DropdownMenu to be non-editable and focusable (select
control) ](https://github.com/flutter/flutter/issues/178009 )
Also related to [Make DropdownMenu's trailing icon not focusable by
default](https://github.com/flutter/flutter/issues/174096 ) and
[[Material3] DropdownMenu Keyboard
Accessibility](https://github.com/flutter/flutter/issues/123797 ).
## Tests
- Adds 9 tests.
2025-12-04 13:41:36 +00:00
engine-flutter-autoroll
7915c80076
Roll Dart SDK from 7e6bfc6af55c to 2de44cc08970 (6 revisions) ( #179443 )
...
https://dart.googlesource.com/sdk.git/+log/7e6bfc6af55c..2de44cc08970
2025-12-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-206.0.dev
2025-12-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-205.0.dev
2025-12-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-204.0.dev
2025-12-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-203.0.dev
2025-12-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-202.0.dev
2025-12-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-201.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-04 11:41:40 +00:00
engine-flutter-autoroll
b3770ec6f4
Roll Skia from b8f79d7316c0 to 55d94a54f453 (1 revision) ( #179439 )
...
https://skia.googlesource.com/skia.git/+log/b8f79d7316c0..55d94a54f453
2025-12-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from ed5a5aaea53c to d7967c8594a6 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-04 10:15:39 +00:00
Pierre
1c5615c16e
Revise README for link updates and terminology changes ( #179357 )
...
Updated links and terminology for clarity and accuracy.
2025-12-04 09:10:06 +00:00
engine-flutter-autoroll
766f030d28
Roll Skia from ce19122e3982 to b8f79d7316c0 (3 revisions) ( #179436 )
...
https://skia.googlesource.com/skia.git/+log/ce19122e3982..b8f79d7316c0
2025-12-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 9e0f35674d95 to 882a54755450 (9 revisions)
2025-12-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from fc22c105a6d3 to 134adc4c4785 (25 revisions)
2025-12-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from f4ccba99d0aa to 0f45bef5b019 (8 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-04 08:15:18 +00:00
Bruno Leroux
0e11196c03
Update some BottomNavigationBar comments to reflect theme normalization ( #179404 )
...
## Description
This PR updates [BottomNavigationBar.selectedItemColor] and
[BottomNavigationBar.unselectedItemColor] documentation to reflect the
changes related to theme normalization.
It also fixes the [BottomNavigationBar.selectedItemColor] documentation
to mention the correct default values.
## Related Issue
Related to https://github.com/flutter/flutter/issues/91772
## Tests
- Documentation only
2025-12-04 08:03:24 +00:00
Robert Ancell
e285737275
Replace use of eglCreateImage with eglCreateImageKHR to reduce EGL requirement ( #179310 )
...
This otherwise required EGL 1.5. This matches the Android embedder which
also uses the extension version.
Fixes https://github.com/flutter/flutter/issues/178462
2025-12-04 03:35:05 +00:00
engine-flutter-autoroll
5017d7f937
Roll Skia from 81a9a0751f00 to ce19122e3982 (5 revisions) ( #179430 )
...
https://skia.googlesource.com/skia.git/+log/81a9a0751f00..ce19122e3982
2025-12-03 bungeman@google.com Try harder for sans-serif and aliases
2025-12-03
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-12-03
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-12-03
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-12-03 nicolettep@google.com Add missing include
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-04 02:46:22 +00:00
gaaclarke
e0be74f835
[impellerc] adds entry prefix flag to avoid shader collisions ( #179160 )
...
fixes https://github.com/flutter/flutter/issues/178766
This adds an "imp_" to all impeller shader entrypoints so that they are
much less likely to collide with user's shaders.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-12-04 01:07:22 +00:00
Jon Ihlas
5cf560e08c
[Windows] Allow apps to prefer high power GPUs ( #177653 )
...
Added a `HighPerformancePreference` flag alongside the existing
`LowPowerPreference`, following the same principle.
This is useful for games and other high-performance applications.
You just need to add in the `main.cpp` of the app:
`project.set_gpu_preference(flutter::GpuPreference::HighPerformancePreference);`
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
2025-12-04 00:40:26 +00:00
Ben Konyi
430800f8c0
[ Infra ] Shard Windows tool_tests_commands ( #179409 )
...
Should fix https://github.com/flutter/flutter/issues/177708
2025-12-04 00:36:54 +00:00
Nicholas Shahan
a147aadf7e
[flutter_tools] Fix filename typo ( #179427 )
...
web_server_utlities.dart -> web_server_utilities.dart
2025-12-04 00:10:41 +00:00
Flutter GitHub Bot
60404cac55
Marks Linux_pixel_7pro draw_arcs_all_stroke_styles_perf__timeline_summary to be unflaky ( #179392 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_pixel_7pro
draw_arcs_all_stroke_styles_perf__timeline_summary"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20draw_arcs_all_stroke_styles_perf__timeline_summary%22 ).
This test can be marked as unflaky.
Co-authored-by: b-luk <97480502+b-luk@users.noreply.github.com>
2025-12-04 00:07:21 +00:00
Flutter GitHub Bot
5bea8c2e9e
Marks Mac_ios draw_arcs_all_fill_styles_perf_ios__timeline_summary to be unflaky ( #179391 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_ios draw_arcs_all_fill_styles_perf_ios__timeline_summary"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20draw_arcs_all_fill_styles_perf_ios__timeline_summary%22 ).
This test can be marked as unflaky.
Co-authored-by: b-luk <97480502+b-luk@users.noreply.github.com>
2025-12-03 23:45:23 +00:00
Flutter GitHub Bot
6d35d0af0c
Marks Linux_pixel_7pro draw_arcs_all_fill_styles_perf__timeline_summary to be unflaky ( #179390 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_pixel_7pro
draw_arcs_all_fill_styles_perf__timeline_summary"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20draw_arcs_all_fill_styles_perf__timeline_summary%22 ).
This test can be marked as unflaky.
Co-authored-by: b-luk <97480502+b-luk@users.noreply.github.com>
2025-12-03 23:45:23 +00:00
Jason Simmons
1f159d9040
Roll Abseil to 564023aa5376 ( #179421 )
...
Includes the ABSL_ASSERT_OK macro (see
https://github.com/flutter/flutter/pull/179363 )
2025-12-03 23:01:06 +00:00
gaaclarke
27ccc2e66f
Made wide gamut tests give more information in their failure ( #179415 )
...
fixes https://github.com/flutter/flutter/issues/179396
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-12-03 21:10:26 +00:00
engine-flutter-autoroll
8e952d6297
Roll Skia from c20f797ab6f9 to 81a9a0751f00 (5 revisions) ( #179417 )
...
https://skia.googlesource.com/skia.git/+log/c20f797ab6f9..81a9a0751f00
2025-12-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 29d26a280798 to ed5a5aaea53c (6 revisions)
2025-12-03 fmalita@google.com Add pathdata kill switch
2025-12-03
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-12-03 ccameron@chromium.org Agtm: Add constructor and remove copy
constructors
2025-12-03 ccameron@chromium.org Fix SkCodecs::ColorProfile builds
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-03 19:48:08 +00:00
Loïc Sharma
f86062c512
Migrate samples and docs to RadioGroup ( #179158 )
...
Migrates some - but not all - samples to use the new `RadioGroup`
widget.
See:
[https://docs.flutter.dev/release/breaking-changes/radio-api-redesign ](https://docs.flutter.dev/release/breaking-changes/radio-api-redesign )
Part of: https://github.com/flutter/flutter/issues/179088
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-12-03 19:39:01 +00:00
Ivan Inozemtsev
d980c7c4e2
Roll Dart SDK to 3.11.0-200.1.beta ( #179399 )
...
The changes between tho current dart (198-dev) and this one:
https://dart.googlesource.com/sdk/+log/0bb365d7ac749a46ce07e70a066b96d9da6cb8a9..6706a94aa76582acbd4f7086329f853de76b83d8
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-12-03 18:44:51 +00:00
Flutter GitHub Bot
69d8710fad
Marks Linux_pixel_7pro new_gallery_opengles_impeller__transition_perf to be unflaky ( #179389 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_pixel_7pro
new_gallery_opengles_impeller__transition_perf"
}
-->
The issue https://github.com/flutter/flutter/issues/173337 has been
closed, and the test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20new_gallery_opengles_impeller__transition_perf%22 ).
This test can be marked as unflaky.
Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com>
2025-12-03 17:32:31 +00:00
engine-flutter-autoroll
6884b77637
Roll Fuchsia Linux SDK from l0DvmZrMHlF12frrX... to VtDPX2k1kosHxjKUE... ( #179408 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-03 16:35:40 +00:00
Flutter GitHub Bot
fc5d4c0f58
Marks Linux_pixel_7pro hello_world_impeller to be unflaky ( #179388 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_pixel_7pro hello_world_impeller"
}
-->
The issue https://github.com/flutter/flutter/issues/173698 has been
closed, and the test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20hello_world_impeller%22 ).
This test can be marked as unflaky.
2025-12-03 16:35:40 +00:00
engine-flutter-autoroll
7bf74a4723
Roll Packages from 148dcd22d041 to 8cb49035b169 (3 revisions) ( #179407 )
...
148dcd22d0...8cb49035b1srawlins@google.com Remove `no_adjacent_strings_in_list` from
enabled lint rules. (flutter/packages#7878 )
2025-12-02 engine-flutter-autoroll@skia.org Roll Flutter from
05d6005dd85c to 5545bb397e7b (28 revisions) (flutter/packages#10551 )
2025-12-02 stuartmorgan@google.com [two_dimensional_scrollables] Update
test for deprecation (flutter/packages#10525 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-03 15:55:35 +00:00
engine-flutter-autoroll
5c64d54db6
Roll Skia from db4c79d41513 to c20f797ab6f9 (1 revision) ( #179403 )
...
https://skia.googlesource.com/skia.git/+log/db4c79d41513..c20f797ab6f9
2025-12-03 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from 719fa5ff65ad to fc22c105a6d3 (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-03 15:35:04 +00:00
engine-flutter-autoroll
e27457436b
Roll Skia from 20829e37dfb8 to db4c79d41513 (1 revision) ( #179401 )
...
https://skia.googlesource.com/skia.git/+log/20829e37dfb8..db4c79d41513
2025-12-03 ccameron@chromium.org SkEncodedInfo::ICCProfile: Rename to
ColorProfile
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-03 13:30:46 +00:00
engine-flutter-autoroll
76968e7906
Roll Skia from adc7ea94cada to 20829e37dfb8 (6 revisions) ( #179385 )
...
https://skia.googlesource.com/skia.git/+log/adc7ea94cada..20829e37dfb8
2025-12-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 4f9af4659432 to 9e0f35674d95 (3 revisions)
2025-12-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 04fbb7daf5a5 to 518a9f63228d (1 revision)
2025-12-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 6c10ef924124 to f4ccba99d0aa (4 revisions)
2025-12-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 31a119af4073 to 719fa5ff65ad (11 revisions)
2025-12-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 577557704db9 to 29d26a280798 (9 revisions)
2025-12-03
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-03 08:05:19 +00:00
Tirth
fb780b5156
Refactor GetShaderClipDepth for clarity ( #179110 )
...
Refactor GetShaderClipDepth for clarity. Fixes #179105
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2025-12-03 04:53:42 +00:00
engine-flutter-autoroll
8e6af9e042
Roll Skia from 3b339a83959b to adc7ea94cada (1 revision) ( #179376 )
...
https://skia.googlesource.com/skia.git/+log/3b339a83959b..adc7ea94cada
2025-12-03
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-03 03:37:29 +00:00
engine-flutter-autoroll
a2d822d263
Roll Dart SDK from eb743a1d4ade to 0bb365d7ac74 (7 revisions) ( #179372 )
...
https://dart.googlesource.com/sdk.git/+log/eb743a1d4ade..0bb365d7ac74
2025-12-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-198.0.dev
2025-12-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-197.0.dev
2025-12-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-196.0.dev
2025-12-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-195.0.dev
2025-12-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-194.0.dev
2025-12-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-193.0.dev
2025-12-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.11.0-192.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-03 02:10:41 +00:00
Nebojša Cvetković
1869f5047d
feat: Add mainAxisExtent parameter to GridView constructors ( #176927 )
...
Fixes #55290 .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-12-03 02:05:40 +00:00
engine-flutter-autoroll
cacdf897e5
Roll Skia from eb01fff20df8 to 3b339a83959b (4 revisions) ( #179371 )
...
https://skia.googlesource.com/skia.git/+log/eb01fff20df8..3b339a83959b
2025-12-02
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-12-02 ccameron@chromium.org Add skhdr::Agtm interface
2025-12-02
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-12-02 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
ANGLE from a41389954432 to 4f9af4659432 (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jsimmons@google.com ,kjlubick@google.com,nicolettep@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-12-03 01:47:26 +00:00
Renzo Olivares
102cde6efa
Fix crash when text editing value changes between scrolls ( #179163 )
...
This change fixes a crash in `EditableText` that occurs when the text
editing value changes between two scrolls, when the second scroll ends
`_dataWhenToolbarShowScheduled` will be invalidated. If the second
scroll ends before the post frame callback scheduled by the first scroll
has a chance to execute, there will be a crash because
`_dataWhenToolbarShowScheduled` is being accessed while null.
This change also invalidates a scheduled toolbar if the text editing
value has changed before the post-frame callback has a chance to run.
Fixes #179164
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
---------
Co-authored-by: Renzo Olivares <roliv@google.com>
2025-12-02 22:53:24 +00:00
