Victor Sanni
5307202991
Shortcircuit if Tooltip message and richMessage are empty
2026-02-17 18:05:22 -08:00
Hannah Jin
f5825a22a4
[a11y] RangeSlider mouse interaction should change keyboard focus ( #182185 )
...
fix: https://github.com/flutter/flutter/issues/173575
RangeSlider manages its own focus node for 2 thumbs. ( a special case
because it's one widget, one render object but two focus nodes)
so when you dragging a thumb, or tap a thumb, the focus node should
request focus.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-02-17 20:41:38 +00:00
Mohellebi Abdessalem
a58324d980
Remove more getters from userMessages class ( #182166 )
...
Towards #125155
This change refactors out more getters form `userMessages` into the
appropriate places.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-02-17 20:40:29 +00:00
walley892
8f61855ded
Implement getUniformMatX and getUniformMatXArray functionality on web ( #182249 )
...
What it says on the tin.
Implementes getUniformMat2, getUniformMat3, getUniformMat4,
getUniformMat2Array, getUniformMat3Array, and getUniformMat4Array on the
web. This will allow users to get matrix uniforms by name.
Also adds tests for existing matrix functionality on web.
Before:
```dart
setFloat(0, 1.0);
setFloat(1, 0.0);
setFloat(2, 0.0);
setFloat(3, 1.0);
```
After:
```
shader.getUniformMat2('uIdentity').set(
1.0, 0.0,
0.0, 1.0,
)
```
2026-02-17 20:25:26 +00:00
Victor Sanni
7ac16a2763
Do not wait until dispose before removing replaced/popped page ( #182315 )
...
Regression was introduced in [Cleans up navigator pop and remove
logic](https://github.com/flutter/flutter/pull/175612/changes#top ).
That PR moved the `onDidRemovePage` call to `_flushHistoryUpdates` in
phase `_RouteLifecycle.dispose`. But waiting until `dispose` causes
potential problems if the widget is rebuilt in a phase preceding that
(but after `pop` or `pushReplacement` has been called). So the outdated
page remains in the pages list even after it has been marked for
removal.
This is causing the page to be pushed again before it is finally
removed, causing the flicker.
## Before
https://github.com/user-attachments/assets/73dba22d-e668-4b2d-84f3-a0beb1faebab
## After
https://github.com/user-attachments/assets/6c8c6ffc-87f0-494f-bd41-7fde1f21d0e1
Fixes [[Navigation] Popping a nested route while the parent is
rebuilding causes a
flicker](https://github.com/flutter/flutter/issues/178570 )
2026-02-17 20:23:52 +00:00
Илия
70870ee8d3
Add contentTextStyle support to SimpleDialog ( #178824 )
...
## Description
This PR adds `contentTextStyle` support to `SimpleDialog`, matching the
functionality already available in `AlertDialog`.
### Problem
`SimpleDialog` was ignoring `DialogTheme.contentTextStyle`, even though
the `DialogThemeData.contentTextStyle` documentation explicitly states
it applies to `SimpleDialog.children`:
> "Overrides the default value for DefaultTextStyle for
SimpleDialog.children and AlertDialog.content."
However, only `AlertDialog` actually implemented this behavior, forcing
developers to specify text styles individually on each child widget.
### Solution
Added `contentTextStyle` parameter to `SimpleDialog` and applied it
using `DefaultTextStyle`, following the same pattern as `AlertDialog`.
The implementation uses the standard fallback chain:
`contentTextStyle` parameter → `DialogTheme.contentTextStyle` → M2/M3
defaults
### Testing
Added a new test `'SimpleDialog Custom Content Text Style'` that
verifies `contentTextStyle` is correctly applied to the children of
`SimpleDialog`.
## Related Issues
Fixes https://github.com/flutter/flutter/issues/59462
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
2026-02-17 20:20:21 +00:00
Alex Medinsh
ecf688eb21
Filter error messages from emulator -list-avds output ( #180802 )
...
Adds a simple heuristic to filter out the info and error messages that
`emulator -list-avds` can output sometimes. The heuristic assumes that
emulator names can only contain `a-z0-9_.-` in their names.
Fixes https://github.com/flutter/flutter/issues/146125
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2026-02-17 19:53:08 +00:00
Navaron Bracke
5b1c84cec1
[Reland] Cupertino cross imports ( #182416 )
...
This is a reland of https://github.com/flutter/flutter/pull/181634 which
broke the tree, because https://github.com/flutter/flutter/pull/182395
also landed and probably conflicted with it.
Part of https://github.com/flutter/flutter/issues/177415
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-02-17 19:35:11 +00:00
engine-flutter-autoroll
35e8dae342
Roll Packages from 09104b08c326 to f83926f04ca8 (1 revision) ( #182504 )
...
09104b08c3...f83926f04c
2026-02-17 stuartmorgan@google.com [ci] Update release to 3.41
(flutter/packages#11014 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-17 19:16:30 +00:00
Elijah Okoroh
6e4a481bdf
Fix iOS CI tests for Xcode 26 Swift compatibility ( #182132 )
...
Fixes Swift_force_load - check #175905 for more info
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Victoria Ashworth <15619084+vashworth@users.noreply.github.com>
2026-02-17 17:45:34 +00:00
Camille Simon
9292bb3a66
Revert "[Android] Add mechanism for setting Android engine flags via … ( #182388 )
...
Reverts https://github.com/flutter/flutter/pull/181632 due to internal
performance regressions of startup time in the order of 100ms.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-02-17 15:39:30 +00:00
engine-flutter-autoroll
9fa7f81be0
Roll Skia from 4ed9faf843e6 to dfe78d132e24 (1 revision) ( #182485 )
...
https://skia.googlesource.com/skia.git/+log/4ed9faf843e6..dfe78d132e24
2026-02-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from ad96e4bb5071 to aca6a0fe0850 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
aaclarke@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-17 10:03:31 +00:00
engine-flutter-autoroll
aba16bc2db
Roll Skia from ff0af46bf172 to 4ed9faf843e6 (2 revisions) ( #182483 )
...
https://skia.googlesource.com/skia.git/+log/ff0af46bf172..4ed9faf843e6
2026-02-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from db23e5d58c86 to 0bf4148fb3a6 (11 revisions)
2026-02-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 1a3afc99a7ef to aad5a316dd86 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-17 07:48:18 +00:00
engine-flutter-autoroll
a78f96e1c0
Roll Skia from 24c7b6f5760f to ff0af46bf172 (1 revision) ( #182481 )
...
https://skia.googlesource.com/skia.git/+log/24c7b6f5760f..ff0af46bf172
2026-02-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 9920252190c8 to 0c958d3b123a (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-17 05:33:19 +00:00
engine-flutter-autoroll
cb9537c0d3
Roll Dart SDK from ff57548fcf54 to 44895e617182 (1 revision) ( #182479 )
...
https://dart.googlesource.com/sdk.git/+log/ff57548fcf54..44895e617182
2026-02-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-154.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-16 23:42:26 +00:00
engine-flutter-autoroll
628c74cd0c
Roll Fuchsia Linux SDK from YND8TyaxKkkkEvlD9... to mcN42vw48OPH3JDNm... ( #182478 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-16 23:30:28 +00:00
engine-flutter-autoroll
32741ac55c
Roll Dart SDK from c819ebe0cbe3 to ff57548fcf54 (1 revision) ( #182472 )
...
https://dart.googlesource.com/sdk.git/+log/c819ebe0cbe3..ff57548fcf54
2026-02-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-153.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-16 18:37:36 +00:00
Kishan Rathore
1f72d29b4c
feat: add routes support in TestWidgetsApp ( #181695 )
...
Feat: Add routes and transitionBuilder support in TestWidgetsApp
part of: https://github.com/flutter/flutter/issues/177415
As many test might need navigation with routes, we need to expose route
from WidgetApp to TestWidgetsApp.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2026-02-16 17:17:07 +00:00
engine-flutter-autoroll
e4b6292935
Roll Skia from 5c8a6641902f to 24c7b6f5760f (1 revision) ( #182467 )
...
https://skia.googlesource.com/skia.git/+log/5c8a6641902f..24c7b6f5760f
2026-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 04048f075303 to 9920252190c8 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-16 16:31:36 +00:00
engine-flutter-autoroll
69ab3fd054
Roll Skia from 94d5d5e5f785 to 5c8a6641902f (6 revisions) ( #182463 )
...
https://skia.googlesource.com/skia.git/+log/94d5d5e5f785..5c8a6641902f
2026-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 8ff522b74b01 to db23e5d58c86 (8 revisions)
2026-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 48f5ceeea3ef to 1a3afc99a7ef (2 revisions)
2026-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
debugger-app-base from 959c34d2cdd3 to 44807f17a4cc
2026-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
skottie-base from af6d4026789b to 4dc2907743fd
2026-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
shaders-base from dd6a75180b0b to 8e3b6d97c1c6
2026-02-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
jsfiddle-base from 9c6712732384 to 1b7f09f5d7a2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-16 10:58:26 +00:00
engine-flutter-autoroll
583fe14c5d
Roll Dart SDK from f2289e13a20a to c819ebe0cbe3 (1 revision) ( #182462 )
...
https://dart.googlesource.com/sdk.git/+log/f2289e13a20a..c819ebe0cbe3
2026-02-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-152.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-16 10:42:26 +00:00
engine-flutter-autoroll
27bf8623b5
Roll Dart SDK from 294e6e248512 to f2289e13a20a (1 revision) ( #182448 )
...
https://dart.googlesource.com/sdk.git/+log/294e6e248512..f2289e13a20a
2026-02-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-151.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-15 22:11:26 +00:00
engine-flutter-autoroll
c480ca18cd
Roll Skia from b7cea4cbe546 to 94d5d5e5f785 (1 revision) ( #182446 )
...
https://skia.googlesource.com/skia.git/+log/b7cea4cbe546..94d5d5e5f785
2026-02-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 80b7d629489f to 04048f075303 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-15 21:50:29 +00:00
engine-flutter-autoroll
7b7523fbfe
Roll Fuchsia Linux SDK from pkyhAZ3sQZDzeNZym... to YND8TyaxKkkkEvlD9... ( #182445 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-15 21:19:19 +00:00
engine-flutter-autoroll
48a9065b69
Roll Skia from a3a82d359a7b to b7cea4cbe546 (1 revision) ( #182439 )
...
https://skia.googlesource.com/skia.git/+log/a3a82d359a7b..b7cea4cbe546
2026-02-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SKP
CIPD package from 552 to 553
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-15 15:39:26 +00:00
engine-flutter-autoroll
06b0fc07de
Roll Skia from a147ae2d4adc to a3a82d359a7b (1 revision) ( #182435 )
...
https://skia.googlesource.com/skia.git/+log/a147ae2d4adc..a3a82d359a7b
2026-02-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 2177dbbd326b to 80b7d629489f (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-15 11:13:30 +00:00
engine-flutter-autoroll
ab3b766230
Roll Dart SDK from f82ec89435f5 to 294e6e248512 (1 revision) ( #182432 )
...
https://dart.googlesource.com/sdk.git/+log/f82ec89435f5..294e6e248512
2026-02-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-150.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-15 06:14:26 +00:00
engine-flutter-autoroll
2dbb266834
Roll Skia from 91d158b0a61e to a147ae2d4adc (2 revisions) ( #182424 )
...
https://skia.googlesource.com/skia.git/+log/91d158b0a61e..a147ae2d4adc
2026-02-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 6a86f2fce200 to 2177dbbd326b (2 revisions)
2026-02-14 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
ANGLE from 71ead6fdeb53 to ad96e4bb5071 (13 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com ,jimgraham@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-14 19:24:13 +00:00
engine-flutter-autoroll
5f58b37fda
Roll Fuchsia Linux SDK from V30FBkJySjFKXwVjW... to pkyhAZ3sQZDzeNZym... ( #182423 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-14 17:12:11 +00:00
engine-flutter-autoroll
12f978221a
Roll Skia from e5a18f8f0d4a to 91d158b0a61e (1 revision) ( #182422 )
...
https://skia.googlesource.com/skia.git/+log/e5a18f8f0d4a..91d158b0a61e
2026-02-14 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from 1f4a9ec2512b to 48f5ceeea3ef (13 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com ,jimgraham@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-14 17:02:27 +00:00
engine-flutter-autoroll
60b5e62a24
Roll Dart SDK from 7a2a28dbd0d4 to f82ec89435f5 (2 revisions) ( #182414 )
...
https://dart.googlesource.com/sdk.git/+log/7a2a28dbd0d4..f82ec89435f5
2026-02-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-149.0.dev
2026-02-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-148.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-14 08:55:43 +00:00
engine-flutter-autoroll
872d0149a1
Roll Skia from befeec673f1b to e5a18f8f0d4a (1 revision) ( #182412 )
...
https://skia.googlesource.com/skia.git/+log/befeec673f1b..e5a18f8f0d4a
2026-02-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 92cf0901ef59 to 6a86f2fce200 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com ,jimgraham@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-14 07:51:40 +00:00
engine-flutter-autoroll
76dcd96d13
Roll Skia from 7dc3ba9b1d90 to befeec673f1b (1 revision) ( #182408 )
...
https://skia.googlesource.com/skia.git/+log/7dc3ba9b1d90..befeec673f1b
2026-02-13 fmalita@google.com [skottie] Add Viewer keybind for
CoreText-based shaping
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com ,jimgraham@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-14 05:40:27 +00:00
Koji Wakamiya
8798c51998
[Web] Fix IME and selection by syncing more text styles ( #180436 )
...
fix https://github.com/flutter/flutter/issues/161592
The current implementation does not fully reflect
[letter-spacing](https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/letter-spacing ),
[word-spacing](https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/word-spacing ),
and
[line-height](https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/line-height )
in the DOM. 0bc99f8c4f70973a1877c88ca35804e9bc5fabcf
And the current implementation generates an DomHTMLTextAreaElement every
time the `enabled`. Therefore, it reapplies the
[scrollTop](https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollTop )
value that the Element had been holding internally.
726491298d2b1f17681cab421c7c9276dde19ee6
https://github.com/user-attachments/assets/6f575366-12a0-4246-b2ab-eb2a0e85cfa5
https://github.com/user-attachments/assets/ec660d4c-5166-450c-be38-77b90fcfce76
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MainApp());
class MainApp extends StatelessWidget {
const MainApp({super.key});
@override
Widget build(BuildContext context) {
return const MaterialApp(home: MainPage());
}
}
class MainPage extends StatelessWidget {
const MainPage({super.key});
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(title: Text('Selection position')),
body: SingleChildScrollView(
padding: const .all(16),
child: Column(
children: [
const Text('height=null'),
TextField(maxLines: 5, style: TextStyle(height: null)),
const Text('height=1.0'),
TextField(maxLines: 5, style: TextStyle(height: 1.0)),
const Text('height=2.0'),
TextField(maxLines: 5, style: TextStyle(height: 2.0)),
],
),
),
);
}
}
```
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-02-14 03:30:25 +00:00
engine-flutter-autoroll
bb71d3549a
Roll Skia from bb69b5b71b4f to 7dc3ba9b1d90 (2 revisions) ( #182401 )
...
https://skia.googlesource.com/skia.git/+log/bb69b5b71b4f..7dc3ba9b1d90
2026-02-13 mike@reedtribe.org Removing obsolete math benches
2026-02-13 borenet@google.com [infra] Update iOS provisioning profile,
add create script
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com ,jimgraham@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-14 03:10:21 +00:00
gaaclarke
5059a9c28b
Disable multithread opengles, enables remaining fragment shader tests ( #182384 )
...
fixes https://github.com/flutter/flutter/issues/180764
test exempt: is test
Opengles requires a separate context for the raster and io threads that
have a share group. Swangle doesn't seem to have support for that so
we'll just run the opengles tests in a single threaded environment.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-02-14 03:08:25 +00:00
auto-submit[bot]
ab86f66e94
Reverts "Standardize on Test* widgets in *_tester.dart files ( #182395 )" ( #182406 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#182395
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: gaaclarke
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: this is causing breakages on the dashboard
example:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8689933991528003217/+/u/run_test.dart_for_framework_tests_shard_and_subshard_libraries/stdout
```
10:36 +9458 ~24: /b/s/w/ir/x/w/flutter/packages/flutter/test/material/dialog_test.dart: Dialog children padding is correct AlertDialog padding is correct when only icon, title a
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: justinmc
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {Renzo-Olivares, victorsanni, navaronbracke}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
This PR moves:
* TestTextField from editable_text_utils.dart to editable_text_tester.dart
* TestListTile from list_tile_test_utils.dart to list_tile_tester.dart
* TestButton from utils.dart to button_tester.dart
The purpose is to align with other Test* widgets, such as TestWidgetsApp in [widgets_app_tester.dart](https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/widgets_app_tester.dart ) and TestSemantics in [semantics_tester.dart](https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/semantics_tester.dart ).
We should continue to follow this pattern in the future, such as in https://github.com/flutter/flutter/pull/181722 .
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2026-02-14 01:46:47 +00:00
auto-submit[bot]
1a1ddb0f16
Reverts "Fix cross imports for all Cupertino tests ( #181634 )" ( #182404 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#181634
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: chunhtai
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: tree breakage
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: navaronbracke
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {justinmc}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
This PR fixes all of the Cupertino cross imports, except for the one
that uses `SelectableText`, which needs further discussion.
Some Material specific tests for Cupertino are now under
`tests/material/cupertino`.
Part of https://github.com/flutter/flutter/issues/177415
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2026-02-14 00:28:48 +00:00
Victor Sanni
d3a07677ec
Add await to tester.pump callsites ( #182398 )
...
Surprised we missed this when reviewing the 0x0 PRs. cc @ahmedsameha1
2026-02-13 23:55:28 +00:00
Jaime Wren
ac3aa6dad6
refactor: Centralize table formatting logic into a new formatTable utility function. ( #182196 )
...
This resolves https://github.com/flutter/flutter/issues/180949
This is follow-up on https://github.com/flutter/flutter/pull/180098
2026-02-13 23:19:59 +00:00
gaaclarke
d802cab600
Adds impeller backend to golden workspace name ( #182387 )
...
fixes https://github.com/flutter/flutter/issues/181399
I'm unable to verify 100% that this is the failure since i can't
reproduce it locally but I believe this is it.
test exempt: is a test
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-02-13 23:01:04 +00:00
Justin McCandless
cf4291157b
Standardize on Test* widgets in *_tester.dart files ( #182395 )
...
This PR moves:
* TestTextField from editable_text_utils.dart to
editable_text_tester.dart
* TestListTile from list_tile_test_utils.dart to list_tile_tester.dart
* TestButton from utils.dart to button_tester.dart
The purpose is to align with other Test* widgets, such as TestWidgetsApp
in
[widgets_app_tester.dart](https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/widgets_app_tester.dart )
and TestSemantics in
[semantics_tester.dart](https://github.com/flutter/flutter/blob/master/packages/flutter/test/widgets/semantics_tester.dart ).
2026-02-13 22:59:39 +00:00
Hameed Habeeblahi Gbolahan
8d238ab04d
Remove Material dependency from transformed_scrollable_test.dart ( #182141 )
...
Replace `MaterialApp` with `TestWidgetsApp` and
`Colors.blue`/`Colors.red` with named constants to remove the Material
library dependency.
Part of #177414
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Co-authored-by: Navaron Bracke <brackenavaron@gmail.com>
2026-02-13 21:57:34 +00:00
Navaron Bracke
ba46c74971
Fix cross imports for all Cupertino tests ( #181634 )
...
This PR fixes all of the Cupertino cross imports, except for the one
that uses `SelectableText`, which needs further discussion.
Some Material specific tests for Cupertino are now under
`tests/material/cupertino`.
Part of https://github.com/flutter/flutter/issues/177415
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-02-13 21:46:48 +00:00
Ilyosbek Ibrokhimov
da086ba743
remove MaterialApp import from raw_radio_test.dart ( #181721 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
The RawRadio widget and its associated tests are part of the Widgets
layer, not the Material layer. By replacing the broad material.dart
import with specific imports (foundation.dart, semantics.dart, and
widgets.dart), we ensure better architectural layering and prevent the
Widgets layer from accidentally depending on Material components.
This is a non-breaking change that purely cleans up imports in a test
file.
Issues Fixed
Part of https://github.com/flutter/flutter/issues/177028
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-02-13 21:41:21 +00:00
engine-flutter-autoroll
1767582ede
Roll Skia from e2991aa99710 to bb69b5b71b4f (37 revisions) ( #182390 )
...
Roll Skia from e2991aa99710 to bb69b5b71b4f (37 revisions)
https://skia.googlesource.com/skia.git/+log/e2991aa99710..bb69b5b71b4f
2026-02-13 bungeman@google.com Fix SkFontMgr_Android fallback
2026-02-13 bungeman@google.com Revert "For script languages space
whitespaces only"
2026-02-13 thomsmit@google.com [graphite] Add contextOptionsPriv to
TestOptions
2026-02-13 kjlubick@google.com Fix typos in Skia codebase
2026-02-13 kjlubick@google.com Remove getEncodedData from SkCodec's
public API
2026-02-13 sergiog@microsoft.com [rust bmp] Fix
SkStreamAdapter::seek_relative for offset 0
2026-02-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 915c2f453b1c to 92cf0901ef59 (1 revision)
2026-02-13 michaelludwig@google.com [graphite] Make texture usage Caps
functions more consistently named
2026-02-13 lehoangquyen@chromium.org Graphite: Report failure messages
for async pipeline compilation
2026-02-13 kjlubick@google.com Migrate gsutil usage to gcloud storage
2026-02-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 1d00645675b0 to 71ead6fdeb53 (16 revisions)
2026-02-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 820c2464a839 to 1f4a9ec2512b (19 revisions)
2026-02-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 63fc10e8f242 to 8ff522b74b01 (7 revisions)
2026-02-13
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2026-02-13
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2026-02-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from a26b8836968d to 915c2f453b1c (3 revisions)
2026-02-13
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2026-02-12 michaelludwig@google.com [graphite] Re-organize Caps function
declarations
2026-02-12 fmalita@google.com Remove unused SkNthSet
2026-02-12 kjlubick@google.com Update comments to show the Vulkan Memory
Allocator is not optional
2026-02-12 borenet@google.com [infra] Make gcs_mirror.go use the storage
API instead of gsutil
2026-02-12 ccameron@chromium.org skhdr::Agtm: Normalize component mixing
2026-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 9a2bbd3ba53f to a26b8836968d (2 revisions)
2026-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from ae81efc63a03 to 1d00645675b0 (12 revisions)
2026-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from adf42c6b0a11 to 63fc10e8f242 (35 revisions)
2026-02-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from e1f2ff49b074 to 820c2464a839 (11 revisions)
2026-02-11 fmalita@google.com Add some SkPath::Iter asserts
2026-02-11
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2026-02-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 43dad2861bf7 to 9a2bbd3ba53f (5 revisions)
2026-02-11 jmbetancourt@google.com Delete legacy graphite logging
priority
2026-02-11 bungeman@google.com Revert "Fix public headers that include
from "src/...""
2026-02-11 jmbetancourt@google.com Change SkDebugf calls in Android
buffer code to SK_LOG
2026-02-11 mike@reedtribe.org Fix public headers that include from
"src/..."
2026-02-11 bungeman@google.com Remove SK_SUPPORT_UNSPANNED_APIS
2026-02-11 jmbetancourt@google.com Reland "redirect SKGPU_LOG macros to
SKIA_LOG"
2026-02-11 fmalita@google.com [bazel macos] Add more indirect frameworks
to FRAMEWORK_GLOB
2026-02-11 jlavrova@google.com For script languages space whitespaces
only
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bungeman@google.com ,jimgraham@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
...
2026-02-13 21:39:03 +00:00
gaaclarke
41e819290c
Turns on most of fragment_shader_test.dart for opengles ( #182229 )
...
fixes https://github.com/flutter/flutter/issues/182106
Changes:
- started running the tests against opengles 3, which matches the
version of the test shaders
- fixed binging uniforms on opengles so it's based on it's type, not
it's size (since vec4 and mat2 have the same size for instance)
- fixed for builtin shaders
- fixed for runtime shaders
- expands our opengles mocking to include more uniform setters
- skips the handful of tests that still don't work
Now builtin shader headers look something like this. You can see this
information didn't exist and was not derivable based on the existing
information in all cases:
```c++
ShaderMetadata Shader::kMetadataFrameInfo = {
"FrameInfo", // name
std::vector<ShaderStructMemberMetadata> {
ShaderStructMemberMetadata {
/*type=*/ShaderType::kFloat,
/*name=*/"mvp",
/*offset=*/0,
/*size=*/64,
/*byte_length=*/64,
/*array_elements=*/std::nullopt,
/*float_type=*/ShaderFloatType::kMat4, // <-- new
},
```
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-02-13 21:38:13 +00:00
Camille Simon
ff0d94ff06
Update CHANGELOG for 3.41.1 release ( #182393 )
...
As the title says :)
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-02-13 21:33:24 +00:00
Hameed Habeeblahi Gbolahan
ba9a650bef
Remove Material dependency from semantics_keep_alive_offstage_test.dart ( #182211 )
...
Remove Material dependency from semantics_keep_alive_offstage_test.dart
Replace `MaterialApp`/`Scaffold` with `TestWidgetsApp` and
`Colors.red`/`Colors.blue` with simple color constants.
Part of #177414
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-02-13 19:35:53 +00:00
Victoria Ashworth
8fdd708068
Update iOS/macOS plugin template to add dependency on FlutterFramework ( #181416 )
...
Add the "FlutterFramework" swift package as a dependency to the iOS and
macOS create template.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-02-13 19:25:19 +00:00