DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
85,557 Commits 882 Branches 1,069 Tags
Commit Graph

85557 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Reid Baker
da45f52b41
See if java 21 presubmits will pass 2025-08-18 14:47:20 -04:00
Matan Lurey
2265d94c6b
Remove embedded_android_views (on-device) tests, same as emulator test (#173814) 
These tests are identical to the `Linux_android_emu` test that runs on
presubmit:


9583f282a5/.ci.yaml (L408-L416)

These tests do not report benchmarks or any other statistics that would
benefit from a real (on-device) test.
 2025-08-18 16:33:30 +00:00
engine-flutter-autoroll
78df185e5a
Roll Skia from 3a17208059ec to 07d71ea4d056 (4 revisions) (#173942) 
https://skia.googlesource.com/skia.git/+log/3a17208059ec..07d71ea4d056

2025-08-18
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from b639f97ad620 to 2c53c1b75e06 (5 revisions)
2025-08-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
shaders-base from 5e22a60082ec to 0b85ebb8cd88
2025-08-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
debugger-app-base from 986ca4affc81 to 6943b399ac36

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC chinmaygarde@google.com,fmalita@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-18 15:52:08 +00:00
engine-flutter-autoroll
660c234bb0
Roll Skia from 978726c1e725 to 3a17208059ec (2 revisions) (#173939) 
https://skia.googlesource.com/skia.git/+log/978726c1e725..3a17208059ec

2025-08-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
skottie-base from 951c83390400 to d3e0a508e29c
2025-08-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
jsfiddle-base from 74f9e2cd8bc1 to c4343b58423e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC chinmaygarde@google.com,fmalita@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-18 06:33:39 +00:00
engine-flutter-autoroll
a8faac8d42
Roll Fuchsia Linux SDK from sLmXksm1vZl2VEeA7... to n0EnLlotF2wczlOq_... (#173936) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC chinmaygarde@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-18 03:40:38 +00:00
Huy
b1551a19e4
Enhance FilledButton and Theme Data's documentation to clarify platform-specific visual density behavior (#173695) 
- Fix https://github.com/flutter/flutter/issues/155768
- Description: The issue is not a bug but WAI, it's due to visual
density not being the same on each platform by default (see my full
explanation at
[here](https://github.com/flutter/flutter/issues/155768#issuecomment-3178302255)),
see:


f22787193b/packages/flutter/lib/src/material/theme_data.dart (L3250-L3255)

 - This is LOCs where visual density impacts the padding:


a04fb324be/packages/flutter/lib/src/material/button_style_button.dart (L501-L505)



In this PR:
- Add `Visual density effects` section to FilledButton documentation to
avoid confusion for users
- Improve the documentation for
`VisualDensity.defaultDensityForPlatform` by including detailed
information about the specific density for each platform.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Signed-off-by: huycozy <huy@nevercode.io>
 2025-08-18 03:19:33 +00:00
engine-flutter-autoroll
51eb659d63
Roll Skia from 88e8c099a086 to 978726c1e725 (3 revisions) (#173935) 
https://skia.googlesource.com/skia.git/+log/88e8c099a086..978726c1e725

2025-08-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 0ae104d9374d to eb3190110845 (1 revision)
2025-08-17 mike@reedtribe.org Reapply "Factor out common pathiter"
2025-08-17 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com
Update SKP version

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC chinmaygarde@google.com,fmalita@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-18 03:13:44 +00:00
engine-flutter-autoroll
59ecc77ab0
Roll Dart SDK from a874859559e6 to 502455ee300b (1 revision) (#173934) 
https://dart.googlesource.com/sdk.git/+log/a874859559e6..502455ee300b

2025-08-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-107.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert
to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-18 02:02:18 +00:00
engine-flutter-autoroll
b3fb4c786d
Roll Dart SDK from 67ca79475db6 to a874859559e6 (2 revisions) (#173922) 
https://dart.googlesource.com/sdk.git/+log/67ca79475db6..a874859559e6

2025-08-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-106.0.dev
2025-08-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-105.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert
to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-17 10:02:27 +00:00
engine-flutter-autoroll
bfede21c2e
Roll Skia from a30d857718ad to 88e8c099a086 (1 revision) (#173919) 
https://skia.googlesource.com/skia.git/+log/a30d857718ad..88e8c099a086

2025-08-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 57d74122fab7 to 0ae104d9374d (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC chinmaygarde@google.com,fmalita@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-17 06:15:31 +00:00
engine-flutter-autoroll
76ce984d9b
Roll Fuchsia Linux SDK from H1kVA85LyQsK8EDp2... to sLmXksm1vZl2VEeA7... (#173913) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC chinmaygarde@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-17 01:19:55 +00:00
engine-flutter-autoroll
8b04c41e97
Roll Skia from d445371afee5 to a30d857718ad (2 revisions) (#173910) 
https://skia.googlesource.com/skia.git/+log/d445371afee5..a30d857718ad

2025-08-16 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
ANGLE from 63d8f74cdf9c to 806c80ece32b (6 revisions)
2025-08-16 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
Dawn from 8f680a2a9cb9 to b639f97ad620 (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-16 22:41:24 +00:00
engine-flutter-autoroll
880572e157
Roll Skia from 16dbd908dcab to d445371afee5 (1 revision) (#173907) 
https://skia.googlesource.com/skia.git/+log/16dbd908dcab..d445371afee5

2025-08-16 robertphillips@google.com Revert "Factor out common pathiter"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-16 18:56:38 +00:00
Alex Talebi
0a2906b81d
Improve SweepGradient angle and TileMode documentation (#172406) 
# Improve SweepGradient and TileMode Documentation

## Description
This PR enhances the documentation for `SweepGradient` and `TileMode` to
provide clearer guidance on how angles are measured and how tile modes
affect sweep gradient rendering.

### Changes
1. **SweepGradient Documentation**:
   - Clarified angle measurement in radians from the positive x-axis
   - Documented angle normalization behavior for values outside [0, 2π]
- Added detailed explanations of how each `TileMode` affects rendering
outside the angular sector

2. **Gradient.sweep Constructor**:
   - Improved parameter documentation
- Added a practical example showing how to create a 90-degree sweep
gradient
   - Clarified the relationship between color stops and angles

3. **TileMode Documentation**:
   - Added sweep gradient-specific behavior to each `TileMode` variant
- Clarified how each mode (clamp, repeated, mirror, decal) affects
rendering outside the angular sector
   - Improved overall documentation structure for gradient edge behavior

## Related Issues
Fixes #166206

## Testing
- Verified documentation changes by reviewing the generated API docs
- Ensured all examples compile and render as expected

## Breaking Changes
None - this is purely a documentation improvement.

## Additional Notes
The changes make it much clearer how `startAngle` and `endAngle`
interact with different `TileMode` values, which was a source of
confusion in the original issue.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.


<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
 2025-08-16 14:08:37 +00:00
engine-flutter-autoroll
36e1db8f37
Roll Skia from 1e148cada9d4 to 16dbd908dcab (1 revision) (#173901) 
https://skia.googlesource.com/skia.git/+log/1e148cada9d4..16dbd908dcab

2025-08-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from e04b90257b5a to 57d74122fab7 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-16 12:48:17 +00:00
engine-flutter-autoroll
5c8c174f3b
Roll Skia from 91ad1f21ca61 to 1e148cada9d4 (3 revisions) (#173890) 
https://skia.googlesource.com/skia.git/+log/91ad1f21ca61..1e148cada9d4

2025-08-15 bungeman@google.com [pdf] Unpremul after interpolating
unpremul
2025-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 2d05384af7d2 to e04b90257b5a (9 revisions)
2025-08-15 mike@reedtribe.org Last users of (unneeded) RawIter

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-16 02:03:40 +00:00
engine-flutter-autoroll
515e753c6e
Roll Dart SDK from 9277d6303da5 to 67ca79475db6 (1 revision) (#173886) 
https://dart.googlesource.com/sdk.git/+log/9277d6303da5..67ca79475db6

2025-08-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-104.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert
to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-16 01:03:27 +00:00
gaaclarke
4abea340e1
Blocks exynos9820 chip from vulkan (#173807) 
fixes https://github.com/flutter/flutter/issues/171992

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-08-15 23:42:17 +00:00
hellohuanlin
eeb3a40cbe
Revert "[ios][tools]do not log "bonjour not found" at all (unless verbose)" (#173879) 
Reverts flutter/flutter#173569

Sorry I have to revert this one as it didn't work. 

# Why didn't work

From the comment, it looks like `echoError` is only used for verbose
mode, and `streamOutput` is used for non-verbose mode (I am still
looking into how this is setup)


e4f27cd097/packages/flutter_tools/bin/xcode_backend.dart (L151)

# How to fix

## Possible Fix 1

I tested this works, by changing this line: 


https://github.com/flutter/flutter/blob/master/packages/flutter_tools/bin/xcode_backend.dart#L159

into this: 

```
if (!verbose && exitCode == 0 && !skipErrorLog)
```

## Possible fix 2: 

Surprisingly this also works: 
```
if (!verbose && exitCode == 0) {
  streamOutput(errorOutput.string().replaceAll('error', '');
}
```

Although we made sure `errorOutput` doesn't start with `error:`, there's
an `error:` in the middle of the string.

Possibly because of this code in `mac.dart`: 

e4f27cd097/packages/flutter_tools/lib/src/ios/mac.dart (L431-L433)

# Why we missed it? 

I tested my initial code code and assumed updated code would work,
because I incorrectly thought `echoError` was the one triggered the
output in non-verbose mode. I should have verified it.
 2025-08-15 23:30:08 +00:00
Ben Konyi
37848d12a8
Roll package:analyzer forward to 8.1.1 (#173867) 2025-08-15 22:56:22 +00:00
engine-flutter-autoroll
f04e092b32
Roll Skia from 2f66be8a593a to 91ad1f21ca61 (3 revisions) (#173877) 
https://skia.googlesource.com/skia.git/+log/2f66be8a593a..91ad1f21ca61

2025-08-15 mike@reedtribe.org Factor out common pathiter
2025-08-15 thomsmit@google.com [graphite] Lift floatStorageManager to
recorder
2025-08-15
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-15 22:41:51 +00:00
Hannah Jin
35375e43fb
[a11y] : set isFocused will update isFocusable to true (#170935) 
the isFocused and isFocusable flags should be more consistent,

this is also to prepare for
https://github.com/flutter/flutter/pull/170696 ,


So all EditableText and TextField widgets will have isFocusable flag set
to true now. (because they set isFocused).



## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
 2025-08-15 22:41:49 +00:00
Justin McCandless
2c031ed023
Reland predictive back route transitions by default (#173860) 
Relands https://github.com/flutter/flutter/pull/165832 by reverting
flutter/flutter#173809.
 2025-08-15 22:40:14 +00:00
engine-flutter-autoroll
1ae899c546
Roll Fuchsia Linux SDK from zWRpLglb48zC1vZLv... to H1kVA85LyQsK8EDp2... (#173874) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC chinmaygarde@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-15 21:38:22 +00:00
lauraywu
e4f27cd097
Add onHover callback support for TableRowInkWell (#173373) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

- Add `onHover` parameter to `TableRowInkWell`
- Add corresponding tests

Issue: https://github.com/flutter/flutter/issues/173370

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-08-15 20:41:21 +00:00
engine-flutter-autoroll
655633709a
Roll Skia from 5654ac32ede0 to 2f66be8a593a (6 revisions) (#173866) 
https://skia.googlesource.com/skia.git/+log/5654ac32ede0..2f66be8a593a

2025-08-15 syoussefi@google.com [vulkan] Re-enable use of
VK_EXT_graphics_pipeline_library
2025-08-15 michaelludwig@google.com Add output colorspace parameter to
SkShader::makeWithWorkingColorSpace
2025-08-15 michaelludwig@google.com [graphite] PatchWriter handles caps
directly
2025-08-15 nicolettep@google.com Reland^2 "[graphite] Add
AHARDWAREBUFFER_FORMAT_B8G8R8A8_UNORM support"
2025-08-15 danieldilan@google.com Add invalid ICC profile test for rust
png
2025-08-15 danieldilan@google.com Add default case for color encode

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-15 19:41:29 +00:00
engine-flutter-autoroll
67f3758d07
Roll Dart SDK from cc008dc8e7aa to 9277d6303da5 (2 revisions) (#173864) 
https://dart.googlesource.com/sdk.git/+log/cc008dc8e7aa..9277d6303da5

2025-08-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-103.0.dev
2025-08-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-102.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert
to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-15 19:37:34 +00:00
auto-submit[bot]
8bd06c09be
Reverts "Implements the Android native stretch effect as a fragment shader (Impeller-only). (#169293)" (#173865) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#169293
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: matanlurey
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Does not work on Metal (iOS/macOS):

```
The following _Exception was thrown running a test:
Exception: Asset 'shaders/stretch_effect.frag' does not contain appropriate runtime stage data for current backend (Metal).
```
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: MTtankkeo
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {dkwingsmt, justinmc, chunhtai}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
> Sorry, Closing PR #169196 and reopening this in a new PR for clarity
and a cleaner commit history.

Fixes #82906

In the existing Flutter implementation, the Android stretch overscroll
effect is achieved using Transform. However, this approach does not
evenly stretch the screen as it does in the native Android environment.
Therefore, in the Impeller environment, add or modify files to implement
the effect using a fragment shader identical to the one used in native
Android.

> [!NOTE]
> - The addition of a separate test file for StretchOverscrollEffect was
not included because it would likely duplicate coverage already provided
by the changes made in overscroll_stretch_indicator_test.dart within
this PR.
>> However, since determining whether stretching occurred by referencing
global coordinates is currently considered impossible with the new
Fragment Shader approach, the code was modified to partially exclude the
relevant test logic in the Impeller.
>>
>> For reference, in the page_view_test.dart test, there was an issue
with referencing the child Transform widget, but because the
StretchOverscrollEffect widget is defined instead of the Transform
widget in the Impeller environment, the code logic was adjusted
accordingly.
> 
> - Golden image tests were updated as the visual effect changes.

## Reference Source
-
https://cs.android.com/android/platform/superproject/main/+/main:frameworks/base/libs/hwui/effects/StretchEffect.cpp

## `Old` Skia (Using Transform)

https://github.com/user-attachments/assets/22d8ff96-d875-4722-bf6f-f0ad15b9077d

## `New` Impeller (Using fragment shader)

https://github.com/user-attachments/assets/73b6ef18-06b2-42ea-9793-c391ec2ce282

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-08-15 17:51:20 +00:00
Matan Lurey
e0c1c49c28
Re-add Linux_android_emu * tests that had KVM issues, now resolved (#173812) 
Underlying issue was fixed in
https://github.com/flutter/flutter/issues/170529, but it was manually
marked `bringup`.
 2025-08-15 17:39:19 +00:00
engine-flutter-autoroll
52af7a5040
Roll Packages from 09533b7d5d66 to 5c52c5545f54 (6 revisions) (#173854) 
09533b7d5d...5c52c5545f

2025-08-15 stuartmorgan@google.com [video_player] Move Android buffer
updates to Dart (flutter/packages#9771)
2025-08-15 sfprhythnn@gmail.com [webview_flutter] Add support for
payment requests on Android (flutter/packages#9679)
2025-08-15 jason-simmons@users.noreply.github.com
[vector_graphics_compiler] Set the m4_10 (Z scale) value to 1 when
constructing an AffineMatrix from an SVG matrix (flutter/packages#9813)
2025-08-15 magder@google.com [url_launcher_ios] Fix test button text to
work on iOS 26 (flutter/packages#9766)
2025-08-15 stuartmorgan@google.com [video_player] Simplify native iOS
code (flutter/packages#9800)
2025-08-14 stuartmorgan@google.com [image_picker] Add the ability to
pick multiple videos - platform_interface (flutter/packages#9804)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-15 16:48:08 +00:00
engine-flutter-autoroll
da5c047a13
Roll Skia from 46ec77ae3954 to 5654ac32ede0 (1 revision) (#173848) 
https://skia.googlesource.com/skia.git/+log/46ec77ae3954..5654ac32ede0

2025-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 07db58fa4a14 to 2d05384af7d2 (10 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-15 15:08:09 +00:00
engine-flutter-autoroll
3bf280c86f
Roll Skia from 162f47d6b6bd to 46ec77ae3954 (2 revisions) (#173833) 
https://skia.googlesource.com/skia.git/+log/162f47d6b6bd..46ec77ae3954

2025-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 899f3505748e to 63d8f74cdf9c (5 revisions)
2025-08-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from e07d4f333e72 to 8f680a2a9cb9 (9 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-15 09:05:34 +00:00
engine-flutter-autoroll
e076dd4e02
Roll Dart SDK from c7faab270f27 to cc008dc8e7aa (2 revisions) (#173826) 
https://dart.googlesource.com/sdk.git/+log/c7faab270f27..cc008dc8e7aa

2025-08-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-101.0.dev
2025-08-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-100.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert
to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-15 05:25:44 +00:00
engine-flutter-autoroll
eb830615a4
Roll Skia from ad5d04000101 to 162f47d6b6bd (5 revisions) (#173822) 
https://skia.googlesource.com/skia.git/+log/ad5d04000101..162f47d6b6bd

2025-08-15
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-14 fmalita@google.com [rustypng] Discard profiles with invalid
gamma
2025-08-14 bungeman@google.com Update SkFont size documentation
2025-08-14
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-14
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-15 03:55:08 +00:00
Jason Simmons
bf4cf11a75
Update the RBE configuration for the recent Clang update (#173803) 
This version of the reclient_cfgs CIPD package references Clang version
21, which matches the Clang roll at
https://github.com/flutter/flutter/pull/173429
 2025-08-15 00:53:12 +00:00
Matan Lurey
2d2070c47f
Stop writing legacy FLUTTER_ROOT/version file (by default?) (#172793) 
Towards https://github.com/flutter/flutter/issues/171900.

I'll make a breaking change announcement before landing this PR.

We can keep the flag for a stable release (allow folks to write `flutter
config --no-enable-omit-legacy-version-file` if they still need the
file), or we can decide it's not worth it and just rely on the breaking
change announcement.
 2025-08-15 00:51:08 +00:00
Matan Lurey
e4663f2f1b
Remove luci_flags.parallel_download_builds and friends (#173799) 
These default to `true` and were removed in
https://flutter-review.googlesource.com/c/recipes/+/68841.
 2025-08-15 00:47:36 +00:00
auto-submit[bot]
0e57a627f5
Reverts "Predictive back route transitions by default (#165832)" (#173809) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#165832
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: matanlurey
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Breaks `Linux_pixel_7pro
embedded_android_views_integration_test`:

-
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20embedded_android_views_integration_test/8918/overview
-
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20embedded_android_views_integration_test/8917/overview

```txt
[2025-08-14 16:01:17.600761] [STDOUT] stdout: [   +1 ms]   Expecte
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: justinmc
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {QuncCccccc}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
This PR turns on predictive back route transitions by default on supported Android devices.

With https://github.com/flutter/flutter/pull/154718, the default (PredictiveBackPageTransitionsBuilder) is the [shared element transition](https://developer.android.com/design/ui/mobile/guides/patterns/predictive-back#shared-element-transition). The [full screen transition](https://developer.android.com/design/ui/mobile/guides/patterns/predictive-back#full-screen-surfaces) is also available by using PredictiveBackFullScreenPageTransitionsBuilder.

Original PR: https://github.com/flutter/flutter/pull/146788

Depends on: https://github.com/flutter/flutter/pull/154718

When this lands in stable, the docs should be updated: https://docs.flutter.dev/platform-integration/android/predictive-back
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-08-14 23:38:48 +00:00
engine-flutter-autoroll
9583f282a5
Roll Skia from dca5f05fee87 to ad5d04000101 (8 revisions) (#173798) 
https://skia.googlesource.com/skia.git/+log/dca5f05fee87..ad5d04000101

2025-08-14 alecmouri@google.com Write correct sBIT for 10-bit BGRX
2025-08-14
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-14 nicolettep@google.com [graphite] Add spvtools_val dependency
2025-08-14
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 1d9ad72b24bd to 07db58fa4a14 (2 revisions)
2025-08-14
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-08-14 robertphillips@google.com Rehabilitate some Win11 jobs
2025-08-14 robertphillips@google.com Rehabilitate Mac14/ANGLE job

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
chinmaygarde@google.com,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-14 22:53:01 +00:00
Mouad Debbar
62904ba72a
[web] Cleanup usages of deprecated routeUpdated message (#173782) 
This is a follow up to https://github.com/flutter/flutter/pull/173652

Closes https://github.com/flutter/flutter/issues/50836
 2025-08-14 22:51:28 +00:00
Ahmed Mohamed Sameh
667da94d3c
Make sure that DataTable, DataColumn, DataRow, and DataCell don't crash in 0x0 environment (#173515) 
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the DataTable,
DataColumn, DataRow, and DataCell UI controls.
 2025-08-14 21:19:01 +00:00
Ahmed Mohamed Sameh
87bac26665
Make sure that a TableRowInkWell doesn't crash in 0x0 environment (#173627) 
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the TableRowInkWell
UI control.
 2025-08-14 21:19:01 +00:00
Ahmed Mohamed Sameh
3c1e258864
Make sure that a DatePickerDialog doesn't crash in 0x0 environment (#173677) 
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the DatePickerDialog
UI control.
 2025-08-14 21:17:12 +00:00
Robert Ancell
231d3466cc
Return result of setting OpenGL contexts back to Flutter (#173757) 
Also check when using them internally that they have worked.
 2025-08-14 21:00:50 +00:00
Matan Lurey
a8ae5e07fd
Read bin/cache/flutter.version.json instead of version for flutter_gallery (#173797) 
Towards https://github.com/flutter/flutter/issues/171900.
 2025-08-14 20:52:26 +00:00
Justin McCandless
d1e2019a94
Predictive back route transitions by default (#165832) 
This PR turns on predictive back route transitions by default on
supported Android devices.

With https://github.com/flutter/flutter/pull/154718, the default
(PredictiveBackPageTransitionsBuilder) is the [shared element
transition](https://developer.android.com/design/ui/mobile/guides/patterns/predictive-back#shared-element-transition).
The [full screen
transition](https://developer.android.com/design/ui/mobile/guides/patterns/predictive-back#full-screen-surfaces)
is also available by using
PredictiveBackFullScreenPageTransitionsBuilder.

Original PR: https://github.com/flutter/flutter/pull/146788

Depends on: https://github.com/flutter/flutter/pull/154718

When this lands in stable, the docs should be updated:
https://docs.flutter.dev/platform-integration/android/predictive-back
 2025-08-14 20:39:12 +00:00
Houssem Eddine Fadhli
8914c91428
feat: add onLongPressUp callback to InkWell widget (#173221) 
This PR introduces a new optional callback, onLongPressUp, to the
InkWell widget.
It allows developers to respond specifically to the moment when a long
press gesture is released, which previously was not directly exposed.

**Before**
There was no way to distinguish between the long press being held and
the moment it ended.

**After**
InkWell now accepts an onLongPressUp callback, which fires when the user
lifts their finger after a long press gesture.
This change enhances gesture handling granularity for widgets that
require different behaviors for long press hold and release.


**Related Issue**
#173390

**Tests**
- Added a new test to ink_well_test.dart verifying that onLongPressUp is
correctly triggered after a long press is released.

**Checklist**
- I read the [Contributor Guide] and followed the process outlined there
for submitting PRs.
- I read the [Tree Hygiene] wiki page.
- I followed the [Flutter Style Guide].
- I signed the [CLA].
- I updated/added relevant documentation (/// doc comments).
- I added new tests to check the change I am making.
- All existing and new tests are passing.

---------

Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Co-authored-by: Reid Baker <1063596+reidbaker@users.noreply.github.com>
Co-authored-by: Jon Ihlas <jon.i@hotmail.fr>
Co-authored-by: Matthew Kosarek <matt.kosarek@canonical.com>
Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com>
Co-authored-by: Micael Cid <micaelcid10@gmail.com>
Co-authored-by: Alexander Aprelev <aam@google.com>
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
 2025-08-14 20:31:02 +00:00
engine-flutter-autoroll
d8186f7045
Roll Dart SDK from 214a7f829913 to c7faab270f27 (1 revision) (#173792) 
https://dart.googlesource.com/sdk.git/+log/214a7f829913..c7faab270f27

2025-08-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-99.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert
to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-14 20:21:00 +00:00
LongCatIsLooong
2fcda04790
Add error handling for Element lifecycle user callbacks (#173148) 
This is for #172289, but since this fix is speculative so I'll wait for
the confirmation from the original reporters before closing the issue.

As a bonus this fixes #65655

The framework Element rebuild logic relies heavily on
`Element._lifecycleState` being correct. When a user-supplied lifecycle
callback (e.g., `State.deactivate`) fails the framework currently only
ensures that every `Element` in the tree has the right lifecycle state,
so an out-of-tree `Element` that is supposed to be disposed may still
have an `active` state and continue being rebuilt by the BuildScope
(because it's in the dirty list). See the comments in #172289

Also related:
#100777
Internal:
b/425298525 b/431537277
b/300829376 b/415724119 b/283614822

# TODO (in a different PR)
The original issue could also be caused by incorrect
`Element.updateChild` calls. If an `Element` subclass calls
`Element.updateChild` to add child but forgets to update its child list
accordingly (such that `visitChildren` misses that child), you'll get a
child Element that thinks it's a child of the parent but the parent
doesn't recognize the child so won't take that child into account during
reparenting or unmounting. This is a programmer error that we should try
to catch in the framework.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-08-14 19:53:20 +00:00
engine-flutter-autoroll
ad7ee1cf04
Roll Fuchsia Linux SDK from I1TfNmsqTp7t3rO8e... to zWRpLglb48zC1vZLv... (#173784) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC chinmaygarde@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-08-14 18:40:26 +00:00