43424 Commits

Author SHA1 Message Date
Qun Cheng
e14ddbf23b Fix nit 2024-11-25 14:12:39 -08:00
Qun Cheng
6ec4b843cf Override transitionDuration and reverseTransitionDuration in bottom sheet 2024-11-25 14:12:39 -08:00
Qun Cheng
102e4d00d0 Update transition and reverseTransition in TransitionRoute 2024-11-25 14:12:39 -08:00
Qun Cheng
b308dbd32a Revert default value change 2024-11-25 14:12:39 -08:00
Qun Cheng
d83fa696c0 Revert partial unit tests in page_transitions_theme_test.dart 2024-11-25 14:12:39 -08:00
Qun Cheng
a9098e587a Revert unit tests 2024-11-25 14:12:39 -08:00
Qun Cheng
830a551e02 Revert widget_tester_test.dart file 2024-11-25 14:12:39 -08:00
Qun Cheng
2ee3831d64 Revert example tests 2024-11-25 14:12:39 -08:00
Qun Cheng
5de0452162 Add api doc for new properties 2024-11-25 14:12:39 -08:00
Qun Cheng
2881c34981 Add transitionDuration and reverseTransitionDuration for PageTransitionBuilder 2024-11-25 14:12:39 -08:00
Qun Cheng
b7bc239ff5 Add example explanation 2024-11-25 14:12:39 -08:00
Qun Cheng
904779f820 Address PR comment 2024-11-25 14:12:39 -08:00
Qun Cheng
a21b6e0ba7 Update failed test 2024-11-25 14:12:39 -08:00
Qun Cheng
bc9150d33e Update failed tests 2024-11-25 14:12:38 -08:00
Qun Cheng
c91c18ebc5 Update unit tests 2024-11-25 14:12:38 -08:00
Qun Cheng
f74318f11a Update tests 2024-11-25 14:12:38 -08:00
Qun Cheng
00b1616c33 Fix failed test 2024-11-25 14:12:38 -08:00
Qun Cheng
2910bae66a add test for example 2024-11-25 14:12:38 -08:00
Qun Cheng
2d31a90f2e Create an example for FadeForwardsTransitionsBuilder 2024-11-25 14:12:38 -08:00
Qun Cheng
146d3a5a4c Update code comment 2024-11-25 14:12:38 -08:00
Qun Cheng
3d3a9df550 Fix linux analysis 2024-11-25 14:12:38 -08:00
Qun Cheng
b3634dced0 Add a unit test 2024-11-25 14:12:38 -08:00
Qun Cheng
420bc5f822 Add new tests and update existing tests 2024-11-25 14:12:38 -08:00
Qun Cheng
26939b9714 Update api doc 2024-11-25 14:12:38 -08:00
Qun Cheng
440e4c2692 Update test message 2024-11-25 14:12:38 -08:00
Qun Cheng
2cd2034fe9 Update 2024-11-25 14:12:38 -08:00
Qun Cheng
fa72d77b9d Update unit tests 2024-11-25 14:12:38 -08:00
Qun Cheng
2b200f2143 Update code comments 2024-11-25 14:12:38 -08:00
Qun Cheng
c5ef5f7fcd Update unit test 2024-11-25 14:12:38 -08:00
Qun Cheng
235d6cdc51 update unit test 2024-11-25 14:12:38 -08:00
Qun Cheng
9202719bc6 Update code comments 2024-11-25 14:12:38 -08:00
Qun Cheng
65acddb5c9 Update docs 2024-11-25 14:12:38 -08:00
Qun Cheng
cb2572aae4 Update default animation duration 2024-11-25 14:12:38 -08:00
Qun Cheng
a908be2941 Fix typo 2024-11-25 14:12:38 -08:00
Qun Cheng
848fbc132a Fix typo 2024-11-25 14:12:37 -08:00
Qun Cheng
77a0e3ebeb Create Android U page transition 2024-11-25 14:12:37 -08:00
chunhtai
85632156c5
Reland "Set stable color for semantics debugger (#157884)" (#159355)
This reverts commit 07690a69b0067f8a8471470f7314a3294591033d.

previous pr was merged when tree is close by mistake, and was revert out
of precaution. There is no change in this reland.


## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-11-25 21:37:10 +00:00
engine-flutter-autoroll
7be361cd6a
Roll Packages from 920321356e45 to 46aeb2b29d60 (3 revisions) (#159420)
920321356e...46aeb2b29d

2024-11-22 reidbaker@google.com Update avd_cipd_version
(flutter/packages#8135)
2024-11-22 10687576+bparrishMines@users.noreply.github.com
[interactive_media_ads] Adds internal wrapper for Android native
`CompanionAdSlot` and `CompanionAdSlot.ClickListener`
(flutter/packages#8131)
2024-11-22 engine-flutter-autoroll@skia.org Roll Flutter from
93d772c5cdd8 to 793569f621f7 (5 revisions) (flutter/packages#8152)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-25 21:25:03 +00:00
chunhtai
1a2d6a30bc
Framework sends a11y message when enabling semantics (#159163)
fixes https://github.com/flutter/flutter/issues/158399

engine ios https://github.com/flutter/engine/pull/56691

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-11-25 21:21:04 +00:00
engine-flutter-autoroll
756cf306d6
Roll Flutter Engine from ce1eb371eafa to fe45a6608651 (4 revisions) (#159435)
ce1eb371ea...fe45a66086

2024-11-25 34871572+gmackall@users.noreply.github.com Bump versions of
agp and robolectric, and configure to use SDK 35 (flutter/engine#56732)
2024-11-25 jiahaog@users.noreply.github.com Add missing import for
malloc (flutter/engine#56781)
2024-11-25 skia-flutter-autoroll@skia.org Roll Skia from 7588789d8fc6 to
12c8bd6ac1d9 (1 revision) (flutter/engine#56786)
2024-11-25 skia-flutter-autoroll@skia.org Roll Skia from 01a3a55f1d54 to
7588789d8fc6 (2 revisions) (flutter/engine#56784)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-25 21:14:43 +00:00
Gray Mackall
70e31b48bf
Bump AGP/Gradle/Kotlin warn versions (#158839)
Bumps the versions up a bit, so we can keep people moving forward.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Gray Mackall <mackall@google.com>
2024-11-25 21:13:24 +00:00
auto-submit[bot]
3d896d8743
Reverts "Update image_filter_test and color_filter_test.dart for Material 3 (#158985)" (#159437)
<!-- start_original_pr_link -->
Reverts: flutter/flutter#158985
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: QuncCccccc
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: to unblock tree
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: TahaTesser
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {QuncCccccc}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Updated unit tests for `ColorFiltered` and `ImageFiltered` to have M2
and M3 versions.

More info in #139076

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2024-11-25 20:47:13 +00:00
LongCatIsLooong
7b9f853cc7
Fix a failing test missed in #159108 (#159407)
Missed this test in https://github.com/flutter/flutter/pull/159108

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-11-25 19:20:31 +00:00
userFortyTwo
d527f6ee10
Fix typo in gen_l10n_types.dart (#159035)
This pull request fixes a typo.
2024-11-25 15:05:03 +00:00
Ben Konyi
b5331b3e1b
[ tool ] Fix expression evaluation not handling errors correctly (#159151)
Also starts DDS for integration test devices.

Fixes https://github.com/flutter/flutter/issues/157922
2024-11-25 15:04:09 +00:00
Taha Tesser
cca41301f0
Update image_filter_test and color_filter_test.dart for Material 3 (#158985)
Updated unit tests for `ColorFiltered` and `ImageFiltered` to have M2
and M3 versions.

More info in #139076

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
2024-11-25 15:01:03 +00:00
Bruno Leroux
8509d78734
Fix Date picker overlay colors aren't applied on selected state (#159203)
## Description

This PR fixes the DatePicker overlay colors for the selected days.
Before this PR, overlays were obscured by the selected day backgound.
This fix simply replaces a DecoratedBox with an Ink to make the overlays
visible.
Combined with https://github.com/flutter/flutter/pull/159072 which fixes
InkWell overlay color resolution related to the selected state, this PR
fixes [Date picker overlay colors aren't applied on
MaterialState.selected
state](https://github.com/flutter/flutter/issues/130586).

Before, no overlay visible for the selected day when hovered, focused,
or pressed:


https://github.com/user-attachments/assets/944d5035-68b2-40da-b606-3e8795229767

After, overlay is visible for the selected day when hovered, focused, or
pressed (color change is slight as defined with M3 defaults):


https://github.com/user-attachments/assets/2627955b-f45a-465f-8eb0-21955ccd8c3e


## Related Issue

Fixes [Date picker overlay colors aren't applied on
MaterialState.selected
state](https://github.com/flutter/flutter/issues/130586).

## Tests

Adds 12 tests.
Updates several existing tests (those tests were looking for a
`DecoratedBox`, make them look for an `Ink`).
2024-11-25 13:09:32 +00:00
engine-flutter-autoroll
a0c3060c68
Roll Flutter Engine from 0ced389c842d to ce1eb371eafa (1 revision) (#159404)
0ced389c84...ce1eb371ea

2024-11-25 jason-simmons@users.noreply.github.com Fix the mapping from
exit response strings to the FlPlatformChannelExitResponse enum
(flutter/engine#56769)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-25 02:34:37 +00:00
engine-flutter-autoroll
9bd2853737
Roll Flutter Engine from 11777dcabe69 to 0ced389c842d (2 revisions) (#159403)
11777dcabe...0ced389c84

2024-11-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
XOyk4KAUqAnkgC2WY... to 9o0fWa2xVhmxV6Mtn... (flutter/engine#56780)
2024-11-24 30870216+gaaclarke@users.noreply.github.com Replaces
Resource's shared_ptr with unique_ptr (flutter/engine#56778)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from XOyk4KAUqAnk to 9o0fWa2xVhmx

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-25 00:06:26 +00:00
engine-flutter-autoroll
d1140638d4
Roll Flutter Engine from 37715e9cdcf8 to 11777dcabe69 (1 revision) (#159401)
37715e9cdc...11777dcabe

2024-11-24 30870216+gaaclarke@users.noreply.github.com Cleaned up
BufferBindingsGLES::BindUniformBuffer (flutter/engine#56777)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-24 21:04:36 +00:00