DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
84,268 Commits 882 Branches 1,069 Tags
Commit Graph

30498 Commits

Author SHA1 Message Date
auto-submit[bot]
88d184dada
Reverts "[Reland] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396) (#168914)" (#169250) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#168914
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: gaaclarke
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting:
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20external_ui_integration_test_ios/16792/overview

The external texture integration test is failing. Running the host app
appeared to work but one of the driver asserts isn't working.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: gaaclarke
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {vashworth}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
## **BREAKING CHANGE**

Adopting Apple's UISceneDelegate protocol shifts the initialization
order of apps. For the common cases we've made sure they will work
without change. The one case that will require a change is any app that
in `-[UIApplicateDelegate didFinishLaunchingWithOptions:]` assumes that
`UIApplicationDelegate.window.rootViewController` is a
`FlutterViewController` instance. This is sometimes done to register
platform channels directly on the `FlutterViewController`. Instead users
should use the `FlutterPluginRegistry` API's to create platform channels
in `-[UIApplicateDelegate didFinishLaunchingWithOptions:]`, like
`FlutterPlugin`s do.

An example can be seen here:
https://github.com/flutter/flutter/pull/168914/files#diff-9f59c5248b58124beca7e290a57646023cda3ca024607092c6c6932606ce16ee

## Changes since revert
Device lab tests have been migrated to using the FlutterPlugin API for
creating platform channels at process launch.

## Description
fixes: https://github.com/flutter/flutter/issues/167267

design doc:

https://docs.google.com/document/d/1ZfcQOs-UKRa9jsFG84-MTFeibZTLKCvPQLxF2eskx44/edit?tab=t.0

relands https://github.com/flutter/flutter/pull/168396

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-05-22 03:32:21 +00:00
engine-flutter-autoroll
3fb1899377
Roll Dart SDK from 56940edd099d to 8f85d89fdc23 (6 revisions) (#169237) 
https://dart.googlesource.com/sdk.git/+log/56940edd099d..8f85d89fdc23

2025-05-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-155.0.dev
2025-05-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-154.0.dev
2025-05-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-153.0.dev
2025-05-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-152.0.dev
2025-05-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-151.0.dev
2025-05-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-150.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert
to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-05-21 22:59:38 +00:00
gaaclarke
6d14eb2129
[Reland] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396) (#168914) 
## **BREAKING CHANGE**

Adopting Apple's UISceneDelegate protocol shifts the initialization
order of apps. For the common cases we've made sure they will work
without change. The one case that will require a change is any app that
in `-[UIApplicateDelegate didFinishLaunchingWithOptions:]` assumes that
`UIApplicationDelegate.window.rootViewController` is a
`FlutterViewController` instance. This is sometimes done to register
platform channels directly on the `FlutterViewController`. Instead users
should use the `FlutterPluginRegistry` API's to create platform channels
in `-[UIApplicateDelegate didFinishLaunchingWithOptions:]`, like
`FlutterPlugin`s do.

An example can be seen here:
https://github.com/flutter/flutter/pull/168914/files#diff-9f59c5248b58124beca7e290a57646023cda3ca024607092c6c6932606ce16ee

## Changes since revert
Device lab tests have been migrated to using the FlutterPlugin API for
creating platform channels at process launch.

## Description
fixes: https://github.com/flutter/flutter/issues/167267

design doc:

https://docs.google.com/document/d/1ZfcQOs-UKRa9jsFG84-MTFeibZTLKCvPQLxF2eskx44/edit?tab=t.0

relands https://github.com/flutter/flutter/pull/168396

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
 2025-05-21 22:01:28 +00:00
Jason Simmons
6390356103
Roll Dart SDK from 7c40eba6bf77 to 56940edd099d (#169135) 2025-05-21 18:31:39 +00:00
Jonah Williams
efc27a570e
[Impeller] disable gl ext render to texture on vivante. (#169153) 
Found code in ANGLE that seems to indicate there are known crashes with
vivnate drivers using gl_ext_render_to_texture. Landing to see if it
fixes https://github.com/flutter/flutter/issues/167850 which we don't
have a device to test for.
 2025-05-21 16:53:08 +00:00
sutes-work
58888f89b7
runtime/dart: fuchsia::io::MODE_TYPE_FILE -> V_TYPE_FILE (#168952) 
fuchsia::io::MODE_TYPE_FILE is deprecated and V_TYPE_FILE is the correct
constant anyway.

<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

An upcoming change to the Fuchsia SDK will remove the
`fuchsia::io::MODE_TYPE_…` constants. This PR changes
`fuchsia::io::MODE_TYPE_FILE` to `V_TYPE_FILE` (which is actually the
correct constant to use in this case anyway). The constant has the same
value.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA]. *n/a: I am a Googler*
- [x] I listed at least one issue that this PR fixes in the description
above. *trivial change*
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-05-21 14:11:09 +00:00
Matan Lurey
35f337ecb4
Skip running Linux fuchsia_test on non-master channel. (#169106) 
We already don't build engine artifacts, so it's a matter of time until
this stopped working.

Towards https://github.com/flutter/flutter/issues/169101.

(Need to CP this into 3.32 and 3.33)
 2025-05-20 00:50:19 +00:00
engine-flutter-autoroll
b98b1e3ad4
Roll Skia from c97451da059f to 13a299964c9f (61 revisions) (#169099) 
Roll Skia from c97451da059f to 13a299964c9f (61 revisions)

https://skia.googlesource.com/skia.git/+log/c97451da059f..13a299964c9f

2025-05-19 thomsmit@google.com [graphite] Add
AccessPattern::kGpuOnlyCopySrc
2025-05-19
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-05-19 borenet@google.com [SkPathBuilder] Add missing docstrings and
tests
2025-05-19 bungeman@google.com Change LinearGradientInfo::fColors to
SkColor4f
2025-05-19 kjlubick@google.com Fix implicit copy constructor in
SkRecorder
2025-05-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 96085ee3c6cc to f70c1194c173 (1 revision)
2025-05-18 robertphillips@google.com [graphite] Enable
AndroidPrecompileTest on Vulkan jobs
2025-05-18 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
ANGLE from db71e8fa7c26 to 5fd79e6a2ce8 (11 revisions)
2025-05-18 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com
Update SKP version
2025-05-16 kjlubick@google.com Fix fontations, icu4x, and vello rust
builds
2025-05-16 bungeman@google.com Roll FreeType from 5d4e649f to 7172bd11
(112 commits)
2025-05-16 borenet@google.com [SkPathBuilder] Add methods needed for
migrating Skia call sites
2025-05-16 danieldilan@google.com Implement drawCoverageMask for Ganesh
2025-05-16 kjlubick@google.com Add initial implementation of
SkRasterContext and SkRasterRecorder
2025-05-16 borenet@google.com [SkPathBuilder] Guard SkPath methods with
out-params behind SK_HIDE_PATH_EDIT_METHODS
2025-05-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from cc02a537e965 to db71e8fa7c26 (18 revisions)
2025-05-16 jsimmons@google.com Fix shift of the blue component in
store_1010102_xr
2025-05-16 jamesgk@google.com [graphite] Guard solid color expression
lifting
2025-05-15 bungeman@google.com Roll Expat from 624da0f5 to 8e49998f
(3866 commits)
2025-05-15 lehoangquyen@google.com GraphiteDawn: support rendering with
smaller MSAA texture.
2025-05-15 michaelludwig@google.com [graphite] Allow identity CS xforms
in runtime effects
2025-05-15 bungeman@google.com Roll HarfBuzz from ca3cd48f to 4e767271
(792 commits)
2025-05-15 jvanverth@google.com [graphite] Fix for Clip key collision
2025-05-15 thomsmit@google.com [graphite] Fix ARM padding perf
regressions.
2025-05-15 nicolettep@google.com [graphite] Update naming to reflect
that VulkanFramebuffers can be cached
2025-05-15 nicolettep@google.com Fix typo in viewer menu
2025-05-15 thomsmit@google.com [graphite] Make DrawBufferManager buffer
sizes a recorder option.
2025-05-15 jamesgk@google.com [graphite] Set interpolation for lifted
expression varyings
2025-05-15 bungeman@google.com Fix
SkAndroidFrameworkUtils::ShaderAsALinearGradient
2025-05-15
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-05-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from e4ec23a0e5f2 to cc02a537e965 (14 revisions)
2025-05-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 930d46d31b5d to 96085ee3c6cc (1 revision)
2025-05-15
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-05-14 robertphillips@google.com [graphite] Address oddity in
PaintParamsKey building
2025-05-14 jamesgk@google.com Ignore tests that read pixels in Protected
configs
2025-05-14 kylechar@google.com Change use_user_defined_labels_in_backend
toggle
2025-05-14 bungeman@google.com [pdf] Respect
kInterpolateColorsInPremul_Flag
2025-05-14 jamesgk@google.com [graphite] Support lifting from runtime
shader children
2025-05-14 bungeman@google.com Change GradientInfo::fColors to SkColor4f
2025-05-14 michaelludwig@google.com [sksl] Skip inline statement limit
for modules
2025-05-14 nicolettep@google.com [graphite] Add noncoherent advanced
blend mode support
2025-05-14 robertphillips@google.com [graphite] Add YCbCr to Precompile
2025-05-14 robertphillips@google.com [graphite][vulkan] Simplify render
pass key
2025-05-14 michaelludwig@google.com [graphite] Simplify LocalMatrix
shader expression w/ and w/o perspective
2025-05-14 jamesgk@google.com Reland "[graphite] Lift solid color shader
expressions"
2025-05-14 kjlubick@google.com Document instantiateWasm in
CanvasKitInitOptions
...
 2025-05-19 23:13:37 +00:00
Littlegnal
77abe867e8
Clean up redundant new line in the GPUSurfaceGLSkia constructor initializer list (#169031) 
Clean up redundant new line in the `GPUSurfaceGLSkia` constructor
initializer list

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Co-authored-by: Jonah Williams <jonahwilliams@google.com>
 2025-05-19 21:23:32 +00:00
Littlegnal
80f5de5da9
Fix typo in gpu_surface_gl_impeller.cc (#168395) 
This PR fixes a typo in `gpu_surface_gl_impeller.cc`
encode_calback -> encode_callback

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-05-19 18:03:16 +00:00
Emmanuel Ferdman
0bd6394025
Modernize system executable detection across components (#169018) 
# PR Summary
This small PR resolves deprecation warnings caused by the use of
`distutils.spawn.find_executable`:
```python
DeprecationWarning: Use shutil.which instead of find_executable
```
Please note that `find_executable` is deprecated from Python 3.10 and
removed in 3.12. `shutil.which` available since Python 3.3.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
 2025-05-19 18:03:16 +00:00
Sirui Qu
5bcde8fa7b
Update documentation for Size and Rect classes (#168031) 
Update documentation for `Size` and `Rect` classes in geometry.dart to
correct references for `centerRight` and `bottomCenter` methods.

Co-authored-by: stuuupidcat <stuuupidcat.3@gmail.com>
 2025-05-19 17:58:15 +00:00
Chris Bracken
e27377ef4d
macOS: port ResizeSynchronizer to Swift (#168959) 
This patch:
* migrates FlutterResizeSynchronizer from Objective-C to Swift.
* reorders the performCommit parameters to support trailing closure
syntax in Swift.
* adds an optional onTimeout parameter to
ResizeSynchronizer.beginResize.
* adds test coverage for the timeout case.
* significantly improves the class documentation.
* adds the first Swift Testing tests for the macOS embedder.
* adds the new tests to run_test.py.

Admittedly, the original purpose was just to add a class that we could
write Swift tests for, but things got a bit out of hand.

Issue: https://github.com/flutter/flutter/issues/168564
Issue: https://github.com/flutter/flutter/issues/144791

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-05-18 19:07:08 +00:00
engine-flutter-autoroll
a682cf27b2
Roll Dart SDK from dc323ec0c1a3 to 7c40eba6bf77 (3 revisions) (#169024) 
https://dart.googlesource.com/sdk.git/+log/dc323ec0c1a3..7c40eba6bf77

2025-05-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-138.0.dev
2025-05-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-137.0.dev
2025-05-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-136.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-05-17 04:54:34 +00:00
jacobsimionato
e74b5da782
Add flag to skip bundling extension safe builds in frameworks for DDM (#168955) 
This attempts to resolve an error like:

```
Cannot find extension safe iOS arm64 Framework at /Volumes/Work/s/w/ir/cache/builder/engine/src/out/ci/ios_debug_ddm_extension_safe/Flutter.framework
ERROR: binaries listed in entitlements.txt, without_entitlements.txt, andunsigned_binaries.txt do not match the set of binaries in the files to be zipped
Binaries found in files to be zipped:
    Flutter.xcframework/ios-arm64/Flutter.framework/Flutter
    Flutter.xcframework/ios-arm64_x86_64-simulator/Flutter.framework/Flutter
    gen_snapshot_arm64
Binaries listed in entitlements.txt, without_entitlements.txt, unsigned_binaries.txt but NOT FOUND:
    extension_safe/Flutter.xcframework/ios-arm64/Flutter.framework/Flutter
    extension_safe/Flutter.xcframework/ios-arm64_x86_64-simulator/Flutter.framework/Flutter
```

This was coming from
[create_ios_framework.py](6de5aed91f/engine/src/flutter/sky/tools/create_ios_framework.py)
which assumes that extension safe frameworks are being built.

I verified that this works using the following:

```sh
et build --config ci/ios_debug_sim_ddm && \
    et build --config ci/ios_debug_sim_arm64_ddm && \
    et build --config ci/ios_debug_ddm && \
    et build --config ci/ios_release_ddm

python3 \
  engine/src/flutter/sky/tools/create_ios_framework.py \
  --dst \
  out/debug_ddm \
  --arm64-out-dir \
  out/ci/ios_debug_ddm \
  --simulator-x64-out-dir \
  out/ci/ios_debug_sim_ddm \
  --simulator-arm64-out-dir \
  out/ci/ios_debug_sim_arm64_ddm \
  --no-extension-safe-frameworks
  ```
 2025-05-17 00:10:45 +00:00
Gray Mackall
8463d5e87d
[hcpp/hc] Fix talkback for HC and HCPP Android platform views (#168939) 
See the description here:
https://github.com/flutter/flutter/issues/113626#issuecomment-2884997160

Fixes https://github.com/flutter/flutter/issues/113626

Also, I think we can probably improve the behavior here to respect what
the original view's accessibility importance was, by storing what we are
overwriting at creation time, and then using that later when we undo
what we do at creation time. As is it seems like there would be no way
for a developer to _actually_ set their view to be not important for
accessibility, we are basically forcing them in to auto. Can look into
that in a follow up.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Gray Mackall <mackall@google.com>
 2025-05-16 22:46:38 +00:00
Jonah Williams
085ca9ed33
[Impeller] separate immutable sampler descriptors. (#169011) 
The descriptor set for the immutable sampler may need to be different
than the non-immutable sampler variant. Make the pipeline key signed and
use the sign bit to indicate immutable sampler.

Fixes https://github.com/flutter/flutter/issues/168114
 2025-05-16 22:39:56 +00:00
engine-flutter-autoroll
25e8e074cf
Roll Fuchsia Linux SDK from Jj-iDG5uPOsFgY2_H... to XtPp9bBW49iDJ0wbA... (#169009) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-05-16 21:33:26 +00:00
Matan Lurey
456071cd00
Remove unittests from windows_host_engine GN targets. (#168991) 
Closes https://github.com/flutter/flutter/issues/168990.

Will shave a few minutes off builds, particularly in resource sensitive
environments like releases.
 2025-05-16 18:37:05 +00:00
engine-flutter-autoroll
3c6f74c799
Roll Dart SDK from a1db62a5dd14 to dc323ec0c1a3 (4 revisions) (#168989) 
https://dart.googlesource.com/sdk.git/+log/a1db62a5dd14..dc323ec0c1a3

2025-05-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-135.0.dev
2025-05-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-134.0.dev
2025-05-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-133.0.dev
2025-05-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-132.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-05-16 18:01:05 +00:00
Jackson Gardner
8ae7b522dc
[skwasm] Add the capability of dumping live object counts in debug mode. (#168389) 
This adds a debugging utility that allows us to dump counts of the live
skwasm objects in debug mode. This is useful for understanding memory
leaks.

This is not code that runs in production or affects end users, so I'm
not bothering to write specific unit tests for this functionality.

---------

Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
 2025-05-16 17:07:53 +00:00
Jim Graham
c685293fc4
[Impeller] Use PathSource for DrawDiffRoundRect (#168942) 
We avoid the expense and memory churn of allocating a path by using
stack allocated path source objects to render the DiffRoundRect call.
 2025-05-16 00:55:29 +00:00
Matt Boetger
bb2c346f35
Increase logging around loading of libflutter.so (#168706) 
Increase logging around libflutter.so. This adds debug logging to the
ReLinker load call as well as more logging in the error case. The split
and source dirs are added to the error message to improve
troubleshooting in the app bundle case. This does not fix the error of
not finding the libflutter.so file, just increases logging to hopefully
help devs find their problem.

Also, this fixes the unit tests which were not correctly getting the
exception in the given test.

Fixes: #168272

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
 2025-05-15 23:27:52 +00:00
engine-flutter-autoroll
a556dcc9e6
Roll Dart SDK from c9640c3a4440 to a1db62a5dd14 (2 revisions) (#168945) 
https://dart.googlesource.com/sdk.git/+log/c9640c3a4440..a1db62a5dd14

2025-05-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-131.0.dev
2025-05-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-130.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-05-15 23:27:51 +00:00
Chris Bracken
5cf4a50be9
iOS,macOS: Support using public API in Swift (#168929) 
This adds Obj-C/Swift bridging headers to Swift targets, which allows us
to use public Flutter framework API from Swift code in the framework.

This also restricts visibility of the Swift framework targets to the
corresponding framework target. The addition of a bridging header allows
us to use public framework types declared in those headers from Swift,
but those types are defined in the framework target, and thus using the
Swift target directly may result in linking errors in the user. Instead,
all usage of the Swift target should be transitive via the framework
target.

Issue: https://github.com/flutter/flutter/issues/144791

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-05-15 22:08:09 +00:00
Matan Lurey
83c3c91645
Add bringup: true Linux orchestrators that schedule Windows engine builds (#168937) 
Towards https://github.com/flutter/flutter/issues/168934.

/cc @reidbaker as release engineer.
 2025-05-15 19:57:31 +00:00
Jim Graham
cdd6be4798
[Impeller] Delete redundant impeller path classes (#168760) 
Nearly all parts of the Impeller rendering pipeline now rely on DlPath
and PathSource objects for their path description needs. The impeller
path only exists for impeller's unit tests and benchmarks to have a
local way to construct paths. We implement path construction for the
DlPath object via DlPathBuilder which makes the impeller family of path
objects functionally obsolete and so they are now deleted.
 2025-05-15 18:42:23 +00:00
engine-flutter-autoroll
a164f65386
Roll Dart SDK from a6c25e31caa7 to c9640c3a4440 (1 revision) (#168911) 
https://dart.googlesource.com/sdk.git/+log/a6c25e31caa7..c9640c3a4440

2025-05-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-129.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-05-15 16:44:52 +00:00
engine-flutter-autoroll
1d8078552d
Roll Dart SDK from b3520981e0f0 to a6c25e31caa7 (11 revisions) (#168895) 
https://dart.googlesource.com/sdk.git/+log/b3520981e0f0..a6c25e31caa7

2025-05-15 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-128.0.dev
2025-05-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-127.0.dev
2025-05-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-126.0.dev
2025-05-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-125.0.dev
2025-05-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-124.0.dev
2025-05-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-123.0.dev
2025-05-14 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-122.0.dev
2025-05-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-121.0.dev
2025-05-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-120.0.dev
2025-05-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-119.0.dev
2025-05-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-118.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-05-15 11:16:37 +00:00
engine-flutter-autoroll
0e3f7777fa
Roll Fuchsia Linux SDK from fSvuEJgRmHxnewRJr... to Jj-iDG5uPOsFgY2_H... (#168893) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-05-15 10:52:07 +00:00
jacobsimionato
d41200aad4
Fix mac_ios_engine_ddm config with missing ci/ios_debug_sim_ddm config (#168888) 
This should fix an error that I got in `Global generators` ->
`Debug-ios-Flutter.xcframework`:

https://ci.chromium.org/ui/p/flutter/builders/staging/Mac%20mac_ios_engine_ddm/1/overview

```
Cannot find iOS x64 simulator framework at /Volumes/Work/s/w/ir/cache/builder/engine/src/out/ci/ios_debug_sim_ddm/Flutter.framework`
```

I think what happened here is that I assumed I could skip the x64
simulator build because myself and other 1P developers are using arm64
macs. But I now see that the `Debug-ios-Flutter.xcframework` task and
the `flutter/sky/tools/create_ios_framework.py` script assumes both
architectures are present.
 2025-05-15 07:56:46 +00:00
Chris Bracken
540d19c148
iOS,macOS: Migrate logging to Logger/FlutterLogger (#168568) 
In new Swift code in the iOS/macOS embedder, we currently lack core
features currently provided by shared internal C++ library code in FML.
This provides a logging implementation that can be used across the
iOS/macOS embedders, whether in Swift, Objective-C, or C++ code, and
migrates the iOS and macOS embedders to use it.

This patch also introduces gn support for authoring [Swift Testing][]
tests.
* Introduces a `SwiftTestingRunner` class that launches the Swift
Testing test runner, which runs all tests annotated with `@Test` linked
into the current executable.
* Introduces a `SwiftTestingRunnerMain` class that implements a main
entrypoint that launches the `SwiftTestingRunner`.
* Introduces a `gn` `source_set` target
(`//flutter/shell/platform/darwin/common:swift_testing_main`) that
includes the Swift Testing main entrypoint, such that `executable`
targets can add it to their deps to automatically be built as a Swift
Testing runner.
* Adds a `framework_common_swift_unittests` executable target for the
common framework unit tests, and wires that into the build and
`run_tests.py` for macOS.

Issue: https://github.com/flutter/flutter/issues/168564
Issue: https://github.com/flutter/flutter/issues/144791

[Swift Testing]: https://developer.apple.com/xcode/swift-testing/


## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-05-15 04:52:35 +00:00
Jonah Williams
b443c2a97a
[display_list] paint cleanup. (#168082) 
Reduce the number of places where we convert flutter paint to DLpaint
and remove unused tonic overrides. Also does a pass on dl_paint/builder
to remove places we accidentally incremented/decrement shared_ptr ref
counts
 2025-05-15 01:53:18 +00:00
jacobsimionato
8556b2537a
Add a new CI build for iOS DDM-enabled artifacts (#168717) 
This adds a new flavor of mac_ios_engine, which enables a build flag.
This is not part of the merge-queue since it's intended for experimental
and internal use at the moment.

Tested locally via `et build --config ci/mac_ios_engine_ddm`

This follows @sigmundch 's
https://github.com/flutter/flutter/pull/162855 which achieves the same
result for Android.

I branched `mac_ios_engine_ddm.json` and removed:
- x86 builds, seeing as I think we're all testing locally with arm64
macs now, and forge supports them as well (with a flag to force use of
arm64).
- All "extension safe" builds seeing as we aren't targeting watches at
this point.
 - All "profile" flavor builds
 2025-05-15 01:38:10 +00:00
auto-submit[bot]
c8b47c0113
Reverts "Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396)" (#168880) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#168396
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: matanlurey
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Broke iOS device lab tests.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: gaaclarke
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {vashworth, hellohuanlin}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
fixes: https://github.com/flutter/flutter/issues/167267

design doc:
https://docs.google.com/document/d/1ZfcQOs-UKRa9jsFG84-MTFeibZTLKCvPQLxF2eskx44/edit?tab=t.0

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-05-15 00:40:18 +00:00
gaaclarke
773d076621
Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396) 
fixes: https://github.com/flutter/flutter/issues/167267

design doc:
https://docs.google.com/document/d/1ZfcQOs-UKRa9jsFG84-MTFeibZTLKCvPQLxF2eskx44/edit?tab=t.0

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-05-14 22:59:14 +00:00
auto-submit[bot]
606bb06c0f
Reverts "Use live region in error text input decorator for Android (#165531)" (#168848) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#165531
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: matanlurey
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Breaks google client tests
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: ash2moon
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {chunhtai, reidbaker, hannah-hyj}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Resolves partly https://github.com/flutter/flutter/issues/165510


**Context:** This issue originates from
https://github.com/flutter/flutter/issues/99715, where it was reported
that `liveRegion` alone was insufficient for announcing form validation
errors. While `liveRegion` announces the first error encountered,
subsequent submissions with the same error message on Android would not
trigger a re-announcement.

**Original Solution:** Pull request
https://github.com/flutter/flutter/pull/123373 addressed this by
implementing the `announce` event to ensure error messages were
consistently announced, even for repeated submissions.

**Native Android Behavior (Jetpack Compose):** In native Android
development using Jetpack Compose, setting the `isError` property of a
`TextField` to `true` triggers Talkback to announce "Error invalid
input." This announcement occurs *only* on the initial change to the
error state. Subsequent errors, even if the `isError` property remains
`true`, are not re-announced. This behavior closely mirrors the
functionality of `liveRegion`, with the key difference being that
`liveRegion` also announces the specific error text, in addition to the
general error state. Testing in a native Jetpack Compose application
confirms this behavior and provides a valuable comparison point against
the current Flutter form example.

**Suggested Action:** **Fork** the behavior in
https://github.com/flutter/flutter/pull/123373. Reinstate the use of
`liveRegion` for error announcements within `widgets/Form` for Android
and keep other platforms the same.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-05-14 17:47:38 +00:00
Chris Bracken
8e35392878
macOS,iOS: fix swift target triple (#168749) 
While unifying iOS and macOS gn configuration in flutter/flutter#168517,
I failed to correctly merge the deployment target in the target triple,
resulting in it being incorrectly hardcoded to the macOS deployment
target. This corrects this to the correct value for the `target_os` of
the current compile.

Also gets rid of an unnecessary assertion; we already
`assert(is_mac || is_ios)` at the top of the file.

Issue: https://github.com/flutter/flutter/issues/167592

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-05-14 15:56:52 +00:00
Robert Ancell
0b9f9288ca
Fix Linux Impeller support broken by incorrect deletion of stencil buffer. (#168668) 
The buffer was leaking and deleted in
9d8e5e0b2f0dbff358286a1f83c83e65077d0b7a. This fixes the location where
the buffer is deleted.
 2025-05-14 08:31:16 +00:00
engine-flutter-autoroll
9a67219ea0
Roll Fuchsia Linux SDK from 6J81agNhuK4q255Jj... to fSvuEJgRmHxnewRJr... (#168794) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-05-14 05:23:11 +00:00
engine-flutter-autoroll
ce5ece9e53
Roll Dart SDK from 645d04a7a964 to b3520981e0f0 (3 revisions) (#168721) 
https://dart.googlesource.com/sdk.git/+log/645d04a7a964..b3520981e0f0

2025-05-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-117.0.dev
2025-05-13 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-116.0.dev
2025-05-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-115.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

---------

Co-authored-by: Alexander Aprelev <aam@google.com>
 2025-05-13 23:48:10 +00:00
Hannah Jin
30924e2d6d
[a11y] Semanctis flag refactor step 3: framework part (#167771) 
issue: https://github.com/flutter/flutter/issues/166101, overall goal is
to update semantics flag to be a struct/class to support more than 32
flags.

step 1: https://github.com/flutter/flutter/pull/167421 Update
semantics_node.h and dart:ui
step 2: https://github.com/flutter/flutter/pull/167738 Update Embedder
part to use a struct instead of a int bit mask.
step 3:(this PR) Update Framework use the SemanticsFlags class instead
of bitmask

TODO:
web engine
use the new class

SemanticsUpdateBuilder.updateNode
pass a list of bools instead of bitmask

flutter_tester
use the SemanticsFlags class instead of bitmask


[apicheck_test.dart](https://github.com/flutter/flutter/pull/167421/files#diff-69aefaacf1041f639974044962123bfae0756ce86032ac1f26256099425d7a5a)
Add this test back
 2025-05-13 23:48:10 +00:00
ash2moon
f3a1806562
Use live region in error text input decorator for Android (#165531) 
Resolves partly https://github.com/flutter/flutter/issues/165510


**Context:** This issue originates from
https://github.com/flutter/flutter/issues/99715, where it was reported
that `liveRegion` alone was insufficient for announcing form validation
errors. While `liveRegion` announces the first error encountered,
subsequent submissions with the same error message on Android would not
trigger a re-announcement.

**Original Solution:** Pull request
https://github.com/flutter/flutter/pull/123373 addressed this by
implementing the `announce` event to ensure error messages were
consistently announced, even for repeated submissions.

**Native Android Behavior (Jetpack Compose):** In native Android
development using Jetpack Compose, setting the `isError` property of a
`TextField` to `true` triggers Talkback to announce "Error invalid
input." This announcement occurs *only* on the initial change to the
error state. Subsequent errors, even if the `isError` property remains
`true`, are not re-announced. This behavior closely mirrors the
functionality of `liveRegion`, with the key difference being that
`liveRegion` also announces the specific error text, in addition to the
general error state. Testing in a native Jetpack Compose application
confirms this behavior and provides a valuable comparison point against
the current Flutter form example.

**Suggested Action:** **Fork** the behavior in
https://github.com/flutter/flutter/pull/123373. Reinstate the use of
`liveRegion` for error announcements within `widgets/Form` for Android
and keep other platforms the same.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Reid Baker <1063596+reidbaker@users.noreply.github.com>
 2025-05-13 17:47:09 +00:00
Kostia Sokolovskyi
f50c6c0fc4
[web] Fix multiline input selection in Chrome. (#168217) 
Fixes https://github.com/flutter/flutter/issues/167805
Fixes https://github.com/flutter/flutter/issues/162698

### Description

First of all, I would like to thank @jezell for posting their fix of
this selection issue:
https://github.com/singerdmx/flutter-quill/issues/2450#issuecomment-2754652065

The issue with selection is happening because in Chrome `pointermove`
event and its coalesced events have some different targets. @mdebbar
already spotted this behavior some time ago and even filed a Chrome bug:
https://github.com/flutter/engine/pull/56949#discussion_r1871750266

This jsfiddle allows reproducing the bug:
https://jsfiddle.net/knevercode/y2hpfmrb/2/

On the following recording, you can see the events' targets and their
bounding boxes.
<video
src="https://github.com/user-attachments/assets/82af8d86-2cfe-4e36-a977-46ffa58facdb"/>

Those coalesced events have their `offsetX` and `offsetY` values
relative to the dummy `div` target. So to fix that, we have to translate
those values to be relative to the actual target.

This PR does exactly this in `_computeOffsetForInputs` when
`event.target != eventTarget` .

| Before | After |
| - | - |
| https://chrome-input-selection-bug.web.app |
https://chrome-input-selection-fix.web.app |
| <video
src="https://github.com/user-attachments/assets/1e10b43a-ff4f-46e8-8977-ee435f9d78fb"/>
| <video
src="https://github.com/user-attachments/assets/a997bfd0-8361-4bb3-910c-58cfc6b5d426"/>
|

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-05-13 15:59:07 +00:00
jesswrd
358b072688
Fixed Android Lint Errors (#168613) 
Fixes blocking warnings on Flutter Roll. Also should fix red tree.

Had to add `@RequiresApi` annotations at the function level due to usage
and requirements of Android functions. This happened because I removed
`@TargetApi` at the class level due to conflicts within the class. It
seems that the `@TargetApi` annotation can no longer be used.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-05-13 13:24:22 +00:00
engine-flutter-autoroll
149ac49583
Roll Fuchsia Linux SDK from 6vjKe0bfYDVaECqBL... to 6J81agNhuK4q255Jj... (#168712) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-05-13 02:41:39 +00:00
engine-flutter-autoroll
2982c93b9d
Roll Dart SDK from 0bea6379f654 to 645d04a7a964 (14 revisions) (#168679) 
https://dart.googlesource.com/sdk.git/+log/0bea6379f654..645d04a7a964

2025-05-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-114.0.dev
2025-05-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-113.0.dev
2025-05-12 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-112.0.dev
2025-05-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-111.0.dev
2025-05-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-110.0.dev
2025-05-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-109.0.dev
2025-05-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-108.0.dev
2025-05-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-107.0.dev
2025-05-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-106.0.dev
2025-05-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-105.0.dev
2025-05-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-104.0.dev
2025-05-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-103.0.dev
2025-05-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-102.0.dev
2025-05-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-101.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-05-12 20:04:52 +00:00
Chinmay Garde
ed60ea9876
[Impeller] libImpeller: Allow setting text decorations. (#168408) 
Underlines, overlines, strikethroughs (with dashed, wavy, dotted...
styles) etc..

Fixes https://github.com/flutter/flutter/issues/157796

<img width="1136" alt="Screenshot 2025-05-06 at 1 04 30 PM"
src="https://github.com/user-attachments/assets/f2233ebd-87b2-42ca-ac2a-c71e40ceb953"
/>
 2025-05-12 20:03:26 +00:00
Gray Mackall
88ce9564c3
Error when trying to use old HC mode when HCPP is enabled (#168027) 
Fixes https://github.com/flutter/flutter/issues/164218.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Gray Mackall <mackall@google.com>
 2025-05-12 18:53:16 +00:00
engine-flutter-autoroll
bf81c5cfdb
Roll Fuchsia Linux SDK from VIG5-P9wwXgQkCkeX... to 6vjKe0bfYDVaECqBL... (#168646) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-05-11 23:58:28 +00:00