Jenn Magder
2edf3d91b7
Rebase ios-experimental onto main ( #173804 )
...
Rebase ios-experimental branch onto main. This will make the PRs
experimenting with newer versions of Xcode (like
https://github.com/flutter/flutter/pull/173123 ) smaller and easier to
reason about.
Rebases #168860 and #170274
```
$ git rebase main -Xtheirs
```
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com>
Co-authored-by: Siva <a-siva@users.noreply.github.com>
Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Co-authored-by: Jamil Saadeh <jssaadeh@outlook.com>
Co-authored-by: Dara Adedeji <76637177+SunkenInTime@users.noreply.github.com>
Co-authored-by: Greg Price <gnprice@gmail.com>
Co-authored-by: Ben Konyi <bkonyi@google.com>
Co-authored-by: Ricardo Dalarme <ricardodalarme@outlook.com>
Co-authored-by: Flutter GitHub Bot <fluttergithubbot@gmail.com>
Co-authored-by: Justin McCandless <jmccandless@google.com>
Co-authored-by: Alex Talebi <31685655+SalehTZ@users.noreply.github.com>
Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
Co-authored-by: Mouad Debbar <mdebbar@google.com>
Co-authored-by: Zuckjet <1083941774@qq.com>
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
Co-authored-by: auto-submit[bot] <98614782+auto-submit[bot]@users.noreply.github.com>
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: yim <ybz975218925@gmail.com>
Co-authored-by: bufffun <chenmingding.cmd@alibaba-inc.com>
Co-authored-by: Chinmay Garde <chinmaygarde@google.com>
Co-authored-by: Hannah Jin <jhy03261997@gmail.com>
Co-authored-by: Kate Lovett <katelovett@google.com>
Co-authored-by: Valentin Vignal <32538273+ValentinVignal@users.noreply.github.com>
Co-authored-by: Derek Xu <derekx@google.com>
Co-authored-by: Yash Dhrangdhariya <72062416+Yash-Dhrangdhariya@users.noreply.github.com>
Co-authored-by: bungeman <bungeman@chromium.org>
Co-authored-by: Ahmed Mohamed Sameh <ahmedsameha1@gmail.com>
Co-authored-by: John "codefu" McDole <codefu@google.com>
Co-authored-by: Dmitry Grand <dmgr@google.com>
Co-authored-by: Kostia Sokolovskyi <sokolovskyi.konstantin@gmail.com>
Co-authored-by: Reid Baker <1063596+reidbaker@users.noreply.github.com>
Co-authored-by: Matthew Kosarek <matt.kosarek@canonical.com>
Co-authored-by: Jason Simmons <jason-simmons@users.noreply.github.com>
Co-authored-by: Jim Graham <flar@google.com>
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
Co-authored-by: Gray Mackall <mackall@google.com>
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Jon Ihlas <jon.i@hotmail.fr>
Co-authored-by: Micael Cid <micaelcid10@gmail.com>
Co-authored-by: Alexander Aprelev <aam@google.com>
Co-authored-by: hellohuanlin <41930132+hellohuanlin@users.noreply.github.com>
Co-authored-by: Luke Memet <1598289+lukemmtt@users.noreply.github.com>
Co-authored-by: Victoria Ashworth <15619084+vashworth@users.noreply.github.com>
Co-authored-by: Mairramer <50643541+Mairramer@users.noreply.github.com>
Co-authored-by: Florin Malita <fmalita@gmail.com>
Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
Co-authored-by: Salem Iranloye <127918074+salemiranloye@users.noreply.github.com>
Co-authored-by: Kevin Moore <kevmoo@google.com>
Co-authored-by: Sydney Bao <sydneybao@google.com>
Co-authored-by: Wdestroier <Wdestroier@gmail.com>
Co-authored-by: Matt Boetger <matt.boetger@gmail.com>
Co-authored-by: Reid Baker <reidbaker@google.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
Co-authored-by: Jessy Yameogo <jessy.yameogo@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: romain.gyh <11901536+romaingyh@users.noreply.github.com>
Co-authored-by: Robert Ancell <robert.ancell@canonical.com>
Co-authored-by: TheLastFlame <131446187+TheLastFlame@users.noreply.github.com>
Co-authored-by: masato <returnymgstokh@icloud.com>
Co-authored-by: Albin PK <56157868+albinpk@users.noreply.github.com>
Co-authored-by: Huy <huy@nevercode.io>
Co-authored-by: Matan Lurey <matanlurey@users.noreply.github.com>
Co-authored-by: Azat Chorekliyev <azat24680@gmail.com>
Co-authored-by: EdwynZN <edwinzn9@gmail.com>
Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
Co-authored-by: Dev TtangKong <ttankkeo112@gmail.com>
Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>
Co-authored-by: Houssem Eddine Fadhli <houssemeddinefadhli81@gmail.com>
2025-08-19 12:05:40 -07:00
Victoria Ashworth
683ec137ee
Try Xcode 16.4 ( #170274 )
...
Test out experimental branch by testing Xcode 16.4
2025-06-09 20:28:01 +00:00
Matan Lurey
fd25d09944
[ios-experimental] Update .ci.yamls ( #168860 )
...
Towards https://github.com/flutter/flutter/issues/168738 .
This PR is to:
- check if the presubmit workflow is working
- (after merge) check post-submit
- label this branch for others.
2025-05-15 11:21:02 -07:00
engine-flutter-autoroll
bf81c5cfdb
Roll Fuchsia Linux SDK from VIG5-P9wwXgQkCkeX... to 6vjKe0bfYDVaECqBL... ( #168646 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-11 23:58:28 +00:00
engine-flutter-autoroll
992ad7489c
Roll Fuchsia Linux SDK from F2xwL6WosfD7ETcPm... to VIG5-P9wwXgQkCkeX... ( #168633 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-10 21:40:07 +00:00
Jim Graham
8ee8eaa66e
delete stale references/includes to classes no longer used ( #168616 )
...
Simple code pruning. While scanning the sources for unused code I found
a few stale references to classes that were already no longer being
used.
2025-05-10 09:02:17 +00:00
engine-flutter-autoroll
b2e0bf3ea0
Roll Skia from 12dbc34d742e to 645404ec2d60 (1 revision) ( #168621 )
...
https://skia.googlesource.com/skia.git/+log/12dbc34d742e..645404ec2d60
2025-05-09 nscobie@google.com Replace scroggo with egdaniel in
OWNERS_build_files.android
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-10 01:24:21 +00:00
Tong Mu
70619a15d0
Fix: Impeller playground's points should be draggable ( #168351 )
...
This PR fixes the issue that `PlaygroundPoint`s can't be dragged in
playgrounds.
The issue was introduced in https://github.com/flutter/engine/pull/56734
by me where I incorrectly removed these static keywords.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-05-09 22:34:34 +00:00
engine-flutter-autoroll
63007eaf48
Roll Skia from 0d16b74f74a5 to 7f7555536e3c (5 revisions) ( #168609 )
...
https://skia.googlesource.com/skia.git/+log/0d16b74f74a5..7f7555536e3c
2025-05-09
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-05-09 drott@chromium.org Reland "[Fontations] Avoid redundant path
retrieval"
2025-05-09 fmalita@google.com [path] Add fill type utils
2025-05-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from c03307f471f4 to b729fb74e68b (6 revisions)
2025-05-09
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-09 19:54:03 +00:00
Chinmay Garde
e3d5758273
[Impeller] libImpeller: Usability improvements for WASM and python bindings. ( #168397 )
...
Fixes https://github.com/flutter/flutter/issues/168393
Fixes https://github.com/flutter/flutter/issues/168394
2025-05-09 17:31:09 +00:00
engine-flutter-autoroll
5e64293590
Roll Skia from efccaeb08b8d to 0d16b74f74a5 (6 revisions) ( #168569 )
...
https://skia.googlesource.com/skia.git/+log/efccaeb08b8d..0d16b74f74a5
2025-05-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
skottie-base from 375561920728 to 6f141efaf8cb
2025-05-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
jsfiddle-base from 552d94229577 to 85c7d3d4b62f
2025-05-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
debugger-app-base from 7f477239b384 to f4f588b1198d
2025-05-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
shaders-base from 3a63c1930823 to 1cdf37f3bad8
2025-05-08 robertphillips@google.com Revert "[Fontations] Avoid
redundant path retrieval"
2025-05-08 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
ANGLE from df8a704788de to c03307f471f4 (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-09 16:58:05 +00:00
Kevin Moore
4cad7a78e8
[web] more cleanup of unused APIs ( #168524 )
...
One API only existed for tests.
Also removed an unused class
2025-05-09 16:56:05 +00:00
engine-flutter-autoroll
dc170241dc
Roll Fuchsia Linux SDK from mqhX1OP8ezmialgqA... to F2xwL6WosfD7ETcPm... ( #168587 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-09 16:56:04 +00:00
gaaclarke
67ef841cae
Increased the limit where we start chopping off the end of blurs ( #168109 )
...
issue: https://github.com/flutter/flutter/issues/165422
Here is the before/after screenshots at sigma = 30
https://github.com/user-attachments/assets/d85f51f6-676e-48e8-ae3e-c887f69f2cbd
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-05-08 22:21:31 +00:00
Alexander Aprelev
201893ed94
Roll to Dart SDK 3.9 Beta 1 ( #168559 )
...
Roll to dart sdk 3.9 beta 1 plus the fix for native resolver not having
an isolate
2025-05-08 20:56:07 +00:00
Chris Bracken
b0ad252b7a
Rename apple -> darwin across our buildroot ( #168558 )
...
As part of unifying our iOS and macOS build config, toolchain, and
scripts, I named some of these `apple_sdk.py`, `toolchain/apple`, etc.
for consistency with the chromium toolchain. This renames these `darwin`
for consistency with other parts of our build.
Issue: https://github.com/flutter/flutter/issues/167592
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-05-08 20:52:08 +00:00
jesswrd
f8b544a7ff
Update Engine to Android 16 (API 36) ( #166796 )
...
Following the directions
[here](https://github.com/flutter/flutter/blob/main/docs/platforms/android/Upgrading-Engine's-Android-API-version.md )
to update engine to android 16.
1. Uploaded api 36 SDK to CIPD using the script from the above docs
2. Updates in Engine to use api 36
- Updated buildroot
- Updated SDK CIPD package in `DEPS`
- Updated android build tools
- Updated `targetsdk` and `compilesdk`
3. Confirm the engine sucessfully builds. I ran `et build -c
android_debug_unopt_arm64`
4. Bumped the gradle version in this PR due to seeing this warning
[here](https://github.com/flutter/flutter/blob/master/docs/platforms/android/New-Android-version.md#:~:text=Update%20Gradle/AGP%20support ).
Note: Post mono-repo merge, we can now update buildroot and `DEPS` in
the same PR 🎊 !!! Also, updated the Clang path due to use of a new Clang
version in the bumped ndk.
Partially Addresses #166950
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-05-08 19:46:59 +00:00
engine-flutter-autoroll
5041a592c8
Roll Skia from 43ae814d2d95 to efccaeb08b8d (5 revisions) ( #168554 )
...
https://skia.googlesource.com/skia.git/+log/43ae814d2d95..efccaeb08b8d
2025-05-08 zengyonghust@gmail.com Fixed precision-loss-induced errors in
path primitive simplification algorithm
2025-05-08 thomsmit@google.com [graphite] Remove vertex buffer bind
tracking logic from metal and vulkan.
2025-05-08 robertphillips@google.com [graphite] Expand coverage of
AndroidPrecompileTest
2025-05-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from b373892b9d96 to df8a704788de (10 revisions)
2025-05-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 093b4d82a49a to 930d46d31b5d (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-08 18:23:12 +00:00
Chris Bracken
02d8c1aceb
iOS,macOS: Unify iOS,macOS build configs ( #168517 )
...
Merges:
* //build/config/ios:compiler
* //build/config/mac:compiler
Into:
* //build/config/apple:compiler
Merges:
* //flutter/shell/platform/darwin/ios:config_ios
* //flutter/shell/platform/darwin/mac:config_macos
Into:
* //flutter/shell/platform/darwin/common:config
Merges:
* //flutter/shell/platform/darwin/ios:config_ios_test
* //flutter/shell/platform/darwin/mac:config_macos_test
Into:
* //flutter/shell/platform/darwin/common:test_config
This avoids the duplication between iOS and macOS build configs used for
building Swift and Objective-C that depends on Swift, and avoids further
duplication when we add Swift to //flutter/shell/platform/darwin/common
in a followup patch.
Issue: https://github.com/flutter/flutter/issues/167592
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-05-08 18:11:10 +00:00
zhongliugo
76747c0ece
Remove unnecessary setAriaRole('dialog') fallback in SemanticRoute class ( #168345 )
...
**Description**
This pull request removes the unnecessary setAriaRole('dialog') fallback
in the SemanticRoute class within the Flutter web engine. This line was
an old fallback and is no longer needed
**Before**
https://dialog-0505-before.web.app/
**After**
https://dialog-050502-after.web.app/
**Issue Fixed**
This PR addresses GitHub Issue #168247 , which proposes reconsidering the
application of role="dialog" to arbitrary routes.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-05-08 08:02:19 +00:00
engine-flutter-autoroll
71c847e8b0
Roll Skia from 4d617bb1bb7d to 43ae814d2d95 (1 revision) ( #168526 )
...
https://skia.googlesource.com/skia.git/+log/4d617bb1bb7d..43ae814d2d95
2025-05-08 michaelludwig@google.com [graphite] Fix device-space blur
mask filters with non-uniform scale
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-08 07:24:33 +00:00
engine-flutter-autoroll
fc939098d4
Roll Fuchsia Linux SDK from _GJje-N2Jk51qtBs6... to mqhX1OP8ezmialgqA... ( #168525 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-08 07:18:12 +00:00
engine-flutter-autoroll
68dff95515
Roll Skia from d787c26f873a to 4d617bb1bb7d (1 revision) ( #168514 )
...
https://skia.googlesource.com/skia.git/+log/d787c26f873a..4d617bb1bb7d
2025-05-07 cairno@google.com [Ganesh] Allow rect preserving view
matrices in the rrect blur fast path
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-08 01:30:26 +00:00
engine-flutter-autoroll
3a1c297206
Roll Skia from 1ea3ec8e7863 to d787c26f873a (6 revisions) ( #168505 )
...
https://skia.googlesource.com/skia.git/+log/1ea3ec8e7863..d787c26f873a
2025-05-07 nicolettep@google.com [graphite] Use hardware blending for
advanced blend modes when supported
2025-05-07 vigneshv@google.com gn_to_bp: Remove libheif from Android
deps
2025-05-07
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-05-07 drott@chromium.org [Fontations] Avoid redundant path
retrieval
2025-05-07 bungeman@google.com Allow generateMetrics to also generate
path
2025-05-07 michaelludwig@google.com [graphite] Use 1/2px for hairline
radius in numRadialSegmentsPerRadian
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-07 22:58:11 +00:00
Kevin Moore
3ff039415e
[web] drop more use of deprecated JS functions ( #166157 )
2025-05-07 22:06:26 +00:00
engine-flutter-autoroll
06fa7d91f2
Roll Skia from 14f3e3209b73 to 1ea3ec8e7863 (2 revisions) ( #168489 )
...
https://skia.googlesource.com/skia.git/+log/14f3e3209b73..1ea3ec8e7863
2025-05-07 thomsmit@google.com [graphite] Split BindDrawBuffers command,
allowing binding of individual buffers.
2025-05-07 robertphillips@google.com [graphite] Add
AndroidPrecompileTest
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-07 18:34:36 +00:00
Robert Ancell
9d8e5e0b2f
Fix stencil buffer leak ( #168448 )
...
Most noticable when rendering to secondary views, one leak per frame.
Introduced for Impeller in 3af706d1887a26410cb82a9aa61da6c773d132f2
2025-05-07 17:57:08 +00:00
Robert Ancell
b3f6925fda
Fix framebuffer leak rendering to secondary views. ( #168447 )
...
Each frame would be leaked. This doesn't occur for single window.
2025-05-07 17:56:28 +00:00
Robert Ancell
f9fb8906c7
Fix uninitalized fields in FlutterWindowMetricsEvent ( #168446 )
...
Specifically physical_view_* were not set and thus had random values.
When they were negative this would cause Flutter to reject the event.
2025-05-07 17:55:45 +00:00
Chris Bracken
4af869e8d3
macOS: trailing closures for FlutterRunLoop.perform* ( #168415 )
...
Support trailing closure syntax in FlutterRunLoop perform methods. This
allows us to write Swift code like:
```
FlutterRunLoop.mainLoop.perform(withDelay: delay) {
// code.
}
```
This also matches the ordering used in NSRunLoop/RunLoop:
*
https://developer.apple.com/documentation/foundation/runloop/perform(inmodes:block:)?language=objc
*
https://developer.apple.com/documentation/foundation/runloop/perform(inmodes:block:)
Follow-up to flutter/flutter#168174 .
No tests since this is just a method rename.
Issue: https://github.com/flutter/flutter/issues/144791
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-05-07 04:27:30 +00:00
engine-flutter-autoroll
1d9bec83d7
Roll Fuchsia Linux SDK from SOlRUoAtzxSsarx-6... to _GJje-N2Jk51qtBs6... ( #168434 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-07 02:56:27 +00:00
Chris Bracken
e89c3927c2
iOS/macOS: Consistent Flutter copyright headers ( #168390 )
...
A long time ago, back after the fork from Chromium, we updated all
Chromium BSD copyright notices to Flutter. We did this in the engine,
but not in the buildroot. After the monorepo merge, we've now got a mix.
This corrects Chromium copyright notices for iOS/macOS files only, and
adds a missing copyright header.
No test changes since this touches only comments, and introduces no
functional changes.
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-05-07 00:09:28 +00:00
engine-flutter-autoroll
eed2d77269
Roll Skia from 36d1445ad00b to 32591be9cd3b (1 revision) ( #168421 )
...
https://skia.googlesource.com/skia.git/+log/36d1445ad00b..32591be9cd3b
2025-05-06 nicolettep@google.com [graphite] Perform flush when going
from using texture copies to reading as input
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-06 23:36:54 +00:00
Jackson Gardner
51ff96b9ac
[skwasm] Dispose underlying picture recorder when ending recording. ( #168384 )
...
The picture recorder doesn't have an explicit disposal function, so
instead we should dispose it when `endRecording` is called.
This addresses https://github.com/flutter/flutter/issues/168190
2025-05-06 22:30:24 +00:00
Chinmay Garde
acae343489
[Impeller] libImpeller: Expose access to conservative path bounds. ( #168402 )
...
Fixes https://github.com/flutter/flutter/issues/165909
2025-05-06 20:36:09 +00:00
engine-flutter-autoroll
949286ea89
Roll Skia from 5cf5d0ff46d9 to 36d1445ad00b (1 revision) ( #168401 )
...
https://skia.googlesource.com/skia.git/+log/5cf5d0ff46d9..36d1445ad00b
2025-05-06 dloehr@google.com Make sure inline static symbols in headers
are visible
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-06 20:32:20 +00:00
engine-flutter-autoroll
862ce5a986
Roll Skia from 889c5b52227c to 5cf5d0ff46d9 (3 revisions) ( #168378 )
...
https://skia.googlesource.com/skia.git/+log/889c5b52227c..5cf5d0ff46d9
2025-05-06 nicolettep@google.com [graphite] Align comment documentation
style for Caps
2025-05-06 robertphillips@google.com Split ChromePrecompileTest's
utilities out into their own file
2025-05-06 bungeman@google.com [pdf] Must add all reserved references
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jimgraham@google.com ,kjlubick@google.com,robertphillips@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-06 17:41:10 +00:00
engine-flutter-autoroll
b4ffba46fc
Roll Skia from 65fd10118ec2 to 646573154de6 (3 revisions) ( #168360 )
...
https://skia.googlesource.com/skia.git/+log/65fd10118ec2..646573154de6
2025-05-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 9dd03f2e4b03 to 093b4d82a49a (1 revision)
2025-05-06 syoussefi@google.com Reland "Load Vulkan dynamic state entry
points"
2025-05-06 syoussefi@google.com [graphite][vulkan] Replace `memset` with
`= {}`
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jsimmons@google.com ,kjlubick@google.com,robertphillips@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-06 07:53:37 +00:00
John "codefu" McDole
429d7e886a
Upload android-arm64-release treemap to known location ( #168349 )
...
fixes : #136011
Logs should now be locate:
* gs://flutter_logs/flutter/_SHA_/android_release_arm64/sizes/
*
https://storage.googleapis.com/flutter_logs/flutter/_SHA_/android_release_arm64/sizes/index.html
2025-05-06 02:05:36 +00:00
engine-flutter-autoroll
0d2ee2c49c
Roll Fuchsia Linux SDK from hjXORaFgiSd6QjK3D... to SOlRUoAtzxSsarx-6... ( #168347 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-06 00:00:57 +00:00
Chris Bracken
2ae0dd195d
macOS: Support writing Swift in the macOS embedder ( #168174 )
...
Enables the `swift` tool in the gn mac toolchain and wires up support
for Swift `source_set` targets. Ports `FlutterRunLoop` to Swift.
* Adds `//flutter/build/config/mac:compiler` config that sets up
`swiftflags` for the `swift` tool in the toolchain for macOS, and adds
it to the default configs on `is_mac` builds.
* Adds `mac_swift_lib_paths` in
`engine/src/build/config/apple/apple_sdk.gni` which holds the path of
Swift shared libraries for macOS targets. This is within the appropriate
`macosx` SDK directory within Xcode.
Finally, this code adds Swift code to the embedder and embedder tests as
proof of concept and to prevent regressions. This ports `FlutterRunLoop`
to Swift in order to verify Objective-C imports of Swift via the
bridging header.
Issue: https://github.com/flutter/flutter/issues/144791
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-05-05 21:19:24 +00:00
Jason Simmons
da738f3142
Copy Dart SDK _internal/vm/bin sources into the sky_engine package ( #168238 )
...
Fixes https://github.com/flutter/flutter/issues/168004
2025-05-05 20:38:52 +00:00
engine-flutter-autoroll
2ef49e7735
Roll Dart SDK from a1e1e2770c1e to 8dc0ecee5adc (1 revision) ( #168338 )
...
https://dart.googlesource.com/sdk.git/+log/a1e1e2770c1e..8dc0ecee5adc
2025-05-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.9.0-97.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-05 20:37:08 +00:00
Jason Simmons
0f769d3e21
Check for duplicate archive paths in the engine build configuration JSON files ( #168248 )
...
The intent is to catch issues like
https://github.com/flutter/flutter/issues/168180 where multiple builders
are uploading artifacts to the same paths on cloud storage.
2025-05-05 20:30:20 +00:00
Jackson Gardner
2b5ef64fc4
Skwasm heavy ( #166619 )
...
This produces a build of Skwasm that works on Firefox and Safari. This
means we use `SkAnimatedImage` for animated gifs and webps and use
builtin ICU data in Skia.
I have unit test suites for Safari and Firefox with dart2wasm and both
`ui` and `engine` test sets. However, there are a few issues with
running these on CI:
* Safari+dart2wasm doesn't work yet until the CI bots are upgraded to
macOS 15, so these have been disabled on CI for now (but you can run the
unit test suite locally).
* Firefox+ui doesn't work because our Linux bots have no GPU and
therefore no WebGL2 support, so that one is disabled. Firefox+dart2wasm
with the `engine` suite is enabled on CI though.
I did make some changes to the host page for our unit test harness so
that Safari actually works though. Even though we're not running on CI,
you can still run locally if you have macOS 15.
2025-05-05 17:56:26 +00:00
Jason Simmons
018c6d44df
Manual roll of Dart from 5c535a368799 to a1e1e2770c1e ( #168317 )
2025-05-05 17:38:12 +00:00
Jim Graham
c1775a78a7
[Impeller] Use StrokeParameters anywhere stroke is described ( #168276 )
...
https://github.com/flutter/flutter/pull/168125 introduced
StrokeParameters to hold all of the stroke-related values, but was only
used in the rendering code. We now use it across Impeller to describe
stroke decorations.
2025-05-05 16:55:23 +00:00
engine-flutter-autoroll
16e11dbc49
Roll Fuchsia Linux SDK from UVdwr2sfg9MUYIC2S... to hjXORaFgiSd6QjK3D... ( #168286 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-04 21:21:33 +00:00
engine-flutter-autoroll
c36748ff48
Roll Fuchsia Linux SDK from vqWDpBRU-9GJgmjRr... to UVdwr2sfg9MUYIC2S... ( #168261 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-05-03 07:42:30 +00:00
Jim Graham
619c02f2a0
[Impeller] Fill/StrokePathGeometry use geom objects as path sources ( #168125 )
...
When basic rendering operations end up in a "general case" situation in
Impeller, it converts the basic shape into a path and calls `DrawPath`.
But, the creation of the path is expensive and all the mechanisms behind
drawing a path now only need a `PathSource` object which can replay the
path to them.
We now have explicit lightweight path source generators which can feed
the path drawing operations directly from the source data without having
to create a full `impeller::Path` object.
2025-05-03 00:06:37 +00:00
