Kate Lovett
9d96df2364
Modernize framework lints ( #179089 )
...
WIP
Commits separated as follows:
- Update lints in analysis_options files
- Run `dart fix --apply`
- Clean up leftover analysis issues
- Run `dart format .` in the right places.
Local analysis and testing passes. Checking CI now.
Part of https://github.com/flutter/flutter/issues/178827
- Adoption of flutter_lints in examples/api coming in a separate change
(cc @loic-sharma)
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-11-26 01:10:39 +00:00
Michael Goderbauer
5491c8c146
Auto-format Framework ( #160545 )
...
This auto-formats all *.dart files in the repository outside of the
`engine` subdirectory and enforces that these files stay formatted with
a presubmit check.
**Reviewers:** Please carefully review all the commits except for the
one titled "formatted". The "formatted" commit was auto-generated by
running `dev/tools/format.sh -a -f`. The other commits were hand-crafted
to prepare the repo for the formatting change. I recommend reviewing the
commits one-by-one via the "Commits" tab and avoiding Github's "Files
changed" tab as it will likely slow down your browser because of the
size of this PR.
---------
Co-authored-by: Kate Lovett <katelovett@google.com>
Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>
2024-12-19 20:06:21 +00:00
Jim Graham
4d0fd4f894
Fix some issues with launching E2E benchmarks and add page delays in textfield benchmarks ( #107500 )
2022-07-14 08:14:08 +00:00
Michael Goderbauer
5684b9f69e
Enable no_leading_underscores_for_local_identifiers ( #96422 )
2022-01-21 14:43:59 -08:00
Jim Graham
6c21e43608
stabilize the way we navigate multiple pages for E2E macrobenchmarks ( #96157 )
2022-01-05 10:05:05 -08:00
Jim Graham
ee204880a5
Opacity Peephole optimization benchmarks ( #94447 )
2021-12-01 01:39:02 -08:00
Darren Austin
37bc722339
Migrate dev/benchmarks/macrobenchmarks to null safety. ( #85501 )
2021-06-29 11:49:27 -07:00
Dan Field
9c0bd18c40
Reland eliminate timeouts from integration tests ( #85141 )
2021-06-23 13:08:51 -07:00
Dan Field
69f2f8a18b
Revert "Remove per-test timeouts from integration tests ( #85098 )" ( #85133 )
...
This reverts commit b96c3c22ce350cd1999066601804c50a36e97ce6.
2021-06-23 08:17:27 -07:00
Dan Field
b96c3c22ce
Remove per-test timeouts from integration tests ( #85098 )
2021-06-23 07:17:28 -07:00
Phil Quitslund
61c30c41b2
fix sort_directives violations ( #80817 )
2021-04-21 13:49:03 -07:00
Ming Lyu (CareF)
92f82c7b88
Transport e2e based perforamnce test to integration_test and remove duplicate watchPerformance ( #67594 )
2020-10-17 20:37:03 -07:00
Michael R Fairhurst
7f3c9b6bda
Remove unused 'dart:async' imports. ( #65568 )
2020-09-16 14:14:06 -07:00
Ming Lyu (CareF)
3313df9b13
ensureVisible => scrollUntilVisible ( #63983 )
2020-08-17 14:11:02 -07:00
Ming Lyu (CareF)
2384376f64
Migrate gallery/transitions_perf test to e2e ( #62064 )
2020-08-12 13:36:07 -07:00
Ming Lyu (CareF)
50828a1318
bug fix ( #62349 )
2020-07-28 18:31:04 -07:00
Ming Lyu (CareF)
056e455e94
Add a E2E based performance test case ( #61509 )
2020-07-23 08:31:04 -07:00
