Daco Harkes
6c1c25cbaf
address bad import
2026-01-22 21:57:46 +01:00
Daco Harkes
69271b90f3
Mark IconData final and @mustBeConst
2026-01-22 19:51:20 +01:00
engine-flutter-autoroll
dbed04aa32
Roll Dart SDK from 7bd4c68b625c to ab4640ea82e9 (1 revision) ( #181324 )
...
https://dart.googlesource.com/sdk.git/+log/7bd4c68b625c..ab4640ea82e9
2026-01-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-59.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-22 16:55:28 +00:00
engine-flutter-autoroll
baa9e32152
Roll Packages from d80c60eef034 to 90102991452d (9 revisions) ( #181323 )
...
d80c60eef0...9010299145jhy03261997@gmail.com [batch-release] Step2 : Publish
packages from the release branch (flutter/packages#10459 )
2026-01-21 dpxhfxywang@163.com [two_dimensional_scrollables] optimizes
tableview janks with >250k rows (flutter/packages#10738 )
2026-01-21 magder@google.com [url_launcher_ios] Migrate XCTest to Swift
Testing (flutter/packages#10780 )
2026-01-21 edpizzi@gmail.com [in_app_purchase] Fix an issue causing
StoreKit 2 transactions remain unfinished (flutter/packages#10656 )
2026-01-21 stuartmorgan@google.com [google_maps_flutter] Restructure iOS
to prep for SwiftPM (flutter/packages#10839 )
2026-01-21 jhy03261997@gmail.com [batch-release] Step3: Adds github
action to create a PR to sync changes on the go_router release branch
back to the main branch (flutter/packages#10393 )
2026-01-21 nateshmbhat1@gmail.com feat(ios): add audio track selection
support for AVFoundation (flutter/packages#10313 )
2026-01-21 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.core:core from 1.13.1 to 1.17.0 in
/packages/image_picker/image_picker_android/android
(flutter/packages#10504 )
2026-01-21 38853913+AlexDochioiu@users.noreply.github.com
[vector_graphics_compiler] Fix rgb/rgba color parsing to support modern
CSS syntax (flutter/packages#10538 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-22 15:54:07 +00:00
engine-flutter-autoroll
2dc633eb11
Roll Dart SDK from 2d53a77adc5d to 7bd4c68b625c (2 revisions) ( #181316 )
...
https://dart.googlesource.com/sdk.git/+log/2d53a77adc5d..7bd4c68b625c
2026-01-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-58.0.dev
2026-01-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-57.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-22 11:32:39 +00:00
engine-flutter-autoroll
b1292de731
Roll Skia from 3f6949bc5780 to 6e9746be8c4a (2 revisions) ( #181311 )
...
https://skia.googlesource.com/skia.git/+log/3f6949bc5780..6e9746be8c4a
2026-01-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 5e75ee90603d to ae18e4e9f317 (8 revisions)
2026-01-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from d5e81edf7a6a to c270c40ffe5c (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,jlavrova@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-22 08:51:48 +00:00
engine-flutter-autoroll
4dc0e2a7e2
Roll Skia from ef6efc358b4a to 3f6949bc5780 (2 revisions) ( #181307 )
...
https://skia.googlesource.com/skia.git/+log/ef6efc358b4a..3f6949bc5780
2026-01-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from c30843e52d7c to 35d0f11eaa71 (16 revisions)
2026-01-21 ccameron@chromium.org skhdr::AdaptiveGlobalToneMap: Use F16
textures
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,jlavrova@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-22 06:34:00 +00:00
engine-flutter-autoroll
0ba797b8da
Roll Dart SDK from 5d7c8faf2e41 to 2d53a77adc5d (1 revision) ( #181305 )
...
https://dart.googlesource.com/sdk.git/+log/5d7c8faf2e41..2d53a77adc5d
2026-01-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-56.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-22 05:09:37 +00:00
Marijua ރ
3feca0c152
[Material] update hourFormat to use Dart 3 switch expression ( #181041 )
...
While I was looking through `time.dart`, I noticed that `hourFormat` was
still using the old switch-case style with a lot of boilerplate. Since
we are moving towards Dart 3 patterns, I thought it'd be a good idea to
swap this out for a switch expression. It's much cleaner now and handles
the `TimeOfDayFormat` mapping in just a few lines.
I also realized there weren't any direct tests for this specific
function (it was mostly covered by larger integration tests), so I added
a small test group in `time_test.dart` to make sure every enum value
maps to the right `HourFormat` correctly.
This is a trivial internal refactor and does not fix a specific bug
report, so no issue is linked.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA]. (I will sign it once the bot prompts me)
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2026-01-22 04:10:46 +00:00
Brahim GUAALI
758db16cc6
Use null-aware elements in cupertino/nav_bar.dart ( #181237 )
...
## Description
Adopts null-aware element syntax (`?x`) in `cupertino/nav_bar.dart`,
replacing 16 instances of the verbose `if (x != null) x!` pattern in the
`_NavigationBarTransition` widget's children list.
Fixes https://github.com/flutter/flutter/issues/172188
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
[Contributor Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md
[](https://www.talabat.com )
[](https://github.com/search?q=org%3Aflutter+talabat&type=pullrequests )
2026-01-22 01:44:06 +00:00
engine-flutter-autoroll
a179188e81
Roll Fuchsia Linux SDK from b2KIEXVAlEqImQ9VO... to b4cLyhuxciUC-4zCJ... ( #181297 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC aaclarke@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-22 01:42:26 +00:00
flutter-pub-roller-bot
800b2bda8e
Roll pub packages ( #181295 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2026-01-22 00:25:24 +00:00
gaaclarke
867339e934
Enables fragment shader test for impeller (fixes mat2 on vulkan) ( #181013 )
...
This rearranges the packing of mat2 fields in structs which was causing
an existing fragment shader test to fail.
The test still doesn't work on Metal, but this PR fixes it for Vulkan. I
suspect the fix for metal may be similar but since the uniforms aren't
in a virtual struct the code isn't hitting this fix.
issue: https://github.com/flutter/flutter/issues/180873
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-01-22 00:13:33 +00:00
engine-flutter-autoroll
f86c64b4ae
Roll Dart SDK from 366200db1aa1 to 5d7c8faf2e41 (4 revisions) ( #181290 )
...
https://dart.googlesource.com/sdk.git/+log/366200db1aa1..5d7c8faf2e41
2026-01-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-55.0.dev
2026-01-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-54.0.dev
2026-01-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-53.0.dev
2026-01-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-52.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-21 23:36:22 +00:00
engine-flutter-autoroll
a97a6e683b
Roll Skia from b5ec89e31f59 to ef6efc358b4a (19 revisions) ( #181289 )
...
https://skia.googlesource.com/skia.git/+log/b5ec89e31f59..ef6efc358b4a
2026-01-21
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2026-01-21 kjlubick@google.com Revert "Prep for removing legacy
SK_USE_VMA logic"
2026-01-21 borenet@google.com Reland "[infra] Add tasks for M4 Mac
Minis"
2026-01-21 robertphillips@google.com [graphite] Fix component masks for
FromImmutableSamplerInfo
2026-01-21 borenet@google.com [infra] Add tasks for Corsola devices
2026-01-21 borenet@google.com Revert "[infra] Add tasks for M4 Mac
Minis"
2026-01-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from c159d041dce0 to 5e75ee90603d (3 revisions)
2026-01-21
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2026-01-21 kjlubick@google.com Delete SkImagePriv
2026-01-21 kjlubick@google.com Remove legacy VMA fields from Graphite's
context options
2026-01-21 borenet@google.com [infra] Add tasks for M4 Mac Minis
2026-01-21 kjlubick@google.com Prep for removing legacy SK_USE_VMA logic
2026-01-21 kjlubick@google.com Make Window::BackendType an enum class
2026-01-21 bungeman@google.com Fix reference leak in
SkImage_Raster::MakeFromBitmap
2026-01-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 504e18291936 to 79314d8b7b7f (15 revisions)
2026-01-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 8274e392beb2 to d5e81edf7a6a (5 revisions)
2026-01-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from c82a1f06439a to c30843e52d7c (14 revisions)
2026-01-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from ec2d660b6a45 to c159d041dce0 (4 revisions)
2026-01-21
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,jlavrova@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-21 23:11:02 +00:00
Navaron Bracke
b4a23495b4
fix description for semantics finders ( #181214 )
...
Fixes https://github.com/flutter/flutter/issues/181196
This PR fixes the description for the bySemanticsLabel/Identifier
matchers, which was missing.
Note: The framework uses `byElementPredicate()` in a bunch of places in
tests, but not all use the `description` field.
Should we add descriptions to those?
Example:
```dart
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
void main() {
testWidgets('bySemanticsLabel', (tester) async {
await tester.pumpWidget(const MaterialApp(home: Text('hello')));
await tester.pumpAndSettle();
expect(find.bySemanticsLabel('goodbye'), findsOneWidget);
});
testWidgets('bySemanticsLabel regex', (tester) async {
await tester.pumpWidget(const MaterialApp(home: Text('hello')));
await tester.pumpAndSettle();
expect(find.bySemanticsLabel(RegExp('^foo')), findsOneWidget);
});
testWidgets('bySemanticsIdentifier', (tester) async {
await tester.pumpWidget(const MaterialApp(home: Text('hello')));
await tester.pumpAndSettle();
expect(find.bySemanticsIdentifier('goodbye'), findsOneWidget);
});
testWidgets('bySemanticsIdentifier regex', (tester) async {
await tester.pumpWidget(const MaterialApp(home: Text('hello')));
await tester.pumpAndSettle();
expect(find.bySemanticsIdentifier(RegExp('^foo')), findsOneWidget);
});
}
```
now gives:
```dart
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure was thrown running a test:
Expected: exactly one matching candidate
Actual: _ElementPredicateWidgetFinder:<Found 0 widgets with a semantics label named "goodbye": []>
Which: means none were found but one was expected
When the exception was thrown, this was the stack:
#4 main.<anonymous closure> (file:///Users/navaronbracke/Desktop/matchers_test/test/widget_test.dart:8:5)
<asynchronous suspension>
#5 testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:192:15)
<asynchronous suspension>
#6 TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:1692:5)
<asynchronous suspension>
<asynchronous suspension>
(elided one frame from package:stack_trace)
This was caught by the test expectation on the following line:
file:///Users/navaronbracke/Desktop/matchers_test/test/widget_test.dart line 8
The test description was:
bySemanticsLabel
════════════════════════════════════════════════════════════════════════════════════════════════════
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure was thrown running a test:
Expected: exactly one matching candidate
Actual: _ElementPredicateWidgetFinder:<Found 0 widgets with a semantics label matching the pattern
"^foo": []>
Which: means none were found but one was expected
When the exception was thrown, this was the stack:
#4 main.<anonymous closure> (file:///Users/navaronbracke/Desktop/matchers_test/test/widget_test.dart:14:5)
<asynchronous suspension>
#5 testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:192:15)
<asynchronous suspension>
#6 TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:1692:5)
<asynchronous suspension>
<asynchronous suspension>
(elided one frame from package:stack_trace)
This was caught by the test expectation on the following line:
file:///Users/navaronbracke/Desktop/matchers_test/test/widget_test.dart line 14
The test description was:
bySemanticsLabel regex
════════════════════════════════════════════════════════════════════════════════════════════════════
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure was thrown running a test:
Expected: exactly one matching candidate
Actual: _ElementPredicateWidgetFinder:<Found 0 widgets with a semantics identifier named
"goodbye": []>
Which: means none were found but one was expected
When the exception was thrown, this was the stack:
#4 main.<anonymous closure> (file:///Users/navaronbracke/Desktop/matchers_test/test/widget_test.dart:20:5)
<asynchronous suspension>
#5 testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:192:15)
<asynchronous suspension>
#6 TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:1692:5)
<asynchronous suspension>
<asynchronous suspension>
(elided one frame from package:stack_trace)
This was caught by the test expectation on the following line:
file:///Users/navaronbracke/Desktop/matchers_test/test/widget_test.dart line 20
The test description was:
bySemanticsIdentifier
════════════════════════════════════════════════════════════════════════════════════════════════════
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure was thrown running a test:
Expected: exactly one matching candidate
Actual: _ElementPredicateWidgetFinder:<Found 0 widgets with a semantics identifier matching the
pattern "^foo": []>
Which: means none were found but one was expected
When the exception was thrown, this was the stack:
#4 main.<anonymous closure> (file:///Users/navaronbracke/Desktop/matchers_test/test/widget_test.dart:26:5)
<asynchronous suspension>
#5 testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:192:15)
<asynchronous suspension>
#6 TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:1692:5)
<asynchronous suspension>
<asynchronous suspension>
(elided one frame from package:stack_trace)
This was caught by the test expectation on the following line:
file:///Users/navaronbracke/Desktop/matchers_test/test/widget_test.dart line 26
The test description was:
bySemanticsIdentifier regex
════════════════════════════════════════════════════════════════════════════════════════════════════
```
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-01-21 23:11:00 +00:00
Ahmed Mohamed Sameh
d947e1ab3a
Make sure that an Icon doesn't crash in 0x0 environment ( #181021 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the Icon widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2026-01-21 22:58:24 +00:00
Ahmed Mohamed Sameh
3f9dff2a8e
Make sure that a GridPaper doesn't crash in 0x0 environment ( #180906 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the GridPaper widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2026-01-21 22:44:06 +00:00
Jenn Magder
a5f4d392a5
Bring Linux coverage out of bringup ( #181280 )
...
Marked as bringup as of #174171 . With the new dashboard level flake
suppression, it will no longer take a long time to mark things as flaky.
Also, this seems to be running on every commit now?
2026-01-21 22:20:40 +00:00
Jenn Magder
c7b999d8c4
Marks Mac_mokey microbenchmarks to be unflaky ( #181276 )
...
The issue https://github.com/flutter/flutter/issues/174101 has been
closed, and the test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_mokey%20microbenchmarks%22 ).
This test can be marked as unflaky.
https://github.com/flutter/flutter/pull/175488 should have been landed.
2026-01-21 22:20:40 +00:00
Jenn Magder
82eac0a2d3
Marks drive_perf_debug_warning to be unflaky ( #181277 )
...
Infra issue has resolved
https://github.com/flutter/flutter/issues/174111 , and the test has been
passing for [50 consecutive
runs](https://data.corp.google.com/sites/dash_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20drive_perf_debug_warning%22 ).
2026-01-21 22:20:39 +00:00
Daco Harkes
28243abb5c
[packages_autoroller] Migrate to dart build cli ( #181273 )
...
Bug:
* https://github.com/flutter/flutter/issues/181265
Tested locally `$ ./dev/packages_autoroller/run --token token.txt` and
commenting out all the GitHub stuff:
```
[...]
Executing [/Users/dacoharkes/src/flutter/package_autoroller_checkouts/framework/bin/dart, build, cli, --target, /Users/dacoharkes/src/flutter/package_autoroller_checkouts/framework/dev/tools/bin/generate_gradle_lockfiles.dart, -o, /var/folders/jc/4znngjfn6f7cxghhg0027rnh00klzg/T/zDK1S4]...
The `dart build cli` command is in preview at the moment.
See documentation on https://dart.dev/interop/c-interop#native-assets .
Deleting output directory: /var/folders/jc/4znngjfn6f7cxghhg0027rnh00klzg/T/zDK1S4/.
Generated: /var/folders/jc/4znngjfn6f7cxghhg0027rnh00klzg/T/zDK1S4/bundle/bin/generate_gradle_lockfiles
Executing [/Users/dacoharkes/src/flutter/package_autoroller_checkouts/framework/bin/flutter, --verbose, update-packages, --force-upgrade]...
[ +19 ms] executing: sysctl hw.optional.arm64
[...]
```
2026-01-21 21:30:16 +00:00
Camille Simon
3f2548bf17
Remove bringup flag from Mac_arm64_mokey task ( #178759 )
...
Removed the 'bringup' flag from Mac_arm64_mokey task due to flakiness.
The flakiness seems to be fixedb y
https://github.com/flutter/flutter/pull/180645 .
Fixes https://github.com/flutter/flutter/issues/177384 .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-01-21 20:58:18 +00:00
Rusino
3b20617345
Fixing getPositionForOffset ( #180913 )
...
It had few bugs and also baseline APIs for WebParagraph were not
implemented (they make little sense but still)
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Dmitry Grand <dmgr@google.com>
2026-01-21 20:25:58 +00:00
Mohellebi abdessalem
e9ec7d0e46
Remove unused UrlStringAttribute class ( #181146 )
...
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-01-21 18:30:10 +00:00
Kostia Sokolovskyi
697572a67c
[Android] Add display corner radii support. ( #179219 )
...
Closes https://github.com/flutter/flutter/issues/97349
Unblocks https://github.com/flutter/flutter/issues/178463
### Description
This PR focuses only on the Android side.
As was discussed in https://github.com/flutter/flutter/issues/97349 , the
iOS API for getting display corner radii is private. The only safe way
to get the radii values is to generate a lookup table ahead and use its
values at runtime. I would be happy to work on the iOS implementation in
a separate PR after this lands.
- Adds `displayCornerRadii` in the physical pixels to the engine's
window metrics
- Adds `displayCornerRadii` support on the Android API 31+
- Adds `displayCornerRadii` in the logical pixels to the `MediaQuery`
- Adds and updates tests
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Matt Boetger <matt.boetger@gmail.com>
2026-01-21 18:13:00 +00:00
engine-flutter-autoroll
63debd3a2e
Roll Packages from 0af57367d3a0 to d80c60eef034 (3 revisions) ( #181255 )
...
0af57367d3...d80c60eef0flutter/packages#10626 )
2026-01-20 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.exifinterface:exifinterface from 1.4.1 to
1.4.2 in /packages/image_picker/image_picker_android/android
(flutter/packages#10584 )
2026-01-20 8014077+Frank3K@users.noreply.github.com [google_fonts] Add
WOFF and WOFF2 font format support for web (flutter/packages#10703 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-21 18:12:58 +00:00
Mohellebi abdessalem
3b666a04d6
Add RawTooltipl example and test ( #180722 )
...
Fixes : #180318
Relands #180691 (because of CLA issues).
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2026-01-21 18:12:56 +00:00
Ahmed Mohamed Sameh
be2f3bd443
Make sure that a Focus doesn't crash in 0x0 environment ( #180674 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the Focus widget.
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2026-01-21 18:12:56 +00:00
engine-flutter-autoroll
ac069ade5c
Roll Dart SDK from 71a854679d60 to 366200db1aa1 (2 revisions) ( #181227 )
...
https://dart.googlesource.com/sdk.git/+log/71a854679d60..366200db1aa1
2026-01-21 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-51.0.dev
2026-01-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-50.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-21 18:11:12 +00:00
engine-flutter-autoroll
35c7f5b0b3
Roll Skia from 2e836c59871c to b5ec89e31f59 (2 revisions) ( #181230 )
...
https://skia.googlesource.com/skia.git/+log/2e836c59871c..b5ec89e31f59
2026-01-21
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2026-01-20
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,jlavrova@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-21 18:07:01 +00:00
bungeman
9c66d267b4
Use SkPathBuilder with SkPathMeasure::getSegment ( #181205 )
...
Migrate calls from the now deprecated SkPathMeasure::getSegment which
took SkPath to the new version of SkPathMeasure::getSegment which takes
SkPathBuilder.
2026-01-21 16:01:29 +00:00
flutter-pub-roller-bot
3159262da5
Roll pub packages ( #181226 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2026-01-21 01:22:59 +00:00
engine-flutter-autoroll
ad4c6f23fc
Roll Skia from 5632ec06fe24 to 2e836c59871c (11 revisions) ( #181220 )
...
https://skia.googlesource.com/skia.git/+log/5632ec06fe24..2e836c59871c
2026-01-20 kjlubick@google.com Relocate all functionality in
SkImagePriv.h to better homes
2026-01-20 bungeman@google.com Remove SkGradientShader.h and
SK_SUPPORT_LEGACY_UNSPANNED_GRADIENTS
2026-01-20 kjlubick@google.com Remove fVulkanVMALargeHeapBlockSize
2026-01-20 ccameron@chromium.org skhdr::AdaptiveGlobalToneMap: Add
operator==
2026-01-20 bungeman@google.com Use newer path utilities which take
SkPathBuilder
2026-01-20 michaelludwig@google.com Reland "[graphite] Stage SampleCount
enum with uint assignment"
2026-01-20
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2026-01-20 kjlubick@google.com Fix viewer in ganesh-vulkan-only mode
2026-01-20
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2026-01-20 fmalita@google.com Don't discard existing dest path content
in mutable path effects
2026-01-20 egdaniel@google.com Fix initializaiton of
VulkanCaps::DepthStencilFormatInfo.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,jlavrova@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-21 01:06:16 +00:00
Kate Lovett
8f1e2e4ebf
Update triage docs ( #181193 )
...
* Turns down `team-games`. Already confirmed triage bot updated and
triage team notified.
* Updates text input and guidance links wrt selection issues.
* Adds omitted teams from untriaged link
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-01-21 00:52:20 +00:00
Emmanuel
d20a814fcb
Add RenderSliver.getMaxPaintRect ( #180074 )
...
This PR extracts the `getMaxPaintRect` logic into a shared method in
`RenderSliver`. This helper is required for upcoming changes in #179003
and #179802 to avoid code duplication.
Cc @Piinks
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
2026-01-21 00:42:23 +00:00
Ahmed Mohamed Sameh
7401f6a7b0
Make sure that a Form doesn't crash in 0x0 environment ( #180792 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the Form widget.
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2026-01-20 23:27:29 +00:00
Ahmed Mohamed Sameh
93ef5e43be
Make sure that an AnimatedSwitcher doesn't crash in 0x0 environment ( #180190 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the AnimatedSwitcher
widget.
---------
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Victor Sanni <victorsanniay@gmail.com>
2026-01-20 23:08:22 +00:00
engine-flutter-autoroll
77fe5570e0
Roll Fuchsia Linux SDK from HbQLVKwpmWqrOLAVY... to b2KIEXVAlEqImQ9VO... ( #181212 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC aaclarke@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-20 22:07:13 +00:00
Mairramer
c6fad7ac6d
Add leadingIndex to CarouselController and onItemChanged to CarouselView ( #180667 )
...
Adds a `leadingIndex` property to CarouselController and an
`onItemChanged` callback to CarouselView.
Closes #169207
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-01-20 21:19:17 +00:00
Mohellebi abdessalem
d28a513d4c
Improve code quality in ViewUtils.java ( #181147 )
...
<img width="512" height="98" alt="Screenshot 2026-01-19 at 11 09 21"
src="https://github.com/user-attachments/assets/d2739ba7-7da8-494f-aded-079b50129a93 "
/>
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-01-20 19:17:20 +00:00
Kaylee Lubick
ca81cdf9f9
[skia] Remove VMA from build logic ( #181183 )
...
Skia is disabling the automatic use of an internal Vulkan Memory
Allocator when no memory allocator is specified.
Flutter already [disables
VMA](ae5c3603d0/tools/gn (L615)https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-01-20 20:57:53 +00:00
engine-flutter-autoroll
8cbe1be5e6
Roll Skia from 320dd956168a to 5632ec06fe24 (7 revisions) ( #181191 )
...
https://skia.googlesource.com/skia.git/+log/320dd956168a..5632ec06fe24
2026-01-20 bungeman@google.com Remove SkDeserialProcs::fTypefaceProc
2026-01-20 michaelludwig@google.com [graphite] Add
InsertStatus::kOutOfOrderRecording
2026-01-20 michaelludwig@google.com Revert "[graphite] Stage SampleCount
enum with uint assignment"
2026-01-20 michaelludwig@google.com Reland "[wgsl] Apply array polyfills
in synthetic sksl tests correctly"
2026-01-20 ccameron@chromium.org
skhdr::Metadata::makeToneMapColorFilter: Complete shader implementation
2026-01-20 kjlubick@google.com Add version of Ganesh Vulkan build rules
w/o VMA
2026-01-20 mike@reedtribe.org don't overalloc space for pathdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,jlavrova@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-20 18:59:17 +00:00
Mohellebi abdessalem
e0d238e9f8
Remove unnecessary Integer.toString in FlutterShellArgs.java ( #180993 )
...
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-01-20 18:51:18 +00:00
Tong Mu
5d93b2e71b
Improve the algorithm for rounded superellipse paths to work better at very large ratio ( #180453 )
...
This PR uses a new algorithm that approximates the superellipse curve
with two conic curves, instead of one cubic curves. This algorithm works
much better at very large ratio. Fixes
https://github.com/flutter/flutter/issues/179875 .
A new playground is added in this PR to show enlarged corner of a
rounded superellipse at very large ratio and compares its path version
and filled version.
<details>
<summary>
For comparison: The best result possible with one cubic curve
</summary>
As the following video shows, the flat segment of the superellipse curve
is the hardest to approximate, since most of its curvature happens near
the right end. The best that a single cubic curve can do is close to a
straight line.
https://github.com/user-attachments/assets/2ed1666d-f96c-4465-9d5c-1f8f4a660bba
Although the largest deviation is only ~1e-6, the "feeling" from the
lack of curvature is sensible as shown in the following screenshot.
<img width="476" height="543" alt="image"
src="https://github.com/user-attachments/assets/6e6b96ed-80b3-487c-b621-3cddd4537ec0 "
/>
</details>
**Result after this PR:**
https://github.com/user-attachments/assets/d0012e62-f61f-4d69-95a5-27646c0bb750
The following screenshot shows the reproduction app as commented in
https://github.com/flutter/flutter/issues/179875#issuecomment-3672426282
after the PR:
<img width="476" height="543" alt="image"
src="https://github.com/user-attachments/assets/d93b83be-a9fc-4b25-aca2-0e2c3f9a7e56 "
/>
For comparison, the following screenshot shows the same shape drawn as
filled:
<img width="476" height="543" alt="image"
src="https://github.com/user-attachments/assets/bf94a20a-278b-42a2-9162-5aa4a61915af "
/>
**Before the PR:**
<img width="1024" height="796" alt="image"
src="https://github.com/user-attachments/assets/053cc229-01f1-4181-97a6-48b96bf16fcf "
/>
Also, a new golden test:
<img width="2400" height="1800" alt="image"
src="https://github.com/user-attachments/assets/6e741066-89a3-4282-bdc2-fa02b1eea14d "
/>
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-01-20 18:36:24 +00:00
engine-flutter-autoroll
ea614598f1
Roll Dart SDK from 2b14627b1843 to 71a854679d60 (2 revisions) ( #181185 )
...
https://dart.googlesource.com/sdk.git/+log/2b14627b1843..71a854679d60
2026-01-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-49.0.dev
2026-01-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-48.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-20 18:28:56 +00:00
Mohellebi abdessalem
7feeea6720
Remove unnecessary String.valueOf in FlutterJNI.java ( #180995 )
...
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-01-20 18:23:19 +00:00
Kaylee Lubick
2d7c3105aa
[skia] Use renamed GNI filegroup ( #180853 )
...
Skia renamed this GNI file group to emphasize this is only libpng (and
not rust png).
https://review.skia.org/1139996
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-01-20 17:31:41 +00:00
aaazlkm
1d70a351c9
Enhance Hero widget with customizable animation curves ( #180100 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
Follow-up to #159393 (closed due to inactivity).
Implements the same feature with changes based on the previous review
feedback.
Related issue: https://github.com/flutter/flutter/issues/26150
## Screenshot
Using elasticOut because the difference was hard to see with
fastOutSlowIn.
<table>
<tr>
<th>curve=elasticOut, reverseCurve=null</th>
<th>curve=elasticOut, reverseCurve=linear</th>
</tr>
<tr>
<td>
<video
src="https://github.com/user-attachments/assets/c8c39fb0-e677-471e-ac2a-2a062277ae48 "
controls muted loop width="320"></video>
</td>
<td>
<video
src="https://github.com/user-attachments/assets/1f39d0a8-ed80-4404-b766-38844cca3909 "
controls muted loop width="320"></video>
</td>
</tr>
</table>
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-01-20 16:50:50 +00:00
engine-flutter-autoroll
4628fdbcde
Roll Skia from 69780e390b46 to 320dd956168a (1 revision) ( #181178 )
...
https://skia.googlesource.com/skia.git/+log/69780e390b46..320dd956168a
2026-01-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 0a57d907cc4f to ec2d660b6a45 (2 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com ,jlavrova@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-20 15:40:31 +00:00
