Casey Hillers
a2d6c74bce
[CP] Roll engine to 9654265 ( #130518 )
...
b/291026973 - Apply revert to Google roll
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.
3.13.0-3.0.pre
2023-07-13 13:53:55 -07:00
engine-flutter-autoroll
47ba59c762
Roll Flutter Engine from 16e2ab7e986c to 1b1ccdd1f527 (13 revisions) ( #130458 )
...
16e2ab7e98...1b1ccdd1f5
2023-07-12 skia-flutter-autoroll@skia.org Roll Skia from 4e989b1564ee to bedc92598644 (1 revision) (flutter/engine#43617 )
2023-07-12 flar@google.com move rtree and canvas_spy sources to Fuchsia sub-directory (flutter/engine#43615 )
2023-07-12 skia-flutter-autoroll@skia.org Roll Skia from 68e3c0b3eea7 to 4e989b1564ee (6 revisions) (flutter/engine#43614 )
2023-07-12 ian@hixie.ch Document (and assert) that channel names can't contains nulls (flutter/engine#43593 )
2023-07-12 58529443+srujzs@users.noreply.github.com Reland "Refactor JSNumber.toDart and Object.toJS" (flutter/engine#43363 )
2023-07-12 31859944+LongCatIsLooong@users.noreply.github.com Add a flag to `ParagraphBuilder` for rounding hack migration (flutter/engine#43118 )
2023-07-12 john@johnmccutchan.com [Impeller] Fixes for asymmetric stencil descriptors (flutter/engine#43535 )
2023-07-12 skia-flutter-autoroll@skia.org Roll Skia from adeeb8d50f7c to 68e3c0b3eea7 (1 revision) (flutter/engine#43609 )
2023-07-12 flar@google.com Add comment to use of 3x3 mapRect in TransformLayer (flutter/engine#43608 )
2023-07-12 skia-flutter-autoroll@skia.org Roll Skia from a251a36ea519 to adeeb8d50f7c (1 revision) (flutter/engine#43606 )
2023-07-12 skia-flutter-autoroll@skia.org Roll Dart SDK from b95f6531c726 to 8f8f281ccdc6 (2 revisions) (flutter/engine#43607 )
2023-07-12 skia-flutter-autoroll@skia.org Roll Skia from ebc149cff431 to a251a36ea519 (2 revisions) (flutter/engine#43604 )
2023-07-12 jonahwilliams@google.com [Impeller] Use new SkParagraph APIs for stroked text. (flutter/engine#41735 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-13 00:46:57 +00:00
LongCatIsLooong
2da353a59a
Exclude Tooltip's overlay child from SelectableRegion ( #130181 )
...
Fixes https://github.com/flutter/flutter/issues/129969 by making tooltip text unselectable (for now).
Also fixes some other issues uncovered when I was writing the tests.
Currently `getTransformTo` only works on ancestors. I'll try to add a new method that computes the transform from 2 arbitrary render objects in the same render tree in a follow-up PR and make `Selectable` use that method instead.
2023-07-13 00:35:57 +00:00
Qun Cheng
dd0b6e35f3
Update Checkbox tests for M2/M3 ( #130351 )
...
Updated unit tests for `Checkbox` to have M2 and M3 versions.
More info in #127064
2023-07-12 22:27:37 +00:00
Srujan Gaddam
ab39bff282
Refactor JSNumber.toDart and Object.toJS ( #129436 )
...
JSNumber.toDart will now be two functions: toDartDouble and toDartInt.
There was code that did an Object.toJS. This has been changed to
use Function.toJS as well to make it consistent with the code
in flutter/packages:
0ef393811d/packages/web_benchmarks/lib/src/recorder.dart (L1223)
This is to help land this CL:
https://dart-review.googlesource.com/c/sdk/+/309082
https://dart-review.googlesource.com/c/sdk/+/309081 is the CL that added
the new methods.
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
2023-07-12 13:54:15 -07:00
Gil Nobrega
a189d95ac2
Reland [a11y] CupertinoSwitch On/Off labels ( #130173 )
...
This original PR (https://github.com/flutter/flutter/pull/127776 ) was reverted (https://github.com/flutter/flutter/pull/130166 ) due to a Google test failure.
This reopens the PR as per the discussion in https://github.com/flutter/flutter/pull/130166#issuecomment-1626105218 .
Fixes issue #4830 .
2023-07-12 20:50:18 +00:00
Greg Spencer
3d67ca4311
Add missing links to examples that aren't linked anywhere ( #130422 )
...
## Description
This adds links to examples that were not linked anywhere.
## Related Issues
- Fixes #129956
## Tests
- Documentation only change
2023-07-12 20:08:05 +00:00
Tae Hyung Kim
d75735eea6
Use platform specific line separator in gen-l10n ( #130090 )
...
Currently files are not generated with `\r\n` in windows. This PR should
fix the issue.
Fixes https://github.com/flutter/flutter/issues/109761 .
2023-07-12 12:50:53 -07:00
Taha Tesser
42924e275b
Update Divider/VerticalDivider and theme tests for M2/M3 ( #130415 )
...
Updated unit tests for `Divider`/ `VerticalDivider` and theme to have M2 and M3 versions.
More info in https://github.com/flutter/flutter/pull/128725
2023-07-12 17:25:20 +00:00
engine-flutter-autoroll
58acd6099e
Roll Flutter Engine from 5c887028810d to 16e2ab7e986c (2 revisions) ( #130421 )
...
5c88702881...16e2ab7e98
2023-07-12 skia-flutter-autoroll@skia.org Roll Skia from ac4c113c071d to ebc149cff431 (4 revisions) (flutter/engine#43603 )
2023-07-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from zTuZjXzI3bqscWmeo... to 1STsUj0X5YgpiSNEb... (flutter/engine#43602 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from zTuZjXzI3bqs to 1STsUj0X5Ygp
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-12 17:13:25 +00:00
engine-flutter-autoroll
544d30dbad
Roll Packages from 188a8468f557 to 250871431bed (14 revisions) ( #130418 )
...
188a8468f5...250871431b
2023-07-12 39314023+wer-mathurin@users.noreply.github.com ADD appBarBreakpoint (flutter/packages#4434 )
2023-07-12 engine-flutter-autoroll@skia.org Roll Flutter from 65ff3cb9b45c to 3ec96a8a4a5d (5 revisions) (flutter/packages#4415 )
2023-07-12 tarrinneal@gmail.com [image_picker] Roll dependancies to avoid error (flutter/packages#4431 )
2023-07-12 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump com.android.billingclient:billing from 6.0.0 to 6.0.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#4422 )
2023-07-12 ditman@gmail.com [file_selector] Avoids using path_provider in web example app. (flutter/packages#4445 )
2023-07-12 ian@hixie.ch [rfw] Add some more documentation for RFW (flutter/packages#4349 )
2023-07-12 stuartmorgan@google.com [ci] Enable LUCI legacy analysis (flutter/packages#4435 )
2023-07-11 ian@hixie.ch [webview_flutter_wkwebview] NSError.toString (flutter/packages#4441 )
2023-07-11 stuartmorgan@google.com [ci] Remove unused Chromium setup (flutter/packages#4437 )
2023-07-11 ian@hixie.ch [flutter_plugin_tools] Reimplements the excerpt system inline in the tool, rather than relying on a separate package. (flutter/packages#4417 )
2023-07-11 10687576+bparrishMines@users.noreply.github.com [ci] Remove webview_flutter implementation opt outs for custom analysis (flutter/packages#4438 )
2023-07-11 stuartmorgan@google.com [palette_generator] Add web support to unit tests (flutter/packages#4440 )
2023-07-11 stuartmorgan@google.com [tool] Conditionalize color on `stdout` (flutter/packages#4436 )
2023-07-11 47866232+chunhtai@users.noreply.github.com [go_router_builder] Cleans up builder code. (flutter/packages#4356 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-12 16:23:19 +00:00
Taha Tesser
21e3bb8967
Update RadioListTile tests format for M2/M3 ( #130391 )
...
Update tests format
context: https://github.com/flutter/flutter/pull/129718#issuecomment-1615124857
2023-07-12 15:47:51 +00:00
engine-flutter-autoroll
21fa18b3fe
Roll Flutter Engine from d68ea304eeda to 5c887028810d (2 revisions) ( #130413 )
...
d68ea304ee...5c88702881
2023-07-12 skia-flutter-autoroll@skia.org Roll Skia from 9038aec6a23a to ac4c113c071d (1 revision) (flutter/engine#43600 )
2023-07-12 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from LV7zVdnjfEPukVG8L... to 0fvk838jTDNQ_l43k... (flutter/engine#43599 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from LV7zVdnjfEPu to 0fvk838jTDNQ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-12 15:08:00 +00:00
engine-flutter-autoroll
ba6009bcca
Roll Flutter Engine from c7317a58466e to d68ea304eeda (1 revision) ( #130410 )
...
c7317a5846...d68ea304ee
2023-07-12 skia-flutter-autoroll@skia.org Roll Skia from 6a8be5964fbe to 9038aec6a23a (1 revision) (flutter/engine#43598 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-12 14:18:07 +00:00
engine-flutter-autoroll
1d50000a10
Roll Flutter Engine from 3dbe7dbeb5d4 to c7317a58466e (1 revision) ( #130402 )
...
3dbe7dbeb5...c7317a5846
2023-07-12 skia-flutter-autoroll@skia.org Roll Skia from 0fb595ccc6a7 to 6a8be5964fbe (1 revision) (flutter/engine#43597 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-12 12:45:25 +00:00
engine-flutter-autoroll
1a14dda88c
Roll Flutter Engine from 73093fdd77c3 to 3dbe7dbeb5d4 (1 revision) ( #130399 )
...
73093fdd77...3dbe7dbeb5
2023-07-12 skia-flutter-autoroll@skia.org Roll Skia from 0ac60b2cecfe to 0fb595ccc6a7 (1 revision) (flutter/engine#43596 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-12 10:58:05 +00:00
engine-flutter-autoroll
ac8e8027bd
Roll Flutter Engine from 29c5c41eeb19 to 73093fdd77c3 (2 revisions) ( #130398 )
...
29c5c41eeb...73093fdd77
2023-07-12 flar@google.com header file cleanup focusing on removing unnecessary SkPicture includes (flutter/engine#43589 )
2023-07-12 bdero@google.com [Impeller] Document ColorSourceContents (flutter/engine#43590 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-12 10:16:25 +00:00
engine-flutter-autoroll
485e79dea7
Roll Flutter Engine from 3482e05776a7 to 29c5c41eeb19 (1 revision) ( #130393 )
...
3482e05776...29c5c41eeb
2023-07-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 51d6128b190e to b95f6531c726 (2 revisions) (flutter/engine#43594 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-12 09:31:36 +00:00
engine-flutter-autoroll
7decd77d0e
Roll Flutter Engine from 7de68c62742d to 3482e05776a7 (2 revisions) ( #130390 )
...
7de68c6274...3482e05776
2023-07-12 skia-flutter-autoroll@skia.org Roll Skia from af2a829258a0 to 0ac60b2cecfe (2 revisions) (flutter/engine#43592 )
2023-07-12 skia-flutter-autoroll@skia.org Roll Skia from 33cfa4fc2aeb to af2a829258a0 (1 revision) (flutter/engine#43591 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-12 08:39:13 +00:00
huycozy
fd720fab03
Make new issue template for 1P package ( #130065 )
...
Closes https://github.com/flutter/flutter/issues/117750 .
### Demo
<details>
<summary>Preview screenshot</summary>

</details>
Demo issue template: [Report a bug in Flutter's first party package](https://github.com/huycozy/flutter/issues/new?assignees=&labels=&projects=&template=9_first_party_packages.yml )
Demo a filed issue: https://github.com/huycozy/flutter/issues/2
2023-07-12 07:47:05 +00:00
engine-flutter-autoroll
10189d1a30
Roll Flutter Engine from 1b44d7ee1a60 to 7de68c62742d (4 revisions) ( #130384 )
...
1b44d7ee1a...7de68c6274
2023-07-12 skia-flutter-autoroll@skia.org Roll Skia from 7b0d85cff28a to 33cfa4fc2aeb (1 revision) (flutter/engine#43586 )
2023-07-12 skia-flutter-autoroll@skia.org Roll Skia from d0ecba6d753c to 7b0d85cff28a (1 revision) (flutter/engine#43585 )
2023-07-12 chinmaygarde@google.com [Impeller] Remove un-actionable info log about validations. (flutter/engine#43575 )
2023-07-12 chinmaygarde@google.com [Impeller] Create a resource manager that batch deallocates resources on a dedicated thread. (flutter/engine#43579 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-12 06:58:09 +00:00
engine-flutter-autoroll
1d30e3e4fb
Roll Flutter Engine from e109a3c0c347 to 1b44d7ee1a60 (3 revisions) ( #130380 )
...
e109a3c0c3...1b44d7ee1a
2023-07-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from EnRnFf_eyS6SGqpHi... to zTuZjXzI3bqscWmeo... (flutter/engine#43583 )
2023-07-12 skia-flutter-autoroll@skia.org Roll Skia from c769464a8b79 to d0ecba6d753c (2 revisions) (flutter/engine#43582 )
2023-07-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 551915bf6ebe to 51d6128b190e (1 revision) (flutter/engine#43581 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from EnRnFf_eyS6S to zTuZjXzI3bqs
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-12 06:05:57 +00:00
engine-flutter-autoroll
d77f918f8e
Roll Flutter Engine from d00590fde18c to e109a3c0c347 (1 revision) ( #130371 )
...
d00590fde1...e109a3c0c3
2023-07-12 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from qVHNy9nU6cQKtR_IB... to LV7zVdnjfEPukVG8L... (flutter/engine#43580 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from qVHNy9nU6cQK to LV7zVdnjfEPu
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3.13.0-2.0.pre
2023-07-12 02:02:03 +00:00
engine-flutter-autoroll
c8906bbd49
Roll Flutter Engine from 875d87e02276 to d00590fde18c (5 revisions) ( #130369 )
...
875d87e022...d00590fde1
2023-07-11 jason-simmons@users.noreply.github.com Release the mutex in the CanCreateConcurrentMessageLoop test before waking the latch (flutter/engine#43574 )
2023-07-11 skia-flutter-autoroll@skia.org Roll Skia from 2998197ce4ca to c769464a8b79 (2 revisions) (flutter/engine#43577 )
2023-07-11 zanderso@users.noreply.github.com Run linux_unopt on a machine with more cores (flutter/engine#43473 )
2023-07-11 skia-flutter-autoroll@skia.org Roll Skia from d2051446ee6b to 2998197ce4ca (1 revision) (flutter/engine#43572 )
2023-07-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 8b1c04086525 to 551915bf6ebe (1 revision) (flutter/engine#43571 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-12 00:55:18 +00:00
Polina Cherkasova
4e8014bf76
Enable not GCed leak tracking. ( #130159 )
2023-07-11 17:41:14 -07:00
engine-flutter-autoroll
c94e6766fd
Roll Flutter Engine from e2df01610fb3 to 875d87e02276 (3 revisions) ( #130359 )
...
e2df01610f...875d87e022
2023-07-11 chinmaygarde@google.com [Impeller] Fix WRITE_AFTER_WRITE hazard in ColorWheel/Vulkan. (flutter/engine#43570 )
2023-07-11 skia-flutter-autoroll@skia.org Roll Skia from 47a37395ee40 to d2051446ee6b (4 revisions) (flutter/engine#43569 )
2023-07-11 gwen.mittertreiner@gmail.com [fuchsia][cml] Mark Tracing as Optional (flutter/engine#43567 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-11 22:44:05 +00:00
Chris Bobbe
233a1bb316
autocomplete: Remove mistaken paragraph in onSelected doc ( #130190 )
...
Fixes #130187 .
Fixes #130187 by removing the mistaken paragraph; see there for details.
2023-07-11 22:37:31 +00:00
engine-flutter-autoroll
e12167d98c
Roll Flutter Engine from 59f234645dd2 to e2df01610fb3 (3 revisions) ( #130357 )
...
59f234645d...e2df01610f
2023-07-11 skia-flutter-autoroll@skia.org Roll Skia from 68bcc4470230 to 47a37395ee40 (12 revisions) (flutter/engine#43568 )
2023-07-11 dnfield@google.com Remove stray semicolons from embedded_views.cc (flutter/engine#43566 )
2023-07-11 bdero@google.com [Impeller] Apply color filters on the CPU for solid colors & gradients. (flutter/engine#43519 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-11 21:29:21 +00:00
Tae Hyung Kim
018fa8c51e
Refactor refresh_indicator.1.dart to not use shrinkwrap ( #129377 )
...
This PR changes the example app into a custom scrollview with three slivers. The middle sliver has a nested scrollview of height 300 and only this nested sliver can trigger the refresh indicator.
Fixes https://github.com/flutter/flutter/issues/116237 .
2023-07-11 20:04:17 +00:00
Tsukuru Tanimichi
cc180e214e
Links in material library docs are outdated ( #129891 )
...
https://api.flutter.dev/flutter/material/material-library.html
Links in `material` library docs are outdated
2023-07-11 19:57:35 +00:00
engine-flutter-autoroll
0757165e59
Roll Flutter Engine from afee1db31e5e to 59f234645dd2 (2 revisions) ( #130352 )
...
afee1db31e...59f234645d
2023-07-11 skia-flutter-autoroll@skia.org Roll Dart SDK from b3e9621a423e to 8b1c04086525 (2 revisions) (flutter/engine#43561 )
2023-07-11 dnfield@google.com Delete unused display list/SkPicture code (flutter/engine#43560 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-11 19:33:24 +00:00
engine-flutter-autoroll
5d4a1f1f5f
Roll Flutter Engine from 75ada1bdf9fd to afee1db31e5e (1 revision) ( #130349 )
...
75ada1bdf9...afee1db31e
2023-07-11 dworsham@google.com [fuchsia] Remove FIDL dart references (flutter/engine#43550 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-11 18:45:22 +00:00
Polina Cherkasova
e608a697c6
Upgrade leak_tracker to 7.0.6. ( #130346 )
2023-07-11 11:19:19 -07:00
engine-flutter-autoroll
f30cd64a16
Roll Flutter Engine from 0011db79d41f to 75ada1bdf9fd (2 revisions) ( #130345 )
...
0011db79d4...75ada1bdf9
2023-07-11 skia-flutter-autoroll@skia.org Roll Skia from 1f4ddedd7872 to 68bcc4470230 (4 revisions) (flutter/engine#43557 )
2023-07-11 skia-flutter-autoroll@skia.org Roll Skia from a788eeaa7ab6 to 1f4ddedd7872 (1 revision) (flutter/engine#43556 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-11 17:56:08 +00:00
flutter-pub-roller-bot
ec2e78e69a
Roll pub packages ( #130289 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-07-11 17:43:18 +00:00
Qun Cheng
12acff81c7
DropdownMenu can be expanded to its parent size (#129753 )
...
Fixes #125199
This PR is to add a new property `expandedInsets` so that the `DropdownMenu` can be expandable and has some margins around.
<details><summary>Example: Setting `expandedInsets` to `EdgeInsets.zero`</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const DropdownMenuExample());
class DropdownMenuExample extends StatefulWidget {
const DropdownMenuExample({super.key});
@override
State<DropdownMenuExample> createState() => _DropdownMenuExampleState();
}
class _DropdownMenuExampleState extends State<DropdownMenuExample> {
final TextEditingController colorController = TextEditingController();
ColorLabel? selectedColor;
@override
Widget build(BuildContext context) {
final List<DropdownMenuEntry<ColorLabel>> colorEntries = <DropdownMenuEntry<ColorLabel>>[];
for (final ColorLabel color in ColorLabel.values) {
colorEntries.add(
DropdownMenuEntry<ColorLabel>(value: color, label: color.label, enabled: color.label != 'Grey'),
);
}
return MaterialApp(
theme: ThemeData(
useMaterial3: true,
colorSchemeSeed: Colors.green,
),
home: Scaffold(
body: Center(
child: Container(
width: 500,
height: 500,
color: Colors.orange,
child: DropdownMenu<ColorLabel>(
expandedInsets: EdgeInsets.zero,
inputDecorationTheme: const InputDecorationTheme(
filled: true,
fillColor: Colors.white,
border: OutlineInputBorder(),
),
controller: colorController,
dropdownMenuEntries: colorEntries,
onSelected: (ColorLabel? color) {
setState(() {
selectedColor = color;
});
},
// expandedInsets: EdgeInsets.only(left: 35.0, right: 20.0, top: 80),
),
),
),
),
);
}
}
enum ColorLabel {
blue('Blue', Colors.blue),
pink('Pink', Colors.pink),
green('Green', Colors.green),
yellow('Yellow', Colors.yellow),
grey('Grey', Colors.grey);
const ColorLabel(this.label, this.color);
final String label;
final Color color;
}
```
<img width="500" alt="Screenshot 2023-06-28 at 11 33 20 PM" src="https://github.com/flutter/flutter/assets/36861262/e703f8a2-6e7c-45a0-86cf-d96da6dc157a ">
</details>
2023-07-11 17:08:07 +00:00
engine-flutter-autoroll
2009f32e53
Roll Packages from 4469c5e95dd8 to 188a8468f557 (6 revisions) ( #130340 )
...
4469c5e95d...188a8468f5
2023-07-11 32538273+ValentinVignal@users.noreply.github.com [go_router] Fix some typos in the comments and asserts (flutter/packages#4412 )
2023-07-11 tarrinneal@gmail.com [pigeon] `Object` type in class integration tests (flutter/packages#4384 )
2023-07-11 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.8.22 to 1.9.0 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#4419 )
2023-07-10 stuartmorgan@google.com [ci] Add initial LUCI legacy analysis (flutter/packages#4428 )
2023-07-10 stuartmorgan@google.com [web_benchmarks] Migrate custom test to `custom_package_tests` (flutter/packages#4429 )
2023-07-10 goddchen@gmail.com go_router: docs: fix typo in StatefulShellRoute.indexedStack(...) docs (flutter/packages#4341 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-11 16:48:19 +00:00
engine-flutter-autoroll
3273182a8e
Roll Flutter Engine from d75c70870f86 to 0011db79d41f (2 revisions) ( #130337 )
...
d75c70870f...0011db79d4
2023-07-11 skia-flutter-autoroll@skia.org Roll Skia from aba52937c5a2 to a788eeaa7ab6 (1 revision) (flutter/engine#43555 )
2023-07-11 skia-flutter-autoroll@skia.org Roll Skia from 57cf27703ab7 to aba52937c5a2 (1 revision) (flutter/engine#43554 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-11 15:58:51 +00:00
engine-flutter-autoroll
de238b6048
Roll Flutter Engine from 5e9f0d61a42a to d75c70870f86 (1 revision) ( #130332 )
...
5e9f0d61a4...d75c70870f
2023-07-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from cgcxIe8D4wb8hQWCV... to EnRnFf_eyS6SGqpHi... (flutter/engine#43553 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from cgcxIe8D4wb8 to EnRnFf_eyS6S
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-11 14:49:26 +00:00
engine-flutter-autoroll
c7da629cbb
Roll Flutter Engine from 417c50199e14 to 5e9f0d61a42a (1 revision) ( #130330 )
...
417c50199e...5e9f0d61a4
2023-07-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from bb8HXP6JZ60Unjk-W... to qVHNy9nU6cQKtR_IB... (flutter/engine#43552 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from bb8HXP6JZ60U to qVHNy9nU6cQK
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-11 13:34:17 +00:00
engine-flutter-autoroll
2fb9a3ccdd
Roll Flutter Engine from bfda8f173fea to 417c50199e14 (2 revisions) ( #130324 )
...
bfda8f173f...417c50199e
2023-07-11 skia-flutter-autoroll@skia.org Roll Skia from 5c8ed590d4f3 to 57cf27703ab7 (1 revision) (flutter/engine#43551 )
2023-07-11 flar@google.com remove include of SkPicture files from non-Fuchsia sources (flutter/engine#43542 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-11 11:17:23 +00:00
Taha Tesser
476e2d5166
Add Badge widget to NavigationBar and NavigationRail examples ( #129834 )
...
fixes [Showcase `Badge` widget in `NavigationBar` and `NavigationRail` examples
](https://github.com/flutter/flutter/issues/129832 )
| Preview | Preview | Preview |
| --------------- | --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/808c9577-c6b4-465f-b9fe-100d422dd408 " /> | <img src="https://github.com/flutter/flutter/assets/48603081/c9b3ee03-56d7-4220-94cf-06e235631714 " /> | <img src="https://github.com/flutter/flutter/assets/48603081/43fab47b-25e8-4412-92d2-6d4868e43ff8 " /> |
2023-07-11 09:30:05 +00:00
engine-flutter-autoroll
eaf01a9a50
Roll Flutter Engine from 2139c8a90822 to bfda8f173fea (2 revisions) ( #130321 )
...
2139c8a908...bfda8f173f
2023-07-11 skia-flutter-autoroll@skia.org Roll Skia from eb1cdb6bd87f to 5c8ed590d4f3 (1 revision) (flutter/engine#43549 )
2023-07-11 skia-flutter-autoroll@skia.org Roll Dart SDK from f9d33db51927 to b3e9621a423e (2 revisions) (flutter/engine#43547 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-11 09:28:12 +00:00
Ian Hickson
2bf8414a20
Update labeler for recent changes ( #130168 )
...
'team' is going away, and 'tech debt' got renamed.
2023-07-11 08:53:59 +00:00
Darshan Rander
af2e28230f
fix: ExpansionTileTheme.shape assignment in ExpansionTile ( #127749 )
...
The ExpansionTile was not following `shape` from ExpansionTileTheme as it was assigning wrong parameter to the tween.
fixes #129785
2023-07-11 08:47:11 +00:00
engine-flutter-autoroll
74491fc73e
Roll Flutter Engine from 12aa98177cf2 to 2139c8a90822 (2 revisions) ( #130316 )
...
12aa98177c...2139c8a908
2023-07-11 skia-flutter-autoroll@skia.org Roll Skia from 77267bf1e7b3 to eb1cdb6bd87f (2 revisions) (flutter/engine#43548 )
2023-07-11 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.2.0 to 4.3.0 (flutter/engine#43546 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-11 08:36:25 +00:00
engine-flutter-autoroll
1b756bc5f9
Roll Flutter Engine from 767f2fb8ab03 to 12aa98177cf2 (1 revision) ( #130315 )
...
767f2fb8ab...12aa98177c
2023-07-11 skia-flutter-autoroll@skia.org Roll Skia from 6a5c4b0c0fcb to 77267bf1e7b3 (1 revision) (flutter/engine#43545 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-11 07:21:17 +00:00
Ian Hickson
d71bbfb490
Implement preferPaintInterior correctly for _CompoundBorder ( #129851 )
2023-07-11 06:44:33 +00:00
engine-flutter-autoroll
81d7297d91
Roll Flutter Engine from 153d9e1d598a to 767f2fb8ab03 (1 revision) ( #130313 )
...
153d9e1d59...767f2fb8ab
2023-07-11 dnfield@google.com [Impeller] Improve resolution of text scaling. (flutter/engine#43533 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-11 06:28:10 +00:00
engine-flutter-autoroll
2d951ac22c
Roll Flutter Engine from 2c82dd7ec54b to 153d9e1d598a (2 revisions) ( #130311 )
...
2c82dd7ec5...153d9e1d59
2023-07-11 skia-flutter-autoroll@skia.org Roll Skia from d0991c6af2d6 to 6a5c4b0c0fcb (1 revision) (flutter/engine#43544 )
2023-07-11 chinmaygarde@google.com [Impeller] Refactor barriers and add documentation. (flutter/engine#43540 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-07-11 05:44:13 +00:00