Daco Harkes
9b274c5529
[native assets] Fix caching on BuildMode switching
2026-02-02 18:38:29 +01:00
engine-flutter-autoroll
f4674dce83
Roll Packages from 510dd407289a to 837dbbdf62da (3 revisions) ( #181811 )
...
510dd40728...837dbbdf62engine-flutter-autoroll@skia.org Roll Flutter from
da72d5936d69 to 1d9d6a9a5ef6 (33 revisions) (flutter/packages#10931 )
2026-01-30 124308320+ritoban23@users.noreply.github.com
[image_picker_ios] Fix deprecated kUTTypeGIF usage
(flutter/packages#10848 )
2026-01-30 65381000+raju-muliyashiya@users.noreply.github.com
[cross_file] [web] Separate "Save As" implementation details from XFile
web class (flutter/packages#10397 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-02 16:01:11 +00:00
engine-flutter-autoroll
54b8778c78
Roll Dart SDK from 434c5c6d1889 to 1aa8f2de7587 (1 revision) ( #181810 )
...
https://dart.googlesource.com/sdk.git/+log/434c5c6d1889..1aa8f2de7587
2026-02-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-101.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-02 15:45:13 +00:00
Brahim GUAALI
224d29a105
Use null-aware elements in cupertino/list_tile.dart ( #181243 )
...
## Description
Adopts null-aware element syntax (`?x`) in `cupertino/list_tile.dart`,
replacing 1 instance of the verbose `if (x != null) x!` pattern.
Contributes to https://github.com/flutter/flutter/issues/172188
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
[Contributor Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md
[](https://www.talabat.com )
[](https://github.com/search?q=org%3Aflutter+talabat&type=pullrequests )
Co-authored-by: Kostia Sokolovskyi <sokolovskyi.konstantin@gmail.com>
2026-02-02 14:54:25 +00:00
Brahim GUAALI
a12f07d9b7
Use null-aware elements in material/dialog.dart ( #181244 )
...
## Description
Adopts null-aware element syntax (`?x`) in `material/dialog.dart`,
replacing 2 instances of the verbose `if (x != null) x!` pattern in
`SimpleDialog`.
Contributes to https://github.com/flutter/flutter/issues/172188
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
[Contributor Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md
[](https://www.talabat.com )
[](https://github.com/search?q=org%3Aflutter+talabat&type=pullrequests )
Co-authored-by: Kostia Sokolovskyi <sokolovskyi.konstantin@gmail.com>
2026-02-02 13:32:19 +00:00
Brahim GUAALI
5378bab244
Use null-aware spread in cupertino/app.dart ( #181585 )
...
## Description
Adopts null-aware spread syntax (`...?x`) in `cupertino/app.dart`,
replacing the verbose `if (x != null) ...x!` pattern.
Contributes to https://github.com/flutter/flutter/issues/172188
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
[Contributor Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md
[](https://www.talabat.com )
[](https://github.com/search?q=org%3Aflutter+talabat&type=pullrequests )
2026-02-02 12:08:56 +00:00
Brahim GUAALI
fa05ce421d
Use null-aware spread in material/app.dart ( #181586 )
...
## Description
Adopts null-aware spread syntax (`...?x`) in `material/app.dart`,
replacing the verbose `if (x != null) ...x!` pattern.
Fixes https://github.com/flutter/flutter/issues/172188
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
[Contributor Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md
[](https://www.talabat.com )
[](https://github.com/search?q=org%3Aflutter+talabat&type=pullrequests )
2026-02-02 12:07:17 +00:00
engine-flutter-autoroll
7e1c88685a
Roll Dart SDK from 84abc8d58ec8 to 434c5c6d1889 (1 revision) ( #181800 )
...
https://dart.googlesource.com/sdk.git/+log/84abc8d58ec8..434c5c6d1889
2026-02-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-100.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-02 10:42:29 +00:00
engine-flutter-autoroll
210b949186
Roll Skia from c14c5b243395 to 43fa79e1c51f (8 revisions) ( #181797 )
...
https://skia.googlesource.com/skia.git/+log/c14c5b243395..43fa79e1c51f
2026-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from ad00a98e67db to d7139503a3f3 (12 revisions)
2026-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from a082d8e7cb91 to 4764cd21387f (11 revisions)
2026-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
shaders-base from b80f1f54f7aa to ea17f563d60c
2026-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
jsfiddle-base from a9626bf87bff to 3ab5ab821316
2026-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 9e5b3d985a5f to 3d03ba33dbea (7 revisions)
2026-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
skottie-base from 292d73c2f82f to c8bbdc3f1219
2026-02-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
debugger-app-base from a2de4c63b16c to 6d108126d20a
2026-02-02
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC codefu@google.com ,jmbetancourt@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-02 09:17:45 +00:00
engine-flutter-autoroll
12df8ac98e
Roll Skia from 4ee9eb659ae0 to c14c5b243395 (1 revision) ( #181780 )
...
https://skia.googlesource.com/skia.git/+log/4ee9eb659ae0..c14c5b243395
2026-02-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 109a2e10e94c to cb5b93c401f2 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC codefu@google.com ,jmbetancourt@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-02 03:33:26 +00:00
engine-flutter-autoroll
9f2371f91b
Roll Fuchsia Linux SDK from nI52U4LJMrBv8G1M9... to 1L4m9qCikk-JzrNWE... ( #181779 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-02 01:31:34 +00:00
engine-flutter-autoroll
9eafba4f46
Roll Skia from a8ceddc2bca0 to 4ee9eb659ae0 (1 revision) ( #181773 )
...
https://skia.googlesource.com/skia.git/+log/a8ceddc2bca0..4ee9eb659ae0
2026-02-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SKP
CIPD package from 550 to 551
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC codefu@google.com ,jmbetancourt@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-01 15:40:26 +00:00
engine-flutter-autoroll
11bda918ff
Roll Skia from a5a535bc21a3 to a8ceddc2bca0 (1 revision) ( #181772 )
...
https://skia.googlesource.com/skia.git/+log/a5a535bc21a3..a8ceddc2bca0
2026-02-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 60448b32a27f to 109a2e10e94c (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC codefu@google.com ,jmbetancourt@google.com,kjlubick@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-01 13:30:26 +00:00
engine-flutter-autoroll
454c53e778
Roll Dart SDK from cde322c518b9 to 84abc8d58ec8 (1 revision) ( #181767 )
...
https://dart.googlesource.com/sdk.git/+log/cde322c518b9..84abc8d58ec8
2026-02-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-99.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-01 09:55:25 +00:00
engine-flutter-autoroll
37a8bb1feb
Roll Dart SDK from c72b3f527a07 to cde322c518b9 (1 revision) ( #181763 )
...
https://dart.googlesource.com/sdk.git/+log/c72b3f527a07..cde322c518b9
2026-02-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-98.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-02-01 05:01:27 +00:00
engine-flutter-autoroll
af5d2ceb93
Roll Dart SDK from 43de79f08887 to c72b3f527a07 (1 revision) ( #181762 )
...
https://dart.googlesource.com/sdk.git/+log/43de79f08887..c72b3f527a07
2026-01-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-97.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-31 23:59:21 +00:00
engine-flutter-autoroll
3fdf8cad2c
Roll Fuchsia Linux SDK from 27OsrsrKcrr2pOaqY... to nI52U4LJMrBv8G1M9... ( #181760 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-31 23:09:24 +00:00
engine-flutter-autoroll
18e3b487de
Roll Dart SDK from a0aac59705e5 to 43de79f08887 (1 revision) ( #181758 )
...
https://dart.googlesource.com/sdk.git/+log/a0aac59705e5..43de79f08887
2026-01-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-96.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-31 18:58:36 +00:00
engine-flutter-autoroll
59df2c8eee
Roll Skia from b704afbcd8e7 to a5a535bc21a3 (1 revision) ( #181757 )
...
https://skia.googlesource.com/skia.git/+log/b704afbcd8e7..a5a535bc21a3
2026-01-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 608edb9018a9 to 60448b32a27f (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-31 16:29:39 +00:00
engine-flutter-autoroll
2cff642bd7
Roll Dart SDK from d6f77f9098e1 to a0aac59705e5 (1 revision) ( #181756 )
...
https://dart.googlesource.com/sdk.git/+log/d6f77f9098e1..a0aac59705e5
2026-01-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-95.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-31 12:58:26 +00:00
engine-flutter-autoroll
c45c10208c
Roll Skia from 6f9511ce11ba to b704afbcd8e7 (4 revisions) ( #181753 )
...
https://skia.googlesource.com/skia.git/+log/6f9511ce11ba..b704afbcd8e7
2026-01-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 13170c81bc3d to 608edb9018a9 (7 revisions)
2026-01-31 michaelludwig@google.com Revert "[graphite] Consolidate
colortype info functions into Caps"
2026-01-31 michaelludwig@google.com Revert "[graphite]
SkSurfaces::WrapBackendTexture doesn't require SkColorType"
2026-01-31 jmbetancourt@google.com Reland: introduce new SkLogPriority
and logging macros to skia
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-31 11:33:44 +00:00
engine-flutter-autoroll
8ba756a52b
Roll Dart SDK from 0cf997832948 to d6f77f9098e1 (2 revisions) ( #181749 )
...
https://dart.googlesource.com/sdk.git/+log/0cf997832948..d6f77f9098e1
2026-01-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-94.0.dev
2026-01-31 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-93.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-31 07:50:26 +00:00
engine-flutter-autoroll
ca515532be
Roll Skia from 33c00c0f3b8b to 6f9511ce11ba (1 revision) ( #181744 )
...
https://skia.googlesource.com/skia.git/+log/33c00c0f3b8b..6f9511ce11ba
2026-01-30 ccameron@chromium.org Add more kR8_unorm_SkColorType and
kR16_unorm_SkColorType support.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-31 02:01:25 +00:00
engine-flutter-autoroll
bbcbb8d5e5
Roll Dart SDK from be3ffc51d407 to 0cf997832948 (1 revision) ( #181740 )
...
https://dart.googlesource.com/sdk.git/+log/be3ffc51d407..0cf997832948
2026-01-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-92.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-31 01:05:26 +00:00
engine-flutter-autoroll
94e0dc8d40
Roll Skia from b62d43b59dd6 to 33c00c0f3b8b (1 revision) ( #181735 )
...
https://skia.googlesource.com/skia.git/+log/b62d43b59dd6..33c00c0f3b8b
2026-01-30 michaelludwig@google.com [graphite] Add f16 variants for
std140 and std430 to UniformManager
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-30 23:54:22 +00:00
Jason Simmons
dc2b4c6eb4
[Impeller] Fix type conversion warnings seen on Windows when Impeller GL API wrappers log arguments with function types ( #181734 )
...
https://github.com/flutter/flutter/pull/181157 introduced a call to the
glDebugMessageCallback API using a lambda as the argument. On Windows
builds this produces a warning about a nonstandard implicit conversion
when the Impeller GL API wrappers try to log the callback argument.
2026-01-30 22:19:35 +00:00
jesswrd
319ef4eed8
Update New Android API Docs ( #180604 )
...
Updated Android API Docs with Android API 36 umbrella issue and added
new links and instructions.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2026-01-30 21:49:03 +00:00
engine-flutter-autoroll
2337afaaef
Roll Fuchsia Linux SDK from isy1ARvK-3bsvtfc-... to 27OsrsrKcrr2pOaqY... ( #181733 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com ,zra@google.com on the revert to ensure that
a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-30 21:12:27 +00:00
nmarci89
f8aaee5694
Fix P3-to-sRGB color conversion to operate in linear light ( #181720 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
### Problem
The P3-to-sRGB color conversion applies an affine matrix directly to
gamma-encoded values in both the C++ engine (`dl_color.cc`) and Dart
(`painting.dart`). This is mathematically incorrect — color space
conversion matrices must operate in linear light. The result is P3
colors that appear nearly identical to sRGB instead of showing the full
gamut difference.
For example, P3 `#1ECAD3` (30/255, 202/255, 211/255) converts to:
- **Old (wrong):** extendedSRGB (-0.12, 0.86, 0.87)
- **New (correct):** extendedSRGB (-0.38, 0.81, 0.84)
The red channel error of 0.26 is clearly visible — colors appear washed
out instead of vivid.
### Fix
Replace the single affine matrix multiply with the correct 3-step
pipeline:
1. **Linearize** — decode gamma via sRGB EOTF
2. **Transform** — apply 3x3 P3-to-sRGB matrix in linear space
3. **Encode** — re-apply gamma via sRGB OETF
Extended range (negative values from out-of-gamut colors) is handled by
mirroring the transfer function.
**C++ (`dl_color.cc`):** Replace affine matrix with `p3ToExtendedSrgb()`
using `double` precision.
**Dart (`painting.dart`):** Replace `_MatrixColorTransform` with
`_P3ToSrgbTransform` and `_SrgbToP3Transform` classes. Also fixes the
sRGB-to-P3 direction.
### Performance
Negligible. The C++ conversion runs once per paint setup in `ReadColor`,
not per frame or per pixel. The Dart conversion runs once per
`Color.withValues()` call.
### Tests
- **C++:** Added `ColorSpaceP3ToExtendedSRGBLinearLight` test in
`dl_color_unittests.cc`
- **Dart:** Added 3 tests in `colors_test.dart`: mid-range
P3→extendedSRGB, P3 green→extendedSRGB, sRGB→P3 round-trip
All new tests fail with the old code and pass with the fix. Existing
tests continue to pass.
## Issue:
https://github.com/flutter/flutter/issues/181717
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing. **New tests pass, can't
run golden tests!**
---------
Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com>
2026-01-30 20:53:45 +00:00
John "codefu" McDole
3ce3f1345d
chore: deflake Linux_mokey flutter_engine_group_performance ( #181624 )
...
fixes : #179114
2026-01-30 20:33:44 +00:00
engine-flutter-autoroll
8975fd4d0c
Roll Dart SDK from 2703fd9733ce to be3ffc51d407 (1 revision) ( #181729 )
...
https://dart.googlesource.com/sdk.git/+log/2703fd9733ce..be3ffc51d407
2026-01-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-91.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-30 20:01:10 +00:00
Matt Boetger
d143c41e41
Ensure content-sizing resize is run on UI thread ( #181686 )
...
While testing with a different add-to-app
https://github.com/flutter/samples/pull/2787 , an exception is sometimes
thrown when the resize is attempted because the callback comes from a
different thread. It is expected that the raster thread calls this but
with previous
[testing](https://github.com/mboetger/test-add-to-app/tree/content-sizing )
never caused this exception.
This PR ensures the resize happens on the UI thread. It also a flag to
ensure content sizing is disabled.
Fixes: https://github.com/flutter/flutter/issues/181573
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
2026-01-30 18:36:08 +00:00
Ben Konyi
467c009eea
[ Tool ] Cleanup ResidentCompiler initialization logic ( #181421 )
...
Moves the initialization logic for web and non-web compilers into the
`ResidentCompiler` factory and reduces code duplication.
Also bumps the flutter_tools Dart SDK version to ^3.10.0 to enable dot
shorthands.
---------
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2026-01-30 18:36:08 +00:00
Daco Harkes
b877bae05d
[native assets] Split debug info into .dsym files ( #181533 )
...
This PR splits the debug info from code assets into separate dsym files
for MacOS and iOS.
The splitting only happens if the build mode is not debug. This aligns
with whether the debug symbols are separated out for the Flutter
framework and the app Framework.
Closes: https://github.com/flutter/flutter/issues/181377
Testing: Added some tests to the integration test
2026-01-30 18:00:23 +00:00
engine-flutter-autoroll
92fb5e8ac5
Roll Skia from 4745eb2fe837 to b62d43b59dd6 (1 revision) ( #181727 )
...
https://skia.googlesource.com/skia.git/+log/4745eb2fe837..b62d43b59dd6
2026-01-30 bwils@google.com Revert "reland: introduce new SkLogPriority
and logging macros to skia"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-30 17:34:26 +00:00
Andrew Marshall
ae0fe0d05c
add ccache support for custom toolchain ( #180737 )
...
Add ccache support when building the engine using a custom toolchain.
Fixes #180736
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
2026-01-30 17:19:13 +00:00
Andrew Marshall
f94d0cb3b2
update GLFW to latest and use EGL context creation on linux ( #181259 )
...
Updates the GLFW dependency to master and uses the EGL context creation
API on Linux. This allows Linux users to select an OpenGL implementation
when running the impeller playground tests by defining
`__EGL_VENDOR_LIBRARY_FILENAMES`.
For example, running
```
$ impeller_unittests --gtest_filter=Play/AiksTest.ToImageFromImage/OpenGLES
```
gives, in `description_gles.cc` ,
```
gl_version_string_ // OpenGL ES 3.2 NVIDIA 590.48.01
```
Then running
```
$ __EGL_VENDOR_LIBRARY_FILENAMES=/usr/share/glvnd/egl_vendor.d/50_mesa.json impeller_unittests --gtest_filter=Play/AiksTest.ToImageFromImage/OpenGLES
```
```
gl_version_string_ // OpenGL ES 3.2 Mesa 25.3.3-arch1.3
```
Fixes #181258
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2026-01-30 17:17:05 +00:00
Andrew Marshall
907bda7d0c
add stacktrace support when requested for host builds ( #181264 )
...
Adds support for backtraces when requested in host builds
### Before:
```
Note: Google Test filter = Play/RendererTest.BabysFirstTriangle/OpenGLES
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from Play/RendererTest
[ RUN ] Play/RendererTest.BabysFirstTriangle/OpenGLES
...
Segmentation fault (core dumped) __EGL_VENDOR_LIBRARY_FILENAMES=/usr/share/glvnd/egl_vendor.d/50_mesa.json ./out/host_debug_unopt/exe.unstripped/impeller_unittests --enable_playground --gtest_filter='Play/RendererTest.BabysFirstTriangle/OpenGLES'
```
### After:
```
Note: Google Test filter = Play/RendererTest.BabysFirstTriangle/OpenGLES
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from Play/RendererTest
[ RUN ] Play/RendererTest.BabysFirstTriangle/OpenGLES
...
[symbolize_elf.inc : 379] RAW: Unable to get high fd: rc=0, limit=1024
[ERROR:flutter/fml/backtrace.cc(108)] Caught signal SIGSEGV during program execution.
Frame 0: 0x55831f19fbc4 impeller::DeviceBufferGLES::GetBufferData()
Frame 1: 0x55831f186cd3 impeller::BufferBindingsGLES::BindUniformBufferV2()
Frame 2: 0x55831f186b66 impeller::BufferBindingsGLES::BindUniformBufferV3()
Frame 3: 0x55831f1861da impeller::BufferBindingsGLES::BindUniformBuffer()
Frame 4: 0x55831f185fea impeller::BufferBindingsGLES::BindUniformData()
Frame 5: 0x55831f1cb112 impeller::EncodeCommandsInReactor()
...
Segmentation fault (core dumped) __EGL_VENDOR_LIBRARY_FILENAMES=/usr/share/glvnd/egl_vendor.d/50_mesa.json ./out/host_debug_unopt/exe.unstripped/impeller_unittests --enable_playground --gtest_filter='Play/RendererTest.BabysFirstTriangle/OpenGLES'
```
Fixes #181156
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2026-01-30 17:13:10 +00:00
Andrew Marshall
1d9d6a9a5e
enable enhanced debugging for GLES playground ( #181157 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
Enables improved OpenGLES debug support in the playground tests if
[KHR_DEBUG](https://registry.khronos.org/OpenGL/extensions/KHR/KHR_debug.txt )
is available. Only activated on unoptimized builds (where `NDEBUG` is
not defined)
Example:
Before:
```
[FATAL:flutter/impeller/renderer/backend/gles/proc_table_gles.h(44)] Fatal GL Error GL_INVALID_ENUM(1280) encountered on call to glBindBuffer
```
After:
```
[ERROR:flutter/impeller/playground/backend/gles/playground_impl_gles.cc(146)] GL Error: GL_INVALID_ENUM error generated. Invalid buffer target enum.
[FATAL:flutter/impeller/renderer/backend/gles/proc_table_gles.h(44)] Fatal GL Error GL_INVALID_ENUM(1280) encountered on call to glBindBuffer
```
Closes #179329
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2026-01-30 17:13:10 +00:00
Matthew Kosarek
7323c0ee05
Make the Windows windowing_test in .ci.yaml have bringup as false ( #181664 )
...
## What's new?
Windows windowing tests should no longer be flaky, so let's set
`bringup: false` in `.ci.yaml`
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
---------
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
2026-01-30 16:31:12 +00:00
engine-flutter-autoroll
d13d227639
Roll Packages from cd4fd61fc5b6 to 510dd407289a (4 revisions) ( #181726 )
...
cd4fd61fc5...510dd40728engine-flutter-autoroll@skia.org Roll Flutter (stable) from
bd7a4a6b5576 to 67323de285b0 (3 revisions) (flutter/packages#10924 )
2026-01-29 engine-flutter-autoroll@skia.org Roll Flutter from
dfd92b773219 to da72d5936d69 (39 revisions) (flutter/packages#10923 )
2026-01-29 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Retrieve lens direction from CameraX directly
(flutter/packages#10847 )
2026-01-29 stuartmorgan@google.com [tool] Adjust error message when
`downgrade` fails (flutter/packages#10734 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-30 15:57:57 +00:00
engine-flutter-autoroll
d06ccc5627
Roll Skia from edbf7e9eb846 to 4745eb2fe837 (1 revision) ( #181725 )
...
https://skia.googlesource.com/skia.git/+log/edbf7e9eb846..4745eb2fe837
2026-01-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 52ea045250c2 to 13170c81bc3d (8 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-30 14:43:27 +00:00
Kazbek Sultanov
32aef9f3e2
Enhance error handling of WidgetsBindingObserver callbacks ( #181174 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
Wraps all 16 WidgetsBindingObserver callback invocations in try-catch
blocks to prevent silent failures and ensure all observers are notified
even when one throws an exception.
Previously, exceptions in observer callbacks would either:
- Be silently discarded (method channel handlers)
- Prevent subsequent observers from being notified
Now, exceptions are properly reported via FlutterError.reportError and
all observers continue to receive notifications.
Fixes flutter/flutter#180434
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
[](https://www.talabat.com )
[](https://github.com/search?q=org%3Aflutter+talabat&type=pullrequests )
---------
Co-authored-by: Mohellebi Abdessalem <116356835+AbdeMohlbi@users.noreply.github.com>
2026-01-30 10:46:26 +00:00
engine-flutter-autoroll
57789683a5
Roll Skia from 05d3cb9d2be9 to edbf7e9eb846 (2 revisions) ( #181715 )
...
https://skia.googlesource.com/skia.git/+log/05d3cb9d2be9..edbf7e9eb846
2026-01-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from cd22b6ab03c3 to ad00a98e67db (13 revisions)
2026-01-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 87026abda3e1 to 9e5b3d985a5f (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-30 09:18:33 +00:00
engine-flutter-autoroll
4ef867d032
Roll Skia from c198e5fa9cd9 to 05d3cb9d2be9 (1 revision) ( #181712 )
...
https://skia.googlesource.com/skia.git/+log/c198e5fa9cd9..05d3cb9d2be9
2026-01-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from e4582e1b1355 to a082d8e7cb91 (27 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-30 07:12:41 +00:00
engine-flutter-autoroll
5267072bec
Roll Dart SDK from 920b7e24583e to 2703fd9733ce (2 revisions) ( #181693 )
...
https://dart.googlesource.com/sdk.git/+log/920b7e24583e..2703fd9733ce
2026-01-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-90.0.dev
2026-01-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.12.0-89.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com ,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-30 04:10:14 +00:00
engine-flutter-autoroll
0322fe58ea
Roll Skia from b9f40c193e7a to c198e5fa9cd9 (6 revisions) ( #181692 )
...
https://skia.googlesource.com/skia.git/+log/b9f40c193e7a..c198e5fa9cd9
2026-01-30
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2026-01-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from a715d2c2482a to 52ea045250c2 (5 revisions)
2026-01-29
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2026-01-29 michaelludwig@google.com [graphite]
SkSurfaces::WrapBackendTexture doesn't require SkColorType
2026-01-29 michaelludwig@google.com [graphite] Reduce inline allocation
size of DrawList
2026-01-29
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bwils@google.com ,codefu@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2026-01-30 03:44:04 +00:00
flutter-pub-roller-bot
9b6f15e67d
Roll pub packages ( #181690 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2026-01-30 00:37:27 +00:00
Jason Simmons
87b599c63e
Extend the Windows tool_integration_tests_2_9 shard timeout to 1 hour ( #181678 )
...
This shard has been timing out often (see
https://github.com/flutter/flutter/issues/180413 )
Some new tests were added to the shard that may have made it exceed the
timeout (see
a5b3c4bd69
2026-01-30 00:20:22 +00:00
Gray Mackall
ba5ba0d923
Add android_sdk dependency to android_engine_opengles_tests ( #181681 )
...
It does android builds, and therefore it gets android deps. In
particular, see this timeout
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8691309993367404513/+/u/run_test.dart_for_android_engine_opengles_tests_shard_and_subshard_None/stdout
where:
```
Checking the license for package NDK (Side by side) 27.0.12077973 in /b/s/w/ir/cache/android/sdk/licenses
License for package NDK (Side by side) 27.0.12077973 accepted.
Preparing "Install NDK (Side by side) 27.0.12077973 v.27.0.12077973".
"Install NDK (Side by side) 27.0.12077973 v.27.0.12077973" ready.
Installing NDK (Side by side) 27.0.12077973 in /b/s/w/ir/cache/android/sdk/ndk/27.0.12077973
"Install NDK (Side by side) 27.0.12077973 v.27.0.12077973" complete.
"Install NDK (Side by side) 27.0.12077973 v.27.0.12077973" finished.
```
Co-authored-by: Gray Mackall <mackall@google.com>
2026-01-29 23:01:17 +00:00
