85926 Commits

Author SHA1 Message Date
chunhtai
c9e0f94dfe
Update path for android_embedding_dependencies 2025-09-12 11:46:27 -07:00
chunhtai
483e1b17eb
Fix path to Android embedding dependencies 2025-09-12 11:09:31 -07:00
engine-flutter-autoroll
2efda9cc14
Roll Packages from 5db263559657 to 15e7e893a6fd (2 revisions) (#175266)
5db2635596...15e7e893a6

2025-09-11 engine-flutter-autoroll@skia.org Roll Flutter from
a0820964d59c to 5a6a1bff8d3e (26 revisions) (flutter/packages#9992)
2025-09-11 49699333+dependabot[bot]@users.noreply.github.com Bump the
all-github-actions group across 1 directory with 2 updates
(flutter/packages#9973)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-12 15:51:10 +00:00
Bruno Leroux
97c5249b32
Document Form.onChange precedence over DropdownButtonFormField.onChange (#175249)
## Description

This PR adds some documentation to `DropdownButtonFormField.onChanged`
to clarify the precedence order related to `Form.onChanged`.

## Related Issue

Fixes [DropdownButtonFormField changes not absorbing Form onChanged
Function](https://github.com/flutter/flutter/issues/86336)

## Tests

Documentation only
2025-09-12 11:55:13 +00:00
engine-flutter-autoroll
f0bce2308b
Roll Fuchsia Linux SDK from 1pTB3J5rn4YYugylf... to b1AYfAFOnvBMHSsYL... (#175250)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-12 08:00:24 +00:00
engine-flutter-autoroll
d4e444113a
Roll Dart SDK from 7acebac57248 to a4075f2f670f (1 revision) (#175245)
https://dart.googlesource.com/sdk.git/+log/7acebac57248..a4075f2f670f

2025-09-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-193.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-12 06:04:24 +00:00
engine-flutter-autoroll
59ece62065
Roll Dart SDK from f7d6a4732ab0 to 7acebac57248 (2 revisions) (#175239)
https://dart.googlesource.com/sdk.git/+log/f7d6a4732ab0..7acebac57248

2025-09-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-192.0.dev
2025-09-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-191.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-11 21:58:27 +00:00
Flutter GitHub Bot
689832e744
Marks Linux_pixel_7pro static_path_stroke_tessellation_perf__timeline_summary to be flaky (#175174)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_pixel_7pro
static_path_stroke_tessellation_perf__timeline_summary"
}
-->
Issue link: https://github.com/flutter/flutter/issues/175173

Co-authored-by: Jim Graham <flar@google.com>
2025-09-11 20:25:16 +00:00
Devon Carew
b88c067486
update deps to point to the new SOT repo for package:coverage (#175234)
This PR updates the deps to point to the new SOT repo for
package:coverage. The engine was referencing the old location;
package:test needs functionality from the latest package:coverage, and
we need to update the coverage reference here in order to roll the
latest `test` through dart and flutter.

Issues:
- roll failure trying to update the latest package:test into the Dart
SDK; https://dart-review.googlesource.com/c/sdk/+/448423

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-09-11 20:06:22 +00:00
Kostia Sokolovskyi
ed6e638756
[web] Fix image and color filters equality in SkWASM. (#175230)
Closes https://github.com/flutter/flutter/issues/173968

- Adds equality support to `ImageFilter`s in SkWASM
- Adds equality support to `ColorFilter`s in SkWASM
- Fixes test to not use const objects in the equality checks

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-09-11 19:15:22 +00:00
engine-flutter-autoroll
234e7d9bf0
Roll Packages from 03598e7797cf to 5db263559657 (1 revision) (#175232)
03598e7797...5db2635596

2025-09-10 stuartmorgan@google.com [url_launcher] Re-remove Android
API<24 support (flutter/packages#9987)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-11 15:40:18 +00:00
Valentin Vignal
d305a32ad9
Migrate to widget state (#174746)
Follow up of https://github.com/flutter/flutter/pull/174486

Migrate some files from `MaterialState` to `WidgetState`. This PR only
focus on `WidgetState` for a subset of files.
- This minimizes conflicts and reduces the size of the PR for easier
reviews and follow up
- I'll work on the other elements of
`packages/flutter/lib/src/material/material_state.dart` into other PRs


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-09-11 14:40:28 +00:00
engine-flutter-autoroll
5a6a1bff8d
Roll Dart SDK from 42045594dbc6 to f7d6a4732ab0 (2 revisions) (#175222)
https://dart.googlesource.com/sdk.git/+log/42045594dbc6..f7d6a4732ab0

2025-09-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-190.0.dev
2025-09-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-189.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-11 10:44:24 +00:00
engine-flutter-autoroll
14ebc8bc33
Roll Skia from 00c8b3f69de9 to ead9277819fc (2 revisions) (#175221)
https://skia.googlesource.com/skia.git/+log/00c8b3f69de9..ead9277819fc

2025-09-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 29f14166cead to 4a8b7b7b5040 (15 revisions)
2025-09-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 7e8698436266 to f27d171991de (17 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,codefu@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-11 10:17:00 +00:00
engine-flutter-autoroll
c35c37a6df
Roll Skia from 4a8817a48b25 to 00c8b3f69de9 (3 revisions) (#175213)
https://skia.googlesource.com/skia.git/+log/4a8817a48b25..00c8b3f69de9

2025-09-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 6b1e4d74700b to 599ecfb9b331 (7 revisions)
2025-09-10
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-09-10 ccameron@chromium.org SkNamedTransferFn: Change kRec709 to
match ITU-R BT.1886 pure 2.4 gamma

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,codefu@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-11 07:57:15 +00:00
engine-flutter-autoroll
9fbcc27bf8
Roll Fuchsia Linux SDK from 10x-JGF5zuuW8ik4K... to 1pTB3J5rn4YYugylf... (#175210)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-11 05:37:26 +00:00
engine-flutter-autoroll
34fd68ed45
Roll Dart SDK from 1de2289e49fe to 42045594dbc6 (1 revision) (#175203)
https://dart.googlesource.com/sdk.git/+log/1de2289e49fe..42045594dbc6

2025-09-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-188.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-11 00:51:19 +00:00
engine-flutter-autoroll
ab7b879602
Roll Skia from cbb0388767d2 to 4a8817a48b25 (4 revisions) (#175202)
https://skia.googlesource.com/skia.git/+log/cbb0388767d2..4a8817a48b25

2025-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 90bb0f2095e9 to 482715c7d748 (6 revisions)
2025-09-10 mike@reedtribe.org Fix difference between builder and path
2025-09-10 danieldilan@google.com Saturate in legacy shader when scaling
2025-09-10 syoussefi@google.com [graphite][vulkan] Adjust test
expectation for host image copy

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,codefu@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-10 23:46:17 +00:00
engine-flutter-autoroll
c8721a2e06
Roll Skia from 55c9d697da52 to cbb0388767d2 (7 revisions) (#175197)
https://skia.googlesource.com/skia.git/+log/55c9d697da52..cbb0388767d2

2025-09-10 briansalomon@gmail.com Move Ganesh-only tool code into
tools/ganesh
2025-09-10 danieldilan@google.com [raster] Don't use lowp when sampling
outside range [-32,768, 32,767]
2025-09-10 brettos@google.com Revert "SkNamedTransferFn: Change kRec709
to match ITU-R BT.1886 pure 2.4 gamma"
2025-09-10 lukasza@chromium.org [rust png] ToCToU: Don't mutate
`fReader` after checking PLTE presence.
2025-09-10 kjlubick@google.com Remove references to fractional ints
2025-09-10 kjlubick@google.com Clean up matrixProc functions
2025-09-10 lukasza@chromium.org [rust png] Support calling
`SkPngRustDecoder::Decode` with null result.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,codefu@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-10 21:08:46 +00:00
engine-flutter-autoroll
0fc2653eeb
Roll Dart SDK from f446144fb7c9 to 1de2289e49fe (3 revisions) (#175192)
https://dart.googlesource.com/sdk.git/+log/f446144fb7c9..1de2289e49fe

2025-09-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-187.0.dev
2025-09-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-186.0.dev
2025-09-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-185.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC codefu@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-10 18:33:11 +00:00
engine-flutter-autoroll
10c1f2867d
Roll Skia from c3a3d1e47699 to 55c9d697da52 (4 revisions) (#175190)
https://skia.googlesource.com/skia.git/+log/c3a3d1e47699..55c9d697da52

2025-09-10 mike@reedtribe.org Migrate sites from SkTLazy to
std::optional
2025-09-10 briansalomon@gmail.com Move BC1 compression utility from
Ganesh to shared GPU tool code
2025-09-10 mike@reedtribe.org Use helper for checking optional
2025-09-10 ccameron@chromium.org SkStream: Add big-endian integer
reading helpers

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,codefu@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-10 18:27:10 +00:00
engine-flutter-autoroll
760a7f0da8
Roll Packages from 2d651b2103cd to 03598e7797cf (5 revisions) (#175185)
2d651b2103...03598e7797

2025-09-10 stuartmorgan@google.com [url_launcher] Temporarily restore
Android 21 support (flutter/packages#9986)
2025-09-10 engine-flutter-autoroll@skia.org Roll Flutter from
973320c0270b to a0820964d59c (17 revisions) (flutter/packages#9983)
2025-09-09 stuartmorgan@google.com [various] Scrub pre-Android-API <24
code (flutter/packages#9851)
2025-09-09 stuartmorgan@google.com [google_sign_in] Add a platform
interface method to clear auth tokens (flutter/packages#9929)
2025-09-09 stuartmorgan@google.com Revert "[url_launcher] fix: Link
widget Tab traversal" (flutter/packages#9980)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-10 15:49:23 +00:00
engine-flutter-autoroll
06c6571999
Roll Skia from 36f3c3fbec19 to c3a3d1e47699 (2 revisions) (#175181)
https://skia.googlesource.com/skia.git/+log/36f3c3fbec19..c3a3d1e47699

2025-09-10 briansalomon@gmail.com rm unused tools/gpu/FenchSync.h file
2025-09-10 syoussefi@google.com [graphite][vulkan] Use
VK_EXT_host_image_copy

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,codefu@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-10 14:57:29 +00:00
Flutter GitHub Bot
5920aaf66c
Marks Linux plugin_test_android_standard to be unflaky (#175163)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux plugin_test_android_standard"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20plugin_test_android_standard%22).
This test can be marked as unflaky.

Co-authored-by: stuartmorgan-g <stuartmorgan@google.com>
2025-09-10 13:04:43 +00:00
engine-flutter-autoroll
0306047493
Roll Skia from 97497ee065e4 to 36f3c3fbec19 (5 revisions) (#175178)
https://skia.googlesource.com/skia.git/+log/97497ee065e4..36f3c3fbec19

2025-09-10 ccameron@chromium.org SkNamedTransferFn: Change kRec709 to
match ITU-R BT.1886 pure 2.4 gamma
2025-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 823c60bcd4de to 7e8698436266 (4 revisions)
2025-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from faec59c14d69 to 90bb0f2095e9 (2 revisions)
2025-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 5189c201ee9c to 29f14166cead (14 revisions)
2025-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 57b81f6717e0 to 6b1e4d74700b (204 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,codefu@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-10 12:52:10 +00:00
Flutter GitHub Bot
930d6f4d40
Marks Windows plugin_test_android_variants to be unflaky (#175167)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows plugin_test_android_variants"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20plugin_test_android_variants%22).
This test can be marked as unflaky.

Co-authored-by: stuartmorgan-g <stuartmorgan@google.com>
2025-09-10 12:07:08 +00:00
Flutter GitHub Bot
6c4894bb41
Marks Linux plugin_test_android_variants to be unflaky (#175162)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux plugin_test_android_variants"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20plugin_test_android_variants%22).
This test can be marked as unflaky.

Co-authored-by: stuartmorgan-g <stuartmorgan@google.com>
2025-09-10 12:03:27 +00:00
Flutter GitHub Bot
8b0f1f2e17
Marks Windows plugin_test_android_standard to be unflaky (#175168)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows plugin_test_android_standard"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20plugin_test_android_standard%22).
This test can be marked as unflaky.
2025-09-10 11:36:11 +00:00
Flutter GitHub Bot
4d54ce1bdf
Marks Mac plugin_test_android_standard to be unflaky (#175166)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac plugin_test_android_standard"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac%20plugin_test_android_standard%22).
This test can be marked as unflaky.
2025-09-10 11:00:40 +00:00
Flutter GitHub Bot
e5c0a3cf39
Marks Mac plugin_test_android_variants to be unflaky (#175165)
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac plugin_test_android_variants"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac%20plugin_test_android_variants%22).
This test can be marked as unflaky.
2025-09-10 10:59:06 +00:00
Matej Knopp
6fc3eefcf6
[shell] Fix engineId not being set after hot restart (#174451)
Fixes #173474

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-09-10 09:19:14 +00:00
engine-flutter-autoroll
be077d02aa
Roll Skia from 6acb8b29b60e to 97497ee065e4 (1 revision) (#175152)
https://skia.googlesource.com/skia.git/+log/6acb8b29b60e..97497ee065e4

2025-09-10
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,codefu@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-10 06:23:16 +00:00
engine-flutter-autoroll
bff9a7ea66
Roll Skia from 127786500ad0 to 6acb8b29b60e (1 revision) (#175148)
https://skia.googlesource.com/skia.git/+log/127786500ad0..6acb8b29b60e

2025-09-10
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,codefu@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-10 04:11:28 +00:00
engine-flutter-autoroll
4534e73480
Roll Skia from 04513dfdf517 to 127786500ad0 (2 revisions) (#175145)
https://skia.googlesource.com/skia.git/+log/04513dfdf517..127786500ad0

2025-09-10 mike@reedtribe.org Change GrShape::asPath() to return a path
2025-09-09 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
ANGLE from 6888dfb1826d to 823c60bcd4de (34 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,codefu@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-10 01:49:27 +00:00
engine-flutter-autoroll
202df8d567
Roll Fuchsia Linux SDK from m7Qmvj5wtfPlMA8i8... to 10x-JGF5zuuW8ik4K... (#175140)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC codefu@google.com,zra@google.com on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-09 23:18:27 +00:00
engine-flutter-autoroll
fe7703376c
Roll Skia from 416b3b42ece2 to 04513dfdf517 (5 revisions) (#175137)
https://skia.googlesource.com/skia.git/+log/416b3b42ece2..04513dfdf517

2025-09-09 mike@reedtribe.org Fold direction into convexity enum
2025-09-09 robertphillips@google.com Reland "[graphite] Add a
non-threaded PipelineManager"
2025-09-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 0022e4eac4b2 to faec59c14d69 (4 revisions)
2025-09-09 mike@reedtribe.org Migrate SkTLazy usage to std::optional
2025-09-09 briansalomon@gmail.com Mac viewer builds with bazel

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,codefu@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-09 20:27:22 +00:00
engine-flutter-autoroll
fbbc797a6a
Roll Skia from 19ba56dde579 to 416b3b42ece2 (1 revision) (#175134)
https://skia.googlesource.com/skia.git/+log/19ba56dde579..416b3b42ece2

2025-09-09 mike@reedtribe.org Remove drawing element that has undefined
behavior

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,codefu@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-09 18:08:19 +00:00
Victor Sanni
53f8432312
Adjust default CupertinoCheckbox size on desktop (#172502)
Fixes [CupertinoCheckbox padding on MacOS is excessive, is applying iOS
standards](https://github.com/flutter/flutter/issues/165140)
2025-09-09 17:04:56 +00:00
engine-flutter-autoroll
a0820964d5
Roll Packages from 24588c6be4fc to 2d651b2103cd (2 revisions) (#175130)
24588c6be4...2d651b2103

2025-09-08 pedromassango.developer@gmail.com [url_launcher] fix: Link
widget Tab traversal (flutter/packages#9815)
2025-09-08 engine-flutter-autoroll@skia.org Roll Flutter from
87d5b753196c to 973320c0270b (25 revisions) (flutter/packages#9977)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-09 15:47:28 +00:00
engine-flutter-autoroll
ecb9ec2d9d
Roll Skia from ab13fd19dd32 to 19ba56dde579 (2 revisions) (#175127)
https://skia.googlesource.com/skia.git/+log/ab13fd19dd32..19ba56dde579

2025-09-09 lukasza@chromium.org [rust png] Smaller, frame-sized
`fPreblendBuffer` for interlaced images.
2025-09-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 14f87286123a to 3877515497c0 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brettos@google.com,codefu@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-09 15:23:20 +00:00
engine-flutter-autoroll
4277a18e13
Roll Skia from 29a015f8712b to ab13fd19dd32 (2 revisions) (#175108)
https://skia.googlesource.com/skia.git/+log/29a015f8712b..ab13fd19dd32

2025-09-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 7e45e468cf42 to 5189c201ee9c (21 revisions)
2025-09-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from af8c2ea541d3 to 0022e4eac4b2 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brettos@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-09 07:17:28 +00:00
engine-flutter-autoroll
b271eb0c91
Roll Skia from 6a4613b83365 to 29a015f8712b (5 revisions) (#175106)
https://skia.googlesource.com/skia.git/+log/6a4613b83365..29a015f8712b

2025-09-09
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-09-08
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-09-08
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-09-08 thomsmit@google.com Revert "[graphite] Extracts early in
drawGeometry"
2025-09-08 robertphillips@google.com Revert "[graphite] Add a
non-threaded PipelineManager"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brettos@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-09 03:13:29 +00:00
engine-flutter-autoroll
7a27d16b4d
Roll Dart SDK from 7b645442db0f to f446144fb7c9 (2 revisions) (#175104)
https://dart.googlesource.com/sdk.git/+log/7b645442db0f..f446144fb7c9

2025-09-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-184.0.dev
2025-09-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-183.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-09 02:47:27 +00:00
Victor Sanni
d328555151
Nav bar static components respect ambient MediaQueryData (#174673)
Fixes [CupertinoSlidingSegmentedControl in CupertinoNavigationBar
renders incorrectly in dark brightness (starting
3.35.0)](https://github.com/flutter/flutter/issues/174642)
Fixes [[Cupertino] MediaQuery.of(context) returns Size(0,0) inside
CupertinoNavigationBar trailing since Flutter
3.35](https://github.com/flutter/flutter/issues/174771#top)

Bug was introduced in [CupertinoSliverNavigationBar respects
accessibility text
scaling](https://github.com/flutter/flutter/pull/168866)

See
https://github.com/flutter/flutter/issues/174642#issuecomment-3235042874
2025-09-08 22:34:25 +00:00
Mohellebi abdessalem
22c8ecd38c
fix typo in test documentation #2 (#174707)
simular to #174292

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-09-08 21:59:18 +00:00
Jason Simmons
d2215194e3
Update ImageReaderSurfaceProducer.MAX_IMAGES to include the maximum number of retained dequeued images (#174971)
MAX_IMAGES was set to 5 by
7a58dac0b1
in order to fix "client tried to acquire more than maxImages buffers"
warnings from ImageReader_JNI.


696251d25a
then converted lastDequeuedImage into a queue that retains up to
MAX_DEQUEUED_IMAGES in-flight images plus the latest dequeued image.
MAX_DEQUEUED_IMAGES was set to 2, but MAX_IMAGES was only incremented by
1. So the ImageReader_JNI warning may reappear in some cases.

This PR ensures that MAX_IMAGES provides enough capacity in the
ImageReader for the total number of images that may be in use.
2025-09-08 21:40:32 +00:00
dependabot[bot]
7f111dd7e7
Bump actions/labeler from 5.0.0 to 6.0.1 in the all-github-actions group (#175093)
Bumps the all-github-actions group with 1 update:
[actions/labeler](https://github.com/actions/labeler).

Updates `actions/labeler` from 5.0.0 to 6.0.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/actions/labeler/releases">actions/labeler's
releases</a>.</em></p>
<blockquote>
<h2>v6.0.1</h2>
<h2>What's Changed</h2>
<ul>
<li>Upgrade publish-action from 0.2.2 to 0.4.0 by <a
href="https://github.com/aparnajyothi-y"><code>@​aparnajyothi-y</code></a>
in <a
href="https://redirect.github.com/actions/labeler/pull/901">actions/labeler#901</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a
href="https://github.com/aparnajyothi-y"><code>@​aparnajyothi-y</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/labeler/pull/901">actions/labeler#901</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/labeler/compare/v6.0.0...v6.0.1">https://github.com/actions/labeler/compare/v6.0.0...v6.0.1</a></p>
<h2>v6.0.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Add workflow file for publishing releases to immutable action
package by <a
href="https://github.com/jcambass"><code>@​jcambass</code></a> in <a
href="https://redirect.github.com/actions/labeler/pull/802">actions/labeler#802</a></li>
</ul>
<h3>Breaking Changes</h3>
<ul>
<li>Upgrade Node.js version to 24 in action and dependencies <a
href="https://github.com/salmanmkc"><code>@​salmanmkc</code></a> in <a
href="https://redirect.github.com/actions/labeler/pull/891">actions/labeler#891</a>
Make sure your runner is on version v2.327.1 or later to ensure
compatibility with this release. <a
href="https://github.com/actions/runner/releases/tag/v2.327.1">Release
Notes</a></li>
</ul>
<h3>Dependency Upgrades</h3>
<ul>
<li>Upgrade eslint-config-prettier from 9.0.0 to 9.1.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/actions/labeler/pull/711">actions/labeler#711</a></li>
<li>Upgrade eslint from 8.52.0 to 8.55.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/actions/labeler/pull/720">actions/labeler#720</a></li>
<li>Upgrade <code>@​types/jest</code> from 29.5.6 to 29.5.11 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/actions/labeler/pull/719">actions/labeler#719</a></li>
<li>Upgrade <code>@​types/js-yaml</code> from 4.0.8 to 4.0.9 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/actions/labeler/pull/718">actions/labeler#718</a></li>
<li>Upgrade <code>@​typescript-eslint/parser</code> from 6.9.0 to 6.14.0
by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/actions/labeler/pull/717">actions/labeler#717</a></li>
<li>Upgrade prettier from 3.0.3 to 3.1.1 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/actions/labeler/pull/726">actions/labeler#726</a></li>
<li>Upgrade eslint from 8.55.0 to 8.56.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/actions/labeler/pull/725">actions/labeler#725</a></li>
<li>Upgrade <code>@​typescript-eslint/parser</code> from 6.14.0 to
6.19.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/actions/labeler/pull/745">actions/labeler#745</a></li>
<li>Upgrade eslint-plugin-jest from 27.4.3 to 27.6.3 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/actions/labeler/pull/744">actions/labeler#744</a></li>
<li>Upgrade <code>@​typescript-eslint/eslint-plugin</code> from 6.9.0 to
6.20.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/actions/labeler/pull/750">actions/labeler#750</a></li>
<li>Upgrade prettier from 3.1.1 to 3.2.5 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/actions/labeler/pull/752">actions/labeler#752</a></li>
<li>Upgrade undici from 5.26.5 to 5.28.3 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/actions/labeler/pull/757">actions/labeler#757</a></li>
<li>Upgrade braces from 3.0.2 to 3.0.3 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/actions/labeler/pull/789">actions/labeler#789</a></li>
<li>Upgrade minimatch from 9.0.3 to 10.0.1 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/actions/labeler/pull/805">actions/labeler#805</a></li>
<li>Upgrade <code>@​actions/core</code> from 1.10.1 to 1.11.1 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/actions/labeler/pull/811">actions/labeler#811</a></li>
<li>Upgrade typescript from 5.4.3 to 5.7.2 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/actions/labeler/pull/819">actions/labeler#819</a></li>
<li>Upgrade <code>@​typescript-eslint/parser</code> from 7.3.1 to 8.17.0
by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/actions/labeler/pull/824">actions/labeler#824</a></li>
<li>Upgrade prettier from 3.2.5 to 3.4.2 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/actions/labeler/pull/825">actions/labeler#825</a></li>
<li>Upgrade <code>@​types/jest</code> from 29.5.12 to 29.5.14 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/actions/labeler/pull/827">actions/labeler#827</a></li>
<li>Upgrade eslint-plugin-jest from 27.9.0 to 28.9.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/actions/labeler/pull/832">actions/labeler#832</a></li>
<li>Upgrade ts-jest from 29.1.2 to 29.2.5 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/actions/labeler/pull/831">actions/labeler#831</a></li>
<li>Upgrade <code>@​vercel/ncc</code> from 0.38.1 to 0.38.3 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/actions/labeler/pull/830">actions/labeler#830</a></li>
<li>Upgrade typescript from 5.7.2 to 5.7.3 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/actions/labeler/pull/835">actions/labeler#835</a></li>
<li>Upgrade eslint-plugin-jest from 28.9.0 to 28.11.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/actions/labeler/pull/839">actions/labeler#839</a></li>
<li>Upgrade undici from 5.28.4 to 5.28.5 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/actions/labeler/pull/842">actions/labeler#842</a></li>
<li>Upgrade <code>@​octokit/request-error</code> from 5.0.1 to 5.1.1 by
<a
href="https://github.com/dependabot"><code>@​dependabot</code></a>[bot]
in <a
href="https://redirect.github.com/actions/labeler/pull/846">actions/labeler#846</a></li>
</ul>
<h3>Documentation changes</h3>
<ul>
<li>Add note regarding <code>pull_request_target</code> to README.md by
<a href="https://github.com/silverwind"><code>@​silverwind</code></a> in
<a
href="https://redirect.github.com/actions/labeler/pull/669">actions/labeler#669</a></li>
<li>Update readme with additional examples and important note about
<code>pull_request_target</code> event by <a
href="https://github.com/IvanZosimov"><code>@​IvanZosimov</code></a> in
<a
href="https://redirect.github.com/actions/labeler/pull/721">actions/labeler#721</a></li>
<li>Document update - permission section by <a
href="https://github.com/harithavattikuti"><code>@​harithavattikuti</code></a>
in <a
href="https://redirect.github.com/actions/labeler/pull/840">actions/labeler#840</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="634933edcd"><code>634933e</code></a>
publish-action upgrade to 0.4.0 from 0.2.2 (<a
href="https://redirect.github.com/actions/labeler/issues/901">#901</a>)</li>
<li><a
href="f1a63e87db"><code>f1a63e8</code></a>
Update Node.js version to 24 in action and dependencies (<a
href="https://redirect.github.com/actions/labeler/issues/891">#891</a>)</li>
<li><a
href="b0a1180683"><code>b0a1180</code></a>
Bump <code>@​octokit/request-error</code> from 5.0.1 to 5.1.1 (<a
href="https://redirect.github.com/actions/labeler/issues/846">#846</a>)</li>
<li><a
href="110d44140c"><code>110d441</code></a>
Update README.md (<a
href="https://redirect.github.com/actions/labeler/issues/871">#871</a>)</li>
<li><a
href="bee50fefe1"><code>bee50fe</code></a>
Bump undici from 5.28.4 to 5.28.5 (<a
href="https://redirect.github.com/actions/labeler/issues/842">#842</a>)</li>
<li><a
href="6463cdb00e"><code>6463cdb</code></a>
Bump eslint-plugin-jest from 28.9.0 to 28.11.0 (<a
href="https://redirect.github.com/actions/labeler/issues/839">#839</a>)</li>
<li><a
href="c209686724"><code>c209686</code></a>
Bump typescript from 5.7.2 to 5.7.3 (<a
href="https://redirect.github.com/actions/labeler/issues/835">#835</a>)</li>
<li><a
href="5184940b54"><code>5184940</code></a>
Bump <code>@​vercel/ncc</code> from 0.38.1 to 0.38.3 (<a
href="https://redirect.github.com/actions/labeler/issues/830">#830</a>)</li>
<li><a
href="3629d5568b"><code>3629d55</code></a>
Document update - permission section (<a
href="https://redirect.github.com/actions/labeler/issues/840">#840</a>)</li>
<li><a
href="d24f7f3731"><code>d24f7f3</code></a>
Bump ts-jest from 29.1.2 to 29.2.5 (<a
href="https://redirect.github.com/actions/labeler/issues/831">#831</a>)</li>
<li>Additional commits viewable in <a
href="8558fd7429...634933edcd">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/labeler&package-manager=github_actions&previous-version=5.0.0&new-version=6.0.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-09-08 21:29:23 +00:00
engine-flutter-autoroll
4a66542a57
Roll Skia from 25f00cb247f2 to 6a4613b83365 (3 revisions) (#175087)
https://skia.googlesource.com/skia.git/+log/25f00cb247f2..6a4613b83365

2025-09-08 syoussefi@google.com [vulkan] Fix threading issues with VMA
in tests
2025-09-08 robertphillips@google.com [graphite] Add a non-threaded
PipelineManager
2025-09-08 mike@reedtribe.org Silence unuseful printfs in tests

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brettos@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-08 20:37:14 +00:00
engine-flutter-autoroll
e3cff0235b
Roll Dart SDK from 83c6b6124380 to 7b645442db0f (1 revision) (#175086)
https://dart.googlesource.com/sdk.git/+log/83c6b6124380..7b645442db0f

2025-09-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-182.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-08 20:27:37 +00:00
Oreofe Solarin
b01f4a5447
Impeller: Convert GLProc name field and GLErrorToString to std::string_view (#173771)
This PR improves the OpenGL error handling and procedure table interface
in the Impeller renderer by changing `const char*` to `std::string_view`
for better memory safety.

### Testing:

Added unit tests to cover `GLErrorToString` return values and
`string_view` behavior

### Issues Fixed #135922

This PR addresses technical debt by improving string handling in the
OpenGL backend, and type safety without breaking existing functionality.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-09-08 19:59:20 +00:00