flutter-zl
b53b07cf7c
Fix AppBar web accessibility: prevent more items announcements
2025-10-03 13:43:29 -07:00
engine-flutter-autoroll
5c0c9e9e9a
Roll Packages from 5fd5f74dce46 to e401aeb3aae4 (4 revisions) ( #176466 )
...
5fd5f74dce...e401aeb3aaengine-flutter-autoroll@skia.org Roll Flutter from
7811e8982355 to 65aca3661b8f (12 revisions) (flutter/packages#10161 )
2025-10-02 34327253+lenzpaul@users.noreply.github.com [Camera] Add lens
type information (iOS) (flutter/packages#7653 )
2025-10-02 mohellebiabdessalem@gmail.com [webview_flutter] updates build
files to use JVM 17 (flutter/packages#10129 )
2025-10-02 mohellebiabdessalem@gmail.com [shared_preferences] updates
build files to use JVM 17 (flutter/packages#10131 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-03 15:49:25 +00:00
engine-flutter-autoroll
dca709fbbf
Roll Dart SDK from fdd90f38d6a0 to 0009748aed50 (3 revisions) ( #176461 )
...
https://dart.googlesource.com/sdk.git/+log/fdd90f38d6a0..0009748aed50
2025-10-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-278.0.dev
2025-10-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-277.0.dev
2025-10-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-276.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-03 15:23:22 +00:00
engine-flutter-autoroll
5bc7a9c130
Roll Skia from f86ae4113254 to b842026480e0 (3 revisions) ( #176458 )
...
https://skia.googlesource.com/skia.git/+log/f86ae4113254..b842026480e0
2025-10-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 7994bf76d7a9 to 62b00f866364 (11 revisions)
2025-10-03
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-10-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from 8d4953412be2 to 228c951bd699 (11 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-03 13:15:43 +00:00
engine-flutter-autoroll
018897e3f1
Roll Skia from 1720a85a507e to f86ae4113254 (1 revision) ( #176443 )
...
https://skia.googlesource.com/skia.git/+log/1720a85a507e..f86ae4113254
2025-10-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 603a5155599a to 01940842b667 (22 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-03 07:22:28 +00:00
engine-flutter-autoroll
a319676090
Roll Fuchsia Linux SDK from Vnoygds8HtDUvGLCK... to HUhTcRn-LUXa2Salu... ( #176442 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-03 06:46:34 +00:00
engine-flutter-autoroll
ddbc920ace
Roll Skia from cf339ab390c2 to 1720a85a507e (4 revisions) ( #176439 )
...
https://skia.googlesource.com/skia.git/+log/cf339ab390c2..1720a85a507e
2025-10-03
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-10-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 3964dd7c126b to 7bc87a4a45cf (7 revisions)
2025-10-02
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-10-02 kjlubick@google.com Add tests for SkSGMerge
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-03 02:15:32 +00:00
engine-flutter-autoroll
02c902e929
Roll Dart SDK from 4f90a06328cb to fdd90f38d6a0 (7 revisions) ( #176431 )
...
https://dart.googlesource.com/sdk.git/+log/4f90a06328cb..fdd90f38d6a0
2025-10-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-275.0.dev
2025-10-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-274.0.dev
2025-10-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-273.0.dev
2025-10-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-272.0.dev
2025-10-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-271.0.dev
2025-10-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-270.0.dev
2025-10-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-269.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-03 01:09:12 +00:00
engine-flutter-autoroll
db0e809831
Roll Skia from 05c1f5803415 to cf339ab390c2 (11 revisions) ( #176426 )
...
https://skia.googlesource.com/skia.git/+log/05c1f5803415..cf339ab390c2
2025-10-02 michaelludwig@google.com Make SkAlignTo templated; optimize
SkAlignNonPow2
2025-10-02
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-10-02 thomsmit@google.com [graphite] Add drawContext pointer to
task dumping
2025-10-02 mike@reedtribe.org use pathbuilder or factories, rather than
mutate SkPath
2025-10-02 kjlubick@google.com Update pixmap asserts to identify
negative values explicitly
2025-10-02
louhi-prod-1-6316342352543744@louhi-prod-1.iam.gserviceaccount.com
Update fiddler-base for 020ae52af0e7
2025-10-02 fmalita@google.com Reset convexity in SkPathBuilder::addPath
2025-10-02 bungeman@google.com Use Skia's ninja when building viewer
with gradle
2025-10-02 borenet@google.com Add Louhi service account to AUTHORS
2025-10-02 mike@reedtribe.org Remove friend pathref hacking
2025-10-02 lukasza@chromium.org [rust png] Copy `EncodePngAsSkData` from
Chromium into Skia.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-02 21:48:43 +00:00
Victoria Ashworth
76776081c6
Add deeplinking for UIScene migration ( #176303 )
...
When an iOS app migrates to UIScene, the application events for handling
deeplinks are no longer called by UIKit. Instead, scene events in the
SceneDelegate must be used. This PR adds support for handling deeplinks
in UIScene while still maintaining support for unmigrated apps, as well.
Fixes https://github.com/flutter/flutter/issues/174403 .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-10-02 20:22:25 +00:00
Slava Egorov
c9f10779f4
Upgrade packages ( #176411 )
...
Changes to the Dart IO require picking up newer version of
`package:watcher`.
2025-10-02 18:01:21 +00:00
Qun Cheng
17e2120be8
Update localization from translation console ( #176324 )
...
Regular import of latest translations.
Some .arb files(cupertino_ko.arb, and material_it.arb) are overwritten
again and will cause translation issues. See comment
https://github.com/flutter/flutter/pull/166496#issuecomment-2773987516 .
I manually reverted them back.
This PR doesn't run the date_localization script.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-10-02 17:38:15 +00:00
jesswrd
f58eada931
Update Framework CI to Use NDK r28c ( #176214 )
...
Updating Framework CI to use new SDK revision containing NDK r28c. Have
to update the flutter.ndkVersion constant in this PR as well otherwise
there will be a mismatch in versions.
Partially Addresses https://github.com/flutter/flutter/issues/175022
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-10-02 17:02:09 +00:00
Mayank Patke
d938e306f5
Remove references to dart:js_util ( #176323 )
...
Flutter has been migrated from dart:js_util (which is unsupported by
dart2wasm) to dart:js_interop, so we can remove/migrate all the
remaining references to js_util.
2025-10-02 16:09:00 +00:00
engine-flutter-autoroll
d674abf522
Roll Packages from 321a5846838d to 5fd5f74dce46 (6 revisions) ( #176409 )
...
321a584683...5fd5f74dcemohellebiabdessalem@gmail.com [url_launcher] updates build
files to use JVM 17 (flutter/packages#10130 )
2025-10-02 mohellebiabdessalem@gmail.com [quick_actions] updates build
files to use JVM 17 (flutter/packages#10132 )
2025-10-01 engine-flutter-autoroll@skia.org Manual roll Flutter from
c9608e28d01a to 7811e8982355 (22 revisions) (flutter/packages#10160 )
2025-10-01 fishythefish@users.noreply.github.com [google_sign_in] Remove
references to dart:js_util (flutter/packages#10148 )
2025-10-01 stuartmorgan@google.com [ci] Re-enable all Android legacy
emulator tests (flutter/packages#10141 )
2025-10-01 engine-flutter-autoroll@skia.org Manual roll Flutter from
96fe3b3df509 to c9608e28d01a (26 revisions) (flutter/packages#10145 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-02 16:03:41 +00:00
Matthew Kosarek
de64eed980
Windowing integration tests now await change futures if a changes is expected + commenting our erroneous icon in Runner.rc for win32 ( #176312 )
...
## What's new?
- Update `Runner.rc` to not include the icon file, as this is what the
other integration tests do
- Await change notifications on the controller when necessary
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-10-02 15:37:33 +00:00
Kate Lovett
1c15d39b18
Fix platform specific semantics for time picker buttons ( #176373 )
...
Updated from https://github.com/flutter/flutter/pull/173418
Fixes https://github.com/flutter/flutter/issues/173302
Applied review feedback and modified for time licker refactor that
landed somewhere in between.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-10-02 15:32:09 +00:00
engine-flutter-autoroll
65aca3661b
Roll Skia from 257c1f94afaa to 05c1f5803415 (4 revisions) ( #176402 )
...
https://skia.googlesource.com/skia.git/+log/257c1f94afaa..05c1f5803415
2025-10-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 29b917fb5921 to 3964dd7c126b (4 revisions)
2025-10-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from ae02c3292a95 to 7994bf76d7a9 (8 revisions)
2025-10-02
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-10-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from a3b8ecf9f94a to 8d4953412be2 (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-02 13:44:27 +00:00
Ben Konyi
f35a2875ae
[ Widget Preview ] Fix resolution for workspace "hosted" dependencies ( #176358 )
...
Projects within the same workspace can depend on each other without
explicitly specifying path dependencies or dependency overrides using
the following syntax:
```
dependencies:
my_workspace_project: # No constraint or path
```
This is treated as a "hosted" dependency, which conflicts with the path
dependencies used by the widget_preview_scaffold.
This change introduces dependency_overrides for each package in the
workspace watched by the widget previewer to allow for dependencies to
be resolved correctly.
Fixes https://github.com/flutter/flutter/issues/176018
2025-10-02 11:13:41 +00:00
engine-flutter-autoroll
9b91dabb99
Roll Skia from b5d8ae8d3410 to 257c1f94afaa (6 revisions) ( #176389 )
...
https://skia.googlesource.com/skia.git/+log/b5d8ae8d3410..257c1f94afaa
2025-10-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from cd3a5de0811f to 603a5155599a (14 revisions)
2025-10-01 kjlubick@google.com Make SkPathPriv::Raw handle SkPaths with
infinite bounds correctly
2025-10-01 kjlubick@google.com Reapply "Reapply "Use pathbuilder or
factories to keep path immutable""
2025-10-01 robertphillips@google.com [graphite] Make use of
PipelineCreateCacheControl in Vulkan
2025-10-01 mike@reedtribe.org Update tests to use pathbuilder
2025-10-01 jmbetancourt@google.com [skcapture] add capture callbacks for
SkSurface
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-02 07:35:21 +00:00
Jim Graham
b77acbf30b
Delete Skia-specific performance overlay implementation ( #176364 )
...
(Essentially a re-issue of
https://github.com/flutter/flutter/pull/174682 which ended up with
broken Google Testing links)
We had 2 different implementations of the rendering code for the
performance overlay layer. The skia version used some skia-specific code
to render the overlay incrementally into an offscreen surface and so we
created a different implementation for Impeller that only uses standard
rendering calls (and no surface cache). It turns out that the Impeller
version was faster anyway even on Skia so it is a simple change to
delete the old code and always use the new visualizer.
The new visualizer reduces the time to render the graph from just under
1ms to about .1ms on Skia.
The new visualizer takes .1ms longer to compute on the UI thread, but
overall we save time between the 2 threads.
The new visualizer is much faster on Impeller.
Some work could be done to save some of that time on the UI thread by
only incrementally updating the graph data, but for now we can take the
~.8-.9ms savings with just some deleted code.
2025-10-02 07:11:39 +00:00
engine-flutter-autoroll
2bf5da46a5
Roll Fuchsia Linux SDK from 1Ai6VL4vb_GdGnWhg... to Vnoygds8HtDUvGLCK... ( #176381 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-02 04:24:31 +00:00
Ben Konyi
23a9ce38af
[ Widget Preview ] Persist "Filter by Selected File" toggle ( #176289 )
...
This change introduces `PersistentPreferences`, which allows for the
widget previewer to save settings to disk.
`PersistentPreferences` makes use of the existing `~/.flutter-devtools`
directory used by DevTools for the same purpose, writing preferences in
JSON format to `~/.flutter-devtools/.widget-preview`.
2025-10-01 22:39:09 +00:00
engine-flutter-autoroll
c1764c14d8
Roll Skia from c44a36470d07 to b5d8ae8d3410 (5 revisions) ( #176367 )
...
https://skia.googlesource.com/skia.git/+log/c44a36470d07..b5d8ae8d3410
2025-10-01 kjlubick@google.com Revert "Reapply "Use pathbuilder or
factories to keep path immutable""
2025-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 9023de589c86 to 29b917fb5921 (3 revisions)
2025-10-01 mike@reedtribe.org Remove unused mutable-path parameter
2025-10-01 robertphillips@google.com [graphite] Add
SupportsPipelineCreationCacheControl bool to VulkanCaps
2025-10-01 nicolettep@google.com Only enable shader precision modifier
usage for ganesh/GL
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-01 22:37:23 +00:00
chunhtai
a3eba8eab2
Reapply "Update the AccessibilityPlugin::Announce method to account f… ( #176107 )
...
…… (#174365 )"
This reverts commit 5e146d47a61098e5ed967352812bcbbe0fe24f20.
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
straight reland, previous pr was reverted because g3fix is outdated
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-10-01 22:34:09 +00:00
engine-flutter-autoroll
d0a688425d
Roll Dart SDK from 8ffec1435cf3 to 4f90a06328cb (3 revisions) ( #176369 )
...
https://dart.googlesource.com/sdk.git/+log/8ffec1435cf3..4f90a06328cb
2025-10-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-268.0.dev
2025-10-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-267.0.dev
2025-10-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-266.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-01 21:11:39 +00:00
Ben Konyi
40f013a0e9
[ Tool / l10n ] Fix issue where localization generator assumed current directory was the target project ( #175881 )
...
When running `flutter pub get` from the root of a Pub workspace,
localizations are generated for each subproject. However, we were trying
to write the untranslated messages file relative to the current
directory, not the target project's directory.
This change updates the logic for determining the output location of the
untranslated messages file to include the target project root.
Fixes https://github.com/flutter/flutter/issues/174205
2025-10-01 20:04:07 +00:00
Ahmed Mohamed Sameh
7ceee3b074
Make sure that a DateRangePickerDialog doesn't crash in 0x0 environments ( #173754 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the
DateRangePickerDialog UI control.
2025-10-01 19:01:57 +00:00
Ahmed Mohamed Sameh
4f49888a06
Make sure that a DrawerButton doesn't crash in 0x0 environment ( #172948 )
...
This is my attempt to handle
https://github.com/flutter/flutter/issues/6537 for the DrawerButton UI
control.
2025-10-01 19:01:57 +00:00
Valentin Vignal
7811e89823
Migrate to WidgetStateTextStyle ( #176330 )
...
Follow up https://github.com/flutter/flutter/pull/176270
Migrate the remaining files from `MaterialStateTextStyle ` to
`WidgetStateTextStyle `. This PR only focus on `WidgetStateTextStyle`.
- This minimizes conflicts and reduces the size of the PR for easier
reviews and follow up
- I'll work on the other elements of
`packages/flutter/lib/src/material/material_state.dart` into other PRs
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-10-01 18:55:00 +00:00
Valentin Vignal
f973b2f13c
Migrate to WidgetStateOutlinedBorder ( #176270 )
...
Follow up https://github.com/flutter/flutter/pull/176164
Migrate the remaining files from `MaterialStateOutlinedBorder ` to
`WidgetStateOutlinedBorder `. This PR only focus on
`WidgetStateOutlinedBorder`.
- This minimizes conflicts and reduces the size of the PR for easier
reviews and follow up
- I'll work on the other elements of
`packages/flutter/lib/src/material/material_state.dart` into other PRs
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-10-01 18:54:58 +00:00
Matej Knopp
77a581a19e
[win32] Runloop should use high resolution timer and avoid deadlock ( #176023 )
...
Replaces `SetTimer`/`WM_TIMER` with a threadpool timer, which doesn't
suffer from 16ms granularity and changes the waking up mechanism to give
the run loop chance to process input messages before processing flutter
tasks.
- Fixes https://github.com/flutter/flutter/issues/173843
- Fixes https://github.com/flutter/flutter/issues/175135
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-10-01 17:19:14 +00:00
engine-flutter-autoroll
7519cfd251
Roll Packages from 287739d0acce to 321a5846838d (3 revisions) ( #176357 )
...
287739d0ac...321a584683stuartmorgan@google.com [local_auth] Adopt structured errors
- platform interface (flutter/packages#10023 )
2025-09-30 jessiewong401@gmail.com Revert hardcoded compilesdk back to
`flutter.compileSdkVersion` in `camera_android` (flutter/packages#9668 )
2025-09-30 mohellebiabdessalem@gmail.com [file_selector] updates build
files to use JVM 17 (flutter/packages#10097 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-01 15:44:18 +00:00
Victoria Ashworth
80496d7662
Add SwiftUI support for UIScene migration ( #176230 )
...
When embedding Flutter in a SwiftUI app, it appears that SwiftUI wraps
the scene delegate given by the developer in an internal class called
`SwiftUI.AppSceneDelegate`. This causes the scene delegate to fail to
check if it conforms to the `FlutterSceneLifeCycleProvider` protocol -
even though it does. However, after force casting it, selectors respond
and can be used.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-10-01 14:24:37 +00:00
engine-flutter-autoroll
72eec03e86
Roll Skia from ecaff95f51aa to c44a36470d07 (4 revisions) ( #176336 )
...
https://skia.googlesource.com/skia.git/+log/ecaff95f51aa..c44a36470d07
2025-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 81cda6698311 to ae02c3292a95 (9 revisions)
2025-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from c2dcfa0865c5 to cd3a5de0811f (31 revisions)
2025-10-01
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from e521bec27829 to a3b8ecf9f94a (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-01 09:41:27 +00:00
Daco Harkes
c33437606c
[native assets] Enable build hooks and code assets on stable ( #176285 )
...
Dart CL enabling for next stable:
* https://dart-review.googlesource.com/c/sdk/+/449803
Tests:
* All existing tests for the feature on the other channels.
2025-10-01 09:20:05 +00:00
Daco Harkes
dc3ad9d246
[native assets] Roll dependencies ( #176287 )
...
Rolling the dependencies to the latest versions.
Tests: All existing tests of build hooks and code assets.
2025-10-01 09:18:11 +00:00
engine-flutter-autoroll
2822801b96
Roll Dart SDK from 527333cfe4cf to 8ffec1435cf3 (1 revision) ( #176334 )
...
https://dart.googlesource.com/sdk.git/+log/527333cfe4cf..8ffec1435cf3
2025-10-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-265.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-01 07:38:38 +00:00
engine-flutter-autoroll
d5d3ffa384
Roll Skia from 6998b06397c5 to ecaff95f51aa (1 revision) ( #176333 )
...
https://skia.googlesource.com/skia.git/+log/6998b06397c5..ecaff95f51aa
2025-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
SwiftShader from 5f1c459a11bb to 18d4f3db9407 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-01 07:24:28 +00:00
Krzysztof Świętnicki
bb07841a70
Update description in _LastFinderMixin to properly describe finding last ( #174232 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
*Replace this paragraph with a description of what this PR is changing
or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one
issue. An issue is not required if the PR fixes something trivial like a
typo.*
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
2025-10-01 05:36:19 +00:00
engine-flutter-autoroll
674aa2b8af
Roll Skia from b242cc09488d to 6998b06397c5 (2 revisions) ( #176331 )
...
https://skia.googlesource.com/skia.git/+log/b242cc09488d..6998b06397c5
2025-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 02470a3c2773 to 9023de589c86 (6 revisions)
2025-10-01
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-01 04:50:27 +00:00
engine-flutter-autoroll
231b6dd578
Roll Dart SDK from af31d2637b6b to 527333cfe4cf (17 revisions) ( #176325 )
...
https://dart.googlesource.com/sdk.git/+log/af31d2637b6b..527333cfe4cf
2025-10-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-264.0.dev
2025-09-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-263.0.dev
2025-09-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-262.0.dev
2025-09-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-261.0.dev
2025-09-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-260.0.dev
2025-09-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-259.0.dev
2025-09-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-258.0.dev
2025-09-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-257.0.dev
2025-09-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-256.0.dev
2025-09-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-255.0.dev
2025-09-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-254.0.dev
2025-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-253.0.dev
2025-09-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-252.0.dev
2025-09-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-251.0.dev
2025-09-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-250.0.dev
2025-09-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-249.0.dev
2025-09-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.10.0-248.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC dart-vm-team@google.com ,jimgraham@google.com on the revert to
ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-10-01 02:21:11 +00:00
Konstantin Scheglov
495342fa96
Stop using deprecated analyzer 7.x.y APIs. ( #176242 )
...
Preparation for landing
https://dart-review.googlesource.com/c/sdk/+/443460
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-10-01 01:25:35 +00:00
Victor Sanni
b719a6c799
Fix docs referencing deprecated radio properties ( #176244 )
...
Docs change to CupertinoRadio and RadioListTile. No tests required.
2025-10-01 01:03:40 +00:00
engine-flutter-autoroll
d4e5754790
Roll Skia from bb3b6bd4be0d to b242cc09488d (22 revisions) ( #176320 )
...
https://skia.googlesource.com/skia.git/+log/bb3b6bd4be0d..b242cc09488d
2025-09-30 briansalomon@gmail.com Fix unused var in
gm/imagemakewithfilter.cpp
2025-09-30 nbilling@google.com [graphite] Use correct reuse policy on
mtl/vk graphite buffers.
2025-09-30 sharaks@google.com Merge 6 release notes into
RELEASE_NOTES.md
2025-09-30 sharaks@google.com Update Skia milestone to 143
2025-09-30
recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
Roll recipe dependencies (trivial).
2025-09-30 briansalomon@gmail.com Viewer builds with Graphite but not
Ganesh
2025-09-30 mike@reedtribe.org Add new Encode() variant to _none impls
2025-09-30 robertphillips@google.com [graphite] Make use of
ThreadSafeResourceProvider
2025-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from c18184683c0b to 02470a3c2773 (1 revision)
2025-09-30 mike@reedtribe.org Reorganize SkDraw::drawPath() to keep
SkPath immutable
2025-09-30 bungeman@google.com [pdf] Remove no longer needed #undefs
2025-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 7a7681cc8f88 to 81cda6698311 (9 revisions)
2025-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from d930194b7928 to c2dcfa0865c5 (20 revisions)
2025-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia
Infra from ed3dfff05a5e to e521bec27829 (5 revisions)
2025-09-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from a9e2ca3b57ab to c18184683c0b (7 revisions)
2025-09-29 mike@reedtribe.org compare utility for paths
2025-09-29 mike@reedtribe.org Add new Encode api to NDK variants
2025-09-29 mike@reedtribe.org Reapply "Use pathbuilder or factories to
keep path immutable"
2025-09-29 jsimmons@google.com Apply font variation arguments to system
default fonts and character lookup fallback fonts in SkParagraph's
FontCollection
2025-09-29 mike@reedtribe.org Harden our conic math for bad W values
2025-09-29 robertphillips@google.com [graphite] Add a
ThreadSafeResourceProvider
2025-09-29 mike@reedtribe.org Unify most common form of encoders:
returning SkData
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jimgraham@google.com ,kjlubick@google.com,maxhudnell@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-30 23:55:54 +00:00
engine-flutter-autoroll
be81070e63
Roll Fuchsia Linux SDK from rcOl0yxJb4znJ903Y... to 1Ai6VL4vb_GdGnWhg... ( #176315 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC jimgraham@google.com ,zra@google.com on the revert to ensure
that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2025-09-30 23:44:17 +00:00
chunhtai
f86835076b
Adds dart ui API for setting application level locale ( #175100 )
...
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
part of https://github.com/flutter/flutter/issues/99600
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-09-30 23:42:02 +00:00
Mohellebi abdessalem
a2c1b383ce
replace onPop usage with onPopWithResult in navigation_bar.2.dart ( #174841 )
...
replace the usage of `onPop ` with `onPopWithResult ` to solve the
analyzerr warning
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-09-30 23:40:06 +00:00
Ben Konyi
37487b3e4c
[ Widget Preview ] Forward Widget Inspector navigation events via DTD ( #176218 )
...
With the assumption that IDEs will not create a debug session for the
widget previewer, the widget inspector's source navigation functionality
won't function as there's no IDE to listen to `navigate` events sent via
`postEvent`.
This change overrides some widget inspector behavior to allow for
navigating to source locations via the DTD Editor service instead of
relying on the VM service's `postEvent`.
This change also makes some minor changes to the diagnostic properties
and descriptions displayed within the inspector to display group and
custom preview annotation details.
Towards https://github.com/flutter/flutter/issues/166423
2025-09-30 23:36:56 +00:00
Victoria Ashworth
7c5e70191f
Add verbose logs to module_uiscene_test_ios ( #176306 )
...
Debugging why
https://ci.chromium.org/ui/p/flutter/builders/staging/Mac%20module_uiscene_test_ios
is failing.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code ).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-09-30 23:36:54 +00:00
