DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove duplicated key in _IconButtonM3 (#105577)

Browse Source
This commit is contained in:
cedvdb 2022-06-10 20:38:10 +02:00 committed by GitHub
parent e09c1325ce
commit feec13a168
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter/lib/src/material/icon_button.dart
View File

@ -497,7 +497,6 @@ class IconButton extends StatelessWidget {
);
}
return _IconButtonM3(
key: key,
style: adjustedStyle,
onPressed: onPressed,
autofocus: autofocus,
@ -577,7 +576,6 @@ class IconButton extends StatelessWidget {
class _IconButtonM3 extends ButtonStyleButton {
const _IconButtonM3({
super.key,
required super.onPressed,
super.style,
super.focusNode,

16
packages/flutter/test/material/icon_button_test.dart
View File

@ -28,6 +28,22 @@ void main() {
mockOnPressedFunction = MockOnPressedFunction();
});
testWidgets('test icon is findable by key', (WidgetTester tester) async {
const ValueKey<String> key = ValueKey<String>('icon-button');
await tester.pumpWidget(
wrap(
useMaterial3: true,
child: IconButton(
key: key,
onPressed: () {},
icon: const Icon(Icons.link),
),
),
);
expect(find.byKey(key), findsOneWidget);
});
testWidgets('test default icon buttons are sized up to 48', (WidgetTester tester) async {
final bool material3 = theme.useMaterial3;
await tester.pumpWidget(