From feec13a1684b2f3b56e4702ef585d990f37eff56 Mon Sep 17 00:00:00 2001 From: cedvdb Date: Fri, 10 Jun 2022 20:38:10 +0200 Subject: [PATCH] Remove duplicated key in _IconButtonM3 (#105577) --- .../flutter/lib/src/material/icon_button.dart | 2 -- .../flutter/test/material/icon_button_test.dart | 16 ++++++++++++++++ 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/packages/flutter/lib/src/material/icon_button.dart b/packages/flutter/lib/src/material/icon_button.dart index 2e67fd182a5..ea8614d948f 100644 --- a/packages/flutter/lib/src/material/icon_button.dart +++ b/packages/flutter/lib/src/material/icon_button.dart @@ -497,7 +497,6 @@ class IconButton extends StatelessWidget { ); } return _IconButtonM3( - key: key, style: adjustedStyle, onPressed: onPressed, autofocus: autofocus, @@ -577,7 +576,6 @@ class IconButton extends StatelessWidget { class _IconButtonM3 extends ButtonStyleButton { const _IconButtonM3({ - super.key, required super.onPressed, super.style, super.focusNode, diff --git a/packages/flutter/test/material/icon_button_test.dart b/packages/flutter/test/material/icon_button_test.dart index 9f1d6ccfd19..ae0354dd0af 100644 --- a/packages/flutter/test/material/icon_button_test.dart +++ b/packages/flutter/test/material/icon_button_test.dart @@ -28,6 +28,22 @@ void main() { mockOnPressedFunction = MockOnPressedFunction(); }); + testWidgets('test icon is findable by key', (WidgetTester tester) async { + const ValueKey key = ValueKey('icon-button'); + await tester.pumpWidget( + wrap( + useMaterial3: true, + child: IconButton( + key: key, + onPressed: () {}, + icon: const Icon(Icons.link), + ), + ), + ); + + expect(find.byKey(key), findsOneWidget); + }); + testWidgets('test default icon buttons are sized up to 48', (WidgetTester tester) async { final bool material3 = theme.useMaterial3; await tester.pumpWidget(