DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Update Process.exitCode setter to not use @override (#7434)

Browse Source 
As of Dart SDK 1.22.0-dev.5.0, `Process.exitCode` is no longer
mutable (that SDK version picks up e5a16b1ca5).
This change allows the tools code to pass analysis in sdk versions both
before and after that change, to allow for analysis against both the host and
target sdks.
This commit is contained in:
Todd Volkert 2017-01-10 21:33:04 -08:00 committed by GitHub
parent 2ee04c92bf
commit a0666f330e
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/flutter_tools/lib/src/base/process_manager.dart
View File

@ -491,8 +491,10 @@ class _RecordingProcess implements Process {
@override
Future<int> get exitCode => delegate.exitCode;
@override
set exitCode(Future<int> exitCode) => delegate.exitCode = exitCode;
// TODO(tvolkert): Remove this once the dart sdk in both the target and
// the host have picked up dart-lang/sdk@e5a16b1
@override // ignore: OVERRIDE_ON_NON_OVERRIDING_SETTER
set exitCode(Future<int> exitCode) => throw new UnsupportedError('set exitCode');
@override
Stream<List<int>> get stdout {
@ -827,7 +829,9 @@ class _ReplayProcess implements Process {
@override
Future<int> get exitCode => _exitCodeCompleter.future;
@override
// TODO(tvolkert): Remove this once the dart sdk in both the target and
// the host have picked up dart-lang/sdk@e5a16b1
@override // ignore: OVERRIDE_ON_NON_OVERRIDING_SETTER
set exitCode(Future<int> exitCode) => throw new UnsupportedError('set exitCode');
@override