From a0666f330ece29b33b5e71dec0874a7fc6bf59d8 Mon Sep 17 00:00:00 2001 From: Todd Volkert Date: Tue, 10 Jan 2017 21:33:04 -0800 Subject: [PATCH] Update Process.exitCode setter to not use @override (#7434) As of Dart SDK 1.22.0-dev.5.0, `Process.exitCode` is no longer mutable (that SDK version picks up https://github.com/dart-lang/sdk/commit/e5a16b1ca56414af3008afb8833660f95a9d06da). This change allows the tools code to pass analysis in sdk versions both before and after that change, to allow for analysis against both the host and target sdks. --- .../flutter_tools/lib/src/base/process_manager.dart | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/flutter_tools/lib/src/base/process_manager.dart b/packages/flutter_tools/lib/src/base/process_manager.dart index 3fd8a1b18b2..3c66aacadb6 100644 --- a/packages/flutter_tools/lib/src/base/process_manager.dart +++ b/packages/flutter_tools/lib/src/base/process_manager.dart @@ -491,8 +491,10 @@ class _RecordingProcess implements Process { @override Future get exitCode => delegate.exitCode; - @override - set exitCode(Future exitCode) => delegate.exitCode = exitCode; + // TODO(tvolkert): Remove this once the dart sdk in both the target and + // the host have picked up dart-lang/sdk@e5a16b1 + @override // ignore: OVERRIDE_ON_NON_OVERRIDING_SETTER + set exitCode(Future exitCode) => throw new UnsupportedError('set exitCode'); @override Stream> get stdout { @@ -827,7 +829,9 @@ class _ReplayProcess implements Process { @override Future get exitCode => _exitCodeCompleter.future; - @override + // TODO(tvolkert): Remove this once the dart sdk in both the target and + // the host have picked up dart-lang/sdk@e5a16b1 + @override // ignore: OVERRIDE_ON_NON_OVERRIDING_SETTER set exitCode(Future exitCode) => throw new UnsupportedError('set exitCode'); @override