Add missing virtual destructors to virtual classes (flutter/engine#4083)

These were previously undetected because Wdelete-non-virtual-dtor
didn't work with std::unique_ptr, but that's no longer the case.
This commit is contained in:
Petr Hosek 2017-09-09 14:01:31 -07:00 committed by GitHub
parent ad88f5b2aa
commit 4bee84e385
3 changed files with 6 additions and 0 deletions

View File

@ -15,6 +15,8 @@ namespace flow {
/// can choose to provide this information however.
class ProcessInfo {
public:
virtual ~ProcessInfo() = default;
virtual bool SampleNow() = 0;
/// Virtual memory size in bytes.

View File

@ -46,6 +46,8 @@ class SceneUpdateContext {
class SurfaceProducer {
public:
virtual ~SurfaceProducer() = default;
virtual std::unique_ptr<SurfaceProducerSurface> ProduceSurface(
const SkISize& size) = 0;

View File

@ -14,6 +14,8 @@ namespace vulkan {
class VulkanNativeSurface {
public:
virtual ~VulkanNativeSurface() = default;
virtual const char* GetExtensionName() const = 0;
virtual uint32_t GetSkiaExtensionName() const = 0;