From 4bee84e3857c9c035d13d18faef84ab01d52fb3b Mon Sep 17 00:00:00 2001
From: Petr Hosek <petrhosek@users.noreply.github.com>
Date: Sat, 9 Sep 2017 14:01:31 -0700
Subject: [PATCH] Add missing virtual destructors to virtual classes
 (flutter/engine#4083)

These were previously undetected because Wdelete-non-virtual-dtor
didn't work with std::unique_ptr, but that's no longer the case.
---
 engine/src/flutter/flow/process_info.h            | 2 ++
 engine/src/flutter/flow/scene_update_context.h    | 2 ++
 engine/src/flutter/vulkan/vulkan_native_surface.h | 2 ++
 3 files changed, 6 insertions(+)

diff --git a/engine/src/flutter/flow/process_info.h b/engine/src/flutter/flow/process_info.h
index e009c6a0426..25d25125f50 100644
--- a/engine/src/flutter/flow/process_info.h
+++ b/engine/src/flutter/flow/process_info.h
@@ -15,6 +15,8 @@ namespace flow {
 /// can choose to provide this information however.
 class ProcessInfo {
  public:
+  virtual ~ProcessInfo() = default;
+
   virtual bool SampleNow() = 0;
 
   /// Virtual memory size in bytes.
diff --git a/engine/src/flutter/flow/scene_update_context.h b/engine/src/flutter/flow/scene_update_context.h
index ed9e9b1b52b..627f3159d8d 100644
--- a/engine/src/flutter/flow/scene_update_context.h
+++ b/engine/src/flutter/flow/scene_update_context.h
@@ -46,6 +46,8 @@ class SceneUpdateContext {
 
   class SurfaceProducer {
    public:
+    virtual ~SurfaceProducer() = default;
+
     virtual std::unique_ptr<SurfaceProducerSurface> ProduceSurface(
         const SkISize& size) = 0;
 
diff --git a/engine/src/flutter/vulkan/vulkan_native_surface.h b/engine/src/flutter/vulkan/vulkan_native_surface.h
index a1142ddc8f1..a8f0fb85528 100644
--- a/engine/src/flutter/vulkan/vulkan_native_surface.h
+++ b/engine/src/flutter/vulkan/vulkan_native_surface.h
@@ -14,6 +14,8 @@ namespace vulkan {
 
 class VulkanNativeSurface {
  public:
+  virtual ~VulkanNativeSurface() = default;
+
   virtual const char* GetExtensionName() const = 0;
 
   virtual uint32_t GetSkiaExtensionName() const = 0;